Re: [Qemu-devel] [PATCH 4/7] RTC: Update the RTC clock only when reading it

2012-07-23 Thread Paolo Bonzini
Il 23/07/2012 07:17, Juan Quintela ha scritto: > Paolo Bonzini wrote: >> From: "Zhang, Yang Z" >> >> Calculate guest RTC based on the time of the last update, instead of >> using timers. The formula is >> >> (base_rtc + guest_time_now - guest_time_last_update + offset) >> >> Base_rtc is the

Re: [Qemu-devel] [PATCH] ide scsi: Mess with geometry only for hard disk devices

2012-07-23 Thread Markus Armbruster
Ping? Markus Armbruster writes: > Legacy -drive cyls=... are now ignored completely when the drive > doesn't back a hard disk device. Before, they were first checked > against a hard disk's limits, then ignored. > > Signed-off-by: Markus Armbruster > --- > hw/ide/qdev.c |3 ++- > hw/scsi

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-07-23 Thread Benjamin Herrenschmidt
On Mon, 2012-07-23 at 16:40 +1000, Benjamin Herrenschmidt wrote: > > Note to Matthew: cirrusdrmfb is a LOT SLOWER than offb for a similar > SW only dumb framebuffer, probably has to do with the way it does the > "dirty" stuff, not sure ... > > Why not draw directly into the emulated vram ? More

Re: [Qemu-devel] [PATCH 7/7] RTC: Allow to migrate from old QEMU

2012-07-23 Thread Paolo Bonzini
Il 23/07/2012 07:12, Juan Quintela ha scritto: > .fields = (VMStateField []) { > VMSTATE_BUFFER(cmos_data, RTCState), > VMSTATE_UINT8(cmos_index, RTCState), > VMSTATE_INT32(current_tm.tm_sec, RTCState), > VMSTATE_INT32(current_tm.tm_min, RTCState), >

Re: [Qemu-devel] [PATCH v2] MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this.

2012-07-23 Thread Igor Mammedov
Hello Gleb, Is this v2 patch more acceptable then v1?

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

2012-07-23 Thread Igor Mammedov
ping. On 06/25/2012 03:55 PM, Igor Mammedov wrote: v2: - drop usage of prev_debug_excp_handler consistently in all users - split from reset patches to avoid confusion of inter-dependency Compile & Run tested: target-i386: tcg and kvm mode i386-linux-user: running of /bin/ls Compile

Re: [Qemu-devel] [PATCH v2] MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this.

2012-07-23 Thread Gleb Natapov
On Mon, Jul 23, 2012 at 09:44:05AM +0200, Igor Mammedov wrote: > Hello Gleb, > > Is this v2 patch more acceptable then v1? Yes. Sorry for not being explicit about it :) -- Gleb.

Re: [Qemu-devel] [RFC PATCH 2/2] block: gluster as block backend

2012-07-23 Thread Bharata B Rao
On Sun, Jul 22, 2012 at 04:38:00PM +0100, Stefan Hajnoczi wrote: > On Sat, Jul 21, 2012 at 9:31 AM, Bharata B Rao > wrote: > > +typedef struct GlusterAIOCB { > > +BlockDriverAIOCB common; > > +QEMUIOVector *qiov; > > The qiov field is unused. > > > +char *bounce; > > Unused. Yes, r

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread Bharata B Rao
On Sun, Jul 22, 2012 at 03:42:28PM +0100, Stefan Hajnoczi wrote: > On Sat, Jul 21, 2012 at 9:29 AM, Bharata B Rao > wrote: > > -drive file=gluster:server@port:volname:image > > > > - Here 'gluster' is the protocol. > > - 'server@port' specifies the server where the volume file specification for >

Re: [Qemu-devel] [RFC seabios PATCH] enumerate APIC IDs directly from CPUs

2012-07-23 Thread Gleb Natapov
On Thu, Jul 19, 2012 at 04:46:35PM -0300, Eduardo Habkost wrote: > On Thu, Jul 19, 2012 at 11:28:54AM -0300, Eduardo Habkost wrote: > > On Thu, Jul 19, 2012 at 12:58:46PM +0300, Gleb Natapov wrote: > > > On Tue, Jul 17, 2012 at 06:56:30PM -0300, Eduardo Habkost wrote: > > > > This patch is an attem

Re: [Qemu-devel] [RFC PATCH 2/2] block: gluster as block backend

2012-07-23 Thread Stefan Hajnoczi
On Mon, Jul 23, 2012 at 9:32 AM, Bharata B Rao wrote: > On Sun, Jul 22, 2012 at 04:38:00PM +0100, Stefan Hajnoczi wrote: >> On Sat, Jul 21, 2012 at 9:31 AM, Bharata B Rao >> wrote: >> > +} GlusterAIOCB; >> > + >> > +typedef struct GlusterCBKData { >> > +GlusterAIOCB *acb; >> > +struct BDR

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread Daniel P. Berrange
On Sat, Jul 21, 2012 at 01:59:17PM +0530, Bharata B Rao wrote: > Hi, > > Here is the v2 patchset for supporting GlusterFS protocol from QEMU. > > This set of patches enables QEMU to boot VM images from gluster volumes. > This is achieved by adding gluster as a new block backend driver in QEMU. >

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread Stefan Hajnoczi
On Mon, Jul 23, 2012 at 9:50 AM, Bharata B Rao wrote: > On Sun, Jul 22, 2012 at 03:42:28PM +0100, Stefan Hajnoczi wrote: >> On Sat, Jul 21, 2012 at 9:29 AM, Bharata B Rao >> wrote: >> > -drive file=gluster:server@port:volname:image >> > >> > - Here 'gluster' is the protocol. >> > - 'server@port'

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread ronnie sahlberg
Why not use -drive file=gluster://server[:port]/volname/image A great many protocols today use the form ://:]/ so this would make it consistent with a lot of other naming schemes out there, and imho make the url more intuitive. FTP looks like this : ftp://user:password@host:port/path NFS lo

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread ronnie sahlberg
Stefan, in iscsi, i just specify those extra arguments that are required that are not part of the url itself as just command line options : qemu-system-i386 -iscsi initiator-name=iqn.qemu.test:my-initiator \ -boot d -drive file=iscsi://127.0.0.1/iqn.qemu.test/1 \ -cdrom iscsi://127.0.0.

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread Stefan Hajnoczi
On Mon, Jul 23, 2012 at 10:34 AM, ronnie sahlberg wrote: > in iscsi, i just specify those extra arguments that are required that > are not part of the url itself as just command line options : > > > qemu-system-i386 -iscsi initiator-name=iqn.qemu.test:my-initiator \ > -boot d -drive file=iscs

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread Vijay Bellur
On 07/23/2012 02:20 PM, Bharata B Rao wrote: 2. It is currently not possible to bypass RPC because the glusterd managed configuration file doesn't support that. It is possible. Gluster already supports custom extensions to volume names and it is possible to use the required volfile by specif

Re: [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running.

2012-07-23 Thread Stefan Hajnoczi
On Fri, Jul 20, 2012 at 8:32 PM, wrote: > From: Benoît Canet > > Signed-off-by: Benoit Canet > --- > migration.c |5 + > 1 file changed, 5 insertions(+) > > diff --git a/migration.c b/migration.c > index 8db1b43..dfce680 100644 > --- a/migration.c > +++ b/migration.c > @@ -425,6 +425,1

Re: [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed.

2012-07-23 Thread Paolo Bonzini
Il 20/07/2012 21:32, benoit.ca...@gmail.com ha scritto: > +bool bdrv_have_block_jobs(void) > +{ > +BlockDriverState *bs; > + > +QTAILQ_FOREACH(bs, &bdrv_states, list) { > +if (bs->job || bdrv_in_use(bs)) { > +return true; > +} > +bdrv_close(bs); Why clos

Re: [Qemu-devel] [PATCH] ide scsi: Mess with geometry only for hard disk devices

2012-07-23 Thread Paolo Bonzini
Il 23/07/2012 09:25, Markus Armbruster ha scritto: > Ping? > > Markus Armbruster writes: > >> Legacy -drive cyls=... are now ignored completely when the drive >> doesn't back a hard disk device. Before, they were first checked >> against a hard disk's limits, then ignored. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running.

2012-07-23 Thread Benoît Canet
Would int bdrv_are_busy(void) { BlockDriverState *bs; QTAILQ_FOREACH(bs, &bdrv_states, list) { if (bs->job || bdrv_in_use(bs)) { return -EBUSY; } } return 0; } be more acceptable ? Benoît Le Monday 23 Jul 2012 à 10:55:41 (+0100), Stefan Hajnoczi a é

Re: [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed.

2012-07-23 Thread Benoît Canet
> Why close the device here? Thanks Benoît

Re: [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running.

2012-07-23 Thread Stefan Hajnoczi
On Mon, Jul 23, 2012 at 11:17 AM, Benoît Canet wrote: > Would > > int bdrv_are_busy(void) > { > BlockDriverState *bs; > > QTAILQ_FOREACH(bs, &bdrv_states, list) { > if (bs->job || bdrv_in_use(bs)) { > return -EBUSY; > } > } > > return 0; > } > > be more

[Qemu-devel] [PATCH] pc: Fix max_cpus

2012-07-23 Thread riegamaths
From: Dunrong Huang The VCPU count limit in kernel now is 254, defined by KVM_MAX_VCPUS in kernel's header files. But the count limit in QEMU is 255, so QEMU will failed to start if user passes "-enable-kvm" and "-smp 255" to it. This patch intruduces a Macro MAX_VCPUS whose value is KVM_MAX_VCP

Re: [Qemu-devel] [PATCH] pc: Fix max_cpus

2012-07-23 Thread Andreas Färber
Am 23.07.2012 12:47, schrieb riegama...@gmail.com: > From: Dunrong Huang > > The VCPU count limit in kernel now is 254, defined by KVM_MAX_VCPUS > in kernel's header files. But the count limit in QEMU is 255, > so QEMU will failed to start if user passes "-enable-kvm" and "-smp 255" > to it. > >

Re: [Qemu-devel] Qemu-devel Digest, Vol 112, Issue 522

2012-07-23 Thread Paulo Arcinas
On Jul 23, 2012 5:36 PM, wrote: > Send Qemu-devel mailing list submissions to > qemu-devel@nongnu.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.nongnu.org/mailman/listinfo/qemu-devel > or, via email, send a message with subject or body 'help' to

Re: [Qemu-devel] Qemu-devel Digest, Vol 112, Issue 523

2012-07-23 Thread Paulo Arcinas
On Jul 23, 2012 6:47 PM, wrote: > > Send Qemu-devel mailing list submissions to > qemu-devel@nongnu.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.nongnu.org/mailman/listinfo/qemu-devel > or, via email, send a message with subject or body 'help' t

Re: [Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-23 Thread Maksim Kozlov
20.07.2012 18:32, Peter Maydell пишет: On 12 July 2012 17:54, Maksim Kozlov wrote: Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 40 +--- 1 files changed, 33 insertions(+), 7 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c i

Re: [Qemu-devel] [PATCH v2] MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this.

2012-07-23 Thread Andreas Färber
Am 12.07.2012 15:22, schrieb Igor Mammedov: > This patch: > - moves decision to designate BSP from board into cpu, making cpu > self-sufficient in this regard. Later it will allow to cleanup hw/pc.c > and remove cpu_reset and wrappers from there. > - stores flag that CPU is BSP in IA32_APIC_BASE

Re: [Qemu-devel] [PATCH 2/6] s390: sclp base support

2012-07-23 Thread Christian Borntraeger
Andreas, thanks for having a look. I no other comments arrive today I will resubmit the patch set with all comments addressed. On 20/07/12 16:06, Andreas Färber wrote: >> +#ifdef DEBUG_HELPER >> +printf("KVM: invalid sclp call 0x%x / 0x%" PRIx64 "x\n", sccb, >> code); > > sccb is a po

Re: [Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-23 Thread Peter Maydell
On 23 July 2012 12:01, Maksim Kozlov wrote: > 20.07.2012 18:32, Peter Maydell пишет: >> This patch seems to be trying to make a distinction that QEMU doesn't >> support, ie between system wide "software reset" and system wide >> "hard reset". I'm not convinced about the wisdom of trying to paper >

Re: [Qemu-devel] [Bug 992067] Re: Windows 2008R2 very slow cold boot when >4GB memory

2012-07-23 Thread Owen Tuz
We have been experiencing this problem for a while now too, using qemu-kvm (currently at 1.1.1). Unfortunately, hv_relaxed doesn't seem to fix it. The following command line produces the issue: qemu-kvm -nodefaults -m 4096 -smp 8 -cpu host,hv_relaxed -vga cirrus -usbdevice tablet -vnc :99 -mo

[Qemu-devel] [PATCH V2 0/3] Block migration when streaming block jobs are running

2012-07-23 Thread benoit . canet
From: Benoît Canet This patchset is designed to avoid starting a live migration while one or more streaming block jobs are running. Tested with the following sequence: QEMU 1.1.50 monitor - type 'help' for more information (qemu) block_stream virtio0 1k (qemu) migrate tcp:localhost: migrate:

[Qemu-devel] [PATCH V2 2/3] qerror: Add error telling that streaming blocks migration

2012-07-23 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 92c4eff..bcd74b7 100644 --- a/qerror.c +++ b/qerror.c @@ -283,6 +283,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH V2 1/3] block: Add bdrv_are_busy()

2012-07-23 Thread benoit . canet
From: Benoît Canet bdrv_are_busy will be used to check if any of the bs are in use or if one of them have a running block job. The first user will be qmp_migrate(). Signed-off-by: Benoit Canet --- block.c | 13 + block.h |2 ++ 2 files changed, 15 insertions(+) diff --git a

[Qemu-devel] [PATCH V2 3/3] migration: block migration when streaming block jobs are running.

2012-07-23 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- migration.c |5 + 1 file changed, 5 insertions(+) diff --git a/migration.c b/migration.c index 8db1b43..5196d7e 100644 --- a/migration.c +++ b/migration.c @@ -425,6 +425,11 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,

Re: [Qemu-devel] [PATCH V2 2/3] qerror: Add error telling that streaming blocks migration

2012-07-23 Thread Peter Maydell
On 23 July 2012 12:23, wrote: > --- a/qerror.c > +++ b/qerror.c > @@ -283,6 +283,10 @@ static const QErrorStringTable qerror_table[] = { > .desc = "Could not set password", > }, > { > +.error_fmt = QERR_STREAMING_BLOCKS_MIGRATION, > +.desc = "Streaming

[Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev.c | 14 +- vl.c |7 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index af54467..f1e83a4 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -502,6 +502,10 @@ static int qdev_get_fw_dev_path_help

Re: [Qemu-devel] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

2012-07-23 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 01:22:43PM -0300, Eduardo Habkost wrote: > On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote: > > On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: > > > When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the > > > MADT table too. > >

[Qemu-devel] [PATCH 1/2] usb: Clean common object and dependency files

2012-07-23 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ab82ef3..1b3882a 100644 --- a/Makefile +++ b/Makefile @@ -218,7 +218,7 @@ clean: rm -Rf .libs rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d bl

[Qemu-devel] [PATCH 2/2] qom: Clean libuser object and dependency files

2012-07-23 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 1b3882a..964e592 100644 --- a/Makefile +++ b/Makefile @@ -217,7 +217,7 @@ clean: rm -f *.o *.d *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *

[Qemu-devel] [PATCH 03/19] qapi: add test case for deallocating traversal of incomplete structure

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek v3: - new patch Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- tests/test-qmp-commands.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 60cbf01..dc

[Qemu-devel] [PATCH 04/19] qapi: generate C types for fixed-width integers

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek (Long line folded using parens: .) Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- scripts/qapi.py |4 1 file changed, 4 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index

[Qemu-devel] [PATCH 12/19] convert net_init_nic() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek v1->v2: - NetLegacyNicOptions::vectors is of type uint32 Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/net.c b/net.c index af544b2..a62e902

[Qemu-devel] [PATCH 09/19] qapi schema: add Netdev types

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek NetdevTapOptions::sndbuf and NetdevDumpOptions::len use the new "size" type. v1->v2: - NetLegacy::name is optional - NetLegacyNicOptions::vectors is of type uint32 - NetdevVdeOptions::port and ::mode are of type uint16 - NetLegacy::vlan has type int32 v2->v3: - NetLegacy::id

[Qemu-devel] [PATCH 18/19] convert net_init_bridge() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net/tap.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/net/tap.c b/net/tap.c index c5563c0..d2736ea 100644 --- a/net/tap.c +++ b/net/tap.c @@ -513,21 +513,22 @@

[Qemu-devel] [PATCH 13/19] convert net_init_dump() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek v1->v2: - NetdevDumpOptions::len is of type 'size', whose C type was changed to uint64_t. Adapt the printf() format specifier macro. Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net/dump.c | 21 + 1 file changed, 17 insertions(+), 4

[Qemu-devel] [PATCH 06/19] expose QemuOpt and QemuOpts struct definitions to interested parties

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek The only clients should be the existent "qemu-option.c", and the upcoming "qapi/opts-visitor.c". Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- qemu-option-internal.h | 53 qemu-option.c | 24 +---

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-23 Thread Lluís Vilanova
Stefan Hajnoczi writes: [...] >> > So I tried trimming down the list of files needed to compile >> > qemu tools, and here is a list: >> >> > Easy to relicense to LGPLv2+: >> > block/raw.c none (GPLv2+: Red Hat, IBM) >> > error.c LGPLv2 (Red Hat, IBM, Ste

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Cornelia Huck
On Sat, 21 Jul 2012 15:16:56 +0200 Jan Kiszka wrote: > On 2012-07-21 14:57, Peter Maydell wrote: > > On 21 July 2012 13:35, Jan Kiszka wrote: > >> On 2012-07-21 14:17, Peter Maydell wrote: > >>> You still haven't really explained why we can't just ignore irqfd > >>> for now. I don't see how it w

[Qemu-devel] [PULL 00/14] Migration next

2012-07-23 Thread Juan Quintela
Hi Anthony This series include the ram_save_live() split. XBZRLE patches got dropped until we fix a new bug. Please apply. Thanks, Juan. The following changes since commit 61dc008f3529fa74a63aad1907438dad857e255a: Revert "audio: Make PC speaker audio card available by default" (2012-07-19

[Qemu-devel] KVM call agenda for Tuesday, July 24

2012-07-23 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-23 Thread Paolo Bonzini
Il 23/07/2012 13:55, Lluís Vilanova ha scritto: >>> >> I have no problems relicensing to "GPLv2 or later" or "GPLv3 or later". >> > What about LGPLv2+? (Note the "L".) > I'd prefer to keep it non-lesser. Is it absolutely necessary? This is about making the block layer part of a library. The bloc

Re: [Qemu-devel] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID (0) on MADT table (v2)

2012-07-23 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 02:04:49PM -0300, Eduardo Habkost wrote: > When resetting an I/O APIC, its ID is set to 0, and SeaBIOS doesn't > change it, so report it correctly on the MADT table. > > Some hardware may require the BIOS to initialize I/O APIC ID to an > unique value, but SeaBIOS doesn't d

[Qemu-devel] [PATCH 07/19] qapi: introduce OptsVisitor

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek This visitor supports parsing -option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...] style QemuOpts objects into "native" C structures. After defining the type tree in the qapi schema (see below), a root type traversal with this visitor linked to the underlying Qe

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Avi Kivity
On 07/23/2012 03:04 PM, Cornelia Huck wrote: > > OK, so I was reading through this thread since I want to add irqfd > support for s390, but we don't have any kind of "irqchip". > > The understanding I got so far is that !s390 architectures have some > kind of mechanism that allows them to "route"

[Qemu-devel] [PATCH 02/19] qapi: fix error propagation

2012-07-23 Thread Stefan Hajnoczi
From: Paolo Bonzini Don't overwrite / leak previously set errors. Make traversal cope with missing mandatory sub-structs. Don't try to end a container that could not be started. v1->v2: - unchanged v2->v3: - instead of examining, assert that we never overwrite errors with error_set() - allow

Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-23 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 02:04:50PM -0300, Eduardo Habkost wrote: > Extract Local APIC IDs directly from the CPUs, and instead of check for > "i < CountCPUs", check if the APIC ID was present on boot, when building > ACPI tables and the MP-Table. > > This keeps ACPI Processor ID == APIC ID, but all

[Qemu-devel] [PULL 00/19] Net patches

2012-07-23 Thread Stefan Hajnoczi
The main piece is Laszlo's OptsVisitor and -net/-netdev parsing conversion. The following changes since commit 61dc008f3529fa74a63aad1907438dad857e255a: Revert "audio: Make PC speaker audio card available by default" (2012-07-19 18:25:52 -0500) are available in the git repository at: git:/

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Peter Maydell
On 23 July 2012 13:18, Avi Kivity wrote: > While you don't have an irqchip, you do have asynchronous interrupt > injection, yes? That's what irqchip really is all about. This seems an odd point of view -- async interrupt injection doesn't have anything to do with whether we're modelling the irq

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Avi Kivity
On 07/21/2012 11:54 AM, Peter Maydell wrote: > On 21 July 2012 07:57, Jan Kiszka wrote: >> On 2012-07-20 21:14, Peter Maydell wrote: >>> I'm sure this isn't the only x86ism in the KVM generic source >>> files. However the thing I'm specifically trying to do is >>> nuke all the uses of kvm_irqchip_

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Avi Kivity
On 07/23/2012 03:25 PM, Peter Maydell wrote: > On 23 July 2012 13:18, Avi Kivity wrote: >> While you don't have an irqchip, you do have asynchronous interrupt >> injection, yes? That's what irqchip really is all about. > > This seems an odd point of view -- async interrupt injection > doesn't h

[Qemu-devel] [PATCH 16/19] convert net_init_vde() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek v1->v2: - NetdevVdeOptions::port and ::mode are of type uint16. Remove superfluous range checks. Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net/vde.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/net/vde.c b/n

Re: [Qemu-devel] [PATCH] pc: Fix max_cpus

2012-07-23 Thread Dunrong Huang
2012/7/23 Andreas Färber : > Am 23.07.2012 12:47, schrieb riegama...@gmail.com: >> From: Dunrong Huang >> >> The VCPU count limit in kernel now is 254, defined by KVM_MAX_VCPUS >> in kernel's header files. But the count limit in QEMU is 255, >> so QEMU will failed to start if user passes "-enable-

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Avi Kivity
On 07/23/2012 03:31 PM, Avi Kivity wrote: > On 07/23/2012 03:25 PM, Peter Maydell wrote: >> On 23 July 2012 13:18, Avi Kivity wrote: >>> While you don't have an irqchip, you do have asynchronous interrupt >>> injection, yes? That's what irqchip really is all about. >> >> This seems an odd point

[Qemu-devel] [PATCH 11/19] convert net_client_init() to OptsVisitor

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek The net_client_init() prototype is kept intact. Based on "is_netdev", the QemuOpts-rooted QemuOpt-list is parsed as a Netdev or a NetLegacy. The original meat of net_client_init() is moved to and simplified in net_client_init1(): Fields not common between -net and -netdev are

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Peter Maydell
On 23 July 2012 12:33, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek I think it would be much nicer to just rewrite qdev_get_fw_dev_path so we weren't trying to fill the path into a fixed string buffer at all. Here is an entirely untested implementation: char *qdev_get_fw_dev_path(DeviceS

[Qemu-devel] [PATCH 19/19] remove unused QemuOpts parameter from net init functions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek v1->v2: - unchanged v2->v3: - keep "qemu-option.h" included in "net/slirp.h" Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net.c | 14 ++ net/dump.c |4 ++-- net/dump.h |5 ++--- net/slirp.c |4 ++-- net/sl

[Qemu-devel] [PATCH 10/19] hw, net: "net_client_type" -> "NetClientOptionsKind" (qapi-generated)

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek NET_CLIENT_TYPE_ -> NET_CLIENT_OPTIONS_KIND_ Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- hw/cadence_gem.c|2 +- hw/dp8393x.c|2 +- hw/e1000.c |2 +- hw/eepro100.c |2 +- hw/etraxfs_eth.c|

[Qemu-devel] [PATCH v5 0/3] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-07-23 Thread Wanpeng Li
This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series are: 1) Things like -m and -bios-name are now device model properties 2) The i440fx and piix3 are now modelled in a thorough fashion 3) i440fx_init is trivialized

[Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM

2012-07-23 Thread Wanpeng Li
From: Anthony Liguori makes pci_host a proper QOM type. Changelog: * against Andreas pci_host branch * make host bridge TypeInfos const * use PCI_HOST_BRIDGE() where appropriate Signed-off-by: Anthony Liguori Signed-off-by: Wanpeng Li --- hw/i440fx.c |6 +++--- hw/pc.c |2 +

[Qemu-devel] [PATCH v5 2/3] merge pc_piix.c to pc.c

2012-07-23 Thread Wanpeng Li
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Wanpeng Li --- hw/i386/Makefile.objs |1 - hw/pc.c | 695 + hw/pc.h | 46 +--- hw/pc_piix.c | 661 --

[Qemu-devel] [PATCH v5 1/3] eliminate piix_pci.c and module i440fx and piix3

2012-07-23 Thread Wanpeng Li
From: Anthony Liguori The big picture about the patch is shown as follows: 1) pc_init creates an I440FX, any bus devices (ISA serial port, PCI vga and nics, etc.), sets properties appropriately, and realizes the devices. 2) I440FX is-a PCIHost, has-a I440FX-PMC, has-a PIIX3 3) PIIX3 has-

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Peter Maydell
On 23 July 2012 13:34, Peter Maydell wrote: > On 23 July 2012 12:33, Laszlo Ersek wrote: >> >> Signed-off-by: Laszlo Ersek > > I think it would be much nicer to just rewrite qdev_get_fw_dev_path > so we weren't trying to fill the path into a fixed string buffer > at all. Here is an entirely unte

[Qemu-devel] [PATCH 08/19] qapi schema: remove trailing whitespace

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- qapi-schema.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..d2f8e02 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@

Re: [Qemu-devel] [PATCH 01/16] net: Add a hub net client

2012-07-23 Thread Laszlo Ersek
Two hairs to split: On 07/20/12 14:01, Stefan Hajnoczi wrote: > +static NetHubPort *net_hub_port_new(NetHub *hub, const char *name) > +{ > +VLANClientState *nc; > +NetHubPort *port; > +unsigned int id = hub->num_ports++; There are projects that don't like to put logic or externally v

[Qemu-devel] [PATCH 14/19] convert net_init_slirp() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net/slirp.c | 93 --- 1 file changed, 25 insertions(+), 68 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 1243d43..44b059f 100644 --- a/net/sl

[Qemu-devel] [PATCH 05/19] qapi: introduce "size" type

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek v1->v2: - fall back to uint64 rather than int Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- qapi/qapi-visit-core.c |7 +++ qapi/qapi-visit-core.h |3 +++ scripts/qapi.py|2 ++ 3 files changed, 12 insertions(+) diff --git a/qapi/qapi

[Qemu-devel] [PATCH 01/19] MAINTAINERS: Replace net maintainer Mark McLoughlin with Stefan Hajnoczi

2012-07-23 Thread Stefan Hajnoczi
The net subsystem has lacked an active maintainer since 2009. I have built and tested a net-next tree to get the ball rolling again. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 30ed56d..2

Re: [Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM

2012-07-23 Thread Andreas Färber
Am 23.07.2012 14:35, schrieb Wanpeng Li: > From: Anthony Liguori > > makes pci_host a proper QOM type. > > Changelog: > * against Andreas pci_host branch > * make host bridge TypeInfos const > * use PCI_HOST_BRIDGE() where appropriate > > Signed-off-by: Anthony Liguori > Signed-off-by: Wanpen

[Qemu-devel] [PATCH 15/19] convert net_init_socket() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek I "reverse engineered" the following permissions between the -socket sub-options: fd listen connect mcast udp | localaddr fd x . .. . | . listen . x .. . | . connect. . x.

[Qemu-devel] [PATCH 17/19] convert net_init_tap() to NetClientOptions

2012-07-23 Thread Stefan Hajnoczi
From: Laszlo Ersek Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- net/tap-aix.c |2 +- net/tap-bsd.c |2 +- net/tap-haiku.c |2 +- net/tap-linux.c |9 +++-- net/tap-solaris.c |2 +- net/tap-win32.c | 11 +++--- net/tap.c | 111 ++

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Peter Maydell
On 23 July 2012 13:26, Avi Kivity wrote: > Really, "irqchip in kernel" means asynchronous interrupts - you can > inject an interrupt from outside the vcpu thread. Obviously if the vcpu > is sleeping you need to wake it up and that pulls in idle management. > > "irqchip" for x86 really means the l

Re: [Qemu-devel] [PATCHv4 0/4] Sandboxing Qemu guests with Libseccomp

2012-07-23 Thread Eduardo Otubo
On Tue, Jul 17, 2012 at 04:19:11PM -0300, Eduardo Otubo wrote: > Hello all, > > This patch is an effort to sandbox Qemu guests using Libseccomp[0]. The > patches > that follows are pretty simple and straightforward. I added the correct > options > and checks to the configure script and the basic

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Cornelia Huck
On Mon, 23 Jul 2012 15:18:49 +0300 Avi Kivity wrote: > > So, for example, if a specific subchannel (=device) has pending status > > and an I/O interrupt is to be generated, this interrupt remains pending > > until an arbitrary cpu is enabled for I/O interrupts. If several cpus > > are enabled for

[Qemu-devel] [PATCH V3 2/3] qerror: Add error telling that streaming blocks migration

2012-07-23 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 92c4eff..c7889fe 100644 --- a/qerror.c +++ b/qerror.c @@ -283,6 +283,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH V3 3/3] migration: block migration when streaming block jobs are running.

2012-07-23 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- migration.c |5 + 1 file changed, 5 insertions(+) diff --git a/migration.c b/migration.c index 8db1b43..4ffdcf2 100644 --- a/migration.c +++ b/migration.c @@ -425,6 +425,11 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,

[Qemu-devel] [PATCH V3 1/3] block: Add bdrv_are_busy()

2012-07-23 Thread benoit . canet
From: Benoît Canet bdrv_are_busy will be used to check if any of the bs are in use or if one of them have a running block job. The first user will be qmp_migrate(). Signed-off-by: Benoit Canet --- block.c | 13 + block.h |2 ++ 2 files changed, 15 insertions(+) diff --git a

[Qemu-devel] [PATCH V3 0/3] Block migration when streaming block jobs are running

2012-07-23 Thread benoit . canet
From: Benoît Canet This patchset is designed to avoid starting a live migration while one or more streaming block jobs are running. Tested with the following sequence: QEMU 1.1.50 monitor - type 'help' for more information (qemu) block_stream virtio0 1k (qemu) migrate tcp:localhost: migrate

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Laszlo Ersek
On 07/23/12 14:46, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Signed-off-by: Laszlo Ersek >> --- >> hw/qdev.c | 14 +- >> vl.c |7 ++- >> 2 files changed, 19 insertions(+), 2 deletions(-) >> >> diff --git a/hw/qdev.c b/hw/qdev.c >> index af54467..f1e83a4 100

[Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-23 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1 RHBZ: 770842 Signed-off-by: Alon Levy --- configure|2 +- hw/qxl.c | 29 - hw/qxl.h |4 trace-events |1 + 4 files ch

[Qemu-devel] [PATCH 1/2] qxl: disallow unknown revisions

2012-07-23 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..3a883ce 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1785,10 +1785,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; br

[Qemu-devel] [PATCH v5 5/6] block: Convert close calls to qemu_close

2012-07-23 Thread Corey Bryant
This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. v5: -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) Signed-off-by: Corey Bryant --- block/raw-posix.c | 24 block/raw-win32.c |2 +- block/vmdk.c

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Avi Kivity
On 07/23/2012 03:58 PM, Peter Maydell wrote: > On 23 July 2012 13:26, Avi Kivity wrote: >> Really, "irqchip in kernel" means asynchronous interrupts - you can >> inject an interrupt from outside the vcpu thread. Obviously if the vcpu >> is sleeping you need to wake it up and that pulls in idle ma

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Avi Kivity
On 07/23/2012 04:06 PM, Cornelia Huck wrote: > On Mon, 23 Jul 2012 15:18:49 +0300 > Avi Kivity wrote: > >> > So, for example, if a specific subchannel (=device) has pending status >> > and an I/O interrupt is to be generated, this interrupt remains pending >> > until an arbitrary cpu is enabled f

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-23 Thread Corey Bryant
On 07/23/2012 09:08 AM, Corey Bryant wrote: When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is found, a dup of the fd will be returned from

[Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-23 Thread Igor Mammedov
MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu. Thus first CPU is always marked as BSP. This pa

[Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c

2012-07-23 Thread Igor Mammedov
v2: ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), to keep cpu_init implementation in -softmmu and -user targets the same in single place and maintanable. v3: reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set tree for testing: https://g

Re: [Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM

2012-07-23 Thread Wanpeng Li
On Mon, Jul 23, 2012 at 02:57:20PM +0200, Andreas Färber wrote: >Am 23.07.2012 14:35, schrieb Wanpeng Li: >> From: Anthony Liguori >> >> makes pci_host a proper QOM type. >> >> Changelog: >> * against Andreas pci_host branch >> * make host bridge TypeInfos const >> * use PCI_HOST_BRIDGE() where

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Peter Maydell
On 23 July 2012 14:09, Avi Kivity wrote: > On 07/23/2012 03:58 PM, Peter Maydell wrote: >> So should we be using something other than KVM_CREATE_IRQCHIP to >> ask the kernel to create a GIC model for us (and leave KVM_CREATE_IRQCHIP >> as a dummy "always succeed" ioctl)? > > Some time ago I sugges

  1   2   3   >