Re: [Qemu-devel] [RFC PATCH v2 03/21][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

At 07/11/2012 06:31 PM, Vasilis Liaskovitis Wrote: > Extend the DSDT to include methods for handling memory hot-add and hot-remove > notifications and memory device status requests. These functions are called > from the memory device SSDT methods. > > Signed-off-by: Vasilis Liaskovitis > --- > s

Re: [Qemu-devel] [PATCH] RFC: vfio-powerpc: added VFIO support (v3)

On 17/07/12 00:21, Alex Williamson wrote: > On Sat, 2012-07-14 at 12:34 +1000, Alexey Kardashevskiy wrote: >> On 14/07/12 01:07, Alex Williamson wrote: >>> On Fri, 2012-07-13 at 17:26 +1000, Alexey Kardashevskiy wrote: It literally does the following: 1. POWERPC IOMMU support (the ke

Re: [Qemu-devel] [PATCH] qemu-options.hx: Fix set_password and expire_password description

Sorry for spamming that much however I was confused why e-mail are coming fine from Pavel Hrdina but not for me. That was the reason I asked Pavel to send it for me as I didn't know my messages have to be approved first because I have no recent activity on the list. Sorry once again! Michal On 07

Re: [Qemu-devel] [PATCH 2/2] fdc-test: Check RELATIVE SEEK beyond track 0/80

On 07/16/2012 04:36 PM, Kevin Wolf wrote: TODO This needs to be checked against a real drive Signed-off-by: Kevin Wolf --- tests/fdc-test.c | 48 +--- 1 files changed, 37 insertions(+), 11 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-te

Re: [Qemu-devel] qemu fails to build with glibc-2.15

On Mon, Jul 16, 2012 at 6:35 PM, X O wrote: > On Mon, Jul 16, 2012 at 5:14 PM, Avi Kivity wrote: >> (fixed mailing list) >> >> On 07/16/2012 03:37 PM, X O wrote: [...] >>> Is there a way to compile qemu with glibc-2.15? [...] >>> ~~~ >>> CCi386-linux-user/syscall.o >>> /tmp/qemu-1.1.1/linux

Re: [Qemu-devel] qemu fails to build with glibc-2.15

On 17 July 2012 10:38, X O wrote: > On Mon, Jul 16, 2012 at 6:35 PM, X O wrote: >> On Mon, Jul 16, 2012 at 5:14 PM, Avi Kivity wrote: >>> (fixed mailing list) >>> >>> On 07/16/2012 03:37 PM, X O wrote: > [...] Is there a way to compile qemu with glibc-2.15? > [...] ~~~ CCi38

Re: [Qemu-devel] qemu fails to build with glibc-2.15

On Tue, Jul 17, 2012 at 11:51 AM, Peter Maydell wrote: > On 17 July 2012 10:38, X O wrote: >> On Mon, Jul 16, 2012 at 6:35 PM, X O wrote: >>> On Mon, Jul 16, 2012 at 5:14 PM, Avi Kivity wrote: (fixed mailing list) On 07/16/2012 03:37 PM, X O wrote: >> [...] > Is there a way t

Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm

Am 16.07.2012 18:37, schrieb Eric Blake: > On 07/16/2012 02:12 AM, Pavel Hrdina wrote: >> On 07/12/2012 07:59 PM, Eric Blake wrote: >>> On 07/12/2012 10:55 AM, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- hmp-commands.hx |2 +- hmp.c| 10 ++ >

Re: [Qemu-devel] [PATCH 2/5] scsi-disk: report resized disk via sense codes

Am 16.07.2012 16:25, schrieb Paolo Bonzini: > Linux will not use these, but a very similar mechanism will be used to > report the condition via virtio-scsi events. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi-bus.c |5 + > hw/scsi-disk.c | 15 +++ > hw/scsi.h |

Re: [Qemu-devel] [PATCH 2/5] scsi-disk: report resized disk via sense codes

Il 17/07/2012 13:14, Kevin Wolf ha scritto: >> > -if (s->features & (1 << SCSI_DISK_F_REMOVABLE)) { >> > -bdrv_set_dev_ops(s->qdev.conf.bs, &scsi_cd_block_ops, s); >> > -} >> > +bdrv_set_dev_ops(s->qdev.conf.bs, &scsi_disk_block_ops, s); > Are you aware of this code? > > bool b

Re: [Qemu-devel] [PATCH v4 1/2] ARM: exynos4210: CMU support

17.07.2012 01:05, Peter Maydell пишет: On 4 July 2012 17:27, Maksim Kozlov wrote: Add exynos4210 Clock Management Units emulation General comment, which I suspect you're not going to like... Underlying the exynos-specific code here, there's a general mechanism of "I'm a device, I have a cloc

Re: [Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

On 17 July 2012 03:24, Catalin Patulea wrote: > I'm just sending this in as a draft for now. There are two outstanding issues: > > 1) What is the recommended type for bitfields? A quick grep shows inconsistent > usage of unsigned int/signed int/uintNN_t across the codebase. Note that > mantissa mu

[Qemu-devel] [rfc patch qemu 0/4] s3 improvements

Hi, This patch series (and the seabios patch series following in a minute) improve s3 support in qemu. The patches allocates a bunch of acpi gpe bits for s3 wakeup of piix chipset devices (ps/2 keyboard, ps/2 mouse, serial port, uhci controller) and does the windup needed so the guest can enabl

[Qemu-devel] [rfc patch qemu 3/4] wakeup: make serial configurable

serial port #1 gets gpe 0x0a. Now that the wakeup is guest-configurable via acpi we also enable it unconditionally. Other serial ports are unchanged: they continue to use the "other" exit reason and are disabled unless explicitly enabled via wakeup property. Signed-off-by: Gerd Hoffmann --- hw

[Qemu-devel] [rfc patch qemu 2/4] wakeup: make ps/2 configurable

ps/2 gets gpe bits 0x08 (keyboard) and 0x09 (mouse). Signed-off-by: Gerd Hoffmann --- hw/ps2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index f93cd24..a3cd124 100644 --- a/hw/ps2.c +++ b/hw/ps2.c @@ -155,7 +155,7 @@ static void ps2_put_keyco

[Qemu-devel] [rfc patch seabios 0/3] s3 improvements

Hi, This patch series carries the dsdt updates needed for the qemu patch series just posted. cheers, Gerd Gerd Hoffmann (3): wakeup: kbd & mouse wakeup: serial wakeup: uhci src/acpi-dsdt.dsl | 60 + 1 files changed, 60 insertions(

[Qemu-devel] [rfc patch seabios 2/3] wakeup: serial

Windup gpe bit 0x0a for s3 wakeup. Signed-off-by: Gerd Hoffmann --- src/acpi-dsdt.dsl |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 93d0b3d..03efbfd 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -479,6 +479,

[Qemu-devel] [rfc patch seabios 3/3] wakeup: uhci

Windup gpe bit 0x0b for s3 wakeup. Also add methods to update the pci config space register 0xc4 which enables/disables wakeup per usb port. Signed-off-by: Gerd Hoffmann --- src/acpi-dsdt.dsl | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) di

Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types

Peter Maydell writes: > On 14 July 2012 13:34, Blue Swirl wrote: >> bitops.h uses inconsistently 'unsigned long' and 'int' for bit numbers. >> >> Unify to 'unsigned long' because it generates better code on x86_64. >> Adjust asserts accordingly. > > Still disagree with this patch, for the record

Re: [Qemu-devel] [PATCH v3 0/2] portability patches

Blue Swirl writes: > I entertained myself by compiling QEMU with -std=c99 -pedantic and > fixing some issues found with that. These two look fine.

Re: [Qemu-devel] [PATCH v5 2/4] exynos4210: Added SD host controller model

On 07/16/2012 09:13 PM, Peter Maydell wrote: On 5 July 2012 05:04, Peter A. G. Crosthwaite wrote: From: Igor Mitsyanko Custom Exynos4210 SD/MMC host controller, based on SD association standard host controller ver. 2.00. Signed-off-by: Igor Mitsyanko --- changed from v4 (Igor): set irq on S

[Qemu-devel] [rfc patch qemu 1/4] wakeup: add acpi gpe wakeup reasons

Allocate four acpi gpe bits (0x08 -> 0x0b) for s3 wakeup configuration and notification. Signed-off-by: Gerd Hoffmann --- hw/acpi.c | 26 ++ sysemu.h |4 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index effc7ec..208c4

[Qemu-devel] [rfc patch seabios 1/3] wakeup: kbd & mouse

Windup gpe bits 0x08 (keyboard) and 0x09 (mouse) for s3 wakeup. Signed-off-by: Gerd Hoffmann --- src/acpi-dsdt.dsl | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 2060686..93d0b3d 100644 --- a/src/acpi-dsdt.dsl +++

[Qemu-devel] [rfc patch qemu 4/4] wakeup: uhci support

Implement the (intel-specific) pci configuration register 0xc4, which is a bitmask saying which ports are allowed to wakeup the system. Also assign gpe bit 0x0b (used only in case uhci handles device 01.2). Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c | 35 ++

[Qemu-devel] [PATCH 2/4] xen: Introduce xen_modified_memory.

This function is to be used during live migration. Every write access to the guest memory should call this funcion so the Xen tools knows which pages are dirty. Signed-off-by: Anthony PERARD --- hw/xen.h |1 + xen-all.c | 21 + xen-stub.c |4 3 files changed

[Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. Signed-off-by: Anthony PERARD --- exec.c |4 memory.c |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index c9fa17d..9f7a4f7 100644 --- a/exec.c +

[Qemu-devel] [PATCH 4/4] xen: Always set the vram dirty during migration.

Because the call to track the dirty bit in the video ram during migration won't work (it returns -1), we set dirtybit on the all video ram. Signed-off-by: Anthony PERARD --- xen-all.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 498883b

[Qemu-devel] [PATCH 0/4] Xen, introducing dirty log for migration.

Hi, This patch set will fix live migration under Xen. For this I introduce a new QMP command to switch global-dirty log and few calls (in exec.c and memory.c) to xen set_dirty function. It unfortunatly necessary to adds new calls because cpu_physical_memory_set_dirty is not call if the memory is

[Qemu-devel] [PATCH 1/4] QMP, Introduce set-global-dirty-log command.

This command is used during a migration of a guest under Xen. It calls memory_global_dirty_log_start or memory_global_dirty_log_stop according to the argument pass to the command. Signed-off-by: Anthony PERARD --- qapi-schema.json | 13 + qmp-commands.hx | 24 +++

Re: [Qemu-devel] KVM call agenda for Tuesday, July 17

Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. There are no topics, so no call. Enjoy the day, Juan.

[Qemu-devel] [PATCH] constify value pointer for qdev_prop_set_string

qdev_prop_set_string uses object_property_set_str, which takes a const char * for the value. Lets propagate the constness into qdev_prop_set_string. Signed-off-by: Christian Borntraeger --- hw/qdev-properties.c |2 +- hw/qdev.h|2 +- 2 files changed, 2 insertions(+), 2 deleti

Re: [Qemu-devel] [PATCH v5 2/4] exynos4210: Added SD host controller model

On 17 July 2012 13:55, Igor Mitsyanko wrote: > On 07/16/2012 09:13 PM, Peter Maydell wrote: >> The IRQ handling code still looks really weird. I would expect >> that the code would be: >>[code which updates various kinds of irq related state] >>sdhci_update_irq(); >> >> where sdhci_update_

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

On 07/17/2012 04:30 PM, Anthony PERARD wrote: > This patch add some calls to xen_modified_memory to notify Xen about dirtybits > during migration. > > diff --git a/exec.c b/exec.c > index c9fa17d..9f7a4f7 100644 > --- a/exec.c > +++ b/exec.c > @@ -3438,6 +3438,7 @@ void cpu_physical_memory_rw(targ

Re: [Qemu-devel] [PATCH] qemu-options.hx: Fix set_password and expire_password description

Am 16.07.2012 15:19, schrieb Pavel Hrdina: > From: Michal Novotny > > The description for set_password and expire_password commands is > incomplete. This patch fixes the man page that is being generated > to match the real behaviour of these functions. > > Signed-off-by: Michal Novotny > --- >

Re: [Qemu-devel] [PATCH 1/4] QMP, Introduce set-global-dirty-log command.

On 07/17/2012 07:30 AM, Anthony PERARD wrote: In the subject, s/set-global/xen-&/, so that searching git log for the full monitor command name will hit this commit. > This command is used during a migration of a guest under Xen. It calls > memory_global_dirty_log_start or memory_global_dirty_log_

Re: [Qemu-devel] [PATCH 1/4] QMP, Introduce set-global-dirty-log command.

On 07/17/2012 04:30 PM, Anthony PERARD wrote: > This command is used during a migration of a guest under Xen. It calls > memory_global_dirty_log_start or memory_global_dirty_log_stop according to the > argument pass to the command. Is the command truly needed? Can't it come from the xen library y

Re: [Qemu-devel] [PATCH v7 0/3] Simpletrace v2: Support multiple args, strings.

On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora wrote: > Existing simpletrace backend allows to trace at max 6 args and does not > support strings. This newer tracelog format gets rid of fixed size records > and therefore allows to trace variable number of args including strings. > > Sample tr

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

On 17/07/12 14:37, Avi Kivity wrote: On 07/17/2012 04:30 PM, Anthony PERARD wrote: This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. diff --git a/exec.c b/exec.c index c9fa17d..9f7a4f7 100644 --- a/exec.c +++ b/exec.c @@ -3438,6 +3438,7 @@ void cpu

Re: [Qemu-devel] [PATCH] RFC: vfio-powerpc: added VFIO support (v3)

On Tue, 2012-07-17 at 17:53 +1000, Alexey Kardashevskiy wrote: > On 17/07/12 00:21, Alex Williamson wrote: > > On Sat, 2012-07-14 at 12:34 +1000, Alexey Kardashevskiy wrote: > >> On 14/07/12 01:07, Alex Williamson wrote: > >>> On Fri, 2012-07-13 at 17:26 +1000, Alexey Kardashevskiy wrote: > It

Re: [Qemu-devel] [PATCH v7 0/3] Simpletrace v2: Support multiple args, strings.

On Tue, Jul 17, 2012 at 3:07 PM, Stefan Hajnoczi wrote: > On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora > wrote: >> Existing simpletrace backend allows to trace at max 6 args and does not >> support strings. This newer tracelog format gets rid of fixed size records >> and therefore allows t

[Qemu-devel] [PATCH v3 02/18] qapi: add test case for deallocating traversal of incomplete structure

v3: - new patch Signed-off-by: Laszlo Ersek --- tests/test-qmp-commands.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 60cbf01..dc3c507 100644 --- a/tests/test-qmp-co

[Qemu-devel] [PATCH v3 11/18] convert net_init_nic() to NetClientOptions

v1->v2: - NetLegacyNicOptions::vectors is of type uint32 Signed-off-by: Laszlo Ersek --- net.c | 39 ++- 1 files changed, 22 insertions(+), 17 deletions(-) diff --git a/net.c b/net.c index af544b2..a62e902 100644 --- a/net.c +++ b/net.c @@ -748,12 +748,15 @

[Qemu-devel] [PATCH v3 09/18] hw, net: "net_client_type" -> "NetClientOptionsKind" (qapi-generated)

NET_CLIENT_TYPE_ -> NET_CLIENT_OPTIONS_KIND_ Signed-off-by: Laszlo Ersek --- net.h | 16 +- hw/cadence_gem.c|2 +- hw/dp8393x.c|2 +- hw/e1000.c |2 +- hw/eepro100.c |2 +- hw/etraxfs_eth.c|2 +

[Qemu-devel] [PATCH v3 16/18] convert net_init_tap() to NetClientOptions

Signed-off-by: Laszlo Ersek --- net/tap.h |2 +- net/tap-aix.c |2 +- net/tap-bsd.c |2 +- net/tap-haiku.c |2 +- net/tap-linux.c |9 +++- net/tap-solaris.c |2 +- net/tap-win32.c | 11 +++-- net/tap.c | 111 ++-

[Qemu-devel] [PATCH v3 10/18] convert net_client_init() to OptsVisitor

The net_client_init() prototype is kept intact. Based on "is_netdev", the QemuOpts-rooted QemuOpt-list is parsed as a Netdev or a NetLegacy. The original meat of net_client_init() is moved to and simplified in net_client_init1(): Fields not common between -net and -netdev are clearly separated. G

[Qemu-devel] [PATCH v3 17/18] convert net_init_bridge() to NetClientOptions

Signed-off-by: Laszlo Ersek --- net/tap.c | 23 --- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/net/tap.c b/net/tap.c index c5563c0..d2736ea 100644 --- a/net/tap.c +++ b/net/tap.c @@ -513,21 +513,22 @@ static int net_bridge_run_helper(const char *helper

[Qemu-devel] [PATCH v3 06/18] qapi: introduce OptsVisitor

This visitor supports parsing -option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...] style QemuOpts objects into "native" C structures. After defining the type tree in the qapi schema (see below), a root type traversal with this visitor linked to the underlying QemuOpts object will bu

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

On 07/17/2012 04:59 PM, Anthony PERARD wrote: >> >> This is pretty ugly. An alternative is to set up a periodic bitmap scan >> that looks at the qemu dirty bitmap and calls xen_modified_memory() for >> dirty page ranges, and clears the bitmap for the next pass. Is it >> workable? > > I don't thi

Re: [Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

On Tue, Jul 17, 2012 at 8:23 AM, Peter Maydell wrote: > I think our current position is "don't use bitfields for anything that > has to match an externally defined layout". This is because on Windows > we have to compile with -mms-bitfields [for compatibility with Windows > APIs], which can lead t

Re: [Qemu-devel] [PATCH v5 2/4] exynos4210: Added SD host controller model

On 07/17/2012 05:37 PM, Peter Maydell wrote: On 17 July 2012 13:55, Igor Mitsyanko wrote: On 07/16/2012 09:13 PM, Peter Maydell wrote: The IRQ handling code still looks really weird. I would expect that the code would be: [code which updates various kinds of irq related state] sdhci_up

[Qemu-devel] [PATCH v3 15/18] convert net_init_vde() to NetClientOptions

v1->v2: - NetdevVdeOptions::port and ::mode are of type uint16. Remove superfluous range checks. Signed-off-by: Laszlo Ersek --- net/vde.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/net/vde.c b/net/vde.c index 8e60f68..703888c 100644 --- a/net/vde

Re: [Qemu-devel] [PATCH v5 2/4] exynos4210: Added SD host controller model

On 17 July 2012 15:58, Igor Mitsyanko wrote: > On 07/17/2012 05:37 PM, Peter Maydell wrote: >> I would suggest two functions: >> >> int sdhci_slotint(SDHCIState *s) >> which just calculates and returns the external interrupt line state >> (might be able to make this 'static'), and > Ok, but I'd r

[Qemu-devel] [PATCH v3 00/18] introduce OptsVisitor, rebase -net/-netdev parsing

The first two patches clean up error propagation and enable the release of incompletely parsed/created objects. A new test case is added as well. Inspired by [1], patches 3-6 add a new visitor that should simplify defining and processing command line options. For a more detailed description, pleas

[Qemu-devel] [PATCH v3 08/18] qapi schema: add Netdev types

NetdevTapOptions::sndbuf and NetdevDumpOptions::len use the new "size" type. v1->v2: - NetLegacy::name is optional - NetLegacyNicOptions::vectors is of type uint32 - NetdevVdeOptions::port and ::mode are of type uint16 - NetLegacy::vlan has type int32 v2->v3: - NetLegacy::id is allowed and takes

[Qemu-devel] [PATCH v3 13/18] convert net_init_slirp() to NetClientOptions

Signed-off-by: Laszlo Ersek --- net/slirp.c | 93 --- 1 files changed, 25 insertions(+), 68 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 1243d43..44b059f 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -686,89 +686,46 @@ void

[Qemu-devel] [PATCH v3 03/18] qapi: generate C types for fixed-width integers

(Long line folded using parens: .) Signed-off-by: Laszlo Ersek --- scripts/qapi.py |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index e062336..1292476 100644 --- a/scrip

[Qemu-devel] [PATCH v3 18/18] remove unused QemuOpts parameter from net init functions

v1->v2: - unchanged v2->v3: - keep "qemu-option.h" included in "net/slirp.h" Signed-off-by: Laszlo Ersek --- net/dump.h |5 ++--- net/slirp.h |4 ++-- net/socket.h|5 ++--- net/tap.h |9 - net/vde.h |5 ++--- net.c | 14 ++

[Qemu-devel] [PATCH v3 12/18] convert net_init_dump() to NetClientOptions

v1->v2: - NetdevDumpOptions::len is of type 'size', whose C type was changed to uint64_t. Adapt the printf() format specifier macro. Signed-off-by: Laszlo Ersek --- net/dump.c | 21 + 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/net/dump.c b/net/dump.c

Re: [Qemu-devel] [PATCH v7 2/3] Simpletrace v2: Support multiple arguments, strings.

On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora wrote: > Existing simpletrace backend allows to trace at max 6 args and does not > support strings. This newer tracelog format gets rid of fixed size records > and therefore allows to trace variable number of args including strings. > > Sample tr

[Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env

This variable is now thread-local, so cannot change anymore while dropping the global mutex. Signed-off-by: Jan Kiszka --- cpus.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index b182b3d..733568d 100644 --- a/cpus.c +++ b/cpus.c @@ -660,10 +660,7 @

Re: [Qemu-devel] [PATCH v7 0/3] Simpletrace v2: Support multiple args, strings.

On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora wrote: > Existing simpletrace backend allows to trace at max 6 args and does not > support strings. This newer tracelog format gets rid of fixed size records > and therefore allows to trace variable number of args including strings. > > Sample tr

[Qemu-devel] [PATCH v3 05/18] expose QemuOpt and QemuOpts struct definitions to interested parties

The only clients should be the existent "qemu-option.c", and the upcoming "qapi/opts-visitor.c". Signed-off-by: Laszlo Ersek --- qemu-option-internal.h | 53 qemu-option.c | 24 + 2 files changed, 54 insertions(+),

Re: [Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env

On 17 July 2012 16:23, Jan Kiszka wrote: > This variable is now thread-local, so cannot change anymore while > dropping the global mutex. This isn't true on any host except Linux, and run_on_cpu() isn't inside a !_WIN32 ifdef as far as I can tell. -- PMM

[Qemu-devel] [PATCH v3 14/18] convert net_init_socket() to NetClientOptions

I "reverse engineered" the following permissions between the -socket sub-options: fd listen connect mcast udp | localaddr fd x . .. . | . listen . x .. . | . connect. . x. . | . mcast

Re: [Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env

On 2012-07-17 17:27, Peter Maydell wrote: > On 17 July 2012 16:23, Jan Kiszka wrote: >> This variable is now thread-local, so cannot change anymore while >> dropping the global mutex. > > This isn't true on any host except Linux, and run_on_cpu() isn't > inside a !_WIN32 ifdef as far as I can tel

[Qemu-devel] q35 and ahci

> Update on q35 testing with various os's. > > Linux > - > -RHEL6.3 installs + runs > -Fedora 16 install + runs > -Fedora 17 - squashfs errors >running on already installed f17 seems ok. Pardon my high-level question (I haven't been following q35 threads closely), but I just looked at h

[Qemu-devel] [PATCH v3 04/18] qapi: introduce "size" type

v1->v2: - fall back to uint64 rather than int Signed-off-by: Laszlo Ersek --- qapi/qapi-visit-core.h |3 +++ qapi/qapi-visit-core.c |7 +++ scripts/qapi.py|2 ++ 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/qapi/qapi-visit-core.h b/qapi/qapi-visit-core.

[Qemu-devel] [PATCH v3 01/18] qapi: fix error propagation

From: Paolo Bonzini Don't overwrite / leak previously set errors. Make traversal cope with missing mandatory sub-structs. Don't try to end a container that could not be started. v1->v2: - unchanged v2->v3: - instead of examining, assert that we never overwrite errors with error_set() - allow

[Qemu-devel] [PATCH v3 07/18] qapi schema: remove trailing whitespace

Signed-off-by: Laszlo Ersek --- qapi-schema.json | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 1ab5dbd..8847f82 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -343,7 +343,7 @@ # @CPU: the index of the virtual

[Qemu-devel] [PATCH 1/2] socket: remove redundant check

It's aleady in the end of loop, error should be set. Signed-off-by: Amos Kong --- qemu-sockets.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 2ae715d..697e5d8 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -178,9 +178,7 @@

[Qemu-devel] [PATCH 2/2] remove unused include of error.h

Signed-off-by: Amos Kong --- qemu_socket.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu_socket.h b/qemu_socket.h index 4689ff3..1a2f517 100644 --- a/qemu_socket.h +++ b/qemu_socket.h @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia); #endif /* !

[Qemu-devel] [PATCH 0/2] trivial fix of qemu-sockets.c

Those two patches fix trivial issues which were found in the second review. Amos Kong (2): socket: remove redundant check remove unused include of error.h qemu-sockets.c |4 +--- qemu_socket.h |1 - 2 files changed, 1 insertions(+), 4 deletions(-)

Re: [Qemu-devel] q35 and ahci

On Tue, Jul 17, 2012 at 09:31:46AM -0600, Eric Blake wrote: > > Update on q35 testing with various os's. > > > > Linux > > - > > -RHEL6.3 installs + runs > > -Fedora 16 install + runs > > -Fedora 17 - squashfs errors > >running on already installed f17 seems ok. > > Pardon my high-level

Re: [Qemu-devel] q35 and ahci

On Tue, Jul 17, 2012 at 11:47:14AM -0400, Jason Baron wrote: > On Tue, Jul 17, 2012 at 09:31:46AM -0600, Eric Blake wrote: > > > Update on q35 testing with various os's. > > > > > > Linux > > > - > > > -RHEL6.3 installs + runs > > > -Fedora 16 install + runs > > > -Fedora 17 - squashfs errors

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

@Todor, Thanks, you might be right. It sounds like it's not a missing feature but a bug. I'll re-raise the priority. ** Also affects: qemu Importance: Undecided Status: New ** Changed in: qemu-kvm (Ubuntu) Importance: Low => High -- You received this bug notification because you

[Qemu-devel] Keeping a secondary CPU in reset

Hi, I've been toying around with adding NVIDIA Tegra support to QEMU. While adding SMP support I came across a problem: on Tegra, the secondary CPU is kept in reset by the clock-and-reset controller (CRC). When bringing up the secondary CPU, the OS writes a given register in the CRC to release the

[Qemu-devel] [PATCH 30/41] blockdev: Drop redundant CHS validation for if=ide

From: Markus Armbruster Leave it to ide_init_drive(). Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 06c997e..5f8677e 100644 --- a/blockdev.c +++ b/blockdev.c

[Qemu-devel] [PATCH 24/41] ide: qdev property for BIOS CHS translation

From: Markus Armbruster This isn't quite orthodox. CHS translation is firmware configuration, communicated via the RTC's CMOS RAM, not a property of the disk. But it's best to treat it just like geometry anyway. Maintain backward compatibility exactly like for geometry: fall back to DriveInfo'

[Qemu-devel] [PATCH 09/41] hd-geometry: Unnest conditional in hd_geometry_guess()

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/hd-geometry.c | 84 +++--- 1 files changed, 42 insertions(+), 42 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index f0dd021..db47846 100

[Qemu-devel] [PATCH 25/41] qtest: Cover qdev property for BIOS CHS translation

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- tests/hd-geo-test.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index a47b945..5d9d2e4 100644 --- a/tests/hd-geo-test.c +++

[Qemu-devel] [PATCH 08/41] hd-geometry: Add tracepoints

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/hd-geometry.c |7 +++ trace-events |4 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index c45eafd..f0dd021 100644 --- a/hw/hd-geo

[Qemu-devel] [PATCH 15/41] blockdev: Save geometry in DriveInfo

From: Markus Armbruster In preparation of purging it from the block layer, which will happen later in this series. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c |4 blockdev.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/blockde

[Qemu-devel] [PATCH 05/41] vvfat: Do not clobber the user's geometry

From: Markus Armbruster vvfat creates a virtual VFAT filesystem with a certain logical geometry that depends on its options. It sets the "geometry hint" to this geometry. It is the only block driver to do this. The geometry hint is about about *physical* geometry, and used only by certain hard

[Qemu-devel] [PATCH 18/41] scsi-hd: qdev properties for disk geometry

From: Markus Armbruster Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Do this only for scsi-hd. scsi-disk is legacy. scsi-cd doesn't have a

[Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures

Rather than hardcoding the list of architectures in the kernel header update script, just import headers for every architecture which supports KVM. This reduces the number of QEMU files which need to be updated to add support for a new KVM architecture. It also means we won't break if the kernel dr

[Qemu-devel] [PATCH 26/41] block: Geometry and translation hints are now useless, purge them

From: Markus Armbruster There are two producers of these hints: drive_init() on behalf of -drive, and hd_geometry_guess(). The only consumer of the hint is hd_geometry_guess(). The callers of hd_geometry_guess() call it only when drive_init() didn't set the hints. Therefore, drive_init()'s hin

[Qemu-devel] [PATCH 02/41] sheepdog: do not blindly memset all read buffers

From: Christoph Hellwig Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig Acked-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) d

[Qemu-devel] [PATCH 33/41] hw/block-common: Factor out fall back to legacy -drive serial=...

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/Makefile.objs |2 +- hw/block-common.c| 24 hw/block-common.h|3 +++ hw/ide/qdev.c| 12 ++-- hw/scsi-disk.c |8 +--- hw/usb/d

[Qemu-devel] [PATCH 29/41] hd-geometry: Compute BIOS CHS translation in one place

From: Markus Armbruster Currently, it is split between hd_geometry_guess() and pc_cmos_init_late(). Confusing. info qtree shows the result of the former. Also confusing. Fold the part done in pc_cmos_init_late() into hd_geometry_guess(). Signed-off-by: Markus Armbruster Signed-off-by: Kevin

[Qemu-devel] [PATCH 32/41] hw/block-common: Move BlockConf & friends from block.h

From: Markus Armbruster This stuff doesn't belong to block layer, and was put there only because a better home didn't exist then. Now it does. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.h | 45 - hw/block-commo

[Qemu-devel] [PATCH 38/41] qemu-iotests: Valgrind support

check -valgrind wraps all qemu-io calls with valgrind. This makes it a bit easier to debug problems that occur somewhere deep in a test case. Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- tests/qemu-iotests/common| 11 +++ tests/qemu-iotests/common.rc | 10 ++

[Qemu-devel] [PATCH 28/41] qtest: Test we don't put hard disk info into CMOS for a CD-ROM

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- tests/hd-geo-test.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 5d9d2e4..9a31e85 100644 --- a/tests/hd-geo-t

[Qemu-devel] [PATCH 16/41] qdev: Introduce block geometry properties

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/block.h b/block.h index 993894e..1cd8a01 100644 --- a/block.h +++ b/block.h @@ -426,6 +426,8 @@ typedef struct BlockCon

[Qemu-devel] [PATCH 34/41] blockdev: Don't limit DriveInfo serial to 20 characters

From: Markus Armbruster All current users (IDE, SCSI and virtio-blk) happen to share this 20 characters limit. Still, it should be left to device models. They already enforce their limits. They have to, as the DriveInfo limit only affects legacy -drive serial=..., not the qdev properties. usb

[Qemu-devel] Release Engineering: qemu-1.1.1.tar.bz2 release name and filetype mismatch

Hi, The qemu-1.1.1 release tarball[1] has file extention .tar.bz2 while the real file format is gzip. $ file Downloads/qemu-1.1.1.tar.bz2 Downloads/qemu-1.1.1.tar.bz2: gzip compressed data, from Unix, last modified: Thu Jul 12 21:52:36 2012 Would it be possible to add a tarball which has a fil

[Qemu-devel] [PATCH 37/41] coroutine-ucontext: Help valgrind understand coroutines

valgrind tends to get confused and report false positives when you switch stacks and don't tell it about it. Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- configure| 20 coroutine-ucontext.c | 28 2 files changed, 48 i

[Qemu-devel] [PATCH 10/41] hd-geometry: Factor out guess_chs_for_size()

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/hd-geometry.c | 32 1 files changed, 20 insertions(+), 12 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index db47846..1a58894 100644 --- a/hw/hd-geomet

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures

On 2012-07-17 18:41, Peter Maydell wrote: > Rather than hardcoding the list of architectures in the kernel > header update script, just import headers for every architecture > which supports KVM. This reduces the number of QEMU files which > need to be updated to add support for a new KVM architect

[Qemu-devel] Keeping a secondary CPU in reset

Hi, I've been toying around with adding NVIDIA Tegra support to QEMU. While adding SMP support I came across a problem: on Tegra, the secondary CPU is kept in reset by the clock-and-reset controller (CRC). When bringing up the secondary CPU, the OS writes a given register in the CRC to release the

[Qemu-devel] [PATCH 22/41] qdev: Collect private helpers in one place

From: Markus Armbruster Just code motion, with one long line wrapped to keep checkpatch.pl happy. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/qdev-properties.c | 144 +- 1 files changed, 72 insertions(+), 72 deletions(-)

  1   2   >