Re: [Qemu-devel] [PATCH v8 01/16] target-or32: Add target stubs and QOM cpu

2012-07-09 Thread Jia Liu
Hi Andreas, Thank you for comment. I've tried fix them, but I'm afraid I didn't fully understand what you mean. Please read the new code and give me some comment, please. On Thu, Jul 5, 2012 at 9:22 PM, Andreas Färber wrote: > Am 01.07.2012 04:45, schrieb Jia Liu: >> Add OpenRISC target stubs an

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-09 Thread Wayne Xia
Paolo, what do you think write a short section in document for it, but make no change to code? 于 2012-7-5 16:34, Paolo Bonzini 写道: Il 05/07/2012 10:13, Michael Tokarev ha scritto: Hi Paolo, should I make a patch to make persistent the default for qemu-nbd? Yes, why not. However, as mention

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-09 Thread Paolo Bonzini
Il 09/07/2012 09:11, Wayne Xia ha scritto: > Paolo, what do you think write a short section in document for it, but > make no change to code? That's okay, but perhaps for 1.2 we can fix the probing. I'll apply the patch to nbd-next and not submit it until it's clear that 1.2 will still have the

Re: [Qemu-devel] [PATCH] bitops: fix types

2012-07-09 Thread Markus Armbruster
Peter Maydell writes: > On 8 July 2012 13:12, wrote: >> -static inline uint64_t deposit64(uint64_t value, int start, int length, >> - uint64_t fieldval) >> +static inline uint64_t deposit64(uint64_t value, unsigned int start, >> +

Re: [Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared

2012-07-09 Thread Deep Debroy
On Sun, Jul 8, 2012 at 11:57 PM, Paolo Bonzini wrote: > Il 07/07/2012 09:56, Blue Swirl ha scritto: >> These don't seem useful. I think DMA accessors should also be used. > > This is a paravirtualized device model, so I think no (like virtio). > > I agree that this patch can be dropped and the fun

Re: [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier

2012-07-09 Thread Peter Maydell
On 8 July 2012 20:22, wrote: > From: Blue Swirl > > Qualifier 'volatile' is not useful for applications, it's too strict > for single threaded code but does not give the real atomicity guarantees > needed for multithreaded code. > > Drop them. > > Signed-off-by: Blue Swirl Reviewed-by: Peter M

Re: [Qemu-devel] [PATCH] ehci: Kick async schedule on wakeup in the non companion case

2012-07-09 Thread Gerd Hoffmann
On 07/06/12 16:53, Hans de Goede wrote: > Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code > to ehci_wakeup to kick the async schedule on wakeup, but the else > was positioned wrong making it trigger for devices which are routed > to the companion rather then to the ehci controller itsel

Re: [Qemu-devel] [PATCH 29/37] ehci: kick async schedule on wakeup

2012-07-09 Thread Gerd Hoffmann
Hi, > do we > support wakeup in the EHCI-code at all? uhci and ohci do, could be ehci doesn't, all our hid emulated devices which need remote wakeup most are usb 1.1 devices ... cheers, Gerd

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-09 Thread Markus Armbruster
blauwir...@gmail.com writes: > From: Blue Swirl > > Replace expr1 ?: expr2 with expr1 ? expr1 : expr2 as K&R intended. > > If expr1 has side effects, introduce a temporary variable. > > Signed-off-by: Blue Swirl > --- > block.c |6 -- > block/qcow2.c|6 -- >

Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool

2012-07-09 Thread Peter Maydell
On 8 July 2012 20:22, wrote: > From: Blue Swirl > > Use 'bool' type for return value of bit test functions. > > Signed-off-by: Blue Swirl I'm 'meh' about the necessity for this change, but it looks safe and functionally correct to me -- all these functions are either already returning the resu

Re: [Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-07-09 Thread Daniel P. Berrange
On Sun, Jul 08, 2012 at 11:45:34PM +0100, Peter Maydell wrote: > On 8 July 2012 20:44, Michael Tokarev <1022...@bugs.launchpad.net> wrote: > > Please take this to your shell. The queston mark is a metacharacter for > > any *nix shell, you should just quote or backslash it. The same > > question m

Re: [Qemu-devel] [sheepdog] [PATCH v2] sheepdog: do not blindly memset all read buffers

2012-07-09 Thread MORITA Kazutaka
At Sun, 8 Jul 2012 21:33:16 +0200, Christoph Hellwig wrote: > > Only buffers that map to unallocated blocks need to be zeroed. > > Signed-off-by: Christoph Hellwig > > --- > block/sheepdog.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) > > Index: qe

Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types

2012-07-09 Thread Markus Armbruster
blauwir...@gmail.com writes: > From: Blue Swirl > > Use 'unsigned int' for bit numbers instead of 'unsigned long' or > 'int'. Adjust asserts. I'd like to lodge a formal objection to this part. There is no consensus. I recognize the power of maintainers to force a change even without consensus.

Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool

2012-07-09 Thread Markus Armbruster
blauwir...@gmail.com writes: > From: Blue Swirl > > Use 'bool' type for return value of bit test functions. Matter of taste. 'bool' makes sense if you think of these functions as predicates (ugly ones, with side effects). 'int' makes sense if you think of them as returning the bit value (a bit

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Alexander Graf writes: > We've had support for creating AHCI devices using -device for a while now, > but it's cumbersome to users. We really should provide an easier way for > them to leverage the power of AHCI! > > So let's introduce a new if= option to -drive, giving users the same > command l

Re: [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly

2012-07-09 Thread Markus Armbruster
Blue Swirl writes: > On Fri, Jul 6, 2012 at 6:57 AM, Markus Armbruster wrote: >> Each test litters /tmp with several files: a pid file and two >> sockets. Tidy up. >> >> Signed-off-by: Markus Armbruster > > While a nice patch, I don't think it should belong to this series. Understand, but wha

[Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-09 Thread Wenchao Xia
Hi, Paolo and folks, qemu have good capabilities to access different virtual disks, I want to expose its block layer API to let 3rd party program linked in, such as management stack or block tools, to access images data directly. Following is the objects: (1) API to write/read block device at

[Qemu-devel] [PATCH] place qemu-sockets.c contributions since 2012-01-13 under GPLv2+

2012-07-09 Thread Paolo Bonzini
Past contributions since 2012-01-13 were only made by Red Hat people, so they are already available under GPLv2+. Signed-off-by: Paolo Bonzini --- qemu-sockets.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-sockets.c b/qemu-sockets.c index 2ae715d..668fa93 100644 --- a/qemu-soc

Re: [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 09:56, schrieb Markus Armbruster: > Blue Swirl writes: > >> On Fri, Jul 6, 2012 at 6:57 AM, Markus Armbruster wrote: >>> Each test litters /tmp with several files: a pid file and two >>> sockets. Tidy up. >>> >>> Signed-off-by: Markus Armbruster >> >> While a nice patch, I don't

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 10:50, schrieb Markus Armbruster: > Alexander Graf writes: > >> We've had support for creating AHCI devices using -device for a while now, >> but it's cumbersome to users. We really should provide an easier way for >> them to leverage the power of AHCI! >> >> So let's introduce a ne

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 11:11, Kevin Wolf wrote: > Am 09.07.2012 10:50, schrieb Markus Armbruster: >> Alexander Graf writes: >> >>> We've had support for creating AHCI devices using -device for a while now, >>> but it's cumbersome to users. We really should provide an easier way for >>> them to lever

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-09 Thread Paolo Bonzini
Il 09/07/2012 10:54, Wenchao Xia ha scritto: > Following is my implementing plan draft: > 1 introduce libqblock.so in sub directory in qemu. > 2 write a nbd client in libqblock, similar to qemu nbd client. Then > use it to talk with nbd server, by default is qemu-nbd, to get access > to images.

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 04:54:08PM +0800, Wenchao Xia wrote: > Hi, Paolo and folks, > qemu have good capabilities to access different virtual disks, I want > to expose its block layer API to let 3rd party program linked in, such > as management stack or block tools, to access images data directly

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 11:13, schrieb Alexander Graf: > > On 09.07.2012, at 11:11, Kevin Wolf wrote: > >> Am 09.07.2012 10:50, schrieb Markus Armbruster: >>> Alexander Graf writes: >>> We've had support for creating AHCI devices using -device for a while now, but it's cumbersome to users. We re

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 11:27, Kevin Wolf wrote: > Am 09.07.2012 11:13, schrieb Alexander Graf: >> >> On 09.07.2012, at 11:11, Kevin Wolf wrote: >> >>> Am 09.07.2012 10:50, schrieb Markus Armbruster: Alexander Graf writes: > We've had support for creating AHCI devices using -device fo

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 11:36:47AM +0200, Alexander Graf wrote: > > On 09.07.2012, at 11:27, Kevin Wolf wrote: > > > Am 09.07.2012 11:13, schrieb Alexander Graf: > >> > >> On 09.07.2012, at 11:11, Kevin Wolf wrote: > >> > >>> Am 09.07.2012 10:50, schrieb Markus Armbruster: > Alexander Graf

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 11:41, Gleb Natapov wrote: > On Mon, Jul 09, 2012 at 11:36:47AM +0200, Alexander Graf wrote: >> >> On 09.07.2012, at 11:27, Kevin Wolf wrote: >> >>> Am 09.07.2012 11:13, schrieb Alexander Graf: On 09.07.2012, at 11:11, Kevin Wolf wrote: > Am 09.07.2012 10:

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 11:44:11AM +0200, Alexander Graf wrote: > > On 09.07.2012, at 11:41, Gleb Natapov wrote: > > > On Mon, Jul 09, 2012 at 11:36:47AM +0200, Alexander Graf wrote: > >> > >> On 09.07.2012, at 11:27, Kevin Wolf wrote: > >> > >>> Am 09.07.2012 11:13, schrieb Alexander Graf: > >

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-09 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot Status in QEMU: Confi

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 11:36, schrieb Alexander Graf: > > On 09.07.2012, at 11:27, Kevin Wolf wrote: > >> Am 09.07.2012 11:13, schrieb Alexander Graf: >>> >>> On 09.07.2012, at 11:11, Kevin Wolf wrote: Can we even make it the default with q35 as long as our AHCI controller doesn't also expose a

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 11:52:32AM +0200, Kevin Wolf wrote: > > If -hda has the semantics of "create an IDE device", then no, we can't > > change it. It doesn't however. IIRC on -M pseries -hda creates SCSI > > devices. On s390 -hda creates virtio devices. So if on -M q35 -hda would > > create i

[Qemu-devel] [PATCH v3 02/10] esp: delay Transfer Information command if dma is not enabled

2012-07-09 Thread Hervé Poussineau
The same mechanism is already in place for some select commands. Signed-off-by: Hervé Poussineau --- hw/esp.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index aff8de6..ac91f00 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -435,6 +435,11 @@ static void handle_ti(ESP

[Qemu-devel] [PATCH v3 00/10] esp: add AMD PCscsi emulation

2012-07-09 Thread Hervé Poussineau
This patchset adds a PCI connection to the 53c9x emulation already present in QEMU. The emulated card is the AMD PCscsi adapter, and has been tested on multiple Microsoft operating systems. Changes v2 -> v3: - add support for accesses with size 1 or 2 - fix compilation for sparc target Changes v

[Qemu-devel] [PATCH v3 08/10] esp: use trace framework instead of stderr output

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 13 ++--- trace-events |3 +++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 796cdc1..ec40d93 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -26,6 +26,7 @@ #include "scsi.h" #include "esp.h" #

[Qemu-devel] [PATCH v3 09/10] pci: add some stubs

2012-07-09 Thread Hervé Poussineau
Cc: Michael S. Tsirkin Signed-off-by: Hervé Poussineau --- hw/pci-stub.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/pci-stub.c b/hw/pci-stub.c index 134c448..e083191 100644 --- a/hw/pci-stub.c +++ b/hw/pci-stub.c @@ -34,6 +34,21 @@ static void pci_error_message(Mon

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 12:02, schrieb Gleb Natapov: > On Mon, Jul 09, 2012 at 11:52:32AM +0200, Kevin Wolf wrote: >>> If -hda has the semantics of "create an IDE device", then no, we can't >>> change it. It doesn't however. IIRC on -M pseries -hda creates SCSI >>> devices. On s390 -hda creates virtio devi

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 12:03:49PM +0200, Kevin Wolf wrote: > Am 09.07.2012 12:02, schrieb Gleb Natapov: > > On Mon, Jul 09, 2012 at 11:52:32AM +0200, Kevin Wolf wrote: > >>> If -hda has the semantics of "create an IDE device", then no, we can't > >>> change it. It doesn't however. IIRC on -M pser

[Qemu-devel] [PATCH] scsi: add free_request callback

2012-07-09 Thread Paolo Bonzini
Most device models have a simple lifecycle for the hba_private field and they can free it when a request is completed or cancelled. However, in some cases it may be simpler to tie the lifetime of hba_private to that of the included SCSIRequest. This patch adds a free_request callback to SCSIBusInf

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Gerd Hoffmann
Hi, >> If -hda has the semantics of "create an IDE device", then no, we can't >> change it. It doesn't however. IIRC on -M pseries -hda creates SCSI devices. >> On s390 -hda creates virtio devices. So if on -M q35 -hda would create >> if=ahci, I don't see how that breaks the CLI. > > It does

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-09 Thread Fabien Chouteau
Any comment? On 07/04/2012 01:04 PM, Fabien Chouteau wrote: > The goal is to make ctrl-a x to close Qemu in a clean way. The current > exit(0) skips a lot of cleanup/close functions, for example in block > drivers. > > Signed-off-by: Fabien Chouteau > --- > qemu-char.c |2 +- > sysemu.h

[Qemu-devel] [PATCH] usb: split endpoint init and reset

2012-07-09 Thread Gerd Hoffmann
Create a new usb_ep_reset() function to reset endpoint state, without re-initialiting the queues, so we don't unlink in-flight packets just because usb-host has to re-parse the descriptor tables. Signed-off-by: Gerd Hoffmann --- hw/usb.h|1 + hw/usb/core.c | 13 ++

[Qemu-devel] [PATCH 3/9] ehci: don't flush cache on doorbell rings.

2012-07-09 Thread Gerd Hoffmann
Commit 4be23939ab0d7019c7e59a37485b416fbbf0f073 makes ehci instantly zap any unlinked queue heads when the guest rings the doorbell. While hacking up uas support this turned out to be a problem. The linux kernel can unlink and instantly relink the very same queue head, thereby killing any async p

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
Ping? [patchwork url http://patchwork.ozlabs.org/patch/167132/] -- PMM On 25 June 2012 15:55, Peter Maydell wrote: > In our disassembly code, the bfd_vma type is always 64 bits, > even if the target's virtual address width is only 32 bits. This > means that when we print out addresses we need to

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 12:19, schrieb Fabien Chouteau: > Any comment? > > On 07/04/2012 01:04 PM, Fabien Chouteau wrote: >> The goal is to make ctrl-a x to close Qemu in a clean way. The current >> exit(0) skips a lot of cleanup/close functions, for example in block >> drivers. >> >> Signed-off-by: Fabien

[Qemu-devel] [PATCH v3 10/10] esp: add AMD PCscsi emulation (PCI SCSI adapter)

2012-07-09 Thread Hervé Poussineau
The PCI version is supported in lots of Operating Systems, and has been successfully tested on: - MS DOS 6.22 (using DC390 driver) - MS Windows 3.11 (using DC390 driver) - MS Windows 98 SE (using default driver) - MS Windows NT 3.1 (using DC390 driver) - MS Windows NT 4.0 (using default driver) Si

Re: [Qemu-devel] [PATCH v2 0/4] Define and use TARGET_PRI*PHYS format specifier macros for target_phys_addr_t

2012-07-09 Thread Peter Maydell
Ping? -- PMM On 25 June 2012 16:52, Peter Maydell wrote: > This patchset defines a set of macros for use in printf format strings > for handling target_phys_addr_t values, as suggested by Andreas Färber > (http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01547.html) > > We can then use th

[Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
Hi, v2 of the usb attached scsi emulation patches. Patch #1 is almost unmodified compared to v1. Patch #2 is new and makes UAS emulation use the new free_request callback (patch just posted by paolo) and obviously depends on that patch to compile. cheers, Gerd Gerd Hoffmann (2): usb: add

[Qemu-devel] [PATCH 1/2] usb: add usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
$subject says all. First cut. It's a pure UAS (usb attached scsi) emulation, without BOT (bulk-only transport) compatibility. If your guest can't handle it use usb-storage instead. The emulation works like any other scsi hba emulation (eps, lsi, virtio, megasas, ...). It provides just the HBA

[Qemu-devel] [PATCH 2/2] uas: use scsi req refcounting + free_request callback

2012-07-09 Thread Gerd Hoffmann
With the new free_request callback for SCSIBusInfo we can use scsi request refcounting instead of our own for the uas request lifecycle. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-uas.c | 33 ++--- 1 files changed, 10 insertions(+), 23 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 8/9] usb: fix interface initialization

2012-07-09 Thread Gerd Hoffmann
zero is a valid interface number, so don't use it when resetting the endpoints. Signed-off-by: Gerd Hoffmann --- hw/usb.h |2 ++ hw/usb/core.c |4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 9cd2f89..7ed8fb8 100644 --- a/hw/usb.h +++

Re: [Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 12:33, Gerd Hoffmann wrote: > Hi, > > v2 of the usb attached scsi emulation patches. Patch #1 is almost > unmodified compared to v1. Patch #2 is new and makes UAS emulation > use the new free_request callback (patch just posted by paolo) and > obviously depends on that patch to com

Re: [Qemu-devel] [PATCH 7/7 v6] deal with panicked event accoring to '-machine panic_action=action'

2012-07-09 Thread Wen Congyang
At 07/06/2012 07:09 PM, Jan Kiszka Wrote: > On 2012-07-06 11:41, Wen Congyang wrote: >> The action is the same as -onpanic parameter. > > As explained in patch 5, now that we have a related device, this no > longer needs to be a machine property. > > Would could be a machine property is enabling/

Re: [Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Paolo Bonzini
Il 09/07/2012 12:39, Gerd Hoffmann ha scritto: > On 07/09/12 12:33, Gerd Hoffmann wrote: >> Hi, >> >> v2 of the usb attached scsi emulation patches. Patch #1 is almost >> unmodified compared to v1. Patch #2 is new and makes UAS emulation >> use the new free_request callback (patch just posted b

[Qemu-devel] [PATCH v3 01/10] esp: execute select commands immediately when it is a non-dma command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 8d73e56..aff8de6 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -270,7 +270,7 @@ static void handle_satn(ESPState *s) uint8_t buf[32]; int len;

[Qemu-devel] [PATCH 4/9] usb-ehci: Fix an assert whenever isoc transfers are used

2012-07-09 Thread Gerd Hoffmann
From: Hans de Goede hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket it uses for isoc transfers, triggering an assert (taking the entire vm down) in usb_packet_setup as soon as any isoc transfers are done by a high speed USB device. Signed-off-by: Hans de Goede Signed-o

[Qemu-devel] [PATCH 2/9] ehci: fix td writeback

2012-07-09 Thread Gerd Hoffmann
Only write back the dwords the hc is supposed to update. Should not make a difference in theory as the guest must not touch the td while it is active to avoid races. But it is still more correct. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |6 -- 1 files changed, 4 insertions(+)

[Qemu-devel] [PATCH v3 07/10] esp: split esp code into generic chip emulation and sysbus layer

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 162 -- 1 file changed, 95 insertions(+), 67 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index d9dd2aa..796cdc1 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -44,12 +44,9 @@ typedef struct E

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-09 Thread igor
On 06/20/2012 03:35 PM, Andreas Färber wrote: Am 20.06.2012 14:59, schrieb Igor Mammedov: It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) when not all properties are set (APIC in this case). Fix it by calling x86_cpu_realize() at board level after APIC is initialized, rig

[Qemu-devel] [PATCH v3 04/10] esp: implement Reset ATN command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 trace-events |1 + 2 files changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index 985a2ee..85078e0 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -113,6 +113,7 @@ struct ESPState { #define CMD_MSGACC 0x12 #define CMD_PAD

[Qemu-devel] [PATCH 5/9] ehci: Kick async schedule on wakeup in the non companion case

2012-07-09 Thread Gerd Hoffmann
From: Hans de Goede Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code to ehci_wakeup to kick the async schedule on wakeup, but the else was positioned wrong making it trigger for devices which are routed to the companion rather then to the ehci controller itself. This patch fixes this.

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >>> If -hda has the semantics of "create an IDE device", then no, we can't >>> change it. It doesn't however. IIRC on -M pseries -hda creates SCSI >>> devices. On s390 -hda creates virtio devices. So if on -M q35 -hda would >>> create if=ahci, I don't see how th

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.07.2012 10:50, schrieb Markus Armbruster: >> Alexander Graf writes: >> >>> We've had support for creating AHCI devices using -device for a while now, >>> but it's cumbersome to users. We really should provide an easier way for >>> them to leverage the power of AHCI! >

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 13:06, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 09.07.2012 10:50, schrieb Markus Armbruster: >>> Alexander Graf writes: >>> We've had support for creating AHCI devices using -device for a while now, but it's cumbersome to users. We really should provid

[Qemu-devel] [PATCH v3 06/10] esp: use hba_private field instead of a complex cast

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index a1f5b8a..d9dd2aa 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -186,7 +186,7 @@ static void esp_dma_enable(void *opaque, int irq, int level) static v

[Qemu-devel] [PATCH 6/9] usb-redir: Correctly handle the usb_redir_babble usbredir status

2012-07-09 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index d949f04..10b4fbb 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Alexander Graf writes: > On 09.07.2012, at 13:06, Markus Armbruster wrote: > >> Kevin Wolf writes: >> >>> Am 09.07.2012 10:50, schrieb Markus Armbruster: Alexander Graf writes: > We've had support for creating AHCI devices using -device for a while now, > but it's cumbersome

[Qemu-devel] [PATCH v3 05/10] esp: support future change of chip_id

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/esp.c b/hw/esp.c index 85078e0..a1f5b8a 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -50,6 +50,7 @@ struct ESPState { uint8_t wregs[ESP_REGS]; qemu_irq irq; uint32_

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 13:19, Markus Armbruster wrote: > Alexander Graf writes: > >> On 09.07.2012, at 13:06, Markus Armbruster wrote: >> >>> Kevin Wolf writes: >>> Am 09.07.2012 10:50, schrieb Markus Armbruster: > Alexander Graf writes: > >> We've had support for creating AHCI

[Qemu-devel] [PATCH 7/9] usb: split endpoint init and reset

2012-07-09 Thread Gerd Hoffmann
Create a new usb_ep_reset() function to reset endpoint state, without re-initialiting the queues, so we don't unlink in-flight packets just because usb-host has to re-parse the descriptor tables. Signed-off-by: Gerd Hoffmann --- hw/usb.h|1 + hw/usb/core.c | 13 ++

[Qemu-devel] [PATCH v3 03/10] esp: implement Disable selection command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 ++ trace-events |1 + 2 files changed, 7 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index ac91f00..985a2ee 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -117,6 +117,7 @@ struct ESPState { #define CMD_SELATN 0x42 #define CMD_SELA

[Qemu-devel] [PATCH 1/9] ehci: fix ehci_qh_do_overlay

2012-07-09 Thread Gerd Hoffmann
Use ehci_flush_qh to make sure we touch inly the fields the hc is allowed to touch. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 1582c2

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-09 Thread Paolo Bonzini
Il 09/07/2012 12:19, Fabien Chouteau ha scritto: > Any comment? Looks good to me. Blue, can you apply it while Anthony is on holiday? Paolo > On 07/04/2012 01:04 PM, Fabien Chouteau wrote: >> The goal is to make ctrl-a x to close Qemu in a clean way. The current >> exit(0) skips a lot of cleanu

[Qemu-devel] [PULL 0/9] usb patch queue

2012-07-09 Thread Gerd Hoffmann
Hi, Here comes the most recent usb patch queue, featuring a collection of little bug fixes all over the place. See individual patches for details. please pull, Gerd The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit

[Qemu-devel] [PATCH 9/9] usb-host: add trace events for iso xfers

2012-07-09 Thread Gerd Hoffmann
Replace iso transfer fprintf's with trace points. Also rename existing tracepoints so they all match usb_host_iso_*. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 10 ++ trace-events|6 -- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/usb/

[Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Peter Maydell
For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. Update the documentation to use 'help' rather than '?', since '?' is a shell metacharacter and thus prone to fail confusin

Re: [Qemu-devel] [PATCH v2 1/3] KVM: Add new -cpu best

2012-07-09 Thread Alexander Graf
On 02.07.2012, at 16:25, Avi Kivity wrote: > On 06/26/2012 07:39 PM, Alexander Graf wrote: >> During discussions on whether to make -cpu host the default in SLE, I found >> myself disagreeing to the thought, because it potentially opens a big can >> of worms for potential bugs. But if I already a

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Eric Blake
On 07/09/2012 05:52 AM, Peter Maydell wrote: > For command line options which permit '?' meaning 'please list the > permitted values', add support for 'help' as a synonym, by abstracting > the check out into a helper function. > > Update the documentation to use 'help' rather than '?', since '?' >

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Peter Maydell
On 9 July 2012 13:07, Eric Blake wrote: > That is, we are filtering based on the explicit presence of a literal > '?' in the help output to determine whether we can further filter based > on '-device device,?' queries without confusing qemu or libvirt; > changing the 'help' output means that old l

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:19, schrieb Fabien Chouteau: > Any comment? > > On 07/04/2012 01:04 PM, Fabien Chouteau wrote: >> The goal is to make ctrl-a x to close Qemu in a clean way. The current >> exit(0) skips a lot of cleanup/close functions, for example in block >> drivers. >> >> Signed-off-by: Fabien

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Eric Blake
On 07/09/2012 06:10 AM, Peter Maydell wrote: > On 9 July 2012 13:07, Eric Blake wrote: >> That is, we are filtering based on the explicit presence of a literal >> '?' in the help output to determine whether we can further filter based >> on '-device device,?' queries without confusing qemu or libv

Re: [Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 12:45, Paolo Bonzini wrote: > Il 09/07/2012 12:39, Gerd Hoffmann ha scritto: >> On 07/09/12 12:33, Gerd Hoffmann wrote: >>> Hi, >>> >>> v2 of the usb attached scsi emulation patches. Patch #1 is almost >>> unmodified compared to v1. Patch #2 is new and makes UAS emulation >>> use th

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 06:07:48AM -0600, Eric Blake wrote: > On 07/09/2012 05:52 AM, Peter Maydell wrote: > > For command line options which permit '?' meaning 'please list the > > permitted values', add support for 'help' as a synonym, by abstracting > > the check out into a helper function. > >

[Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-07-09 Thread Peter Maydell
Proposed patch that would allow '-cpu help' &co: http://patchwork.ozlabs.org/patch/169798/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1022331 Title: -cpu ? causes confusion when directory has 1-

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:27, schrieb Peter Maydell: > Ping? [patchwork url http://patchwork.ozlabs.org/patch/167132/] > > -- PMM > > On 25 June 2012 15:55, Peter Maydell wrote: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual address width is only 32 bits.

[Qemu-devel] [Bug 989225] Re: windows XP Standard PC HAL does not work with qemu-kvm >= 0.15

2012-07-09 Thread Michael Chudobiak
This seems to be fixed in Fedora rawhide packages. Works for me now with: This issue seems to be fixed in current rawhide packages: qemu-common.x86_64 2:1.1.0-4.fc18 qemu-img.x86_64 2:1.1.0-4.fc18 qemu-kv

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:59, schrieb igor: > On 06/20/2012 03:35 PM, Andreas Färber wrote: >> Am 20.06.2012 14:59, schrieb Igor Mammedov: >>> It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) >>> when not all properties are set (APIC in this case). >>> >>> Fix it by calling x86_cpu_rea

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Markus Armbruster
Eric Blake writes: > On 07/09/2012 06:10 AM, Peter Maydell wrote: >> On 9 July 2012 13:07, Eric Blake wrote: >>> That is, we are filtering based on the explicit presence of a literal >>> '?' in the help output to determine whether we can further filter based >>> on '-device device,?' queries wit

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
On 9 July 2012 13:45, Andreas Färber wrote: > Am 09.07.2012 12:27, schrieb Peter Maydell: >> On 25 June 2012 15:55, Peter Maydell wrote: >>> In our disassembly code, the bfd_vma type is always 64 bits, >>> even if the target's virtual address width is only 32 bits. This >>> means that when we pri

[Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Mike Frysinger
The current bss clear logic assumes the target mmap address and host address are the same. Use g2h to translate from the target address space to the host so we can call memset on it. Signed-off-by: Mike Frysinger --- linux-user/flatload.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Peter Maydell
On 9 July 2012 14:04, Mike Frysinger wrote: > The current bss clear logic assumes the target mmap address and host > address are the same. Use g2h to translate from the target address > space to the host so we can call memset on it. > > Signed-off-by: Mike Frysinger Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 25.06.2012 16:55, schrieb Peter Maydell: > In our disassembly code, the bfd_vma type is always 64 bits, > even if the target's virtual address width is only 32 bits. This > means that when we print out addresses we need to truncate them > to 32 bits, to avoid odd output which has incorrectly sig

Re: [Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Andreas Färber
Hi Mike, Am 09.07.2012 15:04, schrieb Mike Frysinger: > The current bss clear logic assumes the target mmap address and host > address are the same. Use g2h to translate from the target address > space to the host so we can call memset on it. > > Signed-off-by: Mike Frysinger > --- > linux-use

[Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Alexander Graf
When just calling ./configure on my box, I always ran into the same issue: In file included from /usr/include/nss3/pkcs11t.h:1780, from /usr/include/nss3/keythi.h:41, from /usr/include/nss3/keyt.h:41, from /usr/include/nss3/pk11pub.h:43,

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
On 9 July 2012 14:19, Andreas Färber wrote: > Am 25.06.2012 16:55, schrieb Peter Maydell: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual address width is only 32 bits. This >> means that when we print out addresses we need to truncate them >> to 32

[Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Alexander Graf
When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the max

[Qemu-devel] [PATCH 0/3] Add -cpu best support

2012-07-09 Thread Alexander Graf
This patch set implements support for a sane default CPU type, that plays the middle ground between -cpu host (unmanagable test matrix) and -cpu qemu64 (breaks assumptions wrt family/model numbers). It also makes it the default for -M pc, so that users who don't specify a specific CPU type on the

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Andreas Färber
Am 09.07.2012 14:06, schrieb Alexander Graf: > When just calling ./configure on my box, I always ran into the same issue: > > In file included from /usr/include/nss3/pkcs11t.h:1780, > from /usr/include/nss3/keythi.h:41, > from /usr/include/nss3/keyt.h:41, >

[Qemu-devel] [PATCH v3 3/3] i386: KVM: List -cpu host and best in -cpu ?

2012-07-09 Thread Alexander Graf
The kvm_enabled() helper doesn't work in a function as early as -cpu ? yet. It also doesn't make sense to list the -cpu ? output conditional on the -enable-kvm parameter. So let's always mention -cpu host in the CPU list when KVM is supported on that configuration. In addition, this patch also add

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 14:06, Alexander Graf wrote: > When just calling ./configure on my box, I always ran into the same issue: > > In file included from /usr/include/nss3/pkcs11t.h:1780, > from /usr/include/nss3/keythi.h:41, > from /usr/include/nss3/keyt.h:41, >

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 15:29, Gerd Hoffmann wrote: > On 07/09/12 14:06, Alexander Graf wrote: >> When just calling ./configure on my box, I always ran into the same issue: >> >> In file included from /usr/include/nss3/pkcs11t.h:1780, >> from /usr/include/nss3/keythi.h:41, >>

  1   2   3   >