Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-04 Thread Orit Wasserman
On 07/03/2012 10:49 PM, Eric Blake wrote: > On 07/03/2012 01:23 PM, Blue Swirl wrote: > >>> + >>> +static inline int64_t round2pow2(int64_t value) > > round up or down? > >>> +{ >>> +while (!is_power_of_2(value)) { >>> +value &= ~(1 << (ffs(value) - 1)); >> >> ffs() only uses 'int',

Re: [Qemu-devel] [PATCH v14 07/13] Add debugging infrastructure

2012-07-04 Thread Orit Wasserman
On 07/03/2012 10:25 PM, Blue Swirl wrote: > On Tue, Jul 3, 2012 at 1:52 PM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> --- >> arch_init.c | 33 +++-- >> 1 files changed, 27 insertions(+), 6 deletions(-) >> >> diff --git a/arch_init.c b/arch_init.c >>

Re: [Qemu-devel] [PATCH v14 09/13] Add migration_end function

2012-07-04 Thread Orit Wasserman
On 07/03/2012 11:38 PM, Eric Blake wrote: > On 07/03/2012 07:52 AM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> --- >> arch_init.c |7 ++- >> 1 files changed, 6 insertions(+), 1 deletions(-) > > You failed to account for my v13 review that you missed a hunk in this > patch

Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-04 Thread Orit Wasserman
On 07/04/2012 12:32 AM, Eric Blake wrote: > On 07/03/2012 07:52 AM, Orit Wasserman wrote: >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman > >> +int xbzrle_encode_buffer(uint8_t *old_buf, uint8_t *new_buf, int slen

Re: [Qemu-devel] [PATCH 08/14] megasas: LSI Megaraid SAS HBA emulation

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 07:52, Hannes Reinecke ha scritto: >>> >> +const char *mfi_frame_desc[] = { >> > >> > Missing 'static'. >> > > If you insist ... > > [ .. ] > > Hey, cool. Just one issue. > > Paolo, can you fix it up in your tree or should I re-send the patch? Neither. Send the fix to qemu-triv

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-04 Thread Paolo Bonzini
Il 03/07/2012 21:09, Blue Swirl ha scritto: >> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest >> > *req, uint8_t *outbuf) >> > outbuf[buflen++] = 0; // not officially assigned >> > outbuf[buflen++] = 0; // reserved >> > outbuf[buf

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 04:14, Wayne Xia ha scritto: > >> of the internal structure inside - be it raw, or qcow, or anything else. >> So, if you specify the format of the device explicitly, by using >> format=raw, only single connection will be made. > thanks, that helped me. A bit more question: is there

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 19:03, schrieb Eric Blake: 2. drive_add file=/dev/fdset/1 -> qemu_open uses the first fd from the set that has access flags matching the qemu_open action flags. qemu_open increments refcount for this fd. 3. add-fd /dev/fdset/1 FDSET={M} -> qemu adds fd to set named

Re: [Qemu-devel] plan for device assignment upstream

2012-07-04 Thread Avi Kivity
On 07/03/2012 10:06 PM, Blue Swirl wrote: > On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: >> On 07/02/2012 12:30 PM, Jan Kiszka wrote: >>> On 2012-07-02 11:18, Michael S. Tsirkin wrote: I've been thinking hard about Jan's patches for device assignment. Basically while I thought it ma

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 20:21, schrieb Corey Bryant: > On 07/03/2012 02:00 PM, Eric Blake wrote: >> On 07/03/2012 11:46 AM, Corey Bryant wrote: >> >>> >>> Yes, I think adding a +1 to the refcount for the monitor makes sense. >>> >>> I'm a bit unsure how to increment the refcount when a monitor reconnects >>>

Re: [Qemu-devel] [PATCH 0/2] pci: exit path cleanup and fix

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 06:39, Alex Williamson ha scritto: > We've currently got a bug in pci_unregister_device in the ordering of > calling the driver exit function and unregistering io regions. In > every driver memory regions are created in the init function and > destroyed in the exit function. By call

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 20:40, schrieb Blue Swirl: > On Sat, Jun 30, 2012 at 5:50 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster >>> wrote: Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into bloc

Re: [Qemu-devel] [PATCH v14 03/13] Add XBZRLE documentation

2012-07-04 Thread Orit Wasserman
On 07/03/2012 10:45 PM, Eric Blake wrote: > On 07/03/2012 07:52 AM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> --- >> docs/xbzrle.txt | 133 >> +++ >> 1 files changed, 133 insertions(+), 0 deletions(-) >> create mode 100644 doc

Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 21:19, schrieb Blue Swirl: > On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf wrote: >> Am 09.06.2012 14:12, schrieb Blue Swirl: >>> Move logging functions from exec.c to qemu-log.c, >>> compile it only once. >>> >>> Signed-off-by: Blue Swirl >> >> This broke the TARGET_I386 specific log

Re: [Qemu-devel] [PATCH 3/6] sheepdog: use coroutine based socket functions in coroutine context

2012-07-04 Thread Kevin Wolf
Am 04.07.2012 02:25, schrieb Peter Crosthwaite: > On Tue, Jul 3, 2012 at 11:15 PM, Kevin Wolf wrote: >> Am 27.06.2012 00:26, schrieb MORITA Kazutaka: >>> This removes blocking network I/Os in coroutine context. >>> >>> Signed-off-by: MORITA Kazutaka >>> --- >>> block/sheepdog.c | 10 --

Re: [Qemu-devel] q35 and ahci

2012-07-04 Thread Alexander Graf
On 04.07.2012, at 03:29, Jason Baron wrote: > On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: >> On 03.07.2012, at 22:37, Jason Baron wrote: >> >>> On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: On 03.07.2012, at 20:46, Jason Baron wrote: > On Tue,

[Qemu-devel] [PATCH] cleanup pc_vga_init function

2012-07-04 Thread Wanpeng Li
From: Wanpeng Li Since function pc_vga_init doesn't need to return DeviceState any more, just cleanup. Signed-off-by: Wanpneg Li --- hw/pc.c | 18 +++--- hw/pc.h |2 +- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index c7e9ab3..f387448

[Qemu-devel] [PATCH v7 5/6] fdc_test: update media_change test

2012-07-04 Thread Pavel Hrdina
After rewrite DSKCHG bit handling the test has to be updated. Now is needed to seek to different track to clear DSKCHG bit. Signed-off-by: Pavel Hrdina --- tests/fdc-test.c | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/tests/fdc-test.c b/t

[Qemu-devel] [PATCH v7 6/6] fdc_test: introduce test_sense_interrupt

2012-07-04 Thread Pavel Hrdina
Calling sense interrupt status while there is no interrupt should return invalid command (0x80). Read command should always returns in st0 seek_end bit set to 1. Signed-off-by: Pavel Hrdina --- tests/fdc-test.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-07-04 Thread Igor Mammedov
On 06/08/2012 03:04 PM, Andreas Färber wrote: Am 08.06.2012 14:52, schrieb Jan Kiszka: On 2012-06-08 14:47, Igor Mammedov wrote: - Original Message - From: "Jan Kiszka" To: "Andreas Färber" Cc: "Igor Mammedov" , "Anthony Liguori" , qemu-devel@nongnu.org, "Igor Mammedov" , "Paolo Bon

[Qemu-devel] [PATCH v3 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-07-04 Thread Maksim Kozlov
Add using of functionality provided by CMU - get_rate and register_clock_handler. Signed-off-by: Maksim Kozlov --- hw/exynos4210_uart.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_u

[Qemu-devel] [PATCH v3 0/2] ARM: Samsung Exynos4210 CMU support

2012-07-04 Thread Maksim Kozlov
Changelog: v2->v3: - hw/exynos4210_cmu.c: debug output was disabled by default v1->v2: - hw/exynos4210_cmu.c: the 'const' qualifier was added to global structures and arrays which shouldn't be changed in runtime. Also, useless type casts were deleted. - hw/exynos4210_ua

[Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
Add exynos4210 Clock Management Units emulation Signed-off-by: Maksim Kozlov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16 + hw/exynos4210.h | 42 ++ hw/exynos4210_cmu.c | 1464 ++ 4 files changed, 1523 insertions(+), 0 de

Re: [Qemu-devel] [PATCH 0/6] blkdebug changes extracted from 1.2 streaming patches

2012-07-04 Thread Kevin Wolf
Am 06.06.2012 08:10, schrieb Paolo Bonzini: > Hi, > > these patches are prerequisites for testing streaming error handling. > They should be useful on their own, so I am sending them early to keep > the queue small. > > Paolo Bonzini (6): > blkdebug: remove sync i/o events > blkdebug: tiny cl

Re: [Qemu-devel] [PATCH 00/13] ARM: Add LPAE support

2012-07-04 Thread Peter Maydell
On 28 June 2012 15:35, Peter Maydell wrote: > It's possible that making target_phys_addr_t 64 bits for > all ARM cores might be a slight slowdown (though only in > system mode, and not in the fast path of a TLB hit for a > RAM access). Benchmarking this is on my todo list, but I wanted > to put th

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 21:45, schrieb Michael Tokarev: > On 03.07.2012 15:05, xiaw...@linux.vnet.ibm.com wrote: >> From: Wenchao Xia >> >> Qemu system emulator reports only fails that make people confused >> about why, when it is invoked with nbd block device tring to connect >> qemu-nbd server. In fact

[Qemu-devel] [PATCH] megasas: mark mfi_frame_desc as 'static'

2012-07-04 Thread Hannes Reinecke
Suggested by blue swirl. Patch is on top of Paolo's scsi-next tree. Signed-off-by: Hannes Reinecke Cc: Paolo Bonzini Cc: Blue Swirl --- hw/megasas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/megasas.c b/hw/megasas.c index b48836f..b99fa97 100644 --- a/hw/mega

Re: [Qemu-devel] race condition in qemu-kvm-1.0.1

2012-07-04 Thread Peter Lieven
On 07/03/12 17:54, Marcelo Tosatti wrote: On Wed, Jun 27, 2012 at 12:35:22PM +0200, Peter Lieven wrote: Hi, we recently came across multiple VMs racing and stopping working. It seems to happen when the system is at 100% cpu. One way to reproduce this is: qemu-kvm-1.0.1 with vnc-thread enabled

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 17:07, schrieb Fabien Chouteau: > On 07/03/2012 04:49 PM, Paolo Bonzini wrote: >> Il 03/07/2012 16:00, Peter Maydell ha scritto: >>> I was just talking on #qemu this morning about the equivalent question >>> of whether the ARM semihosting exit function ought to be doing a >>> qemu_sys

[Qemu-devel] [PATCH] MAINTAINERS: mark megasas as maintained

2012-07-04 Thread Hannes Reinecke
Add maintainers entry for megasas. Patch is on top of Paolo's scsi-next tree. Signed-off-by: Hannes Reinecke Cc: Paolo Bonzini --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2a514fd..e67c84f 100644 --- a/MAINTAINERS

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 15:51, schrieb Paolo Bonzini: > Il 03/07/2012 15:49, Kevin Wolf ha scritto: >>> If the guest does not support flushes, we should run in writethrough mode. The setting is temporary until the next reset, so that for example the BIOS will run in writethrough mode while Linux wi

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-04 Thread Fabien Chouteau
On 07/04/2012 12:07 PM, Kevin Wolf wrote: > Am 03.07.2012 17:07, schrieb Fabien Chouteau: >> On 07/03/2012 04:49 PM, Paolo Bonzini wrote: >>> Il 03/07/2012 16:00, Peter Maydell ha scritto: I was just talking on #qemu this morning about the equivalent question of whether the ARM semihostin

Re: [Qemu-devel] [PATCH 2/2] block: introduce bdrv_swap, implement bdrv_append on top of it

2012-07-04 Thread Kevin Wolf
Am 14.06.2012 16:55, schrieb Paolo Bonzini: > +/* > + * Add new bs contents at the top of an image chain while the chain is > + * live, while keeping required fields on the top layer. > + * > + * This will modify the BlockDriverState fields, and swap contents > + * between bs_new and bs_top. Both b

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-04 Thread Kevin Wolf
Am 04.07.2012 12:27, schrieb Fabien Chouteau: > On 07/04/2012 12:07 PM, Kevin Wolf wrote: >> Am 03.07.2012 17:07, schrieb Fabien Chouteau: >>> On 07/03/2012 04:49 PM, Paolo Bonzini wrote: Il 03/07/2012 16:00, Peter Maydell ha scritto: > I was just talking on #qemu this morning about the eq

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Dunrong Huang
2012/7/4 Maksim Kozlov : > Add exynos4210 Clock Management Units emulation > > Signed-off-by: Maksim Kozlov > --- > hw/arm/Makefile.objs |1 + > hw/exynos4210.c | 16 + > hw/exynos4210.h | 42 ++ > hw/exynos4210_cmu.c | 1464 > ++

Re: [Qemu-devel] plan for device assignment upstream

2012-07-04 Thread Michael S. Tsirkin
On Mon, Jul 02, 2012 at 12:43:48PM +0300, Avi Kivity wrote: > On 07/02/2012 12:30 PM, Jan Kiszka wrote: > > On 2012-07-02 11:18, Michael S. Tsirkin wrote: > >> I've been thinking hard about Jan's patches for device > >> assignment. Basically while I thought it makes sense > >> to make all devices:

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-04 Thread Fabien Chouteau
On 07/04/2012 12:32 PM, Kevin Wolf wrote: > Am 04.07.2012 12:27, schrieb Fabien Chouteau: >> On 07/04/2012 12:07 PM, Kevin Wolf wrote: >>> Am 03.07.2012 17:07, schrieb Fabien Chouteau: On 07/03/2012 04:49 PM, Paolo Bonzini wrote: > Il 03/07/2012 16:00, Peter Maydell ha scritto: >> I wa

[Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-04 Thread Fabien Chouteau
The goal is to make ctrl-a x to close Qemu in a clean way. The current exit(0) skips a lot of cleanup/close functions, for example in block drivers. Signed-off-by: Fabien Chouteau --- qemu-char.c |2 +- sysemu.h|1 + vl.c|5 + 3 files changed, 7 insertions(+), 1 delet

[Qemu-devel] [PATCH 02/10] hw/exynos4210_pwm.c: Fix STOP status in tick handler.

2012-07-04 Thread Peter Maydell
From: Evgeny Voevodin START/STOP bit was not cleaned correctly. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/exynos4210_pwm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_pwm.c b/hw/exynos4210_pwm.c i

[Qemu-devel] [PATCH 01/10] ARM: hw/exynos4210_mct.c: Fix a bug which hangs Linux kernel.

2012-07-04 Thread Peter Maydell
From: Stanislav Vorobiov After some long period of time Linux kernel hanged due to ptimer_get_count may return 0 before timer interrupt occurs, thus, causing FRC to jump back in time Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- hw/exynos4210_mct.c |4 1 files chang

Re: [Qemu-devel] plan for device assignment upstream

2012-07-04 Thread Avi Kivity
On 07/04/2012 01:42 PM, Michael S. Tsirkin wrote: > On Mon, Jul 02, 2012 at 12:43:48PM +0300, Avi Kivity wrote: >> On 07/02/2012 12:30 PM, Jan Kiszka wrote: >> > On 2012-07-02 11:18, Michael S. Tsirkin wrote: >> >> I've been thinking hard about Jan's patches for device >> >> assignment. Basically w

[Qemu-devel] [PATCH 03/10] hw/exynos4210.c: Fix misleading initialization of IROM mirror

2012-07-04 Thread Peter Maydell
From: Evgeny Voevodin We want to mirror whole IROM and should pass zero instead of EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since memory_region_init_alias takes an offset within an original region as an argument. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell Signed-

[Qemu-devel] [PATCH 09/10] i.MX31: KZM-ARM11-01 evaluation board

2012-07-04 Thread Peter Maydell
From: Peter Chubb Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the Freescale i.MX31. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb Signed-off-by: Peter Maydell --- MAINTAINERS |6 ++ hw/arm/Makefile.objs |1 + hw/kzm.c

Re: [Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen

2012-07-04 Thread Eric Blake
On 07/03/2012 11:15 PM, Shrinidhi Joshi wrote: > On Saturday 16 June 2012 03:41 AM, Eric Blake wrote: >> On 06/15/2012 02:48 PM, Supriya Kannery wrote: >> > raw-posix driver changes for bdrv_reopen_xx functions to >> > safely reopen image files. Reopening of image files while >> > changing hostcac

Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-04 Thread Eric Blake
On 07/04/2012 01:24 AM, Orit Wasserman wrote: >> >>> +ret = uleb128_decode_small(src + i, &count); >>> +if (ret < 0) { >> >> An nzrun should be a non-zero value; I'd write this as (ret <= 0) to >> rule out an attempt to pass a zero-length nzrun. > decode can only return -1 (invalid

[Qemu-devel] [PATCH 06/10] i.MX31: Clock Control Module

2012-07-04 Thread Peter Maydell
From: Peter Chubb For Linux to be able to work out how fast its clocks are going, so that timer ticks come approximately at the right time, it needs to be able to query the clock control module (CCM). This is the start of a CCM implementation. It currently knows only about the MCU, HSP and IPG

Re: [Qemu-devel] [RFC PATCH 0/4] virtio-rng and RngBackend infrastructure (v2)

2012-07-04 Thread Amit Shah
On (Sun) 01 Jul 2012 [23:06:36], Paul Brook wrote: > > This series depends on my QOM -object series that I just posted. > > > > In Amit's thread on virtio-rng, danpb mentioned that we really ought to > > have a proper RNG backend infrastructure and of course he's correct on > > that. > > > > Now

[Qemu-devel] [PATCH 04/10] Exynos4: add RTC device

2012-07-04 Thread Peter Maydell
From: Oleg Ogurtsov Signed-off-by: Oleg Ogurtsov Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 595 ++ 3 files changed, 604 insertions(+), 0 deletions(-) create mode 100644

Re: [Qemu-devel] [RFC][PATCH 0/4] tcg: enhance code generation quality for qemu_ld/st IRs

2012-07-04 Thread Wei-Ren Chen
Hi YeongKyoon, Thanks for your work! But maybe you need to thread your patches so that the parts appear as replies to the cover letter. `git-send-email` shoule enable --thread by deafult. The other thing is you might want to cc to Laurent , he said he would like to review your patch before. :

[Qemu-devel] [PULL 00/10] arm-devs queue

2012-07-04 Thread Peter Maydell
Usual arm-devs pullreq; this contains some minor exynos fixes and the iMX31 model. Please pull. thanks -- PMM The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593: bsd-user: fix build (2012-06-28 20:28:36 +) are available in the git repository at: git://git.linar

[Qemu-devel] [PATCH 08/10] i.MX31: Interrupt Controller

2012-07-04 Thread Peter Maydell
From: Peter Chubb Implement the Freescale i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |2 +- h

[Qemu-devel] [PATCH 05/10] i.MX: UART support

2012-07-04 Thread Peter Maydell
From: Peter Chubb Implement the Freescale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the Freescale i.MX series. This patch gives only a `bare-bones' implementation, enough to run Linux or OKL4, but that's about it. Signed-off-by: Philip O'Sulli

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 12:16, Kevin Wolf ha scritto: >> > Yes. It doesn't override cache=unsafe though. > When the guest doesn't support flushes, cache=writeback is equivalent to > cache=unsafe, so if you want the old behaviour back you can switch to > cache=unsafe without additional risks. > > We don't h

[Qemu-devel] [PATCH 07/10] i.MX31: Timers

2012-07-04 Thread Peter Maydell
From: Peter Chubb Implement the timers on the Freescale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run. In particular external triggers, which are not useful under QEMU, are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chu

[Qemu-devel] [PATCH 10/10] hw/cadence_gem: Make rx_desc_addr and tx_desc_addr uint32_t

2012-07-04 Thread Peter Maydell
Make the state fields rx_desc_addr and tx_desc_addr uint32_t; this matches the VMStateDescription, and also conforms to how hardware works: the registers don't magically become larger if the device is attached to a CPU with a larger physical address size. It also fixes a compile failure if the targ

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-07-04 Thread Shrinidhi Joshi
On Wednesday 20 June 2012 11:48 PM, Jeff Cody wrote: On 06/15/2012 04:47 PM, Supriya Kannery wrote: > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block device. > > Usage: > block_set_hostcache > = block device > = on/off > > Example: > (qemu

[Qemu-devel] [Bug 709584] Re: Fullscreen mode splits screen over monitor boundaries on dual-monitor system

2012-07-04 Thread Frans Bijma
I have the exactly the same problem/behavior. You are not allone! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/709584 Title: Fullscreen mode splits screen over monitor boundaries on dual-monitor

Re: [Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen

2012-07-04 Thread Shrinidhi Joshi
On Saturday 16 June 2012 03:41 AM, Eric Blake wrote: On 06/15/2012 02:48 PM, Supriya Kannery wrote: > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya

Re: [Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-07-04 Thread Peter Maydell
On 29 June 2012 21:38, Stefan Weil wrote: > commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table > type safety which now raises compiler errors when latest QEMU was > configured with --enable-debug. > > Fix this by splitting the SSE tables even further to separate > helper functions

Re: [Qemu-devel] [PATCH 0/2] pci: exit path cleanup and fix

2012-07-04 Thread Michael S. Tsirkin
On Tue, Jul 03, 2012 at 10:39:20PM -0600, Alex Williamson wrote: > We've currently got a bug in pci_unregister_device in the ordering of > calling the driver exit function and unregistering io regions. In > every driver memory regions are created in the init function and > destroyed in the exit fu

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated

2012-07-04 Thread Kevin Wolf
Am 04.07.2012 14:21, schrieb Paolo Bonzini: > Il 04/07/2012 12:16, Kevin Wolf ha scritto: Yes. It doesn't override cache=unsafe though. >> When the guest doesn't support flushes, cache=writeback is equivalent to >> cache=unsafe, so if you want the old behaviour back you can switch to >> cache

Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-04 Thread Orit Wasserman
On 07/04/2012 03:20 AM, Eric Blake wrote: > On 07/03/2012 03:39 PM, Eric Blake wrote: >> On 07/03/2012 03:32 PM, Eric Blake wrote: >> +ret = uleb128_decode_small(src + i, &count); +if (ret < 0) { >>> >>> An nzrun should be a non-zero value; I'd write this as (ret <= 0) to

Re: [Qemu-devel] plan for device assignment upstream

2012-07-04 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 02:24:45PM +0300, Avi Kivity wrote: > On 07/04/2012 01:42 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 02, 2012 at 12:43:48PM +0300, Avi Kivity wrote: > >> On 07/02/2012 12:30 PM, Jan Kiszka wrote: > >> > On 2012-07-02 11:18, Michael S. Tsirkin wrote: > >> >> I've been thin

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 14:50, Kevin Wolf ha scritto: > Before merging the patches (or actually this patch, I think patch 1 is > fairly independent), Yes, it is. > I'd like to hear more opinions on whether we need > the cache parameter split first Ok, let's discuss it next week on the KVM/QEMU call. Gett

[Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid full screen updates for cursor blinking - convert cursor_blink_state to cursor_visible_phase hw/vga.c | 14 +++

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
04.07.2012 14:38, Dunrong Huang пишет: +void exynos4210_register_clock_handler(ClockChangeHandler *func, + Exynos4210Clock clock_id, void *opaque) +{ +ClockChangeEntry *cce = g_malloc0(sizeof(ClockChangeEntry)); +Exynos4210ClockState *clock = exynos4

Re: [Qemu-devel] "object_delete: assertion failed: (obj->ref == 0)" deleting usb-storage from monitor

2012-07-04 Thread Peter Maydell
On 2 July 2012 18:28, Peter Maydell wrote: > If you create a usb-storage device on the qemu command line > and then try to delete it via the monitor, QEMU asserts: > > $ dd if=/dev/zero bs=4096 count=1024 of=usb.img > $ ./i386-softmmu/qemu-system-i386 -clock unix -monitor stdio -usb > -drive if=no

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Peter Maydell
On 4 July 2012 14:45, Maksim Kozlov wrote: > 04.07.2012 14:38, Dunrong Huang пишет: >>> +PRINT_DEBUG("%s rate: %llu\n", pll->name, pll->rate); >> >> pll->rate is of type uint64_t incompatible with "%llu" > > > Type uint64_t is included from /usr/include/stdint.h as > > typedef unsigned long lo

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
04.07.2012 17:54, Peter Maydell пишет: On 4 July 2012 14:45, Maksim Kozlov wrote: 04.07.2012 14:38, Dunrong Huang пишет: +PRINT_DEBUG("%s rate: %llu\n", pll->name, pll->rate); pll->rate is of type uint64_t incompatible with "%llu" Type uint64_t is included from /usr/include/stdint.h a

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Dunrong Huang
> >>> + >>> +static void exynos4210_cmu_set_pll(void *opaque, Exynos4210ClockState >>> *pll) >>> +{ >>> +Exynos4210CmuState *s = opaque; >>> +Exynos4210ClockState *source; >>> +target_phys_addr_t offset = pll->div_reg; >>> +ClockChangeEntry *cce; >>> +uint32_t pdiv, mdiv, sdiv,

Re: [Qemu-devel] [PATCH v8 5/6] fdc_test: update media_change test

2012-07-04 Thread Kevin Wolf
Am 04.07.2012 16:26, schrieb Pavel Hrdina: > After rewrite DSKCHG bit handling the test has to be updated. Now > is needed to seek to different track to clear DSKCHG bit. > > Signed-off-by: Pavel Hrdina > --- > tests/fdc-test.c | 30 ++ > 1 files changed, 22 inserti

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
04.07.2012 18:14, Dunrong Huang пишет: + +static void exynos4210_cmu_set_pll(void *opaque, Exynos4210ClockState *pll) +{ +Exynos4210CmuState *s = opaque; +Exynos4210ClockState *source; +target_phys_addr_t offset = pll->div_reg; +ClockChangeEntry *cce; +uint32_t pdiv, mdiv, s

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-04 Thread Peter Lieven
On 07/03/12 15:25, Avi Kivity wrote: On 07/03/2012 04:15 PM, Peter Lieven wrote: On 03.07.2012 15:13, Avi Kivity wrote: On 07/03/2012 04:01 PM, Peter Lieven wrote: Further output from my testing. Working: Linux 2.6.38 with included kvm module Linux 3.0.0 with included kvm module Not-Working:

Re: [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-07-04 Thread Kevin Wolf
Am 29.06.2012 22:33, schrieb Blue Swirl: > On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: >> Unless parameter ":floppy:" is given, vvfat creates a virtual image >> with DOS MBR defining a single partition which holds the FAT file >> system. The size of the virtual image depends on the

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-04 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: > vvfat creates a virtual VFAT filesystem with a certain logical > geometry that depends on its options. It sets the "geometry hint" to > this geometry. It is the only block driver to do this. > > The geometry hint is about about *physical* geometr

Re: [Qemu-devel] [PATCH 3/6] sheepdog: use coroutine based socket functions in coroutine context

2012-07-04 Thread MORITA Kazutaka
At Tue, 03 Jul 2012 15:15:03 +0200, Kevin Wolf wrote: > > Am 27.06.2012 00:26, schrieb MORITA Kazutaka: > > This removes blocking network I/Os in coroutine context. > > > > Signed-off-by: MORITA Kazutaka > > --- > > block/sheepdog.c | 10 -- > > 1 files changed, 8 insertions(+), 2 del

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-04 Thread Paolo Bonzini
Il 03/07/2012 22:15, Andreas Färber ha scritto: >> > >> > I'd also vote for %u. PRI*32 do not seem very useful compared to plain >> > int versions. > If it's not useful we should use unsigned int. It just means that we're assuming 32-bit ints, which is a fact. The day an IL32 platform appears th

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 17:23, Kevin Wolf ha scritto: >> > optsLCHSdef. PCHS >> >:floppy: 80, 2,36 5,16,63 >> > :32:floppy: 80, 2,36 5,16,63 >> > :16:floppy: 80, 2,36 5,16,63 >> > :12:floppy: 80, 2,18 2,16,63 >> > >> > Silly thing to do for use with a hard

[Qemu-devel] [PATCH v4 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-07-04 Thread Maksim Kozlov
Add using of functionality provided by CMU - get_rate and register_clock_handler. Signed-off-by: Maksim Kozlov --- hw/exynos4210_uart.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_u

[Qemu-devel] [PATCH v4 0/2] ARM: Samsung Exynos4210 CMU support

2012-07-04 Thread Maksim Kozlov
These patches add exynos4210 Clock Management Unit emulation and usage of it by exynos4210 UART Changelog: v3->v4: - added missing 'break' statements and 'default' labels in the _read and _write functions, - 'return' calls in the _read were moved, - useless 'return' was removed fro

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-04 Thread Eric Blake
On 07/04/2012 10:19 AM, Paolo Bonzini wrote: > Il 03/07/2012 22:15, Andreas Färber ha scritto: I'd also vote for %u. PRI*32 do not seem very useful compared to plain int versions. >> If it's not useful we should use unsigned int. > > It just means that we're assuming 32-bit ints, wh

[Qemu-devel] [Bug 1020484] Re: RFE: Support spice via unix domain socket

2012-07-04 Thread Alon Levy
There is already support for that in spice-server afaik, though I don't remember the api or what commit, or if it's in a released version (well, it's surely in 0.11.0, but that's unstable). Sorry about the lack of details, I suggest you search spice-devel mailing list archive though. I think libvir

[Qemu-devel] [PATCH] sheepdog: always use coroutine-based network functions

2012-07-04 Thread MORITA Kazutaka
This reduces some code duplication. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 113 ++--- 1 files changed, 47 insertions(+), 66 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 6e73efb..4958672 100644 --- a/block/she

[Qemu-devel] [PATCH v3 11/14] unin_pci: QOM'ify UniNorth PCI host bridges

2012-07-04 Thread Andreas Färber
Introduce type constants and cast macros. Avoid accessing parent fields directly. Signed-off-by: Andreas Färber --- hw/unin_pci.c | 133 ++--- 1 files changed, 70 insertions(+), 63 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index

[Qemu-devel] [PATCH v3 04/14] dec_pci: QOM'ify DEC 21154 PCI-PCI bridge

2012-07-04 Thread Andreas Färber
Introduce type constant. Introduce cast macro and drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Signed-off-by: Andreas Färber --- hw/dec_pci.c | 21 +++-- hw/dec_pci.h |2 ++ 2 files changed, 1

[Qemu-devel] [PATCH v3 02/14] alpha_typhoon: QOM'ify Typhoon PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant and cast macro. Don't access DeviceState indirectly through parent fields. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/alpha_typhoon.c b/hw/alpha_typhoon.c index cc63737..

Re: [Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
On 2012-07-04 18:26, Stefan Weil wrote: > Hi Jan, > > please see my comments below. > > > Am 04.07.2012 15:40, schrieb Jan Kiszka: >> Let the text cursor blink at 5 Hz. No timer is used, instead we rely on >> the fact that the display is updated periodically. >> >> Signed-off-by: Jan Kiszka >> -

[Qemu-devel] [PATCH v3 12/14] pci_host: Turn into SysBus-derived QOM type

2012-07-04 Thread Andreas Färber
From: Andreas Färber The preceding commits fixed misuses of FROM_SYSBUS() that led people to add a bogus busdev field. For qdev the field order was less relevant but for QOM the PCIHostState field (including the SysBusDevice actually initialized with a value) must be placed first within the state

[Qemu-devel] [PATCH v3] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
Let the text cursor blink at 1.875 Hz, the original VGA cursor frequency. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v3: - adjusted frequency to original value - fixed semantic of VGA_TEXT_CURSOR_PERIOD_MS

[Qemu-devel] [PATCH v3 05/14] grackle_pci: QOM'ify Grackle PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Drop no-op reset function. Signed-off-by: Andreas Färber --- hw/grackle_pci.c | 57 ++

[Qemu-devel] [PATCH v3 03/14] bonito: QOM'ify Bonito PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant. Avoid accessing DeviceState or SysBusDevice indirectly through PCIHostState field. Drop global state by passing BonitoState as opaque and adding the IRQs and a pointer to PCIBonitoState to its state. Signed-off-by: Andreas Färber --- hw/bonito.c | 146 +

[Qemu-devel] [PATCH v3 08/14] ppce500_pci: QOM'ify e500 PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing parent fields directly. Signed-off-by: Andreas Färber --- hw/ppce500_pci.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 99748b3..e4f065a 100644 --- a/hw/p

[Qemu-devel] [PATCH v3 00/14] pci_host: Convert to QOM

2012-07-04 Thread Andreas Färber
Hello Michael, This series makes pci_host a proper QOM type, now using explicit PCI_HOST_BRIDGE naming and splitting off cleanups grouped by device, so that we can see where exactly the type introduction is making a change. Only compile-tested were typhoon, bonito and ppc440. Please review. I'm

[Qemu-devel] [PATCH v3 06/14] gt64xxx: QOM'ify GT64120 PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() macro that would've broken SYS_BUS_DEVICE(). Avoid accessing DeviceState indirectly through PCIHostState. Signed-off-by: Andreas Färber --- hw/gt64xxx.c | 35 --- 1

[Qemu-devel] [PATCH v3 10/14] spapr_pci: QOM'ify sPAPR PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop bogus busdev field that would've broken SYS_BUS_DEVICE(). Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- hw/spapr_pci.c |8 hw/spapr_pci.h |6 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --g

[Qemu-devel] [PATCH v3 01/14] pci: Make host bridge TypeInfos const

2012-07-04 Thread Andreas Färber
Also give the sPAPR host bridge type registration functions a unique name. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |2 +- hw/bonito.c|4 ++-- hw/dec_pci.c |6 +++--- hw/grackle_pci.c |4 ++-- hw/gt64xxx.c |4 ++-- hw/piix_pci.c |8 +

[Qemu-devel] [PATCH v3 09/14] prep_pci: QOM'ify Raven PCI host bridge

2012-07-04 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing parent fields directly. Also add missing space and braces. Signed-off-by: Andreas Färber --- hw/prep_pci.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index a8cdc2

Re: [Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Stefan Weil
Hi Jan, please see my comments below. Am 04.07.2012 15:40, schrieb Jan Kiszka: Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid full screen updates for cursor blin

[Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-04 Thread Andreas Färber
Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |4 ++-- hw/dec_pci.c |2 +- hw/grackle_pci.c |2 +- hw/gt64xxx.c | 26

[Qemu-devel] [PATCH v3 13/14] pci: Derive PCI host bridges from TYPE_PCI_HOST_BRIDGE

2012-07-04 Thread Andreas Färber
Some typedef'ed their state to PCIHostState. Use a proper struct, and use PCIHostState and PCI_HOST_BRIDGE() where appropriate. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |2 +- hw/bonito.c| 22 +++--- hw/dec_pci.c |4 ++-- hw/grackle_pci.c |

  1   2   >