Re: [Qemu-devel] [RFC V2 PATCH 4/4] virtio-net: add multiqueue support

2012-07-02 Thread Jason Wang
On 07/01/2012 05:43 PM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2012 at 06:04:49PM +0800, Jason Wang wrote: This patch let the virtio-net can transmit and recevie packets through multiuple VLANClientStates and abstract them as multiple virtqueues to guest. A new parameter 'queues' were introdu

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-07-02 Thread Jan Kiszka
On 2012-07-01 21:18, Peter Lieven wrote: > > Am 01.07.2012 um 10:19 schrieb Avi Kivity: > >> On 06/28/2012 10:27 PM, Peter Lieven wrote: >>> >>> Am 28.06.2012 um 18:32 schrieb Avi Kivity: >>> On 06/28/2012 07:29 PM, Peter Lieven wrote: >> Yes. A signal is sent, and KVM returns from the g

Re: [Qemu-devel] [PATCH] msi/msix: added API to set MSI message address and data

2012-07-02 Thread Jan Kiszka
On 2012-07-02 06:28, Alexey Kardashevskiy wrote: > Ping? > > > On 22/06/12 11:15, Alexey Kardashevskiy wrote: >> Added (msi|msix)_set_message() function for whoever might >> want to use them. >> >> Currently msi_notify()/msix_notify() write to these vectors to >> signal the guest about an interru

Re: [Qemu-devel] [RFC V2 PATCH 4/4] virtio-net: add multiqueue support

2012-07-02 Thread Michael S. Tsirkin
On Mon, Jul 02, 2012 at 03:04:00PM +0800, Jason Wang wrote: > On 07/01/2012 05:43 PM, Michael S. Tsirkin wrote: > >On Mon, Jun 25, 2012 at 06:04:49PM +0800, Jason Wang wrote: > >>This patch let the virtio-net can transmit and recevie packets through > >>multiuple > >>VLANClientStates and abstract

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-07-02 Thread Paolo Bonzini
Il 20/06/2012 19:48, Luiz Capitulino ha scritto: > However, we'd change how we use 'desc' and our error classes. 'desc' would > become a string which is filled by a printf-like function (see section 2) and > we'd replace all error classes we have today by the following ones: > > o ParameterError

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-07-02 Thread Peter Lieven
On 02.07.2012 09:05, Jan Kiszka wrote: On 2012-07-01 21:18, Peter Lieven wrote: Am 01.07.2012 um 10:19 schrieb Avi Kivity: On 06/28/2012 10:27 PM, Peter Lieven wrote: Am 28.06.2012 um 18:32 schrieb Avi Kivity: On 06/28/2012 07:29 PM, Peter Lieven wrote: Yes. A signal is sent, and KVM retur

[Qemu-devel] [PATCH] vga: Implement blinking of text cursor

2012-07-02 Thread Jan Kiszka
Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- hw/vga.c | 14 +- hw/vga_int.h |2 ++ 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/hw/vga.c b/hw/vga.c

[Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-02 Thread Jan Kiszka
Let the text console cursor blink at 5 HZ. Signed-off-by: Jan Kiszka --- console.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index 6a463f5..29b0f1c 100644 --- a/console.c +++ b/console.c @@ -28,6 +28,7 @@ //#define D

Re: [Qemu-devel] [PATCH 1/2 v2] scsi bus: introduce hotplug() and hot_unplug() interfaces for SCSI bus

2012-07-02 Thread Paolo Bonzini
Il 21/06/2012 09:54, Cong Meng ha scritto: > Add two interfaces hotplug() and hot_unplug() to scsi bus info. > The embody scsi bus can implement these two interfaces to signal the HBA > driver > of guest kernel to add/remove the scsi device in question. > > Signed-off-by: Cong Meng > Signed-off-

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Stefan Hajnoczi
On Fri, Jun 29, 2012 at 12:51 PM, Peter Crosthwaite wrote: > BTW Yielding is one thing, but the elephant in the room here is > resumption of the coroutine. When AIO yields my coroutine I i need to > talk to AIO to get it unyielded (Stefans propsoed edit to my code). > What happens when tommorow so

Re: [Qemu-devel] [PATCH 07/17] x86: improve SSE table type safety

2012-07-02 Thread Markus Armbruster
Blue Swirl writes: > SSE function tables could easily be corrupted because of use > of void pointers. > > Introduce function pointer types and helper variables in order > to improve type safety. > > Split sse_op_table3 according to types used. > > Signed-off-by: Blue Swirl Clean build on master

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 6:50 PM, Stefan Hajnoczi wrote: > On Fri, Jun 29, 2012 at 12:51 PM, Peter Crosthwaite > wrote: >> BTW Yielding is one thing, but the elephant in the room here is >> resumption of the coroutine. When AIO yields my coroutine I i need to >> talk to AIO to get it unyielded (Ste

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Kevin Wolf
Am 02.07.2012 10:57, schrieb Peter Crosthwaite: > On Mon, Jul 2, 2012 at 6:50 PM, Stefan Hajnoczi wrote: >> On Fri, Jun 29, 2012 at 12:51 PM, Peter Crosthwaite >> wrote: >>> BTW Yielding is one thing, but the elephant in the room here is >>> resumption of the coroutine. When AIO yields my corouti

Re: [Qemu-devel] SMP for PReP architecture

2012-07-02 Thread Eli Lewis
Thank you for your replay. I need to modify and test a very simple kernel (actually running on a single-core only) on a multi-core PReP platform; I currently have no real multi-core HW so I am looking for a multi-core PReP emulator. Eli - Original Message - From: Alexander Graf To:

Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access

2012-07-02 Thread Avi Kivity
On 06/29/2012 07:37 PM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also ap

Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access

2012-07-02 Thread Avi Kivity
On 07/02/2012 12:07 PM, Avi Kivity wrote: > > Reviewed-by: Avi Kivity (for the entire patchset) -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Igor Mitsyanko
On 07/01/2012 07:26 PM, Paolo Bonzini wrote: Il 29/06/2012 14:26, Andreas Färber ha scritto: Oh, I see. Should we place this device to hw/Makefile.objs in v2? That would've been nice, but I'll do it as a follow-up now. Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introducing CONFIG

Re: [Qemu-devel] [PATCH 0/2] cpu-common.h: remove pointless ifdef guards

2012-07-02 Thread Stefan Hajnoczi
On Fri, Jun 22, 2012 at 12:30:57PM +0100, Peter Maydell wrote: > These patches remove a couple of pointless ifdef guards in cpu-common.h > that I happened to notice. > > Peter Maydell (2): > cpu-common.h: Remove unnecessary guard on including targphys.h > cpu-common.h: Remove a pointless ifnde

Re: [Qemu-devel] [PATCH] configure: Remove help for --disable-vnc-thread, --enable-vnc-thread

2012-07-02 Thread Stefan Hajnoczi
On Thu, Jun 28, 2012 at 05:56:37PM +0200, Stefan Weil wrote: > Commit 2624bab836662d37f08336408a99d97652fc9c4d removed these > configure arguments. Now the help text for both is removed, too. > > Signed-off-by: Stefan Weil > --- > configure |2 -- > 1 file changed, 2 deletions(-) Thanks, ap

Re: [Qemu-devel] SMP for PReP architecture

2012-07-02 Thread Alexander Graf
On 02.07.2012, at 11:05, Eli Lewis wrote: > Thank you > for your replay. Please don't top-post :). > I need to modify > and test a very simple kernel (actually running on a single-core only) on > a multi-core PReP platform; I currently have no real multi-core HW so I am > looking > for a multi-

[Qemu-devel] plan for device assignment upstream

2012-07-02 Thread Michael S. Tsirkin
I've been thinking hard about Jan's patches for device assignment. Basically while I thought it makes sense to make all devices: assignment and not - behave the same and use same APIs for injecting irqs, Anthony thinks there is huge value in making irq propagation hierarchical and device assignment

[Qemu-devel] [PATCH 1/3] scsi: introduce hotplug() and hot_unplug() interfaces for SCSI bus

2012-07-02 Thread Paolo Bonzini
From: Cong Meng Add two interfaces hotplug() and hot_unplug() to scsi bus info. The scsi bus can implement these two interfaces to signal the HBA driver of guest kernel to add/remove the scsi device in question. Signed-off-by: Sen Wang Signed-off-by: Cong Meng [ Fixed braces and indentation -

Re: [Qemu-devel] plan for device assignment upstream

2012-07-02 Thread Avi Kivity
On 07/02/2012 12:18 PM, Michael S. Tsirkin wrote: > I've been thinking hard about Jan's patches for device > assignment. Basically while I thought it makes sense > to make all devices: assignment and not - behave the > same and use same APIs for injecting irqs, Anthony thinks there is huge > value

Re: [Qemu-devel] plan for device assignment upstream

2012-07-02 Thread Jan Kiszka
On 2012-07-02 11:18, Michael S. Tsirkin wrote: > I've been thinking hard about Jan's patches for device > assignment. Basically while I thought it makes sense > to make all devices: assignment and not - behave the > same and use same APIs for injecting irqs, Anthony thinks there is huge > value in

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Peter Maydell
On 2 July 2012 10:08, Igor Mitsyanko wrote: > So, what's the consensus here, for now new devices go to > hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific > devices (not just exynos-related) from hw/arm/Makefile.objs to > hw/Makefile.objs with one commit? Because having on

[Qemu-devel] [PATCH 0/3] scsi: Implement hotplug support for virtio-scsi

2012-07-02 Thread Paolo Bonzini
Here are Cong Meng's patches, rebased and including support for missed events. I'm keeping them out of the next pull request, waiting for test results from Cong Meng with any updated kernel patches he might have. Cong, they are on top of the scsi-next branch on github. Cong Meng (2): scsi: int

[Qemu-devel] [PATCH 1/3] cpu-common.h: Remove unnecessary guard on including targphys.h

2012-07-02 Thread Stefan Hajnoczi
From: Peter Maydell There's no need to make the include of targphys.h conditional on whether TARGET_PHYS_ADDR_BITS is defined, because targphys.h itself checks that and does nothing if it isn't. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- cpu-c

[Qemu-devel] [PULL 0/3] Trivial patches for June 22 to 2 July 2012

2012-07-02 Thread Stefan Hajnoczi
I will be away from 3 - 11 July. Here is the current trivial-patches queue. The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593: bsd-user: fix build (2012-06-28 20:28:36 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patche

[Qemu-devel] [PATCH 2/3] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY

2012-07-02 Thread Stefan Hajnoczi
From: Peter Maydell Remove an ifndef CONFIG_USER_ONLY guard that was pointless because it is already inside an if !defined(CONFIG_USER_ONLY). Signed-off-by: Peter Maydell Acked-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- cpu-common.h |2 -- 1 file changed, 2 deletions(-) diff

[Qemu-devel] [PATCH 3/3] configure: Remove help for --disable-vnc-thread, --enable-vnc-thread

2012-07-02 Thread Stefan Hajnoczi
From: Stefan Weil Commit 2624bab836662d37f08336408a99d97652fc9c4d removed these configure arguments. Now the help text for both is removed, too. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure |2 -- 1 file changed, 2 deletions(-) diff --git a/configure b/configur

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 11:31, Peter Maydell ha scritto: > On 2 July 2012 10:08, Igor Mitsyanko wrote: >> So, what's the consensus here, for now new devices go to >> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >> devices (not just exynos-related) from hw/arm/Makefile.objs to >

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: do not blindly memset all read buffers

2012-07-02 Thread MORITA Kazutaka
At Fri, 29 Jun 2012 17:38:24 +0200, Christoph Hellwig wrote: > > > > > goto done; > > > } > > > - > > > -create = 1; > > > -} else if (acb->aiocb_type == AIOCB_WRITE_UDATA > > > - && !is_data_obj_writable(inode, idx)) { > > > -

Re: [Qemu-devel] plan for device assignment upstream

2012-07-02 Thread Avi Kivity
On 07/02/2012 12:30 PM, Jan Kiszka wrote: > On 2012-07-02 11:18, Michael S. Tsirkin wrote: >> I've been thinking hard about Jan's patches for device >> assignment. Basically while I thought it makes sense >> to make all devices: assignment and not - behave the >> same and use same APIs for injectin

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Peter Maydell
On 2 July 2012 10:42, Paolo Bonzini wrote: > Personally, I believe it'd be best if board descriptions were moved to > hw/ARCH, even if all the required hardware is in hw/ and even if the > file can be moved from obj-y to hw-obj-y.  However, this can be left > open to later discussion, and is compl

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 11:44, Peter Maydell ha scritto: > On 2 July 2012 10:42, Paolo Bonzini wrote: >> > Personally, I believe it'd be best if board descriptions were moved to >> > hw/ARCH, even if all the required hardware is in hw/ and even if the >> > file can be moved from obj-y to hw-obj-y. However,

Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs

2012-07-02 Thread Paolo Bonzini
Il 19/06/2012 11:31, Bharata B Rao ha scritto: >>> > > +ret = pthread_create(&thread, NULL, gluster_handle_poll, >>> > > +(void *)gctx); >> > >> > Please use qemu-thread.h. QEMU uses signals so you almost certainly >> > want to mask signals for this thread (qemu_thread_create() does that)

[Qemu-devel] [PATCH 3/3] virtio-scsi: Report missed events

2012-07-02 Thread Paolo Bonzini
When an event is reported but no buffers are present in the event vq, we can set a flag and report a dummy event as soon as one is added. Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 54 -- 1 file changed, 36 insertions(+), 18 deletion

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 7:04 PM, Kevin Wolf wrote: > Am 02.07.2012 10:57, schrieb Peter Crosthwaite: >> On Mon, Jul 2, 2012 at 6:50 PM, Stefan Hajnoczi wrote: >>> On Fri, Jun 29, 2012 at 12:51 PM, Peter Crosthwaite >>> wrote: BTW Yielding is one thing, but the elephant in the room here is >>

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Kevin Wolf
Am 02.07.2012 11:42, schrieb Peter Crosthwaite: > On Mon, Jul 2, 2012 at 7:04 PM, Kevin Wolf wrote: >> Am 02.07.2012 10:57, schrieb Peter Crosthwaite: >>> No conditional on the qemu_coroutine_create. So it will always create >>> a new coroutine for its work which will solve my problem. All I need

[Qemu-devel] [PATCH 12/14] scsi: Ensure command and transfer lengths are set for all SCSI devices

2012-07-02 Thread Paolo Bonzini
scsi-generic relies on those values to be correct, so it is important that those values are initialized properly for all device types. Reported-by: Christian Hoff Reported-by: Christian Borntraeger Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 25 ++--- 1 file changed,

Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs

2012-07-02 Thread Bharata B Rao
On Mon, Jul 02, 2012 at 11:52:04AM +0200, Paolo Bonzini wrote: > Il 19/06/2012 11:31, Bharata B Rao ha scritto: > >>> > > +ret = pthread_create(&thread, NULL, gluster_handle_poll, > >>> > > +(void *)gctx); > >> > > >> > Please use qemu-thread.h. QEMU uses signals so you almost certainly >

Re: [Qemu-devel] SMP for PReP architecture

2012-07-02 Thread Eli Lewis
>> I need to modify >> and test a very simple kernel (actually running on a single-core only) on >> a multi-core PReP platform; I currently have no real multi-core HW so I am > looking >> for a multi-core PReP emulator. > > Why would anyone do PReP today still? Good question :-) I am wo

[Qemu-devel] [PATCH 10/14] scsi: Fix data length == SCSI_SENSE_BUF_SIZE

2012-07-02 Thread Paolo Bonzini
From: Christian Hoff Fix the edge case where the sense data length is exactly the same as SCSI_SENSE_BUF_SIZE. This makes SCSI requests work that use all of the available 95 byte sense data. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger Signed-off-by: Paolo Bonzini --- h

[Qemu-devel] [PATCH 14/14] scsi: Fix transfer length for READ POSITION commands.

2012-07-02 Thread Paolo Bonzini
From: Christian Hoff The transfer length depends on the specific service action code, as defined in the SCSI stream commands spec section 7.7. Up to now only the extended form was supported. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger Signed-off-by: Paolo Bonzini --- h

[Qemu-devel] KVM call agenda for Tuesday, July 3rd

2012-07-02 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Maydell
On 2 July 2012 11:01, Kevin Wolf wrote: > Reading from block devices during device initialisation breaks > migration, so I'd like to see it go away wherever possible. Reading in > the whole image file doesn't sound like something for which a good > excuse exists, you can do that as well during the

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 8:01 PM, Kevin Wolf wrote: > Am 02.07.2012 11:42, schrieb Peter Crosthwaite: >> On Mon, Jul 2, 2012 at 7:04 PM, Kevin Wolf wrote: >>> Am 02.07.2012 10:57, schrieb Peter Crosthwaite: No conditional on the qemu_coroutine_create. So it will always create a new corout

[Qemu-devel] [PATCH 06/14] ISCSI: force use of sg for SMC and SSC devices

2012-07-02 Thread Paolo Bonzini
From: Ronnie Sahlberg If the device we open is a SMC or SSC device, then force the use of sg. We dont have any medium changer or tape emulation so only passthrough via real sg or scsi-generic via iscsi would work anyway. Forcing sg also makes qemu skip trying to read from the device to guess the

Re: [Qemu-devel] SMP for PReP architecture

2012-07-02 Thread Alexander Graf
On 02.07.2012, at 12:10, Eli Lewis wrote: >>> I need to modify > >>> and test a very simple kernel (actually running on a single-core only) on >>> a multi-core PReP platform; I currently have no real multi-core HW so I am >> looking >>> for a multi-core PReP emulator. >> >> Why would anyone d

[Qemu-devel] [PATCH 01/14] scsi: simplify handling of the VPD page length field

2012-07-02 Thread Paolo Bonzini
The last four bytes of the thin provisioning page were cut out. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index ae25194..747e756 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-d

[Qemu-devel] [PATCH 05/14] ISCSI: Add SCSI passthrough via scsi-generic to libiscsi

2012-07-02 Thread Paolo Bonzini
From: Ronnie Sahlberg Update iscsi to allow passthrough of SG_IO scsi commands when the iscsi device is forced to be scsi-generic. Implement both bdrv_ioctl() and bdrv_aio_ioctl() in the iscsi backend, emulate the SG_IO ioctl and pass the SCSI commands across to the iscsi target. This allows en

Re: [Qemu-devel] hw/Makefile.objs question

2012-07-02 Thread Paolo Bonzini
Il 21/06/2012 16:04, Andreas Färber ha scritto: > > *If* the file is built per target (hw/ppc64/Makefile.objs), then you can > use *-softmmu/config-target.mak and just need to use a different > Makefile than before. > > *If* the file is built per libhw (hw/Makefile.objs), then you need one > opti

Re: [Qemu-devel] qemu-system-arm I/O problems

2012-07-02 Thread Peter Maydell
On 29 June 2012 14:45, Peter Maydell wrote: > On 25 June 2012 16:47, solar wrote: >> QEMU emulator version 1.1.0, Copyright (c) 2003-2008 Fabrice Bellard >> >> parameters used: qemu-system-arm -M versatilepb -m 256 -net nic -net >> user,hostfwd=tcp::40022-:22 -nographic -hda debian-6-armel.img -k

[Qemu-devel] [PATCH 2/3] virtio-scsi: Implement hotplug support for virtio-scsi

2012-07-02 Thread Paolo Bonzini
From: Cong Meng Implement the hotplug() and hot_unplug() interfaces in virtio-scsi, by signal the virtio_scsi.ko in guest kernel via event virtual queue. The counterpart patch of virtio_scsi.ko will be sent soon in another thread. Signed-off-by: Sen Wang Signed-off-by: Cong Meng [ Add memset,

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Kevin Wolf
Am 02.07.2012 12:18, schrieb Peter Maydell: > On 2 July 2012 11:01, Kevin Wolf wrote: >> Reading from block devices during device initialisation breaks >> migration, so I'd like to see it go away wherever possible. Reading in >> the whole image file doesn't sound like something for which a good >>

[Qemu-devel] [PATCH 13/14] scsi: Add basic support for SCSI media changer commands.

2012-07-02 Thread Paolo Bonzini
From: Christian Hoff This adds basic support for SCSI media changer commands. Not all commands are supported as of now, but enough to cover basic functionality. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 45 +

Re: [Qemu-devel] [RFC] Attaching EHCI to sysbus.

2012-07-02 Thread Gerd Hoffmann
Hi, > Does it make sense to have an EHCI bus type that inherits from USBBus? > > That way we could change USBPortOps into methods of the USBBus that the > subclass overrides. I don't think this is useful. USBPortOps should be identical for both cases. > That would strongly decouple the EHCI

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Kevin Wolf
Am 02.07.2012 12:18, schrieb Peter Crosthwaite: > On Mon, Jul 2, 2012 at 8:01 PM, Kevin Wolf wrote: >> Am 02.07.2012 11:42, schrieb Peter Crosthwaite: >>> On Mon, Jul 2, 2012 at 7:04 PM, Kevin Wolf wrote: Am 02.07.2012 10:57, schrieb Peter Crosthwaite: > No conditional on the qemu_corout

[Qemu-devel] [PATCH 09/14] virtio-scsi: do not crash on adding buffers to the event queue

2012-07-02 Thread Paolo Bonzini
The event queue is not supported yet and the handler does not have to do much anyway when buffers are added. However, the handler is called unconditionally by the virtio layer, and this results in a crash as soon as buffers are added to the event queue because we pass NULL. Reported-by: Bryan Ven

[Qemu-devel] [PATCH 03/14] atapi: implement READ DISC INFORMATION

2012-07-02 Thread Paolo Bonzini
This command is not necessary for CD-ROM and DVD-ROM, but some versions of udev trip on its absence. Cc: Kevin Wolf Cc: Markus Armbruster Signed-off-by: Paolo Bonzini --- hw/ide/atapi.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/hw/ide/atapi.c b/hw/i

[Qemu-devel] [PATCH 0/4] net: convert NetClientState to QOM

2012-07-02 Thread Stefan Hajnoczi
Note: These patches apply on top of Zhi Yong Wu's vlan-hub v6 and -netdev socket v2 series. This series is the first step in QOMifying the net subsystem. These patches make NetClientState an Object so that all -netdev and NICs use QOM. The net clients are not yet visible in the QOM tree and have

[Qemu-devel] [PATCH 2/4] net: add net_is_tap_client()

2012-07-02 Thread Stefan Hajnoczi
The vhost-net code interacts closely with the net/tap.c backend so that it can pass the underlying file descriptor to the vhost_net.ko driver. We need a check that confirms a NetClientState is indeed a tap backend (and not something else like slirp or socket). Formalize this in the new net_is_tap_

[Qemu-devel] [PATCH 1/4] net: add public qemu_net_poll() function

2012-07-02 Thread Stefan Hajnoczi
The NetClientInfo .poll() callback is being called directly by hw/vhost_net.c. Create a public net.c function so callers do not depend on internals. This change is useful because later patches change net internals. Those changes shouldn't affect .poll() callers. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 3/4] net: extract notify_link_status_changed() function

2012-07-02 Thread Stefan Hajnoczi
The code to invoke the NetClientInfo .link_status_changed() callback is duplicated in several places. Create a single notify_link_status_changed() function and avoid duplication. This is useful because later patches change net internals. By having a single function it is easier to make changes w

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 8:52 PM, Kevin Wolf wrote: > Am 02.07.2012 12:18, schrieb Peter Crosthwaite: >> On Mon, Jul 2, 2012 at 8:01 PM, Kevin Wolf wrote: >>> Am 02.07.2012 11:42, schrieb Peter Crosthwaite: On Mon, Jul 2, 2012 at 7:04 PM, Kevin Wolf wrote: > Am 02.07.2012 10:57, schrieb P

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 11:37, Paolo Bonzini ha scritto: > Il 02/07/2012 11:31, Peter Maydell ha scritto: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >>> devices (no

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Maydell
On 2 July 2012 11:44, Kevin Wolf wrote: > Am 02.07.2012 12:18, schrieb Peter Maydell: >> Why complicate things by adding code for "if this is the first >> access then read in the file"? > > Because then it works. :-) > > Migration works more or less like this: > > 1. Destination creates device mod

[Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 747e756..e87e57c 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -67,6 +67,7 @@ struct SCSIDiskState bool media_chang

[Qemu-devel] [PATCH 11/14] scsi: Fix LOAD_UNLOAD

2012-07-02 Thread Paolo Bonzini
From: Christian Hoff Change operation code of LOAD_UNLOAD command to 0x1b as described in section 7.3 of the SCSI Stream Commands spec. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |6 +++--- hw/scsi-defs.h |2 +-

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 8:59 PM, Peter Maydell wrote: > On 2 July 2012 11:44, Kevin Wolf wrote: >> Am 02.07.2012 12:18, schrieb Peter Maydell: >>> Why complicate things by adding code for "if this is the first >>> access then read in the file"? >> >> Because then it works. :-) >> >> Migration work

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Kevin Wolf
Am 02.07.2012 12:57, schrieb Peter Crosthwaite: > On Mon, Jul 2, 2012 at 8:52 PM, Kevin Wolf wrote: >> Am 02.07.2012 12:18, schrieb Peter Crosthwaite: >>> On Mon, Jul 2, 2012 at 8:01 PM, Kevin Wolf wrote: Am 02.07.2012 11:42, schrieb Peter Crosthwaite: > On Mon, Jul 2, 2012 at 7:04 PM, K

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-07-02 Thread Gerd Hoffmann
Hi, > What I also so in the trace is that the USB core apparently stumbled as > a request that took very long too complete finally returned, and then > the assertion triggered over this request. Can I get such a trace please? usb_host_req_* and usb_host_urb_* enabled should show all interestin

[Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02

2012-07-02 Thread Paolo Bonzini
Anthony, The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593: bsd-user: fix build (2012-06-28 20:28:36 +) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to 9ce1bb2d36f24af79d2757497acbaf4dc4a2e302:

[Qemu-devel] [PATCH 07/14] megasas: Add header file

2012-07-02 Thread Paolo Bonzini
From: Hannes Reinecke This patch adds the header file for megasas. Signed-off-by: Hannes Reinecke Signed-off-by: Paolo Bonzini --- hw/mfi.h | 1248 ++ 1 file changed, 1248 insertions(+) create mode 100644 hw/mfi.h diff --git a/hw/m

Re: [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete

2012-07-02 Thread Gerd Hoffmann
On 06/29/12 18:27, Jan Kiszka wrote: > Due to queuing/pipelining, there can now be multiple packets per > endpoint in flight. So the assertion in usb_packet_complete became wrong > and can cause bogus QEMU terminations. Seen with a passed-through USB > headset. NAK. The assert doesn't protect aga

[Qemu-devel] [RFC PATCH] Expose tsc deadline timer feature to guest

2012-07-02 Thread Liu, Jinsong
Eduardo, Jan, Andreas As we sync 3 months ago, I wait until qemu1.1 done, then re-write patch based on qemu1.1. Now it's time to re-write my patch based on qemu1.1. Attached is a RFC patch for exposing tsc deadline timer to guest. I have checked current qemu1.1 code, and read some emails regardi

[Qemu-devel] [PATCH 04/14] scsi-disk: implement READ DISC INFORMATION

2012-07-02 Thread Paolo Bonzini
This command is not necessary for CD-ROM and DVD-ROM, but some versions of udev trip on its absence. Cc: Kevin Wolf Cc: Markus Armbruster Signed-off-by: Paolo Bonzini --- hw/scsi-defs.h |1 + hw/scsi-disk.c | 40 2 files changed, 41 insertions(+)

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 8:44 PM, Kevin Wolf wrote: > Am 02.07.2012 12:18, schrieb Peter Maydell: >> On 2 July 2012 11:01, Kevin Wolf wrote: >>> Reading from block devices during device initialisation breaks >>> migration, so I'd like to see it go away wherever possible. Reading in >>> the whole im

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Kevin Wolf
Am 02.07.2012 13:12, schrieb Peter Crosthwaite: > On Mon, Jul 2, 2012 at 8:44 PM, Kevin Wolf wrote: >> Am 02.07.2012 12:18, schrieb Peter Maydell: >>> On 2 July 2012 11:01, Kevin Wolf wrote: Reading from block devices during device initialisation breaks migration, so I'd like to see it

Re: [Qemu-devel] [PATCH 3/4] usb: add usb attached scsi emulation

2012-07-02 Thread Gerd Hoffmann
On 07/01/12 15:36, Paolo Bonzini wrote: > Il 20/06/2012 14:41, Gerd Hoffmann ha scritto: >> Special thanks go to Paolo for bringing the qemu scsi emulation into >> shape, so this can be added nicely without having to touch a single line >> of scsi code. > > But we can touch it and make it even bet

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-07-02 Thread Peter Crosthwaite
On Mon, Jul 2, 2012 at 9:19 PM, Kevin Wolf wrote: > Am 02.07.2012 13:12, schrieb Peter Crosthwaite: >> On Mon, Jul 2, 2012 at 8:44 PM, Kevin Wolf wrote: >>> Am 02.07.2012 12:18, schrieb Peter Maydell: On 2 July 2012 11:01, Kevin Wolf wrote: > Reading from block devices during device ini

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Andreas Färber
Am 01.07.2012 17:26, schrieb Paolo Bonzini: > Il 29/06/2012 14:26, Andreas Färber ha scritto: Oh, I see. Should we place this device to hw/Makefile.objs in v2? >> That would've been nice, but I'll do it as a follow-up now. > > Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introd

Re: [Qemu-devel] [RFC PATCH] Expose tsc deadline timer feature to guest

2012-07-02 Thread Andreas Färber
Am 02.07.2012 13:08, schrieb Liu, Jinsong: > Eduardo, Jan, Andreas > > As we sync 3 months ago, I wait until qemu1.1 done, then re-write patch based > on qemu1.1. > Now it's time to re-write my patch based on qemu1.1. > > Attached is a RFC patch for exposing tsc deadline timer to guest. > I have

Re: [Qemu-devel] [PATCH 08/12] savevm: split save_live into stage2 and stage3

2012-07-02 Thread Orit Wasserman
On 06/28/2012 10:22 PM, Juan Quintela wrote: > We split it into 2 functions, foo_live_iterate, and foo_live_complete. > At this point, we only remove the bits that are for the other stage, > functionally this is equivalent to previous code. > > Signed-off-by: Juan Quintela > --- > arch_init.c

Re: [Qemu-devel] [PATCH 09/12] ram: save_live_setup() don't need to sent pages

2012-07-02 Thread Orit Wasserman
On 06/28/2012 10:22 PM, Juan Quintela wrote: > We should send pages on interate phase, not in setup one. This was a > "bug". Just removing the loop does what we want. Tested that it > works with current ram_load(). > > Signed-off-by: Juan Quintela > --- > arch_init.c | 33 --

Re: [Qemu-devel] [PATCH 10/12] ram: save_live_complete() only do one loop

2012-07-02 Thread Orit Wasserman
On 06/28/2012 10:22 PM, Juan Quintela wrote: > We were doing the same loop that stage2, and a new one for stage3. We > only need the one for stage3. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 31 --- > 1 file changed, 31 deletions(-) > > diff --git a/a

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Andreas Färber
Am 02.07.2012 11:31, schrieb Peter Maydell: > On 2 July 2012 10:08, Igor Mitsyanko wrote: >> So, what's the consensus here, for now new devices go to >> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >> devices (not just exynos-related) from hw/arm/Makefile.objs to >> h

Re: [Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to synchronize the dirty bitmap.

2012-07-02 Thread Orit Wasserman
On 06/28/2012 10:22 PM, Juan Quintela wrote: > 1st: we were synchonizing the dirty bitmap before calling > memory_global_dirty_log_start(). > > 2nd: We are marking all pages as dirty anywhere, no reason to go > through all the bitmap to "mark" dirty same pages twice. > > So, call remov

Re: [Qemu-devel] hw/Makefile.objs question

2012-07-02 Thread Andreas Färber
Am 02.07.2012 12:36, schrieb Paolo Bonzini: > Il 21/06/2012 16:04, Andreas Färber ha scritto: >> >> *If* the file is built per target (hw/ppc64/Makefile.objs), then you can >> use *-softmmu/config-target.mak and just need to use a different >> Makefile than before. >> >> *If* the file is built per

Re: [Qemu-devel] hw/Makefile.objs question

2012-07-02 Thread Alexey Kardashevskiy
02.07.2012 20:36, Paolo Bonzini пишет: > Il 21/06/2012 16:04, Andreas Färber ha scritto: >> >> *If* the file is built per target (hw/ppc64/Makefile.objs), then you can >> use *-softmmu/config-target.mak and just need to use a different >> Makefile than before. >> >> *If* the file is built per libhw

Re: [Qemu-devel] hw/Makefile.objs question

2012-07-02 Thread Andreas Färber
Am 02.07.2012 14:10, schrieb Alexey Kardashevskiy: > 02.07.2012 20:36, Paolo Bonzini пишет: >> Il 21/06/2012 16:04, Andreas Färber ha scritto: >>> >>> *If* the file is built per target (hw/ppc64/Makefile.objs), then you can >>> use *-softmmu/config-target.mak and just need to use a different >>> Ma

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Igor Mitsyanko
On 07/02/2012 03:44 PM, Andreas Färber wrote: Am 01.07.2012 17:26, schrieb Paolo Bonzini: Il 29/06/2012 14:26, Andreas Färber ha scritto: Oh, I see. Should we place this device to hw/Makefile.objs in v2? That would've been nice, but I'll do it as a follow-up now. Yes, so we can also use Ant

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Peter Maydell
On 2 July 2012 13:04, Andreas Färber wrote: > Am 02.07.2012 11:31, schrieb Peter Maydell: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >>> devices (not jus

Re: [Qemu-devel] qemu-system-arm I/O problems

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 12:43, Peter Maydell ha scritto: >>> >> Once apt starts to do disk I/O the kernel throws numerous SCSI errors: >>> >> [ 165.292240] sd 0:0:0:0: [sda] Result: hostbyte=DID_OK >>> >> driverbyte=DRIVER_SENSE >>> >> [ 165.292653] sd 0:0:0:0: [sda] Sense Key : Aborted Command [current] >

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Andreas Färber
Am 02.07.2012 11:37, schrieb Paolo Bonzini: > Il 02/07/2012 11:31, Peter Maydell ha scritto: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >>> devices (not j

Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-07-02 Thread Paolo Bonzini
Il 26/06/2012 00:01, Anthony Liguori ha scritto: > The various object_property_set_* functions are inconsistent because I > didn't write them. I'm not sure why they take value/name. They should > take name/value IMHO. void object_property_set(Object *obj, Visitor *v, const char *name,

Re: [Qemu-devel] [PATCH 4/4] vl: add -late-object to create QOM objects after machine init

2012-07-02 Thread Paolo Bonzini
Il 26/06/2012 00:43, Anthony Liguori ha scritto: > In order to create qdev objects via -late-object, we almost always have to > specify the parent_bus which is usually created during machine init. Until we > properly support two stage init, introduce a -late-object option that allows > for > crea

Re: [Qemu-devel] [PATCH 2/4] qdev: add realized property and make adding child bus implied by realize

2012-07-02 Thread Paolo Bonzini
Why does this lack recursive realization? (I'm not top posting, I'm replying to the commit message. :)) Paolo Il 26/06/2012 00:43, Anthony Liguori ha scritto: > Signed-off-by: Anthony Liguori > --- > hw/qdev.c | 36 +++- > 1 files changed, 35 insertions(+), 1

Re: [Qemu-devel] [PATCH 4/4] vl: add -late-object to create QOM objects after machine init

2012-07-02 Thread Andreas Färber
Am 02.07.2012 14:32, schrieb Paolo Bonzini: > Il 26/06/2012 00:43, Anthony Liguori ha scritto: >> In order to create qdev objects via -late-object, we almost always have to >> specify the parent_bus which is usually created during machine init. Until >> we >> properly support two stage init, intr

[Qemu-devel] [PATCH v2 2/2] pci: Add INTx routing notifier

2012-07-02 Thread Jan Kiszka
This per-device notifier shall be triggered by any interrupt router along the path of a device's legacy interrupt signal on routing changes. For simplicity reasons and as this is a slow path anyway, no further details on the routing changes are provided. Instead, the callback is expected to use pci

  1   2   >