Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-26 Thread Markus Armbruster
Anthony Liguori writes: > On 06/25/2012 03:47 PM, Andreas Färber wrote: [...] >> As for convenience, personally I find all these property API signatures >> inconvenient enough that I copy&paste when I add a new one or need to >> look up object.h. The inconsistent or at least unintuitive order of

Re: [Qemu-devel] [RFC 1/3] memory: add -disable-mem-merge command-line option

2012-06-26 Thread Avi Kivity
On 06/25/2012 11:26 PM, Jan Kiszka wrote: > On 2012-06-25 18:55, Luiz Capitulino wrote: >> Allow for disabling memory merge support (KSM on Linux), which is >> enabled by default otherwise. > > -machine mem_merge=on|off? It's a host property, not a guest property. For devices we have a pretty go

Re: [Qemu-devel] USB passthrough filters - how to deny passing certain devices?

2012-06-26 Thread Hans de Goede
Hi, On 06/25/2012 08:59 PM, Erik Rull wrote: Hans de Goede wrote: Hi, On 06/25/2012 06:17 PM, Erik Rull wrote: Hi all, is there a way to deny passing certain devices to the guest? I want to deny two devices to get assigned to the guest, all others on all ports are allowed, ony two each with

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-26 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 21 Jun 2012 13:42:19 +0100 > "Daniel P. Berrange" wrote: > > [...] > >> > However, we'd change how we use 'desc' and our error classes. 'desc' would >> > become a string which is filled by a printf-like function (see section 2) >> > and >> >> Good, using a pri

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-26 Thread Markus Armbruster
Anthony Liguori writes: > Um, why not just do: > > #define GENERIC_ERROR "{'class': 'GenericError', 'data': { 'domain': %s, > 'msg': %s}" > > And then just use: > > error_set(errp, GENERIC_ERROR, SOME_DOMAIN, "This operation failed!"); Please explain the intended use of domain, and why it is ne

Re: [Qemu-devel] [PATCH 0/4] qdev realize, -object, and -object-late

2012-06-26 Thread Markus Armbruster
Anthony Liguori writes: > As part of implementing the virtio-rng backend support, I decided it was best > to split off the generic part of the series to make review easier. > > This series does a few things. It adds a realized property to DeviceState. > It does so in the least invasive way possi

Re: [Qemu-devel] Add virtual devices to QEMU

2012-06-26 Thread Stefan Hajnoczi
On Mon, Jun 25, 2012 at 7:58 PM, Alberich de megres wrote: > Thank you guys for the reply :) > > One last question, > my device is like a physical console with buttons and indicators. > > I saw the android emulator also draws the keyboard using a modified > version of the qemu. > Is there some kin

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-06-26 Thread Stefan Hajnoczi
On Mon, Jun 25, 2012 at 5:32 PM, Mike Lovell wrote: > On 06/25/2012 09:33 AM, Mike Lovell wrote: >> >> On 06/25/2012 04:40 AM, Stefan Hajnoczi wrote: >>> >>> Have you looked at QEMU's net/vde.c backend? >>> >>> Does VDE (http://vde.sourceforge.net/) already do everything that QDES >>> does? >>> >>

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Markus Armbruster
Anthony Liguori writes: > This will create a new QOM object in the '/objects' path. Note that > properties Long line, will look fugly in git-log. Please wrap at column 70-75. checkpatch.pl complains about long lines in the patch proper, too :) > are set in order which allows for simple obje

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to i

Re: [Qemu-devel] [PATCH v6 08/16] target-or32: Add instruction tanslation

2012-06-26 Thread Wei-Ren Chen
> > 0x is -1, 0x8000 is -MAX. > > -1/-MAX ?will raise a exception, and I've handle this. > > -MAX/-1 ?will get a MAX, for max value of a register is -(-MAX)-1, so, > > it overflowed, I didn't handle this. > > Actually you did this with three brcondi in the else branch. The only thing >

Re: [Qemu-devel] [RFC 3/3] memory/qmp: add set-memory-merge command

2012-06-26 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 05:05:45PM -0500, Anthony Liguori wrote: > On 06/25/2012 11:55 AM, Luiz Capitulino wrote: > >Allow to enable/disable memory merging during run-time. > > > >This is implemented by extending the qemu_set_mem_merge() function. > > > >To test on HMP: > > > > (qemu) set_memory_

Re: [Qemu-devel] [PATCH v6 08/16] target-or32: Add instruction tanslation

2012-06-26 Thread Max Filippov
On Tue, Jun 26, 2012 at 1:14 PM, 陳韋任 (Wei-Ren Chen) wrote: >> > 0x is -1, 0x8000 is -MAX. >> > -1/-MAX ?will raise a exception, and I've handle this. -1 / -MAX equals 0, it's not the issue here. >> > -MAX/-1 ?will get a MAX, for max value of a register is -(-MAX)-1, so, >> > it overf

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 09:54:21AM +0200, Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 21 Jun 2012 13:42:19 +0100 > > "Daniel P. Berrange" wrote: > > > > [...] > > > >> > However, we'd change how we use 'desc' and our error classes. 'desc' > >> > would > >> > become a string

Re: [Qemu-devel] [PATCH 4/4] virtio-rng: hardware random number generator device

2012-06-26 Thread Amit Shah
On (Mon) 25 Jun 2012 [17:59:28], Anthony Liguori wrote: > On 06/25/2012 05:46 PM, Anthony Liguori wrote: > >From: Amit Shah > >diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > >+static void virtio_rng_class_init(ObjectClass *klass, void *data) > >+{ > >+DeviceClass *dc = DEVICE_CLASS(klass);

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-26 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Jun 26, 2012 at 09:54:21AM +0200, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >> > On Thu, 21 Jun 2012 13:42:19 +0100 >> > "Daniel P. Berrange" wrote: [...] >> >> In libvirt we have always reserved the right to change the error >> >> code repor

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Kevin Wolf
Am 26.06.2012 11:10, schrieb Daniel P. Berrange: > I was thinking about some of the sources complexity when using > FD passing from libvirt and wanted to raise one idea for discussion > before we continue. > > With this proposed series, we have usage akin to: > > 1. pass_fd FDSET={M} -> returns

Re: [Qemu-devel] [PATCH v12 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-06-26 Thread Orit Wasserman
On 06/19/2012 09:08 PM, Eric Blake wrote: > On 06/19/2012 09:43 AM, Orit Wasserman wrote: >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman >> --- >> savevm.c | 91 >> +

[Qemu-devel] [PATCH v2] ahci: add -drive support

2012-06-26 Thread Alexander Graf
We've had support for creating AHCI devices using -device for a while now, but it's cumbersome to users. We really should provide an easier way for them to leverage the power of AHCI! So let's introduce a new if= option to -drive, giving users the same command line experience as for scsi or ide.

Re: [Qemu-devel] [RFC 1/3] memory: add -disable-mem-merge command-line option

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 10:47:07 +0300 Avi Kivity wrote: > On 06/25/2012 11:26 PM, Jan Kiszka wrote: > > On 2012-06-25 18:55, Luiz Capitulino wrote: > >> Allow for disabling memory merge support (KSM on Linux), which is > >> enabled by default otherwise. > > > > -machine mem_merge=on|off? > > It's

Re: [Qemu-devel] [RFC 3/3] memory/qmp: add set-memory-merge command

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 10:25:22 +0100 "Daniel P. Berrange" wrote: > On Mon, Jun 25, 2012 at 05:05:45PM -0500, Anthony Liguori wrote: > > On 06/25/2012 11:55 AM, Luiz Capitulino wrote: > > >Allow to enable/disable memory merging during run-time. > > > > > >This is implemented by extending the qemu_se

Re: [Qemu-devel] [RFC 1/3] memory: add -disable-mem-merge command-line option

2012-06-26 Thread Jan Kiszka
On 2012-06-26 09:47, Avi Kivity wrote: > On 06/25/2012 11:26 PM, Jan Kiszka wrote: >> On 2012-06-25 18:55, Luiz Capitulino wrote: >>> Allow for disabling memory merge support (KSM on Linux), which is >>> enabled by default otherwise. >> >> -machine mem_merge=on|off? > > It's a host property, not a

[Qemu-devel] [PATCH] target-arm: Fix typo that meant TTBR1 accesses went to TTBR0

2012-06-26 Thread Peter Maydell
Fix a copy-and-paste error in the register description for TTBR1 that meant it was a duplicate of TTBR0 rather than affecting the correct bit of CPU state. Signed-off-by: Peter Maydell --- Whoops. Spotted while I was looking at this bit of code for a different reason... target-arm/helper.c |

Re: [Qemu-devel] [PATCH 4/4] virtio-rng: hardware random number generator device

2012-06-26 Thread Anthony Liguori
On 06/26/2012 05:48 AM, Amit Shah wrote: On (Mon) 25 Jun 2012 [17:59:28], Anthony Liguori wrote: On 06/25/2012 05:46 PM, Anthony Liguori wrote: From: Amit Shah diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c +static void virtio_rng_class_init(ObjectClass *klass, void *data) +{ +DeviceC

Re: [Qemu-devel] [RFC 3/3] memory/qmp: add set-memory-merge command

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 09:53:32AM -0300, Luiz Capitulino wrote: > On Tue, 26 Jun 2012 10:25:22 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Jun 25, 2012 at 05:05:45PM -0500, Anthony Liguori wrote: > > > On 06/25/2012 11:55 AM, Luiz Capitulino wrote: > > > >Allow to enable/disable memory mer

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Anthony Liguori
On 06/26/2012 03:42 AM, Markus Armbruster wrote: Anthony Liguori writes: This will create a new QOM object in the '/objects' path. Note that properties Long line, will look fugly in git-log. Please wrap at column 70-75. Okay, let me turn this around: How do people normally limit this be

Re: [Qemu-devel] [PATCH 0/4] qdev realize, -object, and -object-late

2012-06-26 Thread Anthony Liguori
On 06/26/2012 03:15 AM, Markus Armbruster wrote: Anthony Liguori writes: As part of implementing the virtio-rng backend support, I decided it was best to split off the generic part of the series to make review easier. This series does a few things. It adds a realized property to DeviceState.

Re: [Qemu-devel] [PATCH 0/4] qdev realize, -object, and -object-late

2012-06-26 Thread Eric Blake
On 06/26/2012 07:42 AM, Anthony Liguori wrote: >> >> Any particular reason for deleting the diffstat from your cover letter? > > I'm not deleting it. I typically just use git-send-email --compose > which doesn't come with a diffstat. git send-email --cover-letter will add the diffstat. Why 'g

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Corey Bryant
On 06/26/2012 05:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU pro

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Andreas Färber
Am 26.06.2012 15:35, schrieb Anthony Liguori: > On 06/26/2012 03:42 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> This will create a new QOM object in the '/objects' path. Note that >>> properties >> >> Long line, will look fugly in git-log. Please wrap at column 70-75. > > Oka

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey Bryant wrote: > >So now from a client's POV you'd have a flow like > > > >* drive_add "file=/dev/fd/N" FDSET={N} > > IIUC then drive_add would loop and pass each fd in the set via SCM_RIGHTS? Yes, you'd probably use the JSON to tell QEMU exactl

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey Bryant wrote: > > >So now from a client's POV you'd have a flow like > > > > > >* drive_add "file=/dev/fd/N" FDSET={N} > > > > IIUC then drive_add would loop and pass each fd

[Qemu-devel] Is *-bsd-user target broken?

2012-06-26 Thread Igor Mammedov
Hello Blue, I've tried to test if *-bsd-user target works but so far wasn't successful so far. I've tried qemu-1.x ports on the latest freebsd/openbsd and a freshly checked out qemu. If it works for you, could you tell: 1. what flavor of bsd you use for testing 2. what configure options ar

Re: [Qemu-devel] Is *-bsd-user target broken?

2012-06-26 Thread Andreas Färber
Am 26.06.2012 17:49, schrieb Igor Mammedov: > Example of what I've did on FreeBSD, qemu with your recent patches and > ld patch form qemu-devel port: > > # ./configure --enable-debug --disable-werror --target-list=i386-bsd-user > > # ./i386-bsd-user/qemu-i386 -strace -bsd FreeBSD -L / /bin/ls >

Re: [Qemu-devel] Is *-bsd-user target broken?

2012-06-26 Thread Igor Mammedov
On 06/26/2012 05:56 PM, Andreas Färber wrote: Am 26.06.2012 17:49, schrieb Igor Mammedov: Example of what I've did on FreeBSD, qemu with your recent patches and ld patch form qemu-devel port: # ./configure --enable-debug --disable-werror --target-list=i386-bsd-user # ./i386-bsd-user/qemu-i38

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Corey Bryant
On 06/26/2012 11:03 AM, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey Bryant wrote: So now from a client's POV you'd have a flow like * drive_add "file=/dev/fd/N" FDSET={N} IIUC then drive_

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-26 Thread Anthony Liguori
On 06/26/2012 06:21 AM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Tue, Jun 26, 2012 at 09:54:21AM +0200, Markus Armbruster wrote: Luiz Capitulino writes: On Thu, 21 Jun 2012 13:42:19 +0100 "Daniel P. Berrange" wrote: [...] In libvirt we have always reserved the right to c

[Qemu-devel] [PATCH v2 3/3] i386: KVM: List -cpu host and best in -cpu ?

2012-06-26 Thread Alexander Graf
The kvm_enabled() helper doesn't work in a function as early as -cpu ? yet. It also doesn't make sense to list the -cpu ? output conditional on the -enable-kvm parameter. So let's always mention -cpu host in the CPU list when KVM is supported on that configuration. In addition, this patch also add

[Qemu-devel] [PATCH v2 1/3] KVM: Add new -cpu best

2012-06-26 Thread Alexander Graf
During discussions on whether to make -cpu host the default in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU

[Qemu-devel] [PATCH v2 2/3] KVM: Use -cpu best as default on x86

2012-06-26 Thread Alexander Graf
When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the max

[Qemu-devel] [Bug 1017793] [NEW] S3 Trio64V+ support

2012-06-26 Thread Tony Zhou
Public bug reported: Is it possible to add S3 Trio emulation to QEMU at all? Since 0.12.3 the Cirrus Logic seems no longer working properly (bad font render/corrupted video). Also, S3 is a widely supported device on many OSes and architectures, which will give more compatibility for QEMU. Thanks!

[Qemu-devel] qemu as dynamic binary translation infrastructure

2012-06-26 Thread Liu Xin
Hi, community, our company uses QEMU as system emulator, to emulate our private-ISA processor and SoC. recently, we came up an idea to build a dynamic binary translator on top of current QEMU technology. please you guys in this community are experienced and your aforementioned advices are really p

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-06-26 Thread Peter Lieven
On 13.03.2012 16:06, Alexander Graf wrote: On 13.03.2012, at 16:05, Corentin Chary wrote: On Tue, Mar 13, 2012 at 12:29 PM, Peter Lieven wrote: On 11.02.2012 09:55, Corentin Chary wrote: On Thu, Feb 9, 2012 at 7:08 PM, Peter Lieven wrote: Hi, is anyone aware if there are still problems w

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-06-26 Thread Mike Lovell
On 06/26/2012 02:29 AM, Stefan Hajnoczi wrote: On Mon, Jun 25, 2012 at 5:32 PM, Mike Lovell wrote: Oh. I forgot another reason why I decided to do this over using VDE. I'll do this one with an example. Say you have 3 virtual machines on 3 different hosts. Each host has a vde_switch process run

[Qemu-devel] [PATCH v5 3/3] Change driftfix default value to slew

2012-06-26 Thread Crístian Viana
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as the time source. If driftfix is not enabled, Windows is prone to blue screening. Signed-off-by: Crístian Viana --- hw/mc146818rtc.c |2 +- vl.c | 11 ++- 2 files changed, 11 insertions(+), 2

[Qemu-devel] [PATCH v5 2/3] Force driftfix=none on previous machines

2012-06-26 Thread Crístian Viana
The current value for the -rtc driftfix option is 'none'. This patch makes sure that the old machines configuration will work the same way even after that option changes its default value. Signed-off-by: Crístian Viana --- hw/pc_piix.c |4 1 file changed, 4 insertions(+) diff --git a/h

[Qemu-devel] [PATCH v5 1/3] Check if GlobalProperty exists before registering

2012-06-26 Thread Crístian Viana
If a GlobalProperty has already been registered, it won't have its value overwritten. Signed-off-by: Crístian Viana --- Changes since v4: - Only register a GlobalProperty if it hasn't already been registered. That avoids the property values to be overwritten (fix previous known bug). hw/qde

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Blue Swirl
On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell wrote: > Add field32() and field64() functions which extract a particular > bit field from a word and return it. Based on an idea by Jia Liu. > > Suggested-by: Jia Liu > Signed-off-by: Peter Maydell > --- > Jia Liu had a function like this in the Op

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Blue Swirl
On Mon, Jun 25, 2012 at 10:43 PM, Anthony Liguori wrote: > This will create a new QOM object in the '/objects' path.  Note that > properties > are set in order which allows for simple objects to be initialized entirely > with this option and then realized. > > This option is roughly equivalent to

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Peter Maydell
On 26 June 2012 18:58, Blue Swirl wrote: > On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell > wrote: >> +static inline uint64_t field64(uint64_t value, int start, int length) > > start and length could be unsigned. They could be, but is there any reason why they should be? set_bit(), clear_bit()

Re: [Qemu-devel] Is *-bsd-user target broken?

2012-06-26 Thread Blue Swirl
On Tue, Jun 26, 2012 at 3:49 PM, Igor Mammedov wrote: > Hello Blue, > > I've tried to test if *-bsd-user target works but so far wasn't successful > so far. > I've tried qemu-1.x ports on the latest freebsd/openbsd and a freshly > checked out qemu. > > If it works for you, could you tell: >  1. wh

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Peter Maydell
On 26 June 2012 14:35, Anthony Liguori wrote: > On 06/26/2012 03:42 AM, Markus Armbruster wrote: >> Long line, will look fugly in git-log.  Please wrap at column 70-75. > How do people normally limit this beyond just eye-balling? Same way I avoid overly long lines in usenet posts and email: my e

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Blue Swirl
On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell wrote: > On 26 June 2012 18:58, Blue Swirl wrote: >> On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell >> wrote: >>> +static inline uint64_t field64(uint64_t value, int start, int length) >> >> start and length could be unsigned. > > They could be, bu

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Peter Maydell
On 26 June 2012 19:25, Blue Swirl wrote: > On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell > wrote: >> On 26 June 2012 18:58, Blue Swirl wrote: >>> On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell >>> wrote: +static inline uint64_t field64(uint64_t value, int start, int length) >>> >>> star

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Corey Bryant
On 06/26/2012 11:37 AM, Corey Bryant wrote: On 06/26/2012 11:03 AM, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey Bryant wrote: So now from a client's POV you'd have a flow like * drive_add

[Qemu-devel] KVM call minutes (2012-06-26)

2012-06-26 Thread Juan Quintela
Hi This are the minutes for Today call - q35 integration why not ICH10? ICH9 is already obsolete. what are the differences? We need to check guests from Windows XP and some *BSD. Having it default for 1.2? Anthony. Having is as an option in 1.2 and make it defalut in 1.3. Alex? Anthon

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Markus Armbruster
Anthony Liguori writes: > On 06/26/2012 03:42 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> This will create a new QOM object in the '/objects' path. Note that >>> properties >> >> Long line, will look fugly in git-log. Please wrap at column 70-75. > > Okay, let me turn this

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Blue Swirl
On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell wrote: > On 26 June 2012 19:25, Blue Swirl wrote: >> On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell >> wrote: >>> On 26 June 2012 18:58, Blue Swirl wrote: On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell wrote: > +static inline uint6

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-26 Thread Marcelo Tosatti
On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > Should have declared this [RFC] in the subject and CC'ed kvm... > > On 2012-06-23 00:45, Jan Kiszka wrote: > > This sketches a possible path to get rid of the iothread lock on vmexits > > in KVM mode. On x86, the the in-kernel irqchips

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-26 Thread Luiz Capitulino
On Wed, 20 Jun 2012 12:47:40 +0800 Amos Kong wrote: > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > variables/functions in monitor.c, so reserve qmp_sendkey() > to monitor.c > > key_defs[] in monitor.c is the mapping of key name to keycode, > Keys' order in the enmu and key_defs[

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-26 Thread Luiz Capitulino
On Wed, 20 Jun 2012 06:53:40 -0600 Eric Blake wrote: > On 06/19/2012 10:47 PM, Amos Kong wrote: > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > variables/functions in monitor.c, so reserve qmp_sendkey() > > to monitor.c > > > > key_defs[] in monitor.c is the mapping of key na

Re: [Qemu-devel] [PATCH 1/4] dump: create writable files

2012-06-26 Thread Luiz Capitulino
On Wed, 20 Jun 2012 22:58:20 +0530 Rabin Vincent wrote: > Make dump-guest-memory not create read-only files, so that it can > overwrite a file created by a previous invocation without having it to > be removed externally. I think we need a force parameter to do this, the command shouldn't overwr

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 02:40:03PM -0400, Corey Bryant wrote: > > > On 06/26/2012 11:37 AM, Corey Bryant wrote: > > > > > >On 06/26/2012 11:03 AM, Daniel P. Berrange wrote: > >>On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: > >>>On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey

Re: [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-06-26 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant wrote: > Signed-off-by: Corey Bryant If this patch doesn't change anymore you can add: Reviewed-by: Luiz Capitulino > --- > v2: > -Convert getfd and closefd to QAPI (lcapitul...@redhat.com) > -Remove changes that returned fd from getfd (lcap

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- > v4: > -This patch is new in v4. Can you explain why it's needed? > > monitor.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/

[Qemu-devel] [PATCH 2/4] file_ram_alloc: change length argument to size_t

2012-06-26 Thread Eduardo Habkost
While we are at it, rename it to "length", as "memory" doesn't mean anything. Signed-off-by: Eduardo Habkost --- exec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index 8244d54..5f3b265 100644 --- a/exec.c +++ b/exec.c @@ -2354,7 +2354,7 @@

[Qemu-devel] [PATCH 1/4] vl.c: change mem_prealloc to bool

2012-06-26 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- cpu-all.h |2 +- vl.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 9dc249a..2beed5a 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -490,7 +490,7 @@ typedef struct RAMList { extern RAMList ram_list;

[Qemu-devel] [PATCH RFC 4/4] add -keep-mem-path-files option

2012-06-26 Thread Eduardo Habkost
This make QEMU create files inside the -mem-path directory using more predictable names, and not remove them afterwards. This allow (for example) users or management layers to use numactl later, to set NUMA policy for the guest RAM. Signed-off-by: Eduardo Habkost --- cpu-all.h |1 + e

[Qemu-devel] [PATCH RFC 0/4] option to not remove files inside -mem-path dir

2012-06-26 Thread Eduardo Habkost
I was investigating if there are any mechanisms that allow manually pinning of guest RAM to specific host NUMA nodes, in the case of multi-node KVM guests, and noticed that -mem-path could be used for that, except that it currently removes any files it creates (using mkstemp()) immediately, not all

[Qemu-devel] [PATCH 3/4] file_ram_alloc(): extract temporary-file creation code to separate function

2012-06-26 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- exec.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c index 5f3b265..dcbe4e1 100644 --- a/exec.c +++ b/exec.c @@ -2353,11 +2353,34 @@ static long gethugepagesize(const char *path)

Re: [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-06-26 Thread Corey Bryant
On 06/26/2012 04:44 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant If this patch doesn't change anymore you can add: Reviewed-by: Luiz Capitulino Thanks! I'll do that. I'll assume we still want this patch even if pas

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 13:45:52 +0200 Kevin Wolf wrote: > Am 26.06.2012 11:10, schrieb Daniel P. Berrange: > > I was thinking about some of the sources complexity when using > > FD passing from libvirt and wanted to raise one idea for discussion > > before we continue. > > > > With this proposed se

Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-26 Thread Benjamin Herrenschmidt
On Mon, 2012-06-25 at 22:55 -0600, Alex Williamson wrote: > Hi, > > VFIO has been kicking around for well over a year now and has been > posted numerous times for review. The pre-requirements are finally > available in linux-next (or will be in the 20120626 build) so I'd lik

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Corey Bryant
On 06/26/2012 04:45 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant --- v4: -This patch is new in v4. Can you explain why it's needed? This just made patch 3/7 easier to review. monitor.c | 40 --

Re: [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 17:15:05 -0400 Corey Bryant wrote: > > > On 06/26/2012 04:44 PM, Luiz Capitulino wrote: > > On Fri, 22 Jun 2012 14:36:09 -0400 > > Corey Bryant wrote: > > > >> Signed-off-by: Corey Bryant > > > > If this patch doesn't change anymore you can add: > > > > Reviewed-by: Luiz

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 17:16:28 -0400 Corey Bryant wrote: > > > On 06/26/2012 04:45 PM, Luiz Capitulino wrote: > > On Fri, 22 Jun 2012 14:36:11 -0400 > > Corey Bryant wrote: > > > >> Signed-off-by: Corey Bryant > >> --- > >> v4: > >> -This patch is new in v4. > > > > Can you explain why it's n

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Corey Bryant
On 06/26/2012 05:28 PM, Luiz Capitulino wrote: On Tue, 26 Jun 2012 17:16:28 -0400 Corey Bryant wrote: On 06/26/2012 04:45 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant --- v4: -This patch is new in v4. Can you explai

Re: [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-06-26 Thread Corey Bryant
On 06/26/2012 05:28 PM, Luiz Capitulino wrote: On Tue, 26 Jun 2012 17:15:05 -0400 Corey Bryant wrote: On 06/26/2012 04:44 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant If this patch doesn't change anymore you can add:

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Corey Bryant
On 06/26/2012 04:50 PM, Luiz Capitulino wrote: On Tue, 26 Jun 2012 13:45:52 +0200 Kevin Wolf wrote: Am 26.06.2012 11:10, schrieb Daniel P. Berrange: I was thinking about some of the sources complexity when using FD passing from libvirt and wanted to raise one idea for discussion before we c

[Qemu-devel] [PATCH 6/6] sheepdog: traverse pending_list from the first for each time

2012-06-26 Thread MORITA Kazutaka
The pending list can be modified in other coroutine context sd_co_rw_vector, so we need to traverse the list from the first again after we send the pending request. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-

Re: [Qemu-devel] [PULL 0/6] usb patch queue.

2012-06-26 Thread Anthony Liguori
On 06/20/2012 09:05 AM, Gerd Hoffmann wrote: Hi, This is the usb patch queue, featuring live migration support for ehci and usb-host. Also as usual some small bugfixes. pleae pull, Gerd Pulled. Thanks. Regards, Anthony Liguori The following changes since commit 93bfef4c6e4b23caea

Re: [Qemu-devel] [PULL] Xen PCI Passthrough

2012-06-26 Thread Anthony Liguori
On 06/21/2012 11:13 AM, Stefano Stabellini wrote: Anthony, please pull Anthony Perard's Xen PCI Passthrough series from: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-pt All the generic patches have been acked by Michael, the Xen patches have been reviewed by Konrad and me. Pulled.

Re: [Qemu-devel] [PULL] Xen compile fixes

2012-06-26 Thread Anthony Liguori
On 06/21/2012 11:17 AM, Stefano Stabellini wrote: Anthony, please pull a couple of small Xen compile fixes to compile against xen-unstable: git://xenbits.xen.org/people/sstabellini/qemu-dm.git compile-xs Pulled. Thanks. Regards, Anthony Liguori Anthony PERARD (2): xen: Reorganize

Re: [Qemu-devel] [PULL] qemu-ga patches for guest-fstrim command

2012-06-26 Thread Anthony Liguori
On 06/21/2012 06:04 PM, Michael Roth wrote: The following changes since commit 47ecbdf07ed2c37bdfd2d77137d01bb319ce13da: libcacard: build fixes (2012-06-21 20:04:24 +) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-6-21-12 Pulled. Thanks. Regards

Re: [Qemu-devel] [PULL 00/10] spice patch queue: qxl & vga bits

2012-06-26 Thread Anthony Liguori
On 06/22/2012 04:25 AM, Gerd Hoffmann wrote: Hi, The spice patch queue carries a few vga bits this time, specifically it makes the vga ram size configurable. There are also a few qxl bugfixes and cleanups. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd Alon Levy (6):

Re: [Qemu-devel] [PULL 00/12] Trivial patches for June 9 to 22 2012

2012-06-26 Thread Anthony Liguori
On 06/22/2012 04:39 AM, Stefan Hajnoczi wrote: The following changes since commit 47ecbdf07ed2c37bdfd2d77137d01bb319ce13da: libcacard: build fixes (2012-06-21 20:04:24 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch chan

[Qemu-devel] [PATCH 3/6] sheepdog: use coroutine based socket functions in coroutine context

2012-06-26 Thread MORITA Kazutaka
This removes blocking network I/Os in coroutine context. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0b49c6d..5dc1d7a 100644 --- a/block/sheepdog.c +++ b/block/shee

[Qemu-devel] [PATCH 0/6] sheepdog: various fixes

2012-06-26 Thread MORITA Kazutaka
See individual patches for details. MORITA Kazutaka (6): sheepdog: fix dprintf format strings sheepdog: restart I/O when socket becomes ready in do_co_req() sheepdog: use coroutine based socket functions in coroutine context sheepdog: make sure we don't free aiocb before sending all reques

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Corey Bryant
On 06/26/2012 04:42 PM, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 02:40:03PM -0400, Corey Bryant wrote: On 06/26/2012 11:37 AM, Corey Bryant wrote: On 06/26/2012 11:03 AM, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: On Tue, Jun 2

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Eric Blake
On 06/26/2012 04:28 PM, Corey Bryant wrote: With this proposed series, we have usage akin to: 1. pass_fd FDSET={M} -> returns a string "/dev/fd/N" showing QEMU's view of the FD 2. drive_add file=/dev/fd/N 3. if failure: close_fd "/dev/fd/N"

[Qemu-devel] [PATCH 1/6] sheepdog: fix dprintf format strings

2012-06-26 Thread MORITA Kazutaka
This fixes warnings about dprintf format in debug mode. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 8877f45..afd06aa 100644 --- a/block/sheepdog.c +++ b/block/sheepdo

[Qemu-devel] [PATCH 4/6] sheepdog: make sure we don't free aiocb before sending all requests

2012-06-26 Thread MORITA Kazutaka
This patch increments the pending counter before sending requests, and make sures that aiocb is not freed while sending them. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/block/sheepdog.

[Qemu-devel] [PATCH 5/6] sheepdog: split outstanding list into inflight and pending

2012-06-26 Thread MORITA Kazutaka
outstanding_list_head is used for both pending and inflight requests. This patch splits it and improves readability. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 49 - 1 files changed, 24 insertions(+), 25 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH 2/6] sheepdog: restart I/O when socket becomes ready in do_co_req()

2012-06-26 Thread MORITA Kazutaka
Currently, no one reenters the yielded coroutine. This fixes it. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index afd06aa..0b49c6d 100644 --- a/block/sheepdog.c ++

[Qemu-devel] Possible qemu gpl license violation

2012-06-26 Thread Alan Nelson
I read a thread "ARM binary code translator" on android-x86 Google Group ( https://groups.google.com/forum/?fromgroups#!topic/android-x86/_3HoNJTi_Y0). It is mentioned that Bluestacks (www.bluestacks.com) uses qemu for an arm binary translator in its software that runs Android apps. I downloaded th

Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-26 Thread Stephen Rothwell
Hi Alex, On Mon, 25 Jun 2012 22:55:52 -0600 Alex Williamson wrote: > > VFIO has been kicking around for well over a year now and has been > posted numerous times for review. The pre-requirements are finally > available in linux-next (or will be in the 20120626 build) so I'd li

[Qemu-devel] buildbot failure in qemu on block_openbsd_4.9

2012-06-26 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_4.9/builds/249 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Build

[Qemu-devel] buildbot failure in qemu on block_openbsd_current

2012-06-26 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_current while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_current/builds/262 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: brad_openbsd_cur

Re: [Qemu-devel] qemu as dynamic binary translation infrastructure

2012-06-26 Thread Wei-Ren Chen
Hi Liu, You might find this thread interesting, http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg04351.html Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-06-26 Thread Peter Crosthwaite
Ping! Any Further thoughts Kevin? This thread flew off on a tangent over whether or not coroutines should be depracated. Seems to be the answer there was no on that front - coroutines are here to stay. I still think this thread points out a major flaw in block+coroutines, regardless of the fact

  1   2   >