Re: [Qemu-devel] [PATCH v5 12/16] target-or32: Add system instructions

2012-06-19 Thread Jia Liu
Hi Blue, On Wed, Jun 20, 2012 at 2:25 AM, Blue Swirl wrote: > On Tue, Jun 19, 2012 at 8:02 AM, Jia Liu wrote: >> Hi Blue, >> >> Thank you for review. >> Is this code OK? >> >> void HELPER(mtspr)(CPUOpenRISCState * env, >>                   target_ulong ra, target_ulong rb, target_ulong offset) >

[Qemu-devel] [Patch V10 0/5] i.MX31: Add initial support

2012-06-19 Thread Peter Chubb
Changes since V9: Added MAINTAINERS entry, rebased (and tested) against git tip. Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

[Qemu-devel] [Patch V10 5/5] i.MX31: KZM-ARM11-01 evaluation board

2012-06-19 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the Freescale i.MX31. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb --- MAINTAINERS |6 + hw/arm/Makefile.objs |1 hw/kzm.c | 154 +++

[Qemu-devel] [Patch V10 2/5] i.MX31: Clock Control Module

2012-06-19 Thread Peter Chubb
For Linux to be able to work out how fast its clocks are going, so that timer ticks come approximately at the right time, it needs to be able to query the clock control module (CCM). This is the start of a CCM implementation. It currently knows only about the MCU, HSP and IPG clocks --- i.e., t

[Qemu-devel] [Patch V10 1/5] i.MX: UART support

2012-06-19 Thread Peter Chubb
Implement the Freescale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the Freescale i.MX series. This patch gives only a `bare-bones' implementation, enough to run Linux or OKL4, but that's about it. Signed-off-by: Philip O'Sullivan Signed-off-by

[Qemu-devel] [Patch V10 4/5] i.MX31: Interrupt Controller

2012-06-19 Thread Peter Chubb
Implement the Freescale i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb Reviewed-by: Peter Maydell --- hw/arm/Makefile.objs |2 hw/imx_avic.c|

[Qemu-devel] [Patch V10 3/5] i.MX31: Timers

2012-06-19 Thread Peter Chubb
Implement the timers on the Freescale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run. In particular external triggers, which are not useful under QEMU, are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb --- hw/arm/M

Re: [Qemu-devel] Cant Upload tests to Wiki

2012-06-19 Thread Peter Crosthwaite
On Tue, Jun 19, 2012 at 11:57 PM, Anthony Liguori wrote: > On 06/19/2012 01:18 AM, Peter Crosthwaite wrote: >> >> Hi, >> >> I'm trying to upload my little endian Microblaze test vector to the >> wiki, but the file upload restrictions are for images only and file >> size<  2MB. Can we relax these s

Re: [Qemu-devel] [PATCH] hw/cadence_gem: Make rx_desc_addr and tx_desc_addr uint32_t

2012-06-19 Thread Peter Crosthwaite
On Wed, May 23, 2012 at 3:02 AM, Peter Maydell wrote: > Make the state fields rx_desc_addr and tx_desc_addr uint32_t; > this matches the VMStateDescription, and also conforms to how > hardware works: the registers don't magically become larger > if the device is attached to a CPU with a larger phy

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-19 Thread Guan Xuetao
On Mon, 2012-06-18 at 19:51 +, Blue Swirl wrote: > On Mon, Jun 18, 2012 at 9:24 AM, Guan Xuetao wrote: > > Coprocessor 0 is system control coprocessor, and we need get/set its > > contents. > > Also, all cache/tlb ops shoule be implemented here, but just ignored with > > no harm. > > > > Cop

Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given

2012-06-19 Thread Peter Crosthwaite
It matches my flow in the real hardware. Heres the scenario where we need this (FYI applies to both microblaze and arm): User creates a Linux elf that includes a built in dtb. Slave mode bootloader boots the real hardware with the elf (my actual real JTAG bootloader work with elfs). However QEMU

Re: [Qemu-devel] [PATCH 14/16] cadence_gem: avoid stack-writing buffer-overrun

2012-06-19 Thread Peter Crosthwaite
I re-sent this yesterday to trivial. May end up getting queued for merge twice. On Tue, Jun 19, 2012 at 11:31 PM, Peter Maydell wrote: > From: Jim Meyering > > Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number > of bytes to clear.  The latter would always clear 4 or 8 > bytes, possi

Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-19 Thread Guan Xuetao
On Mon, 2012-06-18 at 20:02 +, Blue Swirl wrote: [snip] > > diff --git a/hw/puv3.h b/hw/puv3.h > > new file mode 100644 > > index 000..bcfc978 > > --- /dev/null > > +++ b/hw/puv3.h > > @@ -0,0 +1,49 @@ > > +/* > > + * Misc PKUnity SoC declarations > > + * > > + * Copyright (C) 2010-2012 Gua

Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support

2012-06-19 Thread Guan Xuetao
On Mon, 2012-06-18 at 20:05 +, Blue Swirl wrote: [snip] > > +static void puv3_pm_write(void *opaque, target_phys_addr_t offset, > > +uint64_t value, unsigned size) > > +{ > > +PUV3PMState *s = (PUV3PMState *) opaque; > > + > > +switch (offset) { > > +case 0x0: > > +s

Re: [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-19 Thread Guan Xuetao
On Mon, 2012-06-18 at 19:59 +, Blue Swirl wrote: [snip] > > + > > +#define PUV3_DMA_CH_NR (6) > > +#define PUV3_DMA_CH_MASK(0xff) > > +#define PUV3_DMA_CH(offset) ((offset) >> 8) > > + > > +typedef struct { > > +SysBusDevice busdev; > > +MemoryRegion iomem; > > +

Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers

2012-06-19 Thread David Gibson
On Wed, Jun 20, 2012 at 06:23:58AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2012-06-19 at 15:42 +0200, Gerd Hoffmann wrote: > > Well, that isn't guaranteed ... > > > > > - otherwise the guest > > > might invalidate IOMMU mappings while they are still in use by the device > > > code. > > > >

Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers

2012-06-19 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 13:14 +1000, David Gibson wrote: > So, in fact the original comment is a bit out of date. With the > current version of this series, then a guest attempt to invalidate > will be delayed until the unmap occurs. No, this code was dropped, including the tracking of the maps, f

[Qemu-devel] [PATCH] target-i386: Use QEMU instead of Qemu

2012-06-19 Thread Stefan Weil
This new 'QEmu' was recently added. Replace it by the official all upper case 'QEMU'. Signed-off-by: Stefan Weil --- Hopefully those 'Qemu' and 'QEmu' variants will stop as soon as my patch for checkpatch.pl was applied. target-i386/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[Qemu-devel] [PATCH v3 0/6] convert sendkey to qapi

2012-06-19 Thread Amos Kong
This series converted 'sendkey' command to qapi. The raw value in hexadecimal format is not supported by 'sendkey' of qmp. Amos Kong (6): fix doc of using raw values with sendkey monitor: rename keyname '<' to 'less' hmp: rename arguments qapi: generate list struct and visit_list for enum

[Qemu-devel] [PATCH v3 2/6] monitor: rename keyname '<' to 'less'

2012-06-19 Thread Amos Kong
There are many maps of keycode 0x56 in pc-bios/keymaps/* pc-bios/keymaps/common:less 0x56 pc-bios/keymaps/common:greater 0x56 shift pc-bios/keymaps/common:bar 0x56 altgr pc-bios/keymaps/common:brokenbar 0x56 shift altgr This patch just renames '<' to 'less', QAPI would add new variable by

[Qemu-devel] [PATCH v3 4/6] qapi: generate list struct and visit_list for enum

2012-06-19 Thread Amos Kong
Currently, if define an 'enum' and use it in one command's data, List struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. >>> qapi-schema.json: { 'enum': 'KeyCodes', 'data': [ 'shift', 'alt' ... ] } { 'command': 'sendkey', 'd

[Qemu-devel] [PATCH v3 6/6] ps2: output warning when event queue full

2012-06-19 Thread Amos Kong
Event would be ignored if ps2 queue is full, this patch added a warning in ignore path. Signed-off-by: Amos Kong --- hw/ps2.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index f93cd24..799c36b 100644 --- a/hw/ps2.c +++ b/hw/ps2.c @@ -137,8 +137

[Qemu-devel] [PATCH v3 1/6] fix doc of using raw values with sendkey

2012-06-19 Thread Amos Kong
(qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not requested before raw values. And the raw value in decimal format is also not supported. Signed-off-by: Amos Kong --- hmp-commands.hx |6 +++--- 1 files changed, 3 insert

[Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-19 Thread Amos Kong
Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in monitor.c is the mapping of key name to keycode, Keys' order in the enmu and key_defs[] is same. Signed-off-by: Amos Kong --- hmp-commands.hx |2

[Qemu-devel] [PATCH v3 3/6] hmp: rename arguments

2012-06-19 Thread Amos Kong
Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'. Signed-off-by: Amos Kong --- hmp-commands.hx |2 +- monitor.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 30243b6..e336251 100644 --- a/hmp-co

Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers

2012-06-19 Thread Gerd Hoffmann
Hi, >> Like with any other device, it's hard ... what would happen on real >> hardware is that the USB controller will get a target abort, which will >> result in the controller reporting an error (typically in the PCI status >> register) and stopping. Not that hard, code to cancel in-flight tr

Re: [Qemu-devel] [PATCH v5 11/16] target-or32: Add a IIS dummy board

2012-06-19 Thread Max Filippov
On 06/18/2012 05:02 AM, Jia Liu wrote: > Add a dummy board for IIS. > > Signed-off-by: Jia Liu [...] > +if (nd_table[0].vlan) { > +isa_ne2000_init(isa_bus, 0x9200, 4,&nd_table[0]); > +} I have noticed that the kernel you provided expects OpenCores ethernet device. We have a

[Qemu-devel] [PATCH 0/2] Hotplug support for virtio-scsi

2012-06-19 Thread Cong Meng
These patches implement the hotplug support for virtio-scsi. When a new device attaches/detaches to virtio-scsi bus via device_add/device_del commands, the HBA driver in guest kernel will be signaled to add/remove the scsi device. Cong Meng (2): scsi bus: introduce hotplug() and hot_unplug() int

[Qemu-devel] [PATCH 2/2] virtio-scsi: Implement hotplug support for virtio-scsi

2012-06-19 Thread Cong Meng
Implement the hotplug() and hot_unplug() interfaces in virtio-scsi, by signal the virtio_scsi.ko in guest kernel via event virtual queue. The counterpart patch of virtio_scsi.ko will be sent soon in another thread. Signed-off-by: Cong Meng Signed-off-by: Sen Wang --- hw/virtio-scsi.c | 72 ++

[Qemu-devel] [PATCH 1/2] scsi bus: introduce hotplug() and hot_unplug() interfaces for SCSI bus

2012-06-19 Thread Cong Meng
Add two interfaces hotplug() and hot_unplug() to scsi bus info. The embody scsi bus can implement these two interfaces to signal the HBA driver of guest kernel to add/remove the scsi device in question. Signed-off-by: Cong Meng Signed-off-by: Sen Wang --- hw/scsi-bus.c | 16 +++-

<    1   2   3