[Qemu-devel] [PATCH 06/13] ide/ahci: Use universal DMA helper functions

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson The AHCI device can provide both PCI and SysBus AHCI device emulations. For this reason, it wasn't previously converted to use the pci_dma_*() helper functions. Now that we have universal DMA helper functions, this converts AHCI to use them. The DMAContext is obtained from p

[Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson This patch adds cpu_physical_memory_set() function. This is equivalent to calling cpu_physical_memory_write() with a buffer filled with a character, ie, a memset of target memory. It uses a small temporary buffer on the stack. Signed-off-by: David Gibson Signed-off-by: Benj

[Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for guest visible IOMMUs. There are some instances of targe

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-19 Thread Arndt Kritzner
With e1000 and ide I also get BSOD (tried this already), but I don't have a matching dump by hand at the moment. I will "produce" and provide a dump till tomorrow morning (germany). Arndt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

[Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson The USB UHCI and EHCI drivers were converted some time ago to use the pci_dma_*() helper functions. However, this conversion was not complete because in some places both these drivers do DMA via the usb_packet_map() function in usb-libhw.c. That function directly used cpu_phy

[Qemu-devel] [PATCH 11/13] iommu: Allow PCI to use IOMMU infrastructure

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson This patch adds some hooks to let PCI devices and busses use the new IOMMU infrastructure. When IOMMU support is enabled, each PCI device now contains a DMAContext * which is used by the pci_dma_*() wrapper functions. By default, the contexts are initialized to NULL, assuming

[Qemu-devel] [PATCH 10/13] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson The pseries platform already contains an IOMMU implementation, since it is essential for the platform's paravirtualized VIO devices. This IOMMU support is currently built into the implementation of the VIO "bus" and the various VIO devices. This patch converts this code to ma

[Qemu-devel] [PATCH 13/13] Add a memory barrier to DMA functions

2012-06-19 Thread Benjamin Herrenschmidt
The emulated devices can run simultaneously with the guest, so we need to be careful with ordering of load and stores done by them to the guest system memory, which need to be observed in the right order by the guest operating system. This adds a barrier call to the basic DMA read/write ops which

[Qemu-devel] [PATCH 09/13] iommu: Add facility to cancel in-use dma memory maps

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson One new complication raised by IOMMU support over only handling DMA directly to physical addresses is handling dma_memory_map() case (replacing cpu_physical_memory_map()) when the IOMMU translation the IOVAs covered by such a map are invalidated or changed while the map is acti

[Qemu-devel] [PATCH 05/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson dma-helpers.c contains a number of helper functions for doing scatter/gather DMA, and various block device related DMA. Currently, these directly access guest memory using cpu_physical_memory_*(), assuming no IOMMU translation. This patch updates this code to use the new univ

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-19 Thread Kevin Wolf
Am 18.06.2012 20:31, schrieb Anthony Liguori: > Irrespective of anything else, I think it's safe to say the experiment of > "rich > errors" has been a failure. We still have way too many places using > error_report. > > As I mentioned in another thread, I think we should: > > 1) Introduce a G

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-19 Thread vrozenfe
"virtio_ioport_write: unexpected address 0x13 value 0x1" indicates that you got a BSOD. Could you try switching from virtio to e1000, and ide and check if you still getting DRIVER_CORRUPTED_EXPOOL (c5) bug check error? Vadim. -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-19 Thread Markus Armbruster
Blue Swirl writes: > On Mon, Jun 18, 2012 at 9:10 AM, Markus Armbruster wrote: >> Commit 5bbdbb46 moved it to block.c because "other geometry guessing >> functions already reside in block.c".  Device-specific functionality >> should be kept in device code, not the block layer.  Move it back. > >

[Qemu-devel] [Bug 1014823] Re: qemu-kvm-1.0.1 compilation error on Ubuntu 12.04

2012-06-19 Thread Serge Hallyn
The bug is actually in libc (see bug 1010069). You can work around it using the same patch we are using in the ubuntu package, define_AT_EMPTY_PATH.patch. It probably won't apply cleanly upstream, but just make sure to add #ifndef AT_REMOVEDIR #define AT_REMOVEDIR0x200 #endif #ifndef AT_EMPT

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2012-06-19 Thread khetzal
Hello, yes i still have this bug on ubuntu 12.04 (kernel 3.2) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/712416 Title: kvm_intel kernel module crash with via nano vmx Status in QEMU: New Stat

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-19 Thread Wei-Ren Chen
> But if QEMU/TCG is doing a GVA->GPA translation as Wei-Ren said, I don't see > how > KVM can help. Just want to clarify. QEMU maintain a TLB (env->tlb_table) which stores GVA -> HVA mapping, it is used to speedup the address translation. If TLB miss, QEMU will call cpu_arm_handle_mmu_fault (t

[Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson Not that long ago, every device implementation using DMA directly accessed guest memory using cpu_physical_memory_*(). This meant that adding support for a guest visible IOMMU would require changing every one of these devices to go through IOMMU translation. Shortly before qe

[Qemu-devel] [Bug 1014823] [NEW] qemu-kvm-1.0.1 compilation error on Ubuntu 12.04

2012-06-19 Thread Whit Blauvelt
Public bug reported: CClibhw64/9pfs/virtio-9p-handle.o /usr/src/qemu-kvm-1.0.1/hw/9pfs/virtio-9p-handle.c: In function ‘handle_update_file_cred’: /usr/src/qemu-kvm-1.0.1/hw/9pfs/virtio-9p-handle.c:70:58: error: ‘AT_EMPTY_PATH’ undeclared (first use in this function) /usr/src/qemu-kvm-1.0.1

Re: [Qemu-devel] Windows Vista 64 bit on QEMU

2012-06-19 Thread Edward Tisdale
Anup Gangwar gmail.com> writes: > > Hello All,Has anyone had success installing (and runnning) Vista 64 bit on QEMU. I tried it and landed into a variety of windows blue screen errors. The EFI BIOS also does not seem to be working with the QEMU version in CVS. > Thanks for the help.Regards,Anup

Re: [Qemu-devel] [PATCH v5 12/16] target-or32: Add system instructions

2012-06-19 Thread Jia Liu
Hi Blue, Thank you for review. Is this code OK? void HELPER(mtspr)(CPUOpenRISCState * env, target_ulong ra, target_ulong rb, target_ulong offset) { #ifndef CONFIG_USER_ONLY int spr = (ra | offset); int idx; switch (spr) { case TO_SPR(0, 0): /* VR */ env

[Qemu-devel] [Bug 1014823] Re: qemu-kvm-1.0.1 compilation error on Ubuntu 12.04

2012-06-19 Thread Serge Hallyn
(Note, the patch has Subject: Subject: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs) ) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014823 Title: qemu-kvm-1

[Qemu-devel] [Bug 1014823] Re: qemu-kvm-1.0.1 compilation error on Ubuntu 12.04

2012-06-19 Thread Serge Hallyn
Oh, actually I was about to mark this invalid, but in fact it is a valid bug that it is trying to compile this bit of code when the AT* were not defined. There is a patch sent and acked upstream to fix this, so I'll mark it confirmed for now. ** Changed in: qemu Status: New => Confirmed -

[Qemu-devel] [PATCH] Add missing check for host_from_stream_offset return value for RAM_SAVE_FLAG_PAGE

2012-06-19 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a9e8b74..81c2e54 100644 --- a/arch_init.c +++ b/arch_init.c @@ -483,6 +483,9 @@ int ram_load(QEMUFile *f, void *opaque, int version_id)

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Wei-Ren Chen
Hi Andreas, > Poisoned is the "env" variable. You cannot just #include "dyngen-exec.h" > and expect it to be usable since AREG0 targets don't guarantee it's set > properly (may be NULL even with traditional targets at times). Oops, I miss that point. > CPUArchState should currently be usable

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-19 Thread Orit Wasserman
On 06/19/2012 11:49 AM, 陳韋任 (Wei-Ren Chen) wrote: > Mind me CC this to ML? :) sure I will read the threads to understand more. Orit > >> Well it was a while back (2008-9) ,the company was acquired by IBM a year >> later : >> http://www.linux-kvm.org/wiki/images/9/98/KvmForum2008%24kdf2008_2.pd

Re: [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU

2012-06-19 Thread Bharata B Rao
On Mon, Jun 18, 2012 at 04:36:04PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 3:18 PM, Bharata B Rao > wrote: > > 4. Creating VM image > > > > # qemu-img create -f gluster gluster:c-qemu.vol:/F16 5G > > Do you really need "-f gluster"? I realized that we don't. I was picked it up fr

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-19 Thread Daniel P. Berrange
On Tue, Jun 19, 2012 at 09:39:34AM +0200, Kevin Wolf wrote: > Am 18.06.2012 20:31, schrieb Anthony Liguori: > > Irrespective of anything else, I think it's safe to say the experiment of > > "rich > > errors" has been a failure. We still have way too many places using > > error_report. > > > >

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Daniel P. Berrange
On Mon, Jun 18, 2012 at 08:15:37PM +, Blue Swirl wrote: > On Mon, Jun 18, 2012 at 8:31 AM, Daniel P. Berrange > wrote: > > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: > >> On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > >> > I think allowing execve() would render secc

Re: [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend

2012-06-19 Thread Avi Kivity
On 06/18/2012 08:35 PM, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 3:21 PM, Bharata B Rao > wrote: >> +#include "block_int.h" >> +#include "gluster-helpers.h" >> + >> +typedef void *gluster_file_t; > > This typedef is already in gluster-helpers.h. It's ugly BTW, "typedef > struct gluster_f

Re: [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend

2012-06-19 Thread Bharata B Rao
On Mon, Jun 18, 2012 at 06:35:28PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 3:21 PM, Bharata B Rao > wrote: > > +#include "block_int.h" > > +#include "gluster-helpers.h" > > + > > +typedef void *gluster_file_t; > > This typedef is already in gluster-helpers.h. Yes, will fix that.

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-19 Thread Kevin Wolf
Am 19.06.2012 11:20, schrieb Daniel P. Berrange: > On Tue, Jun 19, 2012 at 09:39:34AM +0200, Kevin Wolf wrote: >> Am 18.06.2012 20:31, schrieb Anthony Liguori: >>> Irrespective of anything else, I think it's safe to say the experiment of >>> "rich >>> errors" has been a failure. We still have wa

Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs

2012-06-19 Thread Bharata B Rao
On Mon, Jun 18, 2012 at 06:35:52PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 3:20 PM, Bharata B Rao > wrote: > > +    ret = pthread_create(&thread, NULL, gluster_handle_poll, > > +    (void *)gctx); > > Please use qemu-thread.h. QEMU uses signals so you almost certainly > want to m

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-19 Thread Amos Kong
On 18/06/12 23:30, Amos Kong wrote: On 06/15/2012 09:35 PM, Luiz Capitulino wrote: On Fri, 15 Jun 2012 09:57:49 +0200 Gerd Hoffmann wrote: Hi, It seems we need to notice user when inputted keys are more than 16. Hi Gerd, When I use 'sendkey' command to send key-series to guest, some k

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Andreas Färber
Hi, Am 19.06.2012 11:02, schrieb 陳韋任 (Wei-Ren Chen): >> Question is, what are you trying to do? In particular, of which CPU >> (think SMP) are you trying to print ->some_field? :) > > Currently we only consider single CPU ARM guest, so there should be only one > env we need to take care of. We

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-19 Thread Andreas Färber
Am 19.06.2012 08:40, schrieb Peter Crosthwaite: > On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko > wrote: >> >> Hi Peter, sorry for not properly reviewing your patch for such a long time, >> I'll try to do this as soon as possible. Right now I have a few small >> coments >> >> >> >> On 06/18/201

[Qemu-devel] [Bug 1013241] Re: qemu-system-ppc64 hanging occasionally in disk writes

2012-06-19 Thread Richard W.M. Jones
I switched to using virtio-scsi (instead of virtio-blk). This appears to have solved this problem, although it brings another problem. I also tried vscsi, which fixes both problems. Therefore I will (not definitively) claim that the problem lies somewhere in virtio-blk, but a workaround seems

Re: [Qemu-devel] Status of query-netdev QMP command

2012-06-19 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 3:19 PM, Roger Pau Monne wrote: > I've read from the GSoC/2010 that some work was being done creating a > query-netdev QMP command: > > http://wiki.qemu.org/Google_Summer_of_Code_2010/QMP#query-netdev > > The status says that "mentor has merged it into his tree", but I cann

Re: [Qemu-devel] [Bug 1013241] Re: qemu-system-ppc64 hanging occasionally in disk writes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 10:16 +, Richard W.M. Jones wrote: > I switched to using virtio-scsi (instead of virtio-blk). This appears to > have solved > this problem, although it brings another problem. I also tried vscsi, which > fixes > both problems. > > Therefore I will (not definitively) c

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-19 Thread Lluís Vilanova
Michael Kang writes: > On Tue, Jun 19, 2012 at 4:26 AM, Lluís Vilanova wrote: [...] >> I could understand having multiple 32bit regions in QEMU's virtual space (no >> need for KVM), one per guest page table, and then simply adding an offset to >> every memory access to redirect it to the appropri

Re: [Qemu-devel] Status of query-netdev QMP command

2012-06-19 Thread Roger Pau Monne
Stefan Hajnoczi wrote: On Mon, Jun 18, 2012 at 3:19 PM, Roger Pau Monne wrote: I've read from the GSoC/2010 that some work was being done creating a query-netdev QMP command: http://wiki.qemu.org/Google_Summer_of_Code_2010/QMP#query-netdev The status says that "mentor has merged it into his t

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-19 Thread Peter Maydell
On 19 June 2012 11:17, Andreas Färber wrote: > Am 19.06.2012 08:40, schrieb Peter Crosthwaite: >> On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko >>> And it still has no save/load support, it is really mandatory for all new >>> devices. I can recall that one of the maintainers wrote a while ago t

[Qemu-devel] [Bug 1013241] Re: qemu-system-ppc64 hanging occasionally in disk writes

2012-06-19 Thread Richard W.M. Jones
The problem with virtio-scsi is only a single disk shows up: https://bugs.launchpad.net/qemu/+bug/1013691 I've been using guest kernels 3.3.4 and 3.5.0-rc2+ (ie. Linus git), and both behave the same way. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] Status of query-netdev QMP command

2012-06-19 Thread Stefan Hajnoczi
On Tue, Jun 19, 2012 at 11:53 AM, Roger Pau Monne wrote: > Stefan Hajnoczi wrote: >> >> On Mon, Jun 18, 2012 at 3:19 PM, Roger Pau Monne >>  wrote: >>> >>> I've read from the GSoC/2010 that some work was being done creating a >>> query-netdev QMP command: >>> >>> http://wiki.qemu.org/Google_Summer

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Avi Kivity
On 06/16/2012 09:46 AM, Blue Swirl wrote: > On Fri, Jun 15, 2012 at 9:36 PM, Paul Moore wrote: >> On Friday, June 15, 2012 09:23:46 PM Blue Swirl wrote: >>> On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wrote: >>> > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: >>> >> I think allowing exec

Re: [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend

2012-06-19 Thread Stefan Hajnoczi
On Tue, Jun 19, 2012 at 10:30 AM, Bharata B Rao wrote: > On Mon, Jun 18, 2012 at 06:35:28PM +0100, Stefan Hajnoczi wrote: >> On Mon, Jun 11, 2012 at 3:21 PM, Bharata B Rao >> wrote: >> > + á á/* Use O_DSYNC for write-through caching, no flags for write-back >> > caching, >> > + á á * and O_DIREC

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Andreas Färber
Am 19.06.2012 08:02, schrieb Benjamin Herrenschmidt: > We were incorrectly g_free'ing an object that isn't allocated > in one error path and failed to release it completely in another > > This fixes qemu crashes with some cases of IO errors. > > Signed-off-by: Benjamin Herrenschmidt > --- > hw/

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Wei-Ren Chen
> If you only have one CPU then using first_cpu->some_field1 should be > almost as easy. :) I am afraid first_cpu (CPUArchState) is got poisoned, too. :/ Even I comment out CPUArchState from poison.h, --- vl.c extern CPUArchState *first_cpu; static void main_loop(void) { ... snip ...

Re: [Qemu-devel] [PATCHv3] Add PIIX4 properties to control PM system states.

2012-06-19 Thread Gleb Natapov
On Wed, Jun 13, 2012 at 04:23:28PM +0300, Gleb Natapov wrote: > Ping? > Ping 2? > On Mon, Jun 04, 2012 at 02:31:55PM +0300, Gleb Natapov wrote: > > This patch adds two things. First it allows QEMU to distinguish between > > regular powerdown and S4 powerdown. Later separate QMP notification will

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Peter Maydell
On 19 June 2012 12:54, 陳韋任 (Wei-Ren Chen) wrote: >> If you only have one CPU then using first_cpu->some_field1 should be >> almost as easy. :) > >  I am afraid first_cpu (CPUArchState) is got poisoned, too. :/ Yes. You'll need to write a function which lives in a source file which has access to t

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Peter Crosthwaite
Andreas, will an attribute((destructor)) work ? Cos if it does you can put your printf pretty much anwhere rather than vl.c On Jun 19, 2012 9:54 PM, "陳韋任 (Wei-Ren Chen)" wrote: > > If you only have one CPU then using first_cpu->some_field1 should be > > almost as easy. :) > > I am afraid first_c

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-19 Thread Michael.Kang
On Tue, Jun 19, 2012 at 3:52 PM, 陳韋任 (Wei-Ren Chen) wrote: >> But if QEMU/TCG is doing a GVA->GPA translation as Wei-Ren said, I don't see >> how >> KVM can help. > >  Just want to clarify. QEMU maintain a TLB (env->tlb_table) which stores GVA > -> > HVA mapping, it is used to speedup the addres

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-19 Thread Michael.Kang
On Tue, Jun 19, 2012 at 4:26 AM, Lluís Vilanova wrote: > Blue Swirl writes: > >> On Mon, Jun 18, 2012 at 8:28 AM, 陳韋任 (Wei-Ren Chen) >> wrote:   The reason why we want to do the measuring is we want to use KVM (sounds crazy idea) MMU virtualization to speedup the guest -> host mem

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Andreas Färber
Am 19.06.2012 13:54, schrieb 陳韋任 (Wei-Ren Chen): >> If you only have one CPU then using first_cpu->some_field1 should be >> almost as easy. :) > > I am afraid first_cpu (CPUArchState) is got poisoned, too. :/ > Even I comment out CPUArchState from poison.h, > > --- vl.c > extern CPUArchState *f

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2012-06-19 Thread Serge Hallyn
** Changed in: linux (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/712416 Title: kvm_intel kernel module crash with via nano vmx Status in QEMU: New Sta

Re: [Qemu-devel] [PATCHv3] Add PIIX4 properties to control PM system states.

2012-06-19 Thread Igor Mammedov
On 06/04/2012 01:31 PM, Gleb Natapov wrote: This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it allows S3/S4 states to be disabled from QEMU command line. Some guests

Re: [Qemu-devel] [PATCH 03/39] block: implement is_allocated for raw

2012-06-19 Thread Alexander Graf
On 15.06.2012, at 15:33, Kevin Wolf wrote: > From: Paolo Bonzini > > Either FIEMAP, or SEEK_DATA+SEEK_HOLE can be used to implement the > is_allocated callback for raw files. On Linux ext4, btrfs and XFS > all support it. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PATCHv3] Add PIIX4 properties to control PM system states.

2012-06-19 Thread Gleb Natapov
On Tue, Jun 19, 2012 at 02:30:12PM +0200, Igor Mammedov wrote: > On 06/04/2012 01:31 PM, Gleb Natapov wrote: > >This patch adds two things. First it allows QEMU to distinguish between > >regular powerdown and S4 powerdown. Later separate QMP notification will > >be added for S4 powerdown. Second it

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2012-06-19 Thread khetzal
It's impossible to run any command because the system is frozen -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/712416 Title: kvm_intel kernel module crash with via nano vmx Status in QEMU: New St

Re: [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically

2012-06-19 Thread Alexander Graf
On 07.06.2012, at 23:09, Blue Swirl wrote: > On Tue, Jun 5, 2012 at 11:52 PM, Alexander Graf wrote: >> Today we have two separate places where we keep information which device >> is where: >> >> - hw/ppce500_mpc8544ds.c to instantiate all devices >> - pc-bios/mpc8544ds.dtb as device tree to t

Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given

2012-06-19 Thread Peter Maydell
On 18 June 2012 02:35, Peter A. G. Crosthwaite wrote: > If the user boots with a -dtb assume the Linux boot flow, even when handling > an > elf. We don't do this for -initrd, why should we do it for -dtb ? -- PMM

Re: [Qemu-devel] [PATCH v2 2/2] arm_boot: Conditionalised DTB command line update

2012-06-19 Thread Peter Maydell
On 18 June 2012 02:35, Peter A. G. Crosthwaite wrote: > The DTB command line should only be overwritten if the user provides a command > line with -apend. Otherwise whatever command line was in the DTB should stay > unchanged. > > Signed-off-by: Peter A. G. Crosthwaite > --- > changed since v1: >

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-19 Thread Luiz Capitulino
On Mon, 18 Jun 2012 13:31:52 -0500 Anthony Liguori wrote: > >> Are any users of QMP actually asking for this kind of advanced > >> error reporting ? From libvirt's POV we're perfectly content > >> with just an error class& string. > > > > Real users, please, not theoretical ones. > > Irrespect

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-19 Thread Andreas Färber
Am 19.06.2012 14:09, schrieb Peter Crosthwaite: > Andreas, will an attribute((destructor)) work ? Cos if it does you can > put your printf pretty much anwhere rather than vl.c Yes, it might. main() only seems to call cpus.c:pause_all_vcpus(), so neither first_cpu nor the CPU(Arch)State would get c

Re: [Qemu-devel] [PATCH] Add missing check for host_from_stream_offset return value for RAM_SAVE_FLAG_PAGE

2012-06-19 Thread Juan Quintela
Orit Wasserman wrote: > Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela

[Qemu-devel] [PATCH 16/16] arm_boot: Conditionalised DTB command line update

2012-06-19 Thread Peter Maydell
From: Peter A. G. Crosthwaite The DTB command line should only be overwritten if the user provides a command line with -append. Otherwise whatever command line was in the DTB should stay unchanged. Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: Peter Maydell --- hw/arm_boot.c | 10 ++

[Qemu-devel] [Bug 712416] Missing required logs.

2012-06-19 Thread Brad Figg
This bug is missing log files that will aid in diagnosing the problem. >From a terminal window please run: apport-collect 712416 and then change the status of the bug to 'Confirmed'. If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment

Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers

2012-06-19 Thread Gerd Hoffmann
Hi, > Note that usb_packet_map() invokes dma_memory_map() with a NULL invalidate > callback function. When IOMMU support is added, this will mean that > usb_packet_map() and the corresponding usb_packet_unmap() must be called in > close proximity without dropping the qemu device lock Well, tha

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. > > Anthony suggested for last week: > - multithreading vhost (and general vhost improvements) > > I suggest: > - status of migration: post-copy, IDL, XBRLE, huge memory, ... > Will send an email with a

[Qemu-devel] [PATCH 14/16] cadence_gem: avoid stack-writing buffer-overrun

2012-06-19 Thread Peter Maydell
From: Jim Meyering Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number of bytes to clear. The latter would always clear 4 or 8 bytes, possibly writing beyond the end of that stack buffer. Alternatively, depending on the value of the "size" parameter, it could fail to initialize the end

[Qemu-devel] [PATCH 07/16] hw/arm_gic: Add qdev property for GIC revision

2012-06-19 Thread Peter Maydell
GIC behaviour can be different between revision 1 and 2 of the architectural GIC specification; we also have to handle the legacy 11MPCore GIC, which is different again in some places. Introduce a qdev property so we can behave appropriately. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |

[Qemu-devel] [PATCH 01/16] ARM: Exynos4210 IRQ: Introduce new IRQ gate functionality.

2012-06-19 Thread Peter Maydell
From: Evgeny Voevodin New IRQ gate consists of n_in input qdev gpio lines and one output sysbus IRQ line. The output IRQ level is formed as OR between all gpio inputs. Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- hw/exynos4210.c | 32 +++-- hw/exynos42

[Qemu-devel] [PATCH 06/16] hw/armv7m_nvic: Use MemoryRegions for NVIC specific registers

2012-06-19 Thread Peter Maydell
Implement the NVIC specific register areas using a set of overlaid MemoryRegions in a container, rather than by having the arm_gic read/write functions use special purpose callbacks. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 33 --- hw/armv7m_nvic.c | 74 +++

[Qemu-devel] [PATCH 05/16] hw/arm_gic: Move NVIC specific reset to armv7m_nvic_reset

2012-06-19 Thread Peter Maydell
Move the NVIC specific bits of reset to the NVIC's own reset function, rather than using ifdefs in the common arm_gic reset. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 10 -- hw/armv7m_nvic.c |7 +++ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/ar

[Qemu-devel] [PATCH 11/16] hw/armv7m_nvic: Make the NVIC a freestanding class

2012-06-19 Thread Peter Maydell
Rearrange the GIC and NVIC so both are straightforward subclasses of a common class, rather than having the NVIC source file textually include arm_gic.c. Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |2 +- hw/arm_gic.c | 241 +++

Re: [Qemu-devel] Cant Upload tests to Wiki

2012-06-19 Thread Anthony Liguori
On 06/19/2012 01:18 AM, Peter Crosthwaite wrote: Hi, I'm trying to upload my little endian Microblaze test vector to the wiki, but the file upload restrictions are for images only and file size< 2MB. Can we relax these so I can upload my test vectors? Not really. There are two issues: 1) mak

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-19 Thread Corey Bryant
On 06/18/2012 04:10 AM, Kevin Wolf wrote: Am 15.06.2012 22:00, schrieb Eric Blake: On 06/15/2012 01:19 PM, Corey Bryant wrote: There are some flags that I don't think we'll be able to change. For example: O_RDONLY, O_WRONLY, O_RDWR. I assume libvirt would open all files O_RDWR. I think w

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Anthony Liguori
On 06/19/2012 08:54 AM, Juan Quintela wrote: Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. Anthony suggested for last week: - multithreading vhost (and general vhost improvements) I suggest: - status of migration: post-copy, IDL, XBRLE, huge memory,

Re: [Qemu-devel] [PATCH 05/31] dt: add helper for phandle enumeration

2012-06-19 Thread Alexander Graf
On 09.06.2012, at 03:02, Peter Crosthwaite wrote: > On Fri, Jun 8, 2012 at 10:46 PM, Alexander Graf wrote: >> >> On 07.06.2012, at 02:28, Peter Crosthwaite wrote: >> >>> On Thu, Jun 7, 2012 at 1:58 AM, Alexander Graf wrote: On 06/06/2012 07:11 AM, Peter Crosthwaite wrote: > > On

[Qemu-devel] [PATCH 15/16] cadence_ttc: changed master clock frequency

2012-06-19 Thread Peter Maydell
From: Peter A. G. Crosthwaite Change the timer clock frequency to 133MHz which is correct. the old 2.5MHz value was for the pre-silicon emulation platform. Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: Peter Maydell --- hw/cadence_ttc.c |2 +- 1 files changed, 1 insertions(+), 1 d

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Alexander Graf
On 09.06.2012, at 13:34, Benjamin Herrenschmidt wrote: > On Sat, 2012-06-09 at 20:53 +1000, Benjamin Herrenschmidt wrote: >> Hi folks ! > > (After some discussion with Andreas ...) > >> I'm looking at sorting out the state save/restore of target-ppc (which >> means understanding in general how

[Qemu-devel] [PULL 00/16] arm-devs queue

2012-06-19 Thread Peter Maydell
Hi; this is an arm-devs pullreq which mostly has patches which I've had queued since before freeze and my holiday. (I had to make a trivial fix to one of the GIC patches to account for the list of object files moving from Makefile.target to hw/arm/Makefile.objs but otherwise an unproblematic rebase

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Takuya Yoshikawa
On Tue, 19 Jun 2012 09:01:36 -0500 Anthony Liguori wrote: > I'm not at all convinced that postcopy is a good idea. There needs a clear > expression of what the value proposition is that's backed by benchmarks. > Those > benchmarks need to include latency measurements of downtime which so far

[Qemu-devel] [PATCH 09/16] hw/arm_gic.c: Make NVIC interrupt numbering a runtime setting

2012-06-19 Thread Peter Maydell
Make the minor tweaks to interrupt numbering used by the NVIC a runtime setting rather than a compile time one, so we can drop more NVIC ifdefs. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm

[Qemu-devel] [PATCH 03/16] hw/arm_gic: Remove NVIC ifdefs from gic_state struct

2012-06-19 Thread Peter Maydell
Remove some NVIC ifdefs from the gic_state struct and its state save/load functions. This means there are some fields in it which are present for the NVIC but not used, but means it always has the same layout and can be pulled out into a common subclass. Note that the addition of irq_target[] to t

[Qemu-devel] [PATCH 12/16] hw/omap.h: Drop broken MEM_VERBOSE tracing

2012-06-19 Thread Peter Maydell
Remove the MEM_VERBOSE tracing option from omap.h. This worked by intercepting cpu_register_io_memory() calls; it has been broken since cpu_register_io_memory() was removed in favour of the MemoryRegion API. Signed-off-by: Peter Maydell --- hw/omap.h | 95 --

[Qemu-devel] [PATCH 02/16] arm_boot: Fix typos in comment

2012-06-19 Thread Peter Maydell
From: Andreas Färber mimicing -> mimicking thei -> the Signed-off-by: Andreas Färber Reviewed-by: Stefan Weil Signed-off-by: Peter Maydell --- hw/arm-misc.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm-misc.h b/hw/arm-misc.h index 1d51570..1f96229 100644

[Qemu-devel] [PATCH] Makefile.hw: avoid overly large 'make clean' rm command

2012-06-19 Thread Peter Maydell
Avoid 'make clean' producing an 'rm' command which has a lot of duplicate 'hw//*.o' arguments, by using $(sort $(dir ..)) rather than $(dir $(sort ..)) so Make's sort function will remove the duplicates for us. We can also remove the double '//' safely because $(dir ..) is guaranteed to return a st

[Qemu-devel] [PATCH 04/16] hw/arm_gic: Remove the special casing of NCPU for the NVIC

2012-06-19 Thread Peter Maydell
Drop the special casing of NCPU=1 for the NVIC. This slightly increases the amount of memory used by its state structure, but removes some ifdeffery and means we can safely move the GIC state into a common subclass structure. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 23 +++--

[Qemu-devel] [PATCH 08/16] hw/arm_gic: Make CPU target registers RAZ/WI on uniprocessor

2012-06-19 Thread Peter Maydell
The GIC spec says that the CPU target registers should RAZ/WI for uniprocessor implementations. Implement this, which also conveniently lets us drop an NVIC ifdef. Annoyingly, the 11MPCore's GIC is the odd one out, since it always has these registers, even in uniprocessor configs. Signed-off-by:

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Juan Quintela
Alexander Graf wrote: > On 09.06.2012, at 13:34, Benjamin Herrenschmidt wrote: > >> On Sat, 2012-06-09 at 20:53 +1000, Benjamin Herrenschmidt wrote: >>> Hi folks ! >> >> (After some discussion with Andreas ...) >> >>> I'm looking at sorting out the state save/restore of target-ppc (which >>> mea

[Qemu-devel] [PATCH 10/16] hw/arm_gic: Move CPU interface memory region setup into arm_gic_init

2012-06-19 Thread Peter Maydell
Remove more NVIC ifdefs by moving the code to setup the CPU interface memory regions into the GIC specific arm_gic_init() function rather than the gic_init() function. Rename the latter to more closely reflect what it's now actually doing. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 26

[Qemu-devel] [PATCH 13/16] hw/a9mpcore: Fix compilation failure if physaddrs are 64 bit

2012-06-19 Thread Peter Maydell
Add a cast to a logging printf to avoid a compilation failure if target_phys_addr_t is a 64 bit type. (This is better than using TARGET_FMT_plx because we really don't need a full 16 digit hex string to print the offset into a device.) Signed-off-by: Peter Maydell Reviewed-by: Eric Blake --- hw

Re: [Qemu-devel] [PATCH] hw/cadence_gem: Make rx_desc_addr and tx_desc_addr uint32_t

2012-06-19 Thread Peter Maydell
Peter C: ping? I was hoping for a review or ack for this one before I stick it into an arm-devs pullreq. thanks -- PMM On 22 May 2012 18:02, Peter Maydell wrote: > Make the state fields rx_desc_addr and tx_desc_addr uint32_t; > this matches the VMStateDescription, and also conforms to how > hard

Re: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/'

2012-06-19 Thread Peter Maydell
Ping? (patch still applies cleanly to current master; patchwork URL http://patchwork.ozlabs.org/patch/161324/ ) -- PMM On 25 May 2012 13:07, Peter Maydell wrote: > Make qemu_find_file() check for the passed in name as a straight > pathname even if it doesn't have any path separator character in

Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory

2012-06-19 Thread Peter Maydell
On 14 June 2012 16:14, Andreas Färber wrote: > Commit ec5b06d (configure: ensure directory exists when creating symlinks) > moved the creation of directories into the symlink() function but forgot > the case where no symlink is created. > > This leads to build errors on arm Linux due to -I../linux

Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory

2012-06-19 Thread Andreas Färber
Am 19.06.2012 17:18, schrieb Peter Maydell: > On 14 June 2012 16:14, Andreas Färber wrote: >> Commit ec5b06d (configure: ensure directory exists when creating symlinks) >> moved the creation of directories into the symlink() function but forgot >> the case where no symlink is created. >> >> This l

[Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure

2012-06-19 Thread Orit Wasserman
From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- block-migration.c |8 migration.c | 13 - migration.h |8 ++-- qemu-common.h |1 + savevm.c | 13 + sysemu.h |3 ++- vmstate.h |2 +- 7 f

[Qemu-devel] [PATCH v12 03/13] Add XBZRLE documentation

2012-06-19 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 115 +++ 1 files changed, 115 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..62db494 ---

[Qemu-devel] [PATCH v12 02/13] Add migration capabilites

2012-06-19 Thread Orit Wasserman
Add migration capabiltes that can be queried by the management. The managment can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). The managment can enable a capabilty for the next migration by using migrate_set_param

[Qemu-devel] [PATCH v12 00/13] XBZRLE delta for live migration of large memory app

2012-06-19 Thread Orit Wasserman
Changes from v11: - divide patch 7 to several smaller patches. - Use an array for setting migration parameters QMP only (there is not support for arrays in HMP commands). parameters can be enabled or disabled. - Do not use XBZRLE in stage 3 , it is a ver

  1   2   3   >