Re: [Qemu-devel] [PATCH] ahci: add -drive support

2012-06-14 Thread Markus Armbruster
Alexander Graf writes: > We've had support for creating AHCI devices using -device for a while now, > but it's cumbersome to users. We really should provide an easier way for > them to leverage the power of AHCI! > > So let's introduce a new if= option to -drive, bumping it en par with virtio. I

[Qemu-devel] [PATCH] qapi: converted commit

2012-06-14 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- blockdev.c |9 - blockdev.h |1 - hmp-commands.hx |2 +- hmp.c|9 + hmp.h|1 + qapi-schema.json | 15 +++ qmp-commands.hx | 24 7 files changed, 54 i

Re: [Qemu-devel] [PATCH] ahci: add -drive support

2012-06-14 Thread Alexander Graf
On 14.06.2012, at 09:29, Markus Armbruster wrote: > Alexander Graf writes: > >> We've had support for creating AHCI devices using -device for a while now, >> but it's cumbersome to users. We really should provide an easier way for >> them to leverage the power of AHCI! >> >> So let's introduce

Re: [Qemu-devel] [PATCH] ahci: add -drive support

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 09:34, schrieb Alexander Graf: > > On 14.06.2012, at 09:29, Markus Armbruster wrote: > >> Alexander Graf writes: >> >>> We've had support for creating AHCI devices using -device for a while now, >>> but it's cumbersome to users. We really should provide an easier way for >>> them t

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 10:51:56PM -0600, Alex Williamson wrote: > Finally, complete the fully specified interface. msix_add_config() > gets moved to be closer to the setup functions where it's actually > used. msix_mmio_setup() gets folded into msix_init(). And > msix_uninit() gets reworked a b

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 08:17:22AM +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > Finally, complete the fully specified interface. msix_add_config() > > gets moved to be closer to the setup functions where it's actually > > used. msix_mmio_setup() gets folded into msix

Re: [Qemu-devel] [PATCH v2 6/6] msix: Fix last PCIDevice naming inconsitency

2012-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 10:52:06PM -0600, Alex Williamson wrote: > The previous patches fixed almost all the inconsistent names used > for PCIDevice in msix.c, fix the one remaining transgression. > > Signed-off-by: Alex Williamson Except, would be better to first rename parameters and do other

[Qemu-devel] Does kvm_fd mean KVM or VCPU fd?

2012-06-14 Thread Wei-Ren Chen
Hi all, While reading KVM releated code in QEMU, I found the name of one field in CPU_COMMON (cpu-defs.h), i.e. kvm_fd, might be misleading. See the code below, --- int kvm_init_vcpu(CPUArchState *env) { ret = kvm_vm_ioctl(s, KVM_CREATE_VCPU, env->cpu_index); env->kvm_fd = ret; /* VCPU

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Stefan Hajnoczi
On Wed, Jun 13, 2012 at 11:13 AM, mengcong wrote: >                    seq-read        seq-write       rand-read     rand-write >                    8k     256k     8k     256k     8k   256k     8k   256k > > bare-metal  

Re: [Qemu-devel] [PATCH] ahci: add -drive support

2012-06-14 Thread Markus Armbruster
Alexander Graf writes: > On 14.06.2012, at 09:29, Markus Armbruster wrote: > >> Alexander Graf writes: >> >>> We've had support for creating AHCI devices using -device for a while now, >>> but it's cumbersome to users. We really should provide an easier way for >>> them to leverage the power of

Re: [Qemu-devel] [PATCH 0/3] qom: refactor Interfaces

2012-06-14 Thread Paolo Bonzini
Il 13/06/2012 22:54, Anthony Liguori ha scritto: > The interface implementation was pretty busted. The way it created Objects > for > each interface was extremely clumbsy and brittle. > > This is a new implementation that does something quite a bit more natural. It > simply modifies classes suc

Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd?

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 10:24, 陳韋任 (Wei-Ren Chen) ha scritto: > Hi all, > > While reading KVM releated code in QEMU, I found the name of one > field in CPU_COMMON (cpu-defs.h), i.e. kvm_fd, might be misleading. > See the code below, > > --- > int kvm_init_vcpu(CPUArchState *env) > { > ret = kvm_vm_io

Re: [Qemu-devel] Broken Microblaze timer

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 04:29, Peter Crosthwaite ha scritto: > Obviously this sucks as a patch, but without this hack, the system > freezes on boot. I managed to ascertain that its coming from the > ptimer used by the system timer (hw/xilinx_timer.c). The CPU is either > halted and never resumes, or the time

Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: Test COW from backing file

2012-06-14 Thread Paolo Bonzini
Il 13/06/2012 17:34, Kevin Wolf ha scritto: > Thanks to Paolo who caught a bug that qemu-iotest would have let passed (well, > almost, the zero cluster test case did accidentally catch it). I was surprised > to find that there's no specific test for COW from backing files. Fixing this > now... > >

Re: [Qemu-devel] [PATCH] block: Prevent /dev/fd/X filename from being detected as floppy

2012-06-14 Thread Paolo Bonzini
Il 13/06/2012 16:30, root ha scritto: > From: Corey Bryant > > Reported-by: Kevin Wolf > Signed-off-by: Corey Bryant > --- > block/raw-posix.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index d8eff2f..68886cd 100644 >

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Cong Meng
On Thu, 2012-06-14 at 09:30 +0100, Stefan Hajnoczi wrote: > On Wed, Jun 13, 2012 at 11:13 AM, mengcong wrote: > >seq-readseq-write rand-read rand-write > >8k 256k 8k 256k 8k 256k 8k 256k > > -

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Cong Meng
On Wed, 2012-06-13 at 12:08 -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-06-13 at 18:13 +0800, mengcong wrote: > > Hi folks, I did an IO performance test on the tcm-vhost scsi. I want to > > share > > the test result data here. > > > > > > seq-readseq-write

[Qemu-devel] Compiling static

2012-06-14 Thread Davide Ferraretto
I want compile qemu with --static: ./configure --static --target-list=i386-linux-user,arm-linux-user --python=/usr/bin/python2.7 --prefix=/install_qemu Qemu returns: /usr/bin/ld: cannot find -lssl3 /usr/bin/ld: cannot find -lsmime3 /usr/bin/ld: cannot find -lnss3 /usr/bin/ld: cannot find -lnssu

[Qemu-devel] Compiling static

2012-06-14 Thread Davide Ferraretto
I want compile qemu with --static: ./configure --static --target-list=i386-linux-user,arm-linux-user --python=/usr/bin/python2.7 --prefix=/install_qemu Qemu returns: /usr/bin/ld: cannot find -lssl3 /usr/bin/ld: cannot find -lsmime3 /usr/bin/ld: cannot find -lnss3 /usr/bin/ld: cannot find -ln

Re: [Qemu-devel] [PATCH v1 3/4] vl.c: allow for repeated -sd arguments

2012-06-14 Thread Igor Mitsyanko
On 06/14/2012 06:20 AM, Peter A. G. Crosthwaite wrote: Allows for repeating of -sd arugments in the same way as -pflash and -mtdblock. Signed-off-by: Peter A. G. Crosthwaite --- changed from v3: fixed commit msg typo vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --gi

Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd?

2012-06-14 Thread Wei-Ren Chen
> > I think KVM_CREATE_VCPU should return VCPU fd, right? AFAIK, in KVM > > world, kvm_fd usually means the fd we get after opening "/dev/kvm". > > Just want to make sure I understand the code correcly. Thanks. > > This is the kvm_fd inside struct CPUState, so it's per-CPU. Okay, then it's VC

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-14 Thread Amos Kong
On 12/06/12 01:25, Luiz Capitulino wrote: Hi Luiz, Anthony BTW, why is there a 16 keycode limit? 'Sendkey' command was added by this commit a3a91a355bc6107b7d06d722fb97d2b80065ee0b Limitation of keycodes number (16) was also introduced here, and I didn't find the root reason. That's

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > These don't have to be contiguous. Size them to only what > they need and use separate MemoryRegions for the vector > table and PBA. > > Signed-off-by: Alex Williamson Why is this still using NATIVE? > --- > > hw/msix.c | 11

Re: [Qemu-devel] [PATCH v2 1/6] msix: Add simple BAR allocation MSIX setup functions

2012-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 10:51:19PM -0600, Alex Williamson wrote: > msi_init() takes over a BAR without really specifying or allowing > specification of how it does so. Instead, let's split it into > two interfaces, one fully specified, and one trivially easy. This > implements the latter. msix_i

Re: [Qemu-devel] Compiling static

2012-06-14 Thread Dunrong Huang
2012/6/14 Davide Ferraretto : > I want compile qemu with --static: > ./configure --static --target-list=i386-linux-user,arm-linux-user > --python=/usr/bin/python2.7 --prefix=/install_qemu > > Qemu returns: > /usr/bin/ld: cannot find -lssl3 > /usr/bin/ld: cannot find -lsmime3 > /usr/bin/ld: cannot f

[Qemu-devel] [PATCH] qcow2: fix autoclear image header update

2012-06-14 Thread Stefan Hajnoczi
The autoclear feature bits can be used for qcow2 file format features that are safe to "drop" by old programs that do not understand the feature. Upon opening the image file unknown autoclear feature bits are cleared and the image file header is rewritten, but this was happening too early in the c

Re: [Qemu-devel] [PATCH 1/6 v10] docs: spec for add-cow file format

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 05:06, schrieb Dong Xu Wang: > On Wed, Jun 13, 2012 at 11:10 PM, Eric Blake wrote: >> On 06/13/2012 08:36 AM, Dong Xu Wang wrote: >>> Introduce a new file format:add-cow. The usage can be found at this patch. >>> >>> Signed-off-by: Dong Xu Wang >>> --- >>> docs/specs/add-cow.txt |

Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert

2012-06-14 Thread Kevin Wolf
Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow file can't live alone, must together will image_file and backing_file. > If we implement qemu-img convert operation for add-cow file format, we must > create image_file and backing_file manually, that will be confused for users, > so we just igno

Re: [Qemu-devel] [PATCH 1/7] Add spent time for migration

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > We add time spent for migration to the output of "info migrate" > command. 'total_time' means time since the start fo migration if > migration is 'active', and total time of migration if migration is > completed. As we are also interested in transfer

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-06-14 Thread Kevin Wolf
Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow will let raw file support snapshot_blkdev indirectly. > > Signed-off-by: Dong Xu Wang Paolo, what do you think about this magic? I think I can see its use especially for HMP because it's quite convenient, but on the other hand it assumes a fi

Re: [Qemu-devel] [PATCH 2/7] Add tracepoints for savevm section start/end

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > This allows to know how long each section takes to save. > > An awk script like this tells us sections that takes more that 10ms > > $1 ~ /savevm_state_iterate_end/ { > /* Print savevm_section_end line when > 10ms duration */ > if ($2 > 1

Re: [Qemu-devel] [PATCH 3/7] No need to iterate if we already are over the limit

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > If buffers are full, don't iterate, just exit. > > Signed-off-by: Juan Quintela > --- > savevm.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 779bd22..6bc71b1 100644 > --- a/savevm.c >

Re: [Qemu-devel] [PATCH] qcow2: fix autoclear image header update

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 12:42, schrieb Stefan Hajnoczi: > The autoclear feature bits can be used for qcow2 file format features > that are safe to "drop" by old programs that do not understand the > feature. Upon opening the image file unknown autoclear feature bits are > cleared and the image file header i

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-06-14 Thread Paolo Bonzini
I just took a quick look at the flush code. Il 13/06/2012 16:36, Dong Xu Wang ha scritto: > > +bool add_cow_cache_set_writethrough(BlockDriverState *bs, AddCowCache *c, > +bool enable) > +{ > +bool old = c->writethrough; > + > +if (!old && enable) { > +add_cow_cache_flush(bs,

Re: [Qemu-devel] [PATCH 4/7] Only TCG needs TLB handling

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > Refactor the code that is only needed for tcg to an static function. > Call that only when tcg is enabled. We can't refactor to a dummy > function in the kvm case, as qemu can be compiled at the same time > with tcg and kvm. > > Signed-off-by: Juan Q

Re: [Qemu-devel] [PATCH] qcow2: fix autoclear image header update

2012-06-14 Thread Stefan Hajnoczi
On Thu, Jun 14, 2012 at 12:06 PM, Kevin Wolf wrote: > Am 14.06.2012 12:42, schrieb Stefan Hajnoczi: >> The autoclear feature bits can be used for qcow2 file format features >> that are safe to "drop" by old programs that do not understand the >> feature.  Upon opening the image file unknown autocl

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 12:59, Kevin Wolf ha scritto: > Am 13.06.2012 16:36, schrieb Dong Xu Wang: >> add-cow will let raw file support snapshot_blkdev indirectly. >> >> Signed-off-by: Dong Xu Wang > > Paolo, what do you think about this magic? Besides the obvious layering violation (it would be better to

Re: [Qemu-devel] [PATCH 5/7] Only calculate expected_time for stage 2

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > ram_save_remaining() is an expensive operation when there is a lot of memory. > So we only call the function when we need it. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 6/7] Exit loop if we have been there too long

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > cheking each 64 pages is a random magic number as good as any other. s/cheking/checking > We don't want to test too many times, but on the other hand, > qemu_get_clock_ns() is not so expensive either. We want to be sure > that we spent less than 50ms

Re: [Qemu-devel] [PATCH 7/7] Maintaing number of dirty pages

2012-06-14 Thread Orit Wasserman
On 05/22/2012 09:32 PM, Juan Quintela wrote: > Calculate the number of dirty pages takes a lot on hosts with lots > of memory. Just maintain how many pages are dirty. Only sync bitmaps > if number is small enough. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 15 +--

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 13:18, schrieb Paolo Bonzini: > Il 14/06/2012 12:59, Kevin Wolf ha scritto: >> Am 13.06.2012 16:36, schrieb Dong Xu Wang: >>> add-cow will let raw file support snapshot_blkdev indirectly. >>> >>> Signed-off-by: Dong Xu Wang >> >> Paolo, what do you think about this magic? > > Beside

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Stefan Hajnoczi
On Thu, Jun 14, 2012 at 05:45:22PM +0800, Cong Meng wrote: > On Thu, 2012-06-14 at 09:30 +0100, Stefan Hajnoczi wrote: > > On Wed, Jun 13, 2012 at 11:13 AM, mengcong wrote: > > >seq-readseq-write rand-read > > > rand-write > > >8k 256k

Re: [Qemu-devel] [PATCH v2] qapi: converted commit

2012-06-14 Thread Eric Blake
On 06/14/2012 01:35 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > +++ b/qapi-schema.json > @@ -1169,6 +1169,21 @@ > { 'command': 'block_resize', 'data': { 'device': 'str', 'size': 'int' }} > > ## > +# @commit > +# > +# Commit changes to the disk images (if -snapshot is used) o

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 14:07, Stefan Hajnoczi ha scritto: > Perfect, thanks. virtio-scsi userspace is much better than virtio-blk > here. That's unexpected since they both use the QEMU block layer. If > anything, I would have expected virtio-blk to be faster! Yes, I would have expected something similar

[Qemu-devel] [PATCH v2 0/3] qcow2: fix autoclear image header update

2012-06-14 Thread Stefan Hajnoczi
The code path to clear unknown autoclear feature bits when opening a qcow2 image file was broken. This series includes the fix along with the qemu-iotest to verify the issue and prevent regressions in the future. v2: * Add qemu-iotest [Kevin] Stefan Hajnoczi (3): qcow2: fix autoclear image he

[Qemu-devel] [PATCH v2 1/3] qcow2: fix autoclear image header update

2012-06-14 Thread Stefan Hajnoczi
The autoclear feature bits can be used for qcow2 file format features that are safe to "drop" by old programs that do not understand the feature. Upon opening the image file unknown autoclear feature bits are cleared and the image file header is rewritten, but this was happening too early in the c

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: add 036 autoclear feature bit test

2012-06-14 Thread Stefan Hajnoczi
This new test validates the autoclear feature bit behavior. When QEMU opens a qcow2v3 image file with an unknown autoclear feature bit the bit should be cleared in the image file header. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/036 | 68 +++

[Qemu-devel] [PATCH v2 2/3] qemu-iotests: add qcow2.py set-feature-bit command

2012-06-14 Thread Stefan Hajnoczi
This new command sets feature bits in the image file header: qcow2.py set-feature-bit incompatible|compatible|autoclear The bit number must be in the range [0, 64). Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/qcow2.py | 23 +++ 1 file changed, 23 insertions(+

Re: [Qemu-devel] [PATCH 1/3] tests: fix dependency inclusion

2012-06-14 Thread Andreas Färber
Am 13.06.2012 22:55, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- > Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 32550cb..93046bf 100644 > --- a/Makefile > +++ b/Makefile > @@ -406,4 +406,4 @@ Makefile: $(G

Re: [Qemu-devel] [PATCH 1/3] tests: fix dependency inclusion

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 15:08, Andreas Färber ha scritto: >> > # Include automatically generated dependency files >> > -include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d >> > qapi/*.d) >> > --include $(wildcard qga/*.d hw/*.d hw/usb/*.d) >> > +-include $(wildcard qga/*.d hw/*.d hw/usb/*.

Re: [Qemu-devel] [PATCH] trace: added ability to comment out events in the list

2012-06-14 Thread Stefan Hajnoczi
On Thu, Jun 14, 2012 at 02:41:40PM +1000, Alexey Kardashevskiy wrote: > It is convenient for debug to be able to switch on/off some events easily. > The only possibility now is to remove event name from the file completely > and type it again when we want it back. > > The patch adds '#' symbol han

Re: [Qemu-devel] wiki account

2012-06-14 Thread Stefan Hajnoczi
On Thu, Jun 14, 2012 at 3:31 AM, Peter Crosthwaite wrote: > I wish to upload my test images to the wiki, and I see the process for > getting an account is to contact via email. Can someone create me an > account? Done. I have emailed you the details. For anyone else with an existing wiki accoun

Re: [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-14 Thread Luiz Capitulino
On Wed, 13 Jun 2012 18:07:43 -0400 Corey Bryant wrote: > > > On 06/13/2012 04:47 PM, Eric Blake wrote: > > On 06/13/2012 02:25 PM, Corey Bryant wrote: > > > >>> Also, getfd automatically closes a fd if an existing fdname is passed > >>> again. > >>> I don't think this is a good behavior, I thin

[Qemu-devel] [PATCH v5 1/3] monitor: remove unused do_info_trace

2012-06-14 Thread Harsh Prateek Bora
Going forward with simpletrace v2 variable size trace records, we cannot have a generic function to print trace event info and therefore this interface becomes invalid. As per Stefan Hajnoczi: "This command is only available from the human monitor. It's not very useful because it historically ha

[Qemu-devel] [PATCH v5 3/3] Update simpletrace.py for new log format

2012-06-14 Thread Harsh Prateek Bora
Support new tracelog format for multiple arguments and strings. Signed-off-by: Harsh Prateek Bora --- scripts/simpletrace.py | 116 +++- 1 file changed, 75 insertions(+), 41 deletions(-) diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py in

[Qemu-devel] [PATCH v5 0/3] Simpletrace v2: Support multiple args, strings.

2012-06-14 Thread Harsh Prateek Bora
Existing simpletrace backend allows to trace at max 6 args and does not support strings. This newer tracelog format gets rid of fixed size records and therefore allows to trace variable number of args including strings. Sample trace: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000 version=9P200

[Qemu-devel] [PATCH v5 2/3] Simpletrace v2: Support multiple arguments, strings.

2012-06-14 Thread Harsh Prateek Bora
Existing simpletrace backend allows to trace at max 6 args and does not support strings. This newer tracelog format gets rid of fixed size records and therefore allows to trace variable number of args including strings. Sample trace with strings: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000

Re: [Qemu-devel] Compiling static

2012-06-14 Thread Andreas Färber
Am 14.06.2012 12:03, schrieb Davide Ferraretto: > I want compile qemu with --static: > ./configure --static --target-list=i386-linux-user,arm-linux-user > --python=/usr/bin/python2.7 --prefix=/install_qemu > > Qemu returns: > /usr/bin/ld: cannot find -lssl3 > /usr/bin/ld: cannot find -lsmime3 > /u

Re: [Qemu-devel] [PATCH] block: Prevent /dev/fd/X filename from being detected as floppy

2012-06-14 Thread Corey Bryant
On 06/14/2012 05:24 AM, Paolo Bonzini wrote: Il 13/06/2012 16:30, root ha scritto: From: Corey Bryant Reported-by: Kevin Wolf Signed-off-by: Corey Bryant --- block/raw-posix.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/raw-posix.c b/block/raw-posix.c

Re: [Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size

2012-06-14 Thread Alon Levy
On Tue, Jun 12, 2012 at 09:51:12AM +0200, Gerd Hoffmann wrote: > From: Alon Levy > Please don't push this, it breaks both drivers, leaving n_modes 0 in the rom. I'll send a fixed version. > In preperation for supporting a larger framebuffer for multiple monitors > on a single card, add a proper

[Qemu-devel] libguestfs now uses virtio-scsi, supports large numbers of disks

2012-06-14 Thread Richard W.M. Jones
I switched libguestfs over to using virtio-scsi. One immediate benefit is support for large numbers of disks: up to 255 because we're using 1 target / disk and we reserve one disk for the appliance, in theory more could be supported if we used LUNs. This email just contains some notes that may be

[Qemu-devel] [PATCH] qxl: fix broken n_modes

2012-06-14 Thread Alon Levy
Signed-off-by: Alon Levy --- Hi Gerd, Unfortunately I didn't test my previous patch "qxl: add vgamem_size_mb and vgamem_size" with the current drivers. This patch is not merged since I didn't know if it will reach before/after anothony pull. If before, then please merge it into the bad patch.

Re: [Qemu-devel] [PATCH] block: Prevent /dev/fd/X filename from being detected as floppy

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 15:39, schrieb Corey Bryant: > > > On 06/14/2012 05:24 AM, Paolo Bonzini wrote: >> Il 13/06/2012 16:30, root ha scritto: >>> From: Corey Bryant >>> >>> Reported-by: Kevin Wolf >>> Signed-off-by: Corey Bryant >>> --- >>> block/raw-posix.c |4 +++- >>> 1 file changed, 3 inse

Re: [Qemu-devel] [PATCH v5 2/3] Simpletrace v2: Support multiple arguments, strings.

2012-06-14 Thread Harsh Bora
Hi Stefan, Please see comment below: On 06/14/2012 07:02 PM, Harsh Prateek Bora wrote: [...] -static bool get_trace_record(unsigned int idx, TraceRecord *record) +static bool get_trace_record(unsigned int idx, TraceRecord **recordptr) { -if (!(trace_buf[idx].event& TRACE_RECORD_VALID))

Re: [Qemu-devel] [PATCH v2 2/6] ivshmem: Convert to msix_init_exclusive_bar() interface

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 08:01 +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > Trivial conversion, failed to have an uninit before and after. > > Need not be in this series, but we should fix that trivial bug nevertheless. Given the exit(1) on failure to setup msix, I'm gu

[Qemu-devel] [PATCH 3/5] scsi: Add basic support for SCSI media changer commands.

2012-06-14 Thread Christian Borntraeger
From: Christian Hoff This adds basic support for SCSI media changer commands. Not all commands are supported as of now, but enough to cover basic functionality. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger --- hw/scsi-bus.c | 59 +++

[Qemu-devel] [PATCH 4/5] scsi: Fix transfer length for READ POSITION commands.

2012-06-14 Thread Christian Borntraeger
From: Christian Hoff The transfer length depends on the specific service action code, as defined in the SCSI stream commands spec section 7.7. Up to now only the extended form was supported. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger --- hw/scsi-bus.c | 16 +

[Qemu-devel] [PATCH 1/5] scsi: Fix data length == SCSI_SENSE_BUF_SIZE

2012-06-14 Thread Christian Borntraeger
From: Christian Hoff Fix the edge case where the sense data length is exactly the same as SCSI_SENSE_BUF_SIZE. This makes SCSI requests work that use all of the available 95 byte sense data. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger --- hw/scsi-bus.c |2 +- 1 file

[Qemu-devel] [PATCH 2/5] scsi: Fix LOAD_UNLOAD

2012-06-14 Thread Christian Borntraeger
From: Christian Hoff Change operation code of LOAD_UNLOAD command to 0x1b as described in section 7.3 of the SCSI Stream Commands spec. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger --- hw/scsi-bus.c |6 +++--- hw/scsi-defs.h |2 +- 2 files changed, 4 insertions(

Re: [Qemu-devel] [PATCH 0/5] scsi related fixes

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 15:55, Christian Borntraeger ha scritto: > Paolo, > > this patch series was created during bringup of virtio-scsi on s390x. > We used a tape library as a test vehicle. Awesome! > so here is the set of patches that allowed us to use it via virtio-scsi. > Any comments? Ok to apply?

Re: [Qemu-devel] [PATCH] block: Prevent /dev/fd/X filename from being detected as floppy

2012-06-14 Thread Corey Bryant
On 06/14/2012 09:51 AM, Kevin Wolf wrote: Am 14.06.2012 15:39, schrieb Corey Bryant: On 06/14/2012 05:24 AM, Paolo Bonzini wrote: Il 13/06/2012 16:30, root ha scritto: From: Corey Bryant Reported-by: Kevin Wolf Signed-off-by: Corey Bryant --- block/raw-posix.c |4 +++- 1 file

Re: [Qemu-devel] [PATCH v5 3/4] fdc: rewrite seek and DSKCHG bit handling

2012-06-14 Thread Kevin Wolf
Am 13.06.2012 15:43, schrieb Pavel Hrdina: > This bit is cleared on every successful seek to a different track (cylinder). > The seek is also called on revalidate or on read/write/format commands which > also clear the DSKCHG bit. > > Signed-off-by: Pavel Hrdina > --- > hw/fdc.c | 68 > ++

Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert

2012-06-14 Thread Dong Xu Wang
On Thu, Jun 14, 2012 at 6:51 PM, Kevin Wolf wrote: > Am 13.06.2012 16:36, schrieb Dong Xu Wang: >> add-cow file can't live alone, must together will image_file and >> backing_file. >> If we implement qemu-img convert operation for add-cow file format, we must >> create image_file and backing_file

Re: [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling

2012-06-14 Thread Kevin Wolf
Am 13.06.2012 15:43, schrieb Pavel Hrdina: > The fd_seek will return 'track is invalid' if there is no media in drive. > > Implied seek should have the same behavior as normal seek. We will use the > fd_seek > function instead of a direct modification of head, track and sector values. > The resul

Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 16:06, schrieb Dong Xu Wang: > On Thu, Jun 14, 2012 at 6:51 PM, Kevin Wolf wrote: >> Am 13.06.2012 16:36, schrieb Dong Xu Wang: >>> add-cow file can't live alone, must together will image_file and >>> backing_file. >>> If we implement qemu-img convert operation for add-cow file form

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 08:17 +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > > -/* Initialize the MSI-X structures. Note: if MSI-X is supported, BAR size > > is > > - * modified, it should be retrieved with msix_bar_size. */ > > +/* Add MSI-X capability to the config s

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 11:10 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 10:51:56PM -0600, Alex Williamson wrote: > > Finally, complete the fully specified interface. msix_add_config() > > gets moved to be closer to the setup functions where it's actually > > used. msix_mmio_setup()

[Qemu-devel] [PATCH 5/5] scsi: Ensure command and transfer lengths are set for all SCSI stream commands.

2012-06-14 Thread Christian Borntraeger
From: Christian Hoff scsi-generic relies on those values to be correct, so it is important that those values are initialized properly prior to submitting the SCSI command. Signed-off-by: Christian Hoff Signed-off-by: Christian Borntraeger --- hw/scsi-bus.c |8 1 files changed, 8

Re: [Qemu-devel] [PATCH v2 6/6] msix: Fix last PCIDevice naming inconsitency

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 11:13 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 10:52:06PM -0600, Alex Williamson wrote: > > The previous patches fixed almost all the inconsistent names used > > for PCIDevice in msix.c, fix the one remaining transgression. > > > > Signed-off-by: Alex Willia

Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert

2012-06-14 Thread Dong Xu Wang
On Thu, Jun 14, 2012 at 10:11 PM, Kevin Wolf wrote: > Am 14.06.2012 16:06, schrieb Dong Xu Wang: >> On Thu, Jun 14, 2012 at 6:51 PM, Kevin Wolf wrote: >>> Am 13.06.2012 16:36, schrieb Dong Xu Wang: add-cow file can't live alone, must together will image_file and backing_file. If w

[Qemu-devel] [PATCH 0/5] scsi related fixes

2012-06-14 Thread Christian Borntraeger
Paolo, this patch series was created during bringup of virtio-scsi on s390x. We used a tape library as a test vehicle. so here is the set of patches that allowed us to use it via virtio-scsi. Any comments? Ok to apply? Christian Christian Hoff (5): scsi: Fix data length == SCSI_SENSE_BUF_SIZ

Re: [Qemu-devel] [PATCH v2 6/6] msix: Fix last PCIDevice naming inconsitency

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 08:18:10AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 11:13 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 10:52:06PM -0600, Alex Williamson wrote: > > > The previous patches fixed almost all the inconsistent names used > > > for PCIDevice in msix.c,

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 13:24 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > > These don't have to be contiguous. Size them to only what > > they need and use separate MemoryRegions for the vector > > table and PBA. > > > > Signed-off-by: Alex

Re: [Qemu-devel] [PATCH 5/5] scsi: Ensure command and transfer lengths are set for all SCSI stream commands.

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 15:55, Christian Borntraeger ha scritto: > From: Christian Hoff > > scsi-generic relies on those values to be correct, so it is important that > those values are initialized properly prior to submitting the SCSI command. This and the similar code in patch 3/5 can be replaced by the

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 08:13 +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > > > -memory_region_init_io(&dev->msix_mmio, &msix_mmio_ops, dev, > > - "msix", MSIX_PAGE_SIZE); > > +memory_region_init_io(&dev->msix_table_mmio, &msix_table_mmi

Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 16:17, schrieb Dong Xu Wang: > On Thu, Jun 14, 2012 at 10:11 PM, Kevin Wolf wrote: >> Am 14.06.2012 16:06, schrieb Dong Xu Wang: >>> On Thu, Jun 14, 2012 at 6:51 PM, Kevin Wolf wrote: Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow file can't live alone, must together

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-14 Thread Zhi Hui Li
On 2012年06月11日 23:37, Jeff Cody wrote: On 06/11/2012 10:24 AM, Stefan Hajnoczi wrote: On Mon, Jun 11, 2012 at 1:50 PM, Kevin Wolf wrote: Am 11.06.2012 14:09, schrieb Stefan Hajnoczi: On Fri, Jun 8, 2012 at 6:46 PM, Jeff Cody wrote: On 06/08/2012 12:11 PM, Kevin Wolf wrote: Am 08.06.2012 16

Re: [Qemu-devel] [PATCH v2 1/6] msix: Add simple BAR allocation MSIX setup functions

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 13:29 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 10:51:19PM -0600, Alex Williamson wrote: > > msi_init() takes over a BAR without really specifying or allowing > > specification of how it does so. Instead, let's split it into > > two interfaces, one fully spec

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Andreas Färber
Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: > From: Li Zhang > > For pseries machine, it needs to enable usb > to add kbd or usb mouse. -usb option won't > be used in the future, and machine options > is a better way to enable usb. > > So this patch is to add usb option to machine > options

Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert

2012-06-14 Thread Dong Xu Wang
On Thu, Jun 14, 2012 at 10:24 PM, Kevin Wolf wrote: > Am 14.06.2012 16:17, schrieb Dong Xu Wang: >> On Thu, Jun 14, 2012 at 10:11 PM, Kevin Wolf wrote: >>> Am 14.06.2012 16:06, schrieb Dong Xu Wang: On Thu, Jun 14, 2012 at 6:51 PM, Kevin Wolf wrote: > Am 13.06.2012 16:36, schrieb Dong X

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-14 Thread Jeff Cody
On 06/14/2012 10:23 AM, Zhi Hui Li wrote: > On 2012年06月11日 23:37, Jeff Cody wrote: >> On 06/11/2012 10:24 AM, Stefan Hajnoczi wrote: >>> On Mon, Jun 11, 2012 at 1:50 PM, Kevin Wolf wrote: Am 11.06.2012 14:09, schrieb Stefan Hajnoczi: > On Fri, Jun 8, 2012 at 6:46 PM, Jeff Cody wrote: >>>

[Qemu-devel] [PATCH] cris: Add break support for v10

2012-06-14 Thread Edgar E. Iglesias
I seem to have missed to push this upstream... commit f756c7a723faa3a21dcb6bb6806e77f1628019f5 Author: Edgar E. Iglesias Date: Tue Jul 5 12:56:41 2011 +0200 cris: Add break support for v10. Still no retb Signed-off-by: Edgar E. Iglesias diff --git a/target-cris/cpu.h b/

Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function"

2012-06-14 Thread Anthony PERARD
On 13/06/12 13:48, Jan Kiszka wrote: >> Will you be able to use an address parser via some device property? > > Yes. Actually, the address is already a device property. > Great. Then we should try to come up with a common pci-host-devaddr property everyone can use. Is this patch would be a

[Qemu-devel] [PATCH] configure: properly check if -lrt and -lm is needed

2012-06-14 Thread Natanael Copa
Fixes build against uClibc. uClibc provides 2 versions of clock_gettime(), one with realtime support and one without (this is so you can avoid linking in -lrt unless actually needed). This means that the clock_gettime() don't need -lrt. We still need it for timer_create() so we check for this func

Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd?

2012-06-14 Thread Andreas Färber
Am 14.06.2012 12:16, schrieb 陳韋任 (Wei-Ren Chen): >>> I think KVM_CREATE_VCPU should return VCPU fd, right? AFAIK, in KVM >>> world, kvm_fd usually means the fd we get after opening "/dev/kvm". >>> Just want to make sure I understand the code correcly. Thanks. >> >> This is the kvm_fd inside struc

Re: [Qemu-devel] [PATCH v2 4/6] msix: Split PBA into it's own MemoryRegion

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 08:21:39AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 13:24 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 10:51:47PM -0600, Alex Williamson wrote: > > > These don't have to be contiguous. Size them to only what > > > they need and use separate Memo

[Qemu-devel] [PATCH 0/2] introduce bdrv_swap, implement bdrv_append on top

2012-06-14 Thread Paolo Bonzini
Yet another tiny bit extracted from block mirroring, looks like it should be useful for block commit too. Paolo Bonzini (2): block: copy over job and dirty bitmap fields in bdrv_append block: introduce bdrv_swap, implement bdrv_append on top of it block.c | 175 +

[Qemu-devel] [PATCH 2/2] block: introduce bdrv_swap, implement bdrv_append on top of it

2012-06-14 Thread Paolo Bonzini
The new function can be made a bit nicer than bdrv_append. It swaps the whole contents, and then swaps back (using the usual t=a;a=b;b=t idiom) the fields that need to stay on top. Thus, it does not need explicit bdrv_detach_dev, bdrv_iostatus_disable, etc. Signed-off-by: Paolo Bonzini --- blo

[Qemu-devel] [PATCH 1/2] block: copy over job and dirty bitmap fields in bdrv_append

2012-06-14 Thread Paolo Bonzini
While these should not be in use at the time a transaction is started, a command in the prepare phase of a transaction might have added them, so they need to be brought over. Signed-off-by: Paolo Bonzini --- block.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block.c b

Re: [Qemu-devel] [PATCH v2] qapi: converted commit

2012-06-14 Thread Pavel Hrdina
On 06/14/2012 02:18 PM, Eric Blake wrote: On 06/14/2012 01:35 AM, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- +++ b/qapi-schema.json @@ -1169,6 +1169,21 @@ { 'command': 'block_resize', 'data': { 'device': 'str', 'size': 'int' }} ## +# @commit +# +# Commit changes to the disk images

  1   2   3   >