[Qemu-devel] [PATCH v2 0/3] target-xtensa: AREG0 conversion

2012-06-10 Thread Max Filippov
Changes in v2: - add Peter's patch to this series - rebase to the current master - remove HELPER_CFLAGS from target-xtensa/Makefile.objs Max Filippov (2): target-xtensa: add attributes to helper functions target-xtensa: switch to AREG0-free mode Peter Portante (1): target-xtensa: remove unn

[Qemu-devel] [PATCH v2 1/3] target-xtensa: remove unnecessary include of dyngen-exec.h

2012-06-10 Thread Max Filippov
From: Peter Portante Signed-off-by: Peter Portante Signed-off-by: Max Filippov --- target-xtensa/xtensa-semi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c index b7c8c34..1c8a19e 100644 --- a/target-xtensa/xt

[Qemu-devel] [PATCH v2 3/3] target-xtensa: switch to AREG0-free mode

2012-06-10 Thread Max Filippov
Add env parameter to every helper function that needs it, update 'configure' script. Signed-off-by: Max Filippov --- configure |2 +- target-xtensa/helper.h| 54 +++--- target-xtensa/op_helper.c | 185 ++--- target-xtensa

Re: [Qemu-devel] [PATCH v2 0/3] target-xtensa: AREG0 conversion

2012-06-10 Thread Max Filippov
On Sun, Jun 10, 2012 at 11:26 AM, Max Filippov wrote: > Changes in v2: > - add Peter's patch to this series > - rebase to the current master > - remove HELPER_CFLAGS from target-xtensa/Makefile.objs Grrr, sent from wrong directory, sorry. v3 to come. > Max Filippov (2): >  target-xtensa: add att

[Qemu-devel] [PATCH v3 0/3] target-xtensa: AREG0 conversion

2012-06-10 Thread Max Filippov
Changes in v3: - add Peter's patch to this series - rebase to the current master - actually remove HELPER_CFLAGS from target-xtensa/Makefile.objs Max Filippov (2): target-xtensa: add attributes to helper functions target-xtensa: switch to AREG0-free mode Peter Portante (1): target-xtensa: r

[Qemu-devel] [PATCH v3 1/3] target-xtensa: remove unnecessary include of dyngen-exec.h

2012-06-10 Thread Max Filippov
From: Peter Portante Signed-off-by: Peter Portante Signed-off-by: Max Filippov --- target-xtensa/xtensa-semi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c index b7c8c34..1c8a19e 100644 --- a/target-xtensa/xt

[Qemu-devel] [PATCH v3 2/3] target-xtensa: add attributes to helper functions

2012-06-10 Thread Max Filippov
Mark exception generating functions 'noreturn' and pure constant functions as such. Signed-off-by: Max Filippov --- target-xtensa/helper.h | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target-xtensa/helper.h b/target-xtensa/helper.h index 48a741e..9dd6f8

[Qemu-devel] [PATCH v3 3/3] target-xtensa: switch to AREG0-free mode

2012-06-10 Thread Max Filippov
Add env parameter to every helper function that needs it, update 'configure' script. Signed-off-by: Max Filippov --- configure |2 +- target-xtensa/Makefile.objs |2 - target-xtensa/helper.h | 54 ++-- target-xtensa/op_helper.c | 185 ++

[Qemu-devel] [PATCH v2 2/3] target-xtensa: add attributes to helper functions

2012-06-10 Thread Max Filippov
Mark exception generating functions 'noreturn' and pure constant functions as such. Signed-off-by: Max Filippov --- target-xtensa/helper.h | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target-xtensa/helper.h b/target-xtensa/helper.h index 48a741e..9dd6f8

Re: [Qemu-devel] Large sized guest taking for ever to boot...

2012-06-10 Thread Gleb Natapov
On Fri, Jun 08, 2012 at 11:20:53AM -0700, Chegu Vinod wrote: > On 6/8/2012 11:08 AM, Jan Kiszka wrote: > BTW, another data point ...if I try to boot a the RHEL6.3 kernel in > the guest (with the latest qemu.git and the 3.4.1 on the host) it > boots just fine > > So something to do with the 3.

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > Add a property to receive a fully qualified PCI device address. > > Will be used by KVM device assignment. > > Signed-off-by: Jan Kiszka I'd like to ponder this a bit more. What bothers me is that this mixes two things: - ad

Re: [Qemu-devel] [PATCH 09/13] pci: Introduce and apply PCIDeviceAddress

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:17AM +0200, Jan Kiszka wrote: > This type encapsulates everything from domain to function. Use it first > to simplify the pci_parse_devaddr interface. > > Signed-off-by: Jan Kiszka OK. Except this really is a legacy interface. So please call it PCILegacyDeviceAddres

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > This per-device notifier shall be triggered by any interrupt router > along the path of a device's legacy interrupt signal on routing changes. > For simplicity reasons and as this is a slow path anyway, no further > details on the routin

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > On 2012-06-07 18:28, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: > >> On 2012-06-07 16:32, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: > @

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:48, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: >> This per-device notifier shall be triggered by any interrupt router >> along the path of a device's legacy interrupt signal on routing changes. >> For simplicity reasons and as this is a

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:55, Michael S. Tsirkin wrote: > On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: >> On 2012-06-07 18:28, Michael S. Tsirkin wrote: >>> On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: On 2012-06-07 16:32, Michael S. Tsirkin wrote: > On Mon, Jun 04, 20

Re: [Qemu-devel] [PATCH 09/13] pci: Introduce and apply PCIDeviceAddress

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:37, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:17AM +0200, Jan Kiszka wrote: >> This type encapsulates everything from domain to function. Use it first >> to simplify the pci_parse_devaddr interface. >> >> Signed-off-by: Jan Kiszka > > OK. > Except this really is a

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:35, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: >> Add a property to receive a fully qualified PCI device address. >> >> Will be used by KVM device assignment. >> >> Signed-off-by: Jan Kiszka > > I'd like to ponder this a bit more. Wha

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:05:10PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:48, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > >> This per-device notifier shall be triggered by any interrupt router > >> along the path of a device's legacy interrupt si

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:55, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > >> On 2012-06-07 18:28, Michael S. Tsirkin wrote: > >>> On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:33, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:05:10PM +0200, Jan Kiszka wrote: >> On 2012-06-10 11:48, Michael S. Tsirkin wrote: >>> On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: This per-device notifier shall be triggered by any interrupt router >>>

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:35, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > >> Add a property to receive a fully qualified PCI device address. > >> > >> Will be used by KVM device assignment. > >> > >

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:41, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: >>> On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: On 2012-06-07 18:28, Michael S. Tsirkin wrote: > On Thu, Jun 07, 20

Re: [Qemu-devel] USB Hostport Differences

2012-06-10 Thread Erik Rull
Hans de Goede wrote: Hi, On 06/08/2012 10:56 PM, Erik Rull wrote: Hans de Goede wrote: Hi, On 06/08/2012 06:33 PM, Erik Rull wrote: Hi all, when assigning USB host devices to a guest using the hostport option, there seem to be different formats, when calling info usbhost: - On my vanilla k

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:49:11PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: > >>> On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:49, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: >> On 2012-06-10 11:35, Michael S. Tsirkin wrote: >>> On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: Add a property to receive a fully qualified PCI device address. >>

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:49, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:35, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > A

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:58, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: >> On 2012-06-10 12:49, Michael S. Tsirkin wrote: >>> On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: On 2012-06-10 11:35, Michael S. Tsirkin wrote: > On Mon, Jun 04, 20

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:44:05PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:33, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:05:10PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:48, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > T

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:58, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 12:49, Michael S. Tsirkin wrote: > >>> On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 13:11, Michael S. Tsirkin wrote: > From commit log it would seem that even irq changes should > invoke this. So why isn't this notifier at the host bridge then? Can't follow, where does the commit log imply this? It is only about routing changes, not IRQ level c

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 13:17, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: >> On 2012-06-10 12:58, Michael S. Tsirkin wrote: >>> On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: On 2012-06-10 12:49, Michael S. Tsirkin wrote: > On Sun, Jun 10, 20

Re: [Qemu-devel] [PATCH 03/13] pci: Introduce cached device INTx routing

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:11AM +0200, Jan Kiszka wrote: > Based on the original version by Michael Tsirkin: Instead of traversing > the PCI bus hierarchy from a device to the host bridge, cache this path > in PCIDevice and use it directly on interrupt delivery. This will > specifically pay off

Re: [Qemu-devel] [PATCH 01/13] pci: Refactor pci_change_irq_level

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:09AM +0200, Jan Kiszka wrote: > Align the bus traversal in pci_change_irq_level to other functions. They > use PCIBus:parent_dev to detect the root. > > Signed-off-by: Jan Kiszka Applied. > --- > hw/pci.c |8 > 1 files changed, 4 insertions(+), 4 dele

Re: [Qemu-devel] [PATCH 04/13] pci: Rename map_irq to route_pin

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:12AM +0200, Jan Kiszka wrote: > To avoid confusion with the board-level IRQ the host bridge triggers on > output, rename the per-bridge routing function for the INTx pins to > pci_route_pin_fn. Also adjust variable names of that type. And > rename pci_bridge_map_irq to

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:18:15PM +0200, Jan Kiszka wrote: > On 2012-06-10 13:11, Michael S. Tsirkin wrote: > > From commit log it would seem that even irq changes should > > invoke this. So why isn't this notifier at the host bridge then? > > Can't follow, where does the commit

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:25:41PM +0200, Jan Kiszka wrote: > On 2012-06-10 13:17, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 12:58, Michael S. Tsirkin wrote: > >>> On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] USB Hostport Differences

2012-06-10 Thread Hans de Goede
Hi, On 06/10/2012 12:51 PM, Erik Rull wrote: Hans de Goede wrote: Hi, On 06/08/2012 10:56 PM, Erik Rull wrote: Hans de Goede wrote: Hi, On 06/08/2012 06:33 PM, Erik Rull wrote: Hi all, when assigning USB host devices to a guest using the hostport option, there seem to be different formats

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 13:39, Michael S. Tsirkin wrote: > It's OK to use recursion but when done through a callback > like this it's unreadable. Isn't the alternative poking into foreign bridge device states for their secondary buses? > Also, you need to setup you cache after intx cache has been > initial

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: > On 2012-06-10 13:39, Michael S. Tsirkin wrote: > > It's OK to use recursion but when done through a callback > > like this it's unreadable. > > Isn't the alternative poking into foreign bridge device states for their > secondary buses?

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:18:15PM +0200, Jan Kiszka wrote: > >> @@ -318,6 +322,9 @@ PCIBus *pci_register_bus(DeviceState *parent, > >> const char *name, > >> MemoryRegion *address_space_io, > >> uint8_t devfn_min, int nirq); > >>

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 14:16, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: >> On 2012-06-10 13:39, Michael S. Tsirkin wrote: >>> It's OK to use recursion but when done through a callback >>> like this it's unreadable. >> >> Isn't the alternative poking into foreign

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 02:33:03PM +0200, Jan Kiszka wrote: > On 2012-06-10 14:16, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 13:39, Michael S. Tsirkin wrote: > >>> It's OK to use recursion but when done through a callback > >>> like

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 14:42, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 02:33:03PM +0200, Jan Kiszka wrote: >> On 2012-06-10 14:16, Michael S. Tsirkin wrote: >>> On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: On 2012-06-10 13:39, Michael S. Tsirkin wrote: > It's OK to use rec

[Qemu-devel] [PATCH 1/2] libcacard: build fixes

2012-06-10 Thread Blue Swirl
Link trace objects to fix these errors: LINK vscclient oslib-posix.o: In function `trace_qemu_vfree': /src/qemu/obj-amd64/./trace.h:39: undefined reference to `trace1' oslib-posix.o: In function `trace_qemu_memalign': /src/qemu/obj-amd64/./trace.h:31: undefined reference to `trace3' oslib-posix.

[Qemu-devel] [PATCH 2/2] tests: add gcov target

2012-06-10 Thread Blue Swirl
Add support for compiling for GCOV test coverage, enabled with '--enable-gcov' during configure. After tests, test coverage can be reported with 'make gcov'. Signed-off-by: Blue Swirl --- configure | 19 ++- tests/Makefile | 40

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 02:47:40PM +0200, Jan Kiszka wrote: > On 2012-06-10 14:42, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 02:33:03PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 14:16, Michael S. Tsirkin wrote: > >>> On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 04/13] pci: Rename map_irq to route_pin

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:12AM +0200, Jan Kiszka wrote: > To avoid confusion with the board-level IRQ the host bridge triggers on > output, rename the per-bridge routing function for the INTx pins to > pci_route_pin_fn. Also adjust variable names of that type. And > rename pci_bridge_map_irq to

Re: [Qemu-devel] Large sized guest taking for ever to boot...

2012-06-10 Thread Chegu Vinod
On 6/10/2012 2:30 AM, Gleb Natapov wrote: On Fri, Jun 08, 2012 at 11:20:53AM -0700, Chegu Vinod wrote: On 6/8/2012 11:08 AM, Jan Kiszka wrote: BTW, another data point ...if I try to boot a the RHEL6.3 kernel in the guest (with the latest qemu.git and the 3.4.1 on the host) it boots just fine...

Re: [Qemu-devel] [PATCH 1/2] libcacard: build fixes

2012-06-10 Thread Alon Levy
On Sun, Jun 10, 2012 at 01:04:32PM +, Blue Swirl wrote: > Link trace objects to fix these errors: > LINK vscclient > oslib-posix.o: In function `trace_qemu_vfree': > /src/qemu/obj-amd64/./trace.h:39: undefined reference to `trace1' > oslib-posix.o: In function `trace_qemu_memalign': > /src/q

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 15:01 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 01:25:41PM +0200, Jan Kiszka wrote: > > On 2012-06-10 13:17, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: > > >> On 2012-06-10 12:58, Michael S. Tsirkin wrote: > > >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:35, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > >> Add a property to receive a fully qualified PCI device address. > >> > >> Will be used by KVM device assignment. > >> > >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > vfio_pci.c contains a nice function called "parse_hostaddr". You may > > > guess what it does. ;) > > > >>> > > > >>> Interesting. Why? This looks strange to me: > > > >>> I would expect the admin to bind a device to v

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: > >>> On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > On 2012-

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > > vfio_pci.c contains a nice function called "parse_hostaddr". You > > > > may > > > > guess what it does. ;) > > > > >>> > > > > >>> Interesting. Wh

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 08:19:28AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > > >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: > > >>>

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > > > vfio_pci.c contains a nice function called "parse_hostaddr". You > > > > > may >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > > > > vfio_pci.c contain

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 17:43 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 08:19:28AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > > > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 07:

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-10 Thread Paolo Bonzini
Il 08/06/2012 03:19, Anthony Liguori ha scritto: >> >> +typedef enum ObjectState { >> +OBJECT_STATE_INITIALIZED = 1, >> +OBJECT_STATE_REALIZED, >> +} ObjectState; > > I think using a bool would be better since it reduces the temptation to > add additional states. In fact someone already d

Re: [Qemu-devel] [PULL] iov* function rework (one more time)

2012-06-10 Thread Paolo Bonzini
Il 08/06/2012 01:20, Paolo Bonzini ha scritto: >> > This is the same patchset which has been submitted, resubmitted, >> > rewritten, resubmitted, split, resubmitted, merged, rewritten again, >> > resubmitted and finally received a promise from Anthony to be looked >> > at. Today, months later, I'm

[Qemu-devel] [Bug 1011142] [NEW] Arm emulation do a crash

2012-06-10 Thread BRULE Herman
Public bug reported: Hello, I have try multiple image for the raspberry pi, with this cli: /usr/bin/qemu-system-arm -kernel kernel-rasptoo -M versatilepb -cpu arm1176 -hda hdd.img -m 256 -append "root=/dev/sda2 loglevel=7 debug" -serial stdio -no-kvm I don't know why, with kvm it say: KVM not su

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 09:25:06AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 17:43 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 08:19:28AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > > > > On 2012-06-10 12:41, Michael S. Tsi

[Qemu-devel] [PATCH v2 0/2] pci_host: Convert to QOM

2012-06-10 Thread Andreas Färber
Hello Michael, This series, based on a recent PReP RFC series, in turn based on Anthony's and Wanpeng's i440fx refactoring, makes pci_host a proper QOM type and in this v2 also updates all remaining host controllers beyond PReP. Only compile-tested were typhoon, bonito, ppc440 and ppce500. I've c

[Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-10 Thread Andreas Färber
From: Andreas Färber Allows us to access PCIHostState QOM-style with PCI_HOST() macro. Update PReP Raven PCI to derive from this type. Signed-off-by: Anthony Liguori Signed-off-by: Wanpeng Li Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- hw/pci_host.c | 11 +++ h

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > > > > On Sun, 2012-06-10 at 17:03

[Qemu-devel] [PATCH v2 2/2] pci_host: Derive remaining PCI host controllers from TYPE_PCI_HOST

2012-06-10 Thread Andreas Färber
Some used a dummy "busdev" field to trick qdev upcast macros. QOM requires the parent type's struct to be placed as first field. Drop such bogus fields and use QOM-style casts instead. Some typedef'ed their state to PCIHostState. Use a proper struct, and use PCIHostState and PCI_HOST() where appro

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-06-10 Thread Paolo Bonzini
Il 09/06/2012 02:31, q...@buildbot.b1-systems.de ha scritto: > The Buildbot has detected a new failure on builder default_openbsd_current > while building qemu. > Full details are available at: > > http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/288 > > Buildbot URL:

Re: [Qemu-devel] [PATCH 2/2] tests: add gcov target

2012-06-10 Thread Paolo Bonzini
Il 10/06/2012 15:04, Blue Swirl ha scritto: > @@ -2851,10 +2859,14 @@ fi > # End of CC checks > # After here, no more $cc or $ld runs > > -if test "$debug" = "no" ; then > +if test "$gcov" = "yes" ; then > + CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS" > + LDFLAGS="-fprofile-arcs -ftest

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-10 Thread Paolo Bonzini
Il 08/06/2012 15:19, Jeff Cody ha scritto: >> > >> > This means copying allocated blocks from snap1.qcow2 and writing them >> > into vm001.img. Once this process is complete it is safe to delete >> > snap1.qcow2 since all data is now in vm001.img. > Yes, this is the same as what we are wanting to

Re: [Qemu-devel] [PATCH 2/2] tests: add gcov target

2012-06-10 Thread Andreas Färber
Am 10.06.2012 15:04, schrieb Blue Swirl: > Add support for compiling for GCOV test coverage, enabled > with '--enable-gcov' during configure. > > After tests, test coverage can be reported with 'make gcov'. > > Signed-off-by: Blue Swirl > --- > configure | 19 ++- > tests

Re: [Qemu-devel] [PATCH 1/2] libcacard: build fixes

2012-06-10 Thread Andreas Färber
Am 10.06.2012 15:04, schrieb Blue Swirl: > Link trace objects to fix these errors: > LINK vscclient > oslib-posix.o: In function `trace_qemu_vfree': > /src/qemu/obj-amd64/./trace.h:39: undefined reference to `trace1' > oslib-posix.o: In function `trace_qemu_memalign': > /src/qemu/obj-amd64/./tra

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-10 Thread Paolo Bonzini
Il 08/06/2012 19:57, Kevin Wolf ha scritto: >> > >> > I agree, doing it like mirroring for new writes on the top layer makes >> > sense, as long as you are willing to violate the (optional) speed >> > parameter. I wouldn't think violating the speed parameter in that case >> > would be an issue, a

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 09:58:17AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 08:

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Jan Kiszka
On 2012-06-10 17:55, Michael S. Tsirkin wrote: >>> So if you expect me to merge this work, then either Jan does (1), or >>> gives up and does (2), or I find some time and do (1), or I fail to do >>> (1) and get convinced that we need to do (3). Or someone else gets >>> involved. >> >> I still have

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 06:30:59PM +0200, Jan Kiszka wrote: > Caching the host bridge generically means changing all chipsets and, > well, also testing that they still work afterward. As explained before, > I'd really like to avoid doing this in a single step. Surely it is not hard to find a way t

Re: [Qemu-devel] [Bug 1011142] [NEW] Arm emulation do a crash

2012-06-10 Thread Andreas Färber
Am 10.06.2012 14:19, schrieb BRULE Herman: > Hello, I have try multiple image for the raspberry pi, with this cli: > /usr/bin/qemu-system-arm -kernel kernel-rasptoo -M versatilepb -cpu arm1176 > -hda hdd.img -m 256 -append "root=/dev/sda2 loglevel=7 debug" -serial stdio > -no-kvm Does the qemu-s

[Qemu-devel] [RFC PATCH] msix: Support specifying offsets, BARs, and capability location

2012-06-10 Thread Alex Williamson
msix_init has very little configurability as to how it lays out MSI/X for a device. It claims to resize BARs, but doesn't actually do this anymore. This patch allows MSI/X to be fully specified, which is necessary both for emulated devices trying to match the physical layout of a hardware device

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 07:50:07PM +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 06:30:59PM +0200, Jan Kiszka wrote: > > Caching the host bridge generically means changing all chipsets and, > > well, also testing that they still work afterward. As explained before, > > I'd really like

Re: [Qemu-devel] [RFC PATCH] msix: Support specifying offsets, BARs, and capability location

2012-06-10 Thread Jan Kiszka
On 2012-06-10 19:02, Alex Williamson wrote: > msix_init has very little configurability as to how it lays out > MSI/X for a device. It claims to resize BARs, but doesn't > actually do this anymore. This patch allows MSI/X to be fully > specified, which is necessary both for emulated devices tryin

Re: [Qemu-devel] [Bug 1011142] [NEW] Arm emulation do a crash

2012-06-10 Thread Dunrong Huang
2012/6/10 BRULE Herman <1011...@bugs.launchpad.net>: > I can't debug it with gdb, it crash after the kernel boot (the qemu > application crash). > I'm under gentoo: I am under gentoo too, why cant you use debug qemu? There is another way to debug qemu: Open a terminal, set you core file size to

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 19:22 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 09:58:17AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > > > > On Sun, 2012-06-10 at 17:54

Re: [Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-10 Thread Anthony Liguori
On 06/10/2012 10:57 AM, Andreas Färber wrote: From: Andreas Färber Allows us to access PCIHostState QOM-style with PCI_HOST() macro. Update PReP Raven PCI to derive from this type. Signed-off-by: Anthony Liguori Signed-off-by: Wanpeng Li Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguo

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-10 Thread Anthony Liguori
On 06/10/2012 10:49 AM, Paolo Bonzini wrote: Il 08/06/2012 03:19, Anthony Liguori ha scritto: +typedef enum ObjectState { +OBJECT_STATE_INITIALIZED = 1, +OBJECT_STATE_REALIZED, +} ObjectState; I think using a bool would be better since it reduces the temptation to add additional state

Re: [Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-10 Thread Andreas Färber
Am 10.06.2012 19:33, schrieb Anthony Liguori: > On 06/10/2012 10:57 AM, Andreas Färber wrote: >> From: Andreas Färber >> >> Allows us to access PCIHostState QOM-style with PCI_HOST() macro. >> >> Update PReP Raven PCI to derive from this type. >> >> Signed-off-by: Anthony Liguori >> Signed-off-by:

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-10 Thread Andreas Färber
Am 10.06.2012 17:49, schrieb Paolo Bonzini: > Il 08/06/2012 03:19, Anthony Liguori ha scritto: >>> >>> +typedef enum ObjectState { >>> +OBJECT_STATE_INITIALIZED = 1, >>> +OBJECT_STATE_REALIZED, >>> +} ObjectState; >> >> I think using a bool would be better since it reduces the temptation to

Re: [Qemu-devel] [RFC PATCH] msix: Support specifying offsets, BARs, and capability location

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 11:02:48AM -0600, Alex Williamson wrote: > msix_init has very little configurability as to how it lays out > MSI/X for a device. It claims to resize BARs, but doesn't > actually do this anymore. This patch allows MSI/X to be fully > specified, which is necessary both for e

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 11:29:10AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 19:22 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 09:58:17AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 09:

[Qemu-devel] [Bug 1011142] Re: Arm emulation do a crash

2012-06-10 Thread BRULE Herman
Because it stop on: Program received signal SIG38, Real-time event 38. [Switching to Thread 0x71125700 (LWP 32348)] tcg_qemu_tb_exec (cpustate=, tb_ptr=0x400016b3 "\025\b") at /var/tmp-disk/portage/app-emulation/qemu-kvm-1.0.1-r1/work/qemu-kvm-1.0.1/tci.c:442 442 /var/tmp-disk/portage/app

Re: [Qemu-devel] [PATCH 2/2] tests: add gcov target

2012-06-10 Thread Blue Swirl
On Sun, Jun 10, 2012 at 4:04 PM, Paolo Bonzini wrote: > Il 10/06/2012 15:04, Blue Swirl ha scritto: >> @@ -2851,10 +2859,14 @@ fi >>  # End of CC checks >>  # After here, no more $cc or $ld runs >> >> -if test "$debug" = "no" ; then >> +if test "$gcov" = "yes" ; then >> +  CFLAGS="-fprofile-arcs -

Re: [Qemu-devel] [PATCH 2/2] tests: add gcov target

2012-06-10 Thread Blue Swirl
On Sun, Jun 10, 2012 at 4:08 PM, Andreas Färber wrote: > Am 10.06.2012 15:04, schrieb Blue Swirl: >> Add support for compiling for GCOV test coverage, enabled >> with '--enable-gcov' during configure. >> >> After tests, test coverage can be reported with 'make gcov'. >> >> Signed-off-by: Blue Swir

[Qemu-devel] [Bug 1011142] Re: Arm emulation do a crash

2012-06-10 Thread Stefan Weil
Obviously you compiled QEMU using the experimental TCI (TCG interpreter). That's not wrong (for debugging some kinds of crashes it is even useful), but it's slow. You also called gdb with qemu-system-x86_64, but the core was from qemu- system-arm. Which kernel did you use? zImage or kernel-raspto

[Qemu-devel] [Bug 1011142] Re: Arm emulation do a crash

2012-06-10 Thread BRULE Herman
Then the correct gdb command provide: #0 tcg_qemu_tb_exec (cpustate=, tb_ptr=0x0) at /var/tmp-disk/portage/app-emulation/qemu-kvm-1.0.1-r1/work/qemu-kvm-1.0.1/tci.c:444 #1 0x7f6ced51393d in cpu_arm_exec (env=0x7f6cee66c3d0) at /var/tmp-disk/portage/app-emulation/qemu-kvm-1.0.1-r1/work/qemu-

Re: [Qemu-devel] [PATCH 1.1 1/2] kvm/apic: correct short memset

2012-06-10 Thread Stefan Weil
Am 23.05.2012 12:33, schrieb Jan Kiszka: On 2012-05-22 17:30, Stefan Weil wrote: Am 10.05.2012 19:28, schrieb Jan Kiszka: On 2012-05-10 13:19, Jim Meyering wrote: From: Jim Meyering kvm_put_apic_state's attempt to clear *kapic before setting its bits cleared sizeof(void*) bytes (no more than

Re: [Qemu-devel] [PATCH v3 0/3] target-xtensa: AREG0 conversion

2012-06-10 Thread Blue Swirl
Thanks, applied all. On Sun, Jun 10, 2012 at 7:33 AM, Max Filippov wrote: > Changes in v3: > - add Peter's patch to this series > - rebase to the current master > - actually remove HELPER_CFLAGS from target-xtensa/Makefile.objs > > Max Filippov (2): >  target-xtensa: add attributes to helper func

Re: [Qemu-devel] [PATCH 2/2] cadence_gem: avoid stack-writing buffer-overrun

2012-06-10 Thread Stefan Weil
Am 14.05.2012 06:57, schrieb Peter Crosthwaite: ACK and Thanks Jim, Reviewed-by: Peter A.G. Crosthwaite On Fri, May 11, 2012 at 2:19 AM, Jim Meyering wrote: From: Jim Meyering Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number of bytes to clear. The latter would always clear

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-06-10 Thread Blue Swirl
On Sun, Jun 10, 2012 at 4:01 PM, Paolo Bonzini wrote: > Il 09/06/2012 02:31, q...@buildbot.b1-systems.de ha scritto: >> The Buildbot has detected a new failure on builder default_openbsd_current >> while building qemu. >> Full details are available at: >>  http://buildbot.b1-systems.de/qemu/build

[Qemu-devel] [Bug 1011142] Re: Arm emulation do a crash

2012-06-10 Thread Stefan Weil
The missing emulation of Raspberry PI hardware is not a QEMU bug. Anybody is free to add this emulation or to support others to do the job. It won't be easy because the RPi hardware is only partially documented, and the RPi system uses closed source drivers for video. If nobody objects, I suggest

[Qemu-devel] [Bug 1011142] Re: Arm emulation do a crash

2012-06-10 Thread BRULE Herman
Just basic support, that's mean: no crash, and minimal system in console boot (all device emulated by QEMU is already supported). For me the crash, and mainly this cpu seam be supported by QEMU, just have the instruction bugged. -- You received this bug notification because you are a member of qe

  1   2   >