Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-07 Thread Avi Kivity
On 06/07/2012 12:36 AM, Michael Roth wrote: > It would need to be something fairly ubiquitous though, and pygments is > the more well-used library yet still isn't available on RHEL5 and > probably a few other distros we need to support. If someone wants to build qemu from source on RHEL5, they can

Re: [Qemu-devel] [PATCH 02/12] qcow2: fix the byte endian convertion

2012-06-07 Thread Michael Tokarev
On 04.06.2012 15:13, Kevin Wolf wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Kevin Wolf It appears to be a good candidate for -stable, no? Thanks, /mjt

[Qemu-devel] [PATCH v3 25/29] build: libcacard Makefile cleanups

2012-06-07 Thread Paolo Bonzini
Build vscclient from toplevel Makefile, limit usage of vpath. Signed-off-by: Paolo Bonzini --- Makefile |4 Makefile.objs |8 +++- Makefile.target|6 -- configure | 12 +--- libcacard/Makefile | 17 ++--- 5 files change

Re: [Qemu-devel] What target could be a QOM example?

2012-06-07 Thread Jia Liu
Hi Andreas, Thank you for very good example. It looks like I've made CONFIG_TCG_PASS_AREG0 and QOM OK in my v3 patches. May you review it? On Thu, Jun 7, 2012 at 8:53 AM, Andreas Färber wrote: > Hi Jia, > > Am 30.05.2012 11:29, schrieb Jia Liu: >> Since target-or32 is a new target, I would like

Re: [Qemu-devel] [PATCH v2 00/41] postcopy live migration

2012-06-07 Thread Orit Wasserman
On 06/04/2012 03:37 PM, Anthony Liguori wrote: > On 06/04/2012 05:57 PM, Isaku Yamahata wrote: >> After the long time, we have v2. This is qemu part. >> The linux kernel part is sent separatedly. >> >> Changes v1 -> v2: >> - split up patches for review >> - buffered file refactored >> - many bug f

[Qemu-devel] [PATCH v3 02/29] build: do not sprinkle around GENERATED_HEADERS dependencies

2012-06-07 Thread Paolo Bonzini
Keeping GENERATED_HEADERS dependencies up-to-date everywhere is complex. We can simply make the Makefile depend on them, and they will be built before all other targets. Signed-off-by: Paolo Bonzini --- Makefile| 18 +- Makefile.target | 14 -- tests/Makef

[Qemu-devel] [PATCH v3 15/29] build: move fsdev/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile|2 +- Makefile.objs | 11 +-- fsdev/Makefile.objs |9 + 3 files changed, 15 insertions(+), 7 deletions(-) create mode 100644 fsdev/Makefile.objs diff --git a/Makefile b/Makefile index c0ab97a..0c0540d 100644 -

[Qemu-devel] [PATCH v3 13/29] build: move block/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 16 ++-- block/Makefile.objs | 11 +++ 2 files changed, 13 insertions(+), 14 deletions(-) create mode 100644 block/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index ef49a09..3285949 100644 --- a/Makefile

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Markus Armbruster
Anthony Liguori writes: > On 06/07/2012 05:13 AM, Benjamin Herrenschmidt wrote: >> On Wed, 2012-06-06 at 13:42 +0800, Anthony Liguori wrote: >>> On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote: > Hi Anthony, > > > Any co

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-07 Thread Markus Armbruster
Peter Maydell writes: > On 6 June 2012 13:55, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 5 June 2012 13:51, Markus Armbruster wrote: @@ -554,6 +553,7 @@ static int blk_init(struct XenDevice *xendev)  {     struct XenBlkDev *blkdev = container_of(xendev, struct X

[Qemu-devel] [PATCH v3 21/29] build: move target-independent hw/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
This patch starts converting the hw/ directory. Some files in hw/ are compiled once, some twice (32-/64-bit), some once per target. Each category is moved in a separate patch. After this patch, the files that are compiled once will show the same hierarchy in the build tree as they do in the sourc

[Qemu-devel] [PATCH v3 07/29] dump: do not compile dump.o for user-mode emulation

2012-06-07 Thread Paolo Bonzini
It is not needed, because the monitor is not included. Cc: Wen Congyang Signed-off-by: Paolo Bonzini --- Makefile.target |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index 67d5f3e..f1ec554 100644 --- a/Makefile.target +++ b/Makefile.

[Qemu-devel] [PATCH v3 29/29] build: do not create directories at configure time

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 35 ++- rules.mak |1 + 2 files changed, 3 insertions(+), 33 deletions(-) diff --git a/configure b/configure index cbcbcb1..0ecb55f 100755 --- a/configure +++ b/configure @@ -3671,26 +3671,6 @@ if [ "$TARGET_BASE_

[Qemu-devel] [PATCH v3 03/29] build: add rules for nesting

2012-06-07 Thread Paolo Bonzini
This adds the 'magic' rules that take care of subdirectories. The subdirectory makefiles in the source tree are not complete; they only define some variables (listed in nested-vars) according to the configuration. The magic rules descend into subdirectory makefiles and gather the evaluated values

[Qemu-devel] [PATCH v3 06/29] build: move libobj-y variable to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target | 41 +++ configure |6 -- target-alpha/Makefile.objs |3 ++- target-arm/Makefile.objs|4 target-cris/Makefile.objs |5 - ta

[Qemu-devel] [PULL v3 00/29] per-directory Makefile.objs snippets, limit vpath (ab)use

2012-06-07 Thread Paolo Bonzini
The following changes since commit 349417004a0f7cf5518a998dca755cd06f6c212b: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2012-06-06 20:57:56 +0800) are available in the git repository at: git://github.com/bonzini/qemu.git nested-makefiles-3 for you to fetch changes up to 2d

[Qemu-devel] [PATCH v3 09/29] dump: remove dumping stuff from cpu-all.h

2012-06-07 Thread Paolo Bonzini
This simplifies things, because they will only be included for softmmu targets and because the stubs are taken out-of-line in separate files, which in the future could even be compiled only once. Cc: Wen Congyang Signed-off-by: Paolo Bonzini --- Makefile.target | 10 +++-- c

[Qemu-devel] [PATCH v3 28/29] configure: ensure directory exists when creating symlink

2012-06-07 Thread Paolo Bonzini
From: Anthony Liguori Signed-off-by: Anthony Liguori --- configure |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index cd5e8b3..cbcbcb1 100755 --- a/configure +++ b/configure @@ -42,6 +42,7 @@ compile_prog() { # symbolically link $1 to $2. Port

[Qemu-devel] [PATCH v3 01/29] build: remove trace-nested-y

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 70c5c79..1daa92c 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -425,16 +425,11 @@ ifneq ($(TRACE_BACKEND),dtrace) trace-obj-y

[Qemu-devel] [PATCH v3 10/29] build: move other target-*/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target | 10 +- target-alpha/Makefile.objs |3 ++- target-arm/Makefile.objs|3 ++- target-cris/Makefile.objs |4 ++-- target-i386/Makefile.objs |5 +++-- target-lm32/Makefile.objs |

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Hans de Goede
Hi, Sorry for jumping in the middle of the thread, I missed the beginning of this. Enabling USB by default, esp. emulating a USB mouse by default is a *bad* idea. They way the periodic schedule of the various USB controllers works means that emulating a USB device means a 1000 vm exits per second

[Qemu-devel] [PATCH v3 12/29] build: adapt qom/Makefile and move it to Makefile.objs

2012-06-07 Thread Paolo Bonzini
qom/ already used a separate makefile. Convert it to use relative paths, and make it declare both common-obj-y and user-obj-y. This way, the upper makefiles do not need to know that some QOM files are compiled twice. Signed-off-by: Paolo Bonzini --- Makefile.objs | 13 +++-- qom/

[Qemu-devel] [PATCH v3 23/29] build: move per-target hw/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
This completes the move to nested Makefiles for virtio and a few other files that were not part of obj-TARGET-y, but still were compiled separately for each target. Signed-off-by: Paolo Bonzini --- Makefile.hw |5 +++-- Makefile.target | 35 +++--

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Benjamin Herrenschmidt
On Thu, 2012-06-07 at 10:32 +0200, Hans de Goede wrote: > Hi, > > Sorry for jumping in the middle of the thread, I missed the beginning > of this. Enabling USB by default, esp. emulating a USB mouse by default > is a *bad* idea. They way the periodic schedule of the various USB > controllers works

[Qemu-devel] [Bug 1002121] Re: disk error when guest boot up via qcow2 image

2012-06-07 Thread Yongjie Ren
after reverting bef0fd59 in qemu-kvm, this issue doesn't exist. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1002121 Title: disk error when guest boot up via qcow2 image Status in QEMU: New Bu

[Qemu-devel] [PATCH v3 20/29] build: move qga/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |7 ++- qga/Makefile.objs |3 +++ 2 files changed, 5 insertions(+), 5 deletions(-) create mode 100644 qga/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index e7f7a85..fec21a4 100644 --- a/Makefile.objs +++ b/Makefile.objs

[Qemu-devel] [PATCH v3 27/29] build: compile oslib-obj-y once

2012-06-07 Thread Paolo Bonzini
There is no difference in oslib-obj-y between user-mode and system targets. There used to be when user-mode could optionally be compiled with PIE. Signed-off-by: Paolo Bonzini --- Makefile.objs |3 ++- Makefile.target |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 08/29] dump: change cpu_get_note_size to return ssize_t

2012-06-07 Thread Paolo Bonzini
So that it can use the same prototype in both cases. Check for failure. Cc: Wen Congyang Signed-off-by: Paolo Bonzini --- cpu-all.h |4 ++-- dump.c |9 +++-- target-i386/arch_dump.c |2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v3 16/29] build: move ui/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs| 21 ++--- ui/Makefile.objs | 18 ++ 2 files changed, 20 insertions(+), 19 deletions(-) create mode 100644 ui/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 4acdbaa..a6310e3 100644 --- a/Makef

[Qemu-devel] [PATCH v3 24/29] build: move device tree to per-target Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target |7 --- hw/arm/Makefile.objs|1 + hw/microblaze/Makefile.objs |1 + hw/ppc/Makefile.objs|1 + 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/Makefile.target b/Makefile.target index 563

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Paolo Bonzini
Il 07/06/2012 10:40, Benjamin Herrenschmidt ha scritto: > On Thu, 2012-06-07 at 10:32 +0200, Hans de Goede wrote: >> Hi, >> >> Sorry for jumping in the middle of the thread, I missed the beginning >> of this. Enabling USB by default, esp. emulating a USB mouse by default >> is a *bad* idea. They wa

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Hans de Goede
Hi, On 06/07/2012 10:40 AM, Benjamin Herrenschmidt wrote: On Thu, 2012-06-07 at 10:32 +0200, Hans de Goede wrote: Hi, Sorry for jumping in the middle of the thread, I missed the beginning of this. Enabling USB by default, esp. emulating a USB mouse by default is a *bad* idea. They way the peri

[Qemu-devel] [PATCH v3 26/29] build: limit usage of vpath

2012-06-07 Thread Paolo Bonzini
All paths are now explicitly given, and the object tree mimics the source tree, so there is no need to apply special vpaths. Signed-off-by: Paolo Bonzini --- Makefile|2 +- Makefile.target |5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefil

[Qemu-devel] [PATCH v3 14/29] build: move net/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 17 + net/Makefile.objs | 12 2 files changed, 13 insertions(+), 16 deletions(-) create mode 100644 net/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 3285949..f40be38 100644 --- a/Makefile.obj

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Gerd Hoffmann
Hi, > Would it be possible to "whitelist" the QEMU emulated HID devices > in the kernel to enable dynamic PM for them (at least when they sit > alone on the bus) ? Or is our emulation busted too ? The emulation was fixed a while ago (IIRC 0.14+ works correctly). upstream udev got rules to enabl

[Qemu-devel] [PATCH v3 04/29] build: move *-user/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target| 32 ++-- bsd-user/Makefile.objs |2 ++ configure |8 +++- linux-user/Makefile.objs |7 +++ linux-user/arm/nwfpe/Makefile.objs |

[Qemu-devel] [PATCH v3 11/29] build: move rules for nesting to Makefile.objs

2012-06-07 Thread Paolo Bonzini
At this point we will start adding nesting behavior to other files than Makefile.target. Because Makefile.objs is included by Makefile.target, it is simpler to move the processing of subdirectories there. To enable this, only add per-target files to obj-y. Use a separate variable for the linker

[Qemu-devel] [PATCH v3 19/29] build: move qapi/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |6 ++ qapi/Makefile.objs |3 +++ 2 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 qapi/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 668c148..e7f7a85 100644 --- a/Makefile.objs +++ b/Makefile.ob

[Qemu-devel] [PATCH v3 18/29] build: move slirp/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |5 + slirp/Makefile.objs |3 +++ 2 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 slirp/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 7ee2bb6..668c148 100644 --- a/Makefile.objs +++ b/Makefile.

[Qemu-devel] [PATCH v3 22/29] build: convert libhw to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
After this patch, the libhw* directories will have a hierarchy that mimics the source tree. This is useful because we do have a couple of files there that are in the top source directory. Signed-off-by: Paolo Bonzini --- Makefile.hw |6 +-- Makefile.objs | 143 +--

[Qemu-devel] [PATCH v3 17/29] build: move audio/ objects to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 18 ++ audio/Makefile.objs | 14 ++ 2 files changed, 16 insertions(+), 16 deletions(-) create mode 100644 audio/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index a6310e3..7ee2bb6 100644 --- a/Mak

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Gerd Hoffmann
Hi, > We (me and Gerd Hoffmann) have investigated that, and experimented with it. > It will work for simply devices, but isochronous devices break. The real > solution at least for x86 vms is to get the XHCI emulation finished, as > the XHCI controller has a much nicer hw interface from an emula

Re: [Qemu-devel] [PATCH] target-microblaze: fix swx build breakage

2012-06-07 Thread Edgar E. Iglesias
On Tue, Jun 05, 2012 at 12:31:04PM +1000, Peter A. G. Crosthwaite wrote: > The lazy initialisation of r_check was throwing an error on --enable-debug. > Removed the lazy initialisation of r_check and swx_addr. Applied, thanks! > > Signed-off-by: Peter A. G. Crosthwaite > --- > target-microbla

[Qemu-devel] [PATCH v3 05/29] build: move obj-TARGET-y variables to nested Makefile.objs

2012-06-07 Thread Paolo Bonzini
Also drop duplicate occurrence of device-hotplug.o. Signed-off-by: Paolo Bonzini --- Makefile.target | 186 ++ configure| 48 --- hw/alpha/Makefile.objs |4 + hw/arm/Makefile

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Benjamin Herrenschmidt
On Thu, 2012-06-07 at 10:52 +0200, Hans de Goede wrote: > > At least that would improve the situation in the long run... > > > > Side note: It might be able to add an option at least to OHCI and EHCI > > to relax a bit the correctness of the emulation and dramatically reduce > > the number of exits

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Benjamin Herrenschmidt
On Thu, 2012-06-07 at 11:05 +0200, Gerd Hoffmann wrote: > > We (me and Gerd Hoffmann) have investigated that, and experimented with it. > > It will work for simply devices, but isochronous devices break. The real > > solution at least for x86 vms is to get the XHCI emulation finished, as > > the XH

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Anthony Liguori
On 06/07/2012 04:07 PM, Markus Armbruster wrote: Anthony Liguori writes: On 06/07/2012 05:13 AM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-06 at 13:42 +0800, Anthony Liguori wrote: On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote:

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Li Zhang
On 06/07/2012 05:17 PM, Benjamin Herrenschmidt wrote: On Thu, 2012-06-07 at 11:05 +0200, Gerd Hoffmann wrote: We (me and Gerd Hoffmann) have investigated that, and experimented with it. It will work for simply devices, but isochronous devices break. The real solution at least for x86 vms is to g

[Qemu-devel] [PATCH 33/37] ehci: fix halt status handling

2012-06-07 Thread Gerd Hoffmann
When the enable bits for controller / async schedule / periodic schedule change just make sure we kick the frame timer and let ehci_advance_periodic_state and ehci_advance_async_state handle the controller state changes. This will make ehci set USBSTS_HALT when the controller shutdown is actually

[Qemu-devel] [PATCH 08/37] usb-storage: remove MSDState->residue

2012-06-07 Thread Gerd Hoffmann
We have the field twice, once in MSDState directly and one in the status word struct. Drop one. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index a96c0b9..e665

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Hans de Goede
Hi, On 06/07/2012 11:16 AM, Benjamin Herrenschmidt wrote: On Thu, 2012-06-07 at 10:52 +0200, Hans de Goede wrote: At least that would improve the situation in the long run... Side note: It might be able to add an option at least to OHCI and EHCI to relax a bit the correctness of the emulation

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Markus Armbruster
[cc: Dan to give him a chance to correct whatever underinformed nonsense I might spout on libvirt] Anthony Liguori writes: > On 06/07/2012 04:07 PM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> On 06/07/2012 05:13 AM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-06 at 13:42

Re: [Qemu-devel] [PATCH v4] net: add the support for -netdev socket, listen

2012-06-07 Thread Stefan Hajnoczi
On Wed, Jun 06, 2012 at 09:26:23PM +0800, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > The -net socket,listen option does not work with the newer -netdev > syntax: > http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html > > This patch makes it work now. > > For the case whe

[Qemu-devel] [PATCH 26/37] ehci: add async field to EHCIQueue

2012-06-07 Thread Gerd Hoffmann
Keep track whenever a EHCIQueue is part of the async or periodic schedule. This way we don't have to pass around the async flag everywhere but can look it up from the EHCIQueue struct when needed. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 92

[Qemu-devel] [PATCH 15/37] xhci: trace: irq + events

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 12 trace-events |3 +++ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 43875aa..6890888 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -422,7 +422,6

Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-07 Thread Stefano Stabellini
On Thu, 7 Jun 2012, Stefan Weil wrote: > Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH. > Extend the check in configure to test both preconditions. > > Signed-off-by: Stefan Weil It works for me. Also I think it is a better fix than the original patch. Acked-by: Stefan

[Qemu-devel] [PATCH 20/37] ehci: add EHCIPacket

2012-06-07 Thread Gerd Hoffmann
Add a separate EHCIPacket struct and move fields over from EHCIQueue. Preparing for supporting multiple packets per queue being in flight at the same time. No functional changes yet. Fix some codestyle issues along the way. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 234

[Qemu-devel] [PATCH 32/37] ehci: update status bits in ehci_set_state

2012-06-07 Thread Gerd Hoffmann
Update the status register in the ehci_set_state function, to make sure the guest-visible register is in sync with our internal schedule state. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehc

[Qemu-devel] [PATCH 28/37] ehci: schedule async bh on async packet completion

2012-06-07 Thread Gerd Hoffmann
When a packet completes which happens to be part of the async schedule kick the async bottom half for processing, Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 16627d3..8b

[Qemu-devel] [PATCH 19/37] xhci: trace: slots

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 12 ++-- trace-events |6 ++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 7e823da..6c2ff02 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1750,8 +

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-06-07 Thread Alexander Graf
On 07.06.2012, at 05:10, Anthony Liguori wrote: > On 06/07/2012 06:56 AM, Paul Moore wrote: >> On Wednesday, June 06, 2012 01:56:52 AM Alexander Graf wrote: >>> The other one (FIPS) is basically a list of encryption algorithms that are >>> deemed OK and not crackable within seconds by anyone. >>>

[Qemu-devel] [PATCH 05/37] uhci: zap uhci_pre_save

2012-06-07 Thread Gerd Hoffmann
Cancel transactions before saving vmstate is pretty pointless and just causes disruptions. We need to cancel them before *loading* vmstate, but in that case uhci_reset() handles it already and no special action is needed. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |8 1 fil

Re: [Qemu-devel] [PATCH v11 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-06-07 Thread Juan Quintela
Orit Wasserman wrote: > On 06/01/2012 02:42 PM, Juan Quintela wrote: >> We are still not using this value, and we are sending it anyway (with a >> value of zero). What happens when we start using if for a checksum, and >> we migration to a new version that "expects" it to be valid? I would >> pr

Re: [Qemu-devel] [PATCH v11 2/9] Add migration capabilites

2012-06-07 Thread Juan Quintela
Orit Wasserman wrote: > On 06/01/2012 01:57 PM, Juan Quintela wrote: >> Orit Wasserman wrote: >>> Add migration capabiltes that can be queried by the management. >>> The managment can query the source QEMU and the destination QEMU in order to >>> verify both support some migration capability (cu

[Qemu-devel] [PATCH 30/37] ehci: fix reset

2012-06-07 Thread Gerd Hoffmann
Check for the reset bit first when processing USBCMD register writes. Also break out of the switch, there is no need to check the other bits. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/h

[Qemu-devel] [PATCH 16/37] xhci: trace: ring fetch

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 10 ++ trace-events |1 + 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 6890888..08fdf94 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -701,10 +701,8 @@

[Qemu-devel] [PATCH 04/37] uhci: fix trace format strings

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/trace-events b/trace-events index 560e57b..dd057bc 100644 --- a/trace-events +++ b/trace-events @@ -266,10 +266,10 @@ usb_uhci_frame_start(uint32_t num) "nr %d" usb_uhci_

[Qemu-devel] [PATCH 37/37] ehci: rework frame skipping

2012-06-07 Thread Gerd Hoffmann
Move the framecount check out of the loop and use the new ehci_update_frindex function to skip frames if needed. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 25 ++--- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-eh

[Qemu-devel] [PATCH 17/37] xhci: trace: endpoints

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 22 +- trace-events |5 + 2 files changed, 10 insertions(+), 17 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 08fdf94..c50e407 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@

[Qemu-devel] [PATCH 06/37] uhci: fix irq routing

2012-06-07 Thread Gerd Hoffmann
The multifunction ich9 ehci controller with uhci companions uses a different interrupt pin for each function. The three uhci devices get pins A, B and C, whereas ehci uses pin D. This way the guest can assign different IRQ lines to each controller. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-u

[Qemu-devel] [PATCH 11/37] usb-storage: migration support

2012-06-07 Thread Gerd Hoffmann
With all scsi migration support bits in place the final step is pretty simple ;) Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 5b9a286..097d7b

[Qemu-devel] [PATCH 09/37] usb-storage: add usb_msd_packet_complete()

2012-06-07 Thread Gerd Hoffmann
Factor out packet completion to a separate function which cares to get the MSDState->packet update right. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-

[Qemu-devel] [PATCH 22/37] ehci: cache USBDevice in EHCIQueue

2012-06-07 Thread Gerd Hoffmann
Keep a USBDevice pointer in EHCIQueue so we don't have to lookup the device on each usb packet submission. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-eh

[Qemu-devel] [PATCH 21/37] ehci: make ehci_execute work on EHCIPacket instead of EHCIQueue

2012-06-07 Thread Gerd Hoffmann
This way it is possible to use ehci_execute to submit others than the first EHCIPacket of the EHCIQueue. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 0

[Qemu-devel] [PATCH 24/37] ehci: add queuing support

2012-06-07 Thread Gerd Hoffmann
Add packet queuing. Follow the qTD chain to see if there are more packets we can submit. Improves performance on larger transfers, especially with usb-host, as we don't have to wait for a packet to finish before sending the next one to the host for processing. Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PATCH 07/37] scsi: prepare migration code for usb-storage support

2012-06-07 Thread Gerd Hoffmann
usb-storage can't handle requests in one go as the data transfer can be splitted into lots of usb packets. Because of that there can be normal in-flight requests at savevm time and we need to handle that. With other scsi hba's this happens only in case i/o is stopped due to errors and there are pe

[Qemu-devel] [PATCH 25/37] ehci: tweak queue initialization

2012-06-07 Thread Gerd Hoffmann
Little tweak for the queue initialization, set the QH address in the allocation function. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index ccaa947..aa67af6 100644 --- a/h

[Qemu-devel] [PATCH 12/37] xhci: Clean up reset function

2012-06-07 Thread Gerd Hoffmann
From: Jan Kiszka Properly register reset function via the device class. Signed-off-by: Jan Kiszka Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 5cf1a64..4bc1e0e 10

[Qemu-devel] [PATCH 35/37] ehci: create ehci_update_frindex

2012-06-07 Thread Gerd Hoffmann
Factor out code from ehci_frame_timer. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index ee7420f..c15dbee 100644 --- a/hw/usb/hcd-ehci.c +++ b

[Qemu-devel] [PATCH 31/37] ehci: add ehci_*_enabled() helpers

2012-06-07 Thread Gerd Hoffmann
Add helper functions to query whenever the async / periodic schedule is enabled or not. Put them into use too. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 27 +-- 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-eh

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Benjamin Herrenschmidt
On Thu, 2012-06-07 at 11:50 +0200, Hans de Goede wrote: > > In the meantime, this approach you experimented with would be very > > useful for us in the common case where there is no isochronous device. > > It shouldn't be too hard for the emulator to switch back to "normal" > > frames if an ISO EP

[Qemu-devel] [PULL 00/37] usb patch queue

2012-06-07 Thread Gerd Hoffmann
Hi, Here are a bunch of usb patches. There are four groups in there which are independant and have been posted as separate series for review ~ two weeks ago: (1) uhci: various little fixes and improvements. (2) usb-storage: live migration support. (3) xhci: tracing support. (4) ehci: p

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/31] dt: add helpers for 2, 3 and 4 cell adds

2012-06-07 Thread Alexander Graf
On 07.06.2012, at 01:45, David Gibson wrote: > [snip] >>> You mean internally? Yeah, probably. Externally? The point of these >>> helpers is to make the code look less cluttered. We can already pass in >>> an array just fine, but C is quite annoying about generating those on >>> the fly, while it

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-07 Thread Laszlo Ersek
On 06/06/12 22:09, Michael Roth wrote: > On Wed, Jun 06, 2012 at 06:49:19PM +0200, Laszlo Ersek wrote: >> The fallback (*v->type_int)() call stores an int64_t, according to its >> prototype ("interface contract"). IMHO it shouldn't try to communicate a >> mathematical value outside of [INT64_MIN,

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-07 Thread Laszlo Ersek
On 06/06/12 22:59, Andreas Färber wrote: > I've squashed the first three hunks on my qom-next-1 branch and am > listening what comes out of the discussion for the fourth one. I'm OK with dropping the fourth hunk, and thanks for squashing the first three already, because now I don't have to repost

[Qemu-devel] [PATCH 34/37] ehci: remove unused attach_poll_counter

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index f77a26d..ee7420f 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -415,7 +415,6 @@ struct EHCIState { */ QEM

[Qemu-devel] [PATCH 13/37] xhci: trace: mmio reads+writes

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 163 ++--- trace-events | 12 2 files changed, 117 insertions(+), 58 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 4bc1e0e..84d714a 100644 --- a/hw/usb/hcd-xh

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Gerd Hoffmann
Hi, >> In the meantime, this approach you experimented with would be very >> useful for us in the common case where there is no isochronous device. >> It shouldn't be too hard for the emulator to switch back to "normal" >> frames if an ISO EP is present, no ? > > That should be possible yes. N

[Qemu-devel] [PATCH 03/37] uhci: make bandwidth tunable

2012-06-07 Thread Gerd Hoffmann
Add a property for the uhci bandwidth. Can be used to make uhci emulation run faster than real hardware. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 91bcc7e..2e7c8f9

[Qemu-devel] [PATCH 27/37] ehci: move async schedule to bottom half

2012-06-07 Thread Gerd Hoffmann
This way we can kick the async schedule independant from the periodic frame timer. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index f363f14..16627d3 100644 --- a/hw/u

[Qemu-devel] [PATCH 01/37] uhci: fix bandwidth management

2012-06-07 Thread Gerd Hoffmann
uhci_process_frame() can be invoked multiple times per frame, so accounting usb bandwith in a local variable doesn't fly, use a variable in UHCIState instead. Also check the limit more frequently. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c | 22 -- trace-events

[Qemu-devel] [PATCH 36/37] ehci: adaptive wakeup rate.

2012-06-07 Thread Gerd Hoffmann
Adapt the frame timer sleeps according to the actual needs. With the periodic schedule being active we'll have to wakeup 1000 times per second and go check for work. In case only the async schedule is active we can be more lazy though. When idle ehci will increate the sleep time step by step, so

[Qemu-devel] [PATCH 18/37] xhci: trace: transfers

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 18 ++ trace-events |6 ++ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index c50e407..7e823da 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -14

[Qemu-devel] Fwd: buildbot failure in qemu on fedora-mingw32

2012-06-07 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on fedora-mingw32 Date: Thu, 07 Jun 2012 13:30:54 +0200 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot has detected a failed build on builder fedora-mingw32 while building qemu. Full details are avail

[Qemu-devel] [PATCH 29/37] ehci: kick async schedule on wakeup

2012-06-07 Thread Gerd Hoffmann
Kick async schedule when we get a wakeup notification from a usb device. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 8b2dfed..f8ed80d 100644 --- a/hw/usb/hcd-ehci.c +++ b/

[Qemu-devel] [PATCH 10/37] usb-storage: add scsi_off, remove scsi_buf

2012-06-07 Thread Gerd Hoffmann
Repace the running buffer pointer (scsi_buf) with a buffer offset field (scsi_off). The later is alot easier to live-migrate. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-s

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-07 Thread Anthony Liguori
On 06/07/2012 06:05 PM, Markus Armbruster wrote: [cc: Dan to give him a chance to correct whatever underinformed nonsense I might spout on libvirt] Don't see Dan on CC so I'll add him... Anthony Liguori writes: >> I think we have a different world view. I see 'qemu -machine foo' as creat

[Qemu-devel] [PATCH 23/37] ehci: move ehci_flush_qh

2012-06-07 Thread Gerd Hoffmann
Move ehci_flush_qh() function up in the source code. No code change. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 35 ++- 1 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index d7131bd..f21b4be 100644

[Qemu-devel] [PATCH 14/37] xhci: trace: run+stop

2012-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |5 ++--- trace-events |2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 84d714a..43875aa 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -813,14 +813,13 @@ st

Re: [Qemu-devel] Fwd: buildbot failure in qemu on fedora-mingw32

2012-06-07 Thread Anthony Liguori
Luiz/Wen Congyang: ^ Regards, Anthony Liguori On 06/07/2012 07:47 PM, Gerd Hoffmann wrote: Original Message Subject: buildbot failure in qemu on fedora-mingw32 Date: Thu, 07 Jun 2012 13:30:54 +0200 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot h

  1   2   3   >