[Qemu-devel] [PATCH] Fix build of kvm-all.c when no KVM_CAP_IRQ_ROUTING

2012-06-05 Thread Jens Freimann
In kvm-all.c an #ifdef KVM_CAP_IRQ_ROUTING was missing in two places which broke the build when this capability is not enabled. Found when building the s390-softmmu target. Signed-off-by: Jens Freimann --- kvm-all.c |4 1 file changed, 4 insertions(+) diff --git a/kvm-all.c b/kvm-all.c

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-06-05 Thread Gerd Hoffmann
Hi, >> Which gets me to a new idea. Why not exit(1) when we detect FIPS and a >> password is set? I agree with the assessment that we should never >> silently drop features. So the best way to make sure that the user >> knows he did something stupid (enable FIPS, but require a non-FIPS >> compli

[Qemu-devel] [PATCH] kvm: Fix build for non-CAP_IRQ_ROUTING targets

2012-06-05 Thread Jan Kiszka
On 2012-06-05 02:54, Andreas Färber wrote: > Am 05.06.2012 01:33, schrieb q...@buildbot.b1-systems.de: >> The Buildbot has detected a new failure on builder default_ppc while >> building qemu. >> Full details are available at: >> http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/417

Re: [Qemu-devel] buildbot failure in qemu on default_ppc

2012-06-05 Thread Jan Kiszka
On 2012-06-05 02:58, Anthony Liguori wrote: > On 06/05/2012 08:54 AM, Andreas Färber wrote: >> Am 05.06.2012 01:33, schrieb q...@buildbot.b1-systems.de: >>> The Buildbot has detected a new failure on builder default_ppc while >>> building qemu. >>> Full details are available at: >>> http://buildb

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:58 AM, Anthony Liguori wrote: > On 06/05/2012 08:52 AM, Andreas Färber wrote: >> Am 04.06.2012 07:46, schrieb Anthony Liguori: >>> On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>> >>> Pul

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Alexander Graf
On 05.06.2012, at 09:42, Avi Kivity wrote: > On 06/05/2012 04:58 AM, Anthony Liguori wrote: >> On 06/05/2012 08:52 AM, Andreas Färber wrote: >>> Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: > Please pull from: > >git://git.kernel.

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Jan Kiszka
On 2012-06-05 10:10, Alexander Graf wrote: > > > On 05.06.2012, at 09:42, Avi Kivity wrote: > >> On 06/05/2012 04:58 AM, Anthony Liguori wrote: >>> On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: > On 05/22/2012 12:37 AM, Avi Kivity wrote: >>

Re: [Qemu-devel] [RFC PATCH 1/5] notifiers: add support for async notifiers handlers

2012-06-05 Thread Gerd Hoffmann
Hi, > +static void notified_complete_cb(AsyncNotifier *notifier, void *opaque) > +{ There is no need to implement this as callback (unlike the notifier _list_ completion callback). Just have a public notifier_complete() function which async notifiers are supposed to call when done. > void no

Re: [Qemu-devel] [RFC PATCH 2/5] migration: moving migration start code to a separated routine

2012-06-05 Thread Gerd Hoffmann
Hi, > -static MigrationState *migrate_init(int blk, int inc) > +static MigrationState *migrate_init(int protocol, const char *protocol_param, > +int blk, int inc) > +s->protocol = protocol; > +s->protocol_param = g_strdup(protocol_param); Hmm, I thin

Re: [Qemu-devel] [RFC PATCH 3/5] migration: moving migration completion code to a separated routine

2012-06-05 Thread Gerd Hoffmann
> +bool start_vm_in_error; start_vm_on_error? cheers, Gerd

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Anthony Liguori
On 06/05/2012 03:42 PM, Avi Kivity wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm

Re: [Qemu-devel] qemu 1.1.0 says 1.1.50

2012-06-05 Thread Anthony Liguori
On 06/05/2012 02:15 PM, Dunrong Huang wrote: 2012/6/5 MATSUDA, Daiki: I tried qemu-1.1.0. But it says 1.1.50 and $ echo VERSION 1.1.50 Is it correct ? It's correct. Because v1.1 has released, v1.1.50 means it's a development branch for No, it's not correct, I messed up the tarball on the web

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 12:02 PM, Anthony Liguori wrote: > On 06/05/2012 03:42 PM, Avi Kivity wrote: >> On 06/05/2012 04:58 AM, Anthony Liguori wrote: >>> On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: > On 05/22/2012 12:37 AM, Avi Kivity wrote: >> Pl

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 03:00, schrieb Michael Roth: > This is an import of Anthony's qidl compiler, with some changes squashed > in to add support for doing the visitor generation via QEMU's qapi code > generators rather than directly. > > Documentation has been imported as well, as is also viewable at: >

Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 03:00, schrieb Michael Roth: > Define away the annotations so we can still compile. > > Signed-off-by: Michael Roth > --- > qapi/qc.h | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > create mode 100644 qapi/qc.h > > diff --git a/qapi/qc.h b/qapi/qc.h > ne

Re: [Qemu-devel] [PATCH 11/17] qapi: add qidl-generated qapi schema for rtc

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 03:00, schrieb Michael Roth: > Signed-off-by: Michael Roth > --- > qidl-generated/mc146818rtc.json |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > create mode 100644 qidl-generated/mc146818rtc.json I haven't looked at the Makefiles, but does this commit mean that th

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-06-05 Thread Amit Shah
On (Mon) 04 Jun 2012 [19:04:41], Anthony Liguori wrote: > On 05/26/2012 04:20 AM, Amit Shah wrote: > >On (Fri) 25 May 2012 [15:00:53], Anthony Liguori wrote: > >>On 05/25/2012 02:32 PM, Amit Shah wrote: > >>>The Linux kernel already has a virtio-rng driver, this is the device > >>>implementation. >

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Anthony Liguori
On 06/05/2012 05:25 PM, Kevin Wolf wrote: Am 05.06.2012 03:00, schrieb Michael Roth: This is an import of Anthony's qidl compiler, with some changes squashed in to add support for doing the visitor generation via QEMU's qapi code generators rather than directly. Documentation has been imported

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-06-05 Thread Anthony Liguori
On 06/05/2012 05:41 PM, Amit Shah wrote: On (Mon) 04 Jun 2012 [19:04:41], Anthony Liguori wrote: On 05/26/2012 04:20 AM, Amit Shah wrote: On (Fri) 25 May 2012 [15:00:53], Anthony Liguori wrote: On 05/25/2012 02:32 PM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Peter Maydell
On 5 June 2012 02:00, Michael Roth wrote: > +The first step is to move your device struct definition to a header file.   > This > +header file should only contain the struct definition and any preprocessor > +declarations you need to define the structure.  This header file will act as > +the sourc

Re: [Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible after start without media

2012-06-05 Thread Marcelo Tosatti
On Tue, Jun 05, 2012 at 08:23:53AM +0200, Markus Armbruster wrote: > Marcelo Tosatti writes: > > > On Thu, May 24, 2012 at 11:02:28AM +0200, Pavel Hrdina wrote: > >> If you start guest with floppy drive but without media inserted, guest > >> still should see floppy drive pressent. > >> > >> Sign

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:00 AM, Michael Roth wrote: > This is an import of Anthony's qidl compiler, with some changes squashed > in to add support for doing the visitor generation via QEMU's qapi code > generators rather than directly. > > Documentation has been imported as well, as is also viewable at: >

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Anthony Liguori
On 06/05/2012 06:00 PM, Peter Maydell wrote: On 5 June 2012 02:00, Michael Roth wrote: +The first step is to move your device struct definition to a header file. This +header file should only contain the struct definition and any preprocessor +declarations you need to define the structure. Th

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 11:47, schrieb Anthony Liguori: > On 06/05/2012 05:25 PM, Kevin Wolf wrote: >> Am 05.06.2012 03:00, schrieb Michael Roth: >>> This is an import of Anthony's qidl compiler, with some changes squashed >>> in to add support for doing the visitor generation via QEMU's qapi code >>> genera

Re: [Qemu-devel] [PATCH 11/17] qapi: add qidl-generated qapi schema for rtc

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:00 AM, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > qidl-generated/mc146818rtc.json |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > create mode 100644 qidl-generated/mc146818rtc.json > > diff --git a/qidl-generated/mc146818rtc.json b/qidl-generated/m

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-06-05 Thread Amit Shah
On (Tue) 05 Jun 2012 [17:54:30], Anthony Liguori wrote: > On 06/05/2012 05:41 PM, Amit Shah wrote: > >On (Mon) 04 Jun 2012 [19:04:41], Anthony Liguori wrote: > >>On 05/26/2012 04:20 AM, Amit Shah wrote: > >>>On (Fri) 25 May 2012 [15:00:53], Anthony Liguori wrote: > On 05/25/2012 02:32 PM, Amit

Re: [Qemu-devel] [PATCH] msix: Drop unused msix_bar_size

2012-06-05 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 04:56:01PM +0200, Jan Kiszka wrote: > No user in sight. > > Signed-off-by: Jan Kiszka Just to note, currently (since the memory API changes) all users assume a single 4K page for MSI-X, we will need some API to remove that assumption. Still the patch is fine. > --- > hw

Re: [Qemu-devel] [PATCH 09/17] rtc: add qc annotations

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:00 AM, Michael Roth wrote: > Add our annotations according to QIDL documentation. > > +qc_declaration typedef struct RTCState { > +ISADevice _immutable dev; > +MemoryRegion _immutable io; > uint8_t cmos_data[128]; > uint8_t cmos_index; > struct tm current_tm

Re: [Qemu-devel] [PATCH 16/17] qidl: add qidl-generated vmstate fields for rtc

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:00 AM, Michael Roth wrote: > Initial check-in of the qidl-generated vmstate fields for rtc. > Don't, please. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] msix: Drop unused msix_bar_size

2012-06-05 Thread Jan Kiszka
On 2012-06-05 12:20, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 04:56:01PM +0200, Jan Kiszka wrote: >> No user in sight. >> >> Signed-off-by: Jan Kiszka > > Just to note, currently (since the memory API changes) all users assume > a single 4K page for MSI-X, we will need some API to remo

Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions

2012-06-05 Thread Jan Kiszka
On 2012-06-05 03:00, Michael Roth wrote: > Define away the annotations so we can still compile. > > Signed-off-by: Michael Roth > --- > qapi/qc.h | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > create mode 100644 qapi/qc.h > > diff --git a/qapi/qc.h b/qapi/qc.h > new

Re: [Qemu-devel] [PATCH 09/17] rtc: add qc annotations

2012-06-05 Thread Jan Kiszka
On 2012-06-05 12:25, Avi Kivity wrote: > On 06/05/2012 04:00 AM, Michael Roth wrote: >> Add our annotations according to QIDL documentation. >> >> +qc_declaration typedef struct RTCState { >> +ISADevice _immutable dev; >> +MemoryRegion _immutable io; >> uint8_t cmos_data[128]; >>

Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions

2012-06-05 Thread Anthony Liguori
On 06/05/2012 06:35 PM, Jan Kiszka wrote: On 2012-06-05 03:00, Michael Roth wrote: Define away the annotations so we can still compile. Signed-off-by: Michael Roth --- qapi/qc.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) create mode 100644 qapi/qc.h diff --git a

Re: [Qemu-devel] [PATCH v2 00/41] postcopy live migration

2012-06-05 Thread Dor Laor
On 06/04/2012 04:38 PM, Isaku Yamahata wrote: On Mon, Jun 04, 2012 at 08:37:04PM +0800, Anthony Liguori wrote: On 06/04/2012 05:57 PM, Isaku Yamahata wrote: After the long time, we have v2. This is qemu part. The linux kernel part is sent separatedly. Changes v1 -> v2: - split up patches for

Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions

2012-06-05 Thread Jan Kiszka
On 2012-06-05 13:12, Anthony Liguori wrote: > On 06/05/2012 06:35 PM, Jan Kiszka wrote: >> On 2012-06-05 03:00, Michael Roth wrote: >>> Define away the annotations so we can still compile. >>> >>> Signed-off-by: Michael Roth >>> --- >>> qapi/qc.h | 11 +++ >>> 1 files changed, 11 inser

Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 13:26, schrieb Jan Kiszka: > On 2012-06-05 13:12, Anthony Liguori wrote: >> On 06/05/2012 06:35 PM, Jan Kiszka wrote: >>> On 2012-06-05 03:00, Michael Roth wrote: Define away the annotations so we can still compile. Signed-off-by: Michael Roth --- qapi/qc.h

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Anthony Liguori
On 06/05/2012 01:49 PM, Yonit Halperin wrote: Hi, I'm sending this patch series again. This time with an additional patch for setting a migrate_end notifier completion callback for spice migration interface. I've also added more detailed commit messages. This patch series introduces async handl

Re: [Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible after start without media

2012-06-05 Thread Markus Armbruster
Marcelo Tosatti writes: > On Tue, Jun 05, 2012 at 08:23:53AM +0200, Markus Armbruster wrote: >> Marcelo Tosatti writes: >> >> > On Thu, May 24, 2012 at 11:02:28AM +0200, Pavel Hrdina wrote: >> >> If you start guest with floppy drive but without media inserted, guest >> >> still should see flopp

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Gerd Hoffmann
Hi, > > > Suggestion: add a _guest marker for ordinary state. Fail the build on > unmarked fields. This ensures that some thought is given to each field, > instead of having a default that may be correct most of the time, but > not always. > > Suggestion: add a mandatory position hint (_gue

Re: [Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible after start without media

2012-06-05 Thread Pavel Hrdina
On 06/05/2012 02:05 PM, Markus Armbruster wrote: Marcelo Tosatti writes: On Tue, Jun 05, 2012 at 08:23:53AM +0200, Markus Armbruster wrote: Marcelo Tosatti writes: On Thu, May 24, 2012 at 11:02:28AM +0200, Pavel Hrdina wrote: If you start guest with floppy drive but without media inserted

Re: [Qemu-devel] [RFC PATCH v1 2/4] m25p80: initial verion

2012-06-05 Thread Andreas Färber
Am 05.06.2012 02:47, schrieb Peter Crosthwaite: > On Wed, Apr 4, 2012 at 10:53 PM, Andreas Färber wrote: >> Am 30.03.2012 08:37, schrieb Peter A. G. Crosthwaite: >>> Added device model for m25p80 SPI flash >>> >>> Signed-off-by: Peter A. G. Crosthwaite >>> --- >>> Makefile.target |1 + >>> h

Re: [Qemu-devel] [PATCH 09/17] rtc: add qc annotations

2012-06-05 Thread Avi Kivity
On 06/05/2012 01:40 PM, Jan Kiszka wrote: > On 2012-06-05 12:25, Avi Kivity wrote: >> On 06/05/2012 04:00 AM, Michael Roth wrote: >>> Add our annotations according to QIDL documentation. >>> >>> +qc_declaration typedef struct RTCState { >>> +ISADevice _immutable dev; >>> +MemoryRegion _immu

Re: [Qemu-devel] [PATCH 0/1] memory detection hack for s390

2012-06-05 Thread Alexander Graf
On 15.05.2012, at 14:49, Christian Borntraeger wrote: > Alex, > > here is a patch that uses the newly introduced KVM_CAP_S390_COW > to get rid of the s390 specific ifdef mess in the main path and > moves it into a separate function. > > This patch also contains a diff agains linux-headers. What

Re: [Qemu-devel] [PATCH 1/1] s390: autodetect map private

2012-06-05 Thread Alexander Graf
On 15.05.2012, at 14:49, Christian Borntraeger wrote: > From: Christian Borntraeger > > kvm on specific s390 systems must not use MAP_PRIVATE since > host read-only page faults are delivered to the guest. Newer > systems allow the distinction via KVM_CAP_S390_COW > > Signed-off-by: Christian B

[Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-05 Thread Markus Armbruster
First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. Get the filename from disk->opts instead. Same result, except for snapshots: there, we now get the filename specified by the user instead of the name of the temporary image created by bdrv_open(). Should be an improvement. Seco

[Qemu-devel] [PATCH 0/2] xen: Clean up BlockDriverState use

2012-06-05 Thread Markus Armbruster
Compile tested only. Stefano, please give it a whirl. Markus Armbruster (2): xen: Don't change -drive if=xen device name during machine init xen: Don't peek behind the BlockDriverState abstraction hw/xen_devconfig.c | 13 ++--- hw/xen_disk.c |5 +++-- 2 files changed, 9 i

[Qemu-devel] [PATCH 1/2] xen: Don't change -drive if=xen device name during machine init

2012-06-05 Thread Markus Armbruster
A "top" BlockDriverState has a non-empty device_name. If the user doesn't specify one with -drive parameter id, the system supplies a default name. xen_config_dev_blk() changes this name, during machine initialization. Naughty. Don't do that. Signed-off-by: Markus Armbruster --- hw/xen_devcon

[Qemu-devel] [PATCH] block: Simplify how drive_init() computes default ID

2012-06-05 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- blockdev.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 67895b2..1cafd70 100644 --- a/blockdev.c +++ b/blockdev.c @@ -278,7 +278,6 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) {

Re: [Qemu-devel] [PATCH] block: Simplify how drive_init() computes default ID

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 14:52, schrieb Markus Armbruster: > Signed-off-by: Markus Armbruster Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] The development tree is now open!

2012-06-05 Thread Avi Kivity
On 06/03/2012 08:05 PM, Jan Kiszka wrote: > On 2012-06-02 11:53, Anthony Liguori wrote: >> Let your PATCHes, PULLs, RFCs, and RFTs start flowing. I'll start >> applying pull requests on Monday or perhaps earlier if I can find the time. >> >> For submaintainers, if you have a very large queue (> 5

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Gerd Hoffmann
Hi, > Absolutely not. This is hideously ugly and affects a bunch of code. > > Spice is *not* getting a hook in migration where it gets to add > arbitrary amounts of downtime to the migration traffic. That's a > terrible idea. > > I'd like to be more constructive in my response, but you aren'

Re: [Qemu-devel] The development tree is now open!

2012-06-05 Thread Jan Kiszka
On 2012-06-05 15:07, Avi Kivity wrote: > On 06/03/2012 08:05 PM, Jan Kiszka wrote: >> On 2012-06-02 11:53, Anthony Liguori wrote: >>> Let your PATCHes, PULLs, RFCs, and RFTs start flowing. I'll start >>> applying pull requests on Monday or perhaps earlier if I can find the time. >>> >>> For submai

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Eric Blake
On 06/05/2012 07:15 AM, Gerd Hoffmann wrote: > Hi, > >> Absolutely not. This is hideously ugly and affects a bunch of code. >> >> Spice is *not* getting a hook in migration where it gets to add >> arbitrary amounts of downtime to the migration traffic. That's a >> terrible idea. >> > So, the

[Qemu-devel] [PATCH] fdc: fix media change detection for windows

2012-06-05 Thread Pavel Hrdina
The windows uses 'READ' command at the start of instalation. We have to also check the 'media_change' bit in the 'fd_seek'. Signed-off-by: Pavel Hrdina --- hw/fdc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 30d34e3..70b0c00 100644 --- a/

Re: [Qemu-devel] [PATCH] fdc: fix media change detection for windows

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 15:48, schrieb Pavel Hrdina: > The windows uses 'READ' command at the start of instalation. We have to > also check the 'media_change' bit in the 'fd_seek'. > > Signed-off-by: Pavel Hrdina Can you explain the scenario in more detail? What is Windows trying and why should it fail? W

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-05 Thread Paolo Bonzini
Il 04/06/2012 20:58, Eric Blake ha scritto: > On 06/04/2012 12:52 PM, Lluís Vilanova wrote: > > As before, I dislike the use of the filename "Makefile" for files that > are not self-contained. If make is called from that deep directory, it > leads to undefined results. > >> >> Naming

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/25] dt: add helper for empty dt creation

2012-06-05 Thread Alexander Graf
On 31.05.2012, at 12:55, David Gibson wrote: > On Wed, May 30, 2012 at 01:00:27PM +0200, Alexander Graf wrote: >> We want to get rid of the concept of loading an external device tree and >> instead >> generate our own. However, to do this we need to also create a device tree >> template programa

Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions

2012-06-05 Thread Paolo Bonzini
Il 05/06/2012 03:00, Michael Roth ha scritto: > Signed-off-by: Michael Roth > --- > qapi/qc.h | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > create mode 100644 qapi/qc.h > > diff --git a/qapi/qc.h b/qapi/qc.h > new file mode 100644 > index 000..3b3a8b9 > --- /dev/

Re: [Qemu-devel] [PATCH 12/17] rtc: add a QOM property for accessing device state

2012-06-05 Thread Paolo Bonzini
Il 05/06/2012 03:00, Michael Roth ha scritto: > This will eventually be used to serialize device state for the purposes > of migration/savevm, and is also useful for introspection/testing. > > Signed-off-by: Michael Roth > --- > hw/mc146818rtc.c | 12 > 1 files changed, 12 inserti

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-05 Thread Amos Kong
- Original Message - > On 06/02/2012 06:54 AM, Amos Kong wrote: > > Signed-off-by: Amos Kong > > I think QERR_INVALID_PARAMETER_VALUE is a more logical choice for the > error > you're generating. I used this new error in [PATCH 6/6], if user inputs more than 16 keys once, this error will

Re: [Qemu-devel] [PATCH] fdc: fix media change detection for windows

2012-06-05 Thread Pavel Hrdina
On 06/05/2012 04:02 PM, Kevin Wolf wrote: Am 05.06.2012 15:48, schrieb Pavel Hrdina: The windows uses 'READ' command at the start of instalation. We have to also check the 'media_change' bit in the 'fd_seek'. Signed-off-by: Pavel Hrdina Can you explain the scenario in more detail? What is Wind

[Qemu-devel] [PATCH 0/2] scsi: Clean up BlockDriverState use

2012-06-05 Thread Markus Armbruster
With this and the related fix for xen applied, block_int.h is finally gone from hw/. Markus Armbruster (2): block: New bdrv_get_flags() scsi-disk: Don't peek behind the BlockDriverState abstraction block.c|5 + block.h|1 + hw/scsi-disk.c |3 +-- 3 files chang

[Qemu-devel] [PATCH 1/2] block: New bdrv_get_flags()

2012-06-05 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c |5 + block.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 7547051..9a50843 100644 --- a/block.c +++ b/block.c @@ -2466,6 +2466,11 @@ const char *bdrv_get_device_name(BlockDriverState *bs)

[Qemu-devel] [PATCH 2/2] scsi-disk: Don't peek behind the BlockDriverState abstraction

2012-06-05 Thread Markus Armbruster
Use the appropriate interface instead. Signed-off-by: Markus Armbruster --- hw/scsi-disk.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 045c764..1bfefb2 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -34,7 +34,6 @@ do { pri

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

2012-06-05 Thread Amos Kong
Hello Eric, Thanks for your comments. - Original Message - > On 06/01/2012 04:54 PM, Amos Kong wrote: > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > variables/functions in monitor.c, so reserve qmp_sendkey() > > to monitor.c > > > > key_defs[] in monitor.c is the ma

Re: [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum

2012-06-05 Thread Amos Kong
- Original Message - > Currently, if define an 'enum' and use it in one command's data, > List struct for enum could not be generated, but it's used in > qmp function. > > For example: KeyCodesList could not be generated. > >>> qapi-schema.json: > { 'enum': 'KeyCodes', > 'data': [ 'shift

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

2012-06-05 Thread Eric Blake
On 06/05/2012 08:55 AM, Amos Kong wrote: >>> +# @sendkey: >>> +# >>> +# Send keys to VM. >>> +# >>> +# @keys: key sequence >>> +# @hold-time: time to delay key up events, milliseconds >>> +# >>> +# Returns: Nothing on success >>> +# If key is unknown or redundant, QERR_INVALID_PARAMETER >

[Qemu-devel] [qemu-devel][RFC] Enable usb in the default configuration

2012-06-05 Thread Li Zhang
Hi all, For pseries, when creating VMs with default configuration, it requires usb mouse and usb kbd devices to be added. But in the default configuration of qemu, usb is disabled. So we when use the default configuration as the following command: $qemu -M pseries vga is enabled, but usb mouse

[Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-05 Thread Li Zhang
Hi all, For pseries, when creating VMs with "-vga std", it requires usb mouse and usb kbd devices to be added. But with default options, vga is enabled and usb is disabled. User may use default options as the following commands: $qemu -M pseries If vga is enabled, usb mouse and usb kbd is disa

Re: [Qemu-devel] [RFC PATCH 1/2] ivring: Add a ring-buffer driver on IVShmem

2012-06-05 Thread Borislav Petkov
On Tue, Jun 05, 2012 at 10:01:17PM +0900, Yoshihiro YUNOMAE wrote: > This patch adds a ring-buffer driver for IVShmem device, a virtual RAM device > in > QEMU. This driver can be used as a ring-buffer for kernel logging or tracing > of > a guest OS by recording kernel programing or SystemTap. >

[Qemu-devel] [PATCH v2] fdc: fix media change detection for windows

2012-06-05 Thread Pavel Hrdina
The Windows uses 'READ' command at the start of an instalation without checking the 'dir' register. We have to abort the transfer with an abnormal termination if there is no media in the drive. We have to also check the 'media_change' bit in the 'fd_seek'. This internal seek clears the 'media_chan

Re: [Qemu-devel] [PATCH v2] fdc: fix media change detection for windows

2012-06-05 Thread Pavel Hrdina
Sorry, I forget the qtest. I'll create it and send it again. Pavel On 06/05/2012 05:46 PM, Pavel Hrdina wrote: The Windows uses 'READ' command at the start of an instalation without checking the 'dir' register. We have to abort the transfer with an abnormal termination if there is no media in t

Re: [Qemu-devel] [PATCH v2] fdc: fix media change detection for windows

2012-06-05 Thread Kevin Wolf
Am 05.06.2012 17:50, schrieb Pavel Hrdina: > Sorry, I forget the qtest. I'll create it and send it again. > > Pavel > > On 06/05/2012 05:46 PM, Pavel Hrdina wrote: >> The Windows uses 'READ' command at the start of an instalation >> without checking the 'dir' register. We have to abort the transf

[Qemu-devel] [RFC PATCH 0/2] ivring: Add IVRing driver

2012-06-05 Thread Yoshihiro YUNOMAE
Hi All, The following patch set provides a new communication path "IVRing" for collecting kernel log or tracing data of guests by a host without using network in a virtualization environment. Network is generally used to collect log or tracing data after outputting the data as a file. However, sin

Re: [Qemu-devel] [PATCH 11/17] qapi: add qidl-generated qapi schema for rtc

2012-06-05 Thread Michael Roth
On Tue, Jun 05, 2012 at 11:29:24AM +0200, Kevin Wolf wrote: > Am 05.06.2012 03:00, schrieb Michael Roth: > > Signed-off-by: Michael Roth > > --- > > qidl-generated/mc146818rtc.json |1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > create mode 100644 qidl-generated/mc146818rtc.js

[Qemu-devel] [PATCH] seabios: correct setting of datalow_base for large rom images

2012-06-05 Thread Jason Baron
I've been creating 256kb rom images with larger acpi tables for second level buses. After a recent re-base, my rom images no longer built. Bisected to: commit 46b82624c95b951e8825fab117d9352faeae0ec8 Author: Kevin O'Connor Date: Sun May 13 12:10:30 2012 -0400 Add mechanism to declare varia

[Qemu-devel] [RFC PATCH 2/2] ivring: Add a ring-buffer reader tool

2012-06-05 Thread Yoshihiro YUNOMAE
This patch adds a reader tool for IVRing. This tool is used on a host OS and reads data written by a guest. This reader reads data from a ring-buffer via POSIX share memory, so the data will be read without memory copying between a guest and a host. To read data written by a guest, s option assigni

[Qemu-devel] [RFC PATCH 1/2] ivring: Add a ring-buffer driver on IVShmem

2012-06-05 Thread Yoshihiro YUNOMAE
This patch adds a ring-buffer driver for IVShmem device, a virtual RAM device in QEMU. This driver can be used as a ring-buffer for kernel logging or tracing of a guest OS by recording kernel programing or SystemTap. This ring-buffer driver is implemented very simple. First 4kB of shared memory re

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-05 Thread Michael Roth
On Tue, Jun 05, 2012 at 11:25:01AM +0200, Kevin Wolf wrote: > Am 05.06.2012 03:00, schrieb Michael Roth: > > This is an import of Anthony's qidl compiler, with some changes squashed > > in to add support for doing the visitor generation via QEMU's qapi code > > generators rather than directly. > >

Re: [Qemu-devel] [RFC PATCH 1/2] ivring: Add a ring-buffer driver on IVShmem

2012-06-05 Thread Yoshihiro YUNOMAE
(2012/06/05 22:10), Borislav Petkov wrote: On Tue, Jun 05, 2012 at 10:01:17PM +0900, Yoshihiro YUNOMAE wrote: This patch adds a ring-buffer driver for IVShmem device, a virtual RAM device in QEMU. This driver can be used as a ring-buffer for kernel logging or tracing of a guest OS by recording k

[Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-05 Thread li zhang
Hi all, For pseries, when creating VMs with "-vga std", it requires usb mouse and usb kbd devices to be added. But with default options, vga is enabled and usb is disabled. User may use default options as the following commands: $qemu -M pseries If vga is enabled, usb mouse and usb kbd is disab

[Qemu-devel] KVM on Fedora 16(X64) cost too much memory

2012-06-05 Thread mzawdx wang
Hi all: I have a PC Workstation(8G memory) which installed Fedora 16(X64). I start a vm by the command "qemu-kvm -m 1024 -hda winxp.qcow2 -net nit -net tap .", and it started successfully. After normally running a few days, I found that the memory cost of my PC Workstation increased day by d

Re: [Qemu-devel] [PATCH v2] fdc: fix media change detection for windows

2012-06-05 Thread Pavel Hrdina
On 06/05/2012 05:56 PM, Kevin Wolf wrote: Am 05.06.2012 17:50, schrieb Pavel Hrdina: Sorry, I forget the qtest. I'll create it and send it again. Pavel On 06/05/2012 05:46 PM, Pavel Hrdina wrote: The Windows uses 'READ' command at the start of an instalation without checking the 'dir' registe

[Qemu-devel] test

2012-06-05 Thread Li Zhang
I can't send out my mail. -- Best Regards Li IBM LTC, China System&Technology Lab, Beijing

[Qemu-devel] [RFC PATCH 1/2] ivring: Add a ring-buffer driver on IVShmem

2012-06-05 Thread Yoshihiro YUNOMAE
This patch adds a ring-buffer driver for IVShmem device, a virtual RAM device in QEMU. This driver can be used as a ring-buffer for kernel logging or tracing of a guest OS by recording kernel programing or SystemTap. This ring-buffer driver is implemented very simple. First 4kB of shared memory re

Re: [Qemu-devel] [PATCH v4 0/7] trace: Generic event state description

2012-06-05 Thread Lluís Vilanova
Lluís Vilanova writes: > Provides a generic event state description and a more detailed event control > and > query interface. > Signed-off-by: Lluís Vilanova > --- ping > Changes in v4: > * Documentation fixes and (re)formatting. > Changes in v3: > * Add some assertions. > * Remove debu

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-05 Thread Stefano Stabellini
On Tue, 5 Jun 2012, Markus Armbruster wrote: > First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. > Get the filename from disk->opts instead. Same result, except for > snapshots: there, we now get the filename specified by the user > instead of the name of the temporary image cr

[Qemu-devel] [PULL 00/29]: QMP queue

2012-06-05 Thread Luiz Capitulino
Contains the new commands dump-guest-memory and query-events; and the netdev_add/netdev_del conversion to the QAPI. The changes (since 8cc9b43f7c5f826b39af4b012ad89bb55faac29c) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Daniel P. Berrange (1):

[Qemu-devel] [PATCH 02/29] Add API to check whether a physical address is I/O address

2012-06-05 Thread Luiz Capitulino
From: Wen Congyang This API will be used in the following patch. Signed-off-by: Wen Congyang Signed-off-by: Luiz Capitulino --- cpu-common.h | 4 exec.c | 12 2 files changed, 16 insertions(+) diff --git a/cpu-common.h b/cpu-common.h index dca5175..1fe3280 100644 ---

[Qemu-devel] [PATCH 01/29] Add API to create memory mapping list

2012-06-05 Thread Luiz Capitulino
From: Wen Congyang The memory mapping list stores virtual address and physical address mapping. The virtual address and physical address are contiguous in the mapping. The folloing patch will use this information to create PT_LOAD in the vmcore. Signed-off-by: Wen Congyang Signed-off-by: Luiz C

[Qemu-devel] [PATCH 20/29] qemu-option: introduce qemu_opt_set_err()

2012-06-05 Thread Luiz Capitulino
This is like qemu_opt_set(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_opt_set(). Signed-off-by: Luiz Capitulino Reviewed-By: Laszlo Ersek --- qemu-option.c | 6 ++ qemu-option.h | 2 ++ 2 files changed, 8 insertions(+)

[Qemu-devel] [PATCH 04/29] Add API to check whether paging mode is enabled

2012-06-05 Thread Luiz Capitulino
From: Wen Congyang This API will be used in the following patch. Signed-off-by: Wen Congyang Signed-off-by: Luiz Capitulino --- cpu-all.h | 6 ++ target-i386/arch_memory_mapping.c | 7 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/cpu-all.h

[Qemu-devel] [PATCH 29/29] Add 'query-events' command to QMP to query async events

2012-06-05 Thread Luiz Capitulino
From: "Daniel P. Berrange" Sometimes it is neccessary for an application to determine whether a particular QMP event is available, so they can decide whether to use compatibility code instead. This introduces a new 'query-events' command to QMP to do just that { "execute": "query-events" } {"r

Re: [Qemu-devel] [PATCH 12/17] rtc: add a QOM property for accessing device state

2012-06-05 Thread Michael Roth
On Tue, Jun 05, 2012 at 04:14:44PM +0200, Paolo Bonzini wrote: > Il 05/06/2012 03:00, Michael Roth ha scritto: > > This will eventually be used to serialize device state for the purposes > > of migration/savevm, and is also useful for introspection/testing. > > > > Signed-off-by: Michael Roth > >

[Qemu-devel] [PATCH 28/29] qapi: convert netdev_del

2012-06-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino Reviewed-By: Laszlo Ersek --- hmp-commands.hx | 3 +-- hmp.c| 9 + hmp.h| 1 + net.c| 11 +-- net.h| 1 - qapi-schema.json | 14 ++ qmp-commands.hx |

[Qemu-devel] [PATCH 27/29] qapi: convert netdev_add

2012-06-05 Thread Luiz Capitulino
This is not a full QAPI conversion, but an intermediate step. In essence, do_netdev_add() is split into three functions: 1. netdev_add(): performs the actual work. This function is fully converted to Error (thus, it's "qapi-friendly") 2. qmp_netdev_add(): the QMP front-end for netdev_add()

[Qemu-devel] [PATCH 22/29] qerror: introduce QERR_INVALID_OPTION_GROUP

2012-06-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino Reviewed-By: Laszlo Ersek --- qerror.c | 4 qerror.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 5092fe7..92c4eff 100644 --- a/qerror.c +++ b/qerror.c @@ -156,6 +156,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 15/29] qemu-option: parse_option_bool(): use error_set()

2012-06-05 Thread Luiz Capitulino
Note that set_option_parameter() callers still expect automatic error reporting with QError, so set_option_parameter() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino Reviewed-By: Laszlo Ersek --- qemu-option.c | 24 1 file changed,

[Qemu-devel] [PATCH] KVM: Fix compiles when KVM_CAP_IRQ_ROUTING is not defined

2012-06-05 Thread Ben Collins
Things like kroute and direct_msi were not protected by ifdef's for when this feature is not enabled. Also, virtio-pci was referencing kvm_irqchip_release_virq() which was not defined without KVM_CAP_IRQ_ROUTING but when KVM was enabled. Signed-off-by: Ben Collins Cc: Avi Kivity Cc: Marcelo Tosa

[Qemu-devel] [PATCH] PPC: mpc8544ds: Fix typo in init of second serial device

2012-06-05 Thread Ben Collins
The reference to serial_hds[0] should be serial_hds[1] when initializing the second serial line. Signed-off-by: Ben Collins Cc: Alexander Graf --- hw/ppce500_mpc8544ds.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index

  1   2   3   >