Re: [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC device, then force the use of sg. We dont have any medium changer emulation so only passthrough via real sg or scsi-generic via iscsi

2012-05-26 Thread Paolo Bonzini
Il 26/05/2012 06:56, Ronnie Sahlberg ha scritto: > Forcing sg also makes qemu skip trying to read from the device to guess the > image format by reading from the device (find_image_format()). > SMC devices do not implement READ6/10/12/16 so it is noit possible to read > from them. > > With this

Re: [Qemu-devel] [PATCH 0/4] ISCSI: Passthough updates

2012-05-26 Thread Paolo Bonzini
Il 26/05/2012 06:56, Ronnie Sahlberg ha scritto: > Paolo, list > > Please find a set of patches for iscsi. > > 1, The recent change to the eventsystem in iscsi is racy. If the > async connect of the socket takes longer than almost instant, the > shortcircuit trying to write directly to the socket

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread Paolo Bonzini
Il 26/05/2012 07:41, ronnie sahlberg ha scritto: > Paolo, > > You need this patch too since without it it might crash. > > commit 6e46eb1846a862dad253be1a576f8554071b154a > Author: Ronnie Sahlberg > Date: Sat May 26 10:28:05 2012 +1000 > > ISCSI: We can only do the shortcircuit and write

Re: [Qemu-devel] [PATCH] SCSI: Add SCSI passthrough via scsi-generic to libiscsi

2012-05-26 Thread Paolo Bonzini
Il 25/05/2012 13:59, Ronnie Sahlberg ha scritto: > Update iscsi to allow passthrough of SG_IO scsi commands when the iscsi > device is forced to be scsi-generic. > > Implement both bdrv_ioctl() and bdrv_aio_ioctl() in the iscsi backend, > emulate the SG_IO ioctl and pass the SCSI commands across t

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread ronnie sahlberg
Almost, but connecter=1 should be set after the if statement not inside it. if (status != 0) { +itask->iscsilun->connected = 1; itask->status = 1; I.e. dont set it in the error path, set it after the block. then it should be all good. optionally you can revert 5b5e96bba

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread ronnie sahlberg
Im compiling your branch now and will verify all is good. It is missing an include so you need to add this patch to compile : On Sat, May 26, 2012 at 5:59 PM, ronnie sahlberg wrote: > Almost, > but connecter=1 should be set after the if statement not inside it. > >     if (status != 0) { > +

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread ronnie sahlberg
I have compiled your branch and run through some tests. It all looks good as long as you apply the patch to #include "hw/scsi-defs.h" On Sat, May 26, 2012 at 6:17 PM, ronnie sahlberg wrote: > Im compiling your branch now and will verify all is good. > > It is missing an include  so you need to

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-26 Thread Peter Maydell
On 25 May 2012 23:13, Ira Ray Jenkins wrote: > I found a GSOC11 project that attempted to port the Android "Goldfish" > platform to mainline QEMU. Was this project successful, or is this > currently being worked on? The project resulted in a very basic prototype and a better understanding of what

Re: [Qemu-devel] [PATCH 03/10] qom: push error reporting to object_property_find

2012-05-26 Thread Paolo Bonzini
Il 25/05/2012 18:05, Andreas Färber ha scritto: >> > @@ -698,10 +702,8 @@ void object_property_del(Object *obj, const char >> > *name, Error **errp) >> > void object_property_get(Object *obj, Visitor *v, const char *name, >> > Error **errp) >> > { >> > -ObjectProper

Re: [Qemu-devel] [PATCH v4 16/16] hub: add the support for hub own flow control

2012-05-26 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 8:13 PM, Stefan Hajnoczi wrote: > On Fri, May 25, 2012 at 06:52:14PM +0800, zwu.ker...@gmail.com wrote: >> @@ -59,16 +60,16 @@ static ssize_t net_hub_receive_iov(NetHub *hub, >> NetHubPort *source_port, >>                                     const struct iovec *iov, int io

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-26 Thread Andreas Färber
Am 26.05.2012 07:55, schrieb 陳韋任: > On Fri, May 25, 2012 at 06:13:25PM -0400, Ira Ray Jenkins wrote: >> I found a GSOC11 project that attempted to port the Android "Goldfish" >> platform to mainline QEMU. Was this project successful, or is this >> currently being worked on? > > The author sent t

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-26 Thread 陳韋任
On Sat, May 26, 2012 at 02:51:29PM +0200, Andreas Färber wrote: > Am 26.05.2012 07:55, schrieb 陳韋任: > > On Fri, May 25, 2012 at 06:13:25PM -0400, Ira Ray Jenkins wrote: > >> I found a GSOC11 project that attempted to port the Android "Goldfish" > >> platform to mainline QEMU. Was this project succe

[Qemu-devel] [RFC prep-next 0/2] prep_pci: Prepare for QOM realize

2012-05-26 Thread Andreas Färber
Hello, This mini-series, based on master, starts fixing issues in the way of calling recursive object_realize() at machine-level (vl.c). Patch 1 is a cherry-pick from Anthony's / Wan Peng's i440fx series, fixing Coding Style issues and dropping parts dependent on MemoryRegion QOM'ification. Patc

[Qemu-devel] [RFC prep-next 1/2] pci-host: Turn into SysBus-derived QOM type

2012-05-26 Thread Andreas Färber
Allows us to access PCIHostState QOM-style with PCI_HOST() macro. Update PReP Raven PCI to derive from this type. Signed-off-by: Anthony Liguori Signed-off-by: Wanpeng Li Signed-off-by: Andreas Färber --- hw/pci_host.c | 11 +++ hw/pci_host.h |3 +++ hw/prep_pci.c |4 ++-- 3

[Qemu-devel] [RFC prep-next 2/2] prep_pci: Create PCIBus and PCIDevice in-place

2012-05-26 Thread Andreas Färber
Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/prep_pci.c | 58 +--- 1 files changed, 42 insertions(+), 16 deletions(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index 3e9f6b8..c7540fb 100644 --- a/hw/prep_pci.c +++ b/hw/pre

Re: [Qemu-devel] [PATCH 03/10] qom: push error reporting to object_property_find

2012-05-26 Thread Andreas Färber
Am 26.05.2012 11:58, schrieb Paolo Bonzini: > Il 25/05/2012 18:05, Andreas Färber ha scritto: @@ -698,10 +702,8 @@ void object_property_del(Object *obj, const char *name, Error **errp) void object_property_get(Object *obj, Visitor *v, const char *name,

[Qemu-devel] [PATCH qom-next] qom: Introduce object_property_is_{child, link}()

2012-05-26 Thread Andreas Färber
Avoids hardcoding partial string comparisons. Signed-off-by: Alexander Barabash Signed-off-by: Andreas Färber --- qom/object.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/qom/object.c b/qom/object.c index 173835b..00bb3b0 100644 --- a/qom/objec

[Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-26 Thread Andreas Färber
Dependency files qom/*.d were not included by Makefile, causing changes in object.h (e.g., changes to struct Object) not to propagate to qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list. libuser/qom/cpu.o was unaffected since Makefile.user includes */*.d. Signed-off-by: Andr

Re: [Qemu-devel] [PATCH] fix multiboot loading if load_end_addr == 0

2012-05-26 Thread Anthony Liguori
On 05/26/2012 05:17 PM, Kevin Wolf wrote: Am Montag, 26. März 2012 21:27:00 schrieb Scott Moser: The previous multiboot load code did not treat the case where load_end_addr was 0 specially. The multiboot specification says the following: * load_end_addr Contains the physical address of th

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-26 Thread Andreas Färber
Am 27.05.2012 02:29, schrieb Andreas Färber: > Dependency files qom/*.d were not included by Makefile, causing changes > in object.h (e.g., changes to struct Object) not to propagate to > qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list. > > libuser/qom/cpu.o was unaffected s

[Qemu-devel] Adjustments to the QEMU 1.1-rc4 schedule

2012-05-26 Thread Anthony Liguori
Hi, Due to the US holiday on Monday and some travel I'm doing, I'm going to move the tagging of 1.1-rc4 to Tuesday the 29th. The 1.1 release will still be on Friday, June 1st. Please have all PULL requests for 1.1 sent by Monday the 28th. For any pending patches, make sure that I have eith

[Qemu-devel] [PATCH v2 00/17] Qemu Openrisc support

2012-05-26 Thread Jia Liu
This is the Opencores Openrisc 1200 support for Qemu. Full implementation of the system-model and linux-user-model support. Openrisc 1200 is a Opencores Open Source CPU, its Architecture Manual can be find at http://opencores.org/svnget,or1k?file=/trunk/docs/openrisc_arch.pdf --- Thank you all fo

[Qemu-devel] [PATCH v2 01/17] Openrisc: add target stubs

2012-05-26 Thread Jia Liu
add openrisc target stubs. Signed-off-by: Jia Liu --- Makefile.target |3 + arch_init.c |2 + arch_init.h |1 + configure| 10 ++- cpu-exec.c |2 + default-configs/or32-soft

[Qemu-devel] [PATCH v2 02/17] Openrisc: add cpu QOM implement

2012-05-26 Thread Jia Liu
add openrisc QOM cpu implement. Signed-off-by: Jia Liu --- Makefile.target |2 + hw/openrisc_cpudev.h | 29 hw/openrisc_pic.c| 28 target-openrisc/cpu.c| 110 ++ target-openrisc/cpu.h| 2

[Qemu-devel] [PATCH v2 04/17] Openrisc: add MMU support

2012-05-26 Thread Jia Liu
add openrisc MMU support. Signed-off-by: Jia Liu --- target-openrisc/cpu.h| 82 - target-openrisc/mmu.c| 199 +- target-openrisc/mmu_helper.c | 20 + 3 files changed, 298 insertions(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 06/17] Openrisc: add exception support

2012-05-26 Thread Jia Liu
add openrisc exception support. Signed-off-by: Jia Liu --- Makefile.target |3 ++- target-openrisc/excp.c| 27 +++ target-openrisc/excp.h| 28 target-openrisc/excp_helper.c | 27 +

[Qemu-devel] [PATCH v2 09/17] Openrisc: add instruction translation routines

2012-05-26 Thread Jia Liu
add openrisc instruction translation routines. Signed-off-by: Jia Liu --- target-openrisc/translate.c | 1421 +++ 1 file changed, 1421 insertions(+) diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c index 5bbad9e..965fa0e 100644 --- a

[Qemu-devel] [PATCH v2 11/17] Openrisc: add a timer

2012-05-26 Thread Jia Liu
add a timer for openrisc. Signed-off-by: Jia Liu --- Makefile.target |1 + cpu-exec.c|4 ++ hw/openrisc_timer.c | 153 + target-openrisc/cpu.h | 20 ++- 4 files changed, 177 insertions(+), 1 deletion(-) create mo

[Qemu-devel] [PATCH v2 12/17] Openrisc: add a simulator board

2012-05-26 Thread Jia Liu
add a simulator board implement for openrisc. Signed-off-by: Jia Liu --- Makefile.target |1 + hw/openrisc_sim.c | 145 + 2 files changed, 146 insertions(+) create mode 100644 hw/openrisc_sim.c diff --git a/Makefile.target b/Makefile.t

[Qemu-devel] [PATCH v2 16/17] Openrisc: add linux user support

2012-05-26 Thread Jia Liu
add linux user support for openrisc. Signed-off-by: Jia Liu --- configure |1 + default-configs/or32-linux-user.mak |2 + linux-user/elfload.c| 41 +++ linux-user/main.c | 100 +++ linux-user/signal.c

[Qemu-devel] [PATCH v2 17/17] Openrisc: add testcases

2012-05-26 Thread Jia Liu
add testcases for openrisc. Signed-off-by: Jia Liu --- tests/tcg/openrisc/Makefile | 73 tests/tcg/openrisc/test_add.c| 34 + tests/tcg/openrisc/test_addc.c | 37 ++ tests/tcg/openrisc/test_addi.c | 31 tests/

Re: [Qemu-devel] [PATCH] fix multiboot loading if load_end_addr == 0

2012-05-26 Thread Kevin Wolf
Am Montag, 26. März 2012 21:27:00 schrieb Scott Moser: > The previous multiboot load code did not treat the case where > load_end_addr was 0 specially. The multiboot specification says the > following: > * load_end_addr >Contains the physical address of the end of the data segment. >(load

[Qemu-devel] Build fails on OS X Lion

2012-05-26 Thread Charlie Somerville
Hi qemu-devel, I tried to build the 1.1.0-rc3 on Mac OS X Lion, and I get this compile error: qga/commands-posix.c: In function ‘qmp_guest_shutdown’: qga/commands-posix.c:65: error: ‘environ’ undeclared (first use in this function) qga/commands-posix.c:65: error: (Each undeclared identifier is

[Qemu-devel] [PATCH v2 15/17] Openrisc: add linux syscall, signal and termbits

2012-05-26 Thread Jia Liu
add linux syscall, signal and termbits from linux-openrisc codes. Signed-off-by: Jia Liu --- linux-user/openrisc/syscall.h | 24 ++ linux-user/openrisc/syscall_nr.h| 506 +++ linux-user/openrisc/target_signal.h | 26 ++ linux-user/openrisc/termbits.

Re: [Qemu-devel] Build fails on OS X Lion

2012-05-26 Thread dunrong huang
2012/5/27 Charlie Somerville : > Hi qemu-devel, > > I tried to build the 1.1.0-rc3 on Mac OS X Lion, and I get this compile > error: > > qga/commands-posix.c: In function ‘qmp_guest_shutdown’: > qga/commands-posix.c:65: error: ‘environ’ undeclared (first use in this > function) > qga/commands-posix

Re: [Qemu-devel] [PATCH v2 00/17] Qemu Openrisc support

2012-05-26 Thread Stefan Weil
Am 27.05.2012 07:32, schrieb Jia Liu: This is the Opencores Openrisc 1200 support for Qemu. Full implementation of the system-model and linux-user-model support. The official name is 'QEMU', not 'Qemu'. Please fix this in the patches, too. Regards, Stefan Weil

[Qemu-devel] [PATCH v2 03/17] Openrisc: add basic machine

2012-05-26 Thread Jia Liu
add openrisc basic machine. Signed-off-by: Jia Liu --- target-openrisc/cpu.h | 30 ++ target-openrisc/helper.c | 45 +++-- target-openrisc/machine.c | 22 +- 3 files changed, 94 insertions(+), 3 de

Re: [Qemu-devel] [PATCH v2 00/17] Qemu Openrisc support

2012-05-26 Thread Jia Liu
On Sun, May 27, 2012 at 2:01 PM, Stefan Weil wrote: > Am 27.05.2012 07:32, schrieb Jia Liu: > >> This is the Opencores Openrisc 1200 support for Qemu. >> Full implementation of the system-model and linux-user-model support. >> > > The official name is 'QEMU', not 'Qemu'. > > Please fix this in the

[Qemu-devel] [PATCH v2 10/17] Openrisc: add Programmable Interrupt Controller

2012-05-26 Thread Jia Liu
add Programmable Interrupt Controller for openrisc. Signed-off-by: Jia Liu --- hw/openrisc_pic.c | 50 + target-openrisc/cpu.h |5 + 2 files changed, 55 insertions(+) diff --git a/hw/openrisc_pic.c b/hw/openrisc_pic.c index 201c6bc..

[Qemu-devel] [PATCH v2 08/17] Openrisc: add float instruction helpers

2012-05-26 Thread Jia Liu
add float point instruction helpers for openrisc. Signed-off-by: Jia Liu --- Makefile.target |2 +- target-openrisc/cpu.h|3 + target-openrisc/fpu_helper.c | 275 ++ target-openrisc/helper.h | 33 + 4 files changed,

[Qemu-devel] [PATCH v2 07/17] Openrisc: add int instruction helpers

2012-05-26 Thread Jia Liu
add int piont instruction helpers for openrisc. Signed-off-by: Jia Liu --- Makefile.target |2 +- target-openrisc/helper.h |8 +++ target-openrisc/int_helper.c | 155 ++ 3 files changed, 164 insertions(+), 1 deletion(-) create mo

[Qemu-devel] [PATCH v2 14/17] Openrisc: add gdb stub support

2012-05-26 Thread Jia Liu
add gdb stub support for openrisc. Signed-off-by: Jia Liu --- gdbstub.c | 64 + 1 file changed, 64 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 6a77a66..98a0d18 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1155,6 +1155,68 @@

[Qemu-devel] [PATCH v2 13/17] Openrisc: add system instruction helpers

2012-05-26 Thread Jia Liu
add system instruction helpers for openrisc. Signed-off-by: Jia Liu --- Makefile.target |2 +- target-openrisc/helper.h |4 + target-openrisc/sys_helper.c | 226 ++ target-openrisc/translate.c | 18 4 files changed, 249 in

[Qemu-devel] [PATCH v2 05/17] Openrisc: add interrupt support

2012-05-26 Thread Jia Liu
add openrisc interrupt support. Signed-off-by: Jia Liu --- Makefile.target |2 +- cpu-exec.c | 13 ++ target-openrisc/cpu.h |4 +++ target-openrisc/helper.h| 25 +++ target-openrisc/intrpt.c| 42