Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 10:06:11AM -0300, Luiz Capitulino wrote: > On Fri, 25 May 2012 08:34:54 +0100 > "Daniel P. Berrange" wrote: > > > On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: > > > On 25/05/12 11:51, Eric Blake wrote: > > > >On 05/24/2012 09:32 PM, Amos Kong wrote: > > > >>C

[Qemu-devel] [PATCH 11/18] ehci: fix reset

2012-05-25 Thread Gerd Hoffmann
Check for the reset bit first when processing USBCMD register writes. Also break out of the switch, there is no need to check the other bits. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/h

[Qemu-devel] [PATCH 09/18] ehci: schedule async bh on async packet completion

2012-05-25 Thread Gerd Hoffmann
When a packet completes which happens to be part of the async schedule kick the async bottom half for processing, Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 16627d3..8b

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Anthony Liguori
On 05/24/2012 10:51 PM, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to monitor.c Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Signed-off-by: Amos Kong +## +#

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Paolo Bonzini
Il 25/05/2012 15:07, Luiz Capitulino ha scritto: > On Fri, 25 May 2012 14:59:25 +0200 > Paolo Bonzini wrote: > >> Il 25/05/2012 14:53, Luiz Capitulino ha scritto: > I agree it would be nice to drop entirely but I don't feel happy doing > that to users who might have QEMU buried in scripts

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 14:12:39 +0100 "Daniel P. Berrange" wrote: > On Fri, May 25, 2012 at 10:06:11AM -0300, Luiz Capitulino wrote: > > On Fri, 25 May 2012 08:34:54 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: > > > > On 25/05/12 11:51

[Qemu-devel] [PATCH 07/18] ehci: add async field to EHCIQueue

2012-05-25 Thread Gerd Hoffmann
Keep track whenever a EHCIQueue is part of the async or periodic schedule. This way we don't have to pass around the async flag everywhere but can look it up from the EHCIQueue struct when needed. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 92

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:14:39 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:07, Luiz Capitulino ha scritto: > > On Fri, 25 May 2012 14:59:25 +0200 > > Paolo Bonzini wrote: > > > >> Il 25/05/2012 14:53, Luiz Capitulino ha scritto: > > I agree it would be nice to drop entirely but I don't feel

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Paolo Bonzini
Il 25/05/2012 15:18, Luiz Capitulino ha scritto: >> > >> > Still not sure what you mean... > I meant it's a similar case. kqemu was a special case and maintenance burden. > We've dropped it and didn't regret. What's stopping us from doing the same > thing with vlans? That we have an alternative,

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Anthony Liguori
On 05/25/2012 08:06 AM, Luiz Capitulino wrote: On Fri, 25 May 2012 08:34:54 +0100 "Daniel P. Berrange" wrote: On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: On 25/05/12 11:51, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depen

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-25 Thread Paolo Bonzini
Il 25/05/2012 14:09, Stefan Hajnoczi ha scritto: >> > >> > Perhaps that be simply a new qemu-img subcommand? It should be possible >> > to run it while the VM is offline. Then the file that is produced could >> > be fed to blockdev-dirty-enable. > For both continuous replication and incremental

[Qemu-devel] [PATCH 05/18] ehci: add queuing support

2012-05-25 Thread Gerd Hoffmann
Add packet queuing. Follow the qTD chain to see if there are more packets we can submit. Improves performance on larger transfers, especially with usb-host, as we don't have to wait for a packet to finish before sending the next one to the host for processing. Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:19:28 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:18, Luiz Capitulino ha scritto: > >> > > >> > Still not sure what you mean... > > I meant it's a similar case. kqemu was a special case and maintenance > > burden. > > We've dropped it and didn't regret. What's stopping

[Qemu-devel] [PATCH 17/18] ehci: adaptive wakeup rate.

2012-05-25 Thread Gerd Hoffmann
Adapt the frame timer sleeps according to the actual needs. With the periodic schedule being active we'll have to wakeup 1000 times per second and go check for work. In case only the async schedule is active we can be more lazy though. When idle ehci will increate the sleep time step by step, so

Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c

2012-05-25 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/qdev-properties.c | 487 > + > hw/qdev.c | 47 + > hw/qdev.h | 87 - > include/qemu/object.h | 98 ++ > qom/ob

[Qemu-devel] [PATCH 06/18] ehci: tweak queue initialization

2012-05-25 Thread Gerd Hoffmann
Little tweak for the queue initialization, set the QH address in the allocation function. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index ccaa947..aa67af6 100644 --- a/h

[Qemu-devel] [PATCH 04/18] ehci: move ehci_flush_qh

2012-05-25 Thread Gerd Hoffmann
Move ehci_flush_qh() function up in the source code. No code change. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 35 ++- 1 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index d7131bd..f21b4be 100644

Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c

2012-05-25 Thread Paolo Bonzini
Il 25/05/2012 15:32, Andreas Färber ha scritto: > Am 23.05.2012 17:44, schrieb Paolo Bonzini: >> Signed-off-by: Paolo Bonzini >> --- >> hw/qdev-properties.c | 487 >> + >> hw/qdev.c | 47 + >> hw/qdev.h | 87 --

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Paolo Bonzini
Il 25/05/2012 15:30, Luiz Capitulino ha scritto: > On Fri, 25 May 2012 15:19:28 +0200 > Paolo Bonzini wrote: > >> Il 25/05/2012 15:18, Luiz Capitulino ha scritto: > > Still not sure what you mean... >>> I meant it's a similar case. kqemu was a special case and maintenance >>> burden. >>>

[Qemu-devel] [PATCH 12/18] ehci: add ehci_*_enabled() helpers

2012-05-25 Thread Gerd Hoffmann
Add helper functions to query whenever the async / periodic schedule is enabled or not. Put them into use too. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 27 +-- 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-eh

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:37:15 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:30, Luiz Capitulino ha scritto: > > On Fri, 25 May 2012 15:19:28 +0200 > > Paolo Bonzini wrote: > > > >> Il 25/05/2012 15:18, Luiz Capitulino ha scritto: > > > > Still not sure what you mean... > >>> I meant it's

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Paolo Bonzini
Il 25/05/2012 15:43, Luiz Capitulino ha scritto: >> Yeah, VDE probably includes something like an hub. But then we could >> drop even "-net socket", "-net udp", "-net dump", and only leave in >> vde+tap+slirp. Or even move slirp into VDE. :) That's a very different >> thing. > > Let's start wit

Re: [Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info

2012-05-25 Thread Jan Kiszka
On 2012-05-25 09:00, Zhi Yong Wu wrote: > On Fri, May 25, 2012 at 4:34 AM, Jan Kiszka wrote: >> On 2012-05-24 14:59, zwu.ker...@gmail.com wrote: >>> From: Zhi Yong Wu >>> >>> Signed-off-by: Zhi Yong Wu >>> --- >>> net.c |7 ++- >>> net/hub.c |2 +- >>> 2 files changed, 7 inserti

[Qemu-devel] [PATCH 16/18] ehci: create ehci_update_frindex

2012-05-25 Thread Gerd Hoffmann
Factor out code from ehci_frame_timer. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index ee7420f..c15dbee 100644 --- a/hw/usb/hcd-ehci.c +++ b

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:47:28 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:43, Luiz Capitulino ha scritto: > >> Yeah, VDE probably includes something like an hub. But then we could > >> drop even "-net socket", "-net udp", "-net dump", and only leave in > >> vde+tap+slirp. Or even move slirp in

Re: [Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info

2012-05-25 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 9:49 PM, Jan Kiszka wrote: > On 2012-05-25 09:00, Zhi Yong Wu wrote: >> On Fri, May 25, 2012 at 4:34 AM, Jan Kiszka wrote: >>> On 2012-05-24 14:59, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu ---  net.c     |    7 +++

[Qemu-devel] [PATCH 08/18] ehci: move async schedule to bottom half

2012-05-25 Thread Gerd Hoffmann
This way we can kick the async schedule independant from the periodic frame timer. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index f363f14..16627d3 100644 --- a/hw/u

[Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 18 ++ net.h | 12 net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 48 insertions(+), 6 deletions(-) diff --git a/net.c b/net.c index 61dc

[Qemu-devel] [PATCH 00/18] ehci updates

2012-05-25 Thread Gerd Hoffmann
Hi, Here comes a patch series with a bunch of updates for the ehci host controller. Two important changes: First ehci supports queuing now, i.e. more than a single packet per endpoint can be in flight at the same time, which improves usb-host performance. Second the wakeup rate is adaptive no

[Qemu-devel] [PATCH 15/18] ehci: remove unused attach_poll_counter

2012-05-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index f77a26d..ee7420f 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -415,7 +415,6 @@ struct EHCIState { */ QEM

[Qemu-devel] [PATCH 02/18] ehci: make ehci_execute work on EHCIPacket instead of EHCIQueue

2012-05-25 Thread Gerd Hoffmann
This way it is possible to use ehci_execute to submit others than the first EHCIPacket of the EHCIQueue. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 0

[Qemu-devel] [PATCH 10/18] ehci: kick async schedule on wakeup

2012-05-25 Thread Gerd Hoffmann
Kick async schedule when we get a wakeup notification from a usb device. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 8b2dfed..f8ed80d 100644 --- a/hw/usb/hcd-ehci.c +++ b/

[Qemu-devel] [PATCH v3] uq/master: Expose CPUID leaf 7 only for -cpu host

2012-05-25 Thread Eduardo Habkost
[re-submitting to get this in through uq/master] Changes v2 -> v3; - Check for kvm_enabled() before setting cpuid_7_0_ebx_features Changes v1 -> v2: - Use kvm_arch_get_supported_cpuid() instead of host_cpuid() on cpu_x86_fill_host(). We should use GET_SUPPORTED_CPUID for all bits on "-

[Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 18 ++ net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 37 insertions(+), 6 deletions(-) diff --git a/net.c b/net.c index 61dc28d..ae0dee

Re: [Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread Jan Kiszka
On 2012-05-25 11:02, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > Reviewed-by: Jan Kiszka Please don't put reviewed-by tags here before the reviewer had a chance to look at the code. > Signed-off-by: Zhi Yong Wu > --- > net.c | 18 ++ > net.h | 12 ++

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Jeff Cody
On 05/25/2012 09:00 AM, Luiz Capitulino wrote: > On Fri, 25 May 2012 14:20:33 +0800 > Amos Kong wrote: > >> On 25/05/12 11:51, Eric Blake wrote: >>> On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sen

Re: [Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 10:17 PM, Jan Kiszka wrote: > On 2012-05-25 11:02, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Reviewed-by:   Jan Kiszka   > > Please don't put reviewed-by tags here before the reviewer had a chance > to look at the code. > >> Signed-off-by: Zhi Yong Wu >> ---

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 11:32:01 +0800 Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on some variables > in monitor.c, so reserve qmp_sendkey() to monitor.c > Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Splitting the args rename to a different patch would make re

Re: [Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread Jan Kiszka
On 2012-05-25 11:25, Zhi Yong Wu wrote: >>> diff --git a/net/hub.c b/net/hub.c >>> index 122de69..8c77d03 100644 >>> --- a/net/hub.c >>> +++ b/net/hub.c >>> @@ -184,6 +184,25 @@ NetClientState *net_hub_find_client_by_name(unsigned >>> int hub_id, >>> } >>> >>> /** >>> + * Determine if one nc pee

Re: [Qemu-devel] [PATCH v3] uq/master: Expose CPUID leaf 7 only for -cpu host

2012-05-25 Thread Jan Kiszka
On 2012-05-25 11:12, Eduardo Habkost wrote: > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 65d9af6..91a657a 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -238,6 +238,8 @@ typedef struct x86_def_t { > /* Store the results of Centaur's CPUID instructions */ >

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-25 Thread Luiz Capitulino
On Thu, 24 May 2012 19:22:52 +0300 Alon Levy wrote: > For all devices print id, mode and guest_bug status. Is qxl really tied to spice? In the meaning that it's impossible to use it without spice? Wouldn't it be better to have 'info display' instead? > Known problems: Prints devices from highes

Re: [Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 10:40 PM, Jan Kiszka wrote: > On 2012-05-25 11:25, Zhi Yong Wu wrote: diff --git a/net/hub.c b/net/hub.c index 122de69..8c77d03 100644 --- a/net/hub.c +++ b/net/hub.c @@ -184,6 +184,25 @@ NetClientState *net_hub_find_client_by_name(unsigned in

Re: [Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread Jan Kiszka
On 2012-05-25 11:44, Zhi Yong Wu wrote: > On Fri, May 25, 2012 at 10:40 PM, Jan Kiszka wrote: >> On 2012-05-25 11:25, Zhi Yong Wu wrote: > diff --git a/net/hub.c b/net/hub.c > index 122de69..8c77d03 100644 > --- a/net/hub.c > +++ b/net/hub.c > @@ -184,6 +184,25 @@ NetClientStat

[Qemu-devel] [PATCH v4] uq/master: Expose CPUID leaf 7 only for -cpu host

2012-05-25 Thread Eduardo Habkost
Changes v3 -> v4: - Wrap line at cpu_x86_fill_host() to make checkpatch.pl happy Changes v2 -> v3; - Check for kvm_enabled() before setting cpuid_7_0_ebx_features Changes v1 -> v2: - Use kvm_arch_get_supported_cpuid() instead of host_cpuid() on cpu_x86_fill_host(). We should use GET_

Re: [Qemu-devel] [PATCH v3] uq/master: Expose CPUID leaf 7 only for -cpu host

2012-05-25 Thread Eduardo Habkost
On Fri, May 25, 2012 at 11:42:00AM -0300, Jan Kiszka wrote: > On 2012-05-25 11:12, Eduardo Habkost wrote: > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 65d9af6..91a657a 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -238,6 +238,8 @@ typedef struct x86_def_t

Re: [Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 10:50 PM, Jan Kiszka wrote: > On 2012-05-25 11:44, Zhi Yong Wu wrote: >> On Fri, May 25, 2012 at 10:40 PM, Jan Kiszka wrote: >>> On 2012-05-25 11:25, Zhi Yong Wu wrote: >> diff --git a/net/hub.c b/net/hub.c >> index 122de69..8c77d03 100644 >> --- a/net/hub.c >>

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-25 Thread Eric Blake
On 05/25/2012 02:48 AM, Paolo Bonzini wrote: >>> * block-job-complete: force completion of mirroring and switching of the >>> device to the target, not related to the rest of the proposal. >>> Synchronously opens backing files if needed, asynchronously completes >>> the job. >> >> Can this be made

Re: [Qemu-devel] [PATCH 3/3] qcow2: Support for fixing refcount inconsistencies

2012-05-25 Thread Stefan Hajnoczi
On Fri, May 11, 2012 at 5:48 PM, Kevin Wolf wrote: > @@ -1205,9 +1206,31 @@ int qcow2_check_refcounts(BlockDriverState *bs, > BdrvCheckResult *res) > >         refcount2 = refcount_table[i]; >         if (refcount1 != refcount2) { > + > +            /* Check if we're allowed to fix the mismatch *

Re: [Qemu-devel] [PATCH block-next 0/3] qemu-img check/qcow2: Allow fixing refcounts

2012-05-25 Thread Stefan Hajnoczi
On Fri, May 11, 2012 at 5:48 PM, Kevin Wolf wrote: > A prerequisite for a "QED mode" in qcow2, which doesn't update the refcount > table except on clean shutdown, is that refcounts can be repaired when the > image is opened the next time after a crash. > > This series adds a qemu-img check option

Re: [Qemu-devel] [PATCH 02/10] qdev: remove qdev_prop_exists

2012-05-25 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Can be replaced everywhere with object_property_find. > > Signed-off-by: Paolo Bonzini Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnbe

Re: [Qemu-devel] [PATCH 03/10] qom: push error reporting to object_property_find

2012-05-25 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/qdev.c |2 +- > hw/scsi-bus.c |2 +- > include/qemu/object.h |4 +++- > qom/object.c | 22 ++ > 4 files changed, 15 insertions(+), 15 deletions(-) [

Re: [Qemu-devel] [PATCH] qemu-iotests: mark 035 qcow2-only

2012-05-25 Thread Kevin Wolf
Am 24.05.2012 17:26, schrieb Stefan Hajnoczi: > The 035 parallel aio write test relies on knowledge of qcow2 metadata > layout to stress parallel L2 table accesses. This only works for qcow2 > unless we add additional calculations for qed or other formats. > > Mark this test as qcow2-only. > > N

Re: [Qemu-devel] [PATCH v4 0/3] fdc: fix media handling

2012-05-25 Thread Kevin Wolf
Am 24.05.2012 11:02, schrieb Pavel Hrdina: > This patch series fixes handling of FDC when you don't have media inserted. > Guest should see floppy drive if you start guest without media and should > detect that there is no media in drive. > > Signed-off-by: Pavel Hrdina > > Pavel Hrdina (3): >

Re: [Qemu-devel] [PATCH 3/3] qcow2: Support for fixing refcount inconsistencies

2012-05-25 Thread Kevin Wolf
Am 25.05.2012 17:33, schrieb Stefan Hajnoczi: > On Fri, May 11, 2012 at 5:48 PM, Kevin Wolf wrote: >> @@ -1205,9 +1206,31 @@ int qcow2_check_refcounts(BlockDriverState *bs, >> BdrvCheckResult *res) >> >> refcount2 = refcount_table[i]; >> if (refcount1 != refcount2) { >> + >> +

Re: [Qemu-devel] [PATCH 04/10] qom: add get_id

2012-05-25 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Some classes may present objects differently in errors, for example if they > are not part of the composition tree or if they are not assigned an id by > the user. Let them do this with a get_id method on Object, and use the > method consistently where

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-25 Thread Luiz Capitulino
On Thu, 24 May 2012 15:41:29 +0200 Paolo Bonzini wrote: > * block-stream: I would still like to add on_error to the existing > block-stream command, if only to ease unit testing. Concerns about the > stability of the API can be handled by adding introspection (exporting > the schema), which is n

Re: [Qemu-devel] [PATCH 05/10] qdev: push state up to Object

2012-05-25 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > qdev properties use the state member (an embryo of the "realized" > property) in order to disable setting them after a device has been > initialized. So, in order to push qdev properties up to Object > we need to push this bit there too. > > Signed-of

[Qemu-devel] [PATCH 04/10] sheepdog: return -errno on error

2012-05-25 Thread Kevin Wolf
From: MORITA Kazutaka On error, BlockDriver APIs should return -errno instead of -1. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 78 +++-- 1 files changed, 46 insertions(+), 32 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH 02/10] qemu-img: Explain how rebase operation can be used to perform a 'diff' operation.

2012-05-25 Thread Kevin Wolf
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Kevin Wolf --- qemu-img.texi | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index b2ca3a5..6fc3c28 100644 --- a/qemu-img.texi +++ b/qemu-img.tex

[Qemu-devel] [PATCH 06/10] qcow2: Check qcow2_alloc_clusters_at() return value

2012-05-25 Thread Kevin Wolf
When using qcow2_alloc_clusters_at(), the cluster allocation code checked the wrong variable for an error code. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2

[Qemu-devel] [PATCH 07/10] qemu-iotests: mark 035 qcow2-only

2012-05-25 Thread Kevin Wolf
From: Stefan Hajnoczi The 035 parallel aio write test relies on knowledge of qcow2 metadata layout to stress parallel L2 table accesses. This only works for qcow2 unless we add additional calculations for qed or other formats. Mark this test as qcow2-only. Note that the test is strictly speaki

[Qemu-devel] [PATCH 01/10] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-25 Thread Kevin Wolf
From: Jim Meyering Signed-off-by: Jim Meyering Signed-off-by: Kevin Wolf --- block/qcow2.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 655799c..c2e49cd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -919,7 +919,8 @@ int qcow

[Qemu-devel] [Bug 1004408] [NEW] BUG: Soft Lockup - CPU#0 stuck for 22s! [qemu-system-x86: 31867]

2012-05-25 Thread Prem Karat
Server release 6.2 * Guest Kernel: 2.6.32-220.el6.x86_64 * Qemu-command line: /usr/local/bin/qemu-system-x86_64 -name 'vm1' -nodefaults -monitor unix:'/tmp/monitor-humanmonitor1-20120525-214210-Zua6',server,nowait -serial unix:'/tmp/serial-20120525-2

Re: [Qemu-devel] [PATCH v2 09/13] vfio: x86 IOMMU implementation

2012-05-25 Thread Don Dutile
On 05/24/2012 06:46 PM, Alex Williamson wrote: On Thu, 2012-05-24 at 17:38 -0400, Don Dutile wrote: On 05/22/2012 01:05 AM, Alex Williamson wrote: x86 is probably the wrong name for this VFIO IOMMU driver, but x86 is the primary target for it. This driver support a very simple usage model usin

[Qemu-devel] [PATCH 10/10] fdc-test: introduced qtest no_media_on_start and cmos qtest for floppy

2012-05-25 Thread Kevin Wolf
From: Pavel Hrdina As default a guest has always one floppy drive so 0x10 byte in CMOS has to have 0x40 value. Higher 4 bits means that the first floppy drive is 1.44 Mb 3"5 drive and lower 4 bits means the second drive is not present. After the guest starts DSKCHG bit in DIR register should be

[Qemu-devel] [PATCH 09/10] fdc: fix media detection

2012-05-25 Thread Kevin Wolf
From: Pavel Hrdina We have to set up 'media_changed' after guest start so floppy driver could detect that there is no media in drive. For this purpose we call 'fdctrl_change_cb' instead of 'fd_revalidate' in 'fdctrl_connect_drives'. 'fd_revalidate' is called inside 'fdctrl_change_cb'. We still h

[Qemu-devel] [Bug 1004408] Re: BUG: Soft Lockup - CPU#0 stuck for 22s! [qemu-system-x86: 31867]

2012-05-25 Thread Prem Karat
CPU model: Intel(R) Xeon(R) CPU X5570 @ 2.93GHz * Guest OS: Red Hat Enterprise Linux Server release 6.2 * Guest Kernel: 2.6.32-220.el6.x86_64 * Qemu-command line: /usr/local/bin/qemu-system-x86_64 -name 'vm1' -nodefaults -monitor unix:'/tmp/monit

[Qemu-devel] [PULL 00/10] Block patches for 1.1

2012-05-25 Thread Kevin Wolf
The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: audio: Always call fini on exit (2012-05-24 19:35:27 +0400) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Jim Meyering (1): qcow2: don't leak buffer for unexpected qcow_ve

[Qemu-devel] [PATCH 03/10] sheepdog: mark image as snapshot when tag is specified

2012-05-25 Thread Kevin Wolf
From: MORITA Kazutaka When a snapshot tag is specified in the filename, the opened image is a snapshot. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c i

Re: [Qemu-devel] [PATCH 04/10] qom: add get_id

2012-05-25 Thread malc
On Fri, 25 May 2012, Andreas F?rber wrote: > Am 23.05.2012 17:44, schrieb Paolo Bonzini: > > Some classes may present objects differently in errors, for example if they > > are not part of the composition tree or if they are not assigned an id by > > the user. Let them do this with a get_id metho

[Qemu-devel] [PATCH 08/10] fdc: floppy drive should be visible after start without media

2012-05-25 Thread Kevin Wolf
From: Pavel Hrdina If you start guest with floppy drive but without media inserted, guest still should see floppy drive pressent. Signed-off-by: Pavel Hrdina Signed-off-by: Kevin Wolf --- hw/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index

[Qemu-devel] [PATCH 05/10] sheepdog: use heap instead of stack for BDRVSheepdogState

2012-05-25 Thread Kevin Wolf
From: MORITA Kazutaka bdrv_create() is called in coroutine context now, so we cannot use more stack than 1 MB in the function if we use ucontext coroutine. This patch allocates BDRVSheepdogState, whose size is 4 MB, on the heap in sd_create(). Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin

[Qemu-devel] [PATCH v2 0/1] virtio-rng: hardware random number generator

2012-05-25 Thread Amit Shah
Hello, Here's the 2nd iteration of the virtio hwrng device. This device just accepts data from the chardev and sends it up to the guest. There's no policy here on restricting the number of bytes we send to the guest, as that can be done by management apps. libvirt has a better picture of the ho

[Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-05-25 Thread Amit Shah
The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. The chardev connected to this device is fed the data to be

[Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump

2012-05-25 Thread Luiz Capitulino
Converting the screendump command is simple and shouldn't take more than or or two patches, the complicated part is to report all errors correctly. I hope I didn't go too far there, but at least this series does the right thing (or is very near to). console.c| 7 ++-- console.h

[Qemu-devel] [PATCH 01/14] qerror: extend QERR_TOO_MANY_FILES

2012-05-25 Thread Luiz Capitulino
Specify it's too many open files in the system (ENFILE). There's no compatibility problem because it's not used anywhere today. Signed-off-by: Luiz Capitulino --- qerror.c | 4 ++-- qerror.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qerror.c b/qerror.c index 5092f

[Qemu-devel] [PATCH 07/14] omap_lcdc: rename ppm_save() to omap_ppm_save()

2012-05-25 Thread Luiz Capitulino
Avoids confusion with the global ppm_save() defined in hw/vga.c. Signed-off-by: Luiz Capitulino --- hw/omap_lcdc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/omap_lcdc.c b/hw/omap_lcdc.c index 4a08e9d..6d2e83a 100644 --- a/hw/omap_lcdc.c +++ b/hw/omap_lcdc.

[Qemu-devel] [PATCH 12/14] tcx: tcx24_screen_dump(): add error handling

2012-05-25 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]->hw_screen_dump() with errp=NULL. The error will be propa

[Qemu-devel] [PATCH 04/14] cutils: introduce qemu_fprintf_err()

2012-05-25 Thread Luiz Capitulino
A fprintf() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino --- cutils.c | 31 +++ qemu-common.h | 1 + 2 files changed, 32 insertions(+) diff --git a/cutils.c b/cutils.c index bdee130..f5b02b4 100644 --- a/cutils.c +++ b/cutils.c @@ -591,3

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-05-25 Thread Anthony Liguori
On 05/25/2012 02:32 PM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. The chardev conn

[Qemu-devel] [PATCH 03/14] cutils: introduce qemu_fopen_err()

2012-05-25 Thread Luiz Capitulino
A fopen() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino --- cutils.c | 42 ++ qemu-common.h | 3 +++ 2 files changed, 45 insertions(+) diff --git a/cutils.c b/cutils.c index af308cd..bdee130 100644 --- a/cutils.c +++ b/cutils.

[Qemu-devel] [PATCH 13/14] tcx: tcx_screen_dump(): add error handling

2012-05-25 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]->hw_screen_dump() with errp=NULL. The error will be propa

[Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-25 Thread Luiz Capitulino
New errors for write() and open() failures. Will be used by the next commits. Signed-off-by: Luiz Capitulino --- qerror.c | 24 qerror.h | 18 ++ 2 files changed, 42 insertions(+) diff --git a/qerror.c b/qerror.c index 2c97382..58e4570 100644 --- a/qerro

[Qemu-devel] [PATCH 08/14] console: vga_hw_screen_dump_ptr: take an Error argument

2012-05-25 Thread Luiz Capitulino
The new argument is not used in this commit. Error handling will be added to each device individually in later commits. All devices that register a screen dump callback via graphic_console_init() are updated. This work is required by the future conversion of the screendump command to the QAPI. S

[Qemu-devel] [PATCH 06/14] cutils: introduce qemu_fwrite_err()

2012-05-25 Thread Luiz Capitulino
A fwrite() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino --- cutils.c | 15 +++ qemu-common.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/cutils.c b/cutils.c index 83edb43..63fdfc0 100644 --- a/cutils.c +++ b/cutils.c @@ -634,3 +634,18 @@ int

[Qemu-devel] [PATCH 05/14] cutils: introduce qemu_fputc_err()

2012-05-25 Thread Luiz Capitulino
A fputc() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino --- cutils.c | 12 qemu-common.h | 1 + 2 files changed, 13 insertions(+) diff --git a/cutils.c b/cutils.c index f5b02b4..83edb43 100644 --- a/cutils.c +++ b/cutils.c @@ -622,3 +622,15 @@ int qemu_

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-05-25 Thread Amit Shah
On (Fri) 25 May 2012 [15:00:53], Anthony Liguori wrote: > On 05/25/2012 02:32 PM, Amit Shah wrote: > >The Linux kernel already has a virtio-rng driver, this is the device > >implementation. > > > >When the guest asks for entropy from the virtio hwrng, it puts a buffer > >in the vq. We then put ent

[Qemu-devel] [PATCH 10/14] omap_lcdc: omap_ppm_save(): add error handling

2012-05-25 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]->hw_screen_dump() with errp=NULL. The error will be propa

[Qemu-devel] [PATCH 09/14] vga: ppm_save(): add error handling

2012-05-25 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fwrite_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Adding error handling to ppm_save() has the net effect of automatically adding error handling for all devices using ppm_save(), but note that the e

[Qemu-devel] [PATCH 14/14] qapi: convert screendump

2012-05-25 Thread Luiz Capitulino
Also activates error reporting from devices. Signed-off-by: Luiz Capitulino --- console.c| 7 --- console.h| 1 - hmp-commands.hx | 5 ++--- hmp.c| 9 + hmp.h| 1 + monitor.c| 6 -- qapi-schema.json | 24 +

[Qemu-devel] [PATCH 11/14] g364fb: g364fb_screen_dump(): add error handling

2012-05-25 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]->hw_screen_dump() with errp=NULL. The error will be propa

[Qemu-devel] Android Goldfish on QEMU

2012-05-25 Thread Ira Ray Jenkins
I found a GSOC11 project that attempted to port the Android "Goldfish" platform to mainline QEMU. Was this project successful, or is this currently being worked on?

[Qemu-devel] [PATCH 0/4] ISCSI: Passthough updates

2012-05-25 Thread Ronnie Sahlberg
Paolo, list Please find a set of patches for iscsi. 1, The recent change to the eventsystem in iscsi is racy. If the async connect of the socket takes longer than almost instant, the shortcircuit trying to write directly to the socket may try to do so before the socket is established. So we hc

[Qemu-devel] [PATCH 1/4] ISCSI: Only call READCAPACITY16 for SBC devices

2012-05-25 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index df0b6c8..39d75cb 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -727,13 +727,20 @@ iscsi_inquiry_cb(struct iscsi_contex

[Qemu-devel] [PATCH 2/4] ISCSI: Use READCAPACITY10 for MMC devices

2012-05-25 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 39d75cb..2ddb9e5 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -700,6 +700,42 @@ iscsi_r

[Qemu-devel] [PATCH 3/4] ISCSI: Only use READ16 for SBC devices. Use READ10 for other device types such as MMC

2012-05-25 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 2ddb9e5..a015a52 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -379,14 +379,25 @@ iscsi_aio_readv(BlockDriverState

[Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC device, then force the use of sg. We dont have any medium changer emulation so only passthrough via real sg or scsi-generic via iscsi wou

2012-05-25 Thread Ronnie Sahlberg
Forcing sg also makes qemu skip trying to read from the device to guess the image format by reading from the device (find_image_format()). SMC devices do not implement READ6/10/12/16 so it is noit possible to read from them. With this patch I can successfully manage a SMC device wiht iscsi in

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-25 Thread ronnie sahlberg
Paolo, You need this patch too since without it it might crash. commit 6e46eb1846a862dad253be1a576f8554071b154a Author: Ronnie Sahlberg Date: Sat May 26 10:28:05 2012 +1000 ISCSI: We can only do the shortcircuit and write directly to the socket IFF we know the socket is open (and writ

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-25 Thread 陳韋任
On Fri, May 25, 2012 at 06:13:25PM -0400, Ira Ray Jenkins wrote: > I found a GSOC11 project that attempted to port the Android "Goldfish" > platform to mainline QEMU. Was this project successful, or is this > currently being worked on? The author sent the patchset last year [1], but apparently i

Re: [Qemu-devel] Tracing message for mu

2012-05-25 Thread Charles . Tsai-蔡清海-研究發展部
Stefan, Hans replied me back and he suggested me to use strace. Hopefully, this issue can be resolved. Additionally, we encountered a tough issue right now. When we ran a 64-bit Windows 7 VM overnight, the kvm process was killed for some reasons. Here is the qemu version I copied from the scree

  1   2   3   >