Re: [Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-21 Thread Peter Maydell
On 21 May 2012 07:16, Alexander Graf wrote: > Shouldn't this be true for all CPUs? I remember talking about reset > with Peter a while ago... but don't remember the conclusions :) The conclusion we came to is that you only need to tb_flush in your CPU's reset function if you have some CPU state w

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread nicolas.sauzede
Hi Peter, > Message du 19/05/12 11:39 > De : "Peter Maydell" > A : "Blue Swirl" > Copie à : "nicolas.sauzede" , qemu-devel@nongnu.org > Objet : Re: [Qemu-devel] Get current env within io_handler ? > > On 19 May 2012 08:13, Blue Swirl wrote: > > nicolas.sauzede wrote: > >> Well, for example, we

Re: [Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 08:15 +0100, Peter Maydell wrote: > The conclusion we came to is that you only need to tb_flush > in your CPU's reset function if you have some CPU state which > you handle by baking it into translated code and doing a tb_flush > when the state changes. This is relatively rare

Re: [Qemu-devel] [PATCH v2 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-05-21 Thread Alexander Graf
On 15.05.2012, at 06:06, Benjamin Herrenschmidt wrote: > More recent Power server chips (i.e. based on the 64 bit hash MMU) > support more than just the traditional 4k and 16M page sizes. This > can get quite complicated, because which page sizes are supported, > which combinations are supported

[Qemu-devel] [Bug 1002121] [NEW] disk error when guest boot up via qcow2 image

2012-05-21 Thread Yongjie Ren
Public bug reported: Host OS (ia32/ia32e/IA64): ia32e Guest OS (ia32/ia32e/IA64): ia32e Guest OS Type (Linux/Windows): Linux(rhel6u1) kvm.git Commit: 51bfd2998113e1f8ce8dcf853407b76a04b5f2a0 qemu-kvm Commit: e54f008ef8f968cfc2f3ecab78491d180fa31efc Host Kernel Version:3.4.0-rc7 Hardware: WSM-EP, R

[Qemu-devel] The image size of instance VM keeps growing

2012-05-21 Thread Charles . Tsai-蔡清海-研究發展部
We created a qcow2 based-image for a VM whose size is big when it is created. When a VM is launched, it is a instance VM image which refers to the based-image. Initially, the image size of instance VM is smaller than that of the based-mage. But we found the image size of the instance VM kept g

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 03:56, Benjamin Herrenschmidt ha scritto: > I don't see an obvious need to provide a "relaxed" variant of the > later at this stage, a quick grep doesn't seem to show that most cases > where it's used are either not performance sensitive or the barrier > makes sense, but feel free to

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 09:51, Kevin Wolf ha scritto: >> > GTESTER check-qtest-i386 >> > FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >> > FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >> > FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0x1f >> > FLOPPY ERROR

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 10:11, schrieb Paolo Bonzini: > Il 21/05/2012 09:51, Kevin Wolf ha scritto: GTESTER check-qtest-i386 FLOPPY ERROR: fdctrl_read_data: controller not ready for reading FLOPPY ERROR: fdctrl_read_data: controller not ready for reading FLOPPY ERROR: fdctrl_unimplemented

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Paolo Bonzini
> >> What do you mean by fixing? Turning them into DPRINTFs? > > > > Or trace events? > > Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the > point here is that today it's a FLOPPY_ERROR, and except for register > fuzzing they report real problems with the emulation and not just

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Kevin Wolf
Am 19.05.2012 14:54, schrieb Blue Swirl: > Add a simple register fuzzing test to floppy controller tests. > > Signed-off-by: Blue Swirl > --- > There's a lot of output like: > GTESTER check-qtest-i386 > FLOPPY ERROR: fdctrl_read_data: controller not ready for reading > FLOPPY ERROR: fdctrl_read_d

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 10:11:06AM +0200, Paolo Bonzini wrote: > Il 21/05/2012 03:56, Benjamin Herrenschmidt ha scritto: > > I don't see an obvious need to provide a "relaxed" variant of the > > later at this stage, a quick grep doesn't seem to show that most cases > > where it's used are either no

Re: [Qemu-devel] [PATCH qom-next v2 1/3] xilinx_zynq: Use cpu_arm_init() to obtain ARMCPU

2012-05-21 Thread Andreas Färber
Am 21.05.2012 03:02, schrieb Peter Crosthwaite: > Cant see it affecting the change pattern to the zynq boot though, so > theres no blocker. > > Acked-by: Peter A.G. Crosthwaite > > On Sat, May 19, 2012 at 2:01 AM, Andreas Färber wrote: >> Needed for arm_load_kernel(). >> >> Signed-off-by: Andre

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-21 Thread Stefan Hajnoczi
On Mon, May 21, 2012 at 8:47 AM, Charles.Tsai-蔡清海-研究發展部 wrote: > Ideally, the image size of instance VM is supposed to remain in a smaller > size than the based-image. Why does it keep growing in size which is even > bigger than that of based-image? Our VM, in fact, did nothing during the > idle s

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
On 05/20/2012 12:18 PM, Alexander Graf wrote: > > > On 20.05.2012, at 12:15, Alexander Graf wrote: > >> >> >> On 09.05.2012, at 15:28, Fabien Chouteau wrote: >> >>> The size of EPN field in MAS2 depends on page size. This patch adds a >>> mask to discard invalid bits in EPN field. >>> >>> Defi

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 11:31 +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2012 at 10:11:06AM +0200, Paolo Bonzini wrote: > > Il 21/05/2012 03:56, Benjamin Herrenschmidt ha scritto: > > > I don't see an obvious need to provide a "relaxed" variant of the > > > later at this stage, a quick grep d

Re: [Qemu-devel] [PATCH 02/15] Openrisc: add MMU support

2012-05-21 Thread 陳韋任
> >> diff --git a/target-openrisc/mem_helper.c b/target-openrisc/mem_helper.c > >> index a2d93c7..922dd6b 100644 > >> --- a/target-openrisc/mem_helper.c > >> +++ b/target-openrisc/mem_helper.c > >> @@ -42,5 +42,30 @@ > >> 戹oid tlb_fill(CPUOPENRISCState *env1, target_ulong addr, int is_write, > >> ?

[Qemu-devel] [RFC 1/2] hw/qxl: ignore guest from guestbug until reset

2012-05-21 Thread Alon Levy
reset only by a guest QXL_IO_RESET Signed-off-by: Alon Levy --- hw/qxl.c |9 - hw/qxl.h |2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c11e70..a9a7778 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -141,6 +141,7 @@ static void qxl_ring_s

[Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

2012-05-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hmp.c|7 +++ hw/qxl.c | 17 + qapi-schema.json | 32 ++-- ui/qemu-spice.h |4 ui/spice-core.c |3 +++ 5 files changed, 61 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 18:58 +1000, Benjamin Herrenschmidt wrote: > Except that you mostly don't know at that level what you can or cannot > do, it depends on the caller. We should have the standard accessors do > it the "safe" way and have performance sensitive stuff do map/unmap, at > least that'

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Alexander Graf
On 21.05.2012, at 10:56, Fabien Chouteau wrote: > On 05/20/2012 12:18 PM, Alexander Graf wrote: >> >> >> On 20.05.2012, at 12:15, Alexander Graf wrote: >> >>> >>> >>> On 09.05.2012, at 15:28, Fabien Chouteau wrote: >>> The size of EPN field in MAS2 depends on page size. This patch ad

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-21 Thread Charles . Tsai-蔡清海-研究發展部
Stefan, We can run a tool to see if there is any active I/O or not. Does the image size shrink back if an I/O activity stops? What we found here is that the image size kept growing. If this problem persists, it could eat up the entire disk space. -Original Message- From: Stefan Hajnocz

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Andreas Färber
Am 14.05.2012 23:22, schrieb Blue Swirl: > On Mon, May 14, 2012 at 8:59 PM, Andreas Färber wrote: >> Am 14.05.2012 21:54, schrieb Blue Swirl: >>> On Mon, May 14, 2012 at 4:15 PM, Andreas Färber wrote: Am 10.05.2012 02:13, schrieb Andreas Färber: > Andreas Färber (74): [...] >

Re: [Qemu-devel] [RFC 1/2] hw/qxl: ignore guest from guestbug until reset

2012-05-21 Thread Gerd Hoffmann
On 05/21/12 11:04, Alon Levy wrote: > reset only by a guest QXL_IO_RESET Looks sensible. I guess you want clear guest_bug in the "guest touched vga registers" code path too. cheers, Gerd

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 19:07 +1000, Benjamin Herrenschmidt wrote: > One thing that might alleviate some of your concerns would possibly be > to "remember" in a global (to be replaced with a thread var eventually) > the last transfer direction and use a simple test to chose the barrier, > ie, store

Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

2012-05-21 Thread Gerd Hoffmann
Hi, > +if (info->qxl0_guest_bug != -1 && info->qxl0_mode != -1) { > +monitor_printf(mon, " qxl0\n"); > +monitor_printf(mon, " guest_bug: %"PRIu64"d\n", > info->qxl0_guest_bug); > +monitor_printf(mon, "mode: %s\n", > +SpiceQueryQXLMode_lookup

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 18.05.2012 19:08, schrieb Paolo Bonzini: > Hi all, > > the current block job API is designed for streaming; one property of > streaming is that in case of an error it can be restarted from the point > where it was left. > > In QEMU 1.2 I would like to add an implementation of mirroring (live >

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 07:16:27PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-05-21 at 19:07 +1000, Benjamin Herrenschmidt wrote: > > > One thing that might alleviate some of your concerns would possibly be > > to "remember" in a global (to be replaced with a thread var eventually) > > th

[Qemu-devel] [Bug 1002121] Re: disk error when guest boot up via qcow2 image

2012-05-21 Thread Yongjie Ren
Latest commit 3fd9fedb in qemu-kvm master tree still has this issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1002121 Title: disk error when guest boot up via qcow2 image Status in QEMU: Ne

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 12:34 +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2012 at 07:16:27PM +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2012-05-21 at 19:07 +1000, Benjamin Herrenschmidt wrote: > > > > > One thing that might alleviate some of your concerns would possibly be > > > to "rem

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 11:29, Kevin Wolf ha scritto: >> * block-stream: I propose adding two options to the existing >> block-stream command. If this is rejected, only mirroring will be able >> to use rerror/werror. >> >> The new options are of course rerror/werror. They are enum options, >> with the foll

[Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
From: Jim Meyering I noticed this commit, virtio-pci: add missing 'static' which made this change: > -const MemoryRegionPortio virtio_portio[] = { > +static const MemoryRegionPortio virtio_portio[] = { and wondered if there were other variables like that. The following command sho

[Qemu-devel] [PATCH 1/3] xen: remove unused global, xen_xcg

2012-05-21 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- hw/xen_backend.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/xen_backend.c b/hw/xen_backend.c index 66cb144..e44ced0 100644 --- a/hw/xen_backend.c +++ b/hw/xen_backend.c @@ -47,7 +47,6 @@ /* public */ XenXC xen_xc = XC_HANDLER_INI

[Qemu-devel] [PATCH 2/3] scsi: declare vmstate_info_scsi_requests to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- hw/scsi-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 8ab9bcd..f10f3ec 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -1561,7 +1561,7 @@ static int get_scsi_requests(QEMUFile *

[Qemu-devel] [PATCH 3/3] qemu-config: qemu_option_rom_opts, qemu_boot_opts: declare static

2012-05-21 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- qemu-config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index be84a03..c03e52b 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -528,7 +528,7 @@ QemuOptsList qemu_spice_opts = {

Re: [Qemu-devel] [PATCH 1/3] xen: remove unused global, xen_xcg

2012-05-21 Thread Stefano Stabellini
On Mon, 21 May 2012, Jim Meyering wrote: > From: Jim Meyering > > > Signed-off-by: Jim Meyering Acked-by: Stefano Stabellini > hw/xen_backend.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/xen_backend.c b/hw/xen_backend.c > index 66cb144..e44ced0 100644 > --- a/hw/xen_backen

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 07:53:23PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-05-21 at 12:34 +0300, Michael S. Tsirkin wrote: > > On Mon, May 21, 2012 at 07:16:27PM +1000, Benjamin Herrenschmidt wrote: > > > On Mon, 2012-05-21 at 19:07 +1000, Benjamin Herrenschmidt wrote: > > > > > > > On

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 12:02, schrieb Paolo Bonzini: > Il 21/05/2012 11:29, Kevin Wolf ha scritto: >>> * block-stream: I propose adding two options to the existing >>> block-stream command. If this is rejected, only mirroring will be able >>> to use rerror/werror. >>> >>> The new options are of course rerr

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Peter Maydell
On 21 May 2012 08:21, nicolas.sauzede wrote: > Ok, so I guess that for now, we have to live with the lack of a way to > actually > get those io transaction properties, right ? > Do you think it would be feasible to allow it the future ? (for now, I've done > some shortcuts and ugly hardcoding in

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 08:07, schrieb ronnie sahlberg: > List, Kevin, > > Since this merge : > commit 1f8bcac09af61e58c5121aa0a932190700ad554d > Merge: cb4c254 1042ec9 > Author: Anthony Liguori > Date: Mon Apr 23 14:27:04 2012 -0500 > > Merge remote-tracking branch 'kwolf/for-anthony' into staging

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: > On Tue, May 15, 2012 at 1:04 PM, wrote: >> From: Jim Meyering >> >> Without this, envlist_to_environ may silently fail to copy all >> strings into the destination buffer, and both callers would leak >> any env strings allocated after a failing strdup, because the >> freeing c

Re: [Qemu-devel] [PATCH 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Kevin Wolf
Am 16.05.2012 15:07, schrieb Jim Meyering: > From: Jim Meyering > > > Signed-off-by: Jim Meyering > --- > block/qcow2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 655799c..f3388bf 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -919,

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
On 05/21/2012 11:08 AM, Alexander Graf wrote: > > On 21.05.2012, at 10:56, Fabien Chouteau wrote: > >> On 05/20/2012 12:18 PM, Alexander Graf wrote: >>> >>> >>> On 20.05.2012, at 12:15, Alexander Graf wrote: >>> On 09.05.2012, at 15:28, Fabien Chouteau wrote: > The size

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 12:45, Kevin Wolf ha scritto: >> I have not yet found the exact part of this big patch that cause this >> slowdown, but will continue investigating. >> >> I am posting this here in case someone has any idea or if 55ms rings any >> bells. 55ms is the frequency of the PIT while the B

Re: [Qemu-devel] [PATCH 4/6] sheepdog: don't leak socket file descriptor upon connection failure

2012-05-21 Thread Kevin Wolf
Am 16.05.2012 15:07, schrieb Jim Meyering: > From: Jim Meyering > > > Signed-off-by: Jim Meyering Acked-by: Kevin Wolf

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes

2012-05-21 Thread ronnie sahlberg
Yes, I use IDE since I boot from this LUN. I just managed to track it down to the IDE changes. It looks like basically this change triggered it : commit bef0fd5958120542f126f2dedbfce65d8839a94d Author: Stefan Hajnoczi Date: Thu Mar 29 10:31:30 2012 +0100 ide: convert ide_sector_read() to

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 12:32, Kevin Wolf ha scritto: > Am 21.05.2012 12:02, schrieb Paolo Bonzini: >> Il 21/05/2012 11:29, Kevin Wolf ha scritto: * block-stream: I propose adding two options to the existing block-stream command. If this is rejected, only mirroring will be able to use rerror/

[Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Jim Meyering
Signed-off-by: Jim Meyering --- Thanks to Kevin Wolf for the improvement. block/qcow2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 655799c..c2e49cd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -919,7 +919,8 @@ int qcow2_update_

Re: [Qemu-devel] [PATCH 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Jim Meyering
Kevin Wolf wrote: > Am 16.05.2012 15:07, schrieb Jim Meyering: >> From: Jim Meyering >> >> >> Signed-off-by: Jim Meyering >> --- >> block/qcow2.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/block/qcow2.c b/block/qcow2.c >> index 655799c..f3388bf 100644 >> --- a/block/qcow2.c >> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Alexander Graf
On 05/21/2012 12:59 PM, Fabien Chouteau wrote: On 05/21/2012 11:08 AM, Alexander Graf wrote: On 21.05.2012, at 10:56, Fabien Chouteau wrote: On 05/20/2012 12:18 PM, Alexander Graf wrote: On 20.05.2012, at 12:15, Alexander Graf wrote: On 09.05.2012, at 15:28, Fabien Chouteau wrote: The

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-21 Thread Amit Shah
On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote: > On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote: > > On 05/16/2012 01:42 PM, Luiz Capitulino wrote: > > >On Wed, 16 May 2012 11:10:47 +0100 > > >"Daniel P. Berrange" wrote: > > > > > >>From: "Daniel P. Berrange" > > >> >

Re: [Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 13:06, schrieb Jim Meyering: > > Signed-off-by: Jim Meyering > --- > Thanks to Kevin Wolf for the improvement. > > block/qcow2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 655799c..c2e49cd 100644 > --- a/block/

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-21 Thread Daniel P. Berrange
On Mon, May 21, 2012 at 04:44:38PM +0530, Amit Shah wrote: > On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote: > > On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote: > > > On 05/16/2012 01:42 PM, Luiz Capitulino wrote: > > > >On Wed, 16 May 2012 11:10:47 +0100 > > > >"Daniel

Re: [Qemu-devel] [RFC][PATCH v2 00/11] uq/master: irqfd-based interrupt injection for virtio/vhost

2012-05-21 Thread Jan Kiszka
On 2012-05-20 11:45, Avi Kivity wrote: > On 05/20/2012 05:42 PM, Michael S. Tsirkin wrote: >> On Thu, May 17, 2012 at 10:32:28AM -0300, Jan Kiszka wrote: >>> After this series, to only reasons to still use qemu-kvm for production >>> purposes will be PCI device assignment >> >> Yay! >> >> By the wa

Re: [Qemu-devel] [RFC 1/2] hw/qxl: ignore guest from guestbug until reset

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 11:12:35AM +0200, Gerd Hoffmann wrote: > On 05/21/12 11:04, Alon Levy wrote: > > reset only by a guest QXL_IO_RESET > > Looks sensible. I guess you want clear guest_bug in the "guest touched > vga registers" code path too. good point, will fix for v2. > > cheers, > Ge

Re: [Qemu-devel] [RFC][PATCH v2 00/11] uq/master: irqfd-based interrupt injection for virtio/vhost

2012-05-21 Thread Avi Kivity
On 05/21/2012 02:31 PM, Jan Kiszka wrote: > On 2012-05-20 11:45, Avi Kivity wrote: > > On 05/20/2012 05:42 PM, Michael S. Tsirkin wrote: > >> On Thu, May 17, 2012 at 10:32:28AM -0300, Jan Kiszka wrote: > >>> After this series, to only reasons to still use qemu-kvm for production > >>> purposes will

Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 11:22:16AM +0200, Gerd Hoffmann wrote: > Hi, > > > +if (info->qxl0_guest_bug != -1 && info->qxl0_mode != -1) { > > +monitor_printf(mon, " qxl0\n"); > > +monitor_printf(mon, " guest_bug: %"PRIu64"d\n", > > info->qxl0_guest_bug); > > +monitor_

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 13:31 +0300, Michael S. Tsirkin wrote: > > IE. Just making the default accessors ordered means that all devices > > written with the assumption that the guest will see accesses in the > > order they are written in the emulated device will be correct, which > > means pretty mu

Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

2012-05-21 Thread Gerd Hoffmann
Hi, > OK, so I can fix this and remove the qxl0 hack at the same stroke. I was > looking at using the system_bus, but that seems like another hack. Didn't check what qom provides these days, searching for objects of a certain type (for example a qxl device) should be possible IMO. Dunno whenev

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Andreas Färber
Am 21.05.2012 09:21, schrieb nicolas.sauzede: > Hi Peter, > >> Message du 19/05/12 11:39 >> De : "Peter Maydell" >> A : "Blue Swirl" >> Copie à : "nicolas.sauzede" , qemu-devel@nongnu.org >> Objet : Re: [Qemu-devel] Get current env within io_handler ? >> >> On 19 May 2012 08:13, Blue Swirl wrot

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-21 Thread Amit Shah
On (Mon) 21 May 2012 [12:29:52], Daniel P. Berrange wrote: > On Mon, May 21, 2012 at 04:44:38PM +0530, Amit Shah wrote: > > On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote: > > > On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote: > > > > On 05/16/2012 01:42 PM, Luiz Capituli

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 09:45:58PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-05-21 at 13:31 +0300, Michael S. Tsirkin wrote: > > > > IE. Just making the default accessors ordered means that all devices > > > written with the assumption that the guest will see accesses in the > > > order

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Stefan Hajnoczi
This makes sense given the generic nature of block jobs. If mirroring was only for live migration, for example, then we could avoid all this by choosing a single policy. As a generic operation it's nice to have control over error policy. Stefan

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 13:02, schrieb Paolo Bonzini: > Il 21/05/2012 12:32, Kevin Wolf ha scritto: >> Am 21.05.2012 12:02, schrieb Paolo Bonzini: >>> Il 21/05/2012 11:29, Kevin Wolf ha scritto: > * block-stream: I propose adding two options to the existing > block-stream command. If this is rejecte

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Eric Blake
On 05/21/2012 05:02 AM, Paolo Bonzini wrote: > Eric, is it a problem for libvirt if a pause or target error during > mirroring causes the job to exit steady state? That means that after a > target error the offset can go back from 100% to <100%. Libvirt would really like to have events present.

[Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Jan Kiszka
Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the IRQ number that is reported to the attached interrupt controller. For this purpose, another PCI bridge callback function is introduced: map_host_irq. It is so far only implemented by the PIIX3, ot

[Qemu-devel] [PATCH 2/2] pci: Add INTx routing notifier

2012-05-21 Thread Jan Kiszka
This per-device notifier shall be triggered by any interrupt router along the path of a device's legacy interrupt signal on routing changes. For simplicity reasons and as this is a slow path anyway, no further details on the routing changes are provided. Instead, the callback is expected to use pci

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes

2012-05-21 Thread Stefan Hajnoczi
On Mon, May 21, 2012 at 12:00 PM, ronnie sahlberg wrote: > Yes, I use IDE since I boot from this LUN. > > > I just managed to track it down to the IDE changes. > > It looks like basically this change triggered it : > > commit bef0fd5958120542f126f2dedbfce65d8839a94d > Author: Stefan Hajnoczi > Da

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-21 Thread Stefan Hajnoczi
On Mon, May 21, 2012 at 10:08 AM, Charles.Tsai-蔡清海-研究發展部 wrote: > We can run a tool to see if there is any active I/O or not. Does the image > size shrink back if an I/O activity stops? > What we found here is that the image size kept growing. If this problem > persists, it could eat up the enti

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Kevin Wolf
Am 17.05.2012 17:34, schrieb Richard W.M. Jones: > From: "Richard W.M. Jones" > > This produces a qcow2 file which is the difference between > two disk images. ie, if: > > base.img - is a disk image (in any format) > modified.img - is base.img, copied and modified > > then: > > qemu

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Don Dutile
On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: On 05/15/2012 05:09 PM, Alex Williamson wrote: On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helga

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
On 05/21/2012 01:11 PM, Alexander Graf wrote: > On 05/21/2012 12:59 PM, Fabien Chouteau wrote: >> On 05/21/2012 11:08 AM, Alexander Graf wrote: >>> On 21.05.2012, at 10:56, Fabien Chouteau wrote: >>> On 05/20/2012 12:18 PM, Alexander Graf wrote: > > On 20.05.2012, at 12:15, Alexander G

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Alexander Graf
On 05/10/2012 02:10 AM, Andreas Färber wrote: Hello, Based on my CPUState patches for 1.1 (qom-cpu-1.1) this series kills off the cpu_state_reset() function, which had been renamed as an interim solution to free the identifier "cpu_reset" for QOM. The interested observer may note that the earli

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Alexander Graf
On 05/21/2012 03:47 PM, Fabien Chouteau wrote: On 05/21/2012 01:11 PM, Alexander Graf wrote: On 05/21/2012 12:59 PM, Fabien Chouteau wrote: On 05/21/2012 11:08 AM, Alexander Graf wrote: On 21.05.2012, at 10:56, Fabien Chouteau wrote: On 05/20/2012 12:18 PM, Alexander Graf wrote: On 20.05.20

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Luiz Capitulino
On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: > Modified QMP commands > = As we have discussed on the ML, we're not going to extend QMP commands. I understand your reasoning, and since the beginning I thought this was something useful to do, but we've already settl

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Richard W.M. Jones
On Mon, May 21, 2012 at 03:29:22PM +0200, Kevin Wolf wrote: > Am 17.05.2012 17:34, schrieb Richard W.M. Jones: > > From: "Richard W.M. Jones" > > > > This produces a qcow2 file which is the difference between > > two disk images. ie, if: > > > > base.img - is a disk image (in any format)

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Andreas Färber
Am 10.05.2012 02:13, schrieb Andreas Färber: > Andreas Färber (74): [...] > target-mips: Use cpu_reset() in cpu_mips_init() [...] > target-mips: Use cpu_reset() in do_interrupt() > target-mips: Let cpu_mips_init() return MIPSCPU > mips_fulong2e: Use cpu_mips_cpu() to obtain MIPSCPU > mips

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 15:59, schrieb Richard W.M. Jones: > On Mon, May 21, 2012 at 03:29:22PM +0200, Kevin Wolf wrote: >> Am 17.05.2012 17:34, schrieb Richard W.M. Jones: >>> From: "Richard W.M. Jones" >>> >>> This produces a qcow2 file which is the difference between >>> two disk images. ie, if: >>> >>>

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 15:59, schrieb Luiz Capitulino: > On Fri, 18 May 2012 19:08:42 +0200 > Paolo Bonzini wrote: > >> Modified QMP commands >> = > > As we have discussed on the ML, we're not going to extend QMP commands. > > I understand your reasoning, and since the beginning I th

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 08:59 AM, Luiz Capitulino wrote: On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: Modified QMP commands = As we have discussed on the ML, we're not going to extend QMP commands. I understand your reasoning, and since the beginning I thought this was

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 10:13 -0300, Jan Kiszka wrote: > Add a PCI IRQ path discovery function that walks from a given device to > the host bridge, returning the IRQ number that is reported to the > attached interrupt controller. For this purpose, another PCI bridge > callback function is introduced:

Re: [Qemu-devel] [PATCH 2/2] pci: Add INTx routing notifier

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 10:15 -0300, Jan Kiszka wrote: > This per-device notifier shall be triggered by any interrupt router > along the path of a device's legacy interrupt signal on routing changes. > For simplicity reasons and as this is a slow path anyway, no further > details on the routing chang

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Luiz Capitulino
On Mon, 21 May 2012 09:10:40 -0500 Anthony Liguori wrote: > On 05/21/2012 08:59 AM, Luiz Capitulino wrote: > > On Fri, 18 May 2012 19:08:42 +0200 > > Paolo Bonzini wrote: > > > >> Modified QMP commands > >> = > > > > As we have discussed on the ML, we're not going to extend Q

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Luiz Capitulino
On Mon, 21 May 2012 16:09:28 +0200 Kevin Wolf wrote: > Am 21.05.2012 15:59, schrieb Luiz Capitulino: > > On Fri, 18 May 2012 19:08:42 +0200 > > Paolo Bonzini wrote: > > > >> Modified QMP commands > >> = > > > > As we have discussed on the ML, we're not going to extend QMP c

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 16:10, schrieb Anthony Liguori: > On 05/21/2012 08:59 AM, Luiz Capitulino wrote: >> On Fri, 18 May 2012 19:08:42 +0200 >> Paolo Bonzini wrote: >> >>> Modified QMP commands >>> = >> >> As we have discussed on the ML, we're not going to extend QMP commands. >> >> I

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:09 AM, Kevin Wolf wrote: Am 21.05.2012 15:59, schrieb Luiz Capitulino: On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: Modified QMP commands = As we have discussed on the ML, we're not going to extend QMP commands. I understand your reasoning, a

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:16 AM, Luiz Capitulino wrote: On Mon, 21 May 2012 09:10:40 -0500 Anthony Liguori wrote: On 05/21/2012 08:59 AM, Luiz Capitulino wrote: On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: Modified QMP commands = As we have discussed on the ML, we'

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
On 05/21/2012 03:57 PM, Alexander Graf wrote: > On 05/21/2012 03:47 PM, Fabien Chouteau wrote: >> On 05/21/2012 01:11 PM, Alexander Graf wrote: >>> On 05/21/2012 12:59 PM, Fabien Chouteau wrote: On 05/21/2012 11:08 AM, Alexander Graf wrote: > On 21.05.2012, at 10:56, Fabien Chouteau wrote:

Re: [Qemu-devel] [QEMU 1.1 PATCH v2] Expose CPUID leaf 7 only for -cpu host

2012-05-21 Thread Eduardo Habkost
On Thu, May 17, 2012 at 01:26:55PM -0300, Eduardo Habkost wrote: [...] > @@ -521,6 +523,12 @@ static int cpu_x86_fill_host(x86_def_t *x86_cpu_def) > x86_cpu_def->ext_features = ecx; > x86_cpu_def->features = edx; > > +if (x86_cpu_def->level >= 7) { > +x86_cpu_def->cpuid_7_0_

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 16:19, Anthony Liguori ha scritto: >> > > I'm not against it in principle, just in practice. Today, checking > whether a command exists is: > > commands = qmp.query_commands() > > if 'block-stream' in commands: > # has block-stream > > I have a hard time envisioning how schem

[Qemu-devel] [QEMU 1.1 PATCH v3] Expose CPUID leaf 7 only for -cpu host

2012-05-21 Thread Eduardo Habkost
Changes v2 -> v3; - Check for kvm_enabled() before setting cpuid_7_0_ebx_features Changes v1 -> v2: - Use kvm_arch_get_supported_cpuid() instead of host_cpuid() on cpu_x86_fill_host(). We should use GET_SUPPORTED_CPUID for all bits on "-cpu host" eventually, but I am not changing all

Re: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-21 Thread Stefan Hajnoczi
On Tue, May 15, 2012 at 02:42:54PM +0200, Paolo Bonzini wrote: > Il 15/05/2012 14:01, Kevin Wolf ha scritto: > > Hi all, > > > > after having implemented refcount fixing in qcow2's img_check, I'm now > > wondering what the best way is to allow users to optionally enable the > > "QED mode" for cach

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Avi Kivity
On 05/21/2012 04:13 PM, Jan Kiszka wrote: > Add a PCI IRQ path discovery function that walks from a given device to > the host bridge, returning the IRQ number that is reported to the > attached interrupt controller. For this purpose, another PCI bridge > callback function is introduced: map_host_i

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 15:59, Luiz Capitulino ha scritto: > I understand your reasoning, and since the beginning I thought this was > something useful to do, but we've already settled for not doing this. > > I also think that we shouldn't have exceptions, as in practice this means > we're extending command

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:26 AM, Paolo Bonzini wrote: Il 21/05/2012 16:19, Anthony Liguori ha scritto: I'm not against it in principle, just in practice. Today, checking whether a command exists is: commands = qmp.query_commands() if 'block-stream' in commands: # has block-stream I have a har

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 16:40, Anthony Liguori ha scritto: > On 05/21/2012 09:26 AM, Paolo Bonzini wrote: >> Il 21/05/2012 16:19, Anthony Liguori ha scritto: >>> >>> I'm not against it in principle, just in practice. Today, checking >>> whether a command exists is: >>> >>> commands = qmp.query_commands

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Jan Kiszka
On 2012-05-21 11:36, Avi Kivity wrote: > On 05/21/2012 04:13 PM, Jan Kiszka wrote: >> Add a PCI IRQ path discovery function that walks from a given device to >> the host bridge, returning the IRQ number that is reported to the >> attached interrupt controller. For this purpose, another PCI bridge >

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-05-21 Thread Igor Mammedov
On 05/10/2012 01:15 AM, Andreas Färber wrote: Am 17.04.2012 12:28, schrieb Igor Mammedov: - Original Message - From: "Andreas Färber" ... I think the right name would be /machine/cpu[%d]/cpu. The local APIC for example should reside under /machine/cpu[%d]/apic. Depends on how we mo

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 09:31 -0400, Don Dutile wrote: > On 05/18/2012 10:47 PM, Alex Williamson wrote: > > On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: > >> On 05/18/2012 06:02 PM, Alex Williamson wrote: > >>> On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: > On 05/15/2012 05:09 PM

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-05-21 Thread Jan Kiszka
On 2012-05-21 11:50, Igor Mammedov wrote: >> I've used cpu_index, but it seems cpuid_apic_id is assigned only once, >> from cpu_index, so it should be identical. What's the difference? > Once Jan voiced that user visible cpu id, should be apic_id in context of cpu > hotplug > (i.e. when doing: dev

  1   2   3   >