Re: [Qemu-devel] [PATCH 02/13] iommu: IOMMU Groups

2012-05-15 Thread David Gibson
On Mon, May 14, 2012 at 11:11:42AM -0600, Alex Williamson wrote: > On Mon, 2012-05-14 at 11:16 +1000, David Gibson wrote: > > On Fri, May 11, 2012 at 04:55:41PM -0600, Alex Williamson wrote: [snip] > > > +struct iommu_group { > > > + struct kobject kobj; > > > + struct kobject *devices_kobj; > > >

Re: [Qemu-devel] [PATCH 02/13] iommu: IOMMU Groups

2012-05-15 Thread Alex Williamson
On Tue, 2012-05-15 at 12:03 +1000, David Gibson wrote: > On Mon, May 14, 2012 at 11:11:42AM -0600, Alex Williamson wrote: > > On Mon, 2012-05-14 at 11:16 +1000, David Gibson wrote: > > > On Fri, May 11, 2012 at 04:55:41PM -0600, Alex Williamson wrote: > [snip] > > > > +struct iommu_group { > > > >

Re: [Qemu-devel] [PATCH 1.1] tests: Fix linker failure for fdc-test

2012-05-15 Thread Kevin Wolf
Am 15.05.2012 07:27, schrieb Stefan Weil: > When QEMU was built with the simple trace backend, linking failed: > > LINK tests/fdc-test > oslib-posix.o: In function `trace_qemu_memalign': > qemu/bin/debug/x86/./trace.h:31: undefined reference to `trace3' > oslib-posix.o: In function `trace_qemu_

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-15 Thread Gleb Natapov
On Mon, May 14, 2012 at 09:43:19PM -0400, Kevin O'Connor wrote: > On Mon, May 14, 2012 at 03:35:23PM +0300, Gleb Natapov wrote: > > QEMU may want to disable guest's S3/S4 support and it wants to distinguish > > between regular powerdown and S4 powerdown. To support that new fw_cfg > > option was ad

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michal Privoznik
On 15.05.2012 00:04, Michael Roth wrote: > Currently, if we fail to open the specified log file (generally due to a > permissions issue), we'll assign NULL to the logfile handle (stderr, > initially) used by the logging routines, which can cause a segfault to > occur when we attempt to report the e

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: align versioning with QEMU_VERSION

2012-05-15 Thread Michal Privoznik
On 15.05.2012 00:04, Michael Roth wrote: > Previously qemu-ga version was defined seperately. Since it is aligned > with QEMU releases, use QEMU_VERSION instead. This also implies the > version bump for 1.1[-rcN] release of qemu-ga. > > Signed-off-by: Michael Roth > --- > qemu-ga.c

Re: [Qemu-devel] KVM call agenda for June, Tuesday 15th

2012-05-15 Thread Kevin Wolf
Am 14.05.2012 17:42, schrieb Anthony Liguori: > On 05/14/2012 07:41 AM, Juan Quintela wrote: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > -open-fd-hook proposal > > The discussion seems to have tapered out without a consensus. I asked for really good reasons

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

2012-05-15 Thread Kevin Wolf
Am 14.05.2012 16:57, schrieb Stefano Stabellini: > On Mon, 14 May 2012, Jan Beulich wrote: >> While for the "normal" case (called from blk_send_response_all()) >> decrementing requests_finished is correct, doing so in the parse error >> case is wrong; requests_inflight needs to be decremented inste

[Qemu-devel] [PATCH 0/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-15 Thread Li Zhi Hui
Signed-off-by: Paolo Bonzini Signed-off-by: Li Zhi Hui Before v5 version, Although use bdrv_aio_* to replace bdrv_* functions, But In the process of processing data, only call the bdrv_dio_* one time, it will not really simulate floppy disk's reading and writing. In v6 version each read and wr

[Qemu-devel] [PATCH 1/3 v6] add function DMA_set_return and DMA_set_channel_async in dma.c

2012-05-15 Thread Li Zhi Hui
Prepare for introducing asynchronous I/O in floppy disks by adding support for asynchronous DMA operations. We won't need idle bottom halves (or bottom halves in general) anymore. QEMU works just fine without them with synchronous I/O (though the floppy drive will stall the guest and be "impolite"

[Qemu-devel] [PATCH 3/3 v6] fdc.c: add tracing

2012-05-15 Thread Li Zhi Hui
Signed-off-by: Paolo Bonzini Signed-off-by: Li Zhi Hui --- hw/fdc.c | 19 +++ trace-events |8 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 29ab29d..7ab8a1f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -36,6 +36,7 @@ #in

[Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-15 Thread Li Zhi Hui
Signed-off-by: Paolo Bonzini Signed-off-by: Li Zhi Hui --- hw/fdc.c | 313 + 1 files changed, 210 insertions(+), 103 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 5684a05..29ab29d 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -404,6 +

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-15 Thread Paolo Bonzini
Il 15/05/2012 11:17, Li Zhi Hui ha scritto: > Signed-off-by: Paolo Bonzini > Signed-off-by: Li Zhi Hui > --- > hw/fdc.c | 313 + > 1 files changed, 210 insertions(+), 103 deletions(-) To reviewers, this is obviously missing migration

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-15 Thread Kevin Wolf
Am 15.05.2012 11:27, schrieb Paolo Bonzini: > which blindly overwrites status2. Hence the new code was not written > based on it. However, the new code is untested as far as I know. In the thread of an earlier version of this series, I said that a qtest for floppy is required. This only confirms

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-15 Thread Paolo Bonzini
Il 15/05/2012 11:33, Kevin Wolf ha scritto: >> > which blindly overwrites status2. Hence the new code was not written >> > based on it. However, the new code is untested as far as I know. > In the thread of an earlier version of this series, I said that a qtest > for floppy is required. This only

[Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Fabien Chouteau
Do not call cpu_dump_state if logfile is NULL. Signed-off-by: Fabien Chouteau --- qemu-log.h |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qemu-log.h b/qemu-log.h index fccfb110..2cd5ffa 100644 --- a/qemu-log.h +++ b/qemu-log.h @@ -51,7 +51,12 @@ extern int logleve

Re: [Qemu-devel] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-15 Thread Fabien Chouteau
Any comment? On 05/09/2012 03:28 PM, Fabien Chouteau wrote: > The size of EPN field in MAS2 depends on page size. This patch adds a > mask to discard invalid bits in EPN field. > > Definition of EPN field from e500v2 RM: > EPN Effective page number: Depending on page size, only the bits > associa

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

2012-05-15 Thread Stefano Stabellini
On Tue, 15 May 2012, Kevin Wolf wrote: > Am 14.05.2012 16:57, schrieb Stefano Stabellini: > > On Mon, 14 May 2012, Jan Beulich wrote: > >> While for the "normal" case (called from blk_send_response_all()) > >> decrementing requests_finished is correct, doing so in the parse error > >> case is wrong

Re: [Qemu-devel] Posting a patch?

2012-05-15 Thread Peter Maydell
On 14 May 2012 22:14, Stefan Weil wrote: > That's why git send-email asks before sending an email. :-) > > If there are several files which match 0001-*, it will ask for > each of them. The default setting for --confirm is 'auto' which means it will only ask if you used the --compose option or se

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

2012-05-15 Thread Kevin Wolf
Am 15.05.2012 12:16, schrieb Stefano Stabellini: > On Tue, 15 May 2012, Kevin Wolf wrote: >> Am 14.05.2012 16:57, schrieb Stefano Stabellini: >>> On Mon, 14 May 2012, Jan Beulich wrote: While for the "normal" case (called from blk_send_response_all()) decrementing requests_finished is cor

Re: [Qemu-devel] [PATCH] ISCSI: iscsi_process_read callback for when the iscsi socket becomes readable may be invoked by qemu after the fd-is-readable event has cleared.

2012-05-15 Thread ronnie sahlberg
The idea was that by being very caredul with FIONREAD I can guarantee non-blocking behaviour without relying on making the socket non-blocking. The only purpose of making the socket non-blocking was to ensure that writes dont block due to the lack of a FIONWRITE ioctl. But, the code becomes simp

Re: [Qemu-devel] [PATCH qom-next 12/22] xilinx_zynq: Use cpu_arm_init() to obtain ARMCPU

2012-05-15 Thread Peter Maydell
On 14 May 2012 18:31, Andreas Färber wrote: > The board initializes only one CPU, so replace first_cpu with that CPU's > state to facilitate review of arm_load_kernel() signature change and to > avoid double casts then. There was a patch proposed to add SMP support to this board: http://lists.gnu

Re: [Qemu-devel] [PATCH qom-next 00/22] ARM: QOM cpu_reset() followups

2012-05-15 Thread Peter Maydell
On 14 May 2012 18:31, Andreas Färber wrote: > Following up on your remark about ugly naming as a consequence of my CPU reset > patches and my OMAP field rename, here's a few more patches. > > Patch 1 is spelling fixes in a comment and could be pulled into 1.1. > > Patches 2-7 fix some more naming

[Qemu-devel] [PATCH] posix-aio: don't set aiocb->ret/active outside critical section

2012-05-15 Thread Jim Meyering
Move code that sets aiocb->ret and aiocb->active into critical section. All other accesses are lock-guarded. Spotted by coverity. Signed-off-by: Jim Meyering --- I've included enough context to show one of the guarded uses in the following function. posix-aio-compat.c | 2 +- 1 file changed,

Re: [Qemu-devel] [PATCH] posix-aio: don't set aiocb->ret/active outside critical section

2012-05-15 Thread Kevin Wolf
Am 15.05.2012 13:27, schrieb Jim Meyering: > > Move code that sets aiocb->ret and aiocb->active into critical section. > All other accesses are lock-guarded. Spotted by coverity. > > Signed-off-by: Jim Meyering > --- > I've included enough context to show one of the > guarded uses in the follow

Re: [Qemu-devel] [PATCH] posix-aio: don't set aiocb->ret/active outside critical section

2012-05-15 Thread Paolo Bonzini
Il 15/05/2012 13:34, Kevin Wolf ha scritto: >> static void qemu_paio_submit(struct qemu_paiocb *aiocb) >> { >> +mutex_lock(&lock); >> aiocb->ret = -EINPROGRESS; >> aiocb->active = 0; >> -mutex_lock(&lock); >> if (idle_threads == 0 && cur_threads < max_threads) >> s

[Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-15 Thread Kevin Wolf
Hi all, after having implemented refcount fixing in qcow2's img_check, I'm now wondering what the best way is to allow users to optionally enable the "QED mode" for cache=writethrough images where refcount updates aren't written out immediately. Basically the two options are: 1. Store it in the

[Qemu-devel] microblaze qemu broken

2012-05-15 Thread Edgar E. Iglesias
Hi, Not sure when this happened but what ever options I pass to qemu microblaze result in: % qemu-system-microblaze qemu-system-microblaze: there is no option group "fsdev" Segmentation fault Does any one know whats going on? Cheers

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-15 Thread Edgar E. Iglesias
On Tue, May 15, 2012 at 12:25:11AM +0400, Max Filippov wrote: > On Thu, May 10, 2012 at 4:10 AM, Andreas Färber wrote: > > Hello, > > > > Based on my CPUState patches for 1.1 (qom-cpu-1.1) this series kills off the > > cpu_state_reset() function, which had been renamed as an interim solution > > t

Re: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-15 Thread Paolo Bonzini
Il 15/05/2012 14:01, Kevin Wolf ha scritto: > Hi all, > > after having implemented refcount fixing in qcow2's img_check, I'm now > wondering what the best way is to allow users to optionally enable the > "QED mode" for cache=writethrough images where refcount updates aren't > written out immediate

Re: [Qemu-devel] [PATCH] posix-aio: don't set aiocb->ret/active outside critical section

2012-05-15 Thread Jim Meyering
Kevin Wolf wrote: > Am 15.05.2012 13:27, schrieb Jim Meyering: >> >> Move code that sets aiocb->ret and aiocb->active into critical section. >> All other accesses are lock-guarded. Spotted by coverity. >> >> Signed-off-by: Jim Meyering >> --- >> I've included enough context to show one of the >>

[Qemu-devel] [PATCH 1/1] s390: autodetect map private

2012-05-15 Thread Christian Borntraeger
From: Christian Borntraeger kvm on specific s390 systems must not use MAP_PRIVATE since host read-only page faults are delivered to the guest. Newer systems allow the distinction via KVM_CAP_S390_COW Signed-off-by: Christian Borntraeger CC: Avi Kivity --- exec.c| 54

[Qemu-devel] [PATCH 0/1] memory detection hack for s390

2012-05-15 Thread Christian Borntraeger
Alex, here is a patch that uses the newly introduced KVM_CAP_S390_COW to get rid of the s390 specific ifdef mess in the main path and moves it into a separate function. This patch also contains a diff agains linux-headers. What is the right approach to do that? Christian Borntraeger (1): s390:

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Luiz Capitulino
On Mon, 14 May 2012 17:04:17 -0500 Michael Roth wrote: > Currently, if we fail to open the specified log file (generally due to a > permissions issue), we'll assign NULL to the logfile handle (stderr, > initially) used by the logging routines, which can cause a segfault to > occur when we attempt

[Qemu-devel] [PATCH 0/3] unchecked uses of strdup

2012-05-15 Thread jim
From: Jim Meyering I've been auditing for unchecked uses of strdup. Here are fixes for a few: Jim Meyering (3): envlist.c: handle strdup failure scsi,pci,qdev,isa-bus,sysbus: don't let *_get_fw_dev_path return NULL sparc: use g_strdup in place of unchecked strdup envlist.c | 9 +

[Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-15 Thread jim
From: Jim Meyering Without this, envlist_to_environ may silently fail to copy all strings into the destination buffer, and both callers would leak any env strings allocated after a failing strdup, because the freeing code stops at the first NULL pointer. Signed-off-by: Jim Meyering --- envlist

[Qemu-devel] [PATCH 3/3] sparc: use g_strdup in place of unchecked strdup

2012-05-15 Thread jim
From: Jim Meyering This avoids a NULL-deref upon strdup failure. Also update matching free to g_free. Signed-off-by: Jim Meyering --- target-sparc/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index 7ac6bdb..1e31318 100644

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: align versioning with QEMU_VERSION

2012-05-15 Thread Luiz Capitulino
On Mon, 14 May 2012 17:04:41 -0500 Michael Roth wrote: > Previously qemu-ga version was defined seperately. Since it is aligned > with QEMU releases, use QEMU_VERSION instead. This also implies the > version bump for 1.1[-rcN] release of qemu-ga. > > Signed-off-by: Michael Roth Acked-by: Luiz

[Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL

2012-05-15 Thread jim
From: Jim Meyering Use g_strdup rather than strdup, because the sole caller (qdev_get_fw_dev_path_helper) assumes it gets non-NULL, and dereferences it. Besides, in that caller, the allocated buffer is already freed with g_free, so it's better to allocate with a matching g_strdup. In one case,

Re: [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL

2012-05-15 Thread Paolo Bonzini
Il 15/05/2012 15:04, j...@meyering.net ha scritto: > diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c > index 8ab9bcd..a4e93d1 100644 > --- a/hw/scsi-bus.c > +++ b/hw/scsi-bus.c > @@ -1470,12 +1470,8 @@ static char *scsibus_get_dev_path(DeviceState *dev) > static char *scsibus_get_fw_dev_path(DeviceStat

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Andreas Färber
Am 15.05.2012 11:39, schrieb Fabien Chouteau: > Do not call cpu_dump_state if logfile is NULL. And where is log_cpu_state() being called from? Its caller is passing NULL already then. Andreas > > Signed-off-by: Fabien Chouteau > --- > qemu-log.h |7 ++- > 1 file changed, 6 insertions(

[Qemu-devel] [PATCH 12/11] msix: Trigger vector mask update check after vmload

2012-05-15 Thread Jan Kiszka
In case we load a PCI device with active vectors, we have to process them and invoke potential notifiers. Signed-off-by: Jan Kiszka --- This amends the QEMU series but should be equally relevant as bug fix for qemu-kvm. hw/msix.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Peter Maydell
On 14 May 2012 23:04, Michael Roth wrote: > Currently, if we fail to open the specified log file (generally due to a > permissions issue), we'll assign NULL to the logfile handle (stderr, > initially) used by the logging routines, which can cause a segfault to > occur when we attempt to report the

Re: [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL

2012-05-15 Thread Kevin Wolf
Am 15.05.2012 15:04, schrieb j...@meyering.net: > From: Jim Meyering > > Use g_strdup rather than strdup, because the sole caller > (qdev_get_fw_dev_path_helper) assumes it gets non-NULL, and dereferences > it. Besides, in that caller, the allocated buffer is already freed with > g_free, so it's

Re: [Qemu-devel] sigaction in windows

2012-05-15 Thread Mulyadi Santosa
Hi On Mon, May 14, 2012 at 10:55 PM, Paolo Bonzini wrote: >> you meant, "the receiving thread", right? > > No, in the sending thread.  That's why I said it is not exactly the same > thing. > > Paolo Interesting...thanks for the clarification... -- regards, Mulyadi Santosa Freelance Linux

Re: [Qemu-devel] KVM call agenda for June, Tuesday 15th

2012-05-15 Thread Anthony Liguori
On 05/15/2012 03:51 AM, Kevin Wolf wrote: Am 14.05.2012 17:42, schrieb Anthony Liguori: On 05/14/2012 07:41 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. -open-fd-hook proposal The discussion seems to have tapered out without a consensus. I a

Re: [Qemu-devel] microblaze qemu broken

2012-05-15 Thread Andreas Färber
Hi, Am 15.05.2012 13:23, schrieb Edgar E. Iglesias: > Not sure when this happened but what ever options I pass to qemu microblaze > result in: > > % qemu-system-microblaze > qemu-system-microblaze: there is no option group "fsdev" > Segmentation fault > > Does any one know wh

Re: [Qemu-devel] KVM call agenda for June, Tuesday 15th

2012-05-15 Thread Daniel P. Berrange
On Tue, May 15, 2012 at 08:44:14AM -0500, Anthony Liguori wrote: > On 05/15/2012 03:51 AM, Kevin Wolf wrote: > >Currently we have a very simple unidirectional structure: > >qemu is a standalone program that keeps running on its own. libvirt is > >the user of qemu. Often enough it's already hard to

Re: [Qemu-devel] microblaze qemu broken

2012-05-15 Thread Peter Maydell
On 15 May 2012 12:23, Edgar E. Iglesias wrote: > Not sure when this happened but what ever options I pass to qemu microblaze > result in: > > % qemu-system-microblaze > qemu-system-microblaze: there is no option group "fsdev" > Segmentation fault Works for me as of commit f4f7d01a (by which I me

Re: [Qemu-devel] [PATCH 08/13] iommu: Introduce IOMMU emulation infrastructure

2012-05-15 Thread Anthony Liguori
On 05/14/2012 10:02 PM, Benjamin Herrenschmidt wrote: On Mon, 2012-05-14 at 21:50 -0500, Anthony Liguori wrote: On 05/14/2012 09:32 PM, Benjamin Herrenschmidt wrote: On Mon, 2012-05-14 at 21:03 -0500, Anthony Liguori wrote: So the CPU thread runs in lock-step with the I/O thread. Dropping the

Re: [Qemu-devel] microblaze qemu broken

2012-05-15 Thread Andreas Färber
Am 15.05.2012 15:59, schrieb Peter Maydell: > On 15 May 2012 12:23, Edgar E. Iglesias wrote: >> Not sure when this happened but what ever options I pass to qemu microblaze >> result in: >> >> % qemu-system-microblaze >> qemu-system-microblaze: there is no option group "fsdev" >> Segmentation faul

Re: [Qemu-devel] microblaze qemu broken

2012-05-15 Thread Edgar E. Iglesias
On Tue, May 15, 2012 at 03:53:33PM +0200, Andreas Färber wrote: > Hi, > > Am 15.05.2012 13:23, schrieb Edgar E. Iglesias: > > Not sure when this happened but what ever options I pass to qemu microblaze > > result in: > > > > % qemu-system-microblaze > > qemu-system-microblaze:

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michael Roth
On Tue, May 15, 2012 at 10:04:32AM -0300, Luiz Capitulino wrote: > On Mon, 14 May 2012 17:04:17 -0500 > Michael Roth wrote: > > > Currently, if we fail to open the specified log file (generally due to a > > permissions issue), we'll assign NULL to the logfile handle (stderr, > > initially) used b

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-15 Thread Edgar E. Iglesias
On Tue, May 15, 2012 at 12:25:11AM +0400, Max Filippov wrote: > On Thu, May 10, 2012 at 4:10 AM, Andreas Färber wrote: > > Hello, > > > > Based on my CPUState patches for 1.1 (qom-cpu-1.1) this series kills off the > > cpu_state_reset() function, which had been renamed as an interim solution > > t

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michael Roth
On Tue, May 15, 2012 at 02:32:41PM +0100, Peter Maydell wrote: > On 14 May 2012 23:04, Michael Roth wrote: > > Currently, if we fail to open the specified log file (generally due to a > > permissions issue), we'll assign NULL to the logfile handle (stderr, > > initially) used by the logging routin

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Peter Maydell
On 15 May 2012 15:22, Michael Roth wrote: > On Tue, May 15, 2012 at 02:32:41PM +0100, Peter Maydell wrote: >> On 14 May 2012 23:04, Michael Roth wrote: >> > Currently, if we fail to open the specified log file (generally due to a >> > permissions issue), we'll assign NULL to the logfile handle (s

[Qemu-devel] [PATCH 02/13] qemu-ga: don't warn on no command return

2012-05-15 Thread Michael Roth
From: Luiz Capitulino This is a valid condition when a command chooses to not emit a success response. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qemu-ga.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 680997e..cf61cb

[Qemu-devel] [PATCH 07/13] qemu-ga: make reopen_fd_to_null() public

2012-05-15 Thread Michael Roth
From: Luiz Capitulino The next commit wants to use it. Signed-off-by: Luiz Capitulino Reviewed-by: Eric Blake Signed-off-by: Michael Roth --- qemu-ga.c | 17 + qga/commands-posix.c | 19 --- qga/guest-agent-core.h |4 3 files change

[Qemu-devel] [PATCH 10/13] qemu-ga: guest-shutdown: become synchronous

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Last commit dropped qemu-ga's SIGCHLD handler, used to automatically reap terminated children processes. This introduced a bug to qmp_guest_shutdown(): it will generate zombies. This problem probably doesn't matter in the success case, as the VM will shutdown anyway, but le

[Qemu-devel] KVM call minutes May 15th

2012-05-15 Thread Juan Quintela
This were the topics discussed Today: - open-fd-hook * (anthony): using blockdev is quite complicated. libvirnt would need to know all images formats. * (kevin): libvirt already knows it. * use a filename <-> fd dictionary We are at: having a command to get an fd from libvirt, or asking to

[Qemu-devel] [PATCH 13/13] qemu-ga: align versioning with QEMU_VERSION

2012-05-15 Thread Michael Roth
Previously qemu-ga version was defined seperately. Since it is aligned with QEMU releases, use QEMU_VERSION instead. This also implies the version bump for 1.1[-rcN] release of qemu-ga. Reviewed-by: Michal Privoznik Acked-by: Luiz Capitulino Signed-off-by: Michael Roth --- qemu-ga.c

[Qemu-devel] [PATCH 08/13] qemu-ga: become_daemon(): reopen standard fds to /dev/null

2012-05-15 Thread Michael Roth
From: Luiz Capitulino This fixes a bug where qemu-ga doesn't suspend the guest because it fails to detect suspend support even when the guest does support suspend. This happens because of the way qemu-ga fds are managed in daemon mode. When starting qemu-ga with --daemon, become_daemon() will cl

[Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM

2012-05-15 Thread Anthony PERARD
In the context of PV-on-HVM under Xen, the emulated nics are supposed to be unplug before the guest drivers are initialized. This mean that there must be unplug without the consent of the guest. Without this patch series, the guest end up with two nics with the same MAC, the emulated nic and the P

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-15 Thread Andreas Färber
Am 15.05.2012 17:12, schrieb nicolas.sauzede: > [...] when trying smp mode, I can't manage to retrieve the current env > (ie: current smp processor number, registers, etc..), > because it seems like the "cpu_single_env" variable is set to NULL > explicitly in cpu-exec.c : > /* fail safe : neve

[Qemu-devel] [PATCH 2/4] qdev: Introduce qdev_force_unplug.

2012-05-15 Thread Anthony PERARD
This function will be use to force a device to be ejected without the guest cooperation. Signed-off-by: Anthony PERARD --- hw/qdev.c | 23 --- hw/qdev.h |3 +++ 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 6a8f6bd..c95d4c2

[Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-15 Thread Anthony PERARD
This hotplug state will be used to remove a device without the guest cooperation. Signed-off-by: Anthony PERARD --- hw/acpi_piix4.c |5 + hw/pci.h|1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 585da4e..dfd5a9d 1006

[Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-15 Thread Anthony PERARD
In the context of PV-on-HVM under Xen, the emulated nics are supposed to be unplug before the guest drivers are initialized. This mean that there must be unplug without the consent of the guest. Without this patch, the guest end up with two nics with the same MAC, the emulated nic and the PV nic.

[Qemu-devel] [PATCH 3/4] pci: Add force_unplug callback.

2012-05-15 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index b706e69..c58bbc1 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1518,7 +1518,7 @@ static int pci_qdev_init(DeviceState *qdev) return 0; }

[Qemu-devel] [PATCH 03/13] qemu-ga: guest-shutdown: don't emit a success response

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or h

Re: [Qemu-devel] [PATCH 3/4] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages

2012-05-15 Thread Scott Wood
On 05/09/2012 05:54 AM, Fabien Chouteau wrote: > On 05/07/2012 06:28 PM, Alexander Graf wrote: >> Hi Fabien, >> >> Could you please elaborate a bit on the case that broke for you with these? >> The patches shouldn't change any guest facing behavior :o. >> >> > > My bad, > > The problem comes fro

[Qemu-devel] [PATCH 12/13] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michael Roth
Currently, if we fail to open the specified log file (generally due to a permissions issue), we'll assign NULL to the logfile handle (stderr, initially) used by the logging routines, which can cause a segfault to occur when we attempt to report the error before exiting. Instead, only re-assign if

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-15 Thread Andreas Färber
Am 15.05.2012 15:19, schrieb Edgar E. Iglesias: > On Tue, May 15, 2012 at 12:25:11AM +0400, Max Filippov wrote: >> On Thu, May 10, 2012 at 4:10 AM, Andreas Färber wrote: >>> Hello, >>> >>> Based on my CPUState patches for 1.1 (qom-cpu-1.1) this series kills off the >>> cpu_state_reset() function,

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-15 Thread Igor Mammedov
On Thu, May 10, 2012 at 02:13:38AM +0200, Andreas Färber wrote: > target-i386: Pass X86CPU to do_cpu_{init,sipi}() > target-i386: Let cpu_x86_init() return X86CPU > pc: Use cpu_x86_init() to obtain X86CPU > pc: Pass X86CPU to pc_cpu_reset() Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-15 Thread Andreas Färber
Am 15.05.2012 13:24, schrieb Edgar E. Iglesias: > On Tue, May 15, 2012 at 12:25:11AM +0400, Max Filippov wrote: >> On Thu, May 10, 2012 at 4:10 AM, Andreas Färber wrote: >>> Hello, >>> >>> Based on my CPUState patches for 1.1 (qom-cpu-1.1) this series kills off the >>> cpu_state_reset() function,

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-05-15 Thread Yongjie Ren
It was fixed in latest qemu-kvm tree. verified it against kvm + qemu-kvm: 331b646d..+ e54f008e.. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2012-05-15 Thread Fantu
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/998435 Title: qemu-kvm-spice doesn't support spice/qxl installs Status in QEMU: Confirmed Bug

[Qemu-devel] [PULL] qemu-ga fixes for 1.1

2012-05-15 Thread Michael Roth
The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-5-15-12 The bulk of these patches finish out the transition to making guest-s

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-15 Thread nicolas.sauzede
Sorry, What I meant was the IO handlers we can register, when initializing an io memory area :     iomemtype = cpu_register_io_memory(tlm_qemu_readfn,    tlm_qemu_writefn, s,    DEVICE_NATIVE_ENDIAN); => tlm_qemu_readfn is d

[Qemu-devel] [PATCH 05/13] qemu-ga: guest-suspend-ram: don't emit a success response

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Today, qemu-ga may not be able to emit a success response when guest-suspend-ram completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response

[Qemu-devel] [PATCH 09/13] qemu-ga: guest-suspend: make the API synchronous

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated children processes. The idea is to avoid having qemu-ga commands blocked waiting for children to terminate. That approach has two problems: 1. qemu-ga is unable to detect errors in the child, mea

[Qemu-devel] [PATCH 01/13] qapi: add support for command options

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Options allow for changes in commands behavior. This commit introduces the QCO_NO_SUCCESS_RESP option, which causes a command to not emit a success response. This is needed by commands such as qemu-ga's guest-shutdown, which may not be able to complete before the VM vanishe

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Fabien Chouteau
On 05/15/2012 03:31 PM, Andreas Färber wrote: > Am 15.05.2012 11:39, schrieb Fabien Chouteau: >> Do not call cpu_dump_state if logfile is NULL. > > And where is log_cpu_state() being called from? Its caller is passing > NULL already then. > No, logfile is a global variable. log_cpu_state() takes

[Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.1.0-rc2.tar.bz2 You can help im

[Qemu-devel] [PATCH 06/13] qemu-ga: guest-suspend-hybrid: don't emit a success response

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Today, qemu-ga may not be able to emit a success response when guest-suspend-hybrid completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a respon

[Qemu-devel] [PATCH 04/13] qemu-ga: guest-suspend-disk: don't emit a success response

2012-05-15 Thread Michael Roth
From: Luiz Capitulino Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response

[Qemu-devel] [PATCH 11/13] qemu-ga: guest-shutdown: use only async-signal-safe functions

2012-05-15 Thread Michael Roth
From: Luiz Capitulino POSIX mandates[1] that a child process of a multi-thread program uses only async-signal-safe functions before exec(). We consider qemu-ga to be multi-thread, because it uses glib. However, qmp_guest_shutdown() uses functions that are not async-signal-safe. Fix it the follow

[Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)

2012-05-15 Thread Stefan Weil
Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test, but accidentally removed rtc-test because check-qtest-i386-y was not enhanced but set twice. This patch adds rtc-test again (and sorts both tests alphabetically). Signed-off-by: Stefan Weil --- tests/Makefile |2 +- 1 file chan

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Peter Maydell
On 15 May 2012 17:08, Fabien Chouteau wrote: > On 05/15/2012 03:31 PM, Andreas Färber wrote: >> Am 15.05.2012 11:39, schrieb Fabien Chouteau: >>> Do not call cpu_dump_state if logfile is NULL. >> >> And where is log_cpu_state() being called from? Its caller is passing >> NULL already then. > No,

[Qemu-devel] Get current env within io_handler ?

2012-05-15 Thread nicolas.sauzede
Hi list, I've implemented a way to link a qemu instance (arm) to a running TLM simulation. That allows me to use qemu-system-arm as a minimal ARM ISS without any hardware device implemented within qemu, all the peripherals are implemented in the TLM simulation. This works by entering the TLM wor

Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM

2012-05-15 Thread Anthony Liguori
On 05/15/2012 10:26 AM, Anthony PERARD wrote: In the context of PV-on-HVM under Xen, the emulated nics are supposed to be unplug before the guest drivers are initialized. This mean that there must be unplug without the consent of the guest. Stefano, Can you do a PULL for the various 1.1 fixes

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Luiz Capitulino
On Tue, 15 May 2012 09:14:13 -0500 Michael Roth wrote: > On Tue, May 15, 2012 at 10:04:32AM -0300, Luiz Capitulino wrote: > > On Mon, 14 May 2012 17:04:17 -0500 > > Michael Roth wrote: > > > > > Currently, if we fail to open the specified log file (generally due to a > > > permissions issue), w

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-15 Thread Peter Maydell
On 15 May 2012 16:31, nicolas.sauzede wrote: > What I meant was the IO handlers we can register, when initializing an io > memory area : > >     iomemtype = cpu_register_io_memory(tlm_qemu_readfn, >    tlm_qemu_writefn, s, >  

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Stefan Weil
Am 15.05.2012 18:04, schrieb Anthony Liguori: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-15 Thread Anthony Liguori
On 05/15/2012 10:31 AM, nicolas.sauzede wrote: Sorry, What I meant was the IO handlers we can register, when initializing an io memory area : iomemtype = cpu_register_io_memory(tlm_qemu_readfn, tlm_qemu_writefn, s,

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-15 Thread Andreas Färber
Am 15.05.2012 17:31, schrieb nicolas.sauzede: > Sorry, > What I meant was the IO handlers we can register, when initializing an > io memory area : > > iomemtype = cpu_register_io_memory(tlm_qemu_readfn, >tlm_qemu_writefn, s, >

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Andreas Färber
Am 15.05.2012 18:04, schrieb Anthony Liguori: > On behalf of the QEMU Team, I'd like to announce the availability of the > second release candidate for the QEMU 1.1 release. This release is > meant for testing purposes and should not be used in a production > environment. > > http://wiki.qemu.org

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Peter Maydell
On 15 May 2012 17:33, Stefan Weil wrote: > Am 15.05.2012 18:04, schrieb Anthony Liguori: >> Known Issues: >> >>  - There appears to be a failure in make check on some platforms.  This >> will be resolved in -rc3. >> > > Just for the record: there are a lot more known issues. > Here is a small extr

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Anthony Liguori
On 05/15/2012 11:33 AM, Stefan Weil wrote: Am 15.05.2012 18:04, schrieb Anthony Liguori: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a product

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Anthony Liguori
On 05/15/2012 11:38 AM, Peter Maydell wrote: On 15 May 2012 17:33, Stefan Weil wrote: Am 15.05.2012 18:04, schrieb Anthony Liguori: Known Issues: - There appears to be a failure in make check on some platforms. This will be resolved in -rc3. Just for the record: there are a lot more kno

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc2 release

2012-05-15 Thread Peter Maydell
On 15 May 2012 17:38, Anthony Liguori wrote: > Known issues == release blockers.  I'm not willing to block a release for > uninitialized memory access unless it's be validated by a human (and if it > has, there probably will be a patch already). > > Likewise, memory leaks are not going to block th

  1   2   >