Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communication only in normal operating mode"

2012-05-14 Thread Jason Wang
On 05/14/2012 02:20 PM, Michael S. Tsirkin wrote: On Mon, May 14, 2012 at 01:31:22PM +0800, Jason Wang wrote: > On 05/10/2012 07:05 PM, Michael S. Tsirkin wrote: > >On Thu, May 10, 2012 at 05:31:56PM +0800, Jason Wang wrote: > >>On 05/10/2012 04:54 PM, Michael S. Tsirkin wrote: > >>>On Th

Re: [Qemu-devel] usb descriptor parsing, why bother?

2012-05-14 Thread Gerd Hoffmann
On 05/12/12 03:32, David Fries wrote: > I was bit in kvm-qemu (Debian qemu-kvm-1.0+dfsg-11) with the usb > descriptor parsing code. I was enhancing a driver in the guest and > found that I could talk to usb alt 0, but not alt 3, I made a local > fix and I see there is an upstream fix (listed below

Re: [Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Jan Beulich
>>> On 11.05.12 at 18:01, Stefano Stabellini wrote: > On Thu, 10 May 2012, Jan Beulich wrote: >> While for the "normal" case (called from blk_send_response_all()) >> decrementing requests_finished is correct, doing so in the parse error >> case is wrong; requests_inflight needs to be decremented i

Re: [Qemu-devel] [Xen-devel] [PATCH] qemu/xendisk: set maximum number of grants to be used

2012-05-14 Thread Jan Beulich
>>> On 11.05.12 at 19:07, Stefano Stabellini wrote: > On Fri, 11 May 2012, Jan Beulich wrote: >> >>> On 11.05.12 at 09:19, "Jan Beulich" wrote: >> > Legacy (non-pvops) gntdev drivers may require this to be done when the >> > number of grants intended to be used simultaneously exceeds a certain >>

Re: [Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-14 Thread Paolo Bonzini
Il 13/05/2012 12:54, Michael S. Tsirkin ha scritto: > This was done as part of 57c9fafe0f759c9f1efa5451662b3627f9bb95e0. > Should we just call object_unparent before qdev_free? > Anthony? Or just call object_unparent in object_delete? Paolo

[Qemu-devel] [PULL 1.1] spice patch queue

2012-05-14 Thread Gerd Hoffmann
Hi, Single little bugfix for 1.1 ... please pull, Gerd The following changes since commit 94d1991445fa3582c042ee4e5b72606e2fc39cc2: sun4u: implement interrupt clearing registers (2012-05-12 09:49:19 +) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu

[Qemu-devel] [PATCH 1.1] qxl: set size of PCI IO BAR correctly (16) for revision 2

2012-05-14 Thread Gerd Hoffmann
From: Uri Lublin Also move it up into switch(qxl->revision) block Signed-off-by: Uri Lublin Signed-off-by: Gerd Hoffmann --- hw/qxl.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c11e70..3da3399 100644 --- a/hw/qxl.c +++ b/hw/qxl.c

[Qemu-devel] [PATCH 1.1] usb-host: handle guest-issued clear halt

2012-05-14 Thread Gerd Hoffmann
Most important here is to update our internal endpoint state so we know the endpoint isn't in halted state any more. Without this usb-host tries to clear halt again with the next data transfer submitted. Doing this twice is (a) not correct and (b) confuses some usb devices, rendering them non-fun

[Qemu-devel] [PULL 1.1] usb patch queue

2012-05-14 Thread Gerd Hoffmann
Hi, One little usb bugfix for 1.1 ... please pull, Gerd Gerd Hoffmann (1): usb-host: handle guest-issued clear halt hw/usb/host-linux.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) The following changes since commit 94d1991445fa3582c042ee4e5b72606e2fc39cc2: sun4

Re: [Qemu-devel] sigaction in windows

2012-05-14 Thread Paolo Bonzini
Il 14/05/2012 05:47, bang bang ha scritto: > Hi, everyone: > I am very sorry to trouble you, but I have a question that need > your help. As we know, sigaction is not defined in windows, but qemu can > run on windows, I want to know how the qemu to implement sigaction so > that it can run on w

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 10:47:35AM +0200, Kevin Wolf wrote: > Am 11.05.2012 17:22, schrieb Markus Armbruster: > > For historical reasons, and unlike other block devices, our floppy > > devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller > > and the drive(s) in a single qdev. This m

Re: [Qemu-devel] [PATCH] audio: fix bug in mixeng_template.h build on NetBSD

2012-05-14 Thread Roger Pau Monne
malc escribió: On Fri, 11 May 2012, Roger Pau Monne wrote: This is a bug fix for rc1, although I think this bug has been present for a long time. If there's a bug than it's within NetBSD itself, this issue has been discussed few times (at least twice it hink) in the past, please search the ML

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-14 Thread Kevin Wolf
Am 11.05.2012 17:22, schrieb Markus Armbruster: > For historical reasons, and unlike other block devices, our floppy > devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller > and the drive(s) in a single qdev. This makes them weird: we need > -global to set up floppy drives, unlike e

Re: [Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Stefano Stabellini
On Mon, 14 May 2012, Jan Beulich wrote: > >>> On 11.05.12 at 18:01, Stefano Stabellini > >>> > wrote: > > On Thu, 10 May 2012, Jan Beulich wrote: > >> While for the "normal" case (called from blk_send_response_all()) > >> decrementing requests_finished is correct, doing so in the parse error > >>

Re: [Qemu-devel] [PATCH] vga: fix vram double-mapping with -vga std and -M pc-0.12

2012-05-14 Thread Avi Kivity
On 05/09/2012 06:23 PM, Avi Kivity wrote: > With pc-0.12, we map the video RAM both through the PCI BAR (the guest does > this) and through a fixed mapping at 0xe000. The memory API doesn't allow > this double map, and aborts. > > Fix by using an alias. > > Ping; should be 1.1ed. -- error c

Re: [Qemu-devel] x86 AREG0 patches

2012-05-14 Thread 陳韋任
On Sun, May 13, 2012 at 09:04:39PM +, Blue Swirl wrote: > Hi, > > A preview of x86 AREG0 patches can be found at the usual place: > URL git://repo.or.cz/qemu/blueswirl.git > http://repo.or.cz/r/qemu/blueswirl.git > > This is obviously 1.2 material. Is this patch will remove AREG0 s

[Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Jan Beulich
While for the "normal" case (called from blk_send_response_all()) decrementing requests_finished is correct, doing so in the parse error case is wrong; requests_inflight needs to be decremented instead. Change in v2: Adjust coding style. Signed-off-by: Jan Beulich --- a/hw/xen_disk.c +++ b/hw/x

Re: [Qemu-devel] [PATCH 01/32] target-arm: initial coprocessor register framework

2012-05-14 Thread Peter Maydell
On 13 May 2012 23:57, Andreas Färber wrote: > Am 15.04.2012 15:45, schrieb Peter Maydell: >> Initial infrastructure for data-driven registration of >> coprocessor register implementations. >> >> We still fall back to the old-style switch statements pending >> complete conversion of all existing re

Re: [Qemu-devel] [Xen-devel] [PATCH V8 RESEND 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-05-14 Thread Anthony PERARD
On Sat, May 12, 2012 at 2:42 AM, Konrad Rzeszutek Wilk wrote: > > I thought I reviewed this last time? Is there a reason for not > attaching 'Reviewed-by: Konrad Rzeszutek Wilk > ' on this patch? Yes, one: you reviewed a later patch :-) Your reviewed-by is in the last version of this series, V11

Re: [Qemu-devel] [Xen-devel] [PATCH V8 RESEND 1/8] pci_ids: Add INTEL_82599_VF id.

2012-05-14 Thread Anthony PERARD
On Sat, May 12, 2012 at 2:43 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 19, 2012 at 12:54 PM, Anthony PERARD > wrote: >> On 19/03/12 11:50, Stefano Stabellini wrote: >>> >>> On Fri, 16 Mar 2012, Anthony PERARD wrote: Signed-off-by: Anthony PERARD ---  hw/pci_ids.h |    1 +

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Kevin Wolf
Am 14.05.2012 12:30, schrieb Jan Beulich: > While for the "normal" case (called from blk_send_response_all()) > decrementing requests_finished is correct, doing so in the parse error > case is wrong; requests_inflight needs to be decremented instead. > > Change in v2: Adjust coding style. > > Sig

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-14 Thread Andreas Färber
Am 14.05.2012 10:47, schrieb Kevin Wolf: > Am 11.05.2012 17:22, schrieb Markus Armbruster: >> For historical reasons, and unlike other block devices, our floppy >> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller >> and the drive(s) in a single qdev. This makes them weird: we ne

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-14 Thread Kevin Wolf
Am 14.05.2012 13:58, schrieb Andreas Färber: > Am 14.05.2012 10:47, schrieb Kevin Wolf: >> Am 11.05.2012 17:22, schrieb Markus Armbruster: >>> For historical reasons, and unlike other block devices, our floppy >>> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller >>> and the drive

Re: [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset

2012-05-14 Thread Kevin Wolf
Am 13.05.2012 10:03, schrieb Zhouyi Zhou: > hi all > > sometimes, qemu/kvm-0.1x will hang in endless loop in > qcow2_alloc_cluster_offset. > after some investigation, I found that: > in function posix_aio_process_queue(void *opaque) > 440 ret = qemu_paio_error(acb); > 441

Re: [Qemu-devel] [PATCH] qemu-img: Fix segmentation fault

2012-05-14 Thread Kevin Wolf
Am 11.05.2012 18:57, schrieb Charles Arnold: > The following command generates a segmentation fault. > qemu-img convert -O vpc -o ? test test2 > This is because the 'goto out;' statement calls qemu_progress_end > before qemu_progress_init is called resulting in a NULL pointer > invocation. > > Si

[Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-14 Thread Gleb Natapov
This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it allows S3/S4 states to be disabled from QEMU command line. Some guests known to be broken with regards to power manag

[Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-14 Thread Gleb Natapov
There can be only one fw_cfg device, so saving global reference to it removes the need to pass its pointer around. Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 106 ++--- hw/fw_cfg.h | 15 +++ hw/loader.c | 10 + hw/

[Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-14 Thread Gleb Natapov
QEMU may want to disable guest's S3/S4 support and it wants to distinguish between regular powerdown and S4 powerdown. To support that new fw_cfg option was added that passes supported system states and what value should guest use to enter each state. States are passed in 6 byte array. Each byte re

[Qemu-devel] [PATCH 1/2] Add ACPI_EXTRACT_PKG_START macro parsing

2012-05-14 Thread Gleb Natapov
It allows to extract the beginning of a Package object content. Signed-off-by: Gleb Natapov --- tools/acpi_extract.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py index 5f613e4..14c1dfe 100755 --- a/tools/acpi_

[Qemu-devel] KVM call agenda for June, Tuesday 15th

2012-05-14 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH 01/32] target-arm: initial coprocessor register framework

2012-05-14 Thread Peter Maydell
On 14 May 2012 11:34, Peter Maydell wrote: > On 13 May 2012 23:57, Andreas Färber wrote: >> I'm aware this series predates the QOM era, but I'm not really happy how >> this aligns with my CPUState overhaul. Independent of what needs to be >> fixed for cpu_copy(), I would like to see new non-TCG f

Re: [Qemu-devel] [PULL for-1.1-rc2] Fixes from QOM-related series

2012-05-14 Thread Luiz Capitulino
On Sun, 13 May 2012 20:27:38 +0200 Andreas Färber wrote: > Hello Anthony, > > Please pull the following patches cherry-picked from various QOM-related > series. > I've dropped Paolo's "Fix -device foo,?" since you already had that queued. > QMP patches will be handled by Luiz. > > Cc: Anthony

[Qemu-devel] [PULL 0/1]: QMP patches for 1.1

2012-05-14 Thread Luiz Capitulino
Only patch, from Michael, that fixes a bug in the QMP input visitor. The changes (since 94d1991445fa3582c042ee4e5b72606e2fc39cc2) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Michael Roth (1): qapi: QMP input visitor, handle floats parsed

[Qemu-devel] [PULL 1/1] qapi: QMP input visitor, handle floats parsed as ints

2012-05-14 Thread Luiz Capitulino
From: Michael Roth JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth Signed-off-by: Lui

Re: [Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa()

2012-05-14 Thread Anthony Liguori
On 05/11/2012 10:22 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori I know this is a pervasive idiom, but it makes little sense to me and I've got a number of similar changes queued up myself. Regards, Anthony Liguori --- hw/fdc.c | 20

Re: [Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa()

2012-05-14 Thread Kevin Wolf
Am 14.05.2012 15:32, schrieb Anthony Liguori: > On 05/11/2012 10:22 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > Reviewed-by: Anthony Liguori > > I know this is a pervasive idiom, but it makes little sense to me and I've > got a > number of similar changes queued up mys

[Qemu-devel] [PATCH] qcow2: adjust qcow2_co_flush_to_os -> qcow2_co_flush_to_disk

2012-05-14 Thread zwu . kernel
From: Zhi Yong Wu qcow2_co_flush_to_os() actually flush all cached data to the disk. To keep its name consistent with its actual function, adjust its name accordingly. Signed-off-by: Zhi Yong Wu --- block/qcow2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bloc

Re: [Qemu-devel] [PATCH] qcow2: adjust qcow2_co_flush_to_os -> qcow2_co_flush_to_disk

2012-05-14 Thread Kevin Wolf
Am 14.05.2012 15:51, schrieb zwu.ker...@gmail.com: > From: Zhi Yong Wu > > qcow2_co_flush_to_os() actually flush all cached data to the disk. To keep > its name consistent with its actual function, adjust its name accordingly. > > Signed-off-by: Zhi Yong Wu This patch is plain wrong. You're

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-14 Thread Anthony Liguori
On 05/11/2012 10:22 AM, Markus Armbruster wrote: For historical reasons, and unlike other block devices, our floppy devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller and the drive(s) in a single qdev. This makes them weird: we need -global to set up floppy drives, unlike every

Re: [Qemu-devel] [PATCH] qcow2: adjust qcow2_co_flush_to_os -> qcow2_co_flush_to_disk

2012-05-14 Thread Zhi Yong Wu
On Mon, May 14, 2012 at 10:04 PM, Kevin Wolf wrote: > Am 14.05.2012 15:51, schrieb zwu.ker...@gmail.com: >> From: Zhi Yong Wu >> >> qcow2_co_flush_to_os() actually flush all cached data to the disk. To keep >> its name consistent with its actual function, adjust its name accordingly. >> >> Signe

Re: [Qemu-devel] [PATCH] qcow2: adjust qcow2_co_flush_to_os -> qcow2_co_flush_to_disk

2012-05-14 Thread Kevin Wolf
Am 14.05.2012 16:27, schrieb Zhi Yong Wu: > On Mon, May 14, 2012 at 10:04 PM, Kevin Wolf wrote: >> Am 14.05.2012 15:51, schrieb zwu.ker...@gmail.com: >>> From: Zhi Yong Wu >>> >>> qcow2_co_flush_to_os() actually flush all cached data to the disk. To keep >>> its name consistent with its actual f

[Qemu-devel] [PATCH] PowerPC: Avoid segfault in cpu_dump_state

2012-05-14 Thread Fabien Chouteau
Quit if no log file is defined. Signed-off-by: Fabien Chouteau --- target-ppc/translate.c |4 1 file changed, 4 insertions(+) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index cf59765..f17bd91 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -9319,6

Re: [Qemu-devel] [PATCH] qcow2: adjust qcow2_co_flush_to_os -> qcow2_co_flush_to_disk

2012-05-14 Thread Zhi Yong Wu
On Mon, May 14, 2012 at 10:39 PM, Kevin Wolf wrote: > Am 14.05.2012 16:27, schrieb Zhi Yong Wu: >> On Mon, May 14, 2012 at 10:04 PM, Kevin Wolf wrote: >>> Am 14.05.2012 15:51, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu qcow2_co_flush_to_os() actually flush all cached data to

[Qemu-devel] [PATCH 2/2] qemu-ga: guest-shutdown: become synchronous

2012-05-14 Thread Michael Roth
From: Luiz Capitulino Last commit dropped qemu-ga's SIGCHLD handler, used to automatically reap terminated children processes. This introduced a bug to qmp_guest_shutdown(): it will generate zombies. This problem probably doesn't matter in the success case, as the VM will shutdown anyway, but le

[Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous

2012-05-14 Thread Michael Roth
From: Luiz Capitulino Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated children processes. The idea is to avoid having qemu-ga commands blocked waiting for children to terminate. That approach has two problems: 1. qemu-ga is unable to detect errors in the child, mea

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Michael Roth
Hi Luiz, I have these patches applied to qga branch with Eric's suggested fix-ups included. I've attached them for your review. If all looks good I'll send a PULL some time today with what's hopefully all the pending fixes for qemu-ga 1.1

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Stefano Stabellini
On Mon, 14 May 2012, Jan Beulich wrote: > While for the "normal" case (called from blk_send_response_all()) > decrementing requests_finished is correct, doing so in the parse error > case is wrong; requests_inflight needs to be decremented instead. > > Change in v2: Adjust coding style. > > Signe

Re: [Qemu-devel] [PATCH for-1.1 0/2] tcg/ppc64: AREG0 support

2012-05-14 Thread Andreas Färber
Am 12.05.2012 03:16, schrieb Andreas Färber: > Here's patches to optimize and fix potential AREG0 issues on ppc64. > > So far I've only tested on Darwin/ppc64 - Debian/sparc, HelenOS/sparc64, > Haiku/i386, Haiku/x86_64 guests work. I've now tested SLES/ppc64 (backported to agraf's AREG0 branch) a

Re: [Qemu-devel] [PULL] kvm fixes for qemu 1.1

2012-05-14 Thread Anthony Liguori
On 05/10/2012 05:57 AM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Pulled. Thanks. Regards, Anthony Liguori to receive a fix for qemu 1.1, fixing dirty tracking with a large host page size; only applicable to ppc.

Re: [Qemu-devel] Some questions about qcow2 code

2012-05-14 Thread Zhi Yong Wu
On Fri, May 11, 2012 at 9:27 AM, Stefan Hajnoczi wrote: > On Fri, May 4, 2012 at 3:44 AM, Zhi Yong Wu wrote: >> On Sun, Apr 29, 2012 at 1:35 AM, Stefan Hajnoczi wrote: >>> On Sat, Apr 28, 2012 at 5:25 PM, Zhi Yong Wu wrote: >>> >>> Here explanations for quick ones that I know without looking at

Re: [Qemu-devel] [PULL 00/30] Block patches for 1.1

2012-05-14 Thread Anthony Liguori
On 05/10/2012 06:49 AM, Kevin Wolf wrote: The following changes since commit 1b3e76ebd1e270eae27e502ea8b836c31d95f801: tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode (2012-05-09 13:59:19 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. With t

Re: [Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-14 Thread Anthony Liguori
On 05/02/2012 11:07 AM, Eduardo Habkost wrote: Changes v2 -> v3: - Actually change 'defconfig' type declaration to bool - Rebase against latest qemu.git (commit 563987d0a799f90b58a575b190a57546c335191b) Changes v1 -> v2: - Move qemu_read_default_config_files() prototype to qemu-config.h

Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address

2012-05-14 Thread Anthony Liguori
On 05/10/2012 11:27 AM, Amos Kong wrote: Those patches updated help functions in qemu-socket.c, and used them in migrate-tcp.c to supporting IPv6 migration. Applied all. Thanks. I tended to agree with Paolo that lack of IPv6 support is a bug at this point... Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH 1.1] Switch SIG_IPI to SIGUSR1

2012-05-14 Thread Anthony Liguori
On 05/09/2012 05:14 PM, Jan Kiszka wrote: Use SIGUSR1 unconditionally as SIG_IPI. First, ucontext coroutines tend to corrupt RT signal masks due to a 32-on-64-bit Linux kernel bug. And, second, there appears to be no advantage in using RT signals for VCPU kicking. Signed-off-by: Jan Kiszka App

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous

2012-05-14 Thread Eric Blake
On 05/14/2012 08:56 AM, Michael Roth wrote: > From: Luiz Capitulino > > Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated > children processes. The idea is to avoid having qemu-ga commands blocked > waiting for children to terminate. > > This commit does just that. Th

Re: [Qemu-devel] [PATCH] ISCSI: iscsi_process_read callback for when the iscsi socket becomes readable may be invoked by qemu after the fd-is-readable event has cleared.

2012-05-14 Thread Paolo Bonzini
Il 12/05/2012 00:04, Ronnie Sahlberg ha scritto: > Libiscsi treats a situation such as POLLIN was invoked and the socket is > readable but ioctl(...FIONREAD...) returns that there are no bytes available > to read as an error and that the socket is faulty or has been closed. > which may trigger a

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: guest-shutdown: become synchronous

2012-05-14 Thread Eric Blake
On 05/14/2012 08:56 AM, Michael Roth wrote: > From: Luiz Capitulino > > Last commit dropped qemu-ga's SIGCHLD handler, used to automatically > reap terminated children processes. This introduced a bug to > qmp_guest_shutdown(): it will generate zombies. > > This problem probably doesn't matter i

Re: [Qemu-devel] [PATCH] PowerPC: Avoid segfault in cpu_dump_state

2012-05-14 Thread Peter Maydell
On 14 May 2012 15:46, Fabien Chouteau wrote: > Quit if no log file is defined. > > Signed-off-by: Fabien Chouteau > --- >  target-ppc/translate.c |    4 >  1 file changed, 4 insertions(+) > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index cf59765..f17bd91 100644 > --- a

Re: [Qemu-devel] KVM call agenda for June, Tuesday 15th

2012-05-14 Thread Anthony Liguori
On 05/14/2012 07:41 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. -open-fd-hook proposal The discussion seems to have tapered out without a consensus. Regards, Anthony Liguori Thanks, Juan.

[Qemu-devel] [PULL 0/3] Block patches for 1.1

2012-05-14 Thread Kevin Wolf
The following changes since commit 77f4c9a68aedb9b0d290a1def1bfc8714be862ec: Merge remote-tracking branch 'origin/master' into staging (2012-05-14 08:44:32 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Charles Arnold (1): qemu-img: Fix seg

[Qemu-devel] [PATCH 2/3] qcow2: Don't ignore failure to clear autoclear flags

2012-05-14 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3bae2d8..655799c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -300,7 +300,10 @@ static int qcow2_open(BlockDriverState *bs, int flags)

[Qemu-devel] [PATCH 3/3] qemu-img: Fix segmentation fault

2012-05-14 Thread Kevin Wolf
From: Charles Arnold The following command generates a segmentation fault. qemu-img convert -O vpc -o ? test test2 This is because the 'goto out;' statement calls qemu_progress_end before qemu_progress_init is called resulting in a NULL pointer invocation. Signed-off-by: Charles Arnold Signed-o

Re: [Qemu-devel] sigaction in windows

2012-05-14 Thread Mulyadi Santosa
Hi... On Mon, May 14, 2012 at 3:39 PM, Paolo Bonzini wrote: > It doesn't use sigaction. :)  Whenever the POSIX version would send a > signal to a thread, the Windows version does the following: > > - call SuspendThread on the receiving thread; > > - execute the signal handler code in the sending

Re: [Qemu-devel] sigaction in windows

2012-05-14 Thread Paolo Bonzini
Il 14/05/2012 17:51, Mulyadi Santosa ha scritto: > Hi... > > On Mon, May 14, 2012 at 3:39 PM, Paolo Bonzini wrote: >> It doesn't use sigaction. :) Whenever the POSIX version would send a >> signal to a thread, the Windows version does the following: >> >> - call SuspendThread on the receiving th

[Qemu-devel] [PATCH 1/3] coroutine: Fix setup of sigaltstack coroutines

2012-05-14 Thread Kevin Wolf
From: Jan Kiszka Use pthread_kill instead of process-wide kill to invoke the signal handler used for stack switching. This may fix spurious lock-ups with this backend, easily triggerable by extending the time window between kill and sigsuspend. Signed-off-by: Jan Kiszka Reviewed-by: Paolo Bonzi

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-14 Thread Andreas Färber
Am 10.05.2012 02:13, schrieb Andreas Färber: > Andreas Färber (74): > target-cris: Reindent cpu_cris_init() > target-cris: Let cpu_cris_init() return CRISCPU > axis_dev88: Use cpu_cris_init() to obtain CRISCPU > cris-boot: Pass CRISCPU to cris_load_image() > cris-boot: Pass CRISCPU to mai

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-14 Thread Andreas Färber
Am 10.05.2012 02:13, schrieb Andreas Färber: > Andreas Färber (74): [...] > target-sparc: Let cpu_sparc_init() return SPARCCPU > sun4m: Use cpu_sparc_init() to obtain SPARCCPU > sun4m: Pass SPARCCPU to {main,secondary}_cpu_reset() > sun4u: Use cpu_sparc_init() to obtain SPARCCPU > sun4u:

Re: [Qemu-devel] KVM call agenda for June, Tuesday 15th

2012-05-14 Thread Paolo Bonzini
Il 14/05/2012 17:42, Anthony Liguori ha scritto: > On 05/14/2012 07:41 AM, Juan Quintela wrote: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > -open-fd-hook proposal > > The discussion seems to have tapered out without a consensus. 1.1 changelog, anything miss

[Qemu-devel] qemu-microblaze-system

2012-05-14 Thread Michael Trimarchi
Hi all, I would like to start using/testing the qemu microblaze system, but I don't find information about linux kernel configuration that match the ml605 hardware design? Is there any howto? Michael

Re: [Qemu-devel] [PATCH 1.1 1/4] xen: do not initialize the interval timer and PCSPK emulator

2012-05-14 Thread Anthony Liguori
On 05/09/2012 07:44 AM, Stefano Stabellini wrote: PIT and PCSPK are emulated by the hypervisor so we don't need to emulate them in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c | 23 +-- 1 files

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 09:56:30 -0500 Michael Roth wrote: > Hi Luiz, > > I have these patches applied to qga branch with Eric's suggested fix-ups > included. I've attached them for your review. If all looks good I'll send a > PULL some time today with what's hopefully all the pending fixes for qe

Re: [Qemu-devel] [PATCH 1.1 1/4] xen: do not initialize the interval timer and PCSPK emulator

2012-05-14 Thread Stefano Stabellini
On Mon, 14 May 2012, Anthony Liguori wrote: > On 05/09/2012 07:44 AM, Stefano Stabellini wrote: > > PIT and PCSPK are emulated by the hypervisor so we don't need to emulate > > them in Qemu: this patch prevents Qemu from waking up needlessly at > > PIT_FREQ on Xen. > > > > Signed-off-by: Stefano St

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Michal Privoznik
On 11.05.2012 21:19, Luiz Capitulino wrote: > The main motivation for this series is fixing two possible race conditions > in the guest-suspend-* API due to the complexity that arose from the way > we handle terminated children processes today. Full details in the first > patch. > > This series ap

[Qemu-devel] [PATCH 1.1 v2 0/5] Xen patches

2012-05-14 Thread Stefano Stabellini
Hi all, this patch series is a collection of the outstanding Xen patches for QEMU 1.1: all of them have been sent to qemu-devel at least once already, some of them as many as 6 times. Patch 1 and 2 remove unneeded devices and timers when Xen is enabled, patch 3, 4 and 5 are improvements and fixes

[Qemu-devel] [PATCH 1.1 v2 3/5] xen_disk: remove syncwrite option

2012-05-14 Thread Stefano Stabellini
This patch removes a dead option. The same can be achieved removing BDRV_O_NOCACHE and BDRV_O_CACHE_WB from the flags passed to bdrv_open. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_d

[Qemu-devel] [PATCH 1.1 v2 1/5] xen: do not initialize the interval timer and PCSPK emulator

2012-05-14 Thread Stefano Stabellini
PIT and PCSPK are emulated by the hypervisor so we don't need to emulate them in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --g

[Qemu-devel] [PATCH 1.1 v2 5/5] xen_disk: properly update stats in ioreq_release()

2012-05-14 Thread Stefano Stabellini
From: Jan Beulich While for the "normal" case (called from blk_send_response_all()) decrementing requests_finished is correct, doing so in the parse error case is wrong; requests_inflight needs to be decremented instead. Signed-off-by: Jan Beulich Signed-off-by: Stefano Stabellini Reviewed-by:

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 19:06:28 +0200 Michal Privoznik wrote: > On 11.05.2012 21:19, Luiz Capitulino wrote: > > The main motivation for this series is fixing two possible race conditions > > in the guest-suspend-* API due to the complexity that arose from the way > > we handle terminated children pr

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Eric Blake
On 05/14/2012 11:06 AM, Michal Privoznik wrote: > On 11.05.2012 21:19, Luiz Capitulino wrote: >> The main motivation for this series is fixing two possible race conditions >> in the guest-suspend-* API due to the complexity that arose from the way >> we handle terminated children processes today. F

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Michael Roth
On Mon, May 14, 2012 at 01:39:50PM -0300, Luiz Capitulino wrote: > On Mon, 14 May 2012 09:56:30 -0500 > Michael Roth wrote: > > > Hi Luiz, > > > > I have these patches applied to qga branch with Eric's suggested fix-ups > > included. I've attached them for your review. If all looks good I'll se

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 12:19:04 -0500 Michael Roth wrote: > On Mon, May 14, 2012 at 01:39:50PM -0300, Luiz Capitulino wrote: > > On Mon, 14 May 2012 09:56:30 -0500 > > Michael Roth wrote: > > > > > Hi Luiz, > > > > > > I have these patches applied to qga branch with Eric's suggested fix-ups > >

[Qemu-devel] [PATCH qom-next 00/22] ARM: QOM cpu_reset() followups

2012-05-14 Thread Andreas Färber
Hello Peter, Following up on your remark about ugly naming as a consequence of my CPU reset patches and my OMAP field rename, here's a few more patches. Patch 1 is spelling fixes in a comment and could be pulled into 1.1. Patches 2-7 fix some more naming ugliness that I missed when running beca

[Qemu-devel] [PATCH for-1.1 01/22] arm_boot: Fix typos in comment

2012-05-14 Thread Andreas Färber
mimicing -> mimicking thei -> the Signed-off-by: Andreas Färber --- hw/arm-misc.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm-misc.h b/hw/arm-misc.h index 2f46e21..5302ee8 100644 --- a/hw/arm-misc.h +++ b/hw/arm-misc.h @@ -45,9 +45,9 @@ struct arm_boot_info

[Qemu-devel] [PATCH qom-next 06/22] tosa: Rename PXA2xxState variable

2012-05-14 Thread Andreas Färber
Avoid cpu->cpu by using "mpu" as variable name. Signed-off-by: Andreas Färber --- hw/tosa.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/tosa.c b/hw/tosa.c index d1ede8d..8bae80d 100644 --- a/hw/tosa.c +++ b/hw/tosa.c @@ -212,14 +212,14 @@ static void

[Qemu-devel] [PATCH qom-next 19/22] arm_pic: Pass ARMCPU to arm_pic_init_cpu()

2012-05-14 Thread Andreas Färber
Pass it through to arm_pic_cpu_handler(). Signed-off-by: Andreas Färber --- hw/arm-misc.h |2 +- hw/arm_pic.c |8 +--- hw/armv7m.c |2 +- hw/exynos4210.c |3 ++- hw/highbank.c |5 ++--- hw/integratorcp.c |2 +- hw/musicpal.c |2 +- hw/omap

[Qemu-devel] [PATCH qom-next 20/22] pxa2xx: Pass ARMCPU to pxa2xx_pic_init()

2012-05-14 Thread Andreas Färber
Cleans up after storing ARMCPU in PXA2xxState. Prepares for storing ARMCPU in PXA2xxPICState. Signed-off-by: Andreas Färber --- hw/pxa.h|2 +- hw/pxa2xx.c |4 ++-- hw/pxa2xx_pic.c |3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/pxa.h b/hw/pxa.h i

[Qemu-devel] [PATCH qom-next 15/22] arm_boot: Pass ARMCPU to arm_load_kernel()

2012-05-14 Thread Andreas Färber
In particular this simplifies the &s->mpu->cpu->env expression again. first_cpu and ->next_cpu are expected to be QOM'ified later. Signed-off-by: Andreas Färber --- hw/arm-misc.h |2 +- hw/arm_boot.c |4 ++-- hw/collie.c |2 +- hw/exynos4_boards.c |4 ++-- hw

[Qemu-devel] [PATCH qom-next 05/22] spitz: Rename PXA2xxState variable

2012-05-14 Thread Andreas Färber
Avoid cpu->cpu by using "mpu" as variable name. Signed-off-by: Andreas Färber --- hw/spitz.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index 9042d44..d320633 100644 --- a/hw/spitz.c +++ b/hw/spitz.c @@ -884,7 +884,7

[Qemu-devel] [PATCH qom-next 11/22] versatilepb: Use cpu_arm_init() to obtain ARMCPU

2012-05-14 Thread Andreas Färber
Needed for arm_load_kernel(). Signed-off-by: Andreas Färber --- hw/versatilepb.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 7c79c54..d567af9 100644 --- a/hw/versatilepb.c +++ b/hw/versatilepb.c @@ -173,7 +173,7 @

[Qemu-devel] [PATCH qom-next 08/22] strongarm: Use cpu_arm_init() to store ARMCPU in StrongARMState

2012-05-14 Thread Andreas Färber
Adapt collie accordingly. Signed-off-by: Andreas Färber --- hw/collie.c|2 +- hw/strongarm.c |6 +++--- hw/strongarm.h |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/collie.c b/hw/collie.c index 42f4310..e6f8dbf 100644 --- a/hw/collie.c +++ b/hw/collie.c

Re: [Qemu-devel] [PATCH for-1.1 01/22] arm_boot: Fix typos in comment

2012-05-14 Thread Stefan Weil
Am 14.05.2012 19:31, schrieb Andreas Färber: mimicing -> mimicking thei -> the Signed-off-by: Andreas Färber --- hw/arm-misc.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm-misc.h b/hw/arm-misc.h index 2f46e21..5302ee8 100644 --- a/hw/arm-misc.h +++ b/hw

[Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-safe functions

2012-05-14 Thread Luiz Capitulino
POSIX mandates[1] that a child process of a multi-thread program uses only async-signal-safe functions before exec(). We consider qemu-ga to be multi-thread, because it uses glib. However, qmp_guest_shutdown() uses functions that are not async-signal-safe. Fix it the following way: - fclose() ->

[Qemu-devel] [PATCH qom-next 12/22] xilinx_zynq: Use cpu_arm_init() to obtain ARMCPU

2012-05-14 Thread Andreas Färber
The board initializes only one CPU, so replace first_cpu with that CPU's state to facilitate review of arm_load_kernel() signature change and to avoid double casts then. Signed-off-by: Andreas Färber --- hw/xilinx_zynq.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff -

Re: [Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-safe functions

2012-05-14 Thread Eric Blake
On 05/14/2012 11:40 AM, Luiz Capitulino wrote: > POSIX mandates[1] that a child process of a multi-thread program uses > only async-signal-safe functions before exec(). We consider qemu-ga > to be multi-thread, because it uses glib. > > However, qmp_guest_shutdown() uses functions that are not > a

Re: [Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-safe functions

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 11:51:13 -0600 Eric Blake wrote: > On 05/14/2012 11:40 AM, Luiz Capitulino wrote: > > POSIX mandates[1] that a child process of a multi-thread program uses > > only async-signal-safe functions before exec(). We consider qemu-ga > > to be multi-thread, because it uses glib. > >

[Qemu-devel] [PATCH qom-next 13/22] arm_boot: Pass ARMCPU to arm_boot_info::write_secondary_boot()

2012-05-14 Thread Andreas Färber
Adapt exynos4210 and highbank accordingly. The parameter itself is unused. Signed-off-by: Andreas Färber --- hw/arm-misc.h |2 +- hw/arm_boot.c |6 +++--- hw/exynos4210.c |2 +- hw/exynos4210.h |2 +- hw/highbank.c |2 +- 5 files changed, 7 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-safe functions

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 15:01:17 -0300 Luiz Capitulino wrote: > > > + > > > +ret = execle("/sbin/shutdown", "shutdown", shutdown_flag, "+0", > > > +"hypervisor initiated shutdown", (char*)NULL, > > > environ); > > > > Where was 'environ' declared? POSIX says that enviro

[Qemu-devel] [PATCH qom-next 16/22] realview: Use cpu_arm_init() to obtain ARMCPU

2012-05-14 Thread Andreas Färber
Needed for arm_pic_init_cpu(). Signed-off-by: Andreas Färber --- hw/realview.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/realview.c b/hw/realview.c index d60435f..38085f1 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -50,7 +50,8 @@ static void realv

[Qemu-devel] [PATCH qom-next 03/22] palm: Rename omap_mpu_state_s variable

2012-05-14 Thread Andreas Färber
Avoid cpu->cpu by using "mpu" as variable name. Signed-off-by: Andreas Färber --- hw/palm.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/palm.c b/hw/palm.c index 6d81829..1375b19 100644 --- a/hw/palm.c +++ b/hw/palm.c @@ -196,7 +196,7 @@ static void palm

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

2012-05-14 Thread Michael Roth
On Mon, May 14, 2012 at 11:17:18AM -0600, Eric Blake wrote: > On 05/14/2012 11:06 AM, Michal Privoznik wrote: > > On 11.05.2012 21:19, Luiz Capitulino wrote: > >> The main motivation for this series is fixing two possible race conditions > >> in the guest-suspend-* API due to the complexity that ar

  1   2   3   >