O.K., the first thing you need to know is llvm-gcc uses GCC as it's
frontend to parse your source code, and uses LLVM as it's backend to
generate binary. In order to support global register correctly, not only
the frontend has to be able to recognize the global register syntax, but
also the LLVM ba
Changes in v5:
Rebase to latest head.
Add Checking of divider, because it also can stop the update.
Fixing some bugs.
Changes in v4:
Rebase to latest head.
Changing in patch 6:
Set the timer to one second earlier before target alarm when AF bit is
clear. In version 3, in order to solve t
There are no need to run a periodic timer to emulate updated-end
logic. Only run the timer when the UF or AF was clear.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 94 +
1 files changed, 86 insertions(+), 8 deletions(-)
diff --git a/hw/
& there is no configure option to avoid using global registers ?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
New
Bug description:
Froz
On 08.05.2012 23:35, Jan Kiszka wrote:
> Hi,
>
> I hunted down a fairly subtle corruption of the VCPU thread signal mask
> in KVM mode when using the ucontext version of coroutines:
>
> coroutine_new calls getcontext, makecontext, swapcontext. Those
> functions get/set also the signal mask of the
The first update cycle begins one - half seconds later when divider
reset is removing.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 61 +
1 files changed, 51 insertions(+), 10 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
The UIP(update in progress) is set when RTC is updating. And the update cycle
begins 244us later after UIP is set. And it is cleared when update end.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/mc14
Add alarm support.
Set the timer to one second earlier before target alarm when AF bit is clear.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 273 ++
1 files changed, 254 insertions(+), 19 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/m
You can try to configure QEMU to use TCI (interpreter) rather then TCG
(jitter). IIRC, TCI doesn't use global register.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work wit
There has no need to use two periodic timer to update RTC time. In this patch,
we only update it when guest reading it.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 207 +-
1 files changed, 66 insertions(+), 141 deletions(-)
diff --git a
On Tue, May 08, 2012 at 09:56:10PM +0400, Michael Tokarev wrote:
> On 08.05.2012 10:43, Gerd Hoffmann wrote:
> > Hi,
> >
> >>> bootindex=1 for virtio
> >>
> >> -drive file=winguest.raw,if=virtio,bootindex=1 --
> >>
> >> this does not work:
> >
> > Oops. I through it does, but seems this is onl
Change DM(date mode) and 24/12 control bit don't affect the internal registers.
It only indicates what format is using for those registers. So we don't need to
update time format when it is modified.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 10 +-
1 files changed, 1 insertion
Can you please show me where to find configure options or specific
options to accomplish that ?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
On Wed, May 09, 2012 at 12:07:04AM +0200, Alexander Graf wrote:
>
> On 08.05.2012, at 22:14, Eduardo Habkost wrote:
>
> > On Tue, May 08, 2012 at 02:58:11AM +0200, Alexander Graf wrote:
> >> On 07.05.2012, at 20:21, Eduardo Habkost wrote:
> >>
> >>>
> >>> Andre? Are you able to help to answer t
The new logic is compatible with old. So should not block to migrate
from old version. But new version cannot migrate to old.
Signed-off-by: Yang Zhang
---
hw/mc146818rtc.c | 35 +++
1 files changed, 31 insertions(+), 4 deletions(-)
diff --git a/hw/mc146818rtc.
On Wed, May 09, 2012 at 08:05:25AM -, Stevan Vucenovic wrote:
> Can you please show me where to find configure options or specific
> options to accomplish that ?
`../qemu/configure --enable-tcg-interpreter` will use TCI not TCG.
You can use `configure --help` to see what options it provides.
`../qemu/configure --enable-tcg-interpreter` will use TCI not TCG. You
can use `configure --help` to see what options it provides.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does n
On 09.05.2012, at 10:14, Gleb Natapov wrote:
> On Wed, May 09, 2012 at 12:07:04AM +0200, Alexander Graf wrote:
>>
>> On 08.05.2012, at 22:14, Eduardo Habkost wrote:
>>
>>> On Tue, May 08, 2012 at 02:58:11AM +0200, Alexander Graf wrote:
On 07.05.2012, at 20:21, Eduardo Habkost wrote:
Original Message
Subject: buildbot failure in qemu on openbsd-default
Date: Tue, 08 May 2012 19:30:00 +0200
From: build...@spunk.home.kraxel.org
To: kraxel+allbuild...@gmail.com
The Buildbot has detected a failed build on builder openbsd-default
while building qemu.
Full detail
On Wed, May 09, 2012 at 03:24:52PM +0800, Amos Kong wrote:
> Boot up a Linux VM with 8 pci block devices which
> are the 8 functions in one pci slot.
> | # qemu-kvm ...
> | -drive file=images/u0,if=none,id=drv0,format=qcow2,cache=none \
> | -device virtio-blk-pci,drive=drv0,id=v0,multifunction=on,a
On Wed, May 09, 2012 at 10:42:26AM +0200, Alexander Graf wrote:
>
>
> On 09.05.2012, at 10:14, Gleb Natapov wrote:
>
> > On Wed, May 09, 2012 at 12:07:04AM +0200, Alexander Graf wrote:
> >>
> >> On 08.05.2012, at 22:14, Eduardo Habkost wrote:
> >>
> >>> On Tue, May 08, 2012 at 02:58:11AM +020
I was thinking there must be something like that ;-) thanks! btw why
this site is so nazi about deleting or editing comments ? :-] makes me
feel like I am in court in murder trial
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https:
On 09/05/12 16:46, Michael S. Tsirkin wrote:
On Wed, May 09, 2012 at 03:24:52PM +0800, Amos Kong wrote:
Boot up a Linux VM with 8 pci block devices which
are the 8 functions in one pci slot.
| # qemu-kvm ...
| -drive file=images/u0,if=none,id=drv0,format=qcow2,cache=none \
| -device virtio-blk-p
On 09.05.2012, at 10:51, Gleb Natapov wrote:
> On Wed, May 09, 2012 at 10:42:26AM +0200, Alexander Graf wrote:
>>
>>
>> On 09.05.2012, at 10:14, Gleb Natapov wrote:
>>
>>> On Wed, May 09, 2012 at 12:07:04AM +0200, Alexander Graf wrote:
On 08.05.2012, at 22:14, Eduardo Habkost wrote
It works! with --enable-tcg-interpreter!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
New
Bug description:
Frozen on start.
CPU: dua
You can send launchpad a bug report talking about this. ;-)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
New
Bug description:
Frozen on
So O.K. to close? :-)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
New
Bug description:
Frozen on start.
CPU: dual-core 64-bit penry
Sure! thanks again!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
New
Bug description:
Frozen on start.
CPU: dual-core 64-bit penryn
** Visibility changed to: Public
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/996303
Title:
does not work with clang
Status in QEMU:
New
Bug description:
Frozen on start.
CPU: dual-core 6
On Wed, May 09, 2012 at 11:05:58AM +0200, Alexander Graf wrote:
>
> On 09.05.2012, at 10:51, Gleb Natapov wrote:
>
> > On Wed, May 09, 2012 at 10:42:26AM +0200, Alexander Graf wrote:
> >>
> >>
> >> On 09.05.2012, at 10:14, Gleb Natapov wrote:
> >>
> >>> On Wed, May 09, 2012 at 12:07:04AM +020
NULL pointer dereference in case no vnc server is configured.
Catch this and return -EINVAL like vnc_display_password() does.
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index deb9ecd..4408110 100644
--
Am 09.05.2012 11:23, schrieb Jim Meyering:
> From: Jim Meyering
>
> * parse_vdiname: Use pstrcpy, not strncpy, when the destination
> buffer must be NUL-terminated.
> * sd_open: Likewise, avoid buffer overrun.
> * do_sd_create: Likewise. Leave the preceding memset, since
> pstrcpy does not NUL-f
Am 09.05.2012 11:23, schrieb Jim Meyering:
> From: Jim Meyering
>
> Also, use PATH_MAX, rather than the arbitrary 1024.
> Using PATH_MAX is more consistent with other filename-related
> variables in this file, like backing_filename and tmp_filename.
>
> Signed-off-by: Jim Meyering
Not absolute
This is an updated patchset for megasas. Upon popular demand
I've split it into three parts, the header file, the emulation
itself, and a patch adding trace events to the emulation.
Changes since v15:
- Move to new SCSI API
- Use generic trace functions for DCMDs
- Replace bitfields with defines
-
This patch adds the header file for megasas.
Signed-off-by: Hannes Reinecke
---
hw/mfi.h | 1248 ++
1 files changed, 1248 insertions(+), 0 deletions(-)
create mode 100644 hw/mfi.h
diff --git a/hw/mfi.h b/hw/mfi.h
new file mode 100644
Am 09.05.2012 11:24, schrieb Jim Meyering:
> From: Jim Meyering
>
>
> Signed-off-by: Jim Meyering
Acked-by: Kevin Wolf
Looks VERY good, ACK!
The DVD drive works now!
On May 8, 2012 at 2:06 PM Gerd Hoffmann wrote:
> Most important here is to update our internal endpoint state so we know
> the endpoint isn't in halted state any more. Without this usb-host
> tries to clear halt again with the next data transfer
Am 08.05.2012 21:35, schrieb Jan Kiszka:
> Hi,
>
> I hunted down a fairly subtle corruption of the VCPU thread signal mask
> in KVM mode when using the ucontext version of coroutines:
>
> coroutine_new calls getcontext, makecontext, swapcontext. Those
> functions get/set also the signal mask of t
On 09/05/12 16:59, Amos Kong wrote:
On 09/05/12 16:46, Michael S. Tsirkin wrote:
On Wed, May 09, 2012 at 03:24:52PM +0800, Amos Kong wrote:
Boot up a Linux VM with 8 pci block devices which
are the 8 functions in one pci slot.
| # qemu-kvm ...
| -drive file=images/u0,if=none,id=drv0,format=qcow
Am 09.05.2012 11:23, schrieb Jim Meyering:
> From: Jim Meyering
>
> strncpy does not guarantee NUL-termination.
> Setting dest[n-1] = '\0' *before* calling strncpy(dest, src, n-1)
> is a no-op. Use pstrcpy to ensure NUL-termination, not strncpy.
It's not, it would only be a no-op before strncpy
On 05/09/2012 02:28 AM, Andreas Färber wrote:
Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3,
based on patches by malc.
Also adjust the registers clobbered, based on patch by Alex.
Signed-off-by: Andreas Färber
---
tcg/ppc/tcg-target.c | 37
This patch add trace events to the megasas HBA emulation.
Signed-off-by: Hannes Reinecke
---
hw/megasas.c | 297 --
trace-events | 79
2 files changed, 328 insertions(+), 48 deletions(-)
diff --git a/hw/megasas.c b/hw/m
On 05/09/2012 02:43 AM, malc wrote:
On Wed, 9 May 2012, Andreas F?rber wrote:
Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3,
based on patches by malc.
Also adjust the registers clobbered, based on patch by Alex.
Alexander, my head is splitting now, so i can not calculate th
On 05/09/2012 11:38 AM, Gleb Natapov wrote:
On Wed, May 09, 2012 at 11:05:58AM +0200, Alexander Graf wrote:
On 09.05.2012, at 10:51, Gleb Natapov wrote:
On Wed, May 09, 2012 at 10:42:26AM +0200, Alexander Graf wrote:
On 09.05.2012, at 10:14, Gleb Natapov wrote:
On Wed, May 09, 2012 at 12:
On 05/09/2012 02:33 AM, malc wrote:
On Wed, 9 May 2012, Andreas F?rber wrote:
Hello malc,
Here's an updated series to fix AREG0 and ppc build.
Debian/sparc fsck on Darwin/ppc now succeeds. No regressions noticed with
Debian/sparc, HelenOS/sparc64, Haiku/i386, Haiku/x86_64.
Regards,
Andreas
On 03/05/12 16:33, Peter Maydell wrote:
>> Since load_image_targphys is declared as taking an int for max_sz, this will
>> fail for ram sizes > INT_MAX.
>> Lets change the max_sz parameter to a uint64_t.
>>
>> Signed-off-by: Christian Borntraeger
>
> A patch equivalent to this has already been su
Am 09.05.2012 12:27, schrieb Alexander Graf:
> On 05/09/2012 02:28 AM, Andreas Färber wrote:
>> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3,
>> based on patches by malc.
>>
>> Also adjust the registers clobbered, based on patch by Alex.
>>
>> Signed-off-by: Andreas Färber
>> --
On 05/07/2012 06:28 PM, Alexander Graf wrote:
> Hi Fabien,
>
> Could you please elaborate a bit on the case that broke for you with these?
> The patches shouldn't change any guest facing behavior :o.
>
>
My bad,
The problem comes from my initialization of tlb entries at board reset.
I use MAS
On 2012-05-09 07:11, Kevin Wolf wrote:
> Am 08.05.2012 21:35, schrieb Jan Kiszka:
>> Hi,
>>
>> I hunted down a fairly subtle corruption of the VCPU thread signal mask
>> in KVM mode when using the ucontext version of coroutines:
>>
>> coroutine_new calls getcontext, makecontext, swapcontext. Those
On 2012-05-09 04:32, Michael Tokarev wrote:
> On 08.05.2012 23:35, Jan Kiszka wrote:
>> Hi,
>>
>> I hunted down a fairly subtle corruption of the VCPU thread signal mask
>> in KVM mode when using the ucontext version of coroutines:
>>
>> coroutine_new calls getcontext, makecontext, swapcontext. Tho
On 9 May 2012 11:11, Kevin Wolf wrote:
> Am 08.05.2012 21:35, schrieb Jan Kiszka:
>> I hunted down a fairly subtle corruption of the VCPU thread signal mask
>> in KVM mode when using the ucontext version of coroutines:
>>
>> coroutine_new calls getcontext, makecontext, swapcontext. Those
>> functi
The guest drivers should already know how to use async for revision 3.
But since it's still possible to have an older driver with revision 3
that doesn't check for the revision, require a new parameter
"force_async", which we can later turn to 1 by default.
Signed-off-by: Alon Levy
---
hw/qxl.c
On 2012-05-09 08:15, Peter Maydell wrote:
> On 9 May 2012 11:11, Kevin Wolf wrote:
>> Am 08.05.2012 21:35, schrieb Jan Kiszka:
>>> I hunted down a fairly subtle corruption of the VCPU thread signal mask
>>> in KVM mode when using the ucontext version of coroutines:
>>>
>>> coroutine_new calls getc
On Wed, May 09, 2012 at 11:23:58AM +0200, Jim Meyering wrote:
> From: Jim Meyering
>
> Don't use strncpy when the source string is known to fit
> in the destination buffer. Use equivalent memcpy.
> We could even use strcpy, here, but some static analyzers
> warn about that, so don't add new uses
Am 09.05.2012 14:09, schrieb Jim Meyering:
> Kevin Wolf wrote:
>> Am 09.05.2012 11:23, schrieb Jim Meyering:
>>> From: Jim Meyering
>>>
>>> strncpy does not guarantee NUL-termination.
>>> Setting dest[n-1] = '\0' *before* calling strncpy(dest, src, n-1)
>>> is a no-op. Use pstrcpy to ensure NUL-t
Am 08.05.2012 16:51, schrieb Paolo Bonzini:
> QED's opaque data includes a pointer back to the BlockDriverState.
> This breaks when bdrv_append shuffles data between bs_new and bs_top.
> To avoid this, add a "rebind" function that tells the driver about
> the new relationship between the BlockDrive
Am 08.05.2012 16:51, schrieb Paolo Bonzini:
> We are reusing bs->file across close/open, which may not cause any
> known bugs but is a recipe for trouble. Prefer bdrv_delete, and
> enjoy the new invariant in the implementation of bdrv_delete.
>
> Signed-off-by: Paolo Bonzini
I think bs->file is
Hi all,
this patch series is a collection of the outstanding Xen patches for
QEMU 1.1: all of them have been sent to qemu-devel at least once
already, some of them as many as 6 times.
Patch 1 and 2 remove unneeded devices and timers when Xen is enabled,
patch 3 and 4 are improvements for xen_disk.
On Thu, 26 Apr 2012, Konrad Rzeszutek Wilk wrote:
> On Wed, Apr 25, 2012 at 01:23:35PM +0200, Christoph Hellwig wrote:
> > On Wed, Apr 25, 2012 at 12:21:53PM +0100, Stefano Stabellini wrote:
> > > That is true, in fact I couldn't figure out what I had to implement just
> > > reading the comment. So
This patch removes a dead option.
The same can be achieved removing BDRV_O_NOCACHE and BDRV_O_CACHE_WB
from the flags passed to bdrv_open.
Signed-off-by: Stefano Stabellini
---
hw/xen_disk.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/hw/xen_disk.c b/hw/xen_d
Am 08.05.2012 16:51, schrieb Paolo Bonzini:
> qemu-io's cvtstr function sometimes will incorrectly omit the
> decimal part of the number, and sometimes will incorrectly include
> it. This patch fixes both. The former is more serious, and can
> be seen in the patches to 027.out and 033.out.
>
> T
Il 09/05/2012 14:46, Kevin Wolf ha scritto:
>> > The changes to all other files were scripted with sed, so there were
>> > no "surprises" beyond 027.out and 033.out.
>> >
>> > Signed-off-by: Paolo Bonzini
>> > ---
>> > 035.out has an extra long line which stumps git send-email,
>> >
On 05/09/12 13:26, Alon Levy wrote:
> The guest drivers should already know how to use async for revision 3.
> But since it's still possible to have an older driver with revision 3
> that doesn't check for the revision, require a new parameter
> "force_async", which we can later turn to 1 by defaul
Use bdrv_aio_flush instead of bdrv_flush.
Make sure to call bdrv_aio_writev/readv after the presync bdrv_aio_flush is
fully
completed and make sure to call the postsync bdrv_aio_flush after
bdrv_aio_writev/readv is fully completed.
Signed-off-by: Stefano Stabellini
---
hw/xen_disk.c | 22 +++
Il 09/05/2012 14:22, Kevin Wolf ha scritto:
> Am 08.05.2012 16:51, schrieb Paolo Bonzini:
>> We are reusing bs->file across close/open, which may not cause any
>> known bugs but is a recipe for trouble. Prefer bdrv_delete, and
>> enjoy the new invariant in the implementation of bdrv_delete.
>>
>>
From: Jim Meyering
v9fs_add_dir_node and qemu_v9fs_synth_add_file used strncpy
to form node->name, which requires NUL-termination, but
strncpy does not ensure NUL-termination.
Use pstrcpy, which does.
Signed-off-by: Jim Meyering
---
hw/9pfs/virtio-9p-synth.c | 4 ++--
1 file changed, 2 inserti
On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA.
I've tested it to work with Linux, Windows Vista, and Windows7.
agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157890
ERROR: return is not a function, parentheses are not
On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
This patch add trace events to the megasas HBA emulation.
agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157891
WARNING: line over 80 characters
#233: FILE: hw/megasas.c:872:
+offset + sizeof(
Signed-off-by: Paolo Bonzini
---
v1->v2: Delete mid_img in the tearDown() method.
tests/qemu-iotests/030 | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 0d2f87b..fbc2175 100755
--- a/
Some bug in VirtualBox: https://www.virtualbox.org/ticket/10532
** Bug watch added: Virtualbox Trac #10532
http://www.virtualbox.org/ticket/10532
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/9967
Il 09/05/2012 09:22, Zhang, Yang Z ha scritto:
> Changes in v5:
> Rebase to latest head.
> Add Checking of divider, because it also can stop the update.
> Fixing some bugs.
At last this passes my tests, great! There's still a few problems, but more
or less it's ok:
1) it needs rebase on top of t
Jim Meyering writes:
> From: Jim Meyering
>
> In both mp_pacl_listxattr and mp_dacl_listxattr, the uses of strncpy
> were unnecessary, since at each point of use we know that the
> NUL-terminated source bytes fit in the destination buffer.
> Use memcpy in place of strncpy.
>
> Signed-off-by: Jim
Jim Meyering writes:
> From: Jim Meyering
>
> v9fs_add_dir_node and qemu_v9fs_synth_add_file used strncpy
> to form node->name, which requires NUL-termination, but
> strncpy does not ensure NUL-termination.
> Use pstrcpy, which does.
>
> Signed-off-by: Jim Meyering
Acked-by: Aneesh Kumar K.V
Jim Meyering writes:
> From: Jim Meyering
>
> The use of strncpy in pt_listxattr is unnecessary, since we
> know that the NUL-terminated source bytes fit in the destination
> buffer. Use memcpy in place of strncpy.
>
> Signed-off-by: Jim Meyering
Fold this with Patch 11 ?
Reviewed-by: Aneesh
Jim Meyering writes:
> From: Jim Meyering
>
> The use of strncpy in mp_user_listxattr is unnecessary, since we
> know that the NUL-terminated source bytes fit in the destination
> buffer. Use memcpy in place of strncpy.
>
> Signed-off-by: Jim Meyering
May be this can be folded into the earli
From: Jim Meyering
A terminal NUL is required by caller's use of strchr.
It's better not to use strncpy at all, since there is no need
to zero out hundreds of trailing bytes for each iteration.
Signed-off-by: Jim Meyering
---
target-ppc/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
On Wed, May 09, 2012 at 02:51:01PM +0200, Gerd Hoffmann wrote:
> On 05/09/12 13:26, Alon Levy wrote:
> > The guest drivers should already know how to use async for revision 3.
> > But since it's still possible to have an older driver with revision 3
> > that doesn't check for the revision, require
The size of EPN field in MAS2 depends on page size. This patch adds a
mask to discard invalid bits in EPN field.
Definition of EPN field from e500v2 RM:
EPN Effective page number: Depending on page size, only the bits
associated with a page boundary are valid. Bits that represent offsets
within a
On 9 May 2012 10:23, Jim Meyering wrote:
> From: Jim Meyering
>
> Remove unnecessary and unchecked uses of strdup,
> and add a comment that this strncpy use is ok.
>
> Signed-off-by: Jim Meyering
> ---
> linux-user/elfload.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>
From: Jim Meyering
Adjust all uses s/strzcpy/strncpy/ and mark these uses
of strncpy as "ok".
Signed-off-by: Jim Meyering
---
hw/acpi.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index 5d521e5..45ab345 100644
--- a/hw/acp
On Wed, 9 May 2012 11:24:00 +0200
Jim Meyering wrote:
> From: Jim Meyering
>
> NUL-termination of the .ifr_name field is not required, but is fine
> (and preferable to using strncpy and leaving the reader to wonder),
> since the first thing the linux kernel does is to clear the last byte.
> Be
From: Jim Meyering
Don't bother with strncpy. There's no need for its zero-fill.
Use g_strndup in place of g_malloc+strncpy+NUL-terminate.
Signed-off-by: Jim Meyering
---
ui/vnc-auth-sasl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth
Am 08.05.2012 16:51, schrieb Paolo Bonzini:
> Either FIEMAP, or SEEK_DATA+SEEK_HOLE can be used to implement the
> is_allocated callback for raw files. Ext4, btrfs and XFS all support
> it.
>
> Signed-off-by: Paolo Bonzini
This is for 1.2, I'll queue it in block-next.
> ---
> block/raw-posix.
Peter Maydell wrote:
> On 9 May 2012 10:23, Jim Meyering wrote:
>> From: Jim Meyering
>>
>> Remove unnecessary and unchecked uses of strdup,
>> and add a comment that this strncpy use is ok.
>>
>> Signed-off-by: Jim Meyering
>> ---
>> linux-user/elfload.c | 10 ++
>> 1 file changed, 6 i
On Wed, 2012-05-09 at 15:24 +0800, Amos Kong wrote:
> Boot up a Linux VM with 8 pci block devices which
> are the 8 functions in one pci slot.
> | # qemu-kvm ...
> | -drive file=images/u0,if=none,id=drv0,format=qcow2,cache=none \
> | -device virtio-blk-pci,drive=drv0,id=v0,multifunction=on,addr=0x0
On 9 May 2012 14:42, Jim Meyering wrote:
> From 5dce6a052cdc2a45ada3e3e96a8c3ef4e90f Mon Sep 17 00:00:00 2001
> From: Jim Meyering
> Date: Mon, 7 May 2012 18:34:26 +0200
> Subject: [PATCH] linux-user: remove two unchecked uses of strdup
>
> Remove two uses of strdup (use g_path_get_basename i
From: Jim Meyering
os_set_proc_name: Use pstrcpy, in place of strncpy and the
ineffectual preceding assignment: name[sizeof(name) - 1] = 0;
Signed-off-by: Jim Meyering
---
os-posix.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index daf3d6f..2a
Am 08.05.2012 16:52, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini
> ---
> block/stream.c | 31 ++--
> include/qemu/ratelimit.h | 50
> ++
> 2 files changed, 52 insertions(+), 29 deletions(-)
> create mode
From: Jim Meyering
strncpy does not guarantee NUL-termination.
Setting dest[n-1] = '\0' *before* calling strncpy(dest, src, n-1)
is a no-op. Use pstrcpy to ensure NUL-termination, not strncpy.
Signed-off-by: Jim Meyering
---
block/vmdk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Jim Meyering
Also, use PATH_MAX, rather than the arbitrary 1024.
Using PATH_MAX is more consistent with other filename-related
variables in this file, like backing_filename and tmp_filename.
Signed-off-by: Jim Meyering
---
block.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-
From: Jim Meyering
Replace strncpy+NUL-terminate use with use of pstrcpy.
This requires linking with cutils.o (or else vssclient doesn't link),
so add that in the Makefile.
Signed-off-by: Jim Meyering
---
libcacard/Makefile | 2 +-
libcacard/vcard_emul_nss.c | 3 +--
2 files changed, 2
Am 08.05.2012 16:51, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/030 | 27 ++-
> tests/qemu-iotests/030.out |4 ++--
> 2 file changed, 28 insertions(+), 3 deletion(-)
>
> diff --git a/tests/qemu-iotests/030.out b/tests/qemu-i
On 9 May 2012 10:24, Jim Meyering wrote:
> From: Jim Meyering
>
> Adjust all uses s/strzcpy/strncpy/ and mark these uses
> of strncpy as "ok".
Note that this will conflict with Paolo's patch
http://patchwork.ozlabs.org/patch/151895/
"convert -acpitable to QemuOpts" which also gets rid
of the po
Peter Maydell wrote:
> On 9 May 2012 14:42, Jim Meyering wrote:
>> From 5dce6a052cdc2a45ada3e3e96a8c3ef4e90f Mon Sep 17 00:00:00 2001
>> From: Jim Meyering
>> Date: Mon, 7 May 2012 18:34:26 +0200
>> Subject: [PATCH] linux-user: remove two unchecked uses of strdup
>>
>> Remove two uses of strd
Kevin Wolf wrote:
> Am 09.05.2012 11:23, schrieb Jim Meyering:
>> From: Jim Meyering
>>
>> strncpy does not guarantee NUL-termination.
>> Setting dest[n-1] = '\0' *before* calling strncpy(dest, src, n-1)
>> is a no-op. Use pstrcpy to ensure NUL-termination, not strncpy.
>
> It's not, it would onl
From: Jim Meyering
Remove unnecessary and unchecked uses of strdup,
and add a comment that this strncpy use is ok.
Signed-off-by: Jim Meyering
---
linux-user/elfload.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
ind
Il 09/05/2012 15:40, Kevin Wolf ha scritto:
>> > +#ifndef SEEK_DATA
>> > +#define SEEK_DATA 3
>> > +#endif
>> > +#ifndef SEEK_HOLE
>> > +#define SEEK_HOLE 4
>> > +#endif
> How is that going to be portable? You assume that on non-Linux you'll
> get -EINVAL, but what does guarantee that 3 or 4 aren't
On 9 May 2012 15:01, Jim Meyering wrote:
> From 402100deb7e27b1d7ac619ebac963f861fae91b0 Mon Sep 17 00:00:00 2001
> From: Jim Meyering
> Date: Mon, 7 May 2012 18:34:26 +0200
> Subject: [PATCH] linux-user: remove two unchecked uses of strdup
>
> Remove two uses of strdup (use g_path_get_basename i
Make the code reusable.
Signed-off-by: Paolo Bonzini
---
v1->v2: Remove SLICE_TIME from ratelimit.h
block/stream.c | 31 ++
include/qemu/ratelimit.h | 48 ++
2 files changed, 50 insertions(+), 29 delet
Am 09.05.2012 16:05, schrieb Paolo Bonzini:
> Il 09/05/2012 15:40, Kevin Wolf ha scritto:
+#ifndef SEEK_DATA
+#define SEEK_DATA 3
+#endif
+#ifndef SEEK_HOLE
+#define SEEK_HOLE 4
+#endif
>> How is that going to be portable? You assume that on non-Linux you'll
>> get -EI
1 - 100 of 316 matches
Mail list logo
