Re: [Qemu-devel] [PATCH for-1.1] scripts/qemu-binfmt-conf.sh: Fix shell syntax

2012-05-08 Thread Paolo Bonzini
Il 07/05/2012 19:47, Andreas Färber ha scritto: > The script is organized as a sequence of binfmt registrations, with a > check whether the to be registered architecture matches the host. > > Add a missing fi for the SuperH section. > > Reported-by: Alexander Graf > Signed-off-by: Andreas Färber

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-08 Thread Dave Allan
FWIW, the idea of an IPMI interface to VMs was proposed for libvirt not too long ago. See: https://bugzilla.redhat.com/show_bug.cgi?id=815136 Dave On Mon, May 07, 2012 at 01:07:45PM -0500, Corey Minyard wrote: > I think we are getting a little out of hand here, and we are mixing > up concepts :

Re: [Qemu-devel] To run (replay) the intermediate micro-ops directly

2012-05-08 Thread 陳韋任
> Does anyone know, how to run(replay) the intermediate micro-ops directly? > > For example, I have traced some micro-op instructions, and want to see what > happens with these instructions(after being translated into host code and then > run). Probably with Graphic User Interface. > > Any approa

Re: [Qemu-devel] [PATCH 00/32] target-arm: refactor copro register implementation

2012-05-08 Thread Rusty Russell
(Accidentally made first reply to Peter only, fixed that now). On Mon, 7 May 2012 13:25:07 +0100, Peter Maydell wrote: > On 7 May 2012 08:23, Rusty Russell wrote: > > OK, I reviewed the infrastructure, and it looks excellent.  A few of > > minor quibbles, which I only mention to show that I rea

[Qemu-devel] [Bug 996303] [NEW] does not work with clang

2012-05-08 Thread Stevan Vucenovic
Public bug reported: Frozen on start. CPU: dual-core 64-bit penryn MacOS: 10.7.3-x86_64 Xcode: 4.3.2 CC: /usr/bin/clang CXX: /usr/bin/clang++ => /usr/bin/clang LD: /usr/bin/clang CFLAGS: -Os -w -pipe -march=native -Qunused-arguments CXXFLAGS: -Os -w -pipe -march=native -Qunused-arguments MAKEFLAG

Re: [Qemu-devel] [RFC] [PATCH 0/2] Sandboxing Qemu guests with Libseccomp

2012-05-08 Thread Daniel P. Berrange
On Fri, May 04, 2012 at 04:08:36PM -0300, Eduardo Otubo wrote: > Hello all, > > This is the first effort to sandboxing Qemu guests using Libseccomp[0]. The > patches that follows are pretty simple and straightforward. I added the > correct > options and checks to the configure script and the basi

Re: [Qemu-devel] [Bug 990364] [NEW] virtio_ioport_write: unexpected address 0x13 value 0x1

2012-05-08 Thread Yan Vugenfirer
You had a BSOD on a guest. NetKVM driver will write 1 to VIRTIO_PCI_ISR register in case of BSOD (we had BSOD callback in the driver). The callback will be called on any BSOD, so it doens't mean that the BSOD was due to virtio-net. Check the guest and check if there is memory dump available. B

Re: [Qemu-devel] [RFC] [PATCH 0/2] Sandboxing Qemu guests with Libseccomp

2012-05-08 Thread Stefano Stabellini
On Tue, 8 May 2012, Daniel P. Berrange wrote: > On Fri, May 04, 2012 at 04:08:36PM -0300, Eduardo Otubo wrote: > > Hello all, > > > > This is the first effort to sandboxing Qemu guests using Libseccomp[0]. The > > patches that follows are pretty simple and straightforward. I added the > > correct

[Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-08 Thread Gerd Hoffmann
Most important here is to update our internal endpoint state so we know the endpoint isn't in halted state any more. Without this usb-host tries to clear halt again with the next data transfer submitted. Doing this twice is (a) not correct and (b) confuses some usb devices, rendering them non-fun

Re: [Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-08 Thread Hans de Goede
Looks good, ACK. On 05/08/2012 02:06 PM, Gerd Hoffmann wrote: Most important here is to update our internal endpoint state so we know the endpoint isn't in halted state any more. Without this usb-host tries to clear halt again with the next data transfer submitted. Doing this twice is (a) not

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Anthony Liguori
On 05/07/2012 06:47 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. I've got a conflict at 9am as it turns out so I won't be able to attend. Regards, Anthony Liguori Thanks, Juan.

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 14:14, Anthony Liguori wrote: > On 05/07/2012 06:47 AM, Juan Quintela wrote: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > I've got a conflict at 9am as it turns out so I won't be able to attend. We can always move it an hour earlier, no?

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Christian Borntraeger
On 04/05/12 20:12, Alexander Graf wrote: > > On 04.05.2012, at 16:02, Christian Borntraeger wrote: > >> On 04/05/12 16:00, Christian Borntraeger wrote: > An IPL (booting) on s390 of SCSI disks is done by a firmware component. > Lets implement this scheme as an qemu device that also allows

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 14:32, Christian Borntraeger wrote: > On 04/05/12 20:12, Alexander Graf wrote: >> >> On 04.05.2012, at 16:02, Christian Borntraeger wrote: >> >>> On 04/05/12 16:00, Christian Borntraeger wrote: >> An IPL (booting) on s390 of SCSI disks is done by a firmware component.

Re: [Qemu-devel] [PATCH 17/26] qemu-io: fix the alloc command

2012-05-08 Thread Kevin Wolf
Am 12.04.2012 14:01, schrieb Paolo Bonzini: > Because sector_num is not updated, the loop would either go on > forever or return garbage. > > Signed-off-by: Paolo Bonzini > --- > qemu-io.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/qemu-io.c b/qemu-io.

Re: [Qemu-devel] [PATCH 17/26] qemu-io: fix the alloc command

2012-05-08 Thread Paolo Bonzini
Il 08/05/2012 14:57, Kevin Wolf ha scritto: >> > >> > diff --git a/qemu-io.c b/qemu-io.c >> > index 43643c8..27a0c3c 100644 >> > --- a/qemu-io.c >> > +++ b/qemu-io.c >> > @@ -1560,7 +1560,7 @@ out: >> > >> > static int alloc_f(int argc, char **argv) >> > { >> > -int64_t offset; >> > +i

Re: [Qemu-devel] [PATCH 1/6] qapi: add support for command options

2012-05-08 Thread Luiz Capitulino
On Mon, 7 May 2012 11:05:36 -0500 Michael Roth wrote: > On Fri, May 04, 2012 at 05:20:17PM -0300, Luiz Capitulino wrote: > > Options allow for changes in commands behavior. This commit introduces > > the QCO_NO_SUCCESS_RESP option, which causes a command to not emit a > > success response. > > >

Re: [Qemu-devel] [PATCH 17/26] qemu-io: fix the alloc command

2012-05-08 Thread Kevin Wolf
Am 08.05.2012 15:06, schrieb Paolo Bonzini: > Il 08/05/2012 14:57, Kevin Wolf ha scritto: diff --git a/qemu-io.c b/qemu-io.c index 43643c8..27a0c3c 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1560,7 +1560,7 @@ out: static int alloc_f(int argc, char **argv)

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Luiz Capitulino
On Tue, 08 May 2012 07:14:11 -0500 Anthony Liguori wrote: > On 05/07/2012 06:47 AM, Juan Quintela wrote: > > > > Hi > > > > Please send in any agenda items you are interested in covering. > > I've got a conflict at 9am as it turns out so I won't be able to attend. Does this mean the call is can

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. Anthony can't make the call, but we have one agenda: - Status of the 1.1 release We can always blame Anthony, as he didn't attend. - QEMU documentation We don't need him to know that it is in bad sh

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Andreas Färber
Am 07.05.2012 14:54, schrieb Anthony Liguori: > On 05/07/2012 06:47 AM, Juan Quintela wrote: >> >> Please send in any agenda items you are interested in covering. > > - Status of the 1.1 release Since it looked like the call is not going to take place lacking feedback from Anthony, I will provoca

Re: [Qemu-devel] [PATCH 17/26] qemu-io: fix the alloc command

2012-05-08 Thread Paolo Bonzini
Il 08/05/2012 15:16, Kevin Wolf ha scritto: > The commit message is talking about something different. Consider the > following image, x is allocated, . is unallocated: > > xxx...xxx > > bdrv_is_allocated(offset = 0, length = 9 * cluster_size) can tell you "2 > clusters allocated", for example be

Re: [Qemu-devel] [RFC] [PATCH 0/2] Sandboxing Qemu guests with Libseccomp

2012-05-08 Thread Corey Bryant
On 05/08/2012 07:32 AM, Stefano Stabellini wrote: On Tue, 8 May 2012, Daniel P. Berrange wrote: On Fri, May 04, 2012 at 04:08:36PM -0300, Eduardo Otubo wrote: Hello all, This is the first effort to sandboxing Qemu guests using Libseccomp[0]. The patches that follows are pretty simple and str

[Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Michael S. Tsirkin
The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git for you to fetch changes up to b

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Anthony Liguori
On 05/08/2012 09:10 AM, Andreas Färber wrote: Am 07.05.2012 14:54, schrieb Anthony Liguori: On 05/07/2012 06:47 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. - Status of the 1.1 release Since it looked like the call is not going to take place lack

[Qemu-devel] KVM minutes May 8th

2012-05-08 Thread Juan Quintela
Hi - Status of the 1.1 release It looks like everything is to the plan, and only bugfixes should be allowed now. - QEMU documentation * Improve properties. Now there is no help when you use -device. * Amit did something about it? Resurect that work? * People don't write documentation. * How

Re: [Qemu-devel] [RFC] [PATCH 0/2] Sandboxing Qemu guests with Libseccomp

2012-05-08 Thread Daniel P. Berrange
On Tue, May 08, 2012 at 10:10:25AM -0400, Corey Bryant wrote: > > > On 05/08/2012 07:32 AM, Stefano Stabellini wrote: > >On Tue, 8 May 2012, Daniel P. Berrange wrote: > >>On Fri, May 04, 2012 at 04:08:36PM -0300, Eduardo Otubo wrote: > >>>Hello all, > >>> > >>>This is the first effort to sandboxi

[Qemu-devel] [PATCH v4 0/7] trace: Generic event state description

2012-05-08 Thread Lluís Vilanova
Provides a generic event state description and a more detailed event control and query interface. Signed-off-by: Lluís Vilanova --- Changes in v4: * Documentation fixes and (re)formatting. Changes in v3: * Add some assertions. * Remove debugging printf's. * Improve documentation. * Make 't

[Qemu-devel] [PATCH v4 2/7] trace: Provide a generic tracing event descriptor

2012-05-08 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description. Signed-off-by: Lluís Vilanova --- Makefile |5 +++ Makefile.objs| 21 ++ scripts/tracetool/backend/events.py | 23 scripts/traceto

[Qemu-devel] [PATCH v4 1/7] tracetool: Explicitly identify public backends

2012-05-08 Thread Lluís Vilanova
Public backends are those printed by "--list-backends" and thus considered valid by the configure script. Signed-off-by: Lluís Vilanova --- scripts/tracetool.py |4 ++-- scripts/tracetool/backend/__init__.py | 16 +++- scripts/tracetool/backend/dtrace.py |

[Qemu-devel] [PATCH v4 3/7] trace: Provide a detailed event control interface

2012-05-08 Thread Lluís Vilanova
This interface decouples event obtention from interaction. Events can be obtained through three different methods: * identifier * name * simple wildcard pattern Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 42 -- trace/control-internal.h | 60 +++ trace/

[Qemu-devel] [PATCH v4 7/7] trace: [stderr] Port to generic event information and new control interface

2012-05-08 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/stderr.py | 27 --- trace/stderr.c | 35 +++ 2 files changed, 15 insertions(+), 47 deletions(-) diff --git a/scripts/tracetool/backend/stderr.py b/scripts

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Michael S. Tsirkin
On Tue, May 08, 2012 at 05:20:12PM +0300, Michael S. Tsirkin wrote: > The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: > > hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 > 16:31:40 +0400) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Anthony Liguori
On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/vi

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Christian Borntraeger
>> Anthony, this is the prototype of the IPL device that we have talked about >> some weeks >> ago. Is an external device to do the IPL process for s390 still ok with you? > > Even with an external IPL, we should still be able to detect that a guest > provides > its own virtio-zipl code that co

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Avi Kivity
On 05/08/2012 05:40 PM, Anthony Liguori wrote: > On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: >> The following changes since commit >> 847c25d01cbe8e4fe457a7426f82daaaf3287aae: >> >>hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes >> (2012-05-07 16:31:40 +0400) >> >> are availa

[Qemu-devel] [PATCH v4 6/7] trace: [simple] Port to generic event information and new control interface

2012-05-08 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 12 +-- trace/simple.c | 37 +-- trace/simple.h |6 +- trace/stderr.h | 11 -- 4 files changed, 11 i

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Anthony Liguori
On 05/08/2012 09:43 AM, Avi Kivity wrote: On 05/08/2012 05:40 PM, Anthony Liguori wrote: On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 1

[Qemu-devel] [PATCH 1.1 00/22] Rebased queue of block patches.

2012-05-08 Thread Paolo Bonzini
Here is my queue, rebased and retested. Patches up to 18 are bugfixes. Patches at 19 and above are increasingly borderline. Based on kwolf/block, tested with "make check-block". Paolo Bonzini (23): block: fix snapshot on QED block: another bdrv_append fix block: do not reuse the backing fi

[Qemu-devel] [PATCH 1.1 02/22] block: another bdrv_append fix

2012-05-08 Thread Paolo Bonzini
bdrv_append must also copy open_flags to the top, because the snapshot has BDRV_O_NO_BACKING set. This causes interesting results if you later use drive-reopen (not upstream) to reopen the image, and lose the backing file in the process. Signed-off-by: Paolo Bonzini --- block.c |1 + 1 file

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Michael S. Tsirkin
On Tue, May 08, 2012 at 09:40:54AM -0500, Anthony Liguori wrote: > On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: > >The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: > > > > hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 > > 16:31:40 +0400

[Qemu-devel] [PATCH v11 0/4] support to migrate with IPv6 address

2012-05-08 Thread Amos Kong
Those patches updated help functions in qemu-socket.c, and used them in migrate-tcp.c to support IPv6 migration. --- Changes from v1: - split different changes to small patches, it will be easier to review - fixed some problem according to Kevin's comment Changes from v2: - fix issue of returning

[Qemu-devel] [PATCH v11 1/4] qerror: add five qerror strings

2012-05-08 Thread Amos Kong
Add five new qerror strings, they are about listen/connect socket: QERR_SOCKET_CONNECT_IN_PROGRESS QERR_SOCKET_CONNECT_FAILED QERR_SOCKET_LISTEN_FAILED QERR_SOCKET_BIND_FAILED QERR_SOCKET_CREATE_FAILED Signed-off-by: Amos Kong Reviewed-by: Orit Wasserman --- qerror.c | 20 ++

[Qemu-devel] [PATCH v11 2/4] sockets: change inet_connect() to support nonblock socket

2012-05-08 Thread Amos Kong
Add a bool argument to inet_connect() to assign if set socket to block/nonblock, and delete original argument 'socktype' that is unused. Add a new argument to inet_connect()/inet_connect_opts(), to pass back connect error by error class. Retry to connect when -EINTR is got. Connect's successful fo

[Qemu-devel] [PATCH v11 4/4] use inet_listen()/inet_connect() to support ipv6 migration

2012-05-08 Thread Amos Kong
Use help functions in qemu-socket.c for tcp migration, which already support ipv6 addresses. Currently errp will be set to UNDEFINED_ERROR when migration fails, qemu would output "migration failed: ...", and current user can see a message("An undefined error has occurred") in monitor. This patch

[Qemu-devel] [PATCH v11 3/4] sockets: use error class to pass listen error

2012-05-08 Thread Amos Kong
Add a new argument in inet_listen()/inet_listen_opts() to pass back listen error. Change nbd, qemu-char, vnc to use new interface. Signed-off-by: Amos Kong Reviewed-by: Orit Wasserman --- nbd.c |2 +- qemu-char.c|2 +- qemu-sockets.c | 17 ++--- qemu_socket.h

Re: [Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear other FPSCR bits

2012-05-08 Thread Peter Maydell
On 7 May 2012 03:45, Matt Craighead wrote: > diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c > -#define SET_QC() env->vfp.xregs[ARM_VFP_FPSCR] = CPSR_Q > +#define SET_QC() env->vfp.xregs[ARM_VFP_FPSCR] |= CPSR_Q Bug reproduced, fix confirmed, Reviewed-by: Peter Maydell This bug

[Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear other FPSCR bits

2012-05-08 Thread Peter Maydell
From: Matt Craighead This patch fixes a bug affecting a variety of Neon instructions, such as VQADD. Signed-off-by: Matt Craighead Signed-off-by: Peter Maydell --- target-arm/neon_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/tar

[Qemu-devel] [PULL for-1.1] target-arm queue

2012-05-08 Thread Peter Maydell
This is a pullreq for a single target-arm patch which I think worth putting into 1.1. The bug has been in qemu for some time but it is a trivial and obvious one-line fix. Please pull. thanks -- PMM The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out t

[Qemu-devel] [PATCH 1.1 05/22] block: add block_job_sleep_ns

2012-05-08 Thread Paolo Bonzini
This function abstracts the pretty complex semantics of the "busy" member of BlockJob. Signed-off-by: Paolo Bonzini --- block.c| 11 +++ block/stream.c | 23 +-- block_int.h| 22 +++--- 3 files changed, 35 insertions(+), 21 deletions(

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Andreas Färber
Am 08.05.2012 16:53, schrieb Andreas Färber: > Am 08.05.2012 16:24, schrieb Anthony Liguori: >> On 05/08/2012 09:10 AM, Andreas Färber wrote: >>> With rc0 not being provided as tarball, it would be nice to document the >>> official, reproducible way of packaging a QEMU tarball on the Wiki. I >>> ha

Re: [Qemu-devel] [RFC] [PATCH 0/2] Sandboxing Qemu guests with Libseccomp

2012-05-08 Thread Corey Bryant
On 05/08/2012 10:27 AM, Daniel P. Berrange wrote: On Tue, May 08, 2012 at 10:10:25AM -0400, Corey Bryant wrote: On 05/08/2012 07:32 AM, Stefano Stabellini wrote: On Tue, 8 May 2012, Daniel P. Berrange wrote: On Fri, May 04, 2012 at 04:08:36PM -0300, Eduardo Otubo wrote: Hello all, This i

[Qemu-devel] [PATCH 1.1 09/22] block: move field reset from bdrv_open_common to bdrv_close

2012-05-08 Thread Paolo Bonzini
bdrv_close should leave fields in the same state as bdrv_new. It is not up to bdrv_open_common to fix the mess. Also, backing_format was not being re-initialized. Signed-off-by: Paolo Bonzini --- block.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/block.

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 16:43, Christian Borntraeger wrote: >>> Anthony, this is the prototype of the IPL device that we have talked about >>> some weeks >>> ago. Is an external device to do the IPL process for s390 still ok with you? >> >> Even with an external IPL, we should still be able to detect

[Qemu-devel] [PATCH 1.1 04/22] block: fully delete bs->file when closing

2012-05-08 Thread Paolo Bonzini
We are reusing bs->file across close/open, which may not cause any known bugs but is a recipe for trouble. Prefer bdrv_delete, and enjoy the new invariant in the implementation of bdrv_delete. Signed-off-by: Paolo Bonzini --- block.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Anthony Liguori
On 05/08/2012 10:13 AM, Andreas Färber wrote: Am 08.05.2012 16:53, schrieb Andreas Färber: Am 08.05.2012 16:24, schrieb Anthony Liguori: On 05/08/2012 09:10 AM, Andreas Färber wrote: With rc0 not being provided as tarball, it would be nice to document the official, reproducible way of packagin

[Qemu-devel] [Bug 996303] Re: does not work with clang

2012-05-08 Thread Stevan Vucenovic
This one does not compile: ./configure --prefix=/usr/local/Cellar/qemu/1.0.1 --cc=/usr/bin/clang --host-cc=/usr/bin/clang --disable-darwin-user --enable-cocoa --disable- bsd-user --disable-guest-agent > In file included from > /private/tmp/homebrew-qemu-1.0.1-CpcD/qemu-1.0.1/target-i386/op_helpe

[Qemu-devel] [PATCH 1.1 22/22] stream: move rate limiting to a separate header file

2012-05-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/stream.c | 31 ++-- include/qemu/ratelimit.h | 50 ++ 2 files changed, 52 insertions(+), 29 deletions(-) create mode 100644 include/qemu/ratelimit.h diff --git a/block/stream

[Qemu-devel] [PATCH 1.1 01/22] block: fix snapshot on QED

2012-05-08 Thread Paolo Bonzini
QED's opaque data includes a pointer back to the BlockDriverState. This breaks when bdrv_append shuffles data between bs_new and bs_top. To avoid this, add a "rebind" function that tells the driver about the new relationship between the BlockDriverState and its opaque. The patch also adds rebind t

[Qemu-devel] [PATCH 0/2] qtest: Add floppy media change test

2012-05-08 Thread Kevin Wolf
Kevin Wolf (2): qtest: Add function to send QMP commands qtest: Add floppy test tests/Makefile |2 + tests/fdc-test.c | 186 ++ tests/libqtest.c | 123 tests/libqtest.h | 17 + 4 files chang

[Qemu-devel] [PATCH 2/2] qtest: Add floppy test

2012-05-08 Thread Kevin Wolf
Let's start with testing media change. Signed-off-by: Kevin Wolf --- tests/Makefile |2 + tests/fdc-test.c | 186 ++ 2 files changed, 188 insertions(+), 0 deletions(-) create mode 100644 tests/fdc-test.c diff --git a/tests/Makefile b/t

[Qemu-devel] [PATCH 1/2] qtest: Add function to send QMP commands

2012-05-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/libqtest.c | 123 ++ tests/libqtest.h | 17 +++ 2 files changed, 113 insertions(+), 27 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 295c6d4..6d333ef 100644 --- a/tests/libqtest.c

[Qemu-devel] [PATCH 1.1 16/22] stream: fix HMP block_job_set_speed

2012-05-08 Thread Paolo Bonzini
The change of the argument name from value to speed was not propagated there. Signed-off-by: Paolo Bonzini --- hmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index eb96618..645f873 100644 --- a/hmp.c +++ b/hmp.c @@ -847,7 +847,7 @@ void hmp_block_job_s

[Qemu-devel] [PATCH 1.1 21/22] stream: move is_allocated_above to block.c

2012-05-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c| 49 + block.h|4 block/stream.c | 53 ++--- 3 files changed, 55 insertions(+), 51 deletions(-) diff --git a/block.c b/block.c ind

Re: [Qemu-devel] [PATCH 1/1 v3] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-08 Thread Crístian Viana
On 27-04-2012 20:14, Crístian Viana wrote: On 27-04-2012 18:23, Peter Maydell wrote: That appears to contain one of your older versions of this patch, not v3. (It touches bsd-user/main.c, for example.) -- PMM You were right, it was an older version. Now the branch is updated and rebased agains

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Avi Kivity
On 05/08/2012 05:49 PM, Anthony Liguori wrote: > On 05/08/2012 09:43 AM, Avi Kivity wrote: >> On 05/08/2012 05:40 PM, Anthony Liguori wrote: >>> On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/

Re: [Qemu-devel] [PATCH 0/2] [PULL 1.1] linux-user fixes for 1.1

2012-05-08 Thread Anthony Liguori
On 05/03/2012 10:15 AM, riku.voi...@linaro.org wrote: From: Riku Voipio The following fixes since commit f05ae5379e40f81a6c8526d891693af8bf6e62da: Bail out if CONFIG_TCG_PASS_AREG0 is defined (2012-05-03 15:48:49 +0400) are available in the git repository at: git://git.linaro.org/people

Re: [Qemu-devel] [PULL 00/12] spice patch queue

2012-05-08 Thread Anthony Liguori
On 05/03/2012 03:53 AM, Gerd Hoffmann wrote: Hi, Here comes the spice patch queue. Nothing major. Most patches make qxl robust against guest bugs, by making qxl logging a message and raising an error IRQ instead of calling abort(). And a few other bugfixes. Pulled. Thanks. Regards, An

Re: [Qemu-devel] [PULL 00/14] SCSI changes for 1.1

2012-05-08 Thread Anthony Liguori
On 05/04/2012 03:45 AM, Paolo Bonzini wrote: Anthony, the following changes since commit f05ae5379e40f81a6c8526d891693af8bf6e62da: Bail out if CONFIG_TCG_PASS_AREG0 is defined (2012-05-03 15:48:49 +0400) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Anthony Liguori
On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) Pulled. Thanks. Regards, Anthony Liguori are available in the git re

Re: [Qemu-devel] [PULL 0/5] Block patches for 1.1

2012-05-08 Thread Anthony Liguori
On 05/07/2012 12:55 PM, Kevin Wolf wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anth

Re: [Qemu-devel] [PULL 1.1 0/6] Missing patches for QEMU 1.1

2012-05-08 Thread Anthony Liguori
On 05/03/2012 12:14 AM, Stefan Weil wrote: Hi Anthony, here are some of my patches which were not committed up to now, but which should be included in QEMU 1.1. Only the last one (qemu-timer, which did not get any review up to now) is w32 related. The first one was discussed a lot, but then for

[Qemu-devel] [PATCH 1.1 10/22] qemu-img: make "info" backing file output correct and easier to use

2012-05-08 Thread Paolo Bonzini
qemu-img info should use the same logic as qemu when printing the backing file path, or debugging becomes quite tricky. We can also simplify the output in case the backing file has an absolute path or a protocol. Signed-off-by: Paolo Bonzini --- block.c| 19 +++ block.h

[Qemu-devel] [PATCH 1.1 03/22] block: do not reuse the backing file across bdrv_close/bdrv_open

2012-05-08 Thread Paolo Bonzini
This is another bug caused by not doing a full cleanup of the BDS across close/open. This was found with mirroring by Shaolong Hu, but it can probably be reproduced also with eject or change. Signed-off-by: Paolo Bonzini --- block.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/block

[Qemu-devel] [PATCH 1.1 06/22] block: wait for job callback in block_job_cancel_sync

2012-05-08 Thread Paolo Bonzini
The limitation on not having I/O after cancellation cannot really be kept. Even streaming has a very small race window where you could cancel a job and have it report completion. If this window is hit, bdrv_change_backing_file() will yield and possibly cause accesses to dangling pointers etc. So

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Paolo Bonzini
Il 08/05/2012 16:49, Anthony Liguori ha scritto: > On 05/08/2012 09:43 AM, Avi Kivity wrote: >> On 05/08/2012 05:40 PM, Anthony Liguori wrote: >>> On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: h

[Qemu-devel] [PATCH v4 4/7] trace: [monitor] Use new event control interface

2012-05-08 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 8946a10..86c2538 100644 --- a/monitor.c +++ b/monitor.c @@ -625,10 +625,19 @@ static void do_trace_event_set_state(Monitor *mon, const QD

[Qemu-devel] [PATCH 1.1 17/22] stream: fix ratelimiting corner case

2012-05-08 Thread Paolo Bonzini
This fixes inability to make progress in streaming if the quota is set to less than the amount of data that an I/O operation has to write. In this case, limit->dispatched + n will always be above the quota and, due to the "goto retry" to recheck cancellation and allocation, streaming will livelock

[Qemu-devel] [PATCH 1.1 20/22] stream: tweak usage of bdrv_co_is_allocated

2012-05-08 Thread Paolo Bonzini
is_allocated_base has complex semantics that are not really usable outside streaming. Split the check in two parts, where the allocated state for the top bs is moved to the caller. The resulting function is more generally useful. Signed-off-by: Paolo Bonzini --- Starting from this patch

[Qemu-devel] [PATCH 1.1 18/22] stream: do not copy unallocated sectors from the base

2012-05-08 Thread Paolo Bonzini
Unallocated sectors should really never be accessed by the guest, so there's no need to copy them during the streaming process. If they are read by the guest during streaming, guest-initiated copy-on-read will copy them (we're in the base == NULL case, which enables copy on read). If they are read

[Qemu-devel] [PATCH 1.1 13/22] stream: fix sectors not allocated test

2012-05-08 Thread Paolo Bonzini
The test on sectors not allocated can fail if the L1/L2 tables are not on disk yet. Allow tests to shutdown the VM early. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/030|1 + tests/qemu-iotests/iotests.py | 10 ++ 2 files changed, 7 insertions(+), 4 deletions(-) d

Re: [Qemu-devel] [PATCH v2] softfloat: float32_to_float16() should do inexact instead of underflow for rounding case

2012-05-08 Thread Peter Maydell
On 3 May 2012 15:37, Alexey Starikovskiy wrote: > IEEE Standard for Floating-Point Arithmetic: > 7.5 Underflow > The underflow exception shall be signaled when a tiny non-zero result > is detected. For binary formats, this > shall be either: > a) after rounding — when a non-zero result computed as

[Qemu-devel] [PATCH v4 5/7] trace: [default] Use new event control interface

2012-05-08 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace/default.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..3c41990 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default implementation for backend ini

[Qemu-devel] [PATCH 1.1 15/22] stream: pass new base image format to bdrv_change_backing_file

2012-05-08 Thread Paolo Bonzini
When an image is modified to point to the new backing file, the backing file format is set to NULL, which means auto-probe. This is wrong, in fact it is a small security problem. Reviewed-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block/stream.c |7 +-- 1 file changed, 5 insertion

[Qemu-devel] [PATCH 1.1 08/22] block: protect path_has_protocol from filenames with colons

2012-05-08 Thread Paolo Bonzini
path_has_protocol will erroneously return "true" if the colon is part of a filename. These names are common with stable device names produced by udev. We cannot fully protect against this in case the filename does not have a path component (e.g. if the current directory is /dev/disk/by-path), but

[Qemu-devel] [PATCH 1.1 19/22] block: implement is_allocated for raw

2012-05-08 Thread Paolo Bonzini
Either FIEMAP, or SEEK_DATA+SEEK_HOLE can be used to implement the is_allocated callback for raw files. Ext4, btrfs and XFS all support it. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 102 + block/raw.c |8 + 2 files ch

[Qemu-devel] [PATCH 1.1 07/22] block: simplify path_is_absolute

2012-05-08 Thread Paolo Bonzini
On Windows, all the logic is already in is_windows_drive and is_windows_drive_prefix. On POSIX, there is no need to look out for colons. The win32 code changes the behaviour in some cases, we could have something like "d:foo.img". The old code would treat it as relative path, the new one as absol

[Qemu-devel] [PATCH 1.1 12/22] qemu-io: fix the alloc command

2012-05-08 Thread Paolo Bonzini
Because sector_num is not updated, the loop would either go on forever or return garbage. Signed-off-by: Paolo Bonzini --- qemu-io.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index b48364f..5882067 100644 --- a/qemu-io.c +++ b/qemu-io.

[Qemu-devel] [PATCH 1.1 14/22] stream: add testcase for partial streaming

2012-05-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/030 | 27 ++- tests/qemu-iotests/030.out |4 ++-- 2 file changed, 28 insertions(+), 3 deletion(-) diff --git a/tests/qemu-iotests/030.out b/tests/qemu-iotests/030.out index 0d2f87b..0aa7a0a 100644 --- a/tests/q

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Andreas Färber
Am 08.05.2012 16:24, schrieb Anthony Liguori: > On 05/08/2012 09:10 AM, Andreas Färber wrote: >> Am 07.05.2012 14:54, schrieb Anthony Liguori: >> rc0 is available, but patches submitted for 1.1 shortly before rc0 >> neither got review nor were applied. Neither did pulls or patches >> applied by Ant

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Alexander Graf
On 07.05.2012, at 01:46, Andreas Färber wrote: > Hello malc, > > This series fixes two long-standing issues on Darwin/ppc and, based on your > second patch, fixes the AREG0 mode for Linux and Darwin and thus the ppc > build. > > Compared to your last patch I have tried to avoid the { int ir; }

[Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands

2012-05-08 Thread Luiz Capitulino
This series changes qemu-ga to not emit a success response for commands guest-shutdown and guest-suspend-{ram,disk,hybrid}. More details and the reason for this change can be found in the following patches. V2 o Rename option_is_enabled() to option_value_matches() [Michael] o Improve guest-shutdo

[Qemu-devel] [PATCH 6/6] qemu-ga: guest-suspend-hybrid: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-hybrid completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should ch

[Qemu-devel] [PATCH 5/6] qemu-ga: guest-suspend-ram: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-ram completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check

[Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for

[Qemu-devel] [PATCH 1/6] qapi: add support for command options

2012-05-08 Thread Luiz Capitulino
Options allow for changes in commands behavior. This commit introduces the QCO_NO_SUCCESS_RESP option, which causes a command to not emit a success response. This is needed by commands such as qemu-ga's guest-shutdown, which may not be able to complete before the VM vanishes. In this case, it's us

[Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check

Re: [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code

2012-05-08 Thread Anthony Liguori
On 05/03/2012 11:09 AM, Stefan Weil wrote: Code which is compiled with CONFIG_TCG_DEBUG (set by configure option --enable-debug-tcg) should not disable the assert macro by defining NDEBUG. With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c were completely useless because NDEBUG

Re: [Qemu-devel] [PATCH for-1.1 0/2] configure: Cosmetic VirtFS fix

2012-05-08 Thread Anthony Liguori
On 04/30/2012 06:12 PM, Andreas Färber wrote: Hello, I recently noticed that lack of VirtFS support leads to configure printing just "VirtFS support". This mini-series fixes it to say "VirtFS support no". I'm not sure if we have a definitive Coding Style for shell scripts (or Python code for

Re: [Qemu-devel] [PATCH for-1.1] cpu: Update documentation and comment

2012-05-08 Thread Anthony Liguori
On 05/02/2012 03:28 PM, Andreas Färber wrote: State struct CPU had been renamed to CPUState, former CPUState to CPUArchState. Signed-off-by: Andreas Färber Applied. Thanks. Regards, Anthony Liguori --- include/qemu/cpu.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) di

  1   2   >