Re: [Qemu-devel] [PATCH 4/4] vl: prop is_suspended variable

2012-05-07 Thread Markus Armbruster
"prop is_suspended variable": do you mean "drop"?

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Gleb Natapov
On Mon, May 07, 2012 at 10:06:58AM +0400, Michael Tokarev wrote: > On 06.05.2012 23:03, Michael Tokarev wrote: > > This is just a heads-up. I tried building current > > qemu git today and running a win7 guest in it. Neither > > already installed guest (which finds new hardware and > > want to reb

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 11:45, Gleb Natapov wrote: > On Mon, May 07, 2012 at 10:06:58AM +0400, Michael Tokarev wrote: >> On 06.05.2012 23:03, Michael Tokarev wrote: >>> This is just a heads-up. I tried building current >>> qemu git today and running a win7 guest in it. Neither >>> already installed guest (

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Gleb Natapov
On Mon, May 07, 2012 at 12:01:47PM +0400, Michael Tokarev wrote: > On 07.05.2012 11:45, Gleb Natapov wrote: > > On Mon, May 07, 2012 at 10:06:58AM +0400, Michael Tokarev wrote: > >> On 06.05.2012 23:03, Michael Tokarev wrote: > >>> This is just a heads-up. I tried building current > >>> qemu git t

Re: [Qemu-devel] [PATCH] fdc: simplify media change handling

2012-05-07 Thread Kevin Wolf
Am 05.05.2012 19:43, schrieb Hervé Poussineau: > This also (partly) fixes IBM OS/2 Warp 4.0 floppy installation, where > not all floppies have the same format (2x80x18 for the first ones, > 2x80x23 for the next ones). > > Signed-off-by: Hervé Poussineau > --- > > This patch fixes a real use case

Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_create adopt coroutine

2012-05-07 Thread Kevin Wolf
Am 05.05.2012 05:28, schrieb zwu.ker...@gmail.com: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > block.c | 48 +++- > 1 files changed, 47 insertions(+), 1 deletions(-) What's this? A version 2 of half the patch series, with the implici

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 12:06, Gleb Natapov wrote: > On Mon, May 07, 2012 at 12:01:47PM +0400, Michael Tokarev wrote: [] >> I'm trying. But the problem is that right now I'm swamped >> with other work. So far win7 x64 appears to work, it >> reboots without showing this "stop" thing or other issues, >> even

Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_create adopt coroutine

2012-05-07 Thread Zhi Yong Wu
On Mon, May 7, 2012 at 4:32 PM, Kevin Wolf wrote: > Am 05.05.2012 05:28, schrieb zwu.ker...@gmail.com: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >>  block.c |   48 +++- >>  1 files changed, 47 insertions(+), 1 deletions(-) > > What's

[Qemu-devel] [PATCH v2 1/2] block: make bdrv_create adopt coroutine

2012-05-07 Thread zwu . kernel
From: Zhi Yong Wu The current qemu.git introduces failure with preallocation and some sizes: qemu-img create -f qcow2 new.img 976563K -o preallocation=metadata qemu-img: qemu-coroutine-lock.c:111: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed. And lock needs to work in coroutine c

[Qemu-devel] [PATCH v2 2/2] qcow2: lock on prealloc

2012-05-07 Thread zwu . kernel
From: Zhi Yong Wu preallocate() will be locked. Signed-off-by: Zhi Yong Wu --- block/qcow2.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 8c60a6f..ee4678f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1192,7 +1192,10 @@ sta

[Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Alexander Graf
If we execute linux-user code that does the following: * A = mmap() * execute code in A * munmap(A) * B = mmap(), but mmap returns the same address as A * execute code in B we end up executing a stale cached tb that contains translated code from A, while we want new code from B. This p

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 12:06, Gleb Natapov wrote: > On Mon, May 07, 2012 at 12:01:47PM +0400, Michael Tokarev wrote: [] And the previously installed guest never reboots in currrent git version, always giving the 0x5c STOP code after first boot. This is aint good at all, as existing guests do

Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow

2012-05-07 Thread Paolo Bonzini
Il 04/05/2012 18:51, Stefan Weil ha scritto: > The tabs in patches 6 and 7 are more problematic. > Although they are not at the start of the line, tabs > should be completely avoided (that's my personal > understanding of QEMU's coding rules). ok, I pushed an updated patchset to scsi-next (commit

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Gleb Natapov
On Mon, May 07, 2012 at 01:54:19PM +0400, Michael Tokarev wrote: > On 07.05.2012 12:06, Gleb Natapov wrote: > > On Mon, May 07, 2012 at 12:01:47PM +0400, Michael Tokarev wrote: > [] > And the previously installed guest never reboots in currrent > git version, always giving the 0x5c STOP c

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 14:16, Gleb Natapov wrote: > On Mon, May 07, 2012 at 01:54:19PM +0400, Michael Tokarev wrote: >> On 07.05.2012 12:06, Gleb Natapov wrote: >>> On Mon, May 07, 2012 at 12:01:47PM +0400, Michael Tokarev wrote: >> [] >> And the previously installed guest never reboots in currrent

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Peter Maydell
On 7 May 2012 10:30, Alexander Graf wrote: > @@ -587,6 +587,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int > prot, >     page_dump(stdout); >     printf("\n"); >  #endif > +    tb_invalidate_phys_page_range(start, start + len, 0); >     mmap_unlock(); >     return start; The comme

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Alexander Graf
On 07.05.2012, at 12:37, Peter Maydell wrote: > On 7 May 2012 10:30, Alexander Graf wrote: >> @@ -587,6 +587,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int >> prot, >> page_dump(stdout); >> printf("\n"); >> #endif >> +tb_invalidate_phys_page_range(start, start + len,

Re: [Qemu-devel] [RFC] [PATCH 2/2] Adding basic calls to libseccomp in vl.c

2012-05-07 Thread Paolo Bonzini
Il 04/05/2012 23:59, Andreas Färber ha scritto: >> > +static struct qemu_seccomp_syscall seccomp_whitelist[] = { >> > +{SCMP_SYS(timer_settime), 255}, > Spaces inside braces please. > >> > +{SCMP_SYS(timer_gettime), 254}, >> > +{SCMP_SYS(futex), 253}, >> > +{SCMP_SYS(select), 252},

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Alexander Graf
On 07.05.2012, at 12:37, Peter Maydell wrote: > On 7 May 2012 10:30, Alexander Graf wrote: >> @@ -587,6 +587,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int >> prot, >> page_dump(stdout); >> printf("\n"); >> #endif >> +tb_invalidate_phys_page_range(start, start + len,

Re: [Qemu-devel] [PATCH 4/4] vl: prop is_suspended variable

2012-05-07 Thread Luiz Capitulino
On Mon, 07 May 2012 09:02:29 +0200 Markus Armbruster wrote: > "prop is_suspended variable": do you mean "drop"? Hm, yes, will respin. Thanks!

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Alexander Graf
On 07.05.2012, at 12:37, Peter Maydell wrote: > On 7 May 2012 10:30, Alexander Graf wrote: >> @@ -587,6 +587,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int >> prot, >> page_dump(stdout); >> printf("\n"); >> #endif >> +tb_invalidate_phys_page_range(start, start + len,

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Alexander Graf
On 07.05.2012, at 13:32, Alexander Graf wrote: > > On 07.05.2012, at 12:37, Peter Maydell wrote: > >> On 7 May 2012 10:30, Alexander Graf wrote: >>> @@ -587,6 +587,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, >>> int prot, >>>page_dump(stdout); >>>printf("\n"); >>> #endif

[Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-07 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

[Qemu-devel] [PATCH] rtl8139: fix regression in TxStatus/TxAddr read

2012-05-07 Thread Avi Kivity
Commit afe0a595356192 added byte reads for TxStatus/TxAddr, but broke 32-bit reads; the mask generation (1 << (8 * size)) - 1 is unspecified in C for size >= sizeof(int), and in fact returns 0 on x86. Fix by using a larger type. Fixes (at least) Fedora 9 i386 with -machine kernel_irqchip=on.

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-07 Thread Peter Maydell
On 7 May 2012 12:38, Alexander Graf wrote: > And the below patch on top of my revised patch fixes it. > The question is whether we still need to flush on mmap() then? IIRC the kernel will let you MAP_FIXED mmap a file to an address that's already mmap'd for something else without having to munmap

Re: [Qemu-devel] [RFC] [PATCH 2/2] Adding basic calls to libseccomp in vl.c

2012-05-07 Thread Eduardo Otubo
On Fri, May 04, 2012 at 11:59:00PM +0200, Andreas Färber wrote: > Am 04.05.2012 21:08, schrieb Eduardo Otubo: > > I added a syscall struct using priority levels as described in the > > libseccomp > > man page. The priority numbers are based to the frequency they appear in a > > sample strace from

Re: [Qemu-devel] [RFC] [PATCH 2/2] Adding basic calls to libseccomp in vl.c

2012-05-07 Thread Eduardo Otubo
On Mon, May 07, 2012 at 01:01:01PM +0200, Paolo Bonzini wrote: > Il 04/05/2012 23:59, Andreas Färber ha scritto: > >> > +static struct qemu_seccomp_syscall seccomp_whitelist[] = { > >> > +{SCMP_SYS(timer_settime), 255}, > > Spaces inside braces please. > > > >> > +{SCMP_SYS(timer_gettime),

Re: [Qemu-devel] [RFC] [PATCH 2/2] Adding basic calls to libseccomp in vl.c

2012-05-07 Thread Paolo Bonzini
> > At least the following are also used: recvmsg, sendmsg, accept, connect, > > bind, listen, ioctl, fallocate, eventfd. I don't know if all of them > > have to be included in the list. Other syscalls are not used but > > probably should be allowed for simplicity, for example poll. > > You stra

Re: [Qemu-devel] [PATCH 00/26] My block patches queue for 1.1

2012-05-07 Thread Kevin Wolf
Am 04.05.2012 18:20, schrieb Paolo Bonzini: > On Thu, Apr 12, 2012 at 2:00 PM, Paolo Bonzini wrote: >> Here is my block patches queue for 1.1. >> >> Patches 1-6 are cleanups to tools and aio.c that let filesystems >> use timers when running under qemu-io. >> >> Patches 7-12 are bugfixes from last

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-07 Thread Anthony Liguori
On 05/07/2012 06:47 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. - Status of the 1.1 release Regards, Anthony Liguori Thanks, Juan.

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-07 Thread Anthony Liguori
On 05/07/2012 06:47 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. - QEMU documentation qemu-doc.texi is in a pretty awful state. I'm wondering if anyone has any ideas about how we can improve it. One thing we could do is move the entire conten

Re: [Qemu-devel] [PATCH] rtl8139: fix regression in TxStatus/TxAddr read

2012-05-07 Thread Michael S. Tsirkin
On Mon, May 07, 2012 at 03:00:45PM +0300, Avi Kivity wrote: > Commit afe0a595356192 added byte reads for TxStatus/TxAddr, but > broke 32-bit reads; the mask generation > >(1 << (8 * size)) - 1 > > is unspecified in C for size >= sizeof(int), and in fact returns 0 > on x86. > > Fix by using a

Re: [Qemu-devel] [PATCH 2/2] qcow2: fix the byte endian convertion

2012-05-07 Thread Kevin Wolf
Am 30.04.2012 14:41, schrieb Stefan Hajnoczi: > On Sat, Apr 28, 2012 at 8:38 AM, wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> block/qcow2-refcount.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Reviewed-by: Stefan Hajnoczi Thanks, applied both

Re: [Qemu-devel] [PATCH 1/3] monitor: remove unused do_info_trace

2012-05-07 Thread Lluís Vilanova
Harsh Prateek Bora writes: > Going forward with simpletrace v2 variable size trace records, we cannot > have a generic function to print trace event info and therefore this > interface becomes invalid. > As per Stefan Hajnoczi: > "This command is only available from the human monitor. It's not

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
So, refreshing it all again with more correct information. First, it appears that only 32bit version of qemu userspace is affected, and only when using 32bit version of guest. So far, either 64bit qemu userpace or 64bit windows7 guest is enough for the issue to not show up. Second, both win7 and

[Qemu-devel] [PATCH 1/4] wakeup on migration

2012-05-07 Thread Luiz Capitulino
From: Gerd Hoffmann Wakeup the guest when the live part of the migation is finished. This avoids being in suspended state on migration, so we don't have to save the is_suspended bit. Signed-off-by: Gerd Hoffmann Reviewed-by: Luiz Capitulino --- migration.c |1 + 1 file changed, 1 insertio

[Qemu-devel] [PATCH v3 0/4]: runstate: introduce 'suspended' state

2012-05-07 Thread Luiz Capitulino
The first patch is a fix from Gerd, it's included in this series for our convenience. The patch introducing the new RunState is actually patch 03/04. This is for 1.1. V3 - small log typo fix [Markus] input.c |4 ++-- migration.c |1 + qapi-schema.json |8 +--- qmp

[Qemu-devel] [PATCH 2/4] qapi-schema.json: fix RunState enums alphabetical order

2012-05-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qapi-schema.json |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 9193fb9..0166ec2 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -92,6 +92,8 @@ # # @debug: QEMU is running on a debug

[Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

2012-05-07 Thread Luiz Capitulino
QEMU enters in this state when the guest suspends to ram (S3). This is important so that HMP users and QMP clients can know that the guest is suspended. QMP also has an event for this, but events are not reliable and are limited (ie. a client can connect to QEMU after the event has been emitted).

[Qemu-devel] [PATCH 4/4] vl: drop is_suspended variable

2012-05-07 Thread Luiz Capitulino
Check for the RUN_STATE_SUSPENDED state instead. Signed-off-by: Luiz Capitulino --- vl.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index a7afc79..5e0080b 100644 --- a/vl.c +++ b/vl.c @@ -1293,7 +1293,6 @@ static pid_t shutdown_pid; static int powe

[Qemu-devel] [PATCH v4 0/2]: hmp: integer parsing fixes

2012-05-07 Thread Luiz Capitulino
I've decided to implement Markus's suggestion (ie. check only for ERANGE) to avoid needless discussions on a simple thing... o V4 - Check only for ERANGE in expr_unary() [Markus] monitor.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()/strtoull()

2012-05-07 Thread Luiz Capitulino
It's not checked currently, so something like: (qemu) balloon -10114334234 (qemu) Will just "work" (in this case the balloon command will get a random value). Fix it by checking if strtoul()/strtoull() overflowed. Signed-off-by: Luiz Capitulino --- monitor.c |4 1

[Qemu-devel] [PATCH 2/2] hmp: fix bad value conversion for M type

2012-05-07 Thread Luiz Capitulino
The M type converts from megabytes to bytes. However, the value can be negative before the conversion, which will lead to a flawed conversion. For example, this: (qemu) balloon -1011 (qemu) Just "works", but the value passed by the balloon command will be something else. This patc

[Qemu-devel] [PATCH] Rate limit vnc_write_pixels_generic

2012-05-07 Thread Philipp Hahn
Only print the error message once per change and also include the actual unsupported color depth in bytes per pixel in the error message. Signed-off-by: Philipp Hahn --- ui/vnc.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index deb9ecd..9d

Re: [Qemu-devel] [PATCH v4 0/2]: hmp: integer parsing fixes

2012-05-07 Thread Eric Blake
On 05/07/2012 08:09 AM, Luiz Capitulino wrote: > I've decided to implement Markus's suggestion (ie. check only for ERANGE) to > avoid needless discussions on a simple thing... > > o V4 > > - Check only for ERANGE in expr_unary() [Markus] > > monitor.c | 12 ++-- > 1 file changed, 10 i

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Jan Kiszka
On 2012-05-07 10:51, Michael Tokarev wrote: > So, refreshing it all again with more correct information. > > First, it appears that only 32bit version of qemu userspace is > affected, and only when using 32bit version of guest. So far, > either 64bit qemu userpace or 64bit windows7 guest is enoug

Re: [Qemu-devel] [PATCH] Rate limit vnc_write_pixels_generic

2012-05-07 Thread Anthony Liguori
On 05/07/2012 08:58 AM, Philipp Hahn wrote: Only print the error message once per change and also include the actual unsupported color depth in bytes per pixel in the error message. Signed-off-by: Philipp Hahn Under what conditions are you seeing this happen? Regards, Anthony Liguori ---

[Qemu-devel] [PATCH] qcow2: Limit COW to where it's needed

2012-05-07 Thread Kevin Wolf
This fixes a regression introduced in commit 250196f1. The bug leads to data corruption, found during an Autotest run with a Fedora 8 guest. Consider a write request whose first part is covered by an already allocated cluster, but additional clusters need to be newly allocated. When counting the n

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Anthony Liguori
On 05/06/2012 09:39 AM, Avi Kivity wrote: On 05/06/2012 05:35 PM, Anthony Liguori wrote: On 05/06/2012 08:11 AM, Avi Kivity wrote: libvirt is essentially the BMC for a virtual guest. I would suggest looking at implementing an IPMI interface to libvirt and exposing it to the guest through a USB

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 18:18, Jan Kiszka wrote: [] > I have a 32-bit WinXP here to test (but not a Win7-32) and will give it I just found out that a 32bit guest is not enough. The problem appears to be with 32bit userspace running under 64bit kernel only. I just booted a 32bit kernel here on host, and no

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Jan Kiszka
On 2012-05-07 11:35, Michael Tokarev wrote: > On 07.05.2012 18:18, Jan Kiszka wrote: > [] >> I have a 32-bit WinXP here to test (but not a Win7-32) and will give it > > I just found out that a 32bit guest is not enough. The problem appears > to be with 32bit userspace running under 64bit kernel o

Re: [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-05-07 Thread Meador Inge
Ping ^ 2. On 04/04/2012 09:30 PM, Meador Inge wrote: > Ping. Any comments on this series? > > On 03/27/2012 05:44 PM, Meador Inge wrote: >> This series is focused at cleaning up a few issues in the >> GNU/Linux usermode driver's option parsing. -h has been >> fixed to exit with 0, a -help optio

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Avi Kivity
On 05/07/2012 05:30 PM, Anthony Liguori wrote: > On 05/06/2012 09:39 AM, Avi Kivity wrote: >> On 05/06/2012 05:35 PM, Anthony Liguori wrote: >>> On 05/06/2012 08:11 AM, Avi Kivity wrote: >>> libvirt is essentially the BMC for a virtual guest. I would suggest >>> looking at implementing an IPMI int

Re: [Qemu-devel] [PATCH v3 0/4]: runstate: introduce 'suspended' state

2012-05-07 Thread Gerd Hoffmann
On 05/07/12 15:56, Luiz Capitulino wrote: > The first patch is a fix from Gerd, it's included in this series for our > convenience. The patch introducing the new RunState is actually patch 03/04. > > This is for 1.1. Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 18:35, Michael Tokarev wrote: > On 07.05.2012 18:18, Jan Kiszka wrote: > [] >> I have a 32-bit WinXP here to test (but not a Win7-32) and will give it > > I just found out that a 32bit guest is not enough. The problem appears > to be with 32bit userspace running under 64bit kernel o

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2012-05-07 Thread Andreas Färber
Am 28.03.2012 00:44, schrieb Meador Inge: > Signed-off-by: Meador Inge > --- > linux-user/main.c | 20 ++-- > 1 files changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn

Re: [Qemu-devel] [PATCH v2 2/2] qcow2: lock on prealloc

2012-05-07 Thread Kevin Wolf
Am 07.05.2012 10:51, schrieb zwu.ker...@gmail.com: > From: Zhi Yong Wu > > preallocate() will be locked. > > Signed-off-by: Zhi Yong Wu Thanks, applied both to the block branch for 1.1. Kevin

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Anthony Liguori
On 05/07/2012 09:44 AM, Avi Kivity wrote: On 05/07/2012 05:30 PM, Anthony Liguori wrote: On 05/06/2012 09:39 AM, Avi Kivity wrote: On 05/06/2012 05:35 PM, Anthony Liguori wrote: On 05/06/2012 08:11 AM, Avi Kivity wrote: libvirt is essentially the BMC for a virtual guest. I would suggest looki

Re: [Qemu-devel] [PATCH] Rate limit vnc_write_pixels_generic

2012-05-07 Thread Philipp Hahn
Hello Anthony, Am Montag 07 Mai 2012 16:19:57 schrieb Anthony Liguori: > On 05/07/2012 08:58 AM, Philipp Hahn wrote: > > Only print the error message once per change and also include the actual > > unsupported color depth in bytes per pixel in the error message. > > > > Signed-off-by: Philipp Hahn

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Avi Kivity
On 05/07/2012 05:55 PM, Anthony Liguori wrote: >>> For all intents and purposes, the BMC/RSA is a separate physical >>> machine. >> >> That's true for any other card on a machine. > > > It has a separate power source for all intents and purposes. If you > think of it in QOM terms, what connects th

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Anthony Liguori
On 05/07/2012 10:11 AM, Avi Kivity wrote: On 05/07/2012 05:55 PM, Anthony Liguori wrote: For all intents and purposes, the BMC/RSA is a separate physical machine. That's true for any other card on a machine. It has a separate power source for all intents and purposes. If you think of it in

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Jan Kiszka
On 2012-05-07 11:45, Michael Tokarev wrote: > On 07.05.2012 18:35, Michael Tokarev wrote: >> On 07.05.2012 18:18, Jan Kiszka wrote: >> [] >>> I have a 32-bit WinXP here to test (but not a Win7-32) and will give it >> >> I just found out that a 32bit guest is not enough. The problem appears >> to b

Re: [Qemu-devel] [PATCH 3/4] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages

2012-05-07 Thread Fabien Chouteau
Hi Scott, I'm a little bit late, but this patch is not compatible with e500. In fact all the modification breaks e500v2 MMU support. What kind PPC core are you working on? Regards, On 07/08/2011 01:44 AM, Scott Wood wrote: > This definition is backward compatible with MAV=1.0 as long as > the g

Re: [Qemu-devel] [PATCH 1/6] qapi: add support for command options

2012-05-07 Thread Michael Roth
On Fri, May 04, 2012 at 05:20:17PM -0300, Luiz Capitulino wrote: > Options allow for changes in commands behavior. This commit introduces > the QCO_NO_SUCCESS_RESP option, which causes a command to not emit a > success response. > > This is needed by commands such as qemu-ga's guest-shutdown, whic

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Avi Kivity
On 05/07/2012 04:51 PM, Michael Tokarev wrote: > So, refreshing it all again with more correct information. > > First, it appears that only 32bit version of qemu userspace is > affected, and only when using 32bit version of guest. So far, > either 64bit qemu userpace or 64bit windows7 guest is eno

Re: [Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command return

2012-05-07 Thread Michael Roth
On Fri, May 04, 2012 at 05:20:18PM -0300, Luiz Capitulino wrote: > This is a valid condition when a command chooses to not emit a > success response. > > Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth > --- > qemu-ga.c |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/qe

Re: [Qemu-devel] [libvirt] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-07 Thread Corey Bryant
On 05/01/2012 06:15 PM, Eric Blake wrote: On 05/01/2012 03:53 PM, Anthony Liguori wrote: I think (correct me if I'm wrong) libvirt should be aware of any file that qemu asks it to open. So from a security point of view, libvirt can prevent opening a file if it isn't affiliated with the guest.

Re: [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response

2012-05-07 Thread Michael Roth
On Fri, May 04, 2012 at 05:20:19PM -0300, Luiz Capitulino wrote: > Today, qemu-ga may not be able to emit a success response when > guest-shutdown completes. This happens because the VM may vanish > before qemu-ga is able to emit a response. > > This semantic is a bit confusing, as it's not clear

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-07 Thread 陳韋任
> - QEMU documentation > > qemu-doc.texi is in a pretty awful state. I'm wondering if anyone has any > ideas > about how we can improve it. One thing we could do is move the entire > contents > of it to the wiki to allow for broader editing. What's qemu-tech.texi status? ;) > I'd also b

[Qemu-devel] : Memory problem with Qemu/SeaBIOS

2012-05-07 Thread Alain Ribière
Hello, I have a memory trouble with an old DOS OS from Digital Research called Concurrent DOS. It worked fine till Qemu v0.11.1. I use Qemu to make a legacy application run without any modification. Starting with Qemu 0.12, my legacy application has not enough memory to run. Actually it seems th

Re: [Qemu-devel] [PATCH 3/4] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages

2012-05-07 Thread Alexander Graf
Hi Fabien, Could you please elaborate a bit on the case that broke for you with these? The patches shouldn't change any guest facing behavior :o. Alex On 07.05.2012, at 17:47, Fabien Chouteau wrote: > Hi Scott, > > I'm a little bit late, but this patch is not compatible with e500. > > In fa

[Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison

2012-05-07 Thread Fabien Chouteau
Use size mask in both operands of effective address comparison. This is the expected as the size of EPN field in MAS2 depends on page size. Definition of EPN field from e500v2 RM: EPN Effective page number: Depending on page size, only the bits associated with a page boundary are valid. Bits that

Re: [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison

2012-05-07 Thread Alexander Graf
On 07.05.2012, at 18:41, Fabien Chouteau wrote: > Use size mask in both operands of effective address comparison. > This is the expected as the size of EPN field in MAS2 depends on page > size. > > Definition of EPN field from e500v2 RM: > EPN Effective page number: Depending on page size, only

Re: [Qemu-devel] [PATCH 3/4] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages

2012-05-07 Thread Andreas Färber
Am 07.05.2012 18:28, schrieb Alexander Graf: > Hi Fabien, > > Could you please elaborate a bit on the case that broke for you with these? > The patches shouldn't change any guest facing behavior :o. > > > Alex > > On 07.05.2012, at 17:47, Fabien Chouteau wrote: > >> Hi Scott, >> >> I'm a litt

Re: [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison

2012-05-07 Thread Fabien Chouteau
On 05/07/2012 06:43 PM, Alexander Graf wrote: > > On 07.05.2012, at 18:41, Fabien Chouteau wrote: > >> Use size mask in both operands of effective address comparison. >> This is the expected as the size of EPN field in MAS2 depends on page >> size. >> >> Definition of EPN field from e500v2 RM: >>

[Qemu-devel] Read location of memory poits esp register

2012-05-07 Thread Davide Ferraretto
how can I read location of memory poits by esp register (i386 cpu)??

Re: [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response

2012-05-07 Thread Michael Roth
On Fri, May 04, 2012 at 05:20:20PM -0300, Luiz Capitulino wrote: > Today, qemu-ga may not be able to emit a success response when > guest-suspend-disk completes. This happens because the VM may > vanish before qemu-ga is able to emit a response. > > This semantic is a bit confusing, as it's not cl

Re: [Qemu-devel] Read location of memory poits esp register

2012-05-07 Thread Mulyadi Santosa
On Mon, May 7, 2012 at 11:49 PM, Davide Ferraretto wrote: > how can I read location of memory poits by esp register (i386 cpu)?? > > CMIIW, using gdb stub hooked to Qemu, it should be: p $esp x -- regards, Mulyadi Santosa Freelance Linux trainer and consultant blog: the-hydra.blogspot.com t

Re: [Qemu-devel] [PATCH 02/35] vmstate: make all architectures export a way to migrate cpu's

2012-05-07 Thread Andreas Färber
Am 04.05.2012 18:16, schrieb Andreas Färber: > Am 04.05.2012 12:54, schrieb Juan Quintela: >> This makes several changes: >> - exports VMStateDescription vmstate_cpu non-static. >> - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined >> - for the architecture that had nothing, it

[Qemu-devel] Read location of memory poits esp register

2012-05-07 Thread Davide Ferraretto
But, I work into qemu code. Is there a c qemu function for this?? On 05/07/12 19:10, Mulyadi Santosa wrote: On Mon, May 7, 2012 at 11:49 PM, Davide Ferraretto wrote: how can I read location of memory poits by esp register (i386 cpu)?? CMIIW, using gdb stub hooked to Qemu, it should be: p $

[Qemu-devel] [PATCH 2/3 v9] qemu-iotests: support add-cow file format

2012-05-07 Thread Dong Xu Wang
Add qemu-iotests test cases for add-cow file format. CC: Kevin Wolf CC: Stefan Hajnoczi Signed-off-by: Dong Xu Wang --- tests/qemu-iotests/017 |2 +- tests/qemu-iotests/018 |2 +- tests/qemu-iotests/019 |2 +- tests/qemu-iotests/020 |2 +- tests/qemu-iot

[Qemu-devel] [PATCH 1/3 v9] add-cow file format

2012-05-07 Thread Dong Xu Wang
Provide a new file format: add-cow. The usage can be found in add-cow.txt of this patch. CC: Kevin Wolf CC: Stefan Hajnoczi Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow-cache.c | 193

[Qemu-devel] [PATCH 3/3 v9] add-cow: support snapshot_blkdev

2012-05-07 Thread Dong Xu Wang
Raw does not support snapshot_blkdev, we will use add-cow as metadata. CC: Marcelo Tosatti CC: Kevin Wolf CC: Stefan Hajnoczi Signed-off-by: Dong Xu Wang --- blockdev.c | 31 +++ docs/live-block-ops.txt | 10 +- 2 files changed, 36 insertio

[Qemu-devel] [PATCH for-1.1] scripts/qemu-binfmt-conf.sh: Fix shell syntax

2012-05-07 Thread Andreas Färber
The script is organized as a sequence of binfmt registrations, with a check whether the to be registered architecture matches the host. Add a missing fi for the SuperH section. Reported-by: Alexander Graf Signed-off-by: Andreas Färber --- scripts/qemu-binfmt-conf.sh |1 + 1 files changed,

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 19:32, Jan Kiszka wrote: > On 2012-05-07 11:45, Michael Tokarev wrote: [] >> $ ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -drive >> file=w7x32sp1.raw,if=virtio,snapshot=on -m 1G -net none -machine >> accel=kvm,kernel_irqchip=on > > Can you check if -global apic.vapic=off makes

[Qemu-devel] [PULL 0/5] Block patches for 1.1

2012-05-07 Thread Kevin Wolf
The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Hervé Poussineau (1): fdc: simplify

[Qemu-devel] [PATCH 1/5] sheepdog: switch to writethrough mode if cluster doesn't support flush

2012-05-07 Thread Kevin Wolf
From: MORITA Kazutaka This is necessary for qemu to work with the older version of Sheepdog which doesn't support SD_OP_FLUSH_VDI. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH 3/5] block: make bdrv_create adopt coroutine

2012-05-07 Thread Kevin Wolf
From: Zhi Yong Wu The current qemu.git introduces failure with preallocation and some sizes: qemu-img create -f qcow2 new.img 976563K -o preallocation=metadata qemu-img: qemu-coroutine-lock.c:111: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed. And lock needs to work in coroutine c

[Qemu-devel] [PATCH 2/5] qcow2: Limit COW to where it's needed

2012-05-07 Thread Kevin Wolf
This fixes a regression introduced in commit 250196f1. The bug leads to data corruption, found during an Autotest run with a Fedora 8 guest. Consider a write request whose first part is covered by an already allocated cluster, but additional clusters need to be newly allocated. When counting the n

[Qemu-devel] [PATCH 4/5] qcow2: lock on prealloc

2012-05-07 Thread Kevin Wolf
From: Zhi Yong Wu preallocate() will be locked. This is required because qcow2_alloc_cluster_link_l2() assumes that it runs under a lock that it can drop while COW is being performed. Signed-off-by: Zhi Yong Wu Signed-off-by: Kevin Wolf --- block/qcow2.c |3 +++ 1 files changed, 3 inserti

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Jan Kiszka
On 2012-05-07 14:48, Michael Tokarev wrote: > On 07.05.2012 19:32, Jan Kiszka wrote: >> On 2012-05-07 11:45, Michael Tokarev wrote: > [] >>> $ ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -drive >>> file=w7x32sp1.raw,if=virtio,snapshot=on -m 1G -net none -machine >>> accel=kvm,kernel_irqchip=o

[Qemu-devel] [PATCH 5/5] fdc: simplify media change handling

2012-05-07 Thread Kevin Wolf
From: Hervé Poussineau This also (partly) fixes IBM OS/2 Warp 4.0 floppy installation, where not all floppies have the same format (2x80x18 for the first ones, 2x80x23 for the next ones). Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf --- hw/fdc.c | 29 +++

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Corey Minyard
I think we are getting a little out of hand here, and we are mixing up concepts :). There are lots of things IPMI *can* do (including serial access, VGA snooping, LAN access, etc.) but I don't see any value it that. The main thing here is to emulate the interface to the guest. OOB management

Re: [Qemu-devel] current qemu git does not work with win7 guest

2012-05-07 Thread Michael Tokarev
On 07.05.2012 22:07, Jan Kiszka wrote: > On 2012-05-07 14:48, Michael Tokarev wrote: >> On 07.05.2012 19:32, Jan Kiszka wrote: >>> On 2012-05-07 11:45, Michael Tokarev wrote: >> [] $ ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -drive file=w7x32sp1.raw,if=virtio,snapshot=on -m 1G -net

[Qemu-devel] Semantics of "-cpu host" (was Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest)

2012-05-07 Thread Eduardo Habkost
Andre? Are you able to help to answer the question below? I would like to clarify what's the expected behavior of "-cpu host" to be able to continue working on it. I believe the code will need to be fixed on either case, but first we need to figure out what are the expectations/requirements, to k

[Qemu-devel] ahci drive: how to make it non-bootable?

2012-05-07 Thread Michael Tokarev
I'm trying to experiment with ahci, but can't even get my win guest to install drivers for it. My usualy procedure is, for an existing guest, to add a dummy drive of required type, boot the guest, let it to recognize the new device and to install drivers needed for it, shut it down and change boot

Re: [Qemu-devel] [Bug 992067] Re: Windows 2008R2 very slow cold boot when >4GB memory

2012-05-07 Thread Matthew Anderson
Apologies for the late feedback, I've tested with the 1.0 source from sourceforge and also from the Proxmox git, both appeared to behave the same. The proxmox version appeared to be slightly better in the sense that the VM never blue screened on boot and it eventually booted whilst the sourcefo

Re: [Qemu-devel] [PATCH] fdc: simplify media change handling

2012-05-07 Thread Hervé Poussineau
Kevin Wolf a écrit : Am 05.05.2012 19:43, schrieb Hervé Poussineau: This also (partly) fixes IBM OS/2 Warp 4.0 floppy installation, where not all floppies have the same format (2x80x18 for the first ones, 2x80x23 for the next ones). Signed-off-by: Hervé Poussineau --- This patch fixes a real

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Corey Minyard
On 05/07/2012 02:45 PM, Dave Allan wrote: FWIW, the idea of an IPMI interface to VMs was proposed for libvirt not too long ago. See: https://bugzilla.redhat.com/show_bug.cgi?id=815136 Well, it wouldn't be to hard to do. I already have working emulation code that does the IPMI LAN interface

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Anthony Liguori
On 05/07/2012 01:07 PM, Corey Minyard wrote: I think we are getting a little out of hand here, and we are mixing up concepts :). There are lots of things IPMI *can* do (including serial access, VGA snooping, LAN access, etc.) but I don't see any value it that. The main thing here is to emulate

  1   2   >