Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Peter Maydell
On 17 April 2012 02:16, Anthony Liguori wrote: > On 04/16/2012 05:54 PM, Peter Maydell wrote: >> Yuck! Nack, this is way too invasive. Testing frameworks >> shouldn't require random pointless changes to every board >> model. > > I think the issue is that all of these machines mandate a -kernel opt

Re: [Qemu-devel] DOS VM problem with QEMU-KVM and newer kernels

2012-04-17 Thread Avi Kivity
On 04/17/2012 09:57 AM, Gleb Natapov wrote: > > > > Status is as follows: > > 1.) Kernel 3.4.x DIDN'T fix the problem > > 2.) Reverting f1c1da2bde712812a3e0f9a7a7ebe7a916a4b5f4 FIXED the problem. > > > > So the bug is still in 3.2., 3.3, 3.4rc present and a possible fix > > doesn't work. Should b

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 09:33, Peter Maydell ha scritto: > > I think the issue is that all of these machines mandate a -kernel option. > > qtest doesn't care if you pass a -kernel but requiring a kernel in order to > > test a device sucks especially if you don't possess the toolchain to build > > such a ker

Re: [Qemu-devel] [PATCH] iotests: fix error in 005

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 08:00, Dong Xu Wang ha scritto: > From: Dong Xu Wang > > According comment, we should not read again, we will write. > > Signed-off-by: Dong Xu Wang > --- > tests/qemu-iotests/005 |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/qemu-iotests/0

Re: [Qemu-devel] [PATCH 1/4] tcg: Add debug_info to JIT ELF image.

2012-04-17 Thread Avi Kivity
On 04/16/2012 10:46 PM, Richard Henderson wrote: > On 04/16/2012 11:28 AM, Avi Kivity wrote: > > Unable to read JIT descriptor from remote memory! > > (gdb) bt > > #0 0x7f4a1257cae5 in ?? () > > #1 0x in ?? () > > (gdb) > > set debug jit 1 Added to .gdbinit: GNU gdb (GDB) Fe

Re: [Qemu-devel] [RFC 00/14] MAINTAINERS cleanups - please read

2012-04-17 Thread Kevin Wolf
Am 16.04.2012 23:47, schrieb Anthony Liguori: > On 04/16/2012 04:24 PM, Peter Maydell wrote: >> I don't particularly object to providing a T: line for >> target-arm.next/arm-devs.next, but I'm not sure it's particularly useful, >> since we don't have the same tendency the kernel does to having subt

Re: [Qemu-devel] [PATCH] qapi: g_hash_table_find() instead of GHashTableIter.

2012-04-17 Thread Erik Rull
On April 13, 2012 at 5:01 PM "NODA, Kai" wrote: > From: "NODA, Kai" > > GHashTableIter was first introduced in glib 2.16. > This patch removes it in favor of older g_hash_table_find() > for better compatibility with RHEL5. > --- > qapi/qmp-input-visitor.c | 25 + > 1

Re: [Qemu-devel] block-stream/drive-mirror and default bandwidth

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 04:50, Eric Blake ha scritto: > Libvirt found out that we have a pretty nasty data race between > block-stream and block-job-set-speed. If a user wants to throttle a > job, they cannot request the throttling until after the job has been > started (thanks to the DeviceNotActive error

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 01:37, Igor Mammedov ha scritto: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > --- > target-i386/helper.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index de7637c..1996b97 100644 > ---

Re: [Qemu-devel] [PATCH RFC 4/6] target-i386: convert cpu to 2-stage initialization

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 01:37, Igor Mammedov ha scritto: > +if (((env->cpuid_features & CPUID_APIC) || smp_cpus > 1) && > !env->apic_state) { > +if (kvm_irqchip_in_kernel()) { > +env->apic_state = qdev_create(NULL, "kvm-apic"); > +} else { > +env->apic_state = qde

[Qemu-devel] [PATCH v2] iotests: fix error in 005

2012-04-17 Thread Dong Xu Wang
From: Dong Xu Wang According comment, we should not read again, we will write. Signed-off-by: Dong Xu Wang --- v1 - v2: add 005.out tests/qemu-iotests/005 |2 +- tests/qemu-iotests/005.out |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/005

Re: [Qemu-devel] qemu softmmu inlined lookup sequence

2012-04-17 Thread 陳韋任
> what does the inline sequence look like ? what kind of things (other > than refill tlb) performed in callout but not the inlined sequence ? What do you mean by the inline sequence, the host binary? If so, --- 0xe86c8 mov_i32 tmp2,edi qemu_ld8u tmp0,tmp2,$0x0 ext8u_i32 tmp12,tmp0 mo

Re: [Qemu-devel] qemu softmmu inlined lookup sequence

2012-04-17 Thread 陳韋任
> > If TLB miss, it will call something like __ldb_mmu (b). __ldb_mmu will try > > to > > walk guest page table, then fill TLB entry if page table hit, or raise a > > guest > > page fault exception if page table miss. > > Yep. that is what i was taught. the sequence of code above is an > inlined

Re: [Qemu-devel] A error when gdb the newest branch, can you help me? Thank you very much!

2012-04-17 Thread 陳韋任
> Thank you very much for your feedback, I found the reason: > > when I git pull to the newest branch then use gdb 7.2, the error will > happen, when I update gdb to 7.3, That is ok. > But I don't know the reason. Maybe the newest branch brings something > which don't compatible with gdb. Doe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/5] QOM'ify Power Architecture CPU

2012-04-17 Thread Andreas Färber
Am 16.04.2012 19:51, schrieb Alexander Graf: > > On 10.04.2012, at 16:09, Andreas Färber wrote: > >> Am 10.04.2012 08:41, schrieb David Gibson: >>> On Fri, Apr 06, 2012 at 06:17:07PM +0200, Andreas Färber wrote: Hello, This series follows up on my PowerPC QOM'ification patches from

[Qemu-devel] [PATCH 03/21] usb-uhci: queuing fix

2012-04-17 Thread Gerd Hoffmann
When we queue up usb packets we may happen to find a already queued packet, which also might be finished at that point already. We don't want continue processing the packet at this point though, so lets just signal back we've found a in-flight packet when in queuing mode. Signed-off-by: Gerd Hoff

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-04-17 Thread Andreas Färber
Am 17.04.2012 09:19, schrieb Paolo Bonzini: > Il 17/04/2012 01:37, Igor Mammedov ha scritto: >> From: Igor Mammedov >> >> Signed-off-by: Igor Mammedov >> --- >> target-i386/helper.c |4 >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/target-i386/helper.c b/target-

Re: [Qemu-devel] [PATCH] add function DMA_set_return and delete bh_schedule in dma.c

2012-04-17 Thread Paolo Bonzini
Il 16/04/2012 14:14, Stefan Hajnoczi ha scritto: > Why are you removing the rearm behavior? I'm pretty sure other ISA > devices rely on this otherwise the code wouldn't exist. Li is correct in that the code can be simplified a lot, but indeed his axe went a bit too far. :) With the exception of

Re: [Qemu-devel] [PATCH RFC 0/6] target-i386: use realize for cpu initialization

2012-04-17 Thread Andreas Färber
Am 17.04.2012 01:36, schrieb Igor Mammedov: > Attempt to use realize for x86 cpu initialization. > based on Paolo's "[PATCH v2] qom: Introduce object_realize_nofail()" > > working tree at: > https://github.com/imammedo/qemu/tree/x86-cpu-realize Note that I'm planning to push out my QOM propert

Re: [Qemu-devel] [PATCH v2 19/24] qdev: generalize properties to Objects

2012-04-17 Thread Zhi Yong Wu
On Thu, Apr 12, 2012 at 5:30 AM, Paolo Bonzini wrote: > The property machinery uses DeviceState arguments in a few places. > Replace this with Object so that we can push properties up. > > Signed-off-by: Paolo Bonzini > --- >  hw/qdev-addr.c       |   19 +++--- >  hw/qdev-properties.c |  173 > +

[Qemu-devel] [PATCH 01/21] usb/vmstate: add parent dev path

2012-04-17 Thread Gerd Hoffmann
... to make vmstate id string truely unique with multiple host controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr" (usb tabled connected to piix3 uhci). This obviously breaks migration. To handle this the usb bus property "full-path" is added. When setting this to false old behav

Re: [Qemu-devel] [ANNOUNCE] SeaBIOS 1.7.0

2012-04-17 Thread Gerd Hoffmann
On 04/16/12 22:11, Anthony Liguori wrote: > On 04/16/2012 06:35 AM, Gerd Hoffmann wrote: >>Hi, >> >>> WinXP guest is unable to find drivers for the video adaptor >>> with -vga std and this vgabios.bin, not even its "standard VGA" >>> fallback driver. The device in question is detected as "Othe

Re: [Qemu-devel] [PATCH v2] iotests: fix error in 005

2012-04-17 Thread Stefan Hajnoczi
On Tue, Apr 17, 2012 at 9:23 AM, Dong Xu Wang wrote: > From: Dong Xu Wang > > According comment, we should not read again, we will write. > > Signed-off-by: Dong Xu Wang > --- > v1 - v2: add 005.out > >  tests/qemu-iotests/005     |    2 +- >  tests/qemu-iotests/005.out |    2 +- >  2 files chan

[Qemu-devel] [PATCH 05/21] usb-host: trace emulated requests

2012-04-17 Thread Gerd Hoffmann
Add tracepoint to track completion of emulated control requests. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 12 +--- trace-events|1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 5eb6916..912ce2

Re: [Qemu-devel] [RFC 00/14] MAINTAINERS cleanups - please read

2012-04-17 Thread Andreas Färber
Am 16.04.2012 23:24, schrieb Peter Maydell: > On 16 April 2012 18:42, Anthony Liguori wrote: >> On 04/16/2012 12:17 PM, Peter Maydell wrote: >>> Here's my stab at it: >>>Maintained: Someone actually looks after it. The maintainer >>> will have a git subtree for

Re: [Qemu-devel] [ANNOUNCE] SeaBIOS 1.7.0

2012-04-17 Thread Michael Tokarev
On 17.04.2012 11:37, Gerd Hoffmann wrote: [] >>> You'll need to build multiple times with different configurations to get >>> the pci ids right for the various vga variants emulated by qemu. I'll >>> have some build scripts to do that here, just need to rebase and polish >>> them, I'll post the bi

[Qemu-devel] [PATCH 21/21] usb-ehci: drop assert()

2012-04-17 Thread Gerd Hoffmann
Not sure what the purpose of the assert() was, in any case it is bogous. We can arrive there if transfer descriptors passed to us from the guest failed to pass sanity checks, i.e. it is guest-triggerable. We deal with that case by resetting the host controller. Everything is ok, no need to throw

[Qemu-devel] [PULL 00/21] usb patch queue

2012-04-17 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue. Nothing major. Some tracing bits, some bugfixes. A new USBDescriptor for the binary representation of usb descriptors, to make the descriptor parsing and creating code more readable and to fix parser bugs. This is all old stuff which I was about to send tw

[Qemu-devel] [PATCH 08/21] usb-host: add property to turn off pipelining

2012-04-17 Thread Gerd Hoffmann
Add a property to usb-host to disable the bulk endpoint pipelining. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 8084fd9..a382f0a 100644 --- a/hw/usb/host-lin

[Qemu-devel] [PATCH 19/21] usb-ehci: Drop unused sofv value

2012-04-17 Thread Gerd Hoffmann
From: Hans de Goede The sofv value only ever gets a value assigned and is never used (read) anywhere, so we can just drop it. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/hw/usb/

[Qemu-devel] [PATCH 06/21] usb-host: trace canceled requests

2012-04-17 Thread Gerd Hoffmann
Add tracepoints to track canceled requests. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c |4 +++- trace-events|2 ++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 912ce23..6ea59a7 100644 --- a/hw/usb/host-li

[Qemu-devel] [PATCH 09/21] usb_packet_set_state: handle p->ep == NULL

2012-04-17 Thread Gerd Hoffmann
usb_packet_set_state can be called with p->ep = NULL. The tracepoint there tries to log endpoint information, which leads to a segfault. This patch makes usb_packet_set_state handle the NULL pointer properly. Signed-off-by: Gerd Hoffmann --- hw/usb/core.c | 17 +++-- 1 files chang

[Qemu-devel] [PATCH 11/21] usb-ehci: fix ehci_child_detach

2012-04-17 Thread Gerd Hoffmann
Looks like a cut+paste bug from ehci_detach. When the device itself is detached from a ehci port (ehci_detach op) we have to clear the device pointer for the companion port too. When a device gets removed from a downstream port of a usb hub (ehci_child_detach op) the ehci port where the usb hub i

Re: [Qemu-devel] block-stream/drive-mirror and default bandwidth

2012-04-17 Thread Stefan Hajnoczi
On Tue, Apr 17, 2012 at 8:53 AM, Paolo Bonzini wrote: > Il 17/04/2012 04:50, Eric Blake ha scritto: >> Libvirt found out that we have a pretty nasty data race between >> block-stream and block-job-set-speed.  If a user wants to throttle a >> job, they cannot request the throttling until after the

[Qemu-devel] [PATCH 14/21] usb: use USBDescriptor for device qualifier descriptors.

2012-04-17 Thread Gerd Hoffmann
Add device qualifier substruct to USBDescriptor, use it in the descriptor generator code. Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 23 --- hw/usb/desc.h | 10 ++ 2 files changed, 22 insertions(+), 11 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c

Re: [Qemu-devel] [PATCH v2] iotests: fix error in 005

2012-04-17 Thread Kevin Wolf
Am 17.04.2012 10:56, schrieb Stefan Hajnoczi: > On Tue, Apr 17, 2012 at 9:23 AM, Dong Xu Wang > wrote: >> From: Dong Xu Wang >> >> According comment, we should not read again, we will write. >> >> Signed-off-by: Dong Xu Wang >> --- >> v1 - v2: add 005.out >> >> tests/qemu-iotests/005 |2

Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.

2012-04-17 Thread Paolo Bonzini
Il 16/04/2012 23:43, Anthony Liguori ha scritto: > For a 10 line test that enumerates the PCI device given the command line > argument? > > Here's the thing, I just looked through the code and spotted what I > think is a buffer overflow. It's hard to tell purely from code > inspection. With just

[Qemu-devel] [PATCH 10/21] usb-hub: add tracepoints

2012-04-17 Thread Gerd Hoffmann
Add tracepoints to the usb hub emulation. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 43 +-- trace-events | 11 ++- 2 files changed, 51 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index eb4e711..

[Qemu-devel] [PATCH 13/21] usb: add USBDescriptor, use for device descriptors.

2012-04-17 Thread Gerd Hoffmann
This patch adds a new type for the binary representation of usb descriptors. It is put into use for the descriptor generator code where the struct replaces the hard-coded offsets. Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 37 +++-- hw/usb/desc.h | 26 +

[Qemu-devel] [PATCH 20/21] usb-redir: Notify our peer when we reject a device due to a speed mismatch

2012-04-17 Thread Gerd Hoffmann
From: Hans de Goede Also cleanup (reset) our device state when we reject a device due to a speed mismatch. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb

[Qemu-devel] [PATCH 16/21] usb: use USBDescriptor for interface descriptors.

2012-04-17 Thread Gerd Hoffmann
Add interface descriptor substruct to USBDescriptor, use it in the descriptor generator code. Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 20 +++- hw/usb/desc.h |9 + 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c

Re: [Qemu-devel] [RFC 00/14] MAINTAINERS cleanups - please read

2012-04-17 Thread Peter Maydell
On 17 April 2012 09:59, Andreas Färber wrote: > Am 16.04.2012 23:24, schrieb Peter Maydell: >> I wouldn't expect people to base arm patches against >> arm-devs.next rather than master, for instance. (Maybe I should??) > > I'm kind of expecting you to, during the Hard Freeze and in case of > accept

Re: [Qemu-devel] [PATCH v3] use an uint64_t for the max_sz parameter in load_image_targphys

2012-04-17 Thread Alexander Graf
On 04/11/2012 10:48 PM, Mark Langsdorf wrote: On 03/12/2012 11:47 AM, Andreas Färber wrote: Am 12.03.2012 17:33, schrieb Mark Langsdorf: Allow load_image_targphys to load files on systems with more than 2G of emulated memory by changing the max_sz parameter from an int to an uint64_t. Signed-o

[Qemu-devel] [PATCH] seabios: update to 1.7.0

2012-04-17 Thread Gerd Hoffmann
Update roms/seabios and pc-bios/bios.bin to the 1.7.0 release. Most noticable new feature is virtio-scsi support. Signed-off-by: Gerd Hoffmann --- pc-bios/bios.bin | Bin 131072 -> 131072 bytes roms/seabios |2 +- 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pc-bios/bi

[Qemu-devel] [PULL 0/1] update seabios to 1.7.0

2012-04-17 Thread Gerd Hoffmann
Hi, $subject says all, this pull updates seabios to the recently released seabios 1.7.0 version. please pull, Gerd The following changes since commit 158fd3ce98afd21f2e2639600f6414ea703a9121: qemu-timer.c: Remove 250us timeouts (2012-04-16 12:56:48 -0500) are available in the git reposit

[Qemu-devel] [PATCH 18/21] usb-host: rewrite usb_linux_update_endp_table

2012-04-17 Thread Gerd Hoffmann
This patch carries a complete rewrite of the usb descriptor parser. Changes / improvements: * We are using the USBDescriptor struct instead of hard-coded offsets now to access descriptor data. * (debug) printfs are all gone, tracepoints have been added instead. * We don't try (and fail) to s

[Qemu-devel] [PATCH 02/21] usb-uhci: stop queue filling when we find a in-flight td

2012-04-17 Thread Gerd Hoffmann
Not only QHs can form rings, but TDs too. With the new queuing/pipelining support we are following TD chains and can actually walk in circles. An assert() prevents us from entering an endless loop then. Fix is easy: Just stop queuing when we figure the TD we are about to queue up is in flight a

[Qemu-devel] [PATCH 04/21] Add bootindex support to usb-host and usb-redir

2012-04-17 Thread Gerd Hoffmann
When passing through a usb pendrive seabios will present it in the F12 boot menu and will happily boot from it. This patch adds bootorder support so you can even make it the default boot device. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c |3 +++ hw/usb/redirect.c |3 +++ 2 f

[Qemu-devel] [PATCH 15/21] usb: use USBDescriptor for config descriptors.

2012-04-17 Thread Gerd Hoffmann
Add config descriptor substruct to USBDescriptor, use it in the descriptor generator code. Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 22 -- hw/usb/desc.h |9 + 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c

[Qemu-devel] [RFC PATCH] disable execution of SWP/SWPB

2012-04-17 Thread Alexey Starikovskiy
Hi, I was wondering how to implement disabling of SWP/SWPB execution if they are not enabled in SCTLR.SW bit. One way to do this is to intercept writes to SCTLR, do tb_flush and make SWP [un]defined for any following translations depending on the c1_sys state during the translation. The other way

[Qemu-devel] [PATCH 12/21] usb-ehci: frindex always is a 14 bits counter

2012-04-17 Thread Gerd Hoffmann
From: Hans de Goede frindex always is a 14 bits counter, and not a 13 bits one as we were emulating. There are some subtle hints to this in the spec, first of all "Table 2-12. FRINDEX - Frame Index Register" says: "Bit 13:0 Frame Index. The value in this register increments at the end of each tim

Re: [Qemu-devel] [PATCH RFC 0/6] target-i386: use realize for cpu initialization

2012-04-17 Thread Igor Mammedov
- Original Message - > From: "Andreas Färber" [cut]...[/cut] > Note that I'm planning to push out my QOM properties for X86CPU > today, > as suggested by Eduardo. I don't see a conflict on brief sight. > > Andreas np, I'll rebase on top of it. > > -- > SUSE LINUX Products GmbH, Maxfeldst

[Qemu-devel] [PATCH 17/21] usb: use USBDescriptor for endpoint descriptors.

2012-04-17 Thread Gerd Hoffmann
Add endpoint descriptor substruct to USBDescriptor, use it in the descriptor generator code. Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 20 +++- hw/usb/desc.h |9 + 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c i

Re: [Qemu-devel] [RFC PATCH 3/3] qtest: add virtio-test test-case

2012-04-17 Thread Stefan Hajnoczi
On Mon, Apr 16, 2012 at 7:07 PM, Anthony Liguori wrote: > On 04/13/2012 09:27 AM, Stefan Hajnoczi wrote: >> >> Signed-off-by: Stefan Hajnoczi >> --- >>  tests/Makefile      |    3 +- >>  tests/virtio-test.c |   88 >> +++ >>  2 files changed, 90 inser

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-04-17 Thread Igor Mammedov
- Original Message - > From: "Paolo Bonzini" > To: "Igor Mammedov" > Cc: qemu-devel@nongnu.org, afaer...@suse.de, aligu...@us.ibm.com, "jan > kiszka" > Sent: Tuesday, April 17, 2012 9:19:44 AM > Subject: Re: [PATCH RFC 6/6] target-i386: make cpus childs of /machine > > Il 17/04/2012 01

Re: [Qemu-devel] [PATCH] usb-host: fix handling of zero-length packets

2012-04-17 Thread Johannes Stezenbach
Hi Gerd, On Mon, Apr 02, 2012 at 01:50:35PM +0200, Johannes Stezenbach wrote: > Zero-length packets are valid but currently cause > qemu to crash: did you have a chance to look at this? Thanks, Johannes > Program terminated with signal 11, Segmentation fault. > #0 0xf7589f26 in usb_host_handl

[Qemu-devel] [PATCH 07/21] usb-host: add usb packet to request tracepoints

2012-04-17 Thread Gerd Hoffmann
Add pointer to USBPacket to all tracepoints tracking requests to make it easier to identify them when multiple requests are in flight. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 26 ++ trace-events| 10 +- 2 files changed, 19 insertions(+),

[Qemu-devel] [PATCH 2/3] Update vgabios binaries

2012-04-17 Thread Gerd Hoffmann
This patch updates the vgabios binaries to seabios-1.7.0. Note that this isn't a simple update. We switch from the lgpl'ed vgabios (https://savannah.nongnu.org/projects/vgabios) to the vgabios provided by seabios here. Any regressions should be reported to the seabios mailing list. Signed-off-b

[Qemu-devel] [PATCH 3/3] Switch isa vga to seavgabios too.

2012-04-17 Thread Gerd Hoffmann
Note: untested as 'qemu -M isapc' is broken. Signed-off-by: Gerd Hoffmann --- hw/vga-isa.c |2 +- hw/vga_int.h |1 - pc-bios/vgabios-isavga.bin | Bin 0 -> 37888 bytes 3 files changed, 1 insertions(+), 2 deletions(-) create mode 100644 pc-bios/vgabios-isavga

Re: [Qemu-devel] [RFC PATCH] disable execution of SWP/SWPB

2012-04-17 Thread Peter Maydell
On 17 April 2012 10:53, Alexey Starikovskiy wrote: > I was wondering how to implement disabling of SWP/SWPB execution if > they are not enabled in SCTLR.SW bit. > One way to do this is to intercept writes to SCTLR, do tb_flush and > make SWP [un]defined for any following translations depending on

[Qemu-devel] [PATCH 1/3] Add seavgabios build rules to roms/Makefile

2012-04-17 Thread Gerd Hoffmann
This patch adds some glue to roms/Makefile to build vgabios binaries for qemu from the seabios sources. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 13 + roms/config.vga.cirrus |3 +++ roms/config.vga.isavga |3 +++ roms/config.vga.qxl|6 ++ roms/c

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-04-17 Thread Igor Mammedov
- Original Message - > From: "Andreas Färber" > To: "Paolo Bonzini" , "Igor Mammedov" > > Cc: qemu-devel@nongnu.org, aligu...@us.ibm.com, "jan kiszka" > > Sent: Tuesday, April 17, 2012 10:46:14 AM > Subject: Re: [PATCH RFC 6/6] target-i386: make cpus childs of /machine > > Am 17.04.201

[Qemu-devel] [PATCH 0/3] switch to seavgabios

2012-04-17 Thread Gerd Hoffmann
Hi, This patch series switches the vgabios binaries shipped by qemu from the lgpl'ed vgabios to the seabios version. There should be no guest-visible changes (especially no regressions) in theory. The only known (and intentional) exception is the vesa 2.0 protected mode interface which is not

[Qemu-devel] [PATCH] ehci: remove hack

2012-04-17 Thread Gerd Hoffmann
To answer the question in the comment removed by this patch: I think this was needed because several places in the ehci emulation did not check the T bit of link entries correctly and thus might have followed invalid references. See commit 2a5ff735dc1074171a0cbb1dc228d6d6e907f571 --- hw/usb/hcd-

Re: [Qemu-devel] [PATCH] ehci: remove hack

2012-04-17 Thread Kevin Wolf
Am 17.04.2012 12:44, schrieb Gerd Hoffmann: > To answer the question in the comment removed by this patch: I think > this was needed because several places in the ehci emulation did not > check the T bit of link entries correctly and thus might have followed > invalid references. See commit 2a5ff

Re: [Qemu-devel] [PATCH RFC 5/6] target-i386: move reset callback to cpu.c

2012-04-17 Thread Jan Kiszka
On 2012-04-17 01:37, Igor Mammedov wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > --- > hw/pc.c |8 > target-i386/cpu.c |8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index db381ab..157327a 100644

Re: [Qemu-devel] [PATCH 1/3] Add seavgabios build rules to roms/Makefile

2012-04-17 Thread Michael Tokarev
On 17.04.2012 14:11, Gerd Hoffmann wrote: > This patch adds some glue to roms/Makefile to build vgabios binaries for > qemu from the seabios sources. FWIW, this is a similar change for seabios debian package I'm preparing currently. Thanks, /mjt diff --git a/debian/rules b/debian/rules index 63

[Qemu-devel] [PATCH] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy --- target-arm/translate.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 7a3c7d6..b35c85f 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -7415,6 +7415,12

Re: [Qemu-devel] [PATCH RFC 5/6] target-i386: move reset callback to cpu.c

2012-04-17 Thread Igor Mammedov
- Original Message - > From: "Jan Kiszka" > To: "Igor Mammedov" > Cc: qemu-devel@nongnu.org, pbonz...@redhat.com, afaer...@suse.de, > aligu...@us.ibm.com > Sent: Tuesday, April 17, 2012 1:28:45 PM > Subject: Re: [PATCH RFC 5/6] target-i386: move reset callback to cpu.c > > On 2012-04-17

Re: [Qemu-devel] [PATCH 0/3] switch to seavgabios

2012-04-17 Thread malc
On Tue, 17 Apr 2012, Gerd Hoffmann wrote: > Hi, > > This patch series switches the vgabios binaries shipped by qemu from the > lgpl'ed vgabios to the seabios version. > > There should be no guest-visible changes (especially no regressions) in > theory. The only known (and intentional) excepti

Re: [Qemu-devel] [PATCH 6/7 v5] Packet abstraction used by VMWARE network devices

2012-04-17 Thread Dmitry Fleytman
Hello, Anthony Thanks for you comments, see inline. On Mon, Apr 16, 2012 at 11:06 PM, Anthony Liguori wrote: > On 03/18/2012 04:27 AM, Dmitry Fleytman wrote: >> >> Signed-off-by: Dmitry Fleytman >> Signed-off-by: Yan Vugenfirer >> --- >>  hw/vmxnet_pkt.c | 1243 >> +++

Re: [Qemu-devel] [PATCH] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Peter Maydell
On 17 April 2012 12:39, Alexey Starikovskiy wrote: Patches should almost always have more than a single line commit message in my opinion. > Signed-off-by: Alexey Starikovskiy > --- >  target-arm/translate.c |    6 ++ >  1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/targ

Re: [Qemu-devel] [PATCH RFC 5/6] target-i386: move reset callback to cpu.c

2012-04-17 Thread Andreas Färber
Am 17.04.2012 13:40, schrieb Igor Mammedov: > - Original Message - >> From: "Jan Kiszka" >> To: "Igor Mammedov" >> Cc: qemu-devel@nongnu.org, pbonz...@redhat.com, afaer...@suse.de, >> aligu...@us.ibm.com >> Sent: Tuesday, April 17, 2012 1:28:45 PM >> Subject: Re: [PATCH RFC 5/6] target-i

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Anthony Liguori
On 04/17/2012 02:44 AM, Paolo Bonzini wrote: Il 17/04/2012 09:33, Peter Maydell ha scritto: I think the issue is that all of these machines mandate a -kernel option. qtest doesn't care if you pass a -kernel but requiring a kernel in order to test a device sucks especially if you don't possess

Re: [Qemu-devel] [PATCH] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
On 04/17/2012 03:55 PM, Peter Maydell wrote: On 17 April 2012 12:39, Alexey Starikovskiy wrote: Patches should almost always have more than a single line commit message in my opinion. Ok Signed-off-by: Alexey Starikovskiy --- target-arm/translate.c |6 ++ 1 files changed, 6 insert

Re: [Qemu-devel] [PATCH] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Peter Maydell
On 17 April 2012 13:03, Alexey Starikovskiy wrote: > On 04/17/2012 03:55 PM, Peter Maydell wrote: >> >> On 17 April 2012 12:39, Alexey Starikovskiy  wrote: >> >> Patches should almost always have more than a single line >> commit message in my opinion. >> > Ok >>> >>> Signed-off-by: Alexey Stariko

Re: [Qemu-devel] [PATCH 7/8] block: add witness argument to drive-reopen

2012-04-17 Thread Eric Blake
[adding libvir-list for some interesting discussions on potential libvirt design issues] On 04/17/2012 12:47 AM, Paolo Bonzini wrote: > Il 16/04/2012 23:55, Eric Blake ha scritto: >>> Do transient guests have persistent storage for them in /var while they >>> are running? >> >> Yes - that's how li

Re: [Qemu-devel] block-stream/drive-mirror and default bandwidth

2012-04-17 Thread Eric Blake
On 04/17/2012 03:20 AM, Stefan Hajnoczi wrote: > I think it's cleanest to support block-job-set-speed even when no job > is running. The speed will be used as the default value when a job is > started. This poses the question of what happens if the job does not > do throttling or cannot support t

Re: [Qemu-devel] [RFC 00/14] MAINTAINERS cleanups - please read

2012-04-17 Thread Anthony Liguori
On 04/17/2012 02:53 AM, Kevin Wolf wrote: Am 16.04.2012 23:47, schrieb Anthony Liguori: On 04/16/2012 04:24 PM, Peter Maydell wrote: I don't particularly object to providing a T: line for target-arm.next/arm-devs.next, but I'm not sure it's particularly useful, since we don't have the same tend

Re: [Qemu-devel] [PATCH 0/3] switch to seavgabios

2012-04-17 Thread Gerd Hoffmann
On 04/17/12 13:40, malc wrote: > On Tue, 17 Apr 2012, Gerd Hoffmann wrote: > >> Hi, >> >> This patch series switches the vgabios binaries shipped by qemu from the >> lgpl'ed vgabios to the seabios version. >> >> There should be no guest-visible changes (especially no regressions) in >> theory.

Re: [Qemu-devel] [PATCH] ehci: remove hack

2012-04-17 Thread Hans de Goede
Hi, On 04/17/2012 12:44 PM, Gerd Hoffmann wrote: To answer the question in the comment removed by this patch: I think this was needed because several places in the ehci emulation did not check the T bit of link entries correctly and thus might have followed invalid references. See commit 2a5ff

[Qemu-devel] [PATCH v2] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
ARM v7MP deprecates use of SWP instruction and only defines it if OS explicitly requests it via setting SCTLR.SW bit. Such a request is expected to occur only once during OS init, thus only static checking for this bit and flush of all translations is done on SCTLR change. Signed-off-by: Alexey St

Re: [Qemu-devel] [PULL 00/21] usb patch queue

2012-04-17 Thread Hans de Goede
Hi, You seem to have missed my last 4 usb patches. This is not really a problem, they can be picked by the next pull req, just making sure they don't fall through the cracks. You can find them here: http://cgit.freedesktop.org/~jwrdegoede/qemu/log/ Other then that the entire series looks good, s

[Qemu-devel] [PATCH 00/10] apply volume on client side v5 bis

2012-04-17 Thread Marc-André Lureau
Just resending as a reminder, thanks. Marc-André Lureau (10): audio: add VOICE_VOLUME ctl audio: don't apply volume effect if backend has VOICE_VOLUME_CAP hw/ac97: remove USE_MIXER code hw/ac97: the volume mask is not only 0x1f hw/ac97: add support for volume control audio/spice: add s

[Qemu-devel] [PATCH 0/7 V6] VMXNET3 paravirtual NIC device implementation

2012-04-17 Thread Dmitry Fleytman
From: Dmitry Fleytman This set of patches implements VMWare VMXNET3 paravirtual NIC device. The device supports of all the device features including offload capabilties, VLANs and etc. The device is tested on different OSes: Fedora 15 Ubuntu 10.4 Centos 6.2 Windows 2008R2 Wind

[Qemu-devel] [PATCH 1/7 V6] Adding missing flag VIRTIO_NET_HDR_F_DATA_VALID from Linux kernel source tree Reformatting comments according to checkpatch.pl requirements

2012-04-17 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/virtio-net.h | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/virtio-net.h b/hw/virtio-net.h index 4468741..fa3c17b 100644 --- a/hw/virtio-net.h +++ b/hw/virtio-net.

[Qemu-devel] [PATCH 6/7 V6] Packet abstraction used by VMWARE network devices

2012-04-17 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_pkt.c | 776 +++ hw/vmxnet_pkt.h | 311 ++ 2 files changed, 1087 insertions(+), 0 deletions(-) create mode 100644 hw/vmxne

Re: [Qemu-devel] [libvirt] [PATCH 7/8] block: add witness argument to drive-reopen

2012-04-17 Thread Michal Privoznik
On 17.04.2012 14:09, Eric Blake wrote: > [adding libvir-list for some interesting discussions on potential > libvirt design issues] > > On 04/17/2012 12:47 AM, Paolo Bonzini wrote: >> Il 16/04/2012 23:55, Eric Blake ha scritto: Do transient guests have persistent storage for them in /var whil

[Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
ARM v7MP deprecates use of SWP instruction and only defines it if OS explicitly requests it via setting SCTLR.SW bit. Such a request is expected to occur only once during OS init, thus only static checking for this bit and flush of all translations is done on SCTLR change. Signed-off-by: Alexey St

[Qemu-devel] [PATCH 05/10] hw/ac97: add support for volume control

2012-04-17 Thread Marc-André Lureau
Combine output volume with Master and PCM registers values. Use default values in mixer_reset (). Set volume on post-load to update backend values. v4,v5: - fix some code style Signed-off-by: Marc-André Lureau --- hw/ac97.c | 81 + 1

[Qemu-devel] [PATCH 04/10] hw/ac97: the volume mask is not only 0x1f

2012-04-17 Thread Marc-André Lureau
It's a case by case (see Table 66. AC ‘97 Baseline Audio Register Map) Signed-off-by: Marc-André Lureau --- hw/ac97.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/ac97.c b/hw/ac97.c index f2804e6..f7866ed 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -118,7 +118,6 @@ enum { #define EACS

[Qemu-devel] [PATCH 10/10] Enable mixemu by default, add runtime option

2012-04-17 Thread Marc-André Lureau
Without MIXEMU, volume control on the guest doesn't work (except when volume is applied by guest "emulation", in Win7 for example). Instead rely on backend volume support, or fallback on mixeng if backend doesn't support volume control, except if mixemu is disabled with QEMU_MIXEMU=0. Signed-off-

Re: [Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Peter Maydell
On 17 April 2012 13:50, Alexey Starikovskiy wrote: > ARM v7MP deprecates use of SWP instruction and only defines it > if OS explicitly requests it via setting SCTLR.SW bit. > Such a request is expected to occur only once during OS init, thus > only static checking for this bit and flush of all tra

Re: [Qemu-devel] [PATCH 0/3] switch to seavgabios

2012-04-17 Thread malc
On Tue, 17 Apr 2012, Gerd Hoffmann wrote: > On 04/17/12 13:40, malc wrote: > > On Tue, 17 Apr 2012, Gerd Hoffmann wrote: > > > >> Hi, > >> > >> This patch series switches the vgabios binaries shipped by qemu from the > >> lgpl'ed vgabios to the seabios version. > >> > >> There should be no gues

[Qemu-devel] [PATCH 3/7 V6] Adding utility function iov_net_csum_add() for iovec checksum calculation Adding utility function iov_rebuild() for smart iovec copy

2012-04-17 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- iov.c | 53 + iov.h |6 ++ 2 files changed, 59 insertions(+), 0 deletions(-) diff --git a/iov.c b/iov.c index 0f96493..0ac15a1 100644 --- a/iov.

Re: [Qemu-devel] [PATCH v3] Undefine SWP instruction unless SCTLR.SW bit is set

2012-04-17 Thread Alexey Starikovskiy
> Adding this brace is incorrectly changing behaviour. > (I agree that it's pretty obscure and halfway to being an > outright bug. It all goes away with the cp15 rework anyway.) Should I add tb_flush() without braces too or set second if() only to avoid changing the bogus behavior? >> +            

[Qemu-devel] [PATCH 5/7 V6] Various utility functions used by VMWARE network devices

2012-04-17 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_debug.h | 121 +++ hw/vmxnet_utils.c | 219 ++ hw/vmxnet_utils.h | 341 + 3 files changed, 681

[Qemu-devel] [PATCH 01/10] audio: add VOICE_VOLUME ctl

2012-04-17 Thread Marc-André Lureau
Add a new PCM control operation to update the stream volume on the audio backend. The argument given is a SWVoiceOut/SWVoiceIn. v4: - verified other backends didn't fail/assert on this new control they randomly return 0 or -1, but we ignore return value. Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH 2/7 V6] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2012-04-17 Thread Dmitry Fleytman
From: Dmitry Fleytman Adding utility function net_raw_checksum() that calculates checksum of buffer given Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- net/checksum.c | 13 +++-- net/checksum.h | 14 +- 2 files changed, 20 insertions(+), 7 deletions(

[Qemu-devel] [PATCH v2] ehci: remove hack

2012-04-17 Thread Gerd Hoffmann
To answer the question in the comment removed by this patch: I think this was needed because several places in the ehci emulation did not check the T bit of link entries correctly and thus might have followed invalid references. See commit 2a5ff735dc1074171a0cbb1dc228d6d6e907f571 Signed-off-by:

  1   2   3   >