Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Orit Wasserman
On 03/07/2012 12:47 AM, Amos Kong wrote: > Introduce tcp_server_start() by moving original code in > tcp_start_incoming_migration(). > > Signed-off-by: Amos Kong > --- > net.c | 28 > qemu_socket.h |2 ++ > 2 files changed, 30 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 08:14, Orit Wasserman ha scritto: > if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)) < 0) > { > closesocket(*fd); > return -socket_error(); > } > return 0; > > and than you will not need ret But closesocket could clobber socket_error(), no? Paolo

Re: [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start()

2012-03-14 Thread Orit Wasserman
On 03/07/2012 12:48 AM, Amos Kong wrote: > Introduce tcp_client_start() by moving original code in > tcp_start_outgoing_migration(). > > Signed-off-by: Amos Kong > --- > net.c | 41 + > qemu_socket.h |1 + > 2 files changed, 42 insertions(+),

Re: [Qemu-devel] [PATCH 0/7] QOM'ify UniCore32 CPU

2012-03-14 Thread Guan Xuetao
On Wed, 2012-03-14 at 02:39 +0100, Andreas Färber wrote: > Hello, > > Based on qom-cpu v4 and object_class_get_list() v2, this series converts > the UniCore32 CPU to QOM. Code-wise, target-unicore32 is pretty close to > target-arm and faces a similar issue of CPU-dependent init code, so let's > ta

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-14 Thread Paolo Bonzini
Il 13/03/2012 20:13, Richard Laager ha scritto: >> > To be completely correct, I suggest the following behavior: >>> > > 1. Add a discard boolean option to the disk layer. >>> > > 2. If discard is not specified: >>> > > * For files, detect a true/false value by comparing >>>

Re: [Qemu-devel] Man page: Add -global description

2012-03-14 Thread Paolo Bonzini
Il 13/03/2012 19:09, Miroslav Rezanina ha scritto: > +@example > +qemu -global ide-drive.physical_block_size=524 -drive > file=file,if=ide,index=0,media=disk > +@end example Let's use something that works, such as 4096 instead of 524. :) Paolo

Re: [Qemu-devel] [PATCH 1/7] MAINTAINERS: Add entry for UniCore32

2012-03-14 Thread Guan Xuetao
On Wed, 2012-03-14 at 02:39 +0100, Andreas Färber wrote: > Consider it Odd Fixes for now. > > Signed-off-by: Andreas Färber > Cc: Guan Xuetao > --- > MAINTAINERS |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f83d07c2..44ff92

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Amos Kong
On 14/03/12 15:27, Paolo Bonzini wrote: Hi Paolo, Il 14/03/2012 08:14, Orit Wasserman ha scritto: if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) { closesocket(*fd); return -socket_error(); } return 0; and than you will not need ret But closesocket could clo

Re: [Qemu-devel] [PATCH 2/7] target-unicore32: Relicense to GPLv2+

2012-03-14 Thread Guan Xuetao
On Wed, 2012-03-14 at 02:39 +0100, Andreas Färber wrote: > Adopt the license text suggested by Guan Xue-tao for all files except > helper.c, to which Anthony Liguori (IBM) contributed a g_malloc() call. > > Signed-off-by: Andreas Färber > Signed-off-by: Guan Xuetao > Signed-off-by: Stefan Weil

Re: [Qemu-devel] Man page: Add -global description

2012-03-14 Thread Miroslav Rezanina
- Original Message - > From: "Paolo Bonzini" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org > Sent: Wednesday, March 14, 2012 8:42:00 AM > Subject: Re: Man page: Add -global description > > Il 13/03/2012 19:09, Miroslav Rezanina ha scritto: > > +@example > > +qemu -global ide-dr

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Lai Jiangshan
On 03/13/2012 07:04 PM, Andreas Färber wrote: > Am 13.03.2012 10:32, schrieb Lai Jiangshan: >> On 02/16/2012 08:51 PM, Anthony Liguori wrote: >>> On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: > +static ICCBusDeviceInfo cpu_device_info = { > +.q

Re: [Qemu-devel] [PATCH 3/7] target-unicore32: QOM'ify CPU

2012-03-14 Thread Guan Xuetao
On Wed, 2012-03-14 at 02:39 +0100, Andreas Färber wrote: > Embed CPUUniCore32State into UniCore32CPU. > > Contributed under GPLv2+. > > Signed-off-by: Andreas Färber > --- > Makefile.target|1 + > target-unicore32/cpu-qom.h | 72 ++ > target-uni

Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference

2012-03-14 Thread Markus Armbruster
Andreas Färber writes: > Am 13.03.2012 19:32, schrieb Mark Langsdorf: >> From: Joshua Housh >> >> Make sure a BusInfo exists before trying to dereference it. > > What's the use case that breaks? Valid question. Every qdev has / used to have a parent bus, and every bus info. If that's not tru

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Gerd Hoffmann
Hi, >> Some solutions that come to my mind: >> >> 1. Pool the screendump file creation from a timer. >> >> Cons: it may return before the file is fully written to disk >> > > We know what the file size should be, so we can poll for the actual > size. Actually why do we need to poll? we cou

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Gerd Hoffmann
Hi, > ok, I'll take it. Note that I'm going to not send the qxl screendump > behavior changing patch again, I think all alternatives to a real async > screendump suck, including libvirt changes, and the current behavior of > giving an old screendump is good enough hopefully for the real users, >

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/13/2012 06:47 PM, Avi Kivity Wrote: > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? >>> >>> Not really, but I'm not 100

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 08:51, Amos Kong ha scritto: > > > ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)); > if (ret < 0) { > ret = -socket_error(); > closesocket(*fd); > } > return ret; > } Looks good. Paolo

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 09:25:29AM +0100, Gerd Hoffmann wrote: > Hi, > > > ok, I'll take it. Note that I'm going to not send the qxl screendump > > behavior changing patch again, I think all alternatives to a real async > > screendump suck, including libvirt changes, and the current behavior of

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Amos Kong
On 14/03/12 00:39, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kong --- net.c | 28 qemu_socket.h |2 ++

Re: [Qemu-devel] [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 01:00, Zhang, Yang Z ha scritto: > Is there any comments with the version 3? Can you explain why you dropped the logic to set the timer to the next event? Paolo

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 09:14:46AM +0100, Gerd Hoffmann wrote: > Hi, > > >> Some solutions that come to my mind: > >> > >> 1. Pool the screendump file creation from a timer. > >> > >> Cons: it may return before the file is fully written to disk > >> > > > > We know what the file size shoul

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Igor Mammedov
On 03/14/2012 08:59 AM, Lai Jiangshan wrote: On 03/13/2012 07:04 PM, Andreas Färber wrote: Am 13.03.2012 10:32, schrieb Lai Jiangshan: On 02/16/2012 08:51 PM, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo c

Re: [Qemu-devel] [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Zhang, Yang Z
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, March 14, 2012 4:35 PM > To: Zhang, Yang Z > Cc: qemu-devel@nongnu.org; Jan Kiszka; k...@vger.kernel.org; > aligu...@us.ibm.com; Marcelo Tosatti > Subject: Re: [PATCH v3 0/7] RTC: New logic to emulate

[Qemu-devel] [PATCH v2] Man page: Add -global description

2012-03-14 Thread Miroslav Rezanina
There's only TODO information in qemu man page for -global option. This is a basic description of this option with simple example. Signed-off-by: Miroslav Rezanina Patch: -- diff --git a/qemu-options.hx b/qemu-options.hx index daefce3..876f929 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

Re: [Qemu-devel] [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 09:52, Zhang, Yang Z ha scritto: > Is there any comments with the version 3? >>> >>> Can you explain why you dropped the logic to set the timer to the >>> next event? > Do you mean why I change the rtc logic? The reason is that: When a > guest is idle, the main activity inside qe

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 12:30 AM, Amos Kong wrote: > - Original Message - >> On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong wrote: > > ... > > Hi, Stefan > >> > diff --git a/kvm-all.c b/kvm-all.c >> > index 77eadf6..7157e78 100644 >> > --- a/kvm-all.c >> > +++ b/kvm-all.c >> > @@ -771,6 +771,

Re: [Qemu-devel] [PATCH RFC v4 02/20] target-arm: Introduce QOM ARMCPUClass

2012-03-14 Thread Igor Mitsyanko
On 03/13/2012 09:58 PM, Andreas Färber wrote: Am 13.03.2012 13:31, schrieb Igor Mitsyanko: On 03/10/2012 08:53 PM, Andreas Färber wrote: diff --git a/target-arm/cpu.c b/target-arm/cpu.c new file mode 100644 index 000..dabc094 --- /dev/null +++ b/target-arm/cpu.c [...] +static void cpu_r

Re: [Qemu-devel] [PATCH v2 1/2] qxl: switch qxl.c to trace-events

2012-03-14 Thread Gerd Hoffmann
Hi, > dprint is still used for qxl_init_common one time prints. > > also switched parts of spice-display.c over, mainly all the callbacks to > spice server. > > All qxl device trace events start with the qxl device id. Looks pretty good overall, just some little nits left ... > @@ -948,8 +9

Re: [Qemu-devel] [PATCH v2 2/2] qxl/qxl_render.c: add trace events

2012-03-14 Thread Gerd Hoffmann
> +# hw/qxl-render.c > +qxl_blit_guest_primary_initialized(void) "" > +qxl_blit(int32_t stride, int32_t left, int32_t right, int32_t top, int32_t > bottom) "stride=%d [%d, %d, %d, %d]" > +qxl_guest_primary_resized(int32_t width, int32_t height, int32_t stride, > int32_t bytes_pp, int32_t bits_pp)

Re: [Qemu-devel] [PATCH v3] w32: Support tests (make check)

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 07:44, schrieb Stefan Weil: > Adding $(EXESUF) is needed to make those tests work on w32 hosts, too. > > v2: > Rebased, added new tests, tests sorted alphabetically. > > v3: > Rebased, $(EXESUF) for qemu-img, qemu-io which were recently added. I have no idea if there's any chance o

Re: [Qemu-devel] [PATCH 10/13] iommu: Introduce IOMMU emulation infrastructure

2012-03-14 Thread David Gibson
On Tue, Mar 13, 2012 at 03:37:09PM +0100, Alexander Graf wrote: > On 13.03.2012, at 15:04, David Gibson wrote: > > On Tue, Mar 13, 2012 at 02:56:47PM +0100, Alexander Graf wrote: > >> On 13.03.2012, at 06:07, David Gibson wrote: [snip] > This need not be a configure option. Just enable it, or

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
Am 13.03.2012 21:48, schrieb Eric Blake: > On 03/06/2012 10:56 AM, Paolo Bonzini wrote: >> From: Federico Simoncelli >> >> Signed-off-by: Federico Simoncelli >> Signed-off-by: Paolo Bonzini > >> ## >> +# @drive-reopen >> +# >> +# Assigns a new image file to a device. >> +# >> +# @device: the n

[Qemu-devel] [RESEND][PATCH 02/14 v9] Add API to check whether a physical address is I/O address

2012-03-14 Thread Wen Congyang
This API will be used in the following patch. Signed-off-by: Wen Congyang --- cpu-common.h |2 ++ exec.c |9 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index dca5175..fcd50dc 100644 --- a/cpu-common.h +++ b/cpu-common.h @@

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 6:14 PM, Stefan Weil wrote: > Am 13.03.2012 17:31, schrieb Andreas Färber: > >> Am 13.03.2012 11:41, schrieb Stefan Hajnoczi: >>> >>> On Mon, Mar 12, 2012 at 8:12 PM, Stefan Weil wrote: Am 12.03.2012 18:06, schrieb Stefano Stabellini: Maybe every maintainer

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 10:17, Kevin Wolf ha scritto: > If we want to do this, it needs to be the same patch, as we couple the > transaction actions with top-level commands as long as there is no other > way to discover the possible actions. And it probably makes more sense > anyway, because the top-level c

Re: [Qemu-devel] [PATCH v4 11/11] audio/rfc: remove PLIVE and PERIOD options

2012-03-14 Thread Gerd Hoffmann
On 03/13/12 16:47, malc wrote: > On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: > >> - period seems to be unused now > Period on the other hand is unused because i somehow missed the subtle > change of behavior in one of the patches made by, i think, Gerd. Uhm, which patch? I think that wasn't i

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/13/2012 12:42 PM, Amos Kong wrote: > Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > and check if available ioeventfd exists. If not, virtio-pci will > fallback to userspace, and don't use ioeventfd f

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 10:29 AM, Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: > Do you have any other comments abou

Re: [Qemu-devel] [PATCH (trivial)] no need to use bdrv_pread() in format guessing code when we can use bdrv_read() directly

2012-03-14 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 4:22 PM, Michael Tokarev wrote: > [Sorry - sent the wrong patch, should have been > BDRV_SECTOR_SIZE, not BDRV_BLOCK_SIZE] > > block.c:find_image_format() calls bdrv_pread() to read first 2048 > bytes from the device to guess its format.  This function can use > bdrv_re

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-14 Thread Igor Mitsyanko
On 03/12/2012 01:43 PM, Igor Mitsyanko wrote: On 02/21/2012 07:33 PM, Peter Maydell wrote: Short summary: * switch wp groups to bitfield rather than int array * convert sd.c to use memory_region_init_ram() to allocate the wp groups (being careful to use memory_region_set_dirty() when we touch t

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 01:14, schrieb Federico Simoncelli: > - Original Message - >> From: "Eric Blake" >> To: "Paolo Bonzini" >> Cc: kw...@redhat.com, fsimo...@redhat.com, qemu-devel@nongnu.org, >> stefa...@linux.vnet.ibm.com, lcapitul...@redhat.com >> Sent: Tuesday, March 13, 2012 9:48:10 PM >>

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 10:19, schrieb Paolo Bonzini: > Il 14/03/2012 10:17, Kevin Wolf ha scritto: >> If we want to do this, it needs to be the same patch, as we couple the >> transaction actions with top-level commands as long as there is no other >> way to discover the possible actions. And it probably m

Re: [Qemu-devel] [PATCH] ide: IDENTIFY word 86 bit 14 is reserved

2012-03-14 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 1:49 PM, Kevin Wolf wrote: > Reserved bits should be cleared to zero. > > Signed-off-by: Kevin Wolf > --- >  hw/ide/core.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 6f06d28..771811c 100644 > --- a/h

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

2012-03-14 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 1:17 PM, Gerd Hoffmann wrote: >  Hi, > >> If you want to do it as part of the QEMU codebase then a thread is >> probably the best way - it avoids the troubles of forking a >> multithreaded program and letting go of resources (guest memory, file >> descriptors) that aren't n

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

2012-03-14 Thread Gerd Hoffmann
Hi, > The most practical first step would be simply sending the ppm over a > socket from ppm_save(). The 'screendump' command today already blocks > so no new badness is being added. There would be no threads or fancy > image encoding. Adding scaling / compression support will add more overhe

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: > Do you have any other comm

Re: [Qemu-devel] [PATCH v3 9/9] net: support to include ipv6 address by brackets

2012-03-14 Thread Amos Kong
On 14/03/12 03:47, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:48:57AM +0800, Amos Kong wrote: That method of representing an IPv6 address with a port is I'm not sure what "that" is referencing. 2312::8274:5200 (5200 is a port) I assumed the previous patch but the representation seems

Re: [Qemu-devel] [PATCH 1/2] Isolation groups

2012-03-14 Thread David Gibson
On Tue, Mar 13, 2012 at 10:49:47AM -0600, Alex Williamson wrote: > On Wed, 2012-03-14 at 01:33 +1100, David Gibson wrote: > > On Mon, Mar 12, 2012 at 04:32:54PM -0600, Alex Williamson wrote: > > > Signed-off-by: Alex Williamson > > > --- > > > > > > drivers/base/Kconfig | 10 + > > > driv

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > On 03/13/2012 12:42 PM, Amos Kong wrote: >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), >> and check if available ioeventfd exists. If not, virtio-pc

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 9:51 AM, Gerd Hoffmann wrote: >  Hi, > >> The most practical first step would be simply sending the ppm over a >> socket from ppm_save().  The 'screendump' command today already blocks >> so no new badness is being added.  There would be no threads or fancy >> image encodin

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Orit Wasserman
On 03/14/2012 09:51 AM, Amos Kong wrote: > On 14/03/12 15:27, Paolo Bonzini wrote: >> > > Hi Paolo, > >> Il 14/03/2012 08:14, Orit Wasserman ha scritto: >>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) >>> { >>> closesocket(*fd); >>> return -socket_error(); >>> } >>>

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: > On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > > On 03/13/2012 12:42 PM, Amos Kong wrote: > >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > >> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > >> a

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 05:51 PM, Amit Shah Wrote: > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > On 03/12/2012 11:04 AM, Wen Congy

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 05:24 PM, Avi Kivity Wrote: > On 03/14/2012 10:29 AM, Wen Congyang wrote: >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > On 03/12/2012 11:04 AM, Wen Congyang wrot

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 11:53 AM, Wen Congyang wrote: > At 03/14/2012 05:24 PM, Avi Kivity Wrote: > > On 03/14/2012 10:29 AM, Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:04 PM, Wen Congyang wrote: > > > > This is sufficient. On the host, you can open /tmp/foo using a custom > > program or nc (nc -U /tmp/foo). On the guest, you can just open > > /dev/virtio-ports/port1 and read/write into it. > > I have two questions: > 1. does it OK to open this

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-14 Thread Avi Kivity
On 03/12/2012 11:43 AM, Igor Mitsyanko wrote: > On 02/21/2012 07:33 PM, Peter Maydell wrote: >> >> Short summary: >> * switch wp groups to bitfield rather than int array >> * convert sd.c to use memory_region_init_ram() to allocate the wp >> groups >> (being careful to use memory_region_set_dir

Re: [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start()

2012-03-14 Thread Amos Kong
On 14/03/12 02:35, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:48:03AM +0800, Amos Kong wrote: Introduce tcp_client_start() by moving original code in tcp_start_outgoing_migration(). Signed-off-by: Amos Kong --- net.c | 41 + qemu_socket.h

Re: [Qemu-devel] [PATCH v2 0/2] qxl trace events

2012-03-14 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 08:06:39PM +0200, Alon Levy wrote: > This is split from the previous screendump change patchset, hence the v2. > > This is by no way complete but I think it is a good start, and frankly I'd > like > to stop here right now. > > Changes from v1: > add qid prefix to all tra

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:07 PM, Avi Kivity Wrote: > On 03/14/2012 11:53 AM, Wen Congyang wrote: >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: >> On Mon,

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:26 PM, Wen Congyang wrote: > >> If so, is this channel visible to guest userspace? If the channle is > >> visible to guest > >> userspace, the program running in userspace may write the same message to > >> the channel. > >> > > > > Surely there's some kind of access control on

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > At 03/14/2012 05:24 PM, Avi Kivity Wrote: > > On 03/14/2012 10:29 AM, Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +0200, Av

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: >> > On 03/13/2012 12:42 PM, Amos Kong wrote: >> >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >> >> allocate ioevent

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: > At 03/14/2012 05:51 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 04:10:04PM +0530, Amit Shah wrote: > On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: > > At 03/14/2012 05:51 PM, Amit Shah Wrote: > > > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > >>> On 03/13/2012 11:18 AM,

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: > On 03/14/2012 12:26 PM, Wen Congyang wrote: > > >> If so, is this channel visible to guest userspace? If the channle is > > >> visible to guest > > >> userspace, the program running in userspace may write the same message > > >> to the

Re: [Qemu-devel] [PATCH 2/7] target-unicore32: Relicense to GPLv2+

2012-03-14 Thread Andreas Färber
Am 14.03.2012 08:53, schrieb Guan Xuetao: > On Wed, 2012-03-14 at 02:39 +0100, Andreas Färber wrote: >> Adopt the license text suggested by Guan Xue-tao for all files except >> helper.c, to which Anthony Liguori (IBM) contributed a g_malloc() call. >> >> Signed-off-by: Andreas Färber >> Signed-off

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: > On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: > >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > >> > On 03/13/2012 12:42 PM, Amos Kong wrote: > >> >> Boot up guest with 232 virtio-blk

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:46 PM, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: > > On 03/14/2012 12:26 PM, Wen Congyang wrote: > > > >> If so, is this channel visible to guest userspace? If the channle is > > > >> visible to guest > > > >> userspace, the program running

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:37 PM, Amit Shah Wrote: > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: >>

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: > At 03/14/2012 06:37 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: > >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivit

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:52 PM, Wen Congyang wrote: > > > >> If so, is this channel visible to guest userspace? If the channle is > >> visible to guest > >> userspace, the program running in userspace may write the same message to > >> the channel. > > > > Access control is via permissions. You can ha

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:52 PM, Gleb Natapov Wrote: > On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: >> At 03/14/2012 06:37 PM, Amit Shah Wrote: >>> On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: > On 03/14/2012 10:29 AM, Wen Congyang

Re: [Qemu-devel] [PATCH 3/7] target-unicore32: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Am 14.03.2012 08:56, schrieb Guan Xuetao: > On Wed, 2012-03-14 at 02:39 +0100, Andreas Färber wrote: >> Embed CPUUniCore32State into UniCore32CPU. >> >> Contributed under GPLv2+. >> >> Signed-off-by: Andreas Färber >> --- >> Makefile.target|1 + >> target-unicore32/cpu-qom.h | 7

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:52 PM, Avi Kivity Wrote: > On 03/14/2012 12:52 PM, Wen Congyang wrote: >>> If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may write the same message to the channel. >>> >>> Acce

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 03:21:14PM +0530, Amit Shah wrote: > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > > >>> On 03/12

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:52:07], Wen Congyang wrote: > At 03/14/2012 06:37 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: > >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote:

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:57:59PM +0800, Wen Congyang wrote: > At 03/14/2012 06:52 PM, Gleb Natapov Wrote: > > On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: > >> At 03/14/2012 06:37 PM, Amit Shah Wrote: > >>> On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > At 03/14/2012

Re: [Qemu-devel] [PATCH v2 1/2] qxl: switch qxl.c to trace-events

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 10:03:06AM +0100, Gerd Hoffmann wrote: > Hi, > > > dprint is still used for qxl_init_common one time prints. > > > > also switched parts of spice-display.c over, mainly all the callbacks to > > spice server. > > > > All qxl device trace events start with the qxl device

Re: [Qemu-devel] [PATCH v2 2/2] qxl/qxl_render.c: add trace events

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 10:04:23AM +0100, Gerd Hoffmann wrote: > > +# hw/qxl-render.c > > +qxl_blit_guest_primary_initialized(void) "" > > +qxl_blit(int32_t stride, int32_t left, int32_t right, int32_t top, int32_t > > bottom) "stride=%d [%d, %d, %d, %d]" > > +qxl_guest_primary_resized(int32_t wid

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > At 03/14/2012 06:52 PM, Avi Kivity Wrote: > > On 03/14/2012 12:52 PM, Wen Congyang wrote: > >>> > If so, is this channel visible to guest userspace? If the channle is > visible to guest > userspace, the program running

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:57 PM, Daniel P. Berrange Wrote: > On Wed, Mar 14, 2012 at 03:21:14PM +0530, Amit Shah wrote: >> On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: >>> At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 1

Re: [Qemu-devel] [PATCH v2 0/2] qxl trace events

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 10:20:13AM +, Stefan Hajnoczi wrote: > On Tue, Mar 13, 2012 at 08:06:39PM +0200, Alon Levy wrote: > > This is split from the previous screendump change patchset, hence the v2. > > > > This is by no way complete but I think it is a good start, and frankly I'd > > like >

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > At 03/14/2012 06:52 PM, Avi Kivity Wrote: > > On 03/14/2012 12:52 PM, Wen Congyang wrote: > >>> > If so, is this channel visible to guest userspace? If the channle is > visible to guest > userspace, the program running

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: > On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: >> At 03/14/2012 06:52 PM, Avi Kivity Wrote: >>> On 03/14/2012 12:52 PM, Wen Congyang wrote: > >> If so, is this channel visible to guest userspace? If the channle is >> vi

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:48 PM, Avi Kivity Wrote: > On 03/14/2012 12:46 PM, Gleb Natapov wrote: >> On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: >>> On 03/14/2012 12:26 PM, Wen Congyang wrote: >> If so, is this channel visible to guest userspace? If the channle is >> visible to guest

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:58 PM, Gleb Natapov Wrote: > On Wed, Mar 14, 2012 at 06:57:59PM +0800, Wen Congyang wrote: >> At 03/14/2012 06:52 PM, Gleb Natapov Wrote: >>> On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: > On (Wed) 14 Mar 2012 [17:5

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 07:06:50PM +0800, Wen Congyang wrote: > At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: > > On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > >> At 03/14/2012 06:52 PM, Avi Kivity Wrote: > >>> On 03/14/2012 12:52 PM, Wen Congyang wrote: > > > >> If so

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 07:06:50PM +0800, Wen Congyang wrote: > At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: > > On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > >> At 03/14/2012 06:52 PM, Avi Kivity Wrote: > >>> On 03/14/2012 12:52 PM, Wen Congyang wrote: > > > >> If so

Re: [Qemu-devel] [PATCH v4 11/11] audio/rfc: remove PLIVE and PERIOD options

2012-03-14 Thread Marc-André Lureau
Hi On Wed, Mar 14, 2012 at 10:22 AM, Gerd Hoffmann wrote: > On 03/13/12 16:47, malc wrote: >> On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: >> >>> - period seems to be unused now > >> Period on the other hand is unused because i somehow missed the subtle >> change of behavior in one of the patche

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 08:51, schrieb Amos Kong: > On 14/03/12 15:27, Paolo Bonzini wrote: >> > > Hi Paolo, > >> Il 14/03/2012 08:14, Orit Wasserman ha scritto: >>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) >>> { >>> closesocket(*fd); >>> return -socket_error(); >>> } >>> r

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 10:42, schrieb Stefan Hajnoczi: > On Tue, Mar 13, 2012 at 1:17 PM, Gerd Hoffmann wrote: >> Hi, >> >>> If you want to do it as part of the QEMU codebase then a thread is >>> probably the best way - it avoids the troubles of forking a >>> multithreaded program and letting go of resour

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity wrote: > On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: >> On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: >> > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: >> >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: >> >> > On 03/13/2012 12:42 PM,

Re: [Qemu-devel] [PATCH v4 11/11] audio/rfc: remove PLIVE and PERIOD options

2012-03-14 Thread Gerd Hoffmann
On 03/14/12 12:20, Marc-André Lureau wrote: > Hi > > On Wed, Mar 14, 2012 at 10:22 AM, Gerd Hoffmann wrote: >> On 03/13/12 16:47, malc wrote: >>> On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: >>> - period seems to be unused now >> >>> Period on the other hand is unused because i somehow miss

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 08:41, schrieb Paolo Bonzini: > Il 13/03/2012 20:13, Richard Laager ha scritto: >>> If you have a new kernel that supports SEEK_HOLE/SEEK_DATA, it can also >>> be done by skipping the zero write on known holes. >>> >>> This could even be done at the block layer level using bdrv_is_all

Re: [Qemu-devel] [PATCH v4 11/11] audio/rfc: remove PLIVE and PERIOD options

2012-03-14 Thread Marc-André Lureau
Hi > Guest interfacing is next to impossible I think, simply because real > hardware has no need for that and thus the interfaces simply don't > exist > in the hardware we are emulating. We can try to fix that with a > virtio > soundcard which has such interfaces, but it could be this simply > sh

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 13:01, Kevin Wolf ha scritto: > Am 14.03.2012 08:41, schrieb Paolo Bonzini: >> Il 13/03/2012 20:13, Richard Laager ha scritto: If you have a new kernel that supports SEEK_HOLE/SEEK_DATA, it can also be done by skipping the zero write on known holes. This could even

Re: [Qemu-devel] [PATCH V2 0/5] VMState cleanups

2012-03-14 Thread Peter Maydell
On 5 March 2012 08:30, Igor Mitsyanko wrote: > This patchset cleans up and optimizes vmstate implementation. > > v1-v2 > PATCH 4 now moves VMSTATE_UINTTL* macros to cpu-defs.h instead of to > vmstate.h. > put_target_ul/get_target_ul introduction is dropped. > PATCH2,PATCH3 commit messages are rew

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 08:37:13 + "Daniel P. Berrange" wrote: > > First, with this applied you will not know the size in advance. Also > > one of the approaches discussed is to allow passing in a file handle. > > That is a possible way to handle async screendumps too: just write to > > the pass

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 13:14, schrieb Paolo Bonzini: >> Paolo mentioned a use case as a fast way for guests to write zeros, but >> is it really faster than a normal write when we have to emulate it by a >> bdrv_write with a temporary buffer of zeros? > > No, of course not. > >> On the other hand we have

  1   2   3   4   >