Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > On 02/21/2012 01:19 AM, Alon Levy wrote: > > >>> (2) Async monitor command. Keeps interface and works nicely. A bunch > >>> of QAPI bits tickled into master meanwhile, so we could look at > >>> this again. Luiz? What is t

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 10:05:26AM -0500, Stefan Berger wrote: > On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: > >On Tue, Feb 21, 2012 at 06:19:26AM -0500, Stefan Berger wrote: > >>On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: > >>>On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wro

Re: [Qemu-devel] [PATCH 1/9] qapi: allow sharing enum implementation across visitors

2012-02-21 Thread Andreas Färber
Am 09.02.2012 15:31, schrieb Paolo Bonzini: > Most visitors will use the same code for enum parsing. Move it to > the core. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber However... > diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c > index ddef3ed..a4e088c 100644 >

Re: [Qemu-devel] [PATCH 5/9] qom: add generic string parsing/printing

2012-02-21 Thread Andreas Färber
Am 09.02.2012 15:31, schrieb Paolo Bonzini: > Add generic property accessors that take a string and parse it > appropriately for the property type. All the magic here is done > by the new string-based visitors. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/object.h | 24 ++

[Qemu-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
This is the second attempt to fix this issue, as a lesson from the last time it doesn't try to use an async monitor command. So with this patchset, in qxl mode, a screendump monitor command will complete before the file is written to disk. This is much better then a hang. To fix it does require

[Qemu-devel] [RFC v4 2/9] sdl: remove NULL check, g_malloc0 can't fail

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy --- ui/sdl.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 6f8091c..f6f711c 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -167,10 +167,6 @@ static PixelFormat sdl_to_qemu_pixelformat(SDL_PixelFormat *sdl_pf) static Displ

[Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl-render.c | 58 ++- hw/qxl.h|2 +- 2 files changed, 20 insertions(+), 40 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 133d093..4518a56 100644 --- a/hw/qxl-render.c +++ b/hw/q

[Qemu-devel] [RFC v4 7/9] qxl: introduce QXLCookie

2012-02-21 Thread Alon Levy
Will be used in the next patch. Signed-off-by: Alon Levy --- hw/qxl-render.c|2 +- hw/qxl.c | 58 --- hw/qxl.h |2 +- ui/spice-display.c | 22 +-- ui/spice-display.h | 14 5 files c

Re: [Qemu-devel] [Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 11:39:28PM +0200, Alon Levy wrote: > This is the second attempt to fix this issue, as a lesson from the last time > it doesn't try to use an async monitor command. So with this patchset, in qxl > mode, a screendump monitor command will complete before the file is written

[Qemu-devel] [RFC v4 1/9] console: don't call console_select unnecessarily

2012-02-21 Thread Alon Levy
From: Gerd Hoffman Tested-by: Alon Levy --- console.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index 135394f..cfcc2f7 100644 --- a/console.c +++ b/console.c @@ -181,12 +181,14 @@ void vga_hw_screen_dump(const char *filename) /* T

[Qemu-devel] [RFC v4 8/9] qxl: make qxl_render_update async

2012-02-21 Thread Alon Levy
RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same time the QXLRect are

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Rusty Russell
On Tue, 21 Feb 2012 17:45:08 +0100, Dongsu Park wrote: > Hi Rusty, > > On 13.02.2012 10:25, Rusty Russell wrote: > > On Fri, 10 Feb 2012 15:36:39 +0100, Dongsu Park > > wrote: > > > Hi, > > > > > > Recently I observed performance regression regarding virtio-blk, > > > especially different IO

[Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-21 Thread Alon Levy
This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has completed. With this patch it is called at the correct moment, but that means there is a race between the m

[Qemu-devel] [RFC v4 5/9] qxl: require spice >= 0.8.2

2012-02-21 Thread Alon Levy
drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1. Signed-off-by: Alon Levy --- configure |2 +- hw/qxl.c | 40 hw/qxl.h |4 ui/spice-display.c | 12 --

[Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-21 Thread Alon Levy
Using vga->screen_dump results in a number of calls to ppm_save, instead of a single one. Lacking time to test all the possible users of vga->screen_dump, avoid the redundant calls by doing the vga_hw_update+ ppm_save in qxl_hw_screen_dump. Signed-off-by: Alon Levy --- hw/qxl.c | 10 --

[Qemu-devel] [RFC v4 3/9] qxl: drop qxl_spice_update_area_async definition

2012-02-21 Thread Alon Levy
It was never used. Introduced in 5ff4e36c804157bd84af43c139f8cd3a59722db9 qxl: async io support using new spice api But not used even then. Signed-off-by: Alon Levy --- hw/qxl.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 766aa6d..6399

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/21/2012 02:58 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 10:05:26AM -0500, Stefan Berger wrote: On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: When the backend delivers the response it checks whether the interface is used in interrupt mode and raises the interrupt. IMO it

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: > On 02/21/2012 02:58 PM, Michael S. Tsirkin wrote: > >On Tue, Feb 21, 2012 at 10:05:26AM -0500, Stefan Berger wrote: > >>On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: > >>> > >>When the backend delivers the response it checks wheth

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/21/2012 06:08 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: At the moment there are two backends that need threading: the libtpms and passthrough backends. Both will require locking of datastructures that belong to the frontend. Only the nul

Re: [Qemu-devel] [PATCH 2/2] qom: add test tools

2012-02-21 Thread Andreas Färber
Am 20.02.2012 23:28, schrieb Michael Roth: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > Signed-off-by: Michael Roth Tested-by: Andreas Färber Thanks, these are really handy! :-) Since it's three independent scripts, it might make sense to split this into three commits? Andr

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread David Gibson
On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: > Am 21.02.2012 09:35, schrieb Paolo Bonzini: > > On 02/20/2012 11:50 AM, Alexander Graf wrote: > DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); > > -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); > >>

Re: [Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-21 Thread Benjamin Herrenschmidt
On Tue, 2012-02-21 at 15:56 +0100, Alexander Graf wrote: > On 02/21/2012 02:57 PM, Michael S. Tsirkin wrote: > > As we make upper bits in IO and prefetcheable memory > > registers writeable, we should declare support > > for 64 bit prefetcheable memory and 32 bit io > > in the bridge. > > > > This

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2012-02-21 Thread C Anthony Risinger
On Sat, Feb 18, 2012 at 11:38 AM, Aneesh Kumar K.V wrote: > On Thu, 16 Feb 2012 06:20:21 -0600, C Anthony Risinger > wrote: >> a) mapped FS security policy (xattrs) causes `ldconfig` to abort()? >> root or normal user ... >> >> somehow `ldconfig` gets a duplicate inode while constructing the >>

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 07:21:28PM -0500, Stefan Berger wrote: > On 02/21/2012 06:08 PM, Michael S. Tsirkin wrote: > >On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: > > > > > >>At the moment there are two backends that need threading: the > >>libtpms and passthrough backends. Both w

[Qemu-devel] [PATCH 0/2] Add "-uboot" option

2012-02-21 Thread Evgeny Voevodin
These patches add "-uboot" option to ARM boards. To let user load u-boot, board should initialize .uboot_start in arm_boot_info struct. Added utilisation of "-uboot" for exynos4 and integratorcp. Evgeny Voevodin (2): ARM: Add "-uboot" option. ARM: exynos, integratorcp: Specify U-Boot start ad

[Qemu-devel] [PATCH 1/2] ARM: Add "-uboot" option.

2012-02-21 Thread Evgeny Voevodin
With this option board can load U-Boot into address specified through arm_boot_info.uboot_start. Signed-off-by: Evgeny Voevodin --- hw/arm-misc.h |1 + hw/arm_boot.c | 51 ++- qemu-options.hx |8 sysemu.h|1 + vl.

[Qemu-devel] [PATCH 2/2] ARM: exynos, integratorcp: Specify U-Boot start address.

2012-02-21 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- hw/exynos4210.h |1 + hw/exynos4_boards.c |1 + hw/integratorcp.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210.h b/hw/exynos4210.h index e7522f8..9035a2a 100644 --- a/hw/exynos4210.h +++ b/hw/exynos4210.h @

[Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread 陳韋任
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge helper, but introduces dependency issue at the same time. While building target xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated at the moment. Explicitly declaring the dependency for the h

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread 陳韋任
On Tue, Feb 21, 2012 at 12:27:26PM +, Stefan Hajnoczi wrote: > On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 wrote: > >  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of > > bridge > > helper, but introduces dependency issue at the same time. While building > > target > > xxx-li

[Qemu-devel] [PATCH v11 7/9] hw/pc_piix: remove is_default for pc-0.15

2012-02-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- hw/pc_piix.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 17f8d5d..2fc4211 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -385,7 +385,6 @@ static QEMUMachine pc_machine_v0_15 = { .desc = "Standard

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread Paolo Bonzini
On 02/22/2012 03:07 AM, 陳韋任 wrote: > > -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF) > +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF) This is not declaring the dependency, it is declaring a target. The rule should be like qemu-bridge-helper.o: config-host.h Paol

Re: [Qemu-devel] [PATCH 1/9] qapi: allow sharing enum implementation across visitors

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 09:31 PM, Andreas Färber wrote: >> > +void output_type_enum(Visitor *v, int *obj, const char *strings[], >> > + const char *kind, const char *name, >> > + Error **errp) >> > +{ >> > +int i = 0; >> > +int value = *obj; >> > +char *e

Re: [Qemu-devel] [PATCH 5/9] qom: add generic string parsing/printing

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 09:47 PM, Andreas Färber wrote: >> > +void object_property_parse(Object *obj, const char *string, >> > + const char *name, Error **errp) >> > +{ >> > +StringInputVisitor *mi; > Curious: where does mi/mo come from? Cut-and-paste from the version using QMP

[Qemu-devel] [Bug 938431] [NEW] Reproducible crash in slirp_remque (qemu 1.0.1)

2012-02-21 Thread Craig Ringer
Public bug reported: Heya I've been testing some automated data conversion scripts with qemu 1.0.1. They work fine with qemu-kvm 0.15.1, but on qemu 1.0.1 (from the website, built from source using gcc 4.6.1, i686 host), when the script runs qemu I see qemu crash in slirp_remque a few seconds aft

[Qemu-devel] [PATCH v11 1/9] blockdev: allow read-only pflash devices

2012-02-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7a6613a..2c132a3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -595,7 +595,8 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) /*

[Qemu-devel] Help me about the FDC

2012-02-21 Thread Zhi Hui Li
I am read the code of fdc.c , I feel it was difficult to understand. Can somebody give me some help: thank you very much! 1: explain the difference between : type_register_static(&isa_fdc_info); type_register_static(&sysbus_fdc_info); type_register_static(&sun4m_fdc_info); 2: e

[Qemu-devel] [PATCH v11 3/9] vl: make find_default_machine externally visible

2012-02-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- hw/boards.h |1 + vl.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index f6d3784..667177d 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -32,6 +32,7 @@ typedef struct QEMUMachine { } QEMUMachine;

[Qemu-devel] [PATCH v11 9/9] pc_piix/pc_sysfw: enable flash by default

2012-02-21 Thread Jordan Justen
Now, the pc-sysfw:rom_only property will default to false which enables flash by default. All pc types below pc-1.1 set rom_only to true. This prevents flash from being enabled on these pc machine types. For pc-1.1 rom_only will use the default (false), which will allow flash to be used for pc-1.

<    1   2