Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-21 Thread Gerd Hoffmann
Hi, >> This seems to not support 64bit prefetchable memory windows, at least >> linux doesn't think it does, lspci looks like this: >> >> 00:10.0 PCI bridge: Red Hat, Inc. Device 0001 (prog-if 00 [Normal decode]) [ ... ] >> Memory behind bridge: f600-f60f >> Prefetchable

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Alon Levy
On Mon, Feb 20, 2012 at 02:29:11PM -0700, Eric Blake wrote: > On 02/20/2012 04:32 AM, Gerd Hoffmann wrote: > > Hmm, that is pretty lame. There are users like autotest which expect > > the screen dump being there when the monitor command is finished, that > > change will break them. > > Libvirt is

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 08:57:54AM +0100, Gerd Hoffmann wrote: > Hi, > > > TBH I'm having problems without doing it with my own Allocator. In > > particular calling ppm_save from spice_server thread seems to be a > > problem. > > Grabbed the qemu mutex? Didn't we remove qemu mutex grabbing fro

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread Paolo Bonzini
On 02/20/2012 11:50 AM, Alexander Graf wrote: >> > DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >> > >> > -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); >> > +trace_dma_bdrv_io(dbs, bs, sector_num, dir); > Was the trace wrong before or is it now? I don't see its defin

[Qemu-devel] BlockDriverState stack and BlockListeners (was: [RFC] Replication agent design)

2012-02-21 Thread Kevin Wolf
Am 20.02.2012 15:32, schrieb Paolo Bonzini: > On 02/19/2012 02:40 PM, Ori Mamluk wrote: >> >> I think it might be better to go back to my original less generic design. >> We can regard it as a 'plugin' for a specific application - in this >> case, replication. >> I can add a plugin interface in the

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 09:35, schrieb Paolo Bonzini: > On 02/20/2012 11:50 AM, Alexander Graf wrote: DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); +trace_dma_bdrv_io(dbs, bs, sector_num, dir); >> Was the trace wr

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-21 Thread Peter Crosthwaite
On Tue, Feb 21, 2012 at 5:56 AM, Peter Maydell wrote: > On 20 February 2012 19:51, Andreas Färber wrote: >> Am 20.02.2012 20:43, schrieb Peter Maydell: >>> I don't particularly care how we QOMify arm_boot (it's not exactly at >>> the top of my priority list demanding attention), I do care that (a

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 10:03 AM, Kevin Wolf wrote: > So let's check which features could make use of it: > > - Copy on read > - I/O throttling > - blkmirror for precopy storage migration > - replication agent > - Old style block migratiom More precisely, dirty bitmap handling. > (btw, we should deprecate

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-21 Thread Gerd Hoffmann
Hi, > Right now qxl_render_update checks if the displaysurface buffer is not > shared, meaning it was allocated by qemu, and in this case it replaces > it with the flipped buffer. I think we should first reqire spice-server 0.8.latest, so update_area_complete is available unconditionally. T

Re: [Qemu-devel] [PATCH 4/4] arm: add device tree support

2012-02-21 Thread Peter Crosthwaite
On Tue, Feb 21, 2012 at 5:47 AM, Peter Maydell wrote: > Ping re patch 3 and 4 here -- I know there was some discussion under the > thread on Peter Crosthwaite's 'qomify arm_boot' patch series, but it's a > bit hard to disentangle from the comments on that patch series. Conclusion reached over the

Re: [Qemu-devel] [PATCH V7 11/11] xen passthrough: clean up MSI-X table handling

2012-02-21 Thread Jan Beulich
>>> On 17.02.12 at 18:08, Anthony PERARD wrote: Wouldn't thus much better be merged into the prior patch(es)? After all you're not trying to reconstruct the Xen-side history of this code anyway. Jan > From: Shan Haitao > > This patch does cleaning up of QEMU MSI handling. The fixes are: > 1.

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 10:15, schrieb Paolo Bonzini: > On 02/21/2012 10:03 AM, Kevin Wolf wrote: >> So let's check which features could make use of it: >> >> - Copy on read >> - I/O throttling >> - blkmirror for precopy storage migration >> - replication agent >> - Old style block migratiom > > More precis

Re: [Qemu-devel] [PATCH v5 07/12] suspend: add system_wakeup monitor command

2012-02-21 Thread Gerd Hoffmann
Hi, >> +# @system_wakeup: >> +# >> +# Wakeup guest from suspend >> +# >> +# Since: 1.1 >> +# >> +# Returns: nothing. > > Would be nice to note that this command does nothing if the guest is already > suspended (btw, does is_suspend account for guest initiated suspends too?). s/suspended/runn

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 10:20:49AM +0100, Gerd Hoffmann wrote: > Hi, > > > Right now qxl_render_update checks if the displaysurface buffer is not > > shared, meaning it was allocated by qemu, and in this case it replaces > > it with the flipped buffer. > > I think we should first reqire spic

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-21 Thread Gerd Hoffmann
On 02/17/12 18:33, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 11:28:21 +0100 > Gerd Hoffmann wrote: > >> Send qmp events on suspend and wakeup so libvirt >> has a chance to track the vm state. [ added libvirt to Cc:, leaving full context. this is about qmp events when the guest enters/leaves

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 10:49 AM, Kevin Wolf wrote: > Am 21.02.2012 10:15, schrieb Paolo Bonzini: >> On 02/21/2012 10:03 AM, Kevin Wolf wrote: >>> - Old style block migratiom >> >> More precisely, dirty bitmap handling. > > Yes, but is it used anywhere else? No, just nitpicking. >>> (btw, we should deprec

Re: [Qemu-devel] [PATCH V7 08/11] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-02-21 Thread Stefano Stabellini
On Mon, 20 Feb 2012, Michael S. Tsirkin wrote: > On Fri, Feb 17, 2012 at 05:08:42PM +, Anthony PERARD wrote: > > From: Allen Kay > > > > A more complete history can be found here: > > git://xenbits.xensource.com/qemu-xen-unstable.git > > > > Signed-off-by: Allen Kay > > Signed-off-by: Guy Zan

[Qemu-devel] [PATCH] qom: Document ways to retrieve child object added by object_property_add_child()

2012-02-21 Thread alexander_barabash
From: Alexander Barabash object_property_add_child() creates a property whose values as a string is the child object's canonical path. Signed-off-by: Alexander Barabash --- include/qemu/object.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b

Re: [Qemu-devel] [PATCH] qom: Document ways to retrieve child object added by object_property_add_child()

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 11:14 AM, alexander_barab...@mentor.com wrote: > From: Alexander Barabash > > object_property_add_child() creates a property whose values as a string is > the child object's canonical path. > > Signed-off-by: Alexander Barabash > --- > include/qemu/object.h |4 > 1 files

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-02-21 Thread Stefano Stabellini
On Mon, 13 Feb 2012, Stefano Stabellini wrote: > On Tue, 31 Jan 2012, Stefano Stabellini wrote: > > On Wed, 25 Jan 2012, Stefano Stabellini wrote: > > > Hi all, > > > this is the fourth version of the Xen save/restore patch series. > > > We have been discussing this issue for quite a while on #qemu

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-21 Thread Peter Maydell
On 21 February 2012 09:15, Peter Crosthwaite wrote: > On Tue, Feb 21, 2012 at 5:56 AM, Peter Maydell > wrote: >> On 20 February 2012 19:51, Andreas Färber wrote: >>> Am 20.02.2012 20:43, schrieb Peter Maydell: I don't particularly care how we QOMify arm_boot (it's not exactly at the t

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Ori Mamluk
On 21/02/2012 11:49, Kevin Wolf wrote: Am 21.02.2012 10:15, schrieb Paolo Bonzini: So maybe we just need to extend the current BlockDriverState stack to distinguish "normal" and "always on top" BlockDrivers, where the latter would roughly correspond to BlockListeners? I would prefer having sepa

Re: [Qemu-devel] [PATCH][v13] megasas: LSI Megaraid SAS HBA emulation

2012-02-21 Thread Hannes Reinecke
On 02/21/2012 12:04 AM, Michael S. Tsirkin wrote: > On Mon, Feb 20, 2012 at 04:17:05PM +0100, Alexander Graf wrote: >> >> On 20.02.2012, at 16:16, Hannes Reinecke wrote: >> >>> On 02/20/2012 04:13 PM, Alexander Graf wrote: On 20.02.2012, at 16:11, Hannes Reinecke wrote: > This pa

Re: [Qemu-devel] [PATCH][v13] megasas: LSI Megaraid SAS HBA emulation

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 11:27:15AM +0100, Hannes Reinecke wrote: > On 02/21/2012 12:04 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 20, 2012 at 04:17:05PM +0100, Alexander Graf wrote: > >> > >> On 20.02.2012, at 16:16, Hannes Reinecke wrote: > >> > >>> On 02/20/2012 04:13 PM, Alexander Graf wrote:

[Qemu-devel] fix ELF loading for 0-length sections

2012-02-21 Thread Damian, Alexandru
Hi, I got a problem with QEMU refusing to load an ELF binary with 0-length sections, while the kernel has no issue doing this. This patch adds a check that has been in kernel since 2008 at least. Cheers, Alex commit a42e5231c1be5f09caeb6c73e34933cd7efa7023 Author: Alexandru DAM

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 11:09, schrieb Paolo Bonzini: >>> 2) BlockListener would be entirely an implementation detail, used in the >>> implementation of other commands. >> >> Depending on what you mean by command (presumably QMP commands?), > > QMP commands, command-line (-drive), whatever. > >> And on the

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 20.02.2012 21:45, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 08:59:38PM +0100, Peter Lieven wrote: On 20.02.2012 20:04, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 08:40:08PM +0200, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 07:17:55PM +0100, Peter Lieven wrote: Hi, I came a across an i

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Gleb Natapov
On Tue, Feb 21, 2012 at 11:50:47AM +0100, Peter Lieven wrote: > >I hope it will make Windows use TSC instead, but you can't be sure > >about anything with Windows :( > Whatever it does now it eates more CPU has almost equal > number of exits and throughput is about the same (15MB/s). > If pmtimer i

[Qemu-devel] [PATCH 6/9] spice: support ipv6 channel address in monitor events and in spice info

2012-02-21 Thread Gerd Hoffmann
From: Yonit Halperin RHBZ #788444 CC: Gerd Hoffmann Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 37 - 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 05cb745..1

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Gleb Natapov
On Tue, Feb 21, 2012 at 11:59:23AM +0100, Peter Lieven wrote: > On 21.02.2012 11:56, Gleb Natapov wrote: > >On Tue, Feb 21, 2012 at 11:50:47AM +0100, Peter Lieven wrote: > >>>I hope it will make Windows use TSC instead, but you can't be sure > >>>about anything with Windows :( > >>Whatever it does

Re: [Qemu-devel] fix ELF loading for 0-length sections

2012-02-21 Thread Peter Maydell
On 21 February 2012 10:42, Damian, Alexandru wrote: > Hi, > > I got a problem with QEMU refusing to load an ELF binary with 0-length > sections, > while the kernel has no issue doing this. > > This patch adds a check that has been in kernel since 2008 at least. CC'ing Riku (linux-user maintainer)

Re: [Qemu-devel] [PATCH][v13] megasas: LSI Megaraid SAS HBA emulation

2012-02-21 Thread Hannes Reinecke
On 02/21/2012 11:34 AM, Michael S. Tsirkin wrote: > On Tue, Feb 21, 2012 at 11:27:15AM +0100, Hannes Reinecke wrote: >> On 02/21/2012 12:04 AM, Michael S. Tsirkin wrote: >>> On Mon, Feb 20, 2012 at 04:17:05PM +0100, Alexander Graf wrote: On 20.02.2012, at 16:16, Hannes Reinecke wrote: >>>

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 12:00, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:59:23AM +0100, Peter Lieven wrote: On 21.02.2012 11:56, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:50:47AM +0100, Peter Lieven wrote: I hope it will make Windows use TSC instead, but you can't be sure about anything with W

[Qemu-devel] [PATCH 8/9] qxl: move ram size init to new function

2012-02-21 Thread Gerd Hoffmann
Factor memory bar sizing bits out to a separate function. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 41 ++--- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 4de4b8d..38bb90e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wrote: On 02/20/2012 05:02 PM, Michael S. Tsirkin wrote: On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wrote: +/* + * Send a TPM request. + * Call this with the state_lock held s

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 11:56, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:50:47AM +0100, Peter Lieven wrote: I hope it will make Windows use TSC instead, but you can't be sure about anything with Windows :( Whatever it does now it eates more CPU has almost equal number of exits and throughput is abou

[Qemu-devel] [PATCH 2/9] qxl: don't render stuff when the vm is stopped.

2012-02-21 Thread Gerd Hoffmann
This patch fixes the local qxl renderer to not kick spice-server in case the vm is stopped. First it is largely pointless because we ask spice-server to process all not-yet processed commands when the vm is stopped, so there isn't much do do anyway. Second we avoid triggering an assert in spice-s

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 11:51 AM, Kevin Wolf wrote: > And even protocols and protocols don't. Compare file to blkdebug, for > example. In fact, blkdebug and blkverify are already very close to what > BlockListeners would be. Yes, and I think considering blkdebug and blkverify help in the design. They provid

[Qemu-devel] [PATCH 7/9] qxl: drop vram bar minimum size

2012-02-21 Thread Gerd Hoffmann
There is no reason to require a minimum size of 16 MB for the vram. Lower the limit to 4096 (one page). Make it disapper completely would break guests. --- hw/qxl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5c6b556..4de4b8d 100644 --- a/

[Qemu-devel] [PATCH 5/9] Add SPICE support to add_client monitor command

2012-02-21 Thread Gerd Hoffmann
From: Daniel P. Berrange With the acceptance of some new APIs to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use TLS or plain connections, the command also gains a new 'tls' parameter to specify whether

[Qemu-devel] [PATCH 1/9] qxl: fix warnings on 32bit

2012-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/qxl.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index ac69125..f421a45 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -625,7 +625,7 @@ static void interface_release_resource(QXLInstance *sin, if (ext.grou

[Qemu-devel] [PULL] spice patch queue

2012-02-21 Thread Gerd Hoffmann
Hi, Here is the spice patch queue with a collection of little improvements and bugfixes. No major stuff. See individual patches for details. please pull, Gerd The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Gleb Natapov
On Tue, Feb 21, 2012 at 12:16:16PM +0100, Peter Lieven wrote: > On 21.02.2012 12:00, Gleb Natapov wrote: > >On Tue, Feb 21, 2012 at 11:59:23AM +0100, Peter Lieven wrote: > >>On 21.02.2012 11:56, Gleb Natapov wrote: > >>>On Tue, Feb 21, 2012 at 11:50:47AM +0100, Peter Lieven wrote: > >I hope it

[Qemu-devel] [PATCH 4/9] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-21 Thread Gerd Hoffmann
From: Yonit Halperin RHBZ #790083 Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b544f31..5c6b556 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1471,7 +1471,7 @@ static void

[Qemu-devel] [PATCH 9/9] qxl: add user-friendly bar size properties

2012-02-21 Thread Gerd Hoffmann
Add two properties to specify bar sizes in megabytes instead of bytes, which is alot more user-friendly. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |8 hw/qxl.h |4 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 38bb90e..87ad49a 100

[Qemu-devel] [PATCH 3/9] qxl: set only off-screen surfaces dirty instead of the whole vram

2012-02-21 Thread Gerd Hoffmann
From: Yonit Halperin We used to assure the guest surfaces were saved before migration by setting the whole vram dirty. This patch sets dirty only the areas that are actually used in the vram. Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 53 ++

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 12:46, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 12:16:16PM +0100, Peter Lieven wrote: On 21.02.2012 12:00, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:59:23AM +0100, Peter Lieven wrote: On 21.02.2012 11:56, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:50:47AM +0100, Pete

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 06:19:26AM -0500, Stefan Berger wrote: > On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: > >On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wrote: > >>On 02/20/2012 05:02 PM, Michael S. Tsirkin wrote: > >>>On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wro

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 11:36 AM, Paolo Bonzini wrote: > On 02/21/2012 11:51 AM, Kevin Wolf wrote: >> And even protocols and protocols don't. Compare file to blkdebug, for >> example. In fact, blkdebug and blkverify are already very close to what >> BlockListeners would be. > > Yes, and I think co

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 wrote: >  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge > helper, but introduces dependency issue at the same time. While building > target > xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not > generated > a

Re: [Qemu-devel] [PATCH 1/2] arm: clean up GIC constants.

2012-02-21 Thread Peter Maydell
On 21 February 2012 02:33, Rusty Russell wrote: > Interrupts numbers 0-31 are private to the processor interface, 32-1019 are > general interrups.  Add GIC_INTERNAL and substitute everywhere. > @@ -73,8 +75,9 @@ typedef struct gic_irq_state >  #define GIC_SET_TRIGGER(irq) s->irq_state[irq].trigger

Re: [Qemu-devel] [PATCH 2/2] arm: make sure that number of irqs can be represented in GICD_TYPER.

2012-02-21 Thread Peter Maydell
On 21 February 2012 02:33, Rusty Russell wrote: > We currently assume that the number of interrupts (ITLinesNumber in > the architecture reference manual) is divisible by 32, since we > present it to the guest when it reads GICD_TYPER (in gic_dist_readb()) > as (N / 32) - 1. > > Signed-off-by: Rus

Re: [Qemu-devel] [PATCH 2/3] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-21 Thread Jeff Cody
On 02/20/2012 12:41 PM, Eric Blake wrote: On 02/20/2012 10:31 AM, Jeff Cody wrote: This is a QAPI/QMP only command to take a snapshot of a group of devices. This is simlar to the blockdev-snapshot-sync command, except s/simlar/similar/ Oops - fixed for v2. blockdev-group-snapshot-sync ac

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 01:22 PM, Stefan Hajnoczi wrote: > This is a good discussion because BlockDriverState has become bloated > and complex. A lot of fields only apply to sub-cases and we should > really split this struct. > > Fields like "backing_file" *should* be in generic code, not duplicated > in e

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-21 Thread Paul Brook
> > +static inline int64_t is_between(int64_t x, int64_t a, int64_t b) > > +{ > > +if (a < b) { > > +return x > a && x <= b; > > +} > > +return x < a && x >= b; > > +} > > This looks slightly odd -- should the boundary condition for whether > a value equal to the max/min really

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 12:36, schrieb Paolo Bonzini: > And here: > > .== BlockSource ==. > | MirrorListener | .== BlockSource ==. > | QCOW2View --+--> QCOW2Format -> | FileProtocol| > '='| '=' > |

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 02:10 PM, Kevin Wolf wrote: >> > I think it depends, but both possibilities should be doable in this model. > > Meh. :-) Agreed. :) > Maybe we need to introduce something outside of the whole stack, an > entity that is referred to by the device (as in IDE, virtio-blk, ...) > and th

[Qemu-devel] [PATCH] pci: add accessors to get/set registers by mask

2012-02-21 Thread Michael S. Tsirkin
pci_regs.h specifies many registers by mask + shifted register values. There's always some duplication when using such: for example to override device type, we would need: pci_word_test_and_clear_mask(cap + PCI_EXP_FLAGS, PCI_EXP_FLAGS_TYPE); pci_word_test_and_set_mask(cap + PCI_EXP_FLAGS,

[Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-21 Thread Michael S. Tsirkin
As we make upper bits in IO and prefetcheable memory registers writeable, we should declare support for 64 bit prefetcheable memory and 32 bit io in the bridge. This changes the default for apb, dec, but I'm guessing they got the defaults wrong by accident. Alternatively, we could let bridges decl

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Vadim Rozenfeld
- Original Message - From: "Peter Lieven" To: "Gleb Natapov" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, vroze...@redhat.com Sent: Tuesday, February 21, 2012 2:05:25 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists On 21.02.2012 12:46, Gleb Natapov wrote: >

Re: [Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-21 Thread Kevin Wolf
Am 20.02.2012 11:13, schrieb Juan Quintela: > > Hi > > Please send in any agenda items you are interested in covering. What's the status with qtest? (Though probably a one-line email would already answer this) Kevin

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 14:56, Vadim Rozenfeld wrote: - Original Message - From: "Peter Lieven" To: "Gleb Natapov" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, vroze...@redhat.com Sent: Tuesday, February 21, 2012 2:05:25 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists

Re: [Qemu-devel] [PATCH 3/3] qapi: Introduce blockdev-query-group-snapshot-failure

2012-02-21 Thread Jeff Cody
On 02/20/2012 12:48 PM, Eric Blake wrote: > On 02/20/2012 10:31 AM, Jeff Cody wrote: >> In the case of a failure in a group snapshot, it is possible for >> multiple file image failures to occur - for instance, failure of >> an original snapshot, and then failure of one or more of the >> attempted r

Re: [Qemu-devel] [PATCH] block: remove unused fields in BlockDriverState

2012-02-21 Thread Kevin Wolf
Am 20.02.2012 17:58, schrieb Paolo Bonzini: > sync_aiocb is unused since commit ce1a14d (Dynamically allocate AIO > Completion Blocks., 2006-08-07). > > private is unused since commit 56a1493 (drive cleanup fixes., 2009-09-25). > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branc

[Qemu-devel] [PATCH] Makefile: Add dependency to fix linux-user-only build

2012-02-21 Thread Peter Maydell
Make qemu-bridge-helper explicitly depend on $(GENERATED_HEADERS) so that it doesn't fail to build when we configured for linux-user targets only. (Build breakage introduced in commit 7b93fad.) Signed-off-by: Peter Maydell --- I suspect we could handle generated headers better in our makefile tha

Re: [Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-21 Thread Juan Quintela
Kevin Wolf wrote: > Am 20.02.2012 11:13, schrieb Juan Quintela: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > What's the status with qtest? (Though probably a one-line email would > already answer this) As this is the only topic for today call, and you agre

[Qemu-devel] 2 build issues for qemu v1.0.1

2012-02-21 Thread Virtbie
Hello I am trying to build from source the qemu v1.0.1 (from git) on a Ubuntu mixed system (part is oneiric 11.10, part is precise 12.04) Here are two issues: During build of: hw/9pfs/virtio-9p-handle.c it gave errors saying it couldnt find definition of "AT_EMPTY_PATH". So I added it at the

Re: [Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-21 Thread Alexander Graf
On 02/21/2012 02:57 PM, Michael S. Tsirkin wrote: As we make upper bits in IO and prefetcheable memory registers writeable, we should declare support for 64 bit prefetcheable memory and 32 bit io in the bridge. This changes the default for apb, dec, but I'm guessing they got the defaults wrong b

Re: [Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-21 Thread Anthony Liguori
On 02/21/2012 08:06 AM, Kevin Wolf wrote: Am 20.02.2012 11:13, schrieb Juan Quintela: Hi Please send in any agenda items you are interested in covering. What's the status with qtest? (Though probably a one-line email would already answer this) I still need to go through Paolo's patches. I

[Qemu-devel] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread 陳韋任
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge helper, but introduces dependency issue at the same time. While building target xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated at the moment. Building recurse-all target first fixes the p

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 06:19:26AM -0500, Stefan Berger wrote: On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wrote: On 02/20/2012 05:02 PM, Michael S. Tsirkin wrote: On Wed, Dec 14, 2

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-02-21 Thread Peter Maydell
On 9 February 2012 22:23, Peter Maydell wrote: > Ping re the VMState and variable sized arrays issue. I don't > see any consensus in this discussion for a different approach, > so should we just commit Mitsyanko's patchset? >From an IRC conversation I just had with Anthony and Juan: ===begin== 14

[Qemu-devel] [PATCH] block: drop aio_multiwrite in BlockDriver

2012-02-21 Thread Paolo Bonzini
These were never used. Signed-off-by: Paolo Bonzini --- block.c | 23 ++--- block_int.h |6 -- 2 files changed, 3 insertions(+), 26 deletions(-) diff --git a/block.c b/block.c index ae297bb..b395f7b 100644 --- a/block.c +++ b/block.c @@ -2767,7 +2793,6 @@ typedef s

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > This is a good discussion because BlockDriverState has become bloated > and complex. A lot of fields only apply to sub-cases and we should > really split this struct. Yup. We've had discussions where couldn't even agree whether a specific block driver is a format or a

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 21.02.2012 12:36, schrieb Paolo Bonzini: >> And here: >> >> .== BlockSource ==. >> | MirrorListener | .== BlockSource ==. >> | QCOW2View --+--> QCOW2Format -> | FileProtocol| >> '='| '=' >

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Dongsu Park
Hi Stefan, see below. On 13.02.2012 11:57, Stefan Hajnoczi wrote: > On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park > wrote: > >  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0. > > > >  - Sequential read (Running inside guest) > >   # fio -name iops -rw=read -size=1G -iodepth 1 \ > >

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 16:56, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 21.02.2012 12:36, schrieb Paolo Bonzini: >>> And here: >>> >>> .== BlockSource ==. >>> | MirrorListener | .== BlockSource ==. >>> | QCOW2View --+--> QCOW2Format -> | FileProtocol| >>> '

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-21 Thread Markus Armbruster
Anthony Liguori writes: > On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: >> On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolf wrote: >>> Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. >> >> I rec

[Qemu-devel] Mascot Contest Results

2012-02-21 Thread Anthony Liguori
First, I'd like to thank everyone for participating! We received a large number of entries and lot of great submissions. But there is pretty clearly a favorite and with 12 votes, I'm pleased to announce that Benoit Canet's "Kew the Angry Emu" logo is the winner! I'm attaching the SVG to this

Re: [Qemu-devel] [PATCH V7 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2012-02-21 Thread Anthony PERARD
On Mon, Feb 20, 2012 at 20:30, Michael S. Tsirkin wrote: > On Fri, Feb 17, 2012 at 05:08:37PM +, Anthony PERARD wrote: >> Signed-off-by: Anthony PERARD >> --- >>  hw/pci_regs.h |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/hw/pci_regs.h b/hw/pci_regs.h >> in

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock

2012-02-21 Thread Peter Maydell
On 13 January 2012 16:21, Alexander Graf wrote: > On 13.01.2012, at 17:16, Peter Maydell wrote: >> On 13 January 2012 15:46, Alexander Graf wrote: >>> This patch forces unlocking of that lock in the segv handler. I'm not sure >>> this is the right approach though. Maybe we should rather make sure

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Eric Blake
On 02/21/2012 01:19 AM, Alon Levy wrote: >>> (2) Async monitor command. Keeps interface and works nicely. A bunch >>> of QAPI bits tickled into master meanwhile, so we could look at >>> this again. Luiz? What is the status here? >>> >>> (3) Something like this patch + additionally

Re: [Qemu-devel] [PATCH V7 11/11] xen passthrough: clean up MSI-X table handling

2012-02-21 Thread Anthony PERARD
On Tue, Feb 21, 2012 at 09:34, Jan Beulich wrote: > Wouldn't thus much better be merged into the prior patch(es)? After > all you're not trying to reconstruct the Xen-side history of this code > anyway. Yes, that probably better than having an extra patch. There is a "link" to the history, anyway

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock

2012-02-21 Thread Alexander Graf
On 02/21/2012 05:11 PM, Peter Maydell wrote: On 13 January 2012 16:21, Alexander Graf wrote: On 13.01.2012, at 17:16, Peter Maydell wrote: On 13 January 2012 15:46, Alexander Graf wrote: This patch forces unlocking of that lock in the segv handler. I'm not sure this is the right approach tho

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 21.02.2012 16:56, schrieb Markus Armbruster: >> Kevin Wolf writes: [...] >>> Maybe we need to introduce something outside of the whole stack, an >>> entity that is referred to by the device (as in IDE, virtio-blk, ...) >>> and that refers to a stack of top-level listeners

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock

2012-02-21 Thread Peter Maydell
On 21 February 2012 16:19, Alexander Graf wrote: > On 02/21/2012 05:11 PM, Peter Maydell wrote: >> For a proper fix we probably need to handle set/getrlimit for >> RLIMIT_AS specially so we can apply them ourselves to the guest's >> mmap/brk usage and don't get spurious allocation failures of >> o

[Qemu-devel] PCI: Add PCI_EXP_TYPE_PCIE_BRIDGE value

2012-02-21 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- include/linux/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/pci_regs.h b/include/linux/pci_regs.h index e41a10f..4b608f5 100644 --- a/include/linux/pci_regs.h +++ b/include/linux/pci_regs.h @@ -391,6 +391,7 @@

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2012-02-21 Thread Peter Lieven
On 16.10.2011 10:54, TeLeMan wrote: On Thu, Oct 13, 2011 at 18:48, Gerd Hoffmann wrote: On 10/13/11 04:09, TeLeMan wrote: On Wed, Oct 12, 2011 at 19:30, Gerd Hoffmannwrote: qemu uses the ps/2 mouse by default. The usb tablet (or mouse) is activated as soon as qemu sees some guest activit

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-21 Thread Eric Blake
On 02/21/2012 03:00 AM, Gerd Hoffmann wrote: > [ added libvirt to Cc:, leaving full context. > this is about qmp events when the guest enters/leaves s3 ]. > >>> @@ -1436,12 +1437,26 @@ void qemu_register_suspend_notifier(Notifier >>> *notifier) >>> >>> void qemu_system_wakeup_request(Wakeup

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 17:19, schrieb Markus Armbruster: Oh, and just to open another can of worms: We should probably design in the notion of media (which can be ejected etc.) and drives (which always stay there). We don't have a clean separation today. >>> >>> The "closed BDS means no media

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Dongsu Park
Hi Rusty, On 13.02.2012 10:25, Rusty Russell wrote: > On Fri, 10 Feb 2012 15:36:39 +0100, Dongsu Park > wrote: > > Hi, > > > > Recently I observed performance regression regarding virtio-blk, > > especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0. > > So I want to share the benc

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Vadim Rozenfeld
- Original Message - From: "Peter Lieven" To: "Vadim Rozenfeld" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, "Gleb Natapov" Sent: Tuesday, February 21, 2012 4:10:22 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists On 21.02.2012 14:56, Vadim Rozenfeld wrote

[Qemu-devel] [PULL v2 0/9] qdev deconstruction, command-line episode

2012-02-21 Thread Paolo Bonzini
Anthony, I'm sending a pull request since you informally said on IRC that you're okay with the patches. The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) are available in the git repos

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 1:10 PM, Kevin Wolf wrote: > Am 21.02.2012 12:36, schrieb Paolo Bonzini: > Oh, and just to open another can of worms: We should probably design in > the notion of media (which can be ejected etc.) and drives (which always > stay there). We don't have a clean separation toda

Re: [Qemu-devel] Mascot Contest Results

2012-02-21 Thread Mulyadi Santosa
On Tue, Feb 21, 2012 at 23:03, Anthony Liguori wrote: > But there is pretty clearly a favorite and with 12 votes, I'm pleased to > announce that Benoit Canet's "Kew the Angry Emu" logo is the winner! I am late to vote, but after seeing the SVG, I say it's a good logo. Kudos for Benoit! -- regar

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 3:57 PM, Dongsu Park wrote: > On 13.02.2012 11:57, Stefan Hajnoczi wrote: >> On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park >> wrote: >> >  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0. >> > >> >  - Sequential read (Running inside guest) >> >   # fio -name io

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 4:01 PM, Markus Armbruster wrote: > Anthony Liguori writes: > >> On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: >>> On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolf  wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: > Repagent is a new module that allows an external repli

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 17:48, Vadim Rozenfeld wrote: - Original Message - From: "Peter Lieven" To: "Vadim Rozenfeld" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, "Gleb Natapov" Sent: Tuesday, February 21, 2012 4:10:22 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists O

[Qemu-devel] [PATCH] PPC: 405: Fix ppc405ep initialization

2012-02-21 Thread Alexander Graf
When trying to run a ppc405 guest, it segfaults quite quickly, trying to access timers that weren't initialized. Initialize them properly instead. Reported-by: Andreas Faerber Signed-off-by: Alexander Graf --- hw/ppc405_uc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --gi

[Qemu-devel] [PATCH] PPC: 405: Use proper CPU reset

2012-02-21 Thread Alexander Graf
On ppc405ep there is a register that allows for software to reset the core, but not the whole system. Implement this reset using a reset interrupt. This gets rid of a bunch of #if 0'ed code. Reported-by: Andreas Faerber Signed-off-by: Alexander Graf --- cpu-exec.c |2 -- hw/ppc.c

  1   2   >