[Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- slirp/if.c | 19 +-- slirp/mbuf.c |3 +-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/slirp/if.c b/slirp/if.c index 8e0cac2..57350d5 100644 --- a/slirp/if.c +++ b/slirp/if.c @@ -22,6 +22,7 @@ ifs_remque

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Jan Kiszka
On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > Please summarize in a bit more details what was broken. > Signed-off-by: Zhi Yong Wu > --- > slirp/if.c | 19 +-- > slirp/mbuf.c |3 +-- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Zhi Yong Wu
On Thu, Feb 16, 2012 at 4:37 PM, Jan Kiszka wrote: > On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> > > Please summarize in a bit more details what was broken. Should those bits be put in the message part of this part? or here? > >> Signed-off-by: Zhi Yong Wu >> --- >>

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Zhi Yong Wu
On Thu, Feb 16, 2012 at 4:45 PM, Zhi Yong Wu wrote: > On Thu, Feb 16, 2012 at 4:37 PM, Jan Kiszka wrote: >> On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: >>> From: Zhi Yong Wu >>> >> >> Please summarize in a bit more details what was broken. > Should those bits be put in the message part of t

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Jan Kiszka
On 2012-02-16 09:45, Zhi Yong Wu wrote: > On Thu, Feb 16, 2012 at 4:37 PM, Jan Kiszka wrote: >> On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: >>> From: Zhi Yong Wu >>> >> >> Please summarize in a bit more details what was broken. > Should those bits be put in the message part of this part? or

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Gleb Natapov
On Wed, Feb 15, 2012 at 03:59:33PM -0600, Anthony Liguori wrote: > On 02/15/2012 07:39 AM, Avi Kivity wrote: > >On 02/07/2012 08:12 PM, Rusty Russell wrote: > >>>I would really love to have this, but the problem is that we'd need a > >>>general purpose bytecode VM with binding to some kernel APIs.

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Zhi Yong Wu
On Thu, Feb 16, 2012 at 4:48 PM, Jan Kiszka wrote: > On 2012-02-16 09:45, Zhi Yong Wu wrote: >> On Thu, Feb 16, 2012 at 4:37 PM, Jan Kiszka wrote: >>> On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu >>> >>> Please summarize in a bit more details what was broken. >> S

Re: [Qemu-devel] [Spice-devel] [PATCH v2] qxl: don't render stuff when the vm is stopped.

2012-02-16 Thread Alon Levy
On Wed, Feb 15, 2012 at 06:28:53PM +0200, Alon Levy wrote: > On Wed, Feb 15, 2012 at 03:45:30PM +0100, Gerd Hoffmann wrote: > > This patch fixes the local qxl renderer to not kick spice-server > > in case the vm is stopped. First it is largely pointless because > > we ask spice-server to process a

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Markus Armbruster
Luiz Capitulino writes: > It's emitted whenever the tray is moved by the guest or by HMP/QMP > commands. I like the simplicity of this patch. A few remarks inline. > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 17 + > block.c| 24 ++

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Zhi Yong Wu
On Thu, Feb 16, 2012 at 5:21 PM, Zhi Yong Wu wrote: > On Thu, Feb 16, 2012 at 4:48 PM, Jan Kiszka wrote: >> On 2012-02-16 09:45, Zhi Yong Wu wrote: >>> On Thu, Feb 16, 2012 at 4:37 PM, Jan Kiszka wrote: On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > >>>

Re: [Qemu-devel] [PATCH] ide: fail I/O to empty disk

2012-02-16 Thread Stefan Hajnoczi
On Wed, Feb 15, 2012 at 11:46:11AM +0100, Paolo Bonzini wrote: > Requesting a read or a write operation on an empty disk can lead > to QEMU dumping core. > > Also fix a few braces here and there. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/core.c | 24 > 1 files c

Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add monitor command

2012-02-16 Thread Igor Mammedov
On 02/16/2012 12:35 AM, Anthony Liguori wrote: On 02/15/2012 05:16 PM, Igor Mammedov wrote: Adds ability to hot-add cpus if guest was started with options -smp X,maxcpus=Y where X< Y. For simplicity sake this implementation doesn't allow to add specific cpu but rather it adds the next not yet pl

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Stefan Hajnoczi
On Wed, Feb 15, 2012 at 1:59 AM, Roy Tam <932...@bugs.launchpad.net> wrote: > 0x7c81071e in SwitchToFiber () from C:\WINDOWS\system32\kernel32.dll > (gdb) bt > #0  0x7c81071e in SwitchToFiber () from C:\WINDOWS\system32\kernel32.dll > #1  0x0044774c in qemu_coroutine_switch (from_=0x19593fc, to_=0x

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-16 Thread Stefan Hajnoczi
+1 I like this one because it has potential for a qemu.org favicon - imagine just a big Q with the red emu head as a simple vector logo. Other icons cannot be easily used since the O'Reilly-style lineart doesn't work in low resolution. If you're wondering what I'm talking about compare the old Ne

Re: [Qemu-devel] [PATCH v16 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-16 Thread Peter Maydell
On 16 February 2012 04:44, Evgeny Voevodin wrote: > On 16.02.2012 08:40, Evgeny Voevodin wrote: >> >> This set of patches adds support for Samsung Exynos4210-based boards NURI >> and SMDKC210. >> Tested on Linux kernel v3.x series. > > > Guys, I think that this is a time to apply this patch series

Re: [Qemu-devel] [PATCH v5 0/4] Zynq-7000 EPP platform model

2012-02-16 Thread Edgar E. Iglesias
On Thu, Feb 16, 2012 at 12:17:02PM +1000, Peter A. G. Crosthwaite wrote: > This is a suite of Device models and a machine model for the Xilinx Zynq-7000 > Extensible Processing Platform: > > http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm > > This is an ARM based platform

Re: [Qemu-devel] [PATCH v5 0/7] Add support for vexpress-a15

2012-02-16 Thread Peter Maydell
On 15 February 2012 14:36, Peter Maydell wrote: > This patchset adds support for the Versatile Express A15 daughterboard. > The resulting model is capable of booting a Linux kernel which has > been configured for Cortex-A15 with the Versatile Express "extended > memory map" and without support for

Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add monitor command

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:35, Anthony Liguori wrote: > On 02/15/2012 05:16 PM, Igor Mammedov wrote: >> Adds ability to hot-add cpus if guest was started with options >> -smp X,maxcpus=Y >> where X< Y. >> For simplicity sake this implementation doesn't allow to add specific >> cpu but rather it adds th

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-16 Thread Kevin Wolf
Am 15.02.2012 15:34, schrieb Anthony Liguori: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Avi Kivity
On 02/16/2012 12:21 AM, Arnd Bergmann wrote: > ioctl is good for hardware devices and stuff that you want to enumerate > and/or control permissions on. For something like KVM that is really a > core kernel service, a syscall makes much more sense. > > I would certainly never mix the two concepts: I

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 10:34, schrieb Stefan Hajnoczi: > This is interesting because the code is a straightforward usage of > coroutines: > > co = qemu_coroutine_create(bdrv_rw_co_entry); > qemu_coroutine_enter(co, &rwco); <--- boom > > Please make test-coroutine and try ./test-coroutine. That performs

Re: [Qemu-devel] [PATCH] ide: fail I/O to empty disk

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 08:45, schrieb Stefan Hajnoczi: > On Wed, Feb 15, 2012 at 11:46:11AM +0100, Paolo Bonzini wrote: >> Requesting a read or a write operation on an empty disk can lead >> to QEMU dumping core. >> >> Also fix a few braces here and there. >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/i

[Qemu-devel] [Bug 925405] Re: VNC server does not work with Mac Screen Sharing

2012-02-16 Thread Fabio Marconi
** Changed in: ubuntu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/925405 Title: VNC server does not work with Mac Screen Sharing Status in QEMU: New Status in Ubu

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Paolo Bonzini
On 02/16/2012 11:34 AM, Kevin Wolf wrote: > Remember that I saw a similar crash a while ago? It was definitely a > NULL pointer access somewhere inside SwitchToFiber. I can't remember > exactly what came out of it, but I think you and Paolo couldn't > reproduce it and I ran out of time for debuggin

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Kevin Wolf
Am 15.02.2012 19:55, schrieb Jan Kiszka: > On 2012-02-15 19:45, Michael S. Tsirkin wrote: >> Remove ugly macros for field names, >> change done by the following script: >> >> s#\bifq_prev\b#m_prev#g; >> s#\bifq_next\b#m_next#g; >> s#\bifs_prev\b#m_prevpkt#g; >> s#\bifs_next\b#m_nextpkt#g; >> s#\bif

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Roy Tam
2012/2/16 Kevin Wolf <932...@bugs.launchpad.net>: > Am 16.02.2012 10:34, schrieb Stefan Hajnoczi: >> This is interesting because the code is a straightforward usage of >> coroutines: >> >> co = qemu_coroutine_create(bdrv_rw_co_entry); >> qemu_coroutine_enter(co, &rwco);   <--- boom >> >> Please mak

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Peter Maydell
On 16 February 2012 11:06, Kevin Wolf wrote: > What are all these m_ and mh_ prefixes for struct fields even about? > When I have an mbuf, I know perfectly well that it is one, and that > m_hdr is a header of it. That's the dead hand of Sixth Edition Unix and its C compiler that put all struct fi

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 12:01, schrieb Paolo Bonzini: > On 02/16/2012 11:34 AM, Kevin Wolf wrote: >> Remember that I saw a similar crash a while ago? It was definitely a >> NULL pointer access somewhere inside SwitchToFiber. I can't remember >> exactly what came out of it, but I think you and Paolo couldn't

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 12:09, schrieb Peter Maydell: > On 16 February 2012 11:06, Kevin Wolf wrote: >> What are all these m_ and mh_ prefixes for struct fields even about? >> When I have an mbuf, I know perfectly well that it is one, and that >> m_hdr is a header of it. > > That's the dead hand of Sixth E

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > of sysbus. So we can support APIC hot-plug feature. > > This is repost of original patch for qemu-kvm rebased on cur

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > Convert pc cpu to qdev device that is attached to icc bus, later > hot-plug ability of icc bus will allow to implement cpu hot-plug. > > Signed-off-by: Igor Mammedov > --- > hw/pc.c | 62 +++--

Re: [Qemu-devel] [PATCH 4/7] cleanup: remove redundant pc_cpu_reset

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > All cpus except of boot cpu should be halted after reset. > So remove redundant pc_cpu_reset and use cpu_reset instead. > > Signed-off-by: Igor Mammedov > --- > hw/pc.c | 11 ++- > target-i386/helper.c |1 + > 2 files changed

Re: [Qemu-devel] [PATCH 5/7] Set default 'model' property if it wasn't specified yet.

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > If cpu model wasn't specified at startup or hot-plug set it to default > value for the target. > > Signed-off-by: Igor Mammedov > --- > hw/pc.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > in

Re: [Qemu-devel] [PATCH 6/7] Prepare ACPI infrastructure for cpu hot-plug in acpi_piix4

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > It's backport of acpi related cpu-hotplug code from qemu-kvm. > Provides means to communicate cpu hot-plug events to guest OS > and that works with current seabios. > > Signed-off-by: Igor Mammedov > --- > hw/acpi_piix4.c | 65 +++

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Michael S. Tsirkin
On Wed, Feb 15, 2012 at 07:55:47PM +0100, Jan Kiszka wrote: > On 2012-02-15 19:45, Michael S. Tsirkin wrote: > > Remove ugly macros for field names, > > change done by the following script: > > > > s#\bifq_prev\b#m_prev#g; > > s#\bifq_next\b#m_next#g; > > s#\bifs_prev\b#m_prevpkt#g; > > s#\bifs_ne

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > +static ICCBusDeviceInfo cpu_device_info = { > +.qdev.name = "cpu-pc", > +.qdev.size = sizeof(CPUPC), > +.qdev.reset = cpu_device_reset, > +.init = cpu_device_init, > +.qdev.props = (Property[]) { > +DEFINE_PROP_STRING("model",

[Qemu-devel] [PATCH] test-coroutine: add performance test for nesting

2012-02-16 Thread Alex Barcelo
The performance test will also check for nesting. It will do a certain quantity of cycles, and each of one will do a depth nesting process. This is useful for benchmarking the creation of coroutines, given that nesting is creation-intensive (and the other perf test does not benchmark that). Signe

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Anthony Liguori
On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead of sysbus. So we can support APIC hot-plug feature. This is repost of origina

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/15/2012 05:16 PM, Igor Mammedov wrote: Convert pc cpu to qdev device that is attached to icc bus, later hot-plug ability of icc bus will allow to implement cpu hot-plug. Signed-off-by: Igor Mammedov Obviously, this needs to go to QOM, but also, this is a shallow conversion. Beginning wi

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-16 Thread Zhi Yong Wu
Your mail has not CCed to qemu-devel mail, and only sent to me. Help you fwd to qemu-devel mail list. On Thu, Feb 16, 2012 at 12:44 PM, Khansa Butt wrote: > +1 > > > On Thu, Feb 16, 2012 at 6:56 AM, Zhi Yong Wu wrote: >> >> On Wed, Feb 15, 2012 at 10:34 PM, Anthony Liguori >> wrote: >> > Pleas

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:42, Anthony Liguori wrote: > On 02/16/2012 05:25 AM, Jan Kiszka wrote: >> On 2012-02-16 00:16, Igor Mammedov wrote: >>> Introduce a new structure CPUS as the controller of ICC (INTERRUPT >>> CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead >>> of sysbus. So we can

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = "cpu-pc", +.qdev.size = sizeof(CPUPC), +.qdev.reset = cpu_device_reset, +.init = cpu_device_init, +.qdev.props = (Property[]) { +

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:51, Anthony Liguori wrote: > On 02/16/2012 06:01 AM, Jan Kiszka wrote: >> On 2012-02-16 00:16, Igor Mammedov wrote: >>> +static ICCBusDeviceInfo cpu_device_info = { >>> +.qdev.name = "cpu-pc", >>> +.qdev.size = sizeof(CPUPC), >>> +.qdev.reset = cpu_device_reset, >>> +

Re: [Qemu-devel] [PATCH uq/master] Synchronize cpu state with kernel before poking into registers.

2012-02-16 Thread Jan Kiszka
On 2012-02-16 10:12, Gleb Natapov wrote: > Call to kvm_cpu_synchronize_state() is missing. > kvm_arch_stop_on_emulation_error may > look at outdated registers here. > > Signed-off-by: Gleb Natapov > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 7079e87..51d0ae7 100644 > --- a/target

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:50 AM, Jan Kiszka wrote: On 2012-02-16 13:42, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold API

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:59, Anthony Liguori wrote: > On 02/16/2012 06:50 AM, Jan Kiszka wrote: >> On 2012-02-16 13:42, Anthony Liguori wrote: >>> On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: > Introduce a new structure CPUS as the controller of ICC (INTERRUP

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Roy Tam
2012/2/16 Kevin Wolf : > Am 16.02.2012 12:01, schrieb Paolo Bonzini: >> On 02/16/2012 11:34 AM, Kevin Wolf wrote: >>> Remember that I saw a similar crash a while ago? It was definitely a >>> NULL pointer access somewhere inside SwitchToFiber. I can't remember >>> exactly what came out of it, but I

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 10:25:43 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > It's emitted whenever the tray is moved by the guest or by HMP/QMP > > commands. > > I like the simplicity of this patch. A few remarks inline. > > > Signed-off-by: Luiz Capitulino > > --- > > QMP/q

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 11:14:47 -0200 Luiz Capitulino wrote: > On Thu, 16 Feb 2012 10:25:43 +0100 > Markus Armbruster wrote: > > > Luiz Capitulino writes: > > > > > It's emitted whenever the tray is moved by the guest or by HMP/QMP > > > commands. > > > > I like the simplicity of this patch. A

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 14:14, schrieb Luiz Capitulino: > On Thu, 16 Feb 2012 10:25:43 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >>> It's emitted whenever the tray is moved by the guest or by HMP/QMP >>> commands. >> >> I like the simplicity of this patch. A few remarks inline. >>

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 14:31:56 +0100 Kevin Wolf wrote: > Am 16.02.2012 14:14, schrieb Luiz Capitulino: > > On Thu, 16 Feb 2012 10:25:43 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >>> It's emitted whenever the tray is moved by the guest or by HMP/QMP > >>> commands

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Anthony Liguori
On 02/16/2012 02:57 AM, Gleb Natapov wrote: On Wed, Feb 15, 2012 at 03:59:33PM -0600, Anthony Liguori wrote: On 02/15/2012 07:39 AM, Avi Kivity wrote: On 02/07/2012 08:12 PM, Rusty Russell wrote: I would really love to have this, but the problem is that we'd need a general purpose bytecode VM

[Qemu-devel] Merging qemu-iotests into qemu.git?

2012-02-16 Thread Kevin Wolf
Hi Christoph, I just talked to Stefan about our testing, both regarding the block layer and qemu in general, and we came to the conclusion that it would probably make sense to merge qemu-iotests into qemu.git. The immediate benefit would be that we could include some short-running tests into 'mak

Re: [Qemu-devel] [PATCH v3 4/9] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-16 Thread Avi Kivity
On 02/14/2012 05:13 PM, Jan Kiszka wrote: > Note that KVM without in-kernel irqchip will report the address after > the instruction that triggered a write access. In contrast, read > accesses will return the precise information. > Well this is wierd. We could retro-doc one or the other behaviour,

Re: [Qemu-devel] [PATCH v3 4/9] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-16 Thread Jan Kiszka
On 2012-02-16 16:21, Avi Kivity wrote: > On 02/14/2012 05:13 PM, Jan Kiszka wrote: >> Note that KVM without in-kernel irqchip will report the address after >> the instruction that triggered a write access. In contrast, read >> accesses will return the precise information. >> > > Well this is wierd

Re: [Qemu-devel] [PATCH v3 6/9] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-16 Thread Avi Kivity
On 02/14/2012 05:13 PM, Jan Kiszka wrote: > This enables acceleration for MMIO-based TPR registers accesses of > 32-bit Windows guest systems. It is mostly useful with KVM enabled, > either on older Intel CPUs (without flexpriority feature, can also be > manually disabled for testing) or any curren

Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add monitor command

2012-02-16 Thread Andreas Färber
Am 16.02.2012 10:33, schrieb Igor Mammedov: > On 02/16/2012 12:35 AM, Anthony Liguori wrote: >> On 02/15/2012 05:16 PM, Igor Mammedov wrote: >>> Adds ability to hot-add cpus if guest was started with options >>> -smp X,maxcpus=Y >>> where X< Y. >>> For simplicity sake this implementation doesn't al

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Paolo Bonzini
On 02/16/2012 02:13 PM, Roy Tam wrote: > * Before a Thread can call SwitchToFiber() it must call > ConvertThreadToFiber(), but there is no way prior to Vista > to know if a Thread created by alien code is already a > Fiber, and the documentation is spectacularly unclear on the > c

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Andreas Färber
Am 16.02.2012 00:16, schrieb Igor Mammedov: > Convert pc cpu to qdev device that is attached to icc bus, later > hot-plug ability of icc bus will allow to implement cpu hot-plug. > > Signed-off-by: Igor Mammedov This conflicts with CPU QOM'ification across targets (and no longer applies due to t

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:54 AM, Jan Kiszka wrote: On 2012-02-16 13:51, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = "cpu-pc", +.qdev.size = sizeof(CPUPC), +.qdev.reset =

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Arnd Bergmann
On Tuesday 07 February 2012, Alexander Graf wrote: > On 07.02.2012, at 07:58, Michael Ellerman wrote: > > > On Mon, 2012-02-06 at 13:46 -0600, Scott Wood wrote: > >> You're exposing a large, complex kernel subsystem that does very > >> low-level things with the hardware. It's a potential source o

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Arnd Bergmann
On Tuesday 07 February 2012, Alexander Graf wrote: > >> > >> Not sure we'll ever get there. For PPC, it will probably take another 1-2 > >> years until we get the 32-bit targets stabilized. By then we will have new > >> 64-bit support though. And then the next gen will come out giving us even >

Re: [Qemu-devel] [MASCOT CONTEST] Alex Bradbury #1

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [MASCOT CONTEST] Clare Liguori #1

2012-02-16 Thread Wanlong Gao
On 02/15/2012 10:46 PM, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. ACK

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2012-02-16 Thread C Anthony Risinger
if this doesn't thread correctly ... RE: http://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03694.html On Thu, 29 Sep 2011 16:45:37 +0100, Daniel P. Berrange wrote: > On Thu, Sep 29, 2011 at 08:52:14PM +0530, Aneesh Kumar K.V wrote: >> On Wed, 28 Sep 2011 16:18:07 +0100, Daniel P. Berrange w

[Qemu-devel] [PATCH 2/2] qom: Fix identifiers in documentation

2012-02-16 Thread Andreas Färber
Fixes gtk-doc warnings. Signed-off-by: Andreas Färber --- include/qemu/object.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index c871254..5179c0c 100644 --- a/include/qemu/object.h +++ b/include/qemu/object.h @@ -486,

[Qemu-devel] [PATCH 0/2] Some small documentation fixes

2012-02-16 Thread Andreas Färber
Hey, I've taken the liberty of rebasing Anthony's gtk-doc patches to verify the documentation I'm adding in the CPU series. Here's some warning fixes that came out of this endeavor. Two open issues remain: * Identifier extensions (e.g., #Objects) lead to warnings. * Some structs are not picked up

[Qemu-devel] [PATCH 1/2] qom: Fix typo in Object's documentation

2012-02-16 Thread Andreas Färber
Fixes a warning from gtk-doc. Signed-off-by: Andreas Färber --- include/qemu/object.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index 69cc2ab..c871254 100644 --- a/include/qemu/object.h +++ b/include/qemu/object.h @@ -

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-02-16 Thread vrozenfe
It was a long journey. But now it seem like we've managed to fix this problem. https://bugzilla.redhat.com/show_bug.cgi?id=771390#c45 I put new drivers here: http://people.redhat.com/vrozenfe/vioscsi.vfd Best regards, Vadim. -- You received this bug notification because you are a member of qem

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

[Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes

2012-02-16 Thread Alon Levy
This allows us to reduce the size of the surfaces bar minimally while not breaking current drivers. To completely disable the bar, or make it zero sized, would break them. Signed-off-by: Alon Levy --- hw/qxl.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c

Re: [Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #2

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [MASCOT CONTEST] Andreas Faerber #1

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [MASCOT CONTEST] Clare Liguori #1

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

[Qemu-devel] [PATCH] qemu-ga: Add guest-getip command

2012-02-16 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- qapi-schema-guest.json | 16 + qga/guest-agent-commands.c | 15

[Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-16 Thread Alexander Barabash
Add object_property_get_child(). Adding a direct accessor to a child property. In the existing implementation, object_property_get() must be used, with with a visitor, implementing the 'type_str' callback, receiving the child's canonical path. In the new implementation,

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused pl080_init().

2012-02-16 Thread Peter Maydell
On 16 February 2012 17:36, Alexander Barabash wrote: > >    Removed unused pl080_init(). I posted the equivalent of this patch recently and it is in arm-devs.next -- please don't commit to qemu-trivial. Thanks -- PMM

Re: [Qemu-devel] [PATCH] [TRIVIAL] Replace object_delete() with object_unref().

2012-02-16 Thread Peter Maydell
Object model lifecycle changes aren't trivial IMHO. [no comment on actual patch contents implied] -- PMM On 16 February 2012 17:38, Alexander Barabash wrote: > >    Replace object_delete() with object_unref(). > >    In the existing implementation, object_delete() >    calls object_unref(), then

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-16 Thread Peter Maydell
On 16 February 2012 17:39, Alexander Barabash wrote: > >    Add object_property_get_child(). > >    Adding a direct accessor to a child property. > >    In the existing implementation, object_property_get() must be used, >    with with a visitor, implementing the 'type_str' callback, >    receivin

[Qemu-devel] [PATCH 1/2] pci: don't export an internal function

2012-02-16 Thread Michael S. Tsirkin
Make an internal function, pci_parse_devaddr, static. Signed-off-by: Michael S. Tsirkin --- hw/pci.c |2 +- hw/pci.h |2 -- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index f580bb5..5827c0e 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -478,7 +478,7 @@ s

[Qemu-devel] [PATCH 0/2] pci devaddr parsing cleanups

2012-02-16 Thread Michael S. Tsirkin
Michael S. Tsirkin (2): pci: don't export an internal function pci: rewrite devaddr parsing hw/pci.c | 83 + hw/pci.h |2 - 2 files changed, 39 insertions(+), 46 deletions(-) -- 1.7.9.111.gf3fb0

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().

2012-02-16 Thread Peter Maydell
On 16 February 2012 17:37, Alexander Barabash wrote: > >    Removed unused arm_sysctl_init(). >    Renamed arm_sysctl_init1() into arm_sysctl_init(). > >    Signed-off-by: Alexander Barabash This also is textually identical to a patch I just submitted this week. Are you sure you aren't somehow l

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().

2012-02-16 Thread Andreas Färber
Am 16.02.2012 18:37, schrieb Alexander Barabash: > > Removed unused arm_sysctl_init(). > Renamed arm_sysctl_init1() into arm_sysctl_init(). > > Signed-off-by: Alexander Barabash This I believe I already reviewed in a patchset from Peter. Not "trivial" but ARM. Andreas > > diff -

Re: [Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #3

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().

2012-02-16 Thread Peter Maydell
On 16 February 2012 18:18, Peter Maydell wrote: > On 16 February 2012 17:37, Alexander Barabash > wrote: >> >>    Removed unused arm_sysctl_init(). >>    Renamed arm_sysctl_init1() into arm_sysctl_init(). >> >>    Signed-off-by: Alexander Barabash > > This also is textually identical to a patch

[Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().

2012-02-16 Thread Alexander Barabash
Removed unused arm_sysctl_init(). Renamed arm_sysctl_init1() into arm_sysctl_init(). Signed-off-by: Alexander Barabash diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c index 149c639..5f1237b 100644 --- a/hw/arm_sysctl.c +++ b/hw/arm_sysctl.c @@ -378,7 +378,7 @@ static void arm_sysctl

Re: [Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #5

2012-02-16 Thread 陳韋任
+1 -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

[Qemu-devel] [PATCH] [TRIVIAL] Removed unused pl080_init().

2012-02-16 Thread Alexander Barabash
Removed unused pl080_init(). Signed-off-by: Alexander Barabash diff --git a/hw/primecell.h b/hw/primecell.h index de7d6f2..ded0446 100644 --- a/hw/primecell.h +++ b/hw/primecell.h @@ -5,9 +5,6 @@ /* Also includes some devices that are currently only used by the ARM boards. */ -/

[Qemu-devel] [PATCH] [TRIVIAL] Replace object_delete() with object_unref().

2012-02-16 Thread Alexander Barabash
Replace object_delete() with object_unref(). In the existing implementation, object_delete() calls object_unref(), then frees the object's storage. Running object_delete() on an object with reference count different from one (1) causes program failure. In the existing im

[Qemu-devel] Minor regression with kvm ioapic, gsi >= 16

2012-02-16 Thread Avi Kivity
kvm-unit-tests.git x86/apic.flat is failing ioapic tests with qemu-system-x86_64 -vnc :99 -device testdev,chardev=x -chardev null,id=x -smp 2 -kernel ./x86/apic.flat -serial stdio ... ioapic interrupt: FAIL ioapic simultaneous interrupt: FAIL This happens because the test is invoking gsi 16, whi

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.02.2012 14:14, schrieb Luiz Capitulino: >> On Thu, 16 Feb 2012 10:25:43 +0100 >> Markus Armbruster wrote: >> >>> Luiz Capitulino writes: >>> It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. >>> >>> I like the simplicity of this p

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 19:30:13 +0100 Markus Armbruster wrote: > > We're probably taking shortcuts so that this > > function really sees a closed -> closed transition when we really have > > closed -> open -> closed. > > Let's figure out how this stuff really works. > > 1. Gues

Re: [Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-16 Thread Peter Maydell
On 16 February 2012 18:39, Meador Inge wrote: > On 02/15/2012 02:14 PM, Peter Maydell wrote: >> I think the right way to deal with both the problem you were seeing >> and this related issue is simply not to try to send the syscall >> request until we have really stopped the CPU. That is, when not

[Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread Michael S. Tsirkin
Use scanf instead of manual string scanning. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 81 +- 1 files changed, 38 insertions(+), 43 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5827c0e..a8c0b69 100644 --- a/hw/pci.c +++

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread malc
On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > Use scanf instead of manual string scanning. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pci.c | 81 > +- > 1 files changed, 38 insertions(+), 43 deletions(-) > > diff --git a/h

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Avi Kivity
On 02/15/2012 04:08 PM, Alexander Graf wrote: > > > > Well, the scatter/gather registers I proposed will give you just one > > register or all of them. > > One register is hardly any use. We either need all ways of a respective > address to do a full fledged lookup or all of them. I should have

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Avi Kivity
On 02/16/2012 03:04 AM, Michael Ellerman wrote: > > > > ioctl is good for hardware devices and stuff that you want to enumerate > > and/or control permissions on. For something like KVM that is really a > > core kernel service, a syscall makes much more sense. > > Yeah maybe. That distinction is a

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Alexander Graf
On 16.02.2012, at 20:24, Avi Kivity wrote: > On 02/15/2012 04:08 PM, Alexander Graf wrote: >>> >>> Well, the scatter/gather registers I proposed will give you just one >>> register or all of them. >> >> One register is hardly any use. We either need all ways of a respective >> address to do a

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Avi Kivity
On 02/16/2012 04:46 PM, Anthony Liguori wrote: >> What will it buy us? Surely not speed. Entering a guest is not much >> (if at all) faster than exiting to userspace and any non trivial >> operation will require exit to userspace anyway, > > > You can emulate the PIT/RTC entirely within the guest u

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Avi Kivity
On 02/16/2012 09:34 PM, Alexander Graf wrote: > On 16.02.2012, at 20:24, Avi Kivity wrote: > > > On 02/15/2012 04:08 PM, Alexander Graf wrote: > >>> > >>> Well, the scatter/gather registers I proposed will give you just one > >>> register or all of them. > >> > >> One register is hardly any use.

  1   2   >