[Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
RHBZ #790083 Signed-off-by: Yonit Halperin --- hw/qxl.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index bc03c1d..a2a3380 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1478,14 +1478,21 @@ static void qxl_vm_change_state_handler(void *

Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure

2012-02-14 Thread Gerd Hoffmann
Hi, > Shouldn't we stop the whole VM at some point, not only vcpu that > does ACPI IO? May be I missed where it is done in the patch series. It isn't hidden elsewhere, qemu doesn't do it. The code was like that before, and I think the reason is that the guest has to stop the other cpus before

Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Gerd Hoffmann
On 02/14/12 09:10, Yonit Halperin wrote: > RHBZ #790083 > > Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b) skip vram when it is unused (in compat mode). I'd love to see (b) done in a different

Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure

2012-02-14 Thread Gleb Natapov
On Tue, Feb 14, 2012 at 09:18:34AM +0100, Gerd Hoffmann wrote: > Hi, > > > Shouldn't we stop the whole VM at some point, not only vcpu that > > does ACPI IO? May be I missed where it is done in the patch series. > > It isn't hidden elsewhere, qemu doesn't do it. The code was like that > befor

Re: [Qemu-devel] Kernel mode VGAs?

2012-02-14 Thread Jan Kiszka
On 2012-02-14 08:12, Gerhard Wiesinger wrote: > Hello, > > Current QEMU-KVM VGA implementation have the following problem with > legacy OS (e.g. DOS with INT10h calls): Performance is low on accessing > A000:0 > page and doing bank switching at the 64k page. Do we already understand the mode and

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-14 Thread Jan Kiszka
On 2012-02-14 08:54, Gleb Natapov wrote: > On Mon, Feb 13, 2012 at 08:22:21PM +0100, Jan Kiszka wrote: Unfortunately, this is only an internal structure, not officially documented by MS. However, all supported OS versions a legacy by now, no longer changing its structure. >>> >>> Thi

Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure

2012-02-14 Thread Gerd Hoffmann
On 02/14/12 09:37, Gleb Natapov wrote: > On Tue, Feb 14, 2012 at 09:18:34AM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> Shouldn't we stop the whole VM at some point, not only vcpu that >>> does ACPI IO? May be I missed where it is done in the patch series. >> >> It isn't hidden elsewhere, qemu does

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-14 Thread Gleb Natapov
On Tue, Feb 14, 2012 at 09:55:46AM +0100, Jan Kiszka wrote: > On 2012-02-14 08:54, Gleb Natapov wrote: > > On Mon, Feb 13, 2012 at 08:22:21PM +0100, Jan Kiszka wrote: > Unfortunately, this is only an internal structure, not officially > documented by MS. However, all supported OS versions

Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure

2012-02-14 Thread Gleb Natapov
On Tue, Feb 14, 2012 at 09:57:01AM +0100, Gerd Hoffmann wrote: > On 02/14/12 09:37, Gleb Natapov wrote: > > On Tue, Feb 14, 2012 at 09:18:34AM +0100, Gerd Hoffmann wrote: > >> Hi, > >> > >>> Shouldn't we stop the whole VM at some point, not only vcpu that > >>> does ACPI IO? May be I missed where

Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 10:35 AM, Gerd Hoffmann wrote: On 02/14/12 09:10, Yonit Halperin wrote: RHBZ #790083 Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b) skip vram when it is unused (in compat mode).

Re: [Qemu-devel] [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 11:10 AM, Yonit Halperin wrote: On 02/14/2012 10:35 AM, Gerd Hoffmann wrote: On 02/14/12 09:10, Yonit Halperin wrote: RHBZ #790083 Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b)

[Qemu-devel] [PATCH 2/2] qdev: print error message before aborting

2012-02-14 Thread Paolo Bonzini
qdev_prop_set_* functions are always called by machine init functions that should know what they're doing, so they abort on error. Still, an assert(!errp) does not aid debugging. Print an error before aborting. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 26 +-

[Qemu-devel] [PATCH 1/2] qdev: allow setting properties to NULL

2012-02-14 Thread Paolo Bonzini
SPARC and PPC set properties to NULL. This can be done with an empty string value. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index b6d6fcf..6f09a35 1006

[Qemu-devel] [PATCH 0/2] fix startup crash on sparc/ppc guests

2012-02-14 Thread Paolo Bonzini
The problem happens when qdev_set_prop_* is passed a NULL pointer. The first patch allows this; the second improves the error message if there are problems with qdev properties, as requested by Peter. Blue Swirl, can you apply? Paolo Bonzini (2): qdev: allow setting properties to NULL qdev: p

Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Gerd Hoffmann
Hi, > I can do it, by retrieving the surfaces addresses from the tracked guest > commands. Exactly. > However, if we already do it, it would be even better if we > just dirty only the areas that are actually modified by the update_area > calls. The problem is that (1) spice-server updates surf

Re: [Qemu-devel] slirp-related crash

2012-02-14 Thread Stefan Hajnoczi
On Mon, Feb 13, 2012 at 08:35:45PM +0100, Jan Kiszka wrote: > On 2012-02-13 16:27, Zhi Yong Wu wrote: > I'm inclined to suggest a slirp rewrite (base support, not all features > at once) as a GSOC project. QEMU really deserves something better. A talented student could pull it off, especially if i

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Stefan Hajnoczi
On Mon, Feb 13, 2012 at 03:42:28PM +0100, Alex Barcelo wrote: > +/* > + * This is used as the signal handler. This is called with the brand new > stack > + * (thanks to sigaltstack). We have to return, given that this is a signal > + * handler and the sigmask and some other things are changed. > +

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-14 Thread Stefan Hajnoczi
On Mon, Feb 13, 2012 at 04:11:15PM +0100, Alex Barcelo wrote: > On Mon, Feb 13, 2012 at 15:51, Peter Maydell wrote: > > On 13 February 2012 14:42, Alex Barcelo wrote: > >> This series of patches implements coroutines method with > >> sigaltstack. > >> > >> The flow of creation and management of t

[Qemu-devel] [PATCH 04/20] memory: support stateless memory listeners

2012-02-14 Thread Avi Kivity
Current memory listeners are incremental; that is, they are expected to maintain their own state, and receive callbacks for changes to that state. This patch adds support for stateless listeners; these work by receiving a ->begin() callback (which tells them that new state is coming), a sequence o

[Qemu-devel] [PATCH 06/20] memory: remove first level of l1_phys_map

2012-02-14 Thread Avi Kivity
L1 and the lower levels in l1_phys_map are equivalent, except that L1 has a different size, and is always allocated. Simplify the code by removing L1. This leaves us with a tree composed solely of L2 tables, but that problem can be renamed away later. Signed-off-by: Avi Kivity --- exec.c | 2

[Qemu-devel] [PATCH 13/20] memory: make phys_page_find() return a MemoryRegionSection

2012-02-14 Thread Avi Kivity
We no longer describe memory in terms of individual pages; use sections throughout instead. PhysPageDesc no longer used - remove. Signed-off-by: Avi Kivity --- exec.c | 299 ++-- 1 files changed, 160 insertions(+), 139 deletions(-) d

[Qemu-devel] [PATCH 07/20] memory: unify phys_map last level with intermediate levels

2012-02-14 Thread Avi Kivity
This lays the groundwork for storing leaf data in intermediate levels, saving space. Signed-off-by: Avi Kivity --- exec.c | 78 --- 1 files changed, 35 insertions(+), 43 deletions(-) diff --git a/exec.c b/exec.c index c541ee7..536e70

[Qemu-devel] [PATCH 20/20] memory: allow phys_map tree paths to terminate early

2012-02-14 Thread Avi Kivity
When storing large contiguous ranges in phys_map, all values tend to be the same pointers to a single MemoryRegionSection. Collapse them by marking nodes with level > 0 as leaves. This reduces tree memory usage dramatically. Signed-off-by: Avi Kivity --- exec.c | 28 +

[Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-02-14 Thread Avi Kivity
Instead of storing PhysPageDesc, store pointers to MemoryRegionSections. The various offsets (phys_offset & ~TARGET_PAGE_MASK, PHYS_OFFSET & TARGET_PAGE_MASK, region_offset) can all be synthesized from the information in a MemoryRegionSection. Adjust phys_page_find() to synthesize a PhysPageDesc.

[Qemu-devel] [PATCH 02/20] xen: ignore I/O memory regions

2012-02-14 Thread Avi Kivity
Signed-off-by: Avi Kivity --- xen-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xen-all.c b/xen-all.c index dd52f02..a58a397 100644 --- a/xen-all.c +++ b/xen-all.c @@ -989,7 +989,7 @@ int xen_hvm_init(void) state->memory_listener = xen_memory_listener;

[Qemu-devel] [PATCH 19/20] memory: unify PhysPageEntry::node and ::leaf

2012-02-14 Thread Avi Kivity
They have the same type, unify them. Signed-off-by: Avi Kivity --- exec.c | 38 ++ 1 files changed, 18 insertions(+), 20 deletions(-) diff --git a/exec.c b/exec.c index 98c0056..a2015f7 100644 --- a/exec.c +++ b/exec.c @@ -193,10 +193,8 @@ static uint16_t

Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 11:24 AM, Gerd Hoffmann wrote: Hi, I can do it, by retrieving the surfaces addresses from the tracked guest commands. Exactly. However, if we already do it, it would be even better if we just dirty only the areas that are actually modified by the update_area calls. The prob

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Paolo Bonzini
On 02/14/2012 10:24 AM, Stefan Hajnoczi wrote: setjmp() followed by return is usually bad. We're relying on the fact that the return code path here does not clobber local variables 'self' and 'co'. Can't we longjmp out back to the coroutine_new() function instead? http://www.gnu.org/software/

[Qemu-devel] [PATCH 14/20] memory: give phys_page_find() its own tree search loop

2012-02-14 Thread Avi Kivity
We'll change phys_page_find_alloc() soon, but phys_page_find() doesn't need to bear the consequences. Signed-off-by: Avi Kivity --- exec.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index bf34dc9..24423d5 100644 --- a/exec.c +++ b/ex

[Qemu-devel] [PATCH 12/20] memory: move tlb flush to MemoryListener commit callback

2012-02-14 Thread Avi Kivity
This way, if we have several changes in a single transaction, we flush just once. Signed-off-by: Avi Kivity --- exec.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index 6232a39..2171eba 100644 --- a/exec.c +++ b/exec.c @@ -2625,7 +2625,

[Qemu-devel] [PATCH 09/20] memory: compress phys_map node pointers to 16 bits

2012-02-14 Thread Avi Kivity
Use an expanding vector to store nodes. Allocation is baroque to g_renew() potentially invalidating pointers; this will be addressed later. Signed-off-by: Avi Kivity --- exec.c | 54 +- 1 files changed, 45 insertions(+), 9 deletions(-) diff

Re: [Qemu-devel] slirp-related crash

2012-02-14 Thread Jan Kiszka
On 2012-02-14 09:22, Stefan Hajnoczi wrote: > On Mon, Feb 13, 2012 at 08:35:45PM +0100, Jan Kiszka wrote: >> On 2012-02-13 16:27, Zhi Yong Wu wrote: >> I'm inclined to suggest a slirp rewrite (base support, not all features >> at once) as a GSOC project. QEMU really deserves something better. > >

[Qemu-devel] [PATCH 16/20] memory: replace phys_page_find_alloc() with phys_page_set()

2012-02-14 Thread Avi Kivity
By giving the function the value we want to set, we make it more flexible for the next patch. Signed-off-by: Avi Kivity --- exec.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/exec.c b/exec.c index e382858..26e70c3 100644 --- a/exec.c +++ b/exec.c @@ -4

[Qemu-devel] [PATCH 03/20] memory: split memory listener for the two address spaces

2012-02-14 Thread Avi Kivity
The memory and I/O address spaces do different things, so split them into two memory listeners. Signed-off-by: Avi Kivity --- exec.c | 80 --- 1 files changed, 66 insertions(+), 14 deletions(-) diff --git a/exec.c b/exec.c index aa54

[Qemu-devel] [PATCH 00/20] Reduce storage overhead of memory core

2012-02-14 Thread Avi Kivity
Currently the memory core requires 16 bytes per guest page (0.4% overhead). This patchset, building on the patches posted last week, reduces the overhead to practically nothing. Assuming a 4k page size, contiguous aligned 4k, 4M, and 4G regions each occupy just 2 bytes. Since most guest memory is

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-14 Thread Evgeny Voevodin
On 10.02.2012 09:36, Evgeny Voevodin wrote: This set of patches adds support for Samsung Exynos4210-based boards NURI and SMDKC210. Tested on Linux kernel v3.x series. Usage: Exynos4210 SOC boards are modelled to run two CPU cores.. Linux kernel v3.x configured with exynos4_defconfig can be use

[Qemu-devel] [PATCH 18/20] memory: change phys_page_set() to set multiple pages

2012-02-14 Thread Avi Kivity
Signed-off-by: Avi Kivity --- exec.c | 41 +++-- 1 files changed, 23 insertions(+), 18 deletions(-) diff --git a/exec.c b/exec.c index f4cd867..98c0056 100644 --- a/exec.c +++ b/exec.c @@ -436,8 +436,9 @@ static void phys_map_nodes_reset(void) } -static

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-14 Thread Peter Maydell
On 14 February 2012 10:27, Evgeny Voevodin wrote: > On 10.02.2012 09:36, Evgeny Voevodin wrote: >> This set of patches adds support for Samsung Exynos4210-based boards NURI >> and SMDKC210. > Ping... > Is somebody going to review? It is on my todo list, but I was flying back from a conference sa

[Qemu-devel] profiling qemu

2012-02-14 Thread Artyom Tarasenko
On a x86_64 host a sparc64 emulation feels quite slower than sparc32. I tried to find out what can be optimized and here are some questions. First of all, it's not clear how to do it in the current git: build-prof $ ../qemu/configure --target-list=sparc64-softmmu --enable-gprof --enable-profiler

[Qemu-devel] [PATCH 05/20] memory: change memory registration to rebuild the memory map on each change

2012-02-14 Thread Avi Kivity
Instead of incrementally building the memory map, rebuild it every time. This allows later simplification, since the code need not consider overlaying a previous mapping. It is also RCU friendly. With large memory guests this can get expensive, since the operation is O(mem size), but this will be

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-14 Thread Evgeny Voevodin
On 14.02.2012 14:32, Peter Maydell wrote: On 14 February 2012 10:27, Evgeny Voevodin wrote: On 10.02.2012 09:36, Evgeny Voevodin wrote: This set of patches adds support for Samsung Exynos4210-based boards NURI and SMDKC210. Ping... Is somebody going to review? It is on my todo list, but I wa

[Qemu-devel] [PATCH 11/20] memory: unify the two branches of cpu_register_physical_memory_log()

2012-02-14 Thread Avi Kivity
Identical except that the second branch knows its not modifying an existing subpage. Signed-off-by: Avi Kivity --- exec.c | 49 +++-- 1 files changed, 15 insertions(+), 34 deletions(-) diff --git a/exec.c b/exec.c index 5d0afdb..6232a39 100644 --- a

[Qemu-devel] [PATCH 15/20] memory: simplify multipage/subpage registration

2012-02-14 Thread Avi Kivity
Instead of considering subpage on a per-page basis, split each section into a subpage head, multipage body, and subpage tail, and register each separately. This simplifies the registration functions. Signed-off-by: Avi Kivity --- exec.c | 120 ++-

[Qemu-devel] [PATCH 17/20] memory: switch phys_page_set() to a recursive implementation

2012-02-14 Thread Avi Kivity
Setting multiple pages at once requires backtracking to previous nodes; easiest to achieve via recursion. Signed-off-by: Avi Kivity --- exec.c | 67 +++ 1 files changed, 41 insertions(+), 26 deletions(-) diff --git a/exec.c b/exec.c

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-14 Thread Paul Brook
> Yes, you are right. Also considering that we are only calling > slirp_update_timeout if CONFIG_SLIRP is defined, there is no need for > the !CONFIG_SLIRP dummy version of the function. Looks reasonable to me. Unfortunately I can't remember which combination of headless VM and timer configs cau

[Qemu-devel] [PATCH 01/20] memory: allow MemoryListeners to observe a specific address space

2012-02-14 Thread Avi Kivity
Ignore any regions not belonging to a specified address space. Signed-off-by: Avi Kivity --- exec.c |2 +- hw/vhost.c |2 +- kvm-all.c |2 +- memory.c | 45 +++-- memory.h |4 +++- xen-all.c |2 +- 6 files changed, 46 insert

[Qemu-devel] [PATCH 10/20] memory: fix RAM subpages in newly initialized pages

2012-02-14 Thread Avi Kivity
If the first subpage installed in a page is RAM, then we install it as a full page, instead of a subpage. Fix by not special casing RAM. The issue dates to commit db7b5426a4b4242, which introduced subpages. Signed-off-by: Avi Kivity --- exec.c | 22 ++ 1 files changed, 10

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v5

2012-02-14 Thread Andreas Färber
Am 14.02.2012 00:41, schrieb Richard Henderson: > On 02/13/2012 12:13 PM, Blue Swirl wrote: >> Blue Swirl (6): >> TCG: split i386 and x86_64 >> TCG: clean up i386 and x86_64 > > I object to these. I do NOT think splitting these makes the code base > as a whole any cleaner. > > Is this really

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-14 Thread Alex Barcelo
On Tue, Feb 14, 2012 at 09:33, Stefan Hajnoczi wrote: > On Mon, Feb 13, 2012 at 04:11:15PM +0100, Alex Barcelo wrote: >> This new implementation... well, it seems to work (I have done an >> ubuntu installation with a cdrom and a qcow drive, which seems to use >> quite a lot of coroutines). Of cour

Re: [Qemu-devel] [PATCH v15 10/10] MAINTAINERS: Add maintainers for Exynos SOC.

2012-02-14 Thread Andreas Färber
Am 10.02.2012 06:36, schrieb Evgeny Voevodin: > > Signed-off-by: Evgeny Voevodin Pattern matches all new files in this patchset (lan9118 existed before) and syntax seems right. Thank you for adding this, so FWIW: Acked-by: Andreas Färber Andreas > --- > MAINTAINERS |8 > 1 file

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-14 Thread Stefano Stabellini
On Tue, 14 Feb 2012, Paul Brook wrote: > > Yes, you are right. Also considering that we are only calling > > slirp_update_timeout if CONFIG_SLIRP is defined, there is no need for > > the !CONFIG_SLIRP dummy version of the function. > > Looks reasonable to me. Unfortunately I can't remember which

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Alex Barcelo
On Tue, Feb 14, 2012 at 10:24, Stefan Hajnoczi wrote: > On Mon, Feb 13, 2012 at 03:42:28PM +0100, Alex Barcelo wrote: >> +    if (!setjmp(*((jmp_buf *)&tr_reenter))) { >> +        return; >> +    } > > setjmp() followed by return is usually bad.  We're relying on the fact > that the return code pa

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-14 Thread Stefan Hajnoczi
On Tue, Feb 14, 2012 at 11:38 AM, Alex Barcelo wrote: > On Tue, Feb 14, 2012 at 09:33, Stefan Hajnoczi wrote: >> On Mon, Feb 13, 2012 at 04:11:15PM +0100, Alex Barcelo wrote: >>> This new implementation... well, it seems to work (I have done an >>> ubuntu installation with a cdrom and a qcow driv

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Stefan Hajnoczi
On Tue, Feb 14, 2012 at 11:53 AM, Alex Barcelo wrote: > On Tue, Feb 14, 2012 at 10:24, Stefan Hajnoczi wrote: >> On Mon, Feb 13, 2012 at 03:42:28PM +0100, Alex Barcelo wrote: >>> +    /* >>> +     * Preserve the SIGUSR1 signal state, block SIGUSR1, >>> +     * and establish our signal handler. Th

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Stefan Hajnoczi
On Tue, Feb 14, 2012 at 9:50 AM, Paolo Bonzini wrote: > On 02/14/2012 10:24 AM, Stefan Hajnoczi wrote: >> >> setjmp() followed by return is usually bad.  We're relying on the fact >> that the return code path here does not clobber local variables 'self' >> and 'co'.  Can't we longjmp out back to t

Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation

2012-02-14 Thread Hervé Poussineau
Hervé Poussineau a écrit : Here are misc fixes done by VirtualBox team. With these patches, floppy emulation is now good enough to run Xenix. Changes v3->v4: - added pc-1.1 machine type - disable media transfer rate check on older machine types - save/restore media transfer rate when media trans

[Qemu-devel] [PATCH] vnc: Don't demote authentication scheme when changing password/disabling login

2012-02-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently when disabling login in VNC, the password is cleared out and the authentication protocol is forced to AUTH_VNC. If you're using a stronger authentication protocol, this has the effect of downgrading your security protocol. Fix this by only changing the authe

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Paul Brook
> > abort can create core dumps or start a debugger which is > > useful for me and maybe other developers, too. > > I consider abort() on OOM somewhat eccentric. abort() is for > programming errors. Resource shortage is an environmental error that is > sometimes (but not always) caused by a prog

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Anthony Liguori
On 02/13/2012 12:29 AM, Stefan Weil wrote: Am 13.02.2012 03:37, schrieb Zhi Yong Wu: On Fri, Feb 10, 2012 at 11:53 PM, Stefan Weil wrote: Am 10.02.2012 16:13, schrieb Zhi Yong Wu: On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange wrote: On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yon

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Anthony Liguori
On 02/13/2012 05:16 AM, Stefan Hajnoczi wrote: On Mon, Feb 13, 2012 at 6:29 AM, Stefan Weil wrote: Allocating RAM for the emulated machine is perhaps the only scenario where a core dump is indeed not reasonable. In most other cases, out-of-memory is an indication of a QEMU internal problem, so

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2012 at 12:42:58PM +, Paul Brook wrote: > > > abort can create core dumps or start a debugger which is > > > useful for me and maybe other developers, too. > > > > I consider abort() on OOM somewhat eccentric. abort() is for > > programming errors. Resource shortage is an env

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Anthony Liguori
On 02/13/2012 08:04 AM, Markus Armbruster wrote: Stefan Weil writes: Am 10.02.2012 16:13, schrieb Zhi Yong Wu: On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange wrote: On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- oslib

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Paul Brook
> > In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking > > for an additional Ack. > > No problem, I'll get an Ack :) > Meanwhile - here's a summary, as far as I understand it. > > Originally PCI SIG only defined the electrical > and mechanical requirements from hotplug, no stan

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-14 Thread Paul Brook
> This series of patches implements coroutines method with > sigaltstack. > > The flow of creation and management of the coroutines is > quite similar to the coroutine-ucontext.c. The way to use > sigaltstack to achieve the needed stack manipulation is > done in a way quite similar to the GNU Port

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Paul Brook
> > The only way to handle this rebustly is to pre-allocate all the memory > > we're ever going to need[1]. I don't see that happening. > > FWIW, users can already opt-in to pre-allocation if running KVM enabled > QEMU > >-mem-path /dev/shm -mem-prealloc (or /dev/hugepages more usefully)

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-14 Thread Alex Barcelo
On Tue, Feb 14, 2012 at 13:17, Stefan Hajnoczi wrote: > On Tue, Feb 14, 2012 at 11:38 AM, Alex Barcelo wrote: >> On Tue, Feb 14, 2012 at 09:33, Stefan Hajnoczi wrote: >>> On Mon, Feb 13, 2012 at 04:11:15PM +0100, Alex Barcelo wrote: This new implementation... well, it seems to work (I have

Re: [Qemu-devel] [Xen-devel] [PATCH V6 10/11] Introduce Xen PCI Passthrough, MSI (3/3)

2012-02-14 Thread Jan Beulich
>>> On 13.02.12 at 13:20, Anthony PERARD wrote: > From: Jiang Yunhong > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git This needs to be updated to include the changes in http://xenbits.xen.org/gitweb/?p=qemu-xen-unstable.git;a=commitdiff;h=bb36d

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Alex Barcelo
On Tue, Feb 14, 2012 at 13:20, Stefan Hajnoczi wrote: > On Tue, Feb 14, 2012 at 11:53 AM, Alex Barcelo wrote: >> On Tue, Feb 14, 2012 at 10:24, Stefan Hajnoczi wrote: >>> (...) >>> What happens when a vcpu thread creates a coroutine while another QEMU >>> thread raises SIG_IPI?  The SIG_IPI will

Re: [Qemu-devel] [RFC Patch 4/7]Qemu: Framework for reopening image files safely

2012-02-14 Thread Supriya Kannery
On 02/07/2012 03:38 PM, Stefan Hajnoczi wrote: On Wed, Feb 01, 2012 at 08:36:58AM +0530, Supriya Kannery wrote: Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respect

Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

2012-02-14 Thread Supriya Kannery
On 02/07/2012 03:47 PM, Stefan Hajnoczi wrote: On Wed, Feb 01, 2012 at 08:37:12AM +0530, Supriya Kannery wrote: +/* stash state before reopen */ +raw_rs->stash_s = g_malloc0(sizeof(BDRVRawState)); +memcpy(raw_rs->stash_s, s, sizeof(BDRVRawState)); Copying a struct is fragile, Mike

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Michael S. Tsirkin
On Tue, Feb 14, 2012 at 12:49:08PM +, Paul Brook wrote: > > > In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking > > > for an additional Ack. > > > > No problem, I'll get an Ack :) > > Meanwhile - here's a summary, as far as I understand it. > > > > Originally PCI SIG only

Re: [Qemu-devel] [Xen-devel] [PATCH V6 10/11] Introduce Xen PCI Passthrough, MSI (3/3)

2012-02-14 Thread Anthony PERARD
On Tue, Feb 14, 2012 at 13:13, Jan Beulich wrote: On 13.02.12 at 13:20, Anthony PERARD wrote: >> From: Jiang Yunhong >> >> A more complete history can be found here: >> git://xenbits.xensource.com/qemu-xen-unstable.git > > This needs to be updated to include the changes in > http://xenbits.

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Paul Brook
> > > Now an OS can have a standard driver and use it > > > to activate hotplug functionality. This is OS hotplug (OSHP). > > > > So presumably this will work on targets that don't have ACPI? > > Assuming a competent guest OS of course. Have you tested this? > > This being the qemu side of thing

Re: [Qemu-devel] profiling qemu

2012-02-14 Thread Lluís Vilanova
Artyom Tarasenko writes: [...] > QEMU 1.0.50 monitor - type 'help' for more information > (qemu) profile > unknown command: 'profile' > (qemu) info profile > async time 38505498320 (38.505) > qemu time 35947093161 (35.947) > Is there a way to find out more? Command "info jit" also has some inf

Re: [Qemu-devel] [Xen-devel] [PATCH V6 10/11] Introduce Xen PCI Passthrough, MSI (3/3)

2012-02-14 Thread Jan Beulich
>>> On 14.02.12 at 14:46, Anthony PERARD wrote: > On Tue, Feb 14, 2012 at 13:13, Jan Beulich wrote: > On 13.02.12 at 13:20, Anthony PERARD wrote: >>> From: Jiang Yunhong >>> >>> A more complete history can be found here: >>> git://xenbits.xensource.com/qemu-xen-unstable.git >> >> This needs

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Michael S. Tsirkin
On Tue, Feb 14, 2012 at 01:47:59PM +, Paul Brook wrote: > > > > Now an OS can have a standard driver and use it > > > > to activate hotplug functionality. This is OS hotplug (OSHP). > > > > > > So presumably this will work on targets that don't have ACPI? > > > Assuming a competent guest OS of

Re: [Qemu-devel] KVM call agenda for Tuesday 14

2012-02-14 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. As there are no topics, call is cancelled. Happy hacking, Juan. PD. You should use the extra time to draw a qemu mascot O:-) > Cheers, > > Juan.

Re: [Qemu-devel] profiling qemu

2012-02-14 Thread Laurent Desnogues
2012/2/14 Lluís Vilanova : > Artyom Tarasenko writes: [...] >> Here it looks like "compute_all_sub" and "compute_all_sub_xcc" are >> good candidates for optimizing: together they take the same amount of >> time as cpu_sparc_exec. I guess both operations would be trivial in >> the x86_64 assembler.

Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure

2012-02-14 Thread Gerd Hoffmann
Hi, >> I see. I've expeced the the guest os putting them into a hlt loop or >> some simliar idle state. Play save and expliticly pausing them all is >> certainly good from a robustness perspective. > Yes. We should not trust a guest to do the "right thing". Updated patch attached. >>> I thin

[Qemu-devel] [PATCH v5 0/6] prevent QEMU from waking up needlessly

2012-02-14 Thread Stefano Stabellini
Hi all, this small patch series prevents QEMU from waking up needlessly on Xen several times a second in order to check some timers. I would like some comments (or some acks ;-) on patch #4 and #5. The first patch stops QEMU from emulating the PIT on Xen, the second patch disables the rtc_clock

Re: [Qemu-devel] profiling qemu

2012-02-14 Thread Artyom Tarasenko
2012/2/14 Lluís Vilanova : > Artyom Tarasenko writes: > [...] >> QEMU 1.0.50 monitor - type 'help' for more information >> (qemu) profile >> unknown command: 'profile' >> (qemu) info profile >> async time  38505498320 (38.505) >> qemu time   35947093161 (35.947) > >> Is there a way to find out more

[Qemu-devel] [PATCH v5 1/6] xen: do not initialize the interval timer and PCSPK emulator

2012-02-14 Thread Stefano Stabellini
PIT and PCSPK are emulated by the hypervisor so we don't need to emulate them in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/h

Re: [Qemu-devel] [PATCH v4 07/11] pc: add 1.1 machine type

2012-02-14 Thread Kevin Wolf
Am 06.02.2012 22:29, schrieb Hervé Poussineau: > > Signed-off-by: Hervé Poussineau > --- > hw/pc_piix.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index c06f1b5..400c6b6 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-14 Thread Stefan Hajnoczi
On Tue, Feb 14, 2012 at 1:12 PM, Alex Barcelo wrote: > On Tue, Feb 14, 2012 at 13:17, Stefan Hajnoczi wrote: >> On Tue, Feb 14, 2012 at 11:38 AM, Alex Barcelo wrote: >>> On Tue, Feb 14, 2012 at 09:33, Stefan Hajnoczi wrote: On Mon, Feb 13, 2012 at 04:11:15PM +0100, Alex Barcelo wrote:

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-14 Thread Stefan Hajnoczi
On Tue, Feb 14, 2012 at 1:21 PM, Alex Barcelo wrote: > On Tue, Feb 14, 2012 at 13:20, Stefan Hajnoczi wrote: >> On Tue, Feb 14, 2012 at 11:53 AM, Alex Barcelo wrote: >>> On Tue, Feb 14, 2012 at 10:24, Stefan Hajnoczi wrote: (...) What happens when a vcpu thread creates a coroutine whi

Re: [Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-14 Thread Kevin Wolf
Am 06.02.2012 22:29, schrieb Hervé Poussineau: > The programmed rate has to be the same as the required rate for the > floppy format ; if that's not the case, the transfer should abort. > This check can be disabled by using the 'check_media_rate' property. > > Save media rate value only if media r

[Qemu-devel] [PATCH v3 2/8] qemu-ga: move channel/transport functionality into wrapper class

2012-02-14 Thread Michael Roth
This is mostly in preparation for the win32 port, which won't use GIO channels for reasons that will be made clearer later. Here the GAChannel class is just a loose wrapper around GIOChannel calls/callbacks, but we also roll in the logic/configuration for various channel types and managing unix soc

Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation

2012-02-14 Thread Kevin Wolf
Am 06.02.2012 22:29, schrieb Hervé Poussineau: > Here are misc fixes done by VirtualBox team. > With these patches, floppy emulation is now good enough to run Xenix. > > Changes v3->v4: > - added pc-1.1 machine type > - disable media transfer rate check on older machine types > - save/restore medi

[Qemu-devel] [PATCH v3 6/9] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-14 Thread Jan Kiszka
This enables acceleration for MMIO-based TPR registers accesses of 32-bit Windows guest systems. It is mostly useful with KVM enabled, either on older Intel CPUs (without flexpriority feature, can also be manually disabled for testing) or any current AMD processor. The approach introduced here is

Re: [Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-14 Thread Paolo Bonzini
On 02/14/2012 04:16 PM, Kevin Wolf wrote: Juan, Paolo, this is a subsection in a struct array. Does this work meanwhile or is it still broken? Juan fixed it. Paolo

[Qemu-devel] [PATCH v3 1/8] qemu-ga: Add schema documentation for types

2012-02-14 Thread Michael Roth
Document guest agent schema types in similar fashion as qmp schema types. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 118 +++- 1 files changed, 97 insertions(+), 21 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.js

Re: [Qemu-devel] profiling qemu

2012-02-14 Thread Laurent Desnogues
On Tue, Feb 14, 2012 at 4:15 PM, Artyom Tarasenko wrote: > 2012/2/14 Laurent Desnogues : >> 2012/2/14 Lluís Vilanova : >>> Artyom Tarasenko writes: >> [...] Here it looks like "compute_all_sub" and "compute_all_sub_xcc" are good candidates for optimizing: together they take the same amou

[Qemu-devel] [PATCH v3 2/9] Remove useless casts from cpu iterators

2012-02-14 Thread Jan Kiszka
CPUState::next_cpu is already CPUState *. Signed-off-by: Jan Kiszka --- cpus.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index d0c8340..4e65894 100644 --- a/cpus.c +++ b/cpus.c @@ -853,7 +853,7 @@ static int all_vcpus_paused(void) if

Re: [Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-14 Thread Kevin Wolf
Am 14.02.2012 16:28, schrieb Paolo Bonzini: > On 02/14/2012 04:16 PM, Kevin Wolf wrote: >> Juan, Paolo, this is a subsection in a struct array. Does this work >> meanwhile or is it still broken? > > Juan fixed it. Oh, cool. :-) Then I'll apply the other four patches as well. Kevin

[Qemu-devel] [PATCH v5 2/6] xen: disable rtc_clock

2012-02-14 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index fd39168

[Qemu-devel] [PATCH v3 9/9] kvmvapic: Use optionrom helpers

2012-02-14 Thread Jan Kiszka
Use OPTION_ROM_START/END from the common header file, add comment to init code. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/kvmvapic.S | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/pc-bios/optionrom/kvmvapic.S b/pc-bios/optionrom/kvmvapic.S index

[Qemu-devel] [PATCH v3 6/8] qemu-ga: add initial win32 support

2012-02-14 Thread Michael Roth
This adds a win32 channel implementation that makes qemu-ga functional on Windows using virtio-serial (unix-listen/isa-serial not currently implemented). Unlike with the posix implementation, we do not use GIOChannel for the following reasons: - glib calls stat() on an fd to check whether S_IFCHR

[Qemu-devel] [PATCH v3 5/9] kvmvapic: Add option ROM

2012-02-14 Thread Jan Kiszka
This imports and builds the original VAPIC option ROM of qemu-kvm. Its interaction with QEMU is described in the commit that introduces the corresponding device model. Signed-off-by: Jan Kiszka --- .gitignore |1 + Makefile |2 +- pc-bios/optionrom/M

[Qemu-devel] [PATCH v3 1/9] kvm: Set cpu_single_env only once

2012-02-14 Thread Jan Kiszka
As we have thread-local cpu_single_env now and KVM uses exactly one thread per VCPU, we can drop the cpu_single_env updates from the loop and initialize this variable only once during setup. Signed-off-by: Jan Kiszka --- cpus.c|1 + kvm-all.c |5 - 2 files changed, 1 insertions(+

[Qemu-devel] [PATCH v5 6/6] main_loop_wait: block indefinitely

2012-02-14 Thread Stefano Stabellini
- remove qemu_calculate_timeout; - explicitly size timeout to uint32_t; - introduce slirp_update_timeout; - pass NULL as timeout argument to select in case timeout is the maximum value; Signed-off-by: Stefano Stabellini Acked-by: Paul Brook --- async.c |2 +- main-loop.c |

  1   2   >