Am 01.02.2012 17:51, schrieb Charles Arnold:
On 2/1/2012 at 05:15 AM, in message <4f292cd0.20...@redhat.com>, Kevin Wolf
> wrote:
>> Am 01.02.2012 00:04, schrieb Charles Arnold:
>>> Thanks Andreas,
>>>
>>> The 'TODO uuid is missing' comment in the patch is from the
>>> original sources (as
Am 01.02.2012 23:41, schrieb Eric Blake:
> On 01/31/2012 08:05 PM, Supriya Kannery wrote:
>> For changing host pagecache setting of a running VM, it is
>> important to have a safe way of reopening its image file.
>>
>> Following patchset introduces:
>> * a generic way to reopen image files saf
Does this Bug similiar with
https://bugzilla.redhat.com/show_bug.cgi?id=771390 ?
** Bug watch added: Red Hat Bugzilla #771390
https://bugzilla.redhat.com/show_bug.cgi?id=771390
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https
Am 02.02.2012 01:09, schrieb Michael Roth:
> On 01/31/2012 09:06 PM, Supriya Kannery wrote:
>> New command "block_set_hostcache" added for dynamically changing
>> host pagecache setting of a block device.
>>
>> Usage:
>> block_set_hostcache
>> = block device
>> = on/off
>>
>> Exampl
Am 02.02.2012 02:49, schrieb Alexander Graf:
> kvm-all.c|4 +
> linux-headers/asm-powerpc/kvm.h | 11 +--
> linux-headers/asm-powerpc/kvm_para.h | 41 -
> linux-headers/asm-s390/kvm.h |9 ++
> linux-headers/asm-x86/hyperv.h |1
On Mon, 23 Jan 2012, Anthony Liguori wrote:
> Otherwise we can write beyond the buffer and corrupt memory. This is tracked
> as CVE-2012-0029.
The stable-1.0 branch looks vulnerable too, shouldn't this patch be
backported?
> Signed-off-by: Anthony Liguori
> ---
> hw/e1000.c |3 +++
> 1 fi
Public bug reported:
When connecting to a QEMU instance from a Mac using any VNC settings on
the QEMU CLI and any target arch (ARM, Intel, etc.), the connection is
attempted but the negotiation never finishes.
I've verified this when building QEMU from source (1.0 and HEAD) on
Ubuntu, Fedora and
Public bug reported:
As detailed in the mailing-list and the brew project (see below), QEMU
currently either doesn't build with LLVM or builds and crashes upon
runtime on Mac OS X Lion (or Snow Leopard if you've upgraded your
compiler from gcc-4.2).
This seems to be tied to the internal represent
Dyweni,
On 17.01.12 23:22:29, Dyweni - KVM wrote:
> I'm getting a very similar error when running oprofile on the
> host...same version of oprofile...
>
>
>
> general protection fault: [#1] PREEMPT SMP
> CPU 5
> Modules linked in: iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi
On 01/18/2012 06:40 AM, Dyweni - KVM wrote:
> Hi All,
>
> I'm not sure who this falls to, so I've included all all parties that
> I thought may be relevant.
>
> I'm getting the following error from my guest kernel when running
> oprofile within qemu-kvm:
>
kvm does not virtualize a PMU before Linu
Can someone explain what is "DB" in this wiki page?
See,
Live snapshots operation extend regular snapshots as follow:
* Create a locked snapshot in DB
On 2012-1-30 19:00, Federico Simoncelli wrote:
Hi,
oVirt, and more specifically VDSM, is currently implementing the live
snapshot feat
- Original Message -
> From: "Shu Ming"
> To: "Federico Simoncelli"
> Cc: qemu-devel@nongnu.org, libvir-l...@redhat.com, "VDSM Project Development"
> ,
> "Dave Allan" , "Eric Blake"
> Sent: Thursday, February 2, 2012 1:59:01 PM
> Subject: Re: [vdsm] oVirt Live Snapshots
>
> Can someone
On February 1, 2012 at 11:05 PM Erik Rull wrote:
> Jan Kiszka wrote:
> > On 2012-02-01 13:52, Erik Rull wrote:
> >> Hi all,
> >>
> >> first of all I'm a bit confused:
> >>
> >> What is the difference between qemu with command line option
--enable-kvm
> >> and qemu-kvm?
> >> It seems to be a di
On 2012-02-02 14:18, Erik Rull wrote:
>
> On February 1, 2012 at 11:05 PM Erik Rull wrote:
>
>> Jan Kiszka wrote:
>>> On 2012-02-01 13:52, Erik Rull wrote:
Hi all,
first of all I'm a bit confused:
What is the difference between qemu with command line option
> --enable-
** Also affects: ubuntu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/925405
Title:
VNC server does not work with Mac Screen Sharing
Status in QEMU:
N
** Also affects: ubuntu
Importance: Undecided
Status: New
** No longer affects: ubuntu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/925412
Title:
Cannot build on Mac using Xcode 4 and L
Tested on i386 platform.
Signed-off-by: Wei Yang
---
qemu-timer.c | 40
qemu-timer.h | 41 +
2 files changed, 41 insertions(+), 40 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index cd026c6..2b5cc48 100
On February 2, 2012 at 2:21 PM Jan Kiszka wrote:
> On 2012-02-02 14:18, Erik Rull wrote:
> >
> > On February 1, 2012 at 11:05 PM Erik Rull
wrote:
> >
> >> Jan Kiszka wrote:
> >>> On 2012-02-01 13:52, Erik Rull wrote:
> Hi all,
>
> first of all I'm a bit confused:
>
>
This option makes no difference for manpages which contains only
ascii chars. But for manpages with actual UTF8 characters (qemu
docs contains these), this change allows to see real characters
instead of mojibakes or substitutes.
Signed-off-By: Michael Tokarev
---
Makefile |9 +
1 f
Currently our texi2pod ignores @documentencoding even if it is set
properly in *.texi files. This results in a mojibake in documents
generated from qemu.pod (which is generated from qemu-doc.texi by
texi2pod), because the rest of the tools assumes ASCII encoding.
This patch recognizes first @docu
On 2012-02-02 15:07, Erik Rull wrote:
>
> On February 2, 2012 at 2:21 PM Jan Kiszka wrote:
>
>> On 2012-02-02 14:18, Erik Rull wrote:
>>>
>>> On February 1, 2012 at 11:05 PM Erik Rull
> wrote:
>>>
Jan Kiszka wrote:
> On 2012-02-01 13:52, Erik Rull wrote:
>> Hi all,
>>
>>
On 2 February 2012 14:16, Michael Tokarev wrote:
> +POD2MAN = pod2man --utf8
> qemu.1: qemu-doc.texi qemu-options.texi qemu-monitor.texi
> $(call quiet-command, \
> perl -Ww -- $(SRC_PATH)/scripts/texi2pod.pl $< qemu.pod && \
> - pod2man --section=1 --center=" " --release=
On 02.02.2012 18:32, Peter Maydell wrote:
> On 2 February 2012 14:16, Michael Tokarev wrote:
>> +POD2MAN = pod2man --utf8
>> qemu.1: qemu-doc.texi qemu-options.texi qemu-monitor.texi
>>$(call quiet-command, \
>> perl -Ww -- $(SRC_PATH)/scripts/texi2pod.pl $< qemu.pod && \
>> -
On 2 February 2012 14:46, Michael Tokarev wrote:
> Besides, this is a task for another patch, since this one "only" thing
> this patch does is addresses the --utf8 issue. Maybe it is so trivial
> that adding --release here actually does fit nicely too. I don't care
> either way, what matters is
On 02.02.2012 18:49, Peter Maydell wrote:
> On 2 February 2012 14:46, Michael Tokarev wrote:
>> Besides, this is a task for another patch, since this one "only" thing
>> this patch does is addresses the --utf8 issue. Maybe it is so trivial
>> that adding --release here actually does fit nicely to
On 02.02.2012 15:15, Stefano Stabellini wrote:
> On Mon, 23 Jan 2012, Anthony Liguori wrote:
>> Otherwise we can write beyond the buffer and corrupt memory. This is tracked
>> as CVE-2012-0029.
>
> The stable-1.0 branch looks vulnerable too, shouldn't this patch be
> backported?
This goes on sin
Am 02.02.2012 16:24, schrieb Michael Tokarev:
> On 02.02.2012 15:15, Stefano Stabellini wrote:
>> On Mon, 23 Jan 2012, Anthony Liguori wrote:
>>> Otherwise we can write beyond the buffer and corrupt memory. This is
>>> tracked
>>> as CVE-2012-0029.
>>
>> The stable-1.0 branch looks vulnerable too
Solaris can be a bit tricky since it supports 32 and 64-bit
applications. Oracle Solaris 11 disabled 32-bit "boot" but
still supports 32-bit applications.
Are the rest of the libraries in the generated Makefile 32-bit or
64-bit? On Solaris, it's fairly easy to tell since the 64-bit libraries
are
Hi, recently I am focusing on KVM(kernel virtualization machine), in which
the device simulation employ the Qemu’s code directly. Still, the Qemu can
run the Guest OS alone, from kernel boot to device simulation.
Device simulation is somehow easy to comprehend. As for kernel boot, is
there any
Hi all
I have a question about IDE TRIM Command.
As you know, QEMU have supported TRIM command since QEMU 0.15.0.
Some QEMU disk images such as qcow2 support bdrv_discard function
which will be called when guest OS executes ATA TRIM command.
So, I think qcow2 image has a function to delete the
Hi all
I have a question about IDE TRIM Command.
As you know, QEMU have supported TRIM command since QEMU 0.15.0.
Some QEMU disk images such as qcow2 support bdrv_discard function
which will be called when guest OS executes ATA TRIM command.
So, I think qcow2 image has a function to delete the
The kvm api has been accumulating cruft for several years now. This is
due to feature creep, fixing mistakes, experience gained by the
maintainers and developers on how to do things, ports to new
architectures, and simply as a side effect of a code base that is
developed slowly and incrementally.
This series, on top of Anthony's qom-upstream.13, fixes several
qdev bugs, and adds enough functionality to QOM, to the point
that all property accesses go through QOM rather than poking
into the structs.
In particular, device initialization goes through the regular,
non-legacy properties; command
The reference that is returned by qdev_device_add is never given
back, so that device_del does not cause the refcount to go to zero
(and thus does nothing).
Signed-off-by: Paolo Bonzini
---
vl.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index d88a18c..c
When a link property's type is an interface, the code expects the
implementation object (not the parent object) to be stored in the
variable. The parent object does not contain the right vtable.
Signed-off-by: Paolo Bonzini
---
qom/object.c |3 ++-
1 files changed, 2 insertions(+), 1 deleti
Drop the special free callback. Instead, register a "regular"
release method in the non-legacy property.
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 19 ---
hw/qdev.c|8 +---
hw/qdev.h|2 +-
3 files changed, 14 insertions(+), 15
In some cases, a legacy property does need a special print method
but not a special parse method. In this case, we can reuse the get/set
from the static (non-legacy) property.
If neither parse nor print is needed, though, do not register the
legacy property at all. The previous patch ensures tha
Do not poke anymore in the struct when accessing qdev properties.
Instead, ask the object to set the right value.
Signed-off-by: Paolo Bonzini
---
hw/qdev-addr.c |5 +++-
hw/qdev-properties.c | 67 ++---
hw/qdev.h|1 -
3 fil
qdev_prop_set is not needed anymore except for hacks, simplify it and
inline it.
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 26 +++---
1 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index ab7f522..d7e
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
The reference that is returned by qdev_device_add is never given
back, so that device_del does not cause the refcount to go to zero
(and thus does nothing).
Signed-off-by: Paolo Bonzini
---
vl.c |1 +
1 files changed, 1 insertions(+), 0 deletio
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
When a link property's type is an interface, the code expects the
implementation object (not the parent object) to be stored in the
variable. The parent object does not contain the right vtable.
Signed-off-by: Paolo Bonzini
---
qom/object.c |3
We need the print method to put double quotes, but parsing is not special.
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 16f9b22..0a293af 100644
--- a/hw/
PCI addresses are set with qdev_prop_uint32. Thus we make the QOM
property accept a device and function encoded in an 8-bit integer,
instead of the magic dd.f hex string.
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 25 +++--
1 files changed, 7 insertions(+), 18
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 61 ++---
1 files changed, 42 insertions(+), 19 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 0a293af..4fb5cf8 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-prope
Similarly, use the object properties also to set the default
values of the qdev properties. This requires reordering
registration and initialization.
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 20 +++-
hw/qdev.c|4 ++--
hw/qdev.h| 11
On 02/02/2012 06:03 PM, Anthony Liguori wrote:
Is this still needed with qom-upstream.14? I fixed a bug on .14 that
involved child properties that was making device-del sometimes fail.
Not sure, I tried with .13 but, from the look of it, it should still be
there. Regarding the .13->.14 di
Integer properties did not work.
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 7efcc78..30abae2 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@
Move the creation of QmpInputVisitor and QmpOutputVisitor from
qmp.c to qom/object.c, since it's the only practical way to access
object properties.
Signed-off-by: Paolo Bonzini
---
include/qemu/object.h | 24
qmp.c | 17 ++---
qom/object.
Signed-off-by: Paolo Bonzini
---
qom/object.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index de6484d..299e146 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -13,8 +13,6 @@
#include "qemu/object.h"
#include "qemu-common.h"
#include "
Yes, I would say it is the same bug. I will test the driver that Vadim
linked in Comment 33
(https://bugzilla.redhat.com/show_bug.cgi?id=771390#c33) and report
back.
Thanks, Mike, for posting here.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscr
Add more wrappers that create a QObject and free it around a
property set, and that convert a QObject to a C type for a property
get.
Signed-off-by: Paolo Bonzini
---
include/qemu/object.h | 70 ++
qom/object.c | 115 +++
There's no need to call into ->parse and ->print manually. The
QOM legacy properties do that for us.
Furthermore, in some cases legacy and static properties have exactly
the same behavior, and we could drop the legacy properties right away.
Add an appropriate fallback to prepare for this.
Signed
Pointer properties (except for PROP_PTR of course) should not need a
legacy counterpart. In the future, relative paths will ensure that
QEMU will support the same syntax as now for drives etc..
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 128
well, the link in the redhat bug, comment 33, is no good apparently. I
will follow that bug, and test when I see Vadim has posted a new driver
to test.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/8
When creating an USB device the old way, there is no way to specify the
target bus. Thus the warning issued by usb_create makes no sense and
rather confuses our users.
Resolve this by passing a bus reference to the usbdevice_init handler
and letting those handlers forward it to usb_create.
Signed
On 30 January 2012 07:38, Evgeny Voevodin wrote:
> This set of patches adds support for Samsung Exynos4210-based boards NURI and
> SMDKC210.
> Tested on Linux kernel v3.x series.
>
> Usage:
> "-smp 2" option is mandatory for now.
If it is then the board should complain about -smp 1. As it is, yo
On 02/02/2012 11:29 AM, Paolo Bonzini wrote:
On 02/02/2012 06:03 PM, Anthony Liguori wrote:
Is this still needed with qom-upstream.14? I fixed a bug on .14 that
involved child properties that was making device-del sometimes fail.
Not sure, I tried with .13 but, from the look of it, it shoul
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
Move the creation of QmpInputVisitor and QmpOutputVisitor from
qmp.c to qom/object.c, since it's the only practical way to access
object properties.
Signed-off-by: Paolo Bonzini
---
include/qemu/object.h | 24
qmp.c
On 02.02.2012, at 20:01, Anthony Liguori wrote:
> On 02/02/2012 11:29 AM, Paolo Bonzini wrote:
>> On 02/02/2012 06:03 PM, Anthony Liguori wrote:
>>>
>>> Is this still needed with qom-upstream.14? I fixed a bug on .14 that
>>> involved child properties that was making device-del sometimes f
On 02/02/2012 08:06 PM, Anthony Liguori wrote:
I don't want object.h to have a dependency on QObject. We need to phase
out QObject.
The header doesn't.
Couple things:
1) We shouldn't use generic interfaces to read/write properties from
objects. We should use type-safe accessors provided by
Am 02.02.2012 20:06, schrieb Anthony Liguori:
> On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
>> Move the creation of QmpInputVisitor and QmpOutputVisitor from
>> qmp.c to qom/object.c, since it's the only practical way to access
>> object properties.
>>
>> Signed-off-by: Paolo Bonzini
>> ---
>> i
On 02/02/2012 08:24 PM, Paolo Bonzini wrote:
1) We shouldn't use generic interfaces to read/write properties from
objects. We should use type-safe accessors provided by the types
themselves.
That doesn't change the fact that we need simple wrappers using C types
(at various levels: object_pro
Hi,
I have modified QEMU to act as a TCG compiler and give me the TCG code for
the whole binary. However, I cannot find a way to obtain the last address
in the binary. The symbol table loaded into syminfos contains only the
address of the last symbol. Not the address of the last machine
instructio
On 02/02/2012 01:24 PM, Paolo Bonzini wrote:
On 02/02/2012 08:06 PM, Anthony Liguori wrote:
I don't want object.h to have a dependency on QObject. We need to phase
out QObject.
The header doesn't.
Couple things:
1) We shouldn't use generic interfaces to read/write properties from
objects. W
Hi,
here are some w32 related patches which were already published
and reviewed on qemu-devel:
http://patchwork.ozlabs.org/patch/132797/
http://patchwork.ozlabs.org/patch/138690/
Regards,
Stefan Weil
The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7:
main-loop: F
These patches apply on top of qemu.git master, and can also be obtained from:
git://github.com/mdroth/qemu.git qga-win32-v2
Luiz/Gal, I decided not to roll the suspend/hibernate stuff into this series
since the s3 situation isn't fully sorted out yet. The file structure is a
little different now,
This is mostly in preparation for the win32 port, which won't use
GIO channels for reasons that will be made clearer later. Here the
GAChannel class is just a loose wrapper around GIOChannel
calls/callbacks, but we also roll in the logic/configuration for
various channel types and managing unix soc
Document guest agent schema types in similar fashion as qmp schema
types.
Signed-off-by: Michael Roth
---
qapi-schema-guest.json | 118 +++-
1 files changed, 97 insertions(+), 21 deletions(-)
diff --git a/qapi-schema-guest.json b/qapi-schema-guest.js
On 02/02/2012 01:29 PM, Paolo Bonzini wrote:
On 02/02/2012 08:24 PM, Paolo Bonzini wrote:
1) We shouldn't use generic interfaces to read/write properties from
objects. We should use type-safe accessors provided by the types
themselves.
That doesn't change the fact that we need simple wrappers
On 02/02/2012 01:07 PM, Alexander Graf wrote:
On 02.02.2012, at 20:01, Anthony Liguori wrote:
On 02/02/2012 11:29 AM, Paolo Bonzini wrote:
On 02/02/2012 06:03 PM, Anthony Liguori wrote:
Is this still needed with qom-upstream.14? I fixed a bug on .14 that
involved child properties that was
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
hw/qdev-properties.c | 61 ++---
1 files changed, 42 insertions(+), 19 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 0a293af..4fb5cf8 10064
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
PCI addresses are set with qdev_prop_uint32. Thus we make the QOM
property accept a device and function encoded in an 8-bit integer,
instead of the magic dd.f hex string.
Signed-off-by: Paolo Bonzini
Isn't this a compatibility breaker?
Won't this
On 02/02/2012 08:36 PM, Anthony Liguori wrote:
The only types that matter are int and string so the variant visitor is
pretty simple.
Sure, only ~150 lines of code. I also do not disagree with the goals
(mine and yours), just with the priorities. :)
Paolo
On 02/02/2012 09:07 PM, Anthony Liguori wrote:
Signed-off-by: Paolo Bonzini
Isn't this a compatibility breaker?
Won't this break libvirt's usage of -device addr=0.2 ?
Nope, the legacy property still keeps the dd.f format. This is only for
QOM (and internal use by qdev).
Paolo
Implement guest-shutdown RPC for Windows. Functionally this should be
equivalent to the posix implementation.
Original patch by Gal Hammer
Signed-off-by: Michael Roth
---
qga/commands-win32.c | 41 -
1 files changed, 40 insertions(+), 1 deletions(-)
d
Many of the current RPC implementations are very much POSIX-specific
and require complete re-writes for Windows. There are however a small
set of core guest agent commands that are common to both, and other
commands such as guest-file-* which *may* be portable. So we introduce
commands.c for the la
On 02.02.2012, at 21:03, Anthony Liguori wrote:
> On 02/02/2012 01:07 PM, Alexander Graf wrote:
>>
>> On 02.02.2012, at 20:01, Anthony Liguori wrote:
>>
>>> On 02/02/2012 11:29 AM, Paolo Bonzini wrote:
On 02/02/2012 06:03 PM, Anthony Liguori wrote:
>>
>
> Is this still needed
This adds a win32 channel implementation that makes qemu-ga functional
on Windows using virtio-serial (unix-listen/isa-serial not currently
implemented). Unlike with the posix implementation, we do not use
GIOChannel for the following reasons:
- glib calls stat() on an fd to check whether S_IFCHR
Signed-off-by: Michael Roth
---
Makefile.objs |2 +-
qga/commands-posix.c | 528
qga/guest-agent-commands.c | 528
3 files changed, 529 insertions(+), 529 deletions(-)
create mode
This allows qemu-ga to function as a Windows service:
- to install the service (will auto-start on boot):
qemu-ga --service install
- to start the service:
net start qemu-ga
- to stop the service:
net stop qemu-ga
- to uninstall service:
qemu-ga --service uninstall
Origina
Various stubs and #ifdefs to compile for Windows using mingw
cross-build. Still has 1 linker error due to a dependency on the
forthcoming win32 versions of the GAChannel/transport class.
Signed-off-by: Michael Roth
---
Makefile |2 +-
Makefile.objs|9 +++--
configure
On 02/02/2012 01:21 PM, Andreas Färber wrote:
Am 02.02.2012 20:06, schrieb Anthony Liguori:
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
Move the creation of QmpInputVisitor and QmpOutputVisitor from
qmp.c to qom/object.c, since it's the only practical way to access
object properties.
Signed-o
On 02/02/2012 02:08 PM, Paolo Bonzini wrote:
On 02/02/2012 08:36 PM, Anthony Liguori wrote:
The only types that matter are int and string so the variant visitor is
pretty simple.
Sure, only ~150 lines of code. I also do not disagree with the goals (mine and
yours), just with the priorities. :)
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Cc: Richard Henderson
Signed-off-by: Stefan Weil
---
target-alpha/cpu.h |1 +
target-alpha/translate.c |5 -
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/target-alpha/cpu.h b/targe
Like the related macro TCG_TARGET_LONG, HOST_LONG_BITS can be determined
by the C preprocessor. It is also not used in Makefiles.
So there is no need to calculate it in configure, and it can be defined
in qemu-common.h.
Signed-off-by: Stefan Weil
---
configure | 12
qemu-comm
Remove some include statements which are not needed.
Cc: Aurelien Jarno
Signed-off-by: Stefan Weil
---
target-mips/translate.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index d5b1c76..8361d88 100644
--- a/tar
Remove some include statements which are not needed.
Signed-off-by: Stefan Weil
---
target-i386/helper.c|6 --
target-i386/op_helper.c |1 -
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 2586aff..87c6a8f 100644
--
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Signed-off-by: Stefan Weil
---
target-s390x/cpu.h |3 +++
target-s390x/helper.c|5 -
target-s390x/translate.c |5 -
3 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/target-
Remove some include statements which are not needed.
Cc: Max Filippov
Signed-off-by: Stefan Weil
---
target-xtensa/core-dc232b.c |1 -
target-xtensa/core-fsf.c|1 -
target-xtensa/helper.c |1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/target-xtensa/cor
Remove some include statements which are not needed.
Cc: Alexander Graf
Signed-off-by: Stefan Weil
---
target-ppc/helper.c|6 --
target-ppc/translate.c |6 --
2 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index 5847
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Signed-off-by: Stefan Weil
---
target-microblaze/cpu.h |3 +++
target-microblaze/helper.c|5 -
target-microblaze/mmu.c |4
target-microblaze/translate.c |8
4 files ch
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Signed-off-by: Stefan Weil
---
target-unicore32/cpu.h|2 ++
target-unicore32/helper.c |4
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Cc: Edgar E. Iglesias
Signed-off-by: Stefan Weil
---
target-cris/cpu.h |3 +++
target-cris/helper.c|4
target-cris/mmu.c |5 -
target-cris/translate.c |7 ---
4 files chan
On 02.02.2012, at 22:12, Stefan Weil wrote:
> Remove some include statements which are not needed.
Are these redundant or do they just happen to be unnecessary because of unused
debug #ifdefs?
Alex
>
> Cc: Alexander Graf
> Signed-off-by: Stefan Weil
> ---
> target-ppc/helper.c|6 -
config.h was missing in cpu.h.
Cc: Michael Walle
Signed-off-by: Stefan Weil
---
target-lm32/cpu.h |1 +
target-lm32/helper.c|5 -
target-lm32/translate.c |8
3 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h
> Remove some include statements which are not needed.
>
> Cc: Max Filippov
> Signed-off-by: Stefan Weil
Acked-by: Max Filippov
Thanks.
-- Max
Remove some include statements which are not needed.
Cc: Aurelien Jarno
Signed-off-by: Stefan Weil
---
target-sh4/translate.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/target-sh4/translate.c b/target-sh4/translate.c
index aacf96d..dd0ee4b 100644
--- a/target-
config.h was missing in cpu.h.
Signed-off-by: Stefan Weil
---
target-m68k/cpu.h |1 +
target-m68k/helper.c|5 -
target-m68k/translate.c |6 --
3 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h
index 0667f82..4cc3a3
HOST_LONG_SIZE is simply the size of a pointer value.
There is no need for this macro.
Signed-off-by: Stefan Weil
---
cpu-defs.h |2 --
thunk.h|4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/cpu-defs.h b/cpu-defs.h
index 57a709b..4527cbf 100644
--- a/cpu-defs.
Hi,
I tried to move the definition of HOST_LONG_BITS from configure
to qemu-common.h. While doing this, I noticed that the different
QEMU targets use includes in non-uniform ways.
So the simple goal resulted in quite a lot of patches.
Patch 1 simply removes a derived macro. This patch is indepen
1 - 100 of 136 matches
Mail list logo
