Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev

2012-02-01 Thread Jan Kiszka
On 2012-02-01 08:29, Paolo Bonzini wrote: > On 01/31/2012 09:49 PM, Anthony Liguori wrote: >>> >>> +DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1), >>> +DEFINE_PROP_PTR("pit", PCSpkState, pit), >> >> Please don't introduce a pointer property here. They cannot be used in >> a

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Kevin Wolf
Am 01.02.2012 00:04, schrieb Charles Arnold: > Thanks Andreas, > > The 'TODO uuid is missing' comment in the patch is from the > original sources (as well as many '//' comments). The vhd footer > and header data structures contain a field for a UUID but no code > was ever developed to generate

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Paolo Bonzini
On 01/31/2012 10:49 PM, Jan Kiszka wrote: > Just make the methods that you want to override virtual with the default > implementation and then make a KVMPIT that inherits from the PIT and > then overrides whatever virtual functions it needs to. That doesn't sound like the proper design for th

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:23, Paolo Bonzini wrote: > On 01/31/2012 10:49 PM, Jan Kiszka wrote: >>> Just make the methods that you want to override virtual with the default >>> implementation and then make a KVMPIT that inherits from the PIT and >>> then overrides whatever virtual functions it needs to. >

[Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a difference in code so far, from the performance point of view it seems to be the same... Now my issue that lead me to a git bisect on qemu-kvm: The f

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Paolo Bonzini
On 02/01/2012 01:43 PM, Jan Kiszka wrote: > It looks good, besides the need to rebase to Anthony's "part 3" changes. Given that this part is not upstream and that the relevant conversion is scripted, I would leave this to Anthony so far. Or what is the schedule? By the time your series is revi

[Qemu-devel] [PATCH RFC v2 8/8] target-arm: Move CPU feature flags out of CPUState

2012-02-01 Thread Andreas Färber
The internal CPU feature flags were only ever set in cpu_reset_model_id(). Therefore move their initialization into ARMCPUClass. We might want to tweak them in the future though (e.g., -cpu cortex-r4,+fpu), so keep a copy in ARMCPU. This in turn means we need to infer features for both ARMCPUClass

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Anthony Liguori
On 01/31/2012 08:40 PM, John Williams wrote: On Wed, Feb 1, 2012 at 12:37 PM, Anthony Liguori wrote: Globals are even worse! Can't you hear the kernel loader begging to be turned into a device? It's pleading with us to stop abusing other parts of QEMU and make it a first class citizen of QEM

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:55, Paolo Bonzini wrote: > On 02/01/2012 01:43 PM, Jan Kiszka wrote: >>> It looks good, besides the need to rebase to Anthony's "part 3" changes. >> Given that this part is not upstream and that the relevant conversion is >> scripted, I would leave this to Anthony so far. Or what

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Peter Maydell
On 1 February 2012 13:04, Anthony Liguori wrote: > How does it race?  Devices normally never touch memory so a loader device > will be the only thing mucking with memory. The obvious one is "loader reset function wants to set starting PC to entry point of kernel/etc" vs "CPU device reset wants to

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 14:10, Jan Kiszka wrote: > On 2012-02-01 13:55, Paolo Bonzini wrote: >> On 02/01/2012 01:43 PM, Jan Kiszka wrote: It looks good, besides the need to rebase to Anthony's "part 3" changes. >>> Given that this part is not upstream and that the relevant conversion is >>> scripted, I

[Qemu-devel] [PATCH RFC v2 1/8] qom: Allow object_class_foreach() to take additional parameters to refine search

2012-02-01 Thread Andreas Färber
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Andreas Färber --- include/qemu/object.h |1 + qom/object.c | 18 -- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index ba37850..a

[Qemu-devel] [PATCH RFC v2 6/8] target-arm: Embed CPUARMState in QOM ARMCPU

2012-02-01 Thread Andreas Färber
We g_malloc0()'ed CPUARMState ourself, and exec.c's cpu_copy() runs through cpu_init() as well, so we are at liberty to supply the CPUState any way we see fit. Having CPUARMState as field in the QOM CPU allows both to access env from an ARMCPU object and to access the QOM Object and its ObjectClass

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Anthony Liguori
On 02/01/2012 06:43 AM, Jan Kiszka wrote: On 2012-02-01 13:23, Paolo Bonzini wrote: On 01/31/2012 10:49 PM, Jan Kiszka wrote: Just make the methods that you want to override virtual with the default implementation and then make a KVMPIT that inherits from the PIT and then overrides whatev

[Qemu-devel] [PATCH RFC v2 5/8] target-arm: Introduce QOM CPU and use it for CPUID lookup

2012-02-01 Thread Andreas Färber
Create a CPU subclass, and register classes matching all CPU models. Don't name the file target-arm/cpu.c so that the user emulators can still easily pick up the base class in hw/cpu.c via VPATH. Make arm_cpu_list() enumerate CPU subclasses. Replace cpu_arm_find_by_name()'s string -> CPUID lookup

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Anthony Liguori
On 02/01/2012 07:10 AM, Peter Maydell wrote: On 1 February 2012 13:04, Anthony Liguori wrote: How does it race? Devices normally never touch memory so a loader device will be the only thing mucking with memory. The obvious one is "loader reset function wants to set starting PC to entry point

[Qemu-devel] [PATCH RFC v2 3/8] qom: Add QOM support to user emulators

2012-02-01 Thread Andreas Färber
Link the Object base class and the module infrastructure for class registration. Call QOM module init. Signed-off-by: Andreas Färber Cc: Anthony Liguori --- Makefile.target|6 ++ Makefile.user |1 + bsd-user/main.c|2 ++ darwin-user/main.c |3 +++ linux-user/mai

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Alexander Graf
On 01.02.2012, at 14:25, Anthony Liguori wrote: > On 02/01/2012 07:10 AM, Peter Maydell wrote: >> On 1 February 2012 13:04, Anthony Liguori wrote: >>> How does it race? Devices normally never touch memory so a loader device >>> will be the only thing mucking with memory. >> >> The obvious one

[Qemu-devel] [PATCH RFC v2 0/8] Introduce QOM CPU and use for ARM

2012-02-01 Thread Andreas Färber
Hello, Here's an updated series on incrementally converting CPUState to QOM. Patch 1 is cherry-picked from Anthony's QOM series 3/4. Patch 2 rearranges module init for QOM. Patch 3 add QOM support to the user emulators. Patch 4 introduces QOM CPU. Patch 5-8 Derive and start using a QOM CPU for

[Qemu-devel] [PATCH RFC v2 7/8] target-arm: Prepare model-specific class_init function

2012-02-01 Thread Andreas Färber
This allows to share initialization between CPU models. Signed-off-by: Andreas Färber --- target-arm/cpu-core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-arm/cpu-core.c b/target-arm/cpu-core.c index 1caf9aa..8284418 100644 --- a/target-arm/cpu-core.c +++

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Avi Kivity
On 02/01/2012 02:52 PM, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > > What is the difference between qemu with command line option --enable-kvm > and qemu-kvm? > It seems to be a difference in code so far, from the performance point of > view it seems to be the same... The d

[Qemu-devel] [PATCH RFC v2 4/8] qom: Introduce CPU class

2012-02-01 Thread Andreas Färber
It's abstract and derived directly from TYPE_OBJECT. Prepare a virtual reset method. Place it in hw/. Have user emulators pick it up via VPATH, building it per target since they didn't use any qdev/QOM devices so far. Signed-off-by: Andreas Färber Cc: Anthony Liguori --- Makefile.objs |

Re: [Qemu-devel] [PATCH v11 4/9] ARM: exynos4210: PWM support.

2012-02-01 Thread Peter Maydell
On 31 January 2012 08:31, Evgeny Voevodin wrote: > On 01/30/2012 11:38 AM, Evgeny Voevodin wrote: >> >> Signed-off-by: Evgeny Voevodin >> Reviewed-by: Peter Maydell >> --- > > This patch should not contain "Reviewed-by:" since QOM usage was added. > Apologise for it. > Peter, could you, please, re

Re: [Qemu-devel] [PATCH v11 6/9] ARM: exynos4210: MCT support.

2012-02-01 Thread Peter Maydell
On 31 January 2012 08:32, Evgeny Voevodin wrote: > On 01/30/2012 11:38 AM, Evgeny Voevodin wrote: >> >> Signed-off-by: Evgeny Voevodin >> Reviewed-by: Peter Maydell > > This patch should not contain "Reviewed-by:" since QOM usage was added. > Apologise for it. > Peter, could you, please, rereview

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Anthony Liguori
On 02/01/2012 07:32 AM, Alexander Graf wrote: On 01.02.2012, at 14:25, Anthony Liguori wrote: On 02/01/2012 07:10 AM, Peter Maydell wrote: On 1 February 2012 13:04, Anthony Liguori wrote: How does it race? Devices normally never touch memory so a loader device will be the only thing mucki

Re: [Qemu-devel] [PATCH v11 9/9] Exynos4210: added display controller implementation

2012-02-01 Thread Peter Maydell
On 31 January 2012 08:33, Evgeny Voevodin wrote: > On 01/30/2012 11:38 AM, Evgeny Voevodin wrote: >> >> From: Mitsyanko Igor >> >> Exynos4210 display controller (FIMD) has 5 hardware windows with alpha and >> chroma key blending functions. >> >> Signed-off-by: Mitsyanko Igor >> Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Alexander Graf
On 01.02.2012, at 14:44, Anthony Liguori wrote: > On 02/01/2012 07:32 AM, Alexander Graf wrote: >> >> On 01.02.2012, at 14:25, Anthony Liguori wrote: >> >>> On 02/01/2012 07:10 AM, Peter Maydell wrote: On 1 February 2012 13:04, Anthony Liguori wrote: > How does it race? Devices norm

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Anthony Liguori
On 02/01/2012 07:49 AM, Alexander Graf wrote: On 01.02.2012, at 14:44, Anthony Liguori wrote: On 02/01/2012 07:32 AM, Alexander Graf wrote: On 01.02.2012, at 14:25, Anthony Liguori wrote: On 02/01/2012 07:10 AM, Peter Maydell wrote: On 1 February 2012 13:04, Anthony Liguoriwrote: How

[Qemu-devel] [PATCH RFC v2 2/8] qom: Register QOM infrastructure early

2012-02-01 Thread Andreas Färber
QOM TYPE_INTERFACE was registered with device_init(), whose constructors are executed rather late in vl.c's main(). Rename the module init type from DEVICE to QOM and call it very early so that QOM can safely be used for machines and CPUs. device_init() is left for legacy types. New ones should u

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Alexander Graf
On 01.02.2012, at 14:52, Anthony Liguori wrote: > On 02/01/2012 07:49 AM, Alexander Graf wrote: >> >> On 01.02.2012, at 14:44, Anthony Liguori wrote: >> >>> On 02/01/2012 07:32 AM, Alexander Graf wrote: On 01.02.2012, at 14:25, Anthony Liguori wrote: > On 02/01/2012 07:10 A

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 2:40 PM Avi Kivity wrote: > On 02/01/2012 02:52 PM, Erik Rull wrote: > > Hi all, > > > > first of all I'm a bit confused: > > > > What is the difference between qemu with command line option --enable-kvm > > and qemu-kvm? > > It seems to be a difference in code so far, fr

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 15:02, Erik Rull wrote: > > On February 1, 2012 at 2:40 PM Avi Kivity wrote: > >> On 02/01/2012 02:52 PM, Erik Rull wrote: >>> Hi all, >>> >>> first of all I'm a bit confused: >>> >>> What is the difference between qemu with command line option > --enable-kvm >>> and qemu-kvm? >>>

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Anthony Liguori
On 02/01/2012 07:55 AM, Alexander Graf wrote: On 01.02.2012, at 14:52, Anthony Liguori wrote: Fine, but to boot u-boot, the real hardware must set IP to something that's most likely an offset into ROM flash. Why can't we bootstrap semi-hosted mode by having a ROM somewhere that just redirect

Re: [Qemu-devel] [PATCH v11 3/9] ARM: exynos4210: UART support

2012-02-01 Thread Peter Maydell
On 30 January 2012 07:38, Evgeny Voevodin wrote: > From: Maksim Kozlov > > Add basic support of exynos4210 UART > > Signed-off-by: Maksim Kozlov > Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > On 2012-02-01 15:02, Erik Rull wrote: > > > > On February 1, 2012 at 2:40 PM Avi Kivity wrote: > > > >> On 02/01/2012 02:52 PM, Erik Rull wrote: > >>> Hi all, > >>> > >>> first of all I'm a bit confused: > >>> > >>> What is the difference betw

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 16:43, Erik Rull wrote: > On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > >> On 2012-02-01 15:02, Erik Rull wrote: >>> >>> On February 1, 2012 at 2:40 PM Avi Kivity wrote: >>> On 02/01/2012 02:52 PM, Erik Rull wrote: > Hi all, > > first of all I'm a bit confus

[Qemu-devel] [Bug 441672] Re: Windos XP BSOD with HP Photosmart usb device attached

2012-02-01 Thread Erik Rull
Please use qemu-1.0 + ehci. The UHCI layer seems to cause this problem when handling some USB 2.0 devices. I had similar problems but with EHCI + qemu-1.0 it was fixed. See docs/usb2.txt for USB 2.0 support. -- You received this bug notification because you are a member of qemu- devel-ml, which i

[Qemu-devel] [Bug 924943] [NEW] usb-host devices given by command line are routed incomplete to the guest

2012-02-01 Thread Erik Rull
Public bug reported: affected qemus: qemu-1.0, qemu-kvm-1.0, qemu and qemu-kvm master branches (older versions not tested) affected guests: linux, windows test hardware: standard usb key (or any other piece of USB hardware) that works perfectly when plugged in after guest bootup Several Sequenc

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 5:01 PM Jan Kiszka wrote: > On 2012-02-01 16:43, Erik Rull wrote: > > On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > > > >> On 2012-02-01 15:02, Erik Rull wrote: > >>> > >>> On February 1, 2012 at 2:40 PM Avi Kivity wrote: > >>> > On 02/01/2012 02:52 PM, Erik R

Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Peter Maydell
On 30 January 2012 07:38, Evgeny Voevodin wrote: > Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH RFC v2 5/8] target-arm: Introduce QOM CPU and use it for CPUID lookup

2012-02-01 Thread Andreas Färber
Am 01.02.2012 13:57, schrieb Andreas Färber: > +/* CPU models */ > + > +typedef struct ARMCPUInfo { > +const char *name; > +const char *alias; > +uint32_t id; > +} ARMCPUInfo; > + > +static const ARMCPUInfo arm_cpus[] = { > +{ > +.name = "pxa270-a0", > +.alias = "px

Re: [Qemu-devel] [PATCH v11 5/9] ARM: exynos4210: basic Power Management Unit implementation

2012-02-01 Thread Peter Maydell
On 30 January 2012 07:38, Evgeny Voevodin wrote: > From: Maksim Kozlov > > Patch adds basic model for Exynos4210 SoC PMU. > This model implements PMU registers just as a bulk of memory. Currently, > the only reason this device exists is that secondary CPU boot loader > uses PMU INFORM5 register a

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Charles Arnold
>>> On 2/1/2012 at 05:15 AM, in message <4f292cd0.20...@redhat.com>, Kevin Wolf wrote: > Am 01.02.2012 00:04, schrieb Charles Arnold: >> Thanks Andreas, >> >> The 'TODO uuid is missing' comment in the patch is from the >> original sources (as well as many '//' comments). The vhd footer >> and

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Stefan Weil
Am 01.02.2012 17:51, schrieb Charles Arnold: On 2/1/2012 at 05:15 AM, in message<4f292cd0.20...@redhat.com>, Kevin Wolf wrote: Am 01.02.2012 00:04, schrieb Charles Arnold: Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original sources (as we

[Qemu-devel] [PATCH] target-arm/helper.c: tb_flush() on CPU reset

2012-02-01 Thread Peter Maydell
Since target-arm has some CPUState fields for which we take the approach of baking assumptions about them into translated code and then calling tb_flush() when the fields change, we must also tb_flush on CPU reset, because reset is a change of those fields. Signed-off-by: Peter Maydell --- targe

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Grant Likely
On Tue, Jan 31, 2012 at 6:44 PM, Alexander Graf wrote: > > On 01.02.2012, at 02:35, Paul Brook wrote: > >>> We could also just change machine->init() and pass the dtb in there. In a >>> QOM world these would become machine device properties anyways. >>> >>>    machine->init(ram_size, boot_devices,

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2012-02-01 Thread sydenis
two years passed... nothihg changed qemu 0.14.1+win7(32/64) the problem persist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/685096 Title: USB Passthrough not working for Windows 7 guest Sta

Re: [Qemu-devel] virtual pc hash table vs physical pc hash table

2012-02-01 Thread 陳韋任
On Fri, Jan 20, 2012 at 08:49:56AM -0500, Xin Tong wrote: > maybe one of the reasons of having the virtual pc hash table is that > the pc does not need to be tranlated to a physical pc which is used in > the physical pc hash table. Take context switch as an example. Before context switching, you

[Qemu-devel] improve your site

2012-02-01 Thread Victoria Jacobs
Hi, Let me take this opportunity to introduce myself, I'm Victoria Jacobs and as Search Engine Optimizer I manage & run a large selection of quality sites in different topics. While working on one of my project sites I've found  planet-ltc.org  and I believe that with my help you can reach highe

Re: [Qemu-devel] [RFC] CODING_STYLE: Clarify style for enum and function type names

2012-02-01 Thread Peter Maydell
Ping^2 and cc'ing trivial. -- PMM On 23 January 2012 14:12, Peter Maydell wrote: > Since nobody seems to have disagreed, perhaps we should > just commit this? > > -- PMM > > On 13 January 2012 20:29, Peter Maydell wrote: >> Clarify that enum type names and function type names should follow >> t

Re: [Qemu-devel] [PATCH] w32: Initialise critical section before starting thread (fix #922131)

2012-02-01 Thread Roy Tam
Hi, 2012/1/31 Stefan Weil : > This patch was contributed by Bogdan Harjoc. I added some assertions. > > Signed-off-by: Stefan Weil [snip] Thanks, it starts now but I hit another crash: GNU gdb (GDB) 7.3 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

[Qemu-devel] [PATCH] Makefile: Remove linux-headers/asm symlink on distclean

2012-02-01 Thread Peter Maydell
configure creates a linux-headers/asm symlink. Remove this when doing a distclean. Signed-off-by: Peter Maydell --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index d172cbf..2560b59 100644 --- a/Makefile +++ b/Makefile @@ -233,6 +233,7 @

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:52, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > > What is the difference between qemu with command line option --enable-kvm > and qemu-kvm? > It seems to be a difference in code so far, from the performance point of > view it seems to be the same... > > No

Re: [Qemu-devel] [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > This patch adds code to the code for the powernv platform to create > and populate isolation groups on hardware using the p5ioc2 PCI host > bridge used on some IBM POWER systems. > > Signed-off-by: Alexey Kardashevskiy > Signed-off-by: Davi

Re: [Qemu-devel] [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 11:58 -0700, Alex Williamson wrote: > On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > > This patch adds code to the code for the powernv platform to create > > and populate isolation groups on hardware using the p5ioc2 PCI host > > bridge used on some IBM POWER system

Re: [Qemu-devel] [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > This patch adds code to the code for the powernv platform to create > and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host > bridge used on some IBM POWER systems. > > Signed-off-by: Alexey Kardashevskiy > Signed-of

Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Andreas Färber
Am 30.01.2012 08:38, schrieb Evgeny Voevodin: > Signed-off-by: Evgeny Voevodin > --- > diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c > new file mode 100644 > index 000..4d41a1a > --- /dev/null > +++ b/hw/exynos4210_combiner.c > +static const VMStateDescription VMState_Exyn

Re: [Qemu-devel] [PATCH 09/23] qdev: kill of DeviceInfo

2012-02-01 Thread Peter Maydell
On 30 January 2012 21:08, Anthony Liguori wrote: > Subject: [PATCH 09/23] qdev: kill of DeviceInfo "kill off". -- PMM

Re: [Qemu-devel] [PATCH 21/23] object: sure up reference counting

2012-02-01 Thread Peter Maydell
Subject: [PATCH 21/23] object: sure up reference counting On 30 January 2012 21:08, Anthony Liguori wrote: > Subject: [PATCH 21/23] object: sure up reference counting "shore up", apparently, although I found that sufficiently unlikely in this context that it might be better to reword completely

Re: [Qemu-devel] [PATCH 22/23] container: make a decendent of Object

2012-02-01 Thread Peter Maydell
On 30 January 2012 21:09, Anthony Liguori wrote: > Subject: [PATCH 22/23] container: make a decendent of Object "descendant". -- PMM

[Qemu-devel] [PATCH 00/22] qom: use Type system to register all devices (v2)

2012-02-01 Thread Anthony Liguori
This is the 3rd QOM series. All known issues have been resolved. This has been extensively tested (including for bisectability). I think this is ready to apply. The goal of this series is to make DeviceState a first class QOM base class. The result is that you can object_new(TYPE_E1000) and hav

[Qemu-devel] [PATCH 02/22] usb: separate out legacy usb registration from type registration

2012-02-01 Thread Anthony Liguori
Type registeration is going to get turned into a QOM call so decouple the legacy support. Signed-off-by: Anthony Liguori --- hw/usb-audio.c |3 ++- hw/usb-bt.c |2 +- hw/usb-bus.c| 22 -- hw/usb-ccid.c |3 ++- hw/usb-hid.c|9 ++--- hw/usb-

[Qemu-devel] [PATCH 10/22] qdev: kill off DeviceInfo

2012-02-01 Thread Anthony Liguori
It is no longer used in the tree since everything is done natively through QEMU Object Model. Signed-off-by: Anthony Liguori --- hw/i2c.c |2 +- hw/ide/qdev.c |2 +- hw/intel-hda.c |2 +- hw/isa-bus.c |2 +- hw/pci.c |2 +

[Qemu-devel] [PATCH 21/22] object: sure up reference counting

2012-02-01 Thread Anthony Liguori
Now we have the following behavior: 1) object_new() returns an object with ref = 1 2) object_initialize() does not increase the reference count (ref may be 0). 3) object_deref() will finalize the object when ref = 0. it does not free the memory associated with the object. 4) both link and chil

[Qemu-devel] [PATCH 20/22] info qdm: do not require a parent_bus to be set

2012-02-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev-monitor.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index a6f0e16..56a3458 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -163,12 +163,14 @@ int qdev_device_help(Q

[Qemu-devel] [PATCH 22/22] container: make a decendent of Object

2012-02-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- v1 -> v2 - Add license (Paolo) --- Makefile.objs |2 +- hw/container.c| 29 - hw/qdev-monitor.c | 14 ++ qom/Makefile |2 +- qom/container.c | 27 +++ qom/object.c

Re: [Qemu-devel] [PATCH 00/23] qom: use Type system to register all devices

2012-02-01 Thread Peter Maydell
On 30 January 2012 21:16, Anthony Liguori wrote: > Patch 8/23 is an automated touch everything patch. It's kind of awkward having a patch series that is both long (number of patches) and wide (patches that require touching/conversion of every device in the tree), because the length means it needs

Re: [Qemu-devel] [PATCH 21/23] object: sure up reference counting

2012-02-01 Thread Anthony Liguori
On 02/01/2012 01:47 PM, Peter Maydell wrote: Subject: [PATCH 21/23] object: sure up reference counting On 30 January 2012 21:08, Anthony Liguori wrote: Subject: [PATCH 21/23] object: sure up reference counting "shore up", apparently, although I found that sufficiently unlikely in this contex

Re: [Qemu-devel] [PATCH 09/23] qdev: kill of DeviceInfo

2012-02-01 Thread Anthony Liguori
On 02/01/2012 01:46 PM, Peter Maydell wrote: On 30 January 2012 21:08, Anthony Liguori wrote: Subject: [PATCH 09/23] qdev: kill of DeviceInfo "kill off". Tanks! Regards, Anthony Liguori -- PMM

[Qemu-devel] [PATCH v4 3/7] i8254: Factor out interface header

2012-02-01 Thread Jan Kiszka
Move the public interface of the PIT into its own header file and update all users. Signed-off-by: Jan Kiszka --- hw/alpha_dp264.c |1 + hw/hpet.c |1 + hw/i82378.c|1 + hw/i8254.c |1 + hw/i8254.h | 54

[Qemu-devel] [PATCH 15/22] qdev: split out UI portions into a new function

2012-02-01 Thread Anthony Liguori
qdev-monitor.c deals with the -device, device_add, and info qdm/qtree interfaces. Signed-off-by: Anthony Liguori --- Makefile.objs |2 +- hw/qdev-monitor.c | 585 + hw/qdev.c | 572 +

Re: [Qemu-devel] [PATCH 17/23] qom: move properties from qdev to object

2012-02-01 Thread Anthony Liguori
On 01/31/2012 01:46 AM, Paolo Bonzini wrote: On 01/30/2012 10:08 PM, Anthony Liguori wrote: This is mostly code movement although not entirely. This makes properties part of the Object base class which means that we can now start using Object in a meaningful way outside of qdev. Can we move th

[Qemu-devel] [PATCH 11/22] qdev: remove baked in notion of aliases (v2)

2012-02-01 Thread Anthony Liguori
Limit them to the device_add functionality. Device aliases were a hack based on the fact that virtio was modeled the wrong way. The mechanism for aliasing is very limited in that only one alias can exist for any device. We have to support it for the purposes of compatibility but we only need to

Re: [Qemu-devel] RFC: Device isolation groups

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > This patch series introduces a new infrastructure to the driver core > for representing "device isolation groups". That is, groups of > devices which can be "isolated" in such a way that the rest of the > system can be protected from them, e

Re: [Qemu-devel] [PATCH 00/23] qom: use Type system to register all devices

2012-02-01 Thread Anthony Liguori
On 02/01/2012 01:55 PM, Peter Maydell wrote: On 30 January 2012 21:16, Anthony Liguori wrote: Patch 8/23 is an automated touch everything patch. It's kind of awkward having a patch series that is both long (number of patches) and wide (patches that require touching/conversion of every device

[Qemu-devel] [PATCH 12/22] qom: add new command to search for types

2012-02-01 Thread Anthony Liguori
This adds a command that allows searching for types that implement a property. This allows you to do things like search for all available PCIDevices. In the future, we'll also have a standard interface for things with a BlockDriverState property that a PCIDevice could implement. This will enable

[Qemu-devel] [PATCH 03/22] qdev: make DeviceInfo private

2012-02-01 Thread Anthony Liguori
Introduce accessors and remove any code that directly accesses DeviceInfo members. Signed-off-by: Anthony Liguori --- hw/pci.c | 13 - hw/qdev-properties.c |4 ++-- hw/qdev.c| 30 +- hw/qdev.h| 24 +

[Qemu-devel] [PATCH v4 0/7] pit, hpet, pcspk: fixes & preparation for KVM

2012-02-01 Thread Jan Kiszka
Changes in V4: - rebased over qom-upstream.13 - comment on rtc_irq_level clearing on reset - fix call to isa_register_ioport by passing the pcspk device Not changed: - PIT pointer property of pcspk (Paolo will port it together with other PROP_PTR users) CC: Paolo Bonzini Jan Kiszka (7):

[Qemu-devel] [PATCH v4 6/7] pcspk: Convert to qdev

2012-02-01 Thread Jan Kiszka
Convert the PC speaker device to a qdev ISA model. Move the public interface to a dedicated header file at this chance. CC: Paolo Bonzini Signed-off-by: Jan Kiszka --- arch_init.c|1 + hw/i82378.c|3 +- hw/mips_jazz.c |3 +- hw/pc.c|3 +- hw/pc.h|4 --

[Qemu-devel] [PATCH 19/22] qdev: implement cleanup logic in finalize

2012-02-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev.c | 57 - 1 files changed, 32 insertions(+), 25 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 8f13e49..e3b53b7 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -247,31 +247,6 @@ void qdev_init_n

Re: [Qemu-devel] [PATCH 17/23] qom: move properties from qdev to object

2012-02-01 Thread Paolo Bonzini
On 02/01/2012 09:01 PM, Anthony Liguori wrote: I think that read-only properties could be interesting for SCSIRequest. For instance, I can imagine having SCSIRequest is-a BlockRequest and having an error property associated with it. That would provide a nice way to have an info io operation that

[Qemu-devel] [PATCH 07/22] qom: allow object_class_foreach to take additional parameters to refine search

2012-02-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- include/qemu/object.h |1 + qom/object.c | 18 -- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index ba37850..adbcfb1 100644 --- a/include/qemu/object.h +++ b/include

[Qemu-devel] [PATCH v4 4/7] i8254: Pass alternative IRQ output object on initialization

2012-02-01 Thread Jan Kiszka
HPET legacy emulation will require control over the PIT IRQ output. To enable this, add support for an alternative IRQ output object to the PIT factory function. If the isa_irq number is < 0, this object will be used. This also removes the IRQ number property from the PIT class as we now use a gen

[Qemu-devel] [PATCH v4 7/7] i8254: Factor out pit_get_channel_info

2012-02-01 Thread Jan Kiszka
Instead of providing 4 individual query functions for mode, gate, output and initial counter state, introduce a service that queries all information at once. This comes with tiny additional costs for pcspk_callback but with a much cleaner interface. Also, it will simplify the implementation of the

[Qemu-devel] [PATCH 16/22] qdev: nuke qdev_init_chardev()

2012-02-01 Thread Anthony Liguori
I'm sure the intentions were good here, but there's no reason this should be in qdev. Move it to qemu-char where it belongs. Signed-off-by: Anthony Liguori --- hw/etraxfs_ser.c |2 +- hw/lm32_juart.c |2 +- hw/lm32_uart.c |2 +- hw/milkymist-uart.c |2 +- hw/pl01

[Qemu-devel] [PATCH 05/22] qdev: allow classes to overload qdev functions

2012-02-01 Thread Anthony Liguori
This allows us to drop per-Device registration functions by allowing the class_init functions to overload qdev methods. Signed-off-by: Anthony Liguori --- hw/qdev.c | 53 + 1 files changed, 33 insertions(+), 20 deletions(-) diff --git a/hw/q

[Qemu-devel] [PATCH 04/22] qdev: remove info from class

2012-02-01 Thread Anthony Liguori
Now DeviceInfo is no longer used after object construction. All of the relevant members have been moved to DeviceClass. Signed-off-by: Anthony Liguori --- hw/pci.c |4 ++- hw/qdev.c | 94 hw/qdev.h | 26 +--- 3 fi

Re: [Qemu-devel] [PATCH 0/3] jazz-led: qdev conversion

2012-02-01 Thread Anthony Liguori
On 01/23/2012 04:34 AM, Hervé Poussineau wrote: Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - convert to qdev Hervé Poussineau (3): jazz-led: use trace framework jazz-led: convert to qdev jazz-led: compile it only twice

[Qemu-devel] [PATCH v4 5/7] i8254: Rework & fix interaction with HPET in legacy mode

2012-02-01 Thread Jan Kiszka
When the HPET enters legacy mode, the IRQ output of the PIT is suppressed and replaced by the HPET timer 0. But the current code to emulate this was broken in many ways. It reset the PIT state after re-enabling, it worked against a stale static PIT structure, and it did not properly saved/restored

[Qemu-devel] [PATCH 06/22] qdev: refactor device creation to allow bus_info to be set only in class

2012-02-01 Thread Anthony Liguori
As we use class_init to set class members, DeviceInfo no longer holds this information. Signed-off-by: Anthony Liguori --- hw/qdev.c | 42 +++--- 1 files changed, 19 insertions(+), 23 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c9f890c..bba84e2 10

[Qemu-devel] [PATCH 14/22] qdev: refactor away qdev_create_from_info

2012-02-01 Thread Anthony Liguori
Note that the FIXME gets fixed in series 4/4. We need to convert BusState to QOM before we can make parent_bus a link. Signed-off-by: Anthony Liguori --- hw/qdev.c | 35 ++- hw/qdev.h |3 +++ 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/

[Qemu-devel] [PATCH 13/22] qdev: split out common init to instance_init

2012-02-01 Thread Anthony Liguori
This gets us closer to being able to object_new() a qdev type and have a functioning object verses having to call qdev_create(). Signed-off-by: Anthony Liguori --- hw/qdev.c | 41 - 1 files changed, 28 insertions(+), 13 deletions(-) diff --git a/hw/qdev

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-01 Thread Alexander Graf
On 01.02.2012, at 18:38, Grant Likely wrote: > On Tue, Jan 31, 2012 at 6:44 PM, Alexander Graf wrote: >> >> On 01.02.2012, at 02:35, Paul Brook wrote: >> We could also just change machine->init() and pass the dtb in there. In a QOM world these would become machine device properties a

[Qemu-devel] [PATCH v4 1/7] i8254: Do not raise IRQ level on reset

2012-02-01 Thread Jan Kiszka
Avoid changing the IRQ level to high on reset as it may trigger spurious events. Instead, open-code the effects of pit_load_count(0) in the reset handler. Signed-off-by: Jan Kiszka --- hw/i8254.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/i8254.c b/hw/i825

Re: [Qemu-devel] [PATCH 07/22] qom: allow object_class_foreach to take additional parameters to refine search

2012-02-01 Thread Andreas Färber
Am 01.02.2012 20:50, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori Reviewed-by: Andreas Färber Thanks, Andreas > --- > include/qemu/object.h |1 + > qom/object.c | 18 -- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/include/q

[Qemu-devel] [PATCH 08/22] qdev: kill off DeviceInfo list

2012-02-01 Thread Anthony Liguori
Teach the various bits of code that need to walk through available devices to do so via QOM. Signed-off-by: Anthony Liguori --- hw/qdev.c | 87 + hw/qdev.h |2 - hw/ssi.c |2 +- 3 files changed, 31 insertions(+), 60 deletions(

[Qemu-devel] [PATCH 01/22] usb-hid: simplify class initialization a bit

2012-02-01 Thread Anthony Liguori
We can probably model USBHidDevice as a base class to get even better code sharing but for now, just use a common function to initialize the common class members. Signed-off-by: Anthony Liguori --- hw/usb-hid.c | 27 +-- 1 files changed, 13 insertions(+), 14 deletions(-

[Qemu-devel] [PATCH 18/22] qom: accept any compatible type when setting a link property

2012-02-01 Thread Anthony Liguori
Links had limited utility before as they only allowed a concrete type to be specified. Now we can support abstract types and interfaces which means it's now possible to have a link. Signed-off-by: Anthony Liguori --- qom/object.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-

[Qemu-devel] [PATCH v4 2/7] hpet: Save/restore cached RTC IRQ level

2012-02-01 Thread Jan Kiszka
In legacy mode, the HPET suppresses the RTC interrupt delivery via IRQ 8 but keeps track of the RTC output level and applies it when legacy mode is turned off again. This value has to be preserved across save/ restore as it cannot be reconstructed otherwise. To document that a raised rtc_irq_level

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a difference in code so far, from the performance point of view it seems to be the same...

  1   2   >