[Qemu-devel] [PATCH] AHCI: Fix port reset race

2012-01-30 Thread Alexander Graf
bdrv_aio_cancel() can trigger bdrv_aio_flush() which makes all aio that is currently in flight finish. So what we do is: port reset detect ncq in flight cancel ncq delete ncq sg list at which point we have double freed the sg list. Instead, with this patch we do: port reset detect nc

Re: [Qemu-devel] [PATCH 08/23] qdev: register all types natively through QEMU Object Model

2012-01-30 Thread Peter Maydell
On 30 January 2012 21:08, Anthony Liguori wrote: > This was done in a mostly automated fashion.  I did it in three steps and then > rebased it into a single step which avoids repeatedly touching every file in > the tree. > > The first step was a sed-based addition of the parent type to the subclas

Re: [Qemu-devel] [PATCH 03/23] qdev: make DeviceInfo private

2012-01-30 Thread Andreas Färber
Am 30.01.2012 22:08, schrieb Anthony Liguori: > Introduce accessors and remove any code that directly accesses DeviceInfo > members. > > Signed-off-by: Anthony Liguori Reviewed-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer

[Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-01-30 Thread Alexander Graf
When using Windows 8 with an AHCI disk drive, it issues a blue screen. The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not supported by our ATA implementation, but Windows expects it to be there. Since without security stuff implemented, the lock would be a nop anyway and CFA_WEAR_

Re: [Qemu-devel] [PATCH 08/23] qdev: register all types natively through QEMU Object Model

2012-01-30 Thread Anthony Liguori
On 01/30/2012 04:29 PM, Peter Maydell wrote: On 30 January 2012 21:08, Anthony Liguori wrote: This was done in a mostly automated fashion. I did it in three steps and then rebased it into a single step which avoids repeatedly touching every file in the tree. The first step was a sed-based add

Re: [Qemu-devel] [PATCH 00/23] qom: use Type system to register all devices

2012-01-30 Thread Anthony Liguori
On 01/30/2012 03:16 PM, Anthony Liguori wrote: (Sorry for not posting this correctly, I didn't want to spam the list with a second submission) This is the 3rd QOM series. I decided to post this even though there's a known issue with device_del as I wanted to give people more time to review what'

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2012-01-30 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu Lucid) Status: Won't Fix => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Status in libvirt virtualization API: U

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2012-01-30 Thread David Gibson
On Wed, Jan 25, 2012 at 04:44:53PM -0700, Alex Williamson wrote: > On Wed, 2012-01-25 at 14:13 +1100, David Gibson wrote: > > On Tue, Dec 20, 2011 at 09:30:37PM -0700, Alex Williamson wrote: > > > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > > > > On Mon, Dec 19, 2011 at 04:41:56PM +010

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Andreas Färber
Am 30.01.2012 19:55, schrieb Juan Quintela: > Please send in any agenda items you are interested in covering. QOM roadmap update: * Series 3/4 is on the list. -> Please officially designate a merge date (Friday?). -> To make review sensible, I ask for a hard device freeze until merged. I.e., no

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Anthony Liguori
On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. QOM roadmap update: * Series 3/4 is on the list. -> Please officially designate a merge date (Friday?). -> To make review sensible, I ask

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Alexander Graf
On 31.01.2012, at 00:53, Anthony Liguori wrote: > On 01/30/2012 05:41 PM, Andreas Färber wrote: >> Am 30.01.2012 19:55, schrieb Juan Quintela: >>> Please send in any agenda items you are interested in covering. >> >> QOM roadmap update: >> * Series 3/4 is on the list. >> -> Please officially de

[Qemu-devel] [Bug 913774] Re: device can't be hot-removed from the guest

2012-01-30 Thread Yongjie Ren
fixed by the following commit. commit 024a6fbdb9d8cbc4d7f833b23db51c9d1004bc47 Author: Anthony Liguori Date: Fri Jan 13 07:45:55 2012 -0600 qdev: fix device_del by refactoring reference counting Commit 8eb0283 broken device_del by having too overzealous reference counting checks.

Re: [Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-01-30 Thread Fernando Luis Vázquez Cao
Hi Igor, Thank you for the prompt reply. I really appreciate it. (2012年01月31日 02:28), Igor Kovalenko wrote: 2012/1/30 Fernando Luis Vázquez Cao: Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the

Re: [Qemu-devel] [RFC][PATCH 00/15 v5] introducing a new, dedicated memory dump mechanism

2012-01-30 Thread Wen Congyang
At 01/31/2012 01:38 AM, Eric Blake Wrote: > On 01/29/2012 10:40 PM, Wen Congyang wrote: Yes, it may tak a lot of time. But we dump a guest memory when the guest panics, and there is no need to continue to run the guest. >>> >>> Would it be possible to have both a dump from a certain point

Re: [Qemu-devel] [RFC][PATCH 09/15] introduce a new monitor command 'dump' to dump guest's memory

2012-01-30 Thread Wen Congyang
At 01/31/2012 01:19 AM, Eric Blake Wrote: > On 01/29/2012 10:36 PM, Wen Congyang wrote: +++ b/hmp-commands.hx @@ -828,6 +828,22 @@ new parameters (if specified) once the vm migration finished successfully. ETEXI { +.name = "dump", +

[Qemu-devel] [Bug 912612] Re: rhel5u5 guest panic when booting up

2012-01-30 Thread Yongjie Ren
Already fixed. pls. track the following bug. https://bugzilla.kernel.org/show_bug.cgi?id=42563 ** Bug watch added: Linux Kernel Bug Tracker #42563 http://bugzilla.kernel.org/show_bug.cgi?id=42563 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

[Qemu-devel] [PATCH 4/7] PPC: Enable doorbell excp handlers

2012-01-30 Thread Alexander Graf
We already had all the code available to have doorbell exceptions be handled properly. It was just disabled. Enable it, so we can rely on it. Signed-off-by: Alexander Graf --- target-ppc/helper.c | 16 ++-- 1 files changed, 2 insertions(+), 14 deletions(-) diff --git a/target-ppc

[Qemu-devel] [PATCH 1/7] PPC: E500: Add some more excp vectors

2012-01-30 Thread Alexander Graf
Our EXCP list is getting outdated. By now, 3 new exception vectors have been introduced. Update the list so we have everything at one place. Signed-off-by: Alexander Graf --- target-ppc/cpu.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-p

[Qemu-devel] [PATCH] PPC: E500: Populate L1CFG0 SPR

2012-01-30 Thread Alexander Graf
When running Linux on e500 with powersave-nap enabled, Linux tries to read out the L1CFG0 register and calculates some things from it. Passing 0 there ends up in a division by 0, resulting in -1, resulting in badness. So let's populate the L1CFG0 register with reasonable defaults. That way guests

[Qemu-devel] [PATCH 5/7] PPC: E500: Implement msgclr

2012-01-30 Thread Alexander Graf
This patch implements the msgclr instruction. It is part of the Embedded.Processor Control specification and clears pending doorbell interrupts on the current CPU. Signed-off-by: Alexander Graf --- target-ppc/helper.h|1 + target-ppc/op_helper.c | 35 +++

[Qemu-devel] [PATCH 2/7] PPC: E500: Add doorbell defines

2012-01-30 Thread Alexander Graf
We're going to introduce doorbell instructions (called processor control in the spec) soon. Add some defines for easier patch readability later. Signed-off-by: Alexander Graf --- target-ppc/cpu.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/target-ppc/

[Qemu-devel] [PATCH 3/7] PPC: Add CPU feature for processor control

2012-01-30 Thread Alexander Graf
We're soon going to implement processor control features. Add the feature flag, so we're well prepared. Signed-off-by: Alexander Graf --- target-ppc/cpu.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index f9cea3d..fbcf488 100644

[Qemu-devel] [PATCH 0/7] Enable doorbell for e500mc

2012-01-30 Thread Alexander Graf
On e500mc we need to implement the doorbell / processor control / msgsnd instructions to allow for smp with Linux guests. This patch set implements everything necessary for this to work. Alexander Graf (7): PPC: E500: Add some more excp vectors PPC: E500: Add doorbell defines PPC: Add CPU fe

[Qemu-devel] [PATCH 7/7] PPC: e500mc: Enable processor control

2012-01-30 Thread Alexander Graf
The e500mc implements Embedded.Processor Control, so enable it and thus enable guests to IPI each other. This makes -smp work with -cpu e500mc. Signed-off-by: Alexander Graf --- target-ppc/translate_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/trans

[Qemu-devel] [PATCH 6/7] PPC: E500: Implement msgsnd

2012-01-30 Thread Alexander Graf
This patch implements the msgsnd instruction. It is part of the Embedded.Processor Control specification and allows one CPU to IPI another CPU without going through an interrupt controller. Signed-off-by: Alexander Graf --- target-ppc/helper.h|1 + target-ppc/op_helper.c | 18 +

[Qemu-devel] buildbot failure in qemu on pci_i386_debian_6_0

2012-01-30 Thread qemu
The Buildbot has detected a new failure on builder pci_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_i386_debian_6_0/builds/169 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason

[Qemu-devel] buildbot failure in qemu on pci_x86_64_debian_6_0

2012-01-30 Thread qemu
The Buildbot has detected a new failure on builder pci_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_6_0/builds/168 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

Re: [Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-01-30 Thread Fernando Luis Vázquez Cao
(2012年01月31日 13:12), Igor Kovalenko wrote: 2012/1/30 Fernando Luis Vázquez Cao: Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the RxOverflow bit in the interrupt mask. Unfortunately rtl8139's can_re

[Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2012-01-30 Thread Henrique Rodrigues
Hi, I figured out what was the problem. It seems that the pkts generated by each guest iperf command is bigger than the default qdisc mtu of 2kb (the pkts have length of 65k). If you set a higher qdisc mtu (=65k) the traffic should be controlled as expected. Henrique -- You received this bug n

[Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-30 Thread Richard Yang
Hi, experts I am just coming to the qemu world. While reading the code, I am wondering why put a struct definition in the c file? Seems there is no error in compile, while I felt it is not a proper way to do it. -- Richard Yang Help you, Help me

Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-30 Thread Mulyadi Santosa
Hi :) On Tue, Jan 31, 2012 at 12:55, Richard Yang wrote: > > Hi, experts > > I am just coming to the qemu world. > > While reading the code, I am wondering why put a struct definition in the > c file? > > Seems there is no error in compile, while I felt it is not a proper way > to do it. maybe

[Qemu-devel] [PATCH] w32: Initialise critical section before starting thread (fix #922131)

2012-01-30 Thread Stefan Weil
This patch was contributed by Bogdan Harjoc. I added some assertions. Signed-off-by: Stefan Weil --- qemu-thread-win32.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c index fe9b931..3524c8b 100644 --- a/qemu-thread-win3

Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-30 Thread Richard Yang
On Tue, Jan 31, 2012 at 01:12:24PM +0700, Mulyadi Santosa wrote: >Hi :) > >On Tue, Jan 31, 2012 at 12:55, Richard Yang wrote: >> >> Hi, experts >> >> I am just coming to the qemu world. >> >> While reading the code, I am wondering why put a struct definition in the >> c file? >> >> Seems there is

Re: [Qemu-devel] [PATCH 0/4] Use rtc_clock uniformly for ARM

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 06:21 PM, Peter Maydell wrote: My timer-fu is weak so I'm not going to claim to have actually reviewed these, but they don't look to be obviously wrong. Are you hoping for these to go in via the arm-devs tree? Yes... You'll need to rebase following the QOM series landing. Gah,

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 08:28 PM, Anthony Liguori wrote: I see. It shouldn't surprise you that I completely disagree with Anthony on this. :) Give me some credit at least... The original patches didn't disable the RTC, it introduced a half-neutered Xen specific RTC. Ah. :) My original suggestion (w

Re: [Qemu-devel] [PATCH 10/23] qdev: remove baked in notion of aliases

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 PM, Anthony Liguori wrote: +/* + * Aliases were a bad idea from the start. Let's keep them + * from spreading further. + */ +static const char *qdev_class_get_alias(DeviceClass *dc) +{ +const char *typename = object_class_get_name(OBJECT_CLASS(dc)); + +if (strcmp(type

Re: [Qemu-devel] [PATCH 17/23] qom: move properties from qdev to object

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 PM, Anthony Liguori wrote: This is mostly code movement although not entirely. This makes properties part of the Object base class which means that we can now start using Object in a meaningful way outside of qdev. Can we move them to an intermediate base class? I would li

Re: [Qemu-devel] [PATCH 21/23] object: sure up reference counting

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 PM, Anthony Liguori wrote: Now we have the following behavior: 1) object_new() returns an object with ref = 1 2) object_initialize() does not increase the reference count (ref may be 0). 3) object_deref() will finalize the object when ref = 0. it does not free the memory

Re: [Qemu-devel] [PATCH 22/23] container: make a decendent of Object

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:09 PM, Anthony Liguori wrote: diff --git a/qom/container.c b/qom/container.c new file mode 100644 index 000..39d7b1e --- /dev/null +++ b/qom/container.c @@ -0,0 +1,15 @@ +#include "qemu/object.h" +#include "module.h" + +static TypeInfo container_info = { +.name =

<    1   2