Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Luiz Capitulino
On Fri, 6 Jan 2012 17:05:53 + "Daniel P. Berrange" wrote: > On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: > > On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: > > >On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: > > >>On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Igor Mitsyanko
On 01/06/2012 10:45 PM, Peter Maydell wrote: On 6 January 2012 18:37, Igor Mitsyanko wrote: On 01/06/2012 12:02 AM, Mark Langsdorf wrote: +if (!cpu_model) { +cpu_model = "cortex-a9"; +} Google said there is only cortexA9-based Highbank SoC version, maybe you should just hard

Re: [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts

2012-01-06 Thread Anthony Liguori
On 01/06/2012 12:47 PM, Peter Maydell wrote: Fix a compile failure on 32 bit hosts (integer constant is too large for 'unsigned long' type) by correcting a typo where the mask used for filling in the second f_fsid word had too many 'F's in it. Also drop the 'L' suffix that allowed this typo to go

Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend

2012-01-06 Thread Kamil Rytarowski
W dniu 29.11.2011 20:55, Benjamin pisze: Signed-off-by: Benjamin --- net.c |6 - net/socket.c| 73 +- qemu-options.hx |2 + 3 files changed, 78 insertions(+), 3 deletions(-) diff --git a/net.c b/net.c index cb52

[Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-06 Thread Peter Maydell
Use the new memory mutator API to simplify the flash remap code; this allows us to drop the flash_mapped flag. Signed-off-by: Peter Maydell --- hw/integratorcp.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp

[Qemu-devel] [PATCH v4 1/2] hw/integratorcp: Fix sense of REMAP bit

2012-01-06 Thread Peter Maydell
Fix the sense of the REMAP bit: 0 should mean "map flash", 1 should mean "map RAM". Signed-off-by: Peter Maydell --- hw/integratorcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index c8f3955..d9d8da3 100644 --- a/hw/integrator

Re: [Qemu-devel] Incorrect hw/omap_dss.c:chip[] index for RFBI_READ and RFBI_STATUS?

2012-01-06 Thread andrzej zaborowski
Hi, On 6 January 2012 17:55, Stefan Hajnoczi wrote: > Is the following code correct in hw/omap_dss.c: > > case 0x58:  /* RFBI_READ */ >    if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0]) >        s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1); >    else if ((s->rfbi.contro

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Luiz Capitulino
On Fri, 06 Jan 2012 09:08:19 -0600 Anthony Liguori wrote: > On 01/06/2012 06:45 AM, Luiz Capitulino wrote: > > On Fri, 6 Jan 2012 11:06:12 + > > Stefan Hajnoczi wrote: > > > >> Proper async support - if you mean the ability to have multiple QMP > >> commands pending at a time - is harder tha

Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend

2012-01-06 Thread Stefan Hajnoczi
On Fri, Jan 6, 2012 at 7:16 PM, Kamil Rytarowski wrote: > ping! Looks good to me. Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Andreas Färber
Am 06.01.2012 16:19, schrieb Anthony Liguori: > I'd like to start a more formal and transparent security audit of QEMU. > The way I'd imagine it working is something like this: I'd like to propose something else: We should define a more formal process for reviewing and applying patches in the fir

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Michael Roth
On 01/06/2012 01:06 PM, Luiz Capitulino wrote: On Fri, 6 Jan 2012 17:05:53 + "Daniel P. Berrange" wrote: On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: On 01/05

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Andreas Färber
Am 06.01.2012 20:10, schrieb Igor Mitsyanko: > On 01/06/2012 10:45 PM, Peter Maydell wrote: >> On 6 January 2012 18:37, Igor Mitsyanko wrote: >>> On 01/06/2012 12:02 AM, Mark Langsdorf wrote: +if (!cpu_model) { +cpu_model = "cortex-a9"; +} >>> >>> >>> Google said the

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Luiz Capitulino
On Fri, 06 Jan 2012 14:09:41 -0600 Michael Roth wrote: > On 01/06/2012 01:06 PM, Luiz Capitulino wrote: > > On Fri, 6 Jan 2012 17:05:53 + > > "Daniel P. Berrange" wrote: > > > >> On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: > >>> On 01/06/2012 04:56 AM, Daniel P. Berrange wr

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Anthony Liguori
On 01/06/2012 02:02 PM, Andreas Färber wrote: Am 06.01.2012 16:19, schrieb Anthony Liguori: I'd like to start a more formal and transparent security audit of QEMU. The way I'd imagine it working is something like this: I'd like to propose something else: We should define a more formal process

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-06 Thread Michael Roth
On 01/06/2012 01:04 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 15:41:33 -0600 Michael Roth wrote: On 01/05/2012 02:25 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 09:10:50 -0600 Michael Roth wrote: On 01/05/2012 08:42 AM, Luiz Capitulino wrote: On Thu, 5 Jan 2012 12:59:27 + "Da

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Mark Langsdorf
On 01/06/2012 10:29 AM, Peter Maydell wrote: > On 5 January 2012 20:02, Mark Langsdorf wrote: >> +static void hb_regs_write(void *opaque, target_phys_addr_t offset, >> + uint64_t value, unsigned size) >> +{ >> +uint32_t *regs = opaque; >> + >> +if (offset == 0xf00)

[Qemu-devel] [PATCH v2 3/3] MAINTAINERS: Add PCI host bridge files to PReP machine

2012-01-06 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 764c92d..6e9cd33 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -307,6 +307,7 @@ PReP M: Andreas Färber S: Odd Fixes F: hw/ppc_prep.c +F: hw/pr

[Qemu-devel] [PATCH v2 0/3] qdev'ify PReP PCI host bridge

2012-01-06 Thread Andreas Färber
Hello Anthony and Hervé, Here's my rebased qdev'ification of PReP PCI host. It is tested not to make things worse than they are already. I've split up my original patch and did some renaming to make it better readable. Please compare it to yours; it is intended to go in before the second QOM s

[Qemu-devel] [PATCH v2 1/3] prep: qdev'ify Raven host bridge

2012-01-06 Thread Andreas Färber
Move initialization of vendor ID, etc. to PCIDeviceInfo. Add VMState. Signed-off-by: Andreas Färber Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 55 ++- 1 files changed, 46 insertions(+), 9 deletions(

[Qemu-devel] [PATCH v2 2/3] prep: Add Raven PCI host SysBus device

2012-01-06 Thread Andreas Färber
For now, focus on qdev'ification and leave PIC IRQs unchanged. Signed-off-by: Andreas Färber Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 41 +++-- 1 files changed, 31 insertions(+), 10 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH 04/30] ppc_prep: convert host bridge to qdev

2012-01-06 Thread Andreas Färber
Am 03.01.2012 15:57, schrieb Andreas Färber: > Am 03.01.2012 01:51, schrieb Anthony Liguori: >> Untested beyond compile. But it's a very simple conversion. >> >> Signed-off-by: Anthony Liguori > > Seems like we've crossed paths now. I have a more complete patch using > different naming Minimal

[Qemu-devel] [Bug 912983] [NEW] Unable to install OS/2 Warp v3 past disk 2

2012-01-06 Thread multitude
Public bug reported: To whom it may concern, As you may (or may not) be aware, QEMU is currently unable to readily install OS/2 Warp v3 (OS2W3) when asked for Installation Diskette 2 (http://www.claunia.com/qemu/objectManager.php?sClass=version&iId=132&iTestingId=138). QEMU 0.8.2 is the last kno

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-06 Thread Kevin O'Connor
On Fri, Jan 06, 2012 at 07:27:25AM +0200, Gleb Natapov wrote: > On Thu, Jan 05, 2012 at 09:05:39PM -0500, Kevin O'Connor wrote: > > SeaBIOS could probably fall back to the harddrive priority if it finds > > a BCV without an explicit bootindex priority. > The same option rom probably will register b

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Peter Maydell
On 6 January 2012 20:42, Anthony Liguori wrote: > On 01/06/2012 02:02 PM, Andreas Färber wrote: >> i) Unless it's a build fix, I propose defining a minimum review time >> before a patch is applied to a (sub)maintainer's queue. > I disagree here.  If anything, I think we wait a bit too long for pe

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 20:11, Andreas Färber wrote: > Not sure how hardcoding the cpu_model would work with CPU features, > would they be still included or stripped out before. Peter? Interesting question. It's certainly more likely to work to have a board where the only tweak you made to the CPU was

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 21:16, Mark Langsdorf wrote: > Assuming that I'm going to need save/restore support, what's > the proper syntax for saving uint32_t *regs? All the uses I > can find seem to be for an array of structs, not an array > of ints, and I keep hoping there's a simpler way. VMSTATE_UINT3

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Andreas Färber
Am 07.01.2012 04:14, schrieb Peter Maydell: > On 6 January 2012 20:11, Andreas Färber wrote: >> Not sure how hardcoding the cpu_model would work with CPU features, >> would they be still included or stripped out before. Peter? > > Interesting question. It's certainly more likely to work to have >

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-06 Thread Andreas Färber
Am 06.01.2012 19:58, schrieb Peter Maydell: > Use the new memory mutator API to simplify the flash remap code; > this allows us to drop the flash_mapped flag. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber I noticed you're dropping a comment about tlb_flush(). Is that because it

Re: [Qemu-devel] [PATCH 01/16] memory: move endianness compensation to memory core

2012-01-06 Thread Andreas Färber
Am 02.01.2012 17:33, schrieb Avi Kivity: > Instead of doing device endianness compensation in cpu_register_io_memory(), > do it in the memory core. > > Signed-off-by: Avi Kivity > diff --git a/exec.c b/exec.c > index 28c057c..507d37c 100644 > --- a/exec.c > +++ b/exec.c > @@ -3666,30 +3565,14 @

Re: [Qemu-devel] [PATCH 13/16] Direct dispatch through MemoryRegion

2012-01-06 Thread Andreas Färber
Am 02.01.2012 17:33, schrieb Avi Kivity: > Now that all mmio goes through MemoryRegions, we can convert > io_mem_opaque to be a MemoryRegion pointer, and remove the thunks > that convert from old-style CPU{Read,Write}MemoryFunc to MemoryRegionOps. > > Signed-off-by: Avi Kivity > diff --git a/mem

<    1   2