Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-06 Thread Gerhard Wiesinger
On Thu, 5 Jan 2012, Kevin O'Connor wrote: On Thu, Jan 05, 2012 at 08:39:15AM +0100, Gerhard Wiesinger wrote: BTW: I didn't get any answer to the following thread: https://lists.gnu.org/archive/html/qemu-devel/2011-11/msg00602.html Odd - that email never made it to my inbox. Anyway, Gerd repo

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-06 Thread Gerd Hoffmann
On 01/06/12 09:20, Gerhard Wiesinger wrote: > On Thu, 5 Jan 2012, Kevin O'Connor wrote: > >> On Thu, Jan 05, 2012 at 08:39:15AM +0100, Gerhard Wiesinger wrote: >>> BTW: I didn't get any answer to the following thread: >>> https://lists.gnu.org/archive/html/qemu-devel/2011-11/msg00602.html >> >> Od

Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

2012-01-06 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 06:33:27PM +0200, Avi Kivity wrote: > These aren't real > regions, since they are never added to the memory hierarchy, but they > allow reuse of the dispatch functionality. This would be great as a comment... > +extern struct MemoryRegion io_mem_ram; > +extern struct Memor

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2012-01-06 Thread Stefan Hajnoczi
On Thu, Jan 05, 2012 at 01:46:08PM -0200, Marcelo Tosatti wrote: > On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: > > From: Dong Xu Wang > > > > Introduce a new file format: add-cow. The usage can be found in add-cow.txt > > of > > this patch. > > > > CC: Kevin Wolf > > CC: Stef

Re: [Qemu-devel] usb-ohci: td.cbp incorrectly updated near page end

2012-01-06 Thread Gerd Hoffmann
On 12/22/11 10:34, Andriy Gapon wrote: > The current code that updates the cbp value after a transfer looks like this: > td.cbp += ret; > if ((td.cbp & 0xfff) + ret > 0xfff) { > > because the 'ret' value is effectively added twice the check may fire too > early > when the overflow hasn't ha

Re: [Qemu-devel] [PATCH 2/5] usb-redir: Dynamically adjust iso buffering size based on ep interval

2012-01-06 Thread Gerd Hoffmann
On 12/22/11 12:12, Hans de Goede wrote: > Note the bufpq_target_size id stored in the endpoint info struct, > even though it only used once. This is done because it will be > referenced from other code in a follow up patch. === checkpatch complains === WARNING: braces {} are necessary for all arms

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Jan Kiszka wrote: > On 2012-01-05 15:50, Avi Kivity wrote: > >> Let me summarize what we have come up with so far: > >> > >> - we move the call to xen_register_framebuffer before > >> memory_region_init_ram in vga_common_init; > >> > >> - we prevent xen_ram_alloc from allocating

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Daniel P. Berrange
On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: > On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: > >Hi, all. > > > >I am trying QEMU Guest Agent and encountered a small bug. It is that the > >PIDFILE remains when daemon start fails. And maybe forgotton to g_free(). > > > >MATSUDA, Daik

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Stefan Hajnoczi
On Thu, Jan 5, 2012 at 8:26 PM, Luiz Capitulino wrote: > On Thu, 05 Jan 2012 09:56:44 -0600 > Anthony Liguori wrote: > >> On 01/05/2012 09:35 AM, Eric Blake wrote: >> > On 01/05/2012 07:16 AM, Luiz Capitulino wrote: >> >>> I know.  We're stuck in a hard place here again because NotSupported >> >>

Re: [Qemu-devel] coroutine bug?, was Re: [PATCH] sheepdog: use coroutines

2012-01-06 Thread MORITA Kazutaka
At Tue, 3 Jan 2012 08:13:51 +, Stefan Hajnoczi wrote: > > On Mon, Jan 02, 2012 at 10:38:11PM +, Stefan Hajnoczi wrote: > > On Mon, Jan 2, 2012 at 3:39 PM, Christoph Hellwig wrote: > > > On Fri, Dec 30, 2011 at 10:35:01AM +, Stefan Hajnoczi wrote: > > >> If you can reproduce this bug a

[Qemu-devel] [Bug 502107] Re: qemu-kvm 0.12.1.2 crashes booting Ubuntu 9.10 with "-vga std"

2012-01-06 Thread Claudio Matsuoka
Note: this is already marked as FIXME in kvm-all.c: if (run->internal.suberror == KVM_INTERNAL_ERROR_EMULATION) { fprintf(stderr, "emulation failure\n"); if (!kvm_arch_stop_on_emulation_error(env)) { cpu_dump_state(env, stderr, fprintf, CPU_DUMP_CODE); r

[Qemu-devel] [Bug 502107] Re: qemu-kvm 0.12.1.2 crashes booting Ubuntu 9.10 with "-vga std"

2012-01-06 Thread Claudio Matsuoka
Yes, memory corruption in guest explains the unaligned/out of range pointer error (issued when grub2 releases a block of memory, and grub uses dynamic allocation quite a lot) and the boot loop. This corruption most likely originates in the vga code fixed in revision 2470 as reported in Bug #717445.

Re: [Qemu-devel] [PATCH v2 1/3] qerror: add check-qerror.sh to verify alphabetical order

2012-01-06 Thread Luiz Capitulino
On Wed, 4 Jan 2012 22:23:32 + Stefan Hajnoczi wrote: > We're supposed to keep qerror definitions and table entries in > alphabetical order. In practice this is not checked. > > I haven't found a nice way to integrate this into the makefile yet but > we can at least have this script which v

Re: [Qemu-devel] [PATCH v2 1/3] qerror: add check-qerror.sh to verify alphabetical order

2012-01-06 Thread Stefan Hajnoczi
On Fri, Jan 6, 2012 at 11:59 AM, Luiz Capitulino wrote: > On Wed,  4 Jan 2012 22:23:32 + > Stefan Hajnoczi wrote: > >> We're supposed to keep qerror definitions and table entries in >> alphabetical order.  In practice this is not checked. >> >> I haven't found a nice way to integrate this int

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Avi Kivity
On 01/05/2012 08:49 PM, Jan Kiszka wrote: > To me this still sounds like a cirrus-only xen workaround that > nevertheless spreads widely. It is. > Again, what speaks against migrating the information Xen needs before > creating the machine or a single device? That would only introduce a > generic

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Jan Kiszka
On 2012-01-06 10:19, Avi Kivity wrote: > On 01/05/2012 08:49 PM, Jan Kiszka wrote: >> To me this still sounds like a cirrus-only xen workaround that >> nevertheless spreads widely. > > It is. > >> Again, what speaks against migrating the information Xen needs before >> creating the machine or a s

[Qemu-devel] MMU Modes

2012-01-06 Thread Xin Tong
In qemu soft TLB, there is a MMU modes. what is it and what does it do ? I see target-mips, NB_MMU_MODES is defined to be 3, unfortunately, there is no comments on what each one of them means in the code. Thanks

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Luiz Capitulino
On Fri, 6 Jan 2012 11:06:12 + Stefan Hajnoczi wrote: > On Thu, Jan 5, 2012 at 8:26 PM, Luiz Capitulino > wrote: > > On Thu, 05 Jan 2012 09:56:44 -0600 > > Anthony Liguori wrote: > > > >> On 01/05/2012 09:35 AM, Eric Blake wrote: > >> > On 01/05/2012 07:16 AM, Luiz Capitulino wrote: > >> >>

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Avi Kivity
On 01/06/2012 02:22 PM, Jan Kiszka wrote: > > > > Adding more concepts, just to work around a bug (and this is really a > > bug in the qemu/xen interface) makes it harder to refactor things later on. > > Well, it's at least only a single concept, one that could even be used > independently of Xen

[Qemu-devel] [PATCH 2/4] usb-storage: cancel I/O on reset

2012-01-06 Thread Gerd Hoffmann
When resetting the usb-storage device we'll have to carefully cancel and clear any requests which might be in flight, otherwise we'll confuse the state machine. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/u

[Qemu-devel] [PULL] usb bugfix patch queue

2012-01-06 Thread Gerd Hoffmann
Hi, Here comes a collection of bugfixes for usb, check the individual patches for details. All four patches should be charry-picked into stable once they are merged into master. please pull, Gerd The following changes since commit f3c6a169a39d188e98c17a0a0ebfa7f85e5aafdd: Merge remote-tr

[Qemu-devel] [PATCH 1/4] Fix parse of usb device description with multiple configurations

2012-01-06 Thread Gerd Hoffmann
From: Cao,Bing Bu Changed From V1: Use DPRINTF instead of fprintf,because it is not an error. When testing ipod on QEMU by He Jie Xu,qemu made a assertion. We found that the ipod with 2 configurations,and the usb-linux did not parse the descriptor correctly. The descr_len returned is the total

[Qemu-devel] [PATCH 4/4] usb-ohci: td.cbp incorrectly updated near page end

2012-01-06 Thread Gerd Hoffmann
From: Andriy Gapon The current code that updates the cbp value after a transfer looks like this: td.cbp += ret; if ((td.cbp & 0xfff) + ret > 0xfff) { because the 'ret' value is effectively added twice the check may fire too early when the overflow hasn't happened yet. Below is one of th

[Qemu-devel] [PATCH 3/4] usb-host: properly release port on unplug & exit

2012-01-06 Thread Gerd Hoffmann
Factor out port release into a separate function. Call release function in exit notifier too. Add explicit call the USBDEVFS_RELEASE_PORT ioctl, just closing the hub file handle seems not to be enougth. Make sure we release the port before resetting the device, otherwise host drivers will not re

Re: [Qemu-devel] MMU Modes

2012-01-06 Thread Peter Maydell
On 6 January 2012 12:45, Xin Tong wrote: > In qemu soft TLB, there is a MMU modes. what is it and what does it do > ? I see target-mips, NB_MMU_MODES is defined to be 3, unfortunately, > there is no comments on what each one of them means in the code. This distinguishes TLB entries for kernel mod

Re: [Qemu-devel] FW: qemu-ppc core dumps randomly on postgresql thread safety test

2012-01-06 Thread Peter Maydell
On 6 January 2012 12:37, Rengert, Mark wrote: > I am using scratchbox2 under Ubuntu 10.04 to build postgresql for ppc. About > half the time > the configuration test for thread safety fails with a qemu-ppc coredump. It > fails less often > when QEMU_STRACE is defined but it still fails sometimes

Re: [Qemu-devel] [PATCH 1/3]use int64 when compare two time

2012-01-06 Thread Peter Maydell
On 6 January 2012 07:37, Zhang, Yang Z wrote: > use int64 when compare two time > > int32 only represent only 136 years when comparing two times based on second. > It would be better to use int64. "int32", "int32_t" and "'int' which happens to be 32 bit" are all different types; your changelog m

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Jan Kiszka
On 2012-01-06 08:50, Stefano Stabellini wrote: > On Thu, 5 Jan 2012, Jan Kiszka wrote: >> On 2012-01-05 15:50, Avi Kivity wrote: Let me summarize what we have come up with so far: - we move the call to xen_register_framebuffer before memory_region_init_ram in vga_common_init; >>

[Qemu-devel] [PATCH 04/12] usb-desc: audio endpoint support

2012-01-06 Thread Gerd Hoffmann
Add support for audio endpoints which have two more fields in the descriptor. Also add support for extra class specific endpoint descriptors. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 14 +++--- hw/usb-desc.h |5 + 2 files changed, 16 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 02/12] usb: track configuration and interface count in USBDevice.

2012-01-06 Thread Gerd Hoffmann
Move fields from USBHostDevice to USBDevice. Add bits to usb-desc.c to fill them for emulated devices too. Also allow to set configuration 0 (== None) for emulated devices. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 34 ++ hw/usb.h |3 +++ usb-lin

[Qemu-devel] [PATCH 08/12] usb: add ifnum to USBEndpoint

2012-01-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb.c| 14 ++ hw/usb.h|3 +++ usb-linux.c |1 + 3 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 5d6baaf..6ba063a 100644 --- a/hw/usb.c +++ b/hw/usb.c @@ -422,6 +422,8 @@ void usb_ep_init(US

[Qemu-devel] [PATCH 03/12] usb: track altsetting in USBDevice

2012-01-06 Thread Gerd Hoffmann
Also handle {GET,SET}_INTERFACE in common code (usb-desc.c). Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c | 22 - hw/usb-ccid.c |8 -- hw/usb-desc.c | 71 +++ hw/usb-hid.c|7 - hw/usb-hub.c|

[Qemu-devel] [PATCH 07/12] usb: add USBEndpoint

2012-01-06 Thread Gerd Hoffmann
Start maintaining endpoint state at USBDevice level. Add USBEndpoint struct and some helper functions to deal with it. For now it contains the endpoint type only. Moved over some bits from usb-linux.c Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |1 + hw/usb.c | 30

[Qemu-devel] [PATCH 12/12] usb: link packets to endpoints not devices

2012-01-06 Thread Gerd Hoffmann
Add USBEndpoint for the control endpoint to USBDevices. Link async packets to the USBEndpoint instead of the USBDevice. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c |3 ++- hw/usb-musb.c |3 ++- hw/usb-ohci.c |4 +++- hw/usb-uhci.c |3 ++- hw/usb.c | 12 ++-- hw

[Qemu-devel] [PATCH v4 00/15] block: generic image streaming

2012-01-06 Thread Stefan Hajnoczi
This series adds the 'block_stream' command which copies the contents of a backing file into the image file while the VM is running. The series builds on the zero detection features which I sent out before Christmas. I suggest grabbing my git tree to try it out without merging this dependency: ht

[Qemu-devel] [PATCH v4 07/15] qmp: add block_job_set_speed command

2012-01-06 Thread Stefan Hajnoczi
Add block_job_set_speed, which sets the maximum speed for a background block operation. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 25 + hmp-commands.hx | 14 ++ hmp.c| 11 +++ hmp.h|1 + qapi-schema.json |

[Qemu-devel] [PATCH v4 02/15] block: check bdrv_in_use() before blockdev operations

2012-01-06 Thread Stefan Hajnoczi
Long-running block operations like block migration and image streaming must have continual access to their block device. It is not safe to perform operations like hotplug, eject, change, resize, commit, or external snapshot while a long-running operation is in progress. This patch adds the missin

[Qemu-devel] [PATCH v4 03/15] block: add BlockJob interface for long-running operations

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block.c | 48 block_int.h | 40 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index daf92c2..5bfaa3a 100644 --- a/block.c +++ b/

[Qemu-devel] [PATCH v4 09/15] qmp: add query-block-jobs

2012-01-06 Thread Stefan Hajnoczi
Add query-block-jobs, which shows the progress of ongoing block device operations. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 33 + hmp.c| 36 hmp.h|1 + monitor.c|7 ++

[Qemu-devel] [PATCH v4 01/15] coroutine: add co_sleep_ns() coroutine sleep function

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + qemu-coroutine-sleep.c | 38 ++ qemu-coroutine.h |6 ++ 3 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 qemu-coroutine-sleep.c diff --git a/Makefile.objs

[Qemu-devel] [PATCH v4 08/15] qmp: add block_job_cancel command

2012-01-06 Thread Stefan Hajnoczi
Add block_job_cancel, which stops an active block streaming operation. When the operation has been cancelled the new BLOCK_JOB_CANCELLED event is emitted. Signed-off-by: Stefan Hajnoczi --- QMP/qmp-events.txt | 24 blockdev.c | 19 ++- hmp-com

[Qemu-devel] [PATCH v4 11/15] block: add bdrv_find_backing_image

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Add bdrv_find_backing_image: given a BlockDriverState pointer, and an id, traverse the backing image chain to locate the id. Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- block.c | 17 + block.h |1 + 2 files changed, 18 insertio

[Qemu-devel] [PATCH 01/12] usb-host: rip out legacy procfs support

2012-01-06 Thread Gerd Hoffmann
This patch removes support for parsing /proc/bus/usb/devices for device discovery. The code lacks a few features compared to the sysfs code and is also bitrotting as everybody has sysfs these days. This implies having sysfs mounted is mandatory now to use the usb-host driver. udev isn't required

[Qemu-devel] [PATCH v4 10/15] blockdev: make image streaming safe across hotplug

2012-01-06 Thread Stefan Hajnoczi
Unplugging a storage interface like virtio-blk causes the host block device to be deleted too. Long-running operations like block migration must take a DriveInfo reference to prevent the BlockDriverState from being freed. For image streaming we can do the same thing. Note that it is not possible

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Jan Kiszka wrote: > On 2012-01-06 08:50, Stefano Stabellini wrote: > > On Thu, 5 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-05 15:50, Avi Kivity wrote: > Let me summarize what we have come up with so far: > > - we move the call to xen_register_framebuffer before

[Qemu-devel] [PATCH 11/12] usb: add max_packet_size to USBEndpoint

2012-01-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c |2 ++ hw/usb.c | 37 + hw/usb.h |4 usb-linux.c | 31 +-- 4 files changed, 44 insertions(+), 30 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c ind

[Qemu-devel] [PATCH v4 06/15] qmp: add block_stream command

2012-01-06 Thread Stefan Hajnoczi
Add the block_stream command, which starts copy backing file contents into the image file. Also add the BLOCK_JOB_COMPLETED QMP event which is emitted when image streaming completes. Later patches add control over the background copy speed, cancelation, and querying running streaming operations.

[Qemu-devel] [PATCH v4 15/15] test: add image streaming test cases

2012-01-06 Thread Stefan Hajnoczi
python test-stream.py Signed-off-by: Stefan Hajnoczi --- test-stream.py | 208 1 files changed, 208 insertions(+), 0 deletions(-) create mode 100644 test-stream.py diff --git a/test-stream.py b/test-stream.py new file mode 100644 index

[Qemu-devel] [PATCH 05/12] usb: add audio device model.

2012-01-06 Thread Gerd Hoffmann
From: H. Peter Anvin This brings a usb audio device to qemu. Output only, fixed at 16bit stereo @ 48 Hz. Based on a patch from H. Peter Anvin Usage: add '-device usb-audio' to your qemu command line. Works sorta ok on a idle machine. Known issues: * Is *very* sensitive to latencies.

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Anthony Liguori
On 01/06/2012 06:45 AM, Luiz Capitulino wrote: On Fri, 6 Jan 2012 11:06:12 + Stefan Hajnoczi wrote: Proper async support - if you mean the ability to have multiple QMP commands pending at a time - is harder than just fixing QEMU. Clients also need to start taking advantage of it. Clients

[Qemu-devel] [PATCH 09/12] usb-desc: USBEndpoint support

2012-01-06 Thread Gerd Hoffmann
Initialize USBEndpoint structs from USBDesc* data. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 9c38661..0768334 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@

[Qemu-devel] [PATCH v4 05/15] block: rate-limit streaming operations

2012-01-06 Thread Stefan Hajnoczi
This patch implements rate-limiting for image streaming. If we've exceeded the bandwidth quota for a 100 ms time slice we sleep the coroutine until the next slice begins. Signed-off-by: Stefan Hajnoczi --- block/stream.c | 65 ++- 1 files ch

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-nbd: drop loop which can never loop

2012-01-06 Thread Stefan Hajnoczi
On Thu, Jan 05, 2012 at 01:16:07PM +, Stefan Hajnoczi wrote: > For some reason nbd_client_thread() has a do..while loop which can never > loop, the condition is bogus because we would take a goto instead. Drop > the loop. > > Reported-by: Dr David Alan Gilbert > Signed-off-by: Stefan Hajnocz

[Qemu-devel] [PATCH v4 12/15] add QERR_BASE_ID_NOT_FOUND

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index feb3d35..42f5fc2 100644 --- a/qerror.c +++ b/qerror.c @@ -276,6 +276,10 @@

[Qemu-devel] [PATCH v4 13/15] block stream: add support for partial streaming

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Add support for streaming data from an intermediate section of the image chain (see patch and documentation for details). Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- block.c| 64 blo

[Qemu-devel] [PATCH 00/12] usb patch queue: audio, xhci

2012-01-06 Thread Gerd Hoffmann
Hi, More patches from the usb patch queue, for review, this time more entertaining than boring bug fixes. It goes in top of the bugfix pull request sent out earier today. git tree available for your convinience, see below. So, what is in there? * usb-audio emulation support. * xhci emulati

[Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Anthony Liguori
Hi, I had an idea I wanted to share and see what level of interest there was in participating and if anyone knows of a process that other projects follow for this. I'd like to start a more formal and transparent security audit of QEMU. The way I'd imagine it working is something like this:

[Qemu-devel] [PATCH 10/12] usb/debug: add usb_ep_dump

2012-01-06 Thread Gerd Hoffmann
Add function to dump endpoint data, for debugging purposes. Signed-off-by: Gerd Hoffmann --- hw/usb.c| 40 hw/usb.h|1 + usb-linux.c |3 +++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 6ba063

[Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + block/stream.c | 119 block_int.h|3 + trace-events |4 ++ 4 files changed, 127 insertions(+), 0 deletions(-) create mode 100644 block/stream.c diff --git a/Makefi

[Qemu-devel] [PATCH v4 14/15] add doc to describe live block operations

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- docs/live-block-ops.txt | 58 +++ 1 files changed, 58 insertions(+), 0 deletions(-) create mode 100644 docs/live-block-ops.txt diff --git a/docs/live-block-op

Re: [Qemu-devel] [PATCH v5 2/5] arm: make the number of GIC interrupts configurable

2012-01-06 Thread Peter Maydell
On 5 January 2012 20:02, Mark Langsdorf wrote: > Increase the maximum number of GIC interrupts for a9mp and a11mp to 256, > and create a configurable property for each defaulting to 96 and 64 > (respectively) so that device modelers can set the value appropriately > for their SoC. Other ARM proces

[Qemu-devel] [PULL 0/9] Trivial patches for 20 December 2011 to 6 January 2012

2012-01-06 Thread Stefan Hajnoczi
My pull request from 22 December 2011 was misformatted and therefore not merged. I have included those patches again together with the latest batch of trivial patches. The following changes since commit c47f3223658119219bbe0b8d09da733d1c06e76f: Merge remote-tracking branch 'pmaydell/arm-devs.f

[Qemu-devel] [PATCH 5/9] configure: Fix test for supported host CPU type

2012-01-06 Thread Stefan Hajnoczi
From: Peter Maydell The test for whether the host CPU is supported had several problems: * the attempt to fall back to TCI was done as a duplicate test, very late (so "--cpu foo" would fail early but "--cpu unicore32" would fail late, differently, and after configure had already printed

[Qemu-devel] [PATCH 3/9] scsi virtio-blk usb-msd: Clean up device init error messages

2012-01-06 Thread Stefan Hajnoczi
From: Markus Armbruster Replace error_report("DEVICE-NAME: MESSAGE"); by just error_report("MESSAGE"); in block device init functions. DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device scsi-hd and scsi-cd, "virtio-blk-pci" for virtio-blk-s390, and "usb-msd" for usb-stor

[Qemu-devel] [PATCH 1/9] qemu-options.hx: fix tls-channel help text

2012-01-06 Thread Stefan Hajnoczi
From: Alon Levy Remove the default compiled out tunnel channel, add the always available cursor channel. Optimally the man page would depend on compiled in options, but that's harder to do. RHBZ: 688586 Acked-by: Gerd Hoffmann Signed-off-by: Alon Levy Signed-off-by: Stefan Hajnoczi --- qemu

[Qemu-devel] [PATCH 4/9] configure: CONFIG_QEMU_INTERP_PREFIX only for user mode

2012-01-06 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 640e815..af19391 100755 --- a/configure +++ b/configure @@ -3395,7 +3395,6 @@ echo "# Automatically ge

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Peter Maydell
On 6 January 2012 13:30, Jan Kiszka wrote: > The third point indicates that there is rather more generic room for > improvements: Why should qemu reset device models before restore at all? Commit 5a8a49d7aa says: # if we load from a snapshot, the machine can be in any state. That can # cause trou

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Stefan Hajnoczi
On Fri, Jan 06, 2012 at 09:19:45AM -0600, Anthony Liguori wrote: > Would folks be interested in participating in something like this? > If so, I can start organizing it. I enjoy bug hunting and would volunteer. Stefan

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Corey Bryant
On 01/06/2012 10:19 AM, Anthony Liguori wrote: Hi, I had an idea I wanted to share and see what level of interest there was in participating and if anyone knows of a process that other projects follow for this. I'd like to start a more formal and transparent security audit of QEMU. The way I'

[Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop

2012-01-06 Thread Stefan Hajnoczi
For some reason nbd_client_thread() has a do..while loop which can never loop, the condition is bogus because we would take a goto instead. Drop the loop. Reported-by: Dr David Alan Gilbert Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- qemu-nbd.c | 10 -- 1 files cha

[Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error path

2012-01-06 Thread Stefan Hajnoczi
From: Peter Maydell Fix a leak of a file descriptor in error exit paths in gdbserver_open(). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- gdbstub.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a5806ef..7d470b6 100644

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 5 January 2012 20:02, Mark Langsdorf wrote: > From: Rob Herring > > Adds support for Calxeda's Highbank SoC. Is there a test kernel image/etc we can use to confirm that this all works? > --- /dev/null > +++ b/hw/highbank.c > @@ -0,0 +1,227 @@ > +/* > + * Calxeda Highbank SoC emulation Is it

[Qemu-devel] [PATCH 2/9] Strip trailing '\n' from error_report()'s first argument (again)

2012-01-06 Thread Stefan Hajnoczi
From: Markus Armbruster Commit 6daf194d got rid of them, but Hans and Gerd added some more lately. Tracked down with this Coccinelle semantic patch: @r@ expression fmt; position p; @@ error_report(fmt, ...)@p @script:python@ fmt << r.fmt; p << r.p; @@ if "\\n" in str(fmt):

[Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_init() error paths

2012-01-06 Thread Stefan Hajnoczi
From: Peter Maydell Fix a leak of a file descriptor due to missing closesocket() calls in error paths in net_socket_listen_init(). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- net/socket.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/socket.

[Qemu-devel] [PATCH 8/9] Make python mandatory

2012-01-06 Thread Stefan Hajnoczi
From: Sebastian Herbszt The QEMU build depends on Python so make it an explicit requirement. Reviewed-by: Stefan Weil Signed-off-by: Sebastian Herbszt Signed-off-by: Stefan Hajnoczi --- configure | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/configure b/co

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Jan Kiszka
On 2012-01-06 13:58, Peter Maydell wrote: > On 6 January 2012 13:30, Jan Kiszka wrote: >> The third point indicates that there is rather more generic room for >> improvements: Why should qemu reset device models before restore at all? > > Commit 5a8a49d7aa says: > # if we load from a snapshot, th

[Qemu-devel] Incorrect hw/omap_dss.c:chip[] index for RFBI_READ and RFBI_STATUS?

2012-01-06 Thread Stefan Hajnoczi
Is the following code correct in hw/omap_dss.c: case 0x58: /* RFBI_READ */ if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0]) s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1); else if ((s->rfbi.control & (1 << 3)) && s->rfbi.chip[1]) s->rfbi.rxbuf = s->r

[Qemu-devel] [PATCH 2/2] vnc: fix no-lock-key-sync strncmp() length

2012-01-06 Thread Stefan Hajnoczi
The no-lock-key-sync option is being parsed incorrectly because of an outdated strcmp() length value. Use the correct length so that invalid option names do not match. Reported-by: Dr David Alan Gilbert Signed-off-by: Stefan Hajnoczi --- ui/vnc.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH 1/2] vvfat: avoid leaking file descriptor in commit_one_file()

2012-01-06 Thread Stefan Hajnoczi
Reported-by: Dr David Alan Gilbert Signed-off-by: Stefan Hajnoczi --- block/vvfat.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index eeffc4a..9ef21dd 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2218,6 +2218,7 @@ static int comm

[Qemu-devel] [PATCH 0/2] Fix fd leak in vvfat.c and strncmp() issue in vnc.c

2012-01-06 Thread Stefan Hajnoczi
Two unrelated bugs that David Gilbert had kicking around that are easy to fix. Let's take care of them. Stefan Hajnoczi (2): vvfat: avoid leaking file descriptor in commit_one_file() vnc: fix no-lock-key-sync strncmp() length block/vvfat.c |3 +++ ui/vnc.c |2 +- 2 files changed

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Mark Langsdorf
On 01/06/2012 10:29 AM, Peter Maydell wrote: > On 5 January 2012 20:02, Mark Langsdorf wrote: >> From: Rob Herring >> >> Adds support for Calxeda's Highbank SoC. > > Is there a test kernel image/etc we can use to confirm that this all works? The 3.2 kernel should have all the necessary support

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Michael Roth
On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: Hi, all. I am trying QEMU Guest Agent and encountered a small bug. It is that the PIDFILE remains when daemon start fails. And maybe for

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 16:58, Mark Langsdorf wrote: > On 01/06/2012 10:29 AM, Peter Maydell wrote: >>> +    /* Override default RAM size */ >>> +    if (ram_size == 0x800) { >>> +        if (sizeof(long) == 8) { >>> +            ram_size = 0xff90; >>> +        } else { >>> +            ram_size

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Daniel P. Berrange
On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: > On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: > >On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: > >>On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: > >>>Hi, all. > >>> > >>>I am trying QEMU Guest Agent and encountered

Re: [Qemu-devel] [PATCH 0/3] remove the periodic RTC update timer

2012-01-06 Thread Andreas Färber
Next time please thread your patch series together so that they can easily be reviewed and tested. git-send-email usually ensures that. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] 回??: [PATCH 2/2] umem: chardevice for kvm?postcopy

2012-01-06 Thread Isaku Yamahata
On Fri, Jan 06, 2012 at 03:02:00PM +0800, thfbjyddx wrote: > Hi, > Can you tell me the base version of the qemu? > the postcopy patches make some conflicts on the qemu which I clone from the > git 03ecd2c80a64d030a22fe67cc7a60f24e17ff211 > Thanks! > ━━━ > To

Re: [Qemu-devel] [PATCH 05/12] usb: add audio device model.

2012-01-06 Thread Alex Bradbury
On 6 January 2012 13:58, Gerd Hoffmann wrote: > diff --git a/hw/usb-audio.c b/hw/usb-audio.c > new file mode 100644 > index 000..c14dff3 > --- /dev/null > +++ b/hw/usb-audio.c > @@ -0,0 +1,698 @@ > +/* > + * QEMU USB Net devices Presumably s/Net/Audio Alex

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Chris Wright
* Corey Bryant (cor...@linux.vnet.ibm.com) wrote: > Count me in for step 2. A good approach may be to run a static > analysis tool against the code, followed by a manual scan of the > code for common vulnerabilities that static analysis can't find. Good idea. Folks are already running things lik

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer

2012-01-06 Thread Jan Kiszka
On 2012-01-06 05:37, Zhang, Yang Z wrote: > change the RTC update logic to use host time with offset to calculate RTC > clock. > There have no need to use two periodic timers to maintain an internal > timer for RTC clock update and alarm check. Instead, we calculate the real > RTC time by

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Mark Langsdorf
On 01/06/2012 11:04 AM, Peter Maydell wrote: > On 6 January 2012 16:58, Mark Langsdorf wrote: >> On 01/06/2012 10:29 AM, Peter Maydell wrote: +sysram = g_new(MemoryRegion, 1); +memory_region_init_ram(sysram, "highbank.sysram", 0x8000); +memory_region_add_subregion(sysme

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Chris Wright
* Anthony Liguori (aligu...@us.ibm.com) wrote: > 2) Two people walk through a particular piece of code and > independently flag anything that looks like a potential security > issue. Auditing is always helpful, but won't ever get full coverage. qtest + fuzz is another great way to identify proble

Re: [Qemu-devel] [PATCH 1/3]use int64 when compare two time

2012-01-06 Thread Andreas Färber
Am 06.01.2012 08:37, schrieb Zhang, Yang Z: > use int64 when compare two time > > int32 only represent only 136 years when comparing two times based on second. > It would be better to use int64. int32 and int64 are softfloat types and should not be used here. Do you have an actual use case that

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 17:34, Mark Langsdorf wrote: > On 01/06/2012 11:04 AM, Peter Maydell wrote: >> On 6 January 2012 16:58, Mark Langsdorf wrote: > +    if (load_image_targphys("sysram.bin", 0xfff88000, 0x8000) < 0) { > +            fprintf(stderr, "Unable to load sysram.bin\n"); > +  

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Andreas Färber
Am 05.01.2012 21:02, schrieb Mark Langsdorf: > From: Rob Herring > > Adds support for Calxeda's Highbank SoC. > > Signed-off-by: Rob Herring > Signed-off-by: Mark Langsdorf > --- > diff --git a/hw/highbank.c b/hw/highbank.c > new file mode 100644 > index 000..73b6564 > --- /dev/null > +++

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Igor Mitsyanko
On 01/06/2012 12:02 AM, Mark Langsdorf wrote: Hello, Mark. According to technical specification on Calxeda website, highbank SoC has SD 3.0 host controller, are you planning to implement it in qemu? I'm asking because I recently have submitted a patch implementing SD 2.0 host controller, and i

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 18:37, Igor Mitsyanko wrote: > On 01/06/2012 12:02 AM, Mark Langsdorf wrote: >> +    if (!cpu_model) { >> +        cpu_model = "cortex-a9"; >> +    } > > > Google said there is only cortexA9-based Highbank SoC version, maybe you > should just hardcode cpu model? This is just boi

[Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts

2012-01-06 Thread Peter Maydell
Fix a compile failure on 32 bit hosts (integer constant is too large for 'unsigned long' type) by correcting a typo where the mask used for filling in the second f_fsid word had too many 'F's in it. Also drop the 'L' suffix that allowed this typo to go undetected on 64 bit hosts. Signed-off-by: Pe

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Rob Herring
On 01/06/2012 12:37 PM, Igor Mitsyanko wrote: > On 01/06/2012 12:02 AM, Mark Langsdorf wrote: > > Hello, Mark. According to technical specification on Calxeda website, > highbank SoC has SD 3.0 host controller, are you planning to implement > it in qemu? I'm asking because I recently have submitte

[Qemu-devel] [PATCH v4 0/2] integratorcp: fix and simplify flash remap code

2012-01-06 Thread Peter Maydell
Simplify the flash remap code now we have an API for simple enable/disable of memory regions. Changes: v1->v2: split 'fix sense of REMAP bit' into its own patch v2->v3: minor change suggested by Avi in patch 2 (pass !(sm->cm_ctrl & 4) to set_enabled() rather than using if) v3->v4: reba

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-06 Thread Luiz Capitulino
On Thu, 05 Jan 2012 15:41:33 -0600 Michael Roth wrote: > On 01/05/2012 02:25 PM, Luiz Capitulino wrote: > > On Thu, 05 Jan 2012 09:10:50 -0600 > > Michael Roth wrote: > > > >> On 01/05/2012 08:42 AM, Luiz Capitulino wrote: > >>> On Thu, 5 Jan 2012 12:59:27 + > >>> "Daniel P. Berrange" wrot

  1   2   >