Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

On 01/01/2012 06:27 PM, Stefan Hajnoczi wrote: On Sun, Jan 1, 2012 at 9:43 AM, Orit Wasserman wrote: On 12/30/2011 12:39 AM, Anthony Liguori wrote: On 12/28/2011 07:25 PM, Isaku Yamahata wrote: Intro = This patch series implements postcopy live migration.[1] As discussed at KVM forum 2011

Re: [Qemu-devel] Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

On 01/01/2012 04:01 PM, Ronen Hod wrote: On 01/01/2012 12:16 PM, Dor Laor wrote: On 12/29/2011 06:16 PM, Anthony Liguori wrote: On 12/29/2011 10:07 AM, Dor Laor wrote: On 12/26/2011 11:05 AM, Avi Kivity wrote: On 12/26/2011 05:14 AM, Nikunj A Dadhania wrote: btw you can get an additional sp

[Qemu-devel] KVM call agenda for Tuesday 3

Hi First of all, Happy New Year to everybody (even for the people whose calendar is different O:-) Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] Regression: cold plug with device_add fails assertion

Anthony Liguori writes: > On 12/21/2011 05:01 AM, Markus Armbruster wrote: >> Test case: >> >> $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor >> stdio -usb >> >> Works in v1.0, doesn't work in master's commit ab0115e1: >> >> qemu-system-x86_64: /work/armbru/qemu/hw/qde

[Qemu-devel] virtual pc hash table vs physical pc hash table

In qemu, there is a virtual pc hash table and a physical pc hash table. virtual pc hash table is used to find tbs until a context switch. and physical pc hash table keeps all the translated tb. virtual pc hash table is smaller, accessed with 12 bits and physical pc hash table is bigger, accessed wi

Re: [Qemu-devel] [RFC PATCH 0/4] simpletrace : support var num/size of args, strings.

Harsh Prateek Bora writes: > Converting tracetool.sh to tracetool.py Excellent! I was thinking about switching the script language to python, but wasn't sure if python was an acceptable build dependency for the project. I was modifying the bash tracetool to add a tracing layer more amenable to

[Qemu-devel] [RFC PATCH 1/3] tcg: add extended MMU helper functions

Title: Samsung Enterprise Portal mySingle MMU helper functions defined in softmmu_template.h are extended to receive their return address so that they return to give addresses not caller's pc's.   Signed-off-by: Yeongkyoon Lee --- exec-all.h |   16 +++ 

[Qemu-devel] [RFC PATCH 3/3] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

Title: Samsung Enterprise Portal mySingle Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization.   Signed-off-by: Yeongkyoon Lee --- configure |    7 +++ 1 files changed, 7 insertions(+), 0 dele

Re: [Qemu-devel] KVM call agenda for Tuesday 3

Am 02.01.2012 13:09, schrieb Juan Quintela: > First of all, Happy New Year to everybody (even for the people whose > calendar is different O:-) +1 > Please send in any agenda items you are interested in covering. QOM: If Anthony is available, I'd be interested in hearing an update on the roadmap

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

On 12/29/2011 07:33 PM, Anthony Liguori wrote: FWIW, I expect virtio-scsi to be the first guinea pig here... I believe Stefan has already started looking at writing some qtest based tests for virtio-scsi. I'm curious, because a SCSI HBA makes it as hard as it can be to write unit tests. Pre

Re: [Qemu-devel] KVM call agenda for Tuesday 3

On 01/02/2012 02:46 PM, Andreas Färber wrote: QOM: If Anthony is available, I'd be interested in hearing an update on the roadmap. In particular, * when can we expect to be able to model SoCs rather than CPUs? Will this affect command line usage - are we going to have '-device ti-tms570' rather t

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

On 29.12.2011, at 16:14, Amit Shah wrote: > On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote: >>> port->throttled never becomes true for qemu. >> >> Huh? What did I miss below? >> >>if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) { >>virtio_serial_t

Re: [Qemu-devel] coroutine bug?, was Re: [PATCH] sheepdog: use coroutines

On Fri, Dec 30, 2011 at 10:35:01AM +, Stefan Hajnoczi wrote: > Are you building with gcc 4.5.3 or later? (Earlier versions may > mis-compile, see https://bugs.launchpad.net/qemu/+bug/902148.) I'm using "gcc version 4.6.2 (Debian 4.6.2-9)", so that should not be an issue. > If you can reprod

Re: [Qemu-devel] coroutine bug?, was Re: [PATCH] sheepdog: use coroutines

Forgot to attach the "go-fast" patch required to reproduce the issue on slow storage: Index: sheepdog/sheep/simple_store.c === --- sheepdog.orig/sheep/simple_store.c 2011-12-29 20:10:44.171622413 +0100 +++ sheepdog/sheep/simple_store

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

On 02/01/12 16:34, Alexander Graf wrote: >>>if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) { >>>virtio_serial_throttle_port(port, true); >> >> Ah; I see what's happening. pty_chr_write() returns 0 if a client >> isn't yet connected. >> >> This is different from the

Re: [Qemu-devel] KVM call agenda for Tuesday 3

On 2 January 2012 13:46, Andreas Färber wrote: > * when can we expect to be able to model SoCs rather than CPUs? Will > this affect command line usage - are we going to have '-device > ti-tms570' rather than '-cpu cortex-r4' then, or -cpu overriding the > container's default? My initial inclinati

[Qemu-devel] [PATCH 00/16] Kill old-style I/O dispatch

This patchset removes I/O dispatch through CPU{Read,Write}Func and replaces it with direct dispatch through MemoryRegions (except for MemoryRegionOps::old_mmio, of course). Avi Kivity (16): memory: move endianness compensation to memory core exec: make phys_page_find() return a temporary mem

[Qemu-devel] [PATCH 04/16] memory: remove MemoryRegion::backend_registered

backend_registered was used to lazify the process of registering an mmio region, since the it is different for the I/O address space and the memory address space. However, it also makes registration dependent on the region being visible in the address space. This is not the case for "fake" region

[Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

Convert the fixed-address IO_MEM_RAM, IO_MEM_ROM, IO_MEM_UNASSIGNED, and IO_MEM_NOTDIRTY io handlers to MemoryRegions. These aren't real regions, since they are never added to the memory hierarchy, but they allow reuse of the dispatch functionality. Signed-off-by: Avi Kivity --- cpu-common.h

[Qemu-devel] [PATCH 15/16] Drop IO_MEM_ROMD

Unlike ->readonly, ->readable is not inherited from aliase, so we can simply query the memory region. Signed-off-by: Avi Kivity --- cpu-common.h |3 --- exec.c | 22 +- memory.c |5 +++-- memory.h |1 + 4 files changed, 17 insertions(+), 14 deletio

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

On 02.01.2012, at 16:41, Christian Borntraeger wrote: > On 02/01/12 16:34, Alexander Graf wrote: if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) { virtio_serial_throttle_port(port, true); >>> >>> Ah; I see what's happening. pty_chr_write() returns 0 if a cl

[Qemu-devel] [PATCH 12/16] Convert io_mem_watch to be a MemoryRegion

Signed-off-by: Avi Kivity --- exec.c | 73 ++- 1 files changed, 26 insertions(+), 47 deletions(-) diff --git a/exec.c b/exec.c index cc70134..fc1dcb7 100644 --- a/exec.c +++ b/exec.c @@ -212,7 +212,7 @@ CPUReadMemoryFunc *_io_mem_rea

[Qemu-devel] [PATCH 14/16] Remove IO_MEM_SUBPAGE

Replace with a MemoryRegion flag. Signed-off-by: Avi Kivity --- cpu-common.h |1 - exec.c | 10 +- memory.c |1 + memory.h |1 + 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 98dddfe..ffb0a44 100644 --- a/cpu-

[Qemu-devel] [PATCH 16/16] Remove IO_MEM_SHIFT

We no longer use any of the lower bits of a ram_addr, so we might as well use them for the io table index. This increases the number of potential I/O handlers by a factor of 8. Signed-off-by: Avi Kivity --- cpu-all.h |2 +- cpu-common.h |2 -- exec.c | 32 ++

[Qemu-devel] [PATCH 09/16] Switch cpu_register_physical_memory_log() to use MemoryRegions

Still internally using ram_addr. Signed-off-by: Avi Kivity --- exec-obsolete.h | 24 +++- exec.c | 24 +++- memory.c| 44 3 files changed, 38 insertions(+), 54 deletions(-) diff --git a/e

Re: [Qemu-devel] [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

On Thu, Dec 29, 2011 at 06:01:45PM +0200, Avi Kivity wrote: > On 12/29/2011 06:00 PM, Avi Kivity wrote: > > The NFS client has exactly the same issue, if you mount it with the intr > > option. In fact you could use the NFS client as a trivial umem/cuse > > prototype. > > Actually, NFS can return

[Qemu-devel] [PATCH 05/16] Fix wrong region_offset when overlaying a page with another

cpu_register_physical_memory_log() does not update region_offset if a page was previously registered for the same address. This could cause mmio accesses going to the wrong place, by using the old region_offset. Signed-off-by: Avi Kivity --- exec.c |1 + 1 files changed, 1 insertions(+), 0

[Qemu-devel] [PATCH 03/16] memory: move mmio access to functions

Currently mmio access goes directly to the io_mem_{read,write} arrays. In preparation for eliminating them, add indirection via a function. Signed-off-by: Avi Kivity --- exec-all.h |7 - exec.c | 54 ++-- memory.c

[Qemu-devel] [PATCH 07/16] Uninline get_page_addr_code()

Its use of IO_MEM_ROM and friends will later cause #include loops; and it is too large to merit inlining. Signed-off-by: Avi Kivity --- exec-all.h | 26 +- exec.c | 26 ++ 2 files changed, 27 insertions(+), 25 deletions(-) diff --git a/exe

[Qemu-devel] [PATCH 10/16] Convert the subpage wrapper to be a MemoryRegion

Signed-off-by: Avi Kivity --- exec.c | 70 --- 1 files changed, 18 insertions(+), 52 deletions(-) diff --git a/exec.c b/exec.c index c8c839a..fb8c23e 100644 --- a/exec.c +++ b/exec.c @@ -2472,6 +2472,7 @@ static inline void tlb_set_di

Re: [Qemu-devel] virtio-net with virtio-mmio

On Mon, Jan 2, 2012 at 5:19 AM, Ying-Shiuan Pan wrote: > 2011/12/30 Stefan Hajnoczi >> >> On Wed, Dec 28, 2011 at 06:16:42PM +0800, Ying-Shiuan Pan wrote: >> > I'm very interested in virtio-mmio Peter Maydell did for QEMU, >> > (http://lists.nongnu.org/archive/html/qemu-devel/2011-11/msg01870.htm

[Qemu-devel] [PATCH 13/16] Direct dispatch through MemoryRegion

Now that all mmio goes through MemoryRegions, we can convert io_mem_opaque to be a MemoryRegion pointer, and remove the thunks that convert from old-style CPU{Read,Write}MemoryFunc to MemoryRegionOps. Signed-off-by: Avi Kivity --- exec-all.h |4 +- exec-obsolete.h |5 +- exec.c

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

On Mon, Jan 2, 2012 at 9:28 AM, Dor Laor wrote: > At the end of the day, it's performance testing using various scenarios that > can educate us whether post-copy worth the extra complexity over slowing > down the guest on the source. True. It's certainly an interesting patch series to benchmark

[Qemu-devel] [PATCH 06/16] Avoid range comparisons on io index types

The code sometimes uses range comparisons on io indexes (e.g. index =< IO_MEM_ROM). Avoid these as they make moving to objects harder. Signed-off-by: Avi Kivity --- exec-all.h |2 +- exec.c | 37 - memory.c |3 ++- soft

[Qemu-devel] [PATCH 11/16] Convert IO_MEM_SUBPAGE_RAM to be a MemoryRegion

Signed-off-by: Avi Kivity --- cpu-common.h |1 - exec.c | 72 +++-- 2 files changed, 24 insertions(+), 49 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index fd787b9..98dddfe 100644 --- a/cpu-common.h +++ b/cpu-common.h @@ -

[Qemu-devel] [PATCH 02/16] exec: make phys_page_find() return a temporary

Instead of returning a PhysPageDesc pointer, return a temporary. This lets us move away from actually storing PhysPageDesc's, and instead sythesising them when needed. Signed-off-by: Avi Kivity --- exec.c | 148 +--- 1 files changed, 4

[Qemu-devel] [PATCH 01/16] memory: move endianness compensation to memory core

Instead of doing device endianness compensation in cpu_register_io_memory(), do it in the memory core. Signed-off-by: Avi Kivity --- exec-obsolete.h |2 +- exec.c | 142 --- memory.c| 37 -- 3 files changed,

Re: [Qemu-devel] [PATCH] Fix wrong region_offset when overlaying a page with another

Am 01.01.2012 18:23, schrieb Avi Kivity: > cpu_register_physical_memory_log() does not update region_offset > if a page was previously registered for the same address. This > could cause mmio accesses going to the wrong place, by using the > old region_offset. > > Signed-off-by: Avi Kivity Line

Re: [Qemu-devel] [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

On 01/02/2012 06:05 PM, Andrea Arcangeli wrote: On Thu, Dec 29, 2011 at 06:01:45PM +0200, Avi Kivity wrote: On 12/29/2011 06:00 PM, Avi Kivity wrote: The NFS client has exactly the same issue, if you mount it with the intr option. In fact you could use the NFS client as a trivial umem/cuse pro

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

On 12/20/2011 05:51 PM, Anthony Liguori wrote: hw/object.c | 469 + hw/object.h | 427 +++ A couple more remarks: 1) Please put it outside hw/ 2) Why do you need a list for the inte

[Qemu-devel] [PATCH v2 00/15] virtio: device configuration and headers cleanup

This series cleans up device configuration in virtio: 1) all properties (features and not) are moved to a single macro DEFINE_VIRTIO_XYZ_PROPERTIES. This makes the definitions uniform across all three virtio backends. 2) all configuration is moved to a single struct, which embeds the NICConf/Blo

[Qemu-devel] [PATCH v2 01/15] virtio-net: move property declarations to header file

Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |6 +- hw/virtio-net.h | 41 ++--- hw/virtio-pci.c |7 +-- 3 files changed, 24 insertions(+), 30 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index c4b9a

[Qemu-devel] [PATCH v2 13/15] virtio-balloon: move init function to virtio-balloon.h

Signed-off-by: Paolo Bonzini --- hw/virtio-balloon.h |3 +++ hw/virtio-pci.h |1 + hw/virtio.h |2 -- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/virtio-balloon.h b/hw/virtio-balloon.h index 73300dd..cde2e67 100644 --- a/hw/virtio-balloon.h +++ b/hw/v

[Qemu-devel] [PATCH v2 10/15] virtio: move conf fields into an anonymous union

Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.h |8 +--- hw/virtio-pci.h | 10 ++ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/s390-virtio-bus.h b/hw/s390-virtio-bus.h index 414fd22..b9f711d 100644 --- a/hw/s390-virtio-bus.h +++ b/hw/s390-virtio-

[Qemu-devel] [PATCH 1/8] notifier: switch to QLIST

Notifiers do not need to access both ends of the list, and using a QLIST also simplifies the API. Signed-off-by: Paolo Bonzini --- I do plan to exploit the simplified API in a future patch... input.c |2 +- migration.c |2 +- notify.c | 10 +- notify.h |

[Qemu-devel] [PATCH v2 02/15] virtio-net: move NICConf into virtio_net_conf

Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |3 +-- hw/s390-virtio-bus.h |1 - hw/virtio-net.c | 13 ++--- hw/virtio-net.h |2 ++ hw/virtio-pci.c |3 +-- hw/virtio-pci.h |1 - hw/virtio.h |3 +-- 7 files changed, 11 insertio

[Qemu-devel] [PATCH 8/8] block: use QSIMPLEQ for the AIO free list

QSIMPLEQ is equivalent to an open-coded free list, use it. Signed-off-by: Paolo Bonzini --- block.c |9 - block_int.h |4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index 3f072f6..10e80d7 100644 --- a/block.c +++ b/block.c @@ -3242,9

[Qemu-devel] [PATCH v2 09/15] virtio-blk: move BlockConf into VirtIOBlkConf

Also call blockdev_mark_auto_del from virtio_blk_exit, rather than just virtio_blk_exit_pci. Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |4 +--- hw/s390-virtio-bus.h |1 - hw/virtio-blk.c | 17 + hw/virtio-blk.h |2 ++ hw/virtio-pci.c |

[Qemu-devel] [PATCH 7/8] coroutine: switch to QSIMPLEQ

QSIMPLEQ is now the best candidate for a free list, use it. Signed-off-by: Paolo Bonzini --- coroutine-ucontext.c | 10 +- qemu-coroutine-int.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c index 3d01075..65b0bb7 1

[Qemu-devel] [PATCH v2 15/15] virtio-blk: move init function to virtio-blk.h

Signed-off-by: Paolo Bonzini --- hw/virtio-blk.h |7 +-- hw/virtio.h |7 --- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/virtio-blk.h b/hw/virtio-blk.h index 518e1cc..70d939a 100644 --- a/hw/virtio-blk.h +++ b/hw/virtio-blk.h @@ -97,11 +97,14 @@ struct vi

[Qemu-devel] [PATCH v2 05/15] virtio-9p: remove PCI dependencies from hw/9pfs/

Also move the 9p.h file to 9pfs/virtio-9p-device.h, for consistency with the corresponding .c file. Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-device.c | 36 + hw/{9p.h => 9pfs/virtio-9p-device.h} |4 +- hw/9pfs/virtio-9p.c

[Qemu-devel] [PATCH 5/8] qemu-queue: really simplify QSIMPLEQ

QSIMPLEQ is still relatively heavyweight when used as a free list, compared to a simple singly-linked list. One disadvantage is that it requires an initializer macro, unlike for example QLIST. The patch removes the double links so that there is a "really really simple" queue type. Signed-off-by:

[Qemu-devel] [PATCH v2 07/15] virtio-blk: define VirtIOBlkConf

Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |4 ++-- hw/s390-virtio-bus.h |3 ++- hw/virtio-blk.c | 13 ++--- hw/virtio-blk.h |5 + hw/virtio-pci.c |4 ++-- hw/virtio-pci.h |3 ++- hw/virtio.h |3 ++- 7 files changed, 21

[Qemu-devel] [PATCH 2/8] block-migration: switch to QTAILQ

Block migration needs to insert at tail. Use a QTAILQ, even though the double links are strictly not necessary. Signed-off-by: Paolo Bonzini --- block-migration.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/block-migratio

[Qemu-devel] [PATCH 6/8] qemu-queue: drop QCIRCLEQ

The main advantage of circular lists (the fact that the head node has the same memory layout as any other node, so you do not need conditionals) is completely negated by the implementation in qemu-queue.h. Not surprisingly, nobody uses QCIRCLEQ. While this might change if RCU is ever adopted by QE

[Qemu-devel] [PATCH v2 12/15] virtio-serial: move init function to virtio-serial.h

Signed-off-by: Paolo Bonzini --- hw/virtio-serial.h |7 +-- hw/virtio.h|3 --- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h index 2e1a428..8469956 100644 --- a/hw/virtio-serial.h +++ b/hw/virtio-serial.h @@ -45,10 +45,1

[Qemu-devel] [PATCH v2 04/15] virtio-9p: use CONFIG_VIRTFS, not CONFIG_LINUX

Signed-off-by: Paolo Bonzini --- hw/virtio-pci.h |2 +- hw/virtio.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h index e0df6ef..2edd249 100644 --- a/hw/virtio-pci.h +++ b/hw/virtio-pci.h @@ -34,7 +34,7 @@ typedef struct {

[Qemu-devel] [PATCH 3/8] qed: switch to QTAILQ

QED needs to insert at tail. Use a QTAILQ, even though the double links are strictly not necessary. Signed-off-by: Paolo Bonzini --- block/qed.c | 20 ++-- block/qed.h |4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/block/qed.c b/block/qed.c index

[Qemu-devel] [PATCH v2 08/15] virtio-blk: move property declarations to header file

Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |2 +- hw/virtio-blk.h |5 + hw/virtio-pci.c |3 +-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index cf7cfef..71720b9 100644 --- a/hw/s390-virtio-bus.c

[Qemu-devel] [PATCH v2 03/15] virtio-serial: move property declarations to header file

Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |3 +-- hw/virtio-pci.c |4 +--- hw/virtio-serial.h |5 + 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index 80b11e5..282688a 100644 --- a/hw/s390-virtio-bus.

[Qemu-devel] [PATCH v2 11/15] virtio-net: move init function to virtio-net.h

Signed-off-by: Paolo Bonzini --- hw/virtio-net.h |3 +++ hw/virtio.h |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-net.h b/hw/virtio-net.h index ee55a85..96cd8b1 100644 --- a/hw/virtio-net.h +++ b/hw/virtio-net.h @@ -168,6 +168,9 @@ struct virtio_net

[Qemu-devel] [PATCH 4/8] ccid: switch to QTAILQ

CCID emulation needs to insert at tail. Use a QTAILQ, even though the double links are strictly not necessary. Signed-off-by: Paolo Bonzini --- hw/ccid-card-emulated.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/ccid-card-emulated.c b/hw/

[Qemu-devel] [PATCH v2 06/15] virtio-9p: move property declarations to header file

Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-device.h |5 + hw/virtio-pci.c|4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.h b/hw/9pfs/virtio-9p-device.h index 65789db..7f2a4eb 100644 --- a/hw/9pfs/virtio-9p-device.h +

[Qemu-devel] [PATCH 0/8] qemu-queue cleanups

These patches simplify the jungle of lists provided by qemu-queue from 4 to 3. QCIRCLEQ is dropped, since it provides no real advantage over QTAILQ. QSIMPLEQ is simplified to no longer permit insertion at the tail, with the advantage that it is more suited for simple free lists. Stefan, these ar

[Qemu-devel] [PATCH v2 14/15] virtio-9p: move init function to virtio-9p-device.h

Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-device.h |2 ++ hw/virtio.h|6 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.h b/hw/9pfs/virtio-9p-device.h index 7f2a4eb..28b0012 100644 --- a/hw/9pfs/virtio-9p-device.h ++

Re: [Qemu-devel] [PATCH 06/16] Avoid range comparisons on io index types

On 01/03/2012 03:33 AM, Avi Kivity wrote: > -if ((pd & ~TARGET_PAGE_MASK) > IO_MEM_ROM && !(pd & IO_MEM_ROMD)) { > +if (!is_ram_rom(pd) && !(pd & IO_MEM_ROMD)) { > /* IO memory case (romd handled later) */ Perhaps (!is_ram_rom_romd(pd))? At least that's what I see from DeMorgan's

Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

On 01/03/2012 03:33 AM, Avi Kivity wrote: > -if (is_ram_rom_romd(pd)) { > +if (!is_ram_rom_romd(pd)) { Should be merged with a previous patch. r~

Re: [Qemu-devel] [PATCH 00/16] Kill old-style I/O dispatch

On 01/03/2012 03:33 AM, Avi Kivity wrote: > Avi Kivity (16): > memory: move endianness compensation to memory core > exec: make phys_page_find() return a temporary > memory: move mmio access to functions > memory: remove MemoryRegion::backend_registered > Fix wrong region_offset when over

Re: [Qemu-devel] coroutine bug?, was Re: [PATCH] sheepdog: use coroutines

On Mon, Jan 2, 2012 at 3:39 PM, Christoph Hellwig wrote: > On Fri, Dec 30, 2011 at 10:35:01AM +, Stefan Hajnoczi wrote: >> If you can reproduce this bug and suspect coroutines are involved then I > > It's entirely reproducable. > > I've played around a bit and switched from the ucontext to the

Re: [Qemu-devel] [PATCH 24/27] grackle: remove broken pci device

Am 20.12.2011 17:51, schrieb Anthony Liguori: > I have no idea what's going on here, but this is broken and cannot possibly > work because: > > 1) It's qdev name conflicts with a device that sits on SysBus > > 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice > > If you

Re: [Qemu-devel] [PATCH 25/27] unin_pci: remove phantom qdev devices in unin_pci

Am 20.12.2011 17:51, schrieb Anthony Liguori: > Same problem as with grackle. This code can't possibly work. Nack. Cf. grackle, it does work (-M mac99). Solution should be renaming, not breaking. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennife

Re: [Qemu-devel] [PATCH 10/27] not-for-upstream: disable non-qdev pci devices

Am 20.12.2011 17:51, schrieb Anthony Liguori: > Obviously, this isn't an acceptable approach. We need to convert these > devices > to qdev. > --- > hw/macio.c |5 + > hw/openpic.c|5 + > hw/ppc4xx_pci.c |5 + > hw/prep_pci.c |5 + > 4 files changed, 20

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

Am 22.12.2011 20:57, schrieb Anthony Liguori: > On 12/22/2011 12:00 PM, Kevin O'Connor wrote: >> On Thu, Dec 22, 2011 at 11:41:08AM -0600, Anthony Liguori wrote: >>> On 12/22/2011 11:25 AM, Kevin O'Connor wrote: Why not declare types with something like the following: TypeInfo my_dev

[Qemu-devel] [PATCH 02/30] openpic: remove dead code to make a PCI device version

bus is always NULL so the code in this if clause is dead (and therefore untested). Signed-off-by: Anthony Liguori --- hw/openpic.c | 30 +++--- hw/openpic.h |2 +- hw/ppc_newworld.c |2 +- 3 files changed, 5 insertions(+), 29 deletions(-) diff --git a

[Qemu-devel] [PATCH 12/30] qdev: add a interface to register subclasses

In order to introduce inheritance while still using the qdev registration interfaces, we need to be able to use a parent other than TYPE_DEVICE. Add a new interface that allows this. Signed-off-by: Anthony Liguori --- hw/qdev.c |9 +++-- hw/qdev.h |1 + 2 files changed, 8 insertions

Re: [Qemu-devel] [PATCH 10/27] not-for-upstream: disable non-qdev pci devices

On 01/02/2012 04:55 PM, Andreas Färber wrote: Am 20.12.2011 17:51, schrieb Anthony Liguori: Obviously, this isn't an acceptable approach. We need to convert these devices to qdev. --- hw/macio.c |5 + hw/openpic.c|5 + hw/ppc4xx_pci.c |5 + hw/prep_pci.c

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

On 01/02/2012 05:01 PM, Andreas Färber wrote: Am 22.12.2011 20:57, schrieb Anthony Liguori: On 12/22/2011 12:00 PM, Kevin O'Connor wrote: On Thu, Dec 22, 2011 at 11:41:08AM -0600, Anthony Liguori wrote: On 12/22/2011 11:25 AM, Kevin O'Connor wrote: Why not declare types with something like th

[Qemu-devel] [PATCH 06/30] pci: call reset unconditionally

Because now all PCI devices are converted to qdev. Signed-off-by: Anthony Liguori --- hw/pci.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 399227f..fd575ac 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -159,11 +159,8 @@ void pci_device_deass

Re: [Qemu-devel] KVM call agenda for Tuesday 3

On 01/02/2012 07:46 AM, Andreas Färber wrote: Am 02.01.2012 13:09, schrieb Juan Quintela: First of all, Happy New Year to everybody (even for the people whose calendar is different O:-) +1 Please send in any agenda items you are interested in covering. QOM: If Anthony is available, I'd be

Re: [Qemu-devel] KVM call agenda for Tuesday 3

On 01/02/2012 08:11 AM, Paolo Bonzini wrote: On 01/02/2012 02:46 PM, Andreas Färber wrote: QOM: If Anthony is available, I'd be interested in hearing an update on the roadmap. In particular, * when can we expect to be able to model SoCs rather than CPUs? Will this affect command line usage - are

Re: [Qemu-devel] KVM call agenda for Tuesday 3

On 01/02/2012 09:54 AM, Peter Maydell wrote: On 2 January 2012 13:46, Andreas Färber wrote: * when can we expect to be able to model SoCs rather than CPUs? Will this affect command line usage - are we going to have '-device ti-tms570' rather than '-cpu cortex-r4' then, or -cpu overriding the co

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

On 01/02/2012 11:59 AM, Paolo Bonzini wrote: On 12/20/2011 05:51 PM, Anthony Liguori wrote: hw/object.c | 469 + hw/object.h | 427 +++ A couple more remarks: 1) Please put it outside hw/ D

[Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support

This board never worked with TCG. It hasn't been updated since 0.13.0. I'm fairly sure hardware doesn't exist anymore that you can run the KVM support with. So let's remove it. It can always be restored later if there is interest again. Signed-off-by: Anthony Liguori --- Makefile.target|

[Qemu-devel] [PATCH 04/30] ppc_prep: convert host bridge to qdev

Untested beyond compile. But it's a very simple conversion. Signed-off-by: Anthony Liguori --- hw/prep_pci.c | 38 +++--- 1 files changed, 27 insertions(+), 11 deletions(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index ea9fb69..16c036f 100644 --- a/hw/prep_

[Qemu-devel] [PATCH 25/30] virtio-serial: convert to QEMU Object Model

Signed-off-by: Anthony Liguori --- hw/virtio-console.c| 73 ++ hw/virtio-serial-bus.c | 66 +++--- hw/virtio-serial.h | 81 ++-- 3 files changed, 129 insertions(+), 91

[Qemu-devel] [PATCH 13/30] qdev: add class_init to DeviceInfo

Since we are still dynamically creating TypeInfo, we need to chain the class_init function in order to be able to make use of it within subclasses of TYPE_DEVICE. This will disappear once we register TypeInfos directly. Signed-off-by: Anthony Liguori --- hw/qdev.c |4 hw/qdev.h |5

[Qemu-devel] [PATCH 24/30] spapr: convert to QEMU Object Model (v2)

Signed-off-by: Anthony Liguori --- v1 -> v2 - use QOM to check for the default console --- hw/spapr_llan.c | 37 +++-- hw/spapr_vio.c | 47 --- hw/spapr_vio.h | 35 ++- hw/spapr

[Qemu-devel] [PATCH 26/30] grackle: remove broken pci device

I have no idea what's going on here, but this is broken and cannot possibly work because: 1) It's qdev name conflicts with a device that sits on SysBus 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice If you do qdev_create("grackle"), the code expects to get the SysBus

[Qemu-devel] [PATCH 22/30] ide: convert to QEMU Object Model

Signed-off-by: Anthony Liguori --- hw/ide/internal.h | 20 ++--- hw/ide/qdev.c | 111 + 2 files changed, 82 insertions(+), 49 deletions(-) diff --git a/hw/ide/internal.h b/hw/ide/internal.h index 00b28df..c808a0d 100644 --- a/hw/ide/

[Qemu-devel] [PATCH 08/30] qdev: integrate with QEMU Object Model (v2)

This is a very shallow integration. We register a TYPE_DEVICE but only use QOM as basically a memory allocator. This will make all devices show up as QOM objects but they will all carry the TYPE_DEVICE. Signed-off-by: Anthony Liguori --- v1 -> v2 - update for new location of object.h --- hw/q

[Qemu-devel] [PATCH 18/30] ssi: convert to QEMU Object Model

Signed-off-by: Anthony Liguori --- hw/ads7846.c | 17 - hw/max111x.c | 34 -- hw/spitz.c | 39 +++ hw/ssd0323.c | 17 - hw/ssi-sd.c| 17 - hw/ssi.c |

[Qemu-devel] [PATCH 21/30] hda-codec: convert to QEMU Object Model

Signed-off-by: Anthony Liguori --- hw/hda-audio.c | 58 ++- hw/intel-hda.c | 31 + hw/intel-hda.h | 26 3 files changed, 71 insertions(+), 44 deletions(-) diff --git a/hw/hda-audio.c b/

[Qemu-devel] [PATCH 19/30] i2c: rename i2c_slave -> I2CSlave

Signed-off-by: Anthony Liguori --- hw/ds1338.c | 10 +- hw/hw.h |4 ++-- hw/i2c.c | 30 +++--- hw/i2c.h | 18 ++ hw/lm832x.c | 10 +- hw/max7310.c | 10 +- hw/pxa2xx.c | 10 +- hw/smbus.

[Qemu-devel] [PATCH 23/30] scsi: convert to QEMU Object Model

Signed-off-by: Anthony Liguori --- hw/scsi-bus.c | 95 +++- hw/scsi-disk.c| 159 - hw/scsi-generic.c | 29 ++ hw/scsi.h | 31 ++ 4 files changed, 201 insertions(+), 113 deletions

[Qemu-devel] [PATCH 11/30] qdev: use a wrapper to access reset and promote reset to a class method

Signed-off-by: Anthony Liguori --- hw/intel-hda.c |4 +--- hw/lsi53c895a.c |2 +- hw/qdev.c | 22 +- hw/qdev.h |8 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 8cb92d3..6e1c5de 100644

[Qemu-devel] [PATCH 27/30] unin_pci: remove phantom qdev devices in unin_pci

Same problem as with grackle. This code can't possibly work. Signed-off-by: Anthony Liguori --- hw/unin_pci.c | 77 - 1 files changed, 0 insertions(+), 77 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index 14d9914..b3365fe 10

[Qemu-devel] qom: add QEMU Object Model type hierarchy to qdev (v2)

This is series 2/4 of the QOM refactoring. These series are divided up based on the major scripted code conversions. This series makes qdev a proper Object and converts qdev's type inheritance to QOM inheritance. The first half of the series are manual cleanups/refactorings. The second half is

[Qemu-devel] [PATCH 05/30] pseries: Remove hcalls callback

From: David Gibson For forgotten historical reasons, PAPR hypercalls for specific virtual IO devices (oh which there are quite a number) are registered via a callback in the VIOsPAPRDeviceInfo structure. This is kind of ugly, so this patch instead registers hypercalls from device_init() function

[Qemu-devel] [PATCH 16/30] usb: convert to QEMU Object Model

Signed-off-by: Anthony Liguori --- hw/usb-bt.c | 33 ++ hw/usb-bus.c| 179 +++ hw/usb-ccid.c | 38 +++- hw/usb-desc.c | 18 +++--- hw/usb-hid.c| 108 -- hw/usb-hub.c|

[Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion

These are various small stylistic changes which help make things more consistent such that the automated conversion script can be simpler. It's not necessary to agree or disagree with these style changes because all of this code is going to be rewritten by the patch monkey script anyway. Signed-o

  1   2   >