[Qemu-devel] [PATCH 00/11] configure: Fix compiler warnings in config.log

2011-12-17 Thread Stefan Weil
Recently some patches were sent from Peter Maydell to improve the output in config.log. This new patch series also improves that output by eliminating some compiler warnings. Here is the result of a typical QEMU configuration: without patch series 296 lines in config.log with 78 compilations, 69

[Qemu-devel] [PATCH 02/11] configure: Fix compiler warnings in config.log (old-style function definition)

2011-12-17 Thread Stefan Weil
warning: function declaration isn’t a prototype In function ‘foo’: warning: old-style function definition The function name was changed, too, to avoid an additional warning. Signed-off-by: Stefan Weil --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/conf

[Qemu-devel] [PATCH 09/11] configure: Fix compiler warning in config.log (value was never used)

2011-12-17 Thread Stefan Weil
Signed-off-by: Stefan Weil --- configure |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 31ea3ff..0c791b5 100755 --- a/configure +++ b/configure @@ -2269,8 +2269,7 @@ cat > $TMPC << EOF int main(void) { -int efd = eventfd(0, EFD_NONBL

[Qemu-devel] [PATCH 08/11] configure: Fix compiler warning in config.log (undefined NULL)

2011-12-17 Thread Stefan Weil
Avoid the warning when probing for xfs. Signed-off-by: Stefan Weil --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index b755ad1..31ea3ff 100755 --- a/configure +++ b/configure @@ -1670,6 +1670,7 @@ fi # xfsctl() probe, used for raw-p

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0 (was: Re: git-bisect results

2011-12-17 Thread Richard W.M. Jones
On Fri, Dec 16, 2011 at 07:44:10PM -0600, Anthony Liguori wrote: > On 12/16/2011 06:53 PM, Max Filippov wrote: > >>>git bisect says this. I didn't believe it first time, so I ran it > >>>twice with a few modifications, and it pointed to the same commit both > >>>times ... > >> > >>Richard, > >>cou

[Qemu-devel] [PATCH 10/11] configure: Fix compiler warnings in config.log (statement without effect)

2011-12-17 Thread Stefan Weil
Signed-off-by: Stefan Weil --- configure |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0c791b5..1ae380f 100755 --- a/configure +++ b/configure @@ -2074,7 +2074,7 @@ cat > $TMPC < #include #include -int main(void) { preadv; } +int ma

[Qemu-devel] [PATCH 07/11] configure: Fix compiler warnings in config.log (uninitialized variable)

2011-12-17 Thread Stefan Weil
warning: ‘fd’ is used uninitialized in this function warning: ‘id’ is used uninitialized in this function Signed-off-by: Stefan Weil --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index b799212..b755ad1 100755 --- a/configure +++ b

[Qemu-devel] [PATCH 06/11] configure: Fix compiler warning in config.log (macro redefined)

2011-12-17 Thread Stefan Weil
warning: "_GNU_SOURCE" redefined The macro is already defined on the command line. Signed-off-by: Stefan Weil --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index efc7b6b..b799212 100755 --- a/configure +++ b/configure @@ -2251,7 +22

[Qemu-devel] [PATCH 05/11] configure: Fix compiler warning in config.log (unused variable)

2011-12-17 Thread Stefan Weil
warning: unused variable ‘iov’ Signed-off-by: Stefan Weil --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5d860a7..efc7b6b 100755 --- a/configure +++ b/configure @@ -2060,7 +2060,7 @@ cat > $TMPC < #include #include -int mai

[Qemu-devel] [PATCH 11/11] configure: Improve Xen autodetection for hosts without Xen

2011-12-17 Thread Stefan Weil
With this patch, it only takes one test (instead of four) to detect that there is no Xen support at all. For most build hosts, this will reduce the time configure needs. It will also reduce noisy output in config.log. Build hosts with Xen now need up to five (instead of up to four) tests. They ge

[Qemu-devel] [PATCH 04/11] configure: Fix compiler warnings in config.log (null arguments)

2011-12-17 Thread Stefan Weil
warning: null argument where non-null required (argument 1) warning: null argument where non-null required (argument 3) Signed-off-by: Stefan Weil --- configure |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 8dee237..5d860a7 100755 ---

[Qemu-devel] [PATCH 01/11] configure: Fix compiler warnings in config.log (always return a value from main)

2011-12-17 Thread Stefan Weil
Fix several "warning: control reaches end of non-void function". Signed-off-by: Stefan Weil --- configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 6fd580e..03b8f35 100755 --- a/configure +++ b/configure @@ -1082,7 +1082,7 @@ fi

[Qemu-devel] [PATCH 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Stefan Weil
warning: return makes integer from pointer without a cast Signed-off-by: Stefan Weil --- configure |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 93c6cbe..8dee237 100755 --- a/configure +++ b/configure @@ -1841,7 +1841,11 @@ if test "$cu

[Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove

2011-12-17 Thread Geoffrey Thomas
Report an error when err is nonzero, not when it is zero. Signed-off-by: Geoffrey Thomas --- net/slirp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 6646ecb..18e07ba 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -351,7 +351,7 @@ void

Re: [Qemu-devel] [PATCH 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Peter Maydell
On 17 December 2011 08:27, Stefan Weil wrote: > warning: return makes integer from pointer without a cast > > Signed-off-by: Stefan Weil > --- >  configure |    6 +- >  1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index 93c6cbe..8dee237 100755 > --

Re: [Qemu-devel] [PATCH 00/11] configure: Fix compiler warnings in config.log

2011-12-17 Thread Peter Maydell
On 17 December 2011 08:27, Stefan Weil wrote: > Recently some patches were sent from Peter Maydell to improve > the output in config.log. > > This new patch series also improves that output by eliminating > some compiler warnings. All except 03/11: Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Stefan Weil
Am 17.12.2011 12:29, schrieb Peter Maydell: On 17 December 2011 08:27, Stefan Weil wrote: warning: return makes integer from pointer without a cast Signed-off-by: Stefan Weil --- configure |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/configure b/configure ind

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0 (was: Re: git-bisect results

2011-12-17 Thread Richard W.M. Jones
On Fri, Dec 16, 2011 at 07:44:10PM -0600, Anthony Liguori wrote: > Fairly certain this bisect is a red herring. > > tglx reported this the other day in IRC. He narrowed it down to > virtio-serial. He was able to reproduce it both with kvm tools and > QEMU. I looked at this a bit more closely, a

[Qemu-devel] [PULL] VirtFS update

2011-12-17 Thread Aneesh Kumar K.V
Hi Anthony, This include a signed pull request. I guess you would require a recent git to use the gpg info. The following changes since commit 774d5c5b1604b8443a8e42048b370b6c95dbfc40: cris: Handle conditional stores on CRISv10 (2011-12-12 11:38:31 +0100) are available in the git repository

Re: [Qemu-devel] [PATCH 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Peter Maydell
On 17 December 2011 12:11, Stefan Weil wrote: > Am 17.12.2011 12:29, schrieb Peter Maydell: >>> +  return s != (const char *)0; >> >> You don't need this cast, I think. > > Indeed, a quick test with gcc-4.4.5 shows no new warning when > I remove the type cast. Are you sure that this works with all

Re: [Qemu-devel] [PATCH 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Eric Blake
On 12/17/2011 07:09 AM, Peter Maydell wrote: >> Typically NULL is defined to be ((void *)0 for C >> (that's the reason why I used a type cast, too). Only for >> C++ it is defined without a type cast. > > The C standard permits plain "0" as a definition of NULL. POSIX concurs with the C standard t

[Qemu-devel] Changing vmexit behavior for a running guest

2011-12-17 Thread panda23
For sandboxing some forms of untrusted code, the risk of a red pill could be greatly reduced if qemu had "seccomp" mode, i.e., a way for a guest OS to request that qemu drop any future unwhitelisted vmexit calls. How complicated would it be to add this functionality to qemu and which parts of qemu

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Anthony Liguori
On 12/17/2011 02:33 AM, Richard W.M. Jones wrote: On Fri, Dec 16, 2011 at 07:44:10PM -0600, Anthony Liguori wrote: On 12/16/2011 06:53 PM, Max Filippov wrote: git bisect says this. I didn't believe it first time, so I ran it twice with a few modifications, and it pointed to the same commit bot

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 09:13:52AM -0600, Anthony Liguori wrote: > Okay, I can reproduce this now with a F15 guest. > > I've narrowed it down to '-nodefaults -serial stdio'. Can you > confirm that if you remove those options it works for you? Confirmed: removing those options allows it to boot n

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Anthony Liguori
On 12/17/2011 09:13 AM, Anthony Liguori wrote: On 12/17/2011 02:33 AM, Richard W.M. Jones wrote: On Fri, Dec 16, 2011 at 07:44:10PM -0600, Anthony Liguori wrote: On 12/16/2011 06:53 PM, Max Filippov wrote: git bisect says this. I didn't believe it first time, so I ran it twice with a few modif

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > I've even further narrowed it down to the presents or lack of '-vga > cirrus'. If you add '-vga cirrus' to the above command line, the > guest will boot successfully. Confirmed: Adding -vga cirrus to the command line cures it too.

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Anthony Liguori
On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: I've even further narrowed it down to the presents or lack of '-vga cirrus'. If you add '-vga cirrus' to the above command line, the guest will boot successfully. Confirmed: Addi

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: > On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: > >On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > >>I've even further narrowed it down to the presents or lack of '-vga > >>cirrus'. If you add '-vga cirrus' to

[Qemu-devel] [PATCH v2 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Stefan Weil
warning: return makes integer from pointer without a cast v2: Removed type cast. Signed-off-by: Stefan Weil --- configure |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 93c6cbe..773df6a 100755 --- a/configure +++ b/configure @@ -1841,7

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Kevin O'Connor
On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: > On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: > >On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > >>I've even further narrowed it down to the presents or lack of '-vga > >>cirrus'. If you add '-vga cirrus' to

Re: [Qemu-devel] [PATCH v2 03/11] configure: Fix compiler warning in config.log (integer from pointer)

2011-12-17 Thread Peter Maydell
On 17 December 2011 16:46, Stefan Weil wrote: > warning: return makes integer from pointer without a cast > > v2: Removed type cast. > > Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell > --- >  configure |    6 +- >  1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/c

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Anthony Liguori
On 12/17/2011 10:49 AM, Kevin O'Connor wrote: On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: I've even further narrowed it down to the presents or lack of '-vga

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 11:49:56AM -0500, Kevin O'Connor wrote: > On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: > > On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: > > >On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > > >>I've even further narrowed it down to

Re: [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove

2011-12-17 Thread Jan Kiszka
On 2011-12-17 10:23, Geoffrey Thomas wrote: > Report an error when err is nonzero, not when it is zero. > > Signed-off-by: Geoffrey Thomas > --- > net/slirp.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/slirp.c b/net/slirp.c > index 6646ecb..18e07ba 100644

[Qemu-devel] [PATCH 0/3] target-mips improvements

2011-12-17 Thread Richard Henderson
I was interested in testing some Loongson vectorization code for GCC. These, plus a handfull of other hacks on top of Khansa Butt's mips64-linux-user patches, does a fair job of it. I'll post the hacks under separate cover, as I don't know what the real fix ought to be; I just forced the cpu flags

[Qemu-devel] [PATCH 1/3] target-mips: Streamline indexed cp1 memory addressing.

2011-12-17 Thread Richard Henderson
We've already eliminated both base and index being zero. Signed-off-by: Richard Henderson --- target-mips/translate.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d5b1c76..b20a817 100644 --- a/target-mips/trans

[Qemu-devel] [PATCH 3/3] target-mips: Implement Loongson Multimedia Instructions

2011-12-17 Thread Richard Henderson
Implements all of the COP2 instructions except for the S family of comparisons. The documentation is unclear for those. Signed-off-by: Richard Henderson --- Makefile.target |3 + target-mips/helper.h | 59 target-mips/lmi_helper.c | 744 +

[Qemu-devel] [PATCH 2/3] mips-linux-user: Always support rdhwr.

2011-12-17 Thread Richard Henderson
The kernel will emulate this instruction if it's not supported natively. This insn is used for TLS, among other things, and so is required by modern glibc. Signed-off-by: Richard Henderson --- target-mips/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ta

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

2011-12-17 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/241

[Qemu-devel] Patch to add iSCSI configuration optionsi. Version 2

2011-12-17 Thread Ronnie Sahlberg
List, Please find attached a patch that adds configuration variables for iSCSI to set CHAP username/password, header-digest settings and the iqn to use when logging in to the target. The patch is updated to produce an error if the username is set but no password was given. regards ronnie sahl

[Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2011-12-17 Thread Ronnie Sahlberg
This patch adds configuration variables for iSCSI to set initiator-name to use when logging in to the target, which type of header-digest to negotiate with the target and username and password for CHAP authentication. This allows specifying a initiator-name either from the command line -iscsi init