- Original Message -
> I have been following this thread pretty closely and the one sentence
> summary of
> the current argument is: ovirt-guest-agent is already featureful and
> tested, so
> let's drop qemu-ga and have everyone adopt ovirt-guest-agent.
What we're suggesting is let's dro
- Original Message -
> On 11/16/2011 11:53 AM, Barak Azulay wrote:
> > On Wednesday 16 November 2011 17:28:16 Michael Roth wrote:
> >> 2) You'd also need a schema, similar to
> >> qemu.git/qapi-schema-guest.json,
> >> to describe the calls you're proxying. The existing infrastructure
> >>
Public bug reported:
Target: x86_64-softmmu
Qemu Command line: [root@hs22 qemu-1.0-rc2]# ./x86_64-softmmu/qemu-
system-x86_64 -smp sockets=2,cores=4,threads=2 -numa
node,nodeid=0,mem=4g -numa node,nodeid=1,mem=1g -cpu core2duo -m 5g
/home/bharata/f15-lvm -nographic --enable-kvm -net
nic,macaddr=5
Hi,
A recent patch in qemu conflicts with old ncurses libraries (version 5.3). You
will see this error cause by bool type redefinition in curses.h (with
CONFIG_CURSES configured by default):
console.c: In function 'text_console_init':
console.c:1550:23: error: assignment from incompatible point
On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
make clean missed the source qmp files generated
by python. Fix that.
Signed-off-by: Michael S. Tsirkin
---
Makefile |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 168093c..b335f2a 100644
--
On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
.c files include .h files, so .o depends on .h,
and the linked result depends on .o.
We got it wrong for qga rules, fix it up.
Another possible option is to make the "all" target depend on
GENERATED_HEADERS and GENERATED_SOURCES, like
all: $(
On Wed, Nov 16, 2011 at 5:23 PM, Ian Campbell wrote:
> On Wed, 2011-11-16 at 10:34 +, Stefan Hajnoczi wrote:
>> On Wed, Nov 16, 2011 at 6:57 AM, Chunyan Liu wrote:
>> > Currently qemu-nbd does not support finding free nbd device for users like
>> > "losetup -f" and issuing "qemu-nbd -c /dev/n
On Wed, Nov 16, 2011 at 06:55:06PM +0100, Hans de Goede wrote:
> Hi,
>
> On 11/16/2011 02:47 PM, Anthony Liguori wrote:
> >On 11/16/2011 06:07 AM, Alon Levy wrote:
> >>On Wed, Nov 16, 2011 at 08:53:45AM +0100, Hans de Goede wrote:
> >>>Hi,
> >>>
> >>>On 11/15/2011 11:39 PM, Ayal Baron wrote:
> >>>
On 14 November 2011 09:39, Bertrand Cachet wrote:
> @@ -977,6 +977,15 @@ static void lan9118_writel(void *opaque,
> target_phys_addr_t offset,
> s->pmt_ctrl &= ~0x34e;
> s->pmt_ctrl |= (val & 0x34e);
> break;
> + case CSR_BYTE_TEST:
> + /* Even if this register i
On Thu, Nov 17, 2011 at 06:55:14PM +0800, hkran wrote:
> On 11/17/2011 02:37 PM, Gleb Natapov wrote:
> >On Thu, Nov 17, 2011 at 02:29:47PM +0800, hkran wrote:
> >>On 11/16/2011 06:51 PM, Gleb Natapov wrote:
> >>>On Wed, Nov 16, 2011 at 10:48:15AM +, Stefan Hajnoczi wrote:
> On Wed, Nov 16,
On Wed, 2011-11-16 at 19:56 +, Anthony Liguori wrote:
> On 11/16/2011 12:41 PM, Peter Maydell wrote:
> > Pawel may have more detail, but to me the significant difference
> > is that virtio-mmio is an implementation of a specification extension
> > agreed with the virtio spec maintainers, wherea
Thanks for your suggestions.
For the usage "qemu-nbd -f disk.img", adding some code could implement it. I
think it could be like "losetup -f" usage.
#qemu-nbd -f
show the first free nbd device at this moment.
user can choose to issue "qemu-nbd -c THAT_DEVICE disk.img" or not.
#qemu-nbd -f d
Adding -f option to qemu-nbd to support finding a free nbd device and connect
disk image to that device. Usage of this option is similar to "losetup -f".
#qemu-nbd -f
show the first free nbd device found at the very moment.
#qemu-nbd -f disk.img
find a free nbd device and connect disk.img to that d
On 11/17/2011 12:20 PM, Pawel Moll wrote:
> Correct. Syborg virtio was something Paul Brook did bit is not an "official"
> virtio transport as far as Linux or the spec is concerned.
Honestly, that's the first time I hear about it, and as I'm not allowed
to look at qemu code (legal reasons, ju
On 11/17/2011 02:37 PM, Gleb Natapov wrote:
On Thu, Nov 17, 2011 at 02:29:47PM +0800, hkran wrote:
On 11/16/2011 06:51 PM, Gleb Natapov wrote:
On Wed, Nov 16, 2011 at 10:48:15AM +, Stefan Hajnoczi wrote:
On Wed, Nov 16, 2011 at 10:14 AM, hkran wrote:
On 11/15/2011 09:17 PM, Stefan Hajno
Bonjour,
Je suis chargé du référencement du site http://sens.guide-demenagement.com,
site référence dans lunivers du déménagement.
Je me permets de vous contacter pour vous demander un échange de liens entre
nos sites, ce qui améliorerait nos r
Am 17.11.2011 10:31, schrieb Paolo Bonzini:
> On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
>> .c files include .h files, so .o depends on .h,
>> and the linked result depends on .o.
>> We got it wrong for qga rules, fix it up.
>
> Another possible option is to make the "all" target depend on
Signed-off-by: Benoit Canet
---
hw/sh7750.c |2 +-
hw/sh_intc.c| 87 ++
hw/sh_intc.h|7 +++-
target-sh4/helper.c |3 ++
4 files changed, 68 insertions(+), 31 deletions(-)
diff --git a/hw/sh7750.c b/hw/sh7750.c
Signed-off-by: Benoit Canet
---
hw/sh.h |3 ++-
hw/sh7750.c |4 ++--
hw/sh_timer.c | 43 ---
3 files changed, 28 insertions(+), 22 deletions(-)
diff --git a/hw/sh.h b/hw/sh.h
index cf3f6f6..c764be6 100644
--- a/hw/sh.h
+++ b/hw/sh.h
@@ -3
Signed-off-by: Benoit Canet
---
hw/r2d.c|2 +-
hw/sh.h |3 +-
hw/sh7750.c | 72 --
hw/shix.c |2 +-
4 files changed, 49 insertions(+), 30 deletions(-)
diff --git a/hw/r2d.c b/hw/r2d.c
index a9aefa2..9b6fcba 100644
--
These patches converts the remaining sh4 devices to the memory API.
The patch "sh_intc: convert interrupt controller to memory API" is
somewhat tricky.
Benoît Canet (5):
sh7750: convert memory controller/ioport to memory API
sh7750: convert cache and tlb to memory API
sh_timer: convert to me
Signed-off-by: Benoit Canet
---
hw/sh7750.c | 43 ++-
1 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/hw/sh7750.c b/hw/sh7750.c
index 5cee76a..fd48c4a 100644
--- a/hw/sh7750.c
+++ b/hw/sh7750.c
@@ -42,6 +42,7 @@ typedef struct SH7750State
Signed-off-by: Benoit Canet
---
hw/sh.h|3 ++-
hw/sh7750.c| 28 +++-
hw/sh_serial.c | 55 ++-
3 files changed, 47 insertions(+), 39 deletions(-)
diff --git a/hw/sh.h b/hw/sh.h
index c764be6..0e45d61 1
On Fri, 11 Nov 2011 15:39:29 +0530
Supriya Kannery wrote:
> On 11/11/2011 12:17 PM, Supriya Kannery wrote:
> > Enhance "info block" to display hostcache setting for each
> > block device.
> >
> >
> > ##
> > Index: qemu/qapi-types.h
> >
于 2011/11/16,星期三 2:43, Cam Macdonell 写道:
On Sun, Nov 13, 2011 at 8:56 PM, wrote:
From: Hongyong Zang
Ivshmem(nahanni) is a mechanism for sharing host memory with VMs running on the
same host. Currently, guest notifies qemu by reading or writing ivshmem
device's PCI MMIO BAR0(Doorbell).
This
On 11/17/2011 02:24 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
>
> /* sh775x interrupt controller tables for sh_intc.c
> @@ -706,30 +714,40 @@ static CPUWriteMemoryFunc * const sh7750_mmct_write[] =
> {
> sh7750_mmct_writel
> };
>
> -SH7750State *sh7750_init(CPUSH4State * cp
On Fri, 11 Nov 2011 12:17:35 +0530
Supriya Kannery wrote:
> New error classes defined for file reopen failure and data
> sync error
>
> Signed-off-by: Supriya Kannery
>
> ---
> qerror.c |8
> qerror.h |6 ++
> 2 files changed, 14 insertions(+)
>
> Index: qemu/qerror.c
>
2011/11/17 Benoît Canet :
> Signed-off-by: Benoit Canet
> --- a/hw/sh7750.c
> +++ b/hw/sh7750.c
> @@ -756,7 +756,7 @@ SH7750State *sh7750_init(CPUSH4State * cpu, MemoryRegion
> *sysmem)
> "cache-and-tlb", 0x0800);
> memory_region_add_subregion(sysmem, 0xf000,
On 11/17/2011 02:56 PM, Peter Maydell wrote:
> 2011/11/17 Benoît Canet :
> > Signed-off-by: Benoit Canet
> > --- a/hw/sh7750.c
> > +++ b/hw/sh7750.c
> > @@ -756,7 +756,7 @@ SH7750State *sh7750_init(CPUSH4State * cpu,
> > MemoryRegion *sysmem)
> > "cache-and-tlb", 0x08000
From: Stefan Weil
This bug was detected by codespell.
In mips_mipssim.c a grammatical error was fixed, too.
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
docs/libcacard.txt |2 +-
hw/mips_mipssim.c |2 +-
qemu-doc.texi |4 ++--
3 files changed, 4 insertions(+
These bug fixes and documentation fixes are suitable for 1.0. The purely
internal trivial patches are being queued up for 1.1 in the
trivial-patches-next tree.
The following changes since commit 3f5bd4e1b874590d3d76e031530799a4610da6dc:
Update version to 1.0-rc2 (2011-11-14 11:26:32 -0600)
ar
From: Vagrant Cascadian
One n too many for running, need we say more.
Signed-Off-By: Vagrant Cascadian
Signed-off-by: Stefan Hajnoczi
---
target-i386/kvm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index ddd115c..5bfc21f 1
From: Markus Armbruster
stat() can fail for a file name just read with readdir(). Easiest way
to trigger is a dangling symbolic link --- look ma, no race! When it
fails, file_completion() uses sb.st_mode uninitialized. If the
directory bit happens to be set, it appends a "/" to the completed
n
From: Matthias Brugger
Reviewed-by: Alon Levy
Signed-off-by: Matthias Brugger
Signed-off-by: Stefan Hajnoczi
---
docs/libcacard.txt | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/libcacard.txt b/docs/libcacard.txt
index 296706a..f7d7519 100644
--- a/d
From: Stefan Weil
These errors were detected by codespell:
remaing -> remaining
soley -> solely
virutal -> virtual
seperate -> separate
libcacard.txt still needs some more patches.
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
block-migration.c |2 +-
docs/libcacard
Yes, allocating the exact size would make the realloc unnecessary. But it
involve more code to walk one more time through the mask_reg and prio_reg
array before allocating.
I made it this way to make code shorter.
The freed MemoryRegion are not initialized at all.
However as realloc seems to be a
On Fri, 11 Nov 2011 12:17:48 +0530
Supriya Kannery wrote:
> New command "block_set_hostcache" added for dynamically changing
> host pagecache setting of a block device.
>
> Usage:
> block_set_hostcache
> = block device
> = on/off
>
> Example:
> (qemu) block_set_hostcache ide0-hd0
On Thu, 17 Nov 2011 11:15:06 +0530
Supriya Kannery wrote:
> On 11/17/2011 12:04 AM, Stefan Hajnoczi wrote:
> > On Fri, Nov 11, 2011 at 6:47 AM, Supriya Kannery
> > wrote:
> >> +{
> >> +.name = "block_set_hostcache",
> >> +.args_type = "device:B,option:b",
> >> +
On Fri, 11 Nov 2011 12:18:18 +0530
Supriya Kannery wrote:
> Struct BDRVReopenState along with three reopen related functions
> introduced for handling reopen state of images safely. This can be
> extended by each of the block drivers to reopen respective
> image files.
Shouldn't this patch come
On Wed, 16 Nov 2011 23:58:46 +0200
"Michael S. Tsirkin" wrote:
> make clean missed the source qmp files generated
> by python. Fix that.
>
> Signed-off-by: Michael S. Tsirkin
Michael, this series is for 1.0, right?
> ---
> Makefile |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-
These patches converts the remaining sh4 devices to the memory API.
The patch "sh_intc: convert interrupt controller to memory API" is
somewhat tricky
V2:
Cosmetic change of a memory region size in
"sh7750: convert memory controller/ioport to memory API".
Remove the realloc in "convert interrupt
Signed-off-by: Benoit Canet
---
hw/r2d.c|2 +-
hw/sh.h |3 +-
hw/sh7750.c | 72 --
hw/shix.c |2 +-
4 files changed, 49 insertions(+), 30 deletions(-)
diff --git a/hw/r2d.c b/hw/r2d.c
index a9aefa2..9b6fcba 100644
--
Signed-off-by: Benoit Canet
---
hw/sh7750.c | 43 ++-
1 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/hw/sh7750.c b/hw/sh7750.c
index 3bf568d..6ad76df 100644
--- a/hw/sh7750.c
+++ b/hw/sh7750.c
@@ -42,6 +42,7 @@ typedef struct SH7750State
Signed-off-by: Benoit Canet
---
hw/sh7750.c |2 +-
hw/sh_intc.c| 85 ++-
hw/sh_intc.h|7 +++-
target-sh4/helper.c |3 ++
4 files changed, 66 insertions(+), 31 deletions(-)
diff --git a/hw/sh7750.c b/hw/sh7750.c
On Thu, Nov 17, 2011 at 11:21:01AM -0200, Luiz Capitulino wrote:
> On Wed, 16 Nov 2011 23:58:46 +0200
> "Michael S. Tsirkin" wrote:
>
> > make clean missed the source qmp files generated
> > by python. Fix that.
> >
> > Signed-off-by: Michael S. Tsirkin
>
> Michael, this series is for 1.0, rig
Add macros for aligning a number to a multiple, for example:
QEMU_ALIGN_DOWN(500, 2000) = 0
QEMU_ALIGN_UP(500, 2000) = 2000
Since ALIGN_UP() is a common macro name use the QEMU_* namespace prefix.
Hopefully this will protect us from included headers that leak something
with a similar name.
Signe
Signed-off-by: Stefan Hajnoczi
---
block.c | 72 ++
trace-events |1 +
2 files changed, 73 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index 0eef122..d5faa6c 100644
--- a/block.c
+++ b/block.c
@@ -1464,6 +1464,61
On 11/17/2011 12:36 PM, Chunyan Liu wrote:
Adding lock to the nbd device before connecting disk image to that device to
handling race conditions.
This removes the possibility for other programs to lock. Have you
checked what happens if you use the same device twice and whether you
can piggy
On 11/17/2011 02:40 PM, Stefan Hajnoczi wrote:
When copy-on-read is enabled it is necessary to wait for overlapping
requests before issuing new requests. This prevents races between the
copy-on-read and a write request.
What about discards?
Paolo
On Thu, Nov 17, 2011 at 1:43 PM, Paolo Bonzini wrote:
> On 11/17/2011 02:40 PM, Stefan Hajnoczi wrote:
>>
>> When copy-on-read is enabled it is necessary to wait for overlapping
>> requests before issuing new requests. This prevents races between the
>> copy-on-read and a write request.
>
> What
On Thu, Nov 17, 2011 at 1:41 PM, Paolo Bonzini wrote:
> On 11/17/2011 12:36 PM, Chunyan Liu wrote:
>>
>> Adding lock to the nbd device before connecting disk image to that device
>> to
>> handling race conditions.
>
> This removes the possibility for other programs to lock. Have you checked
> wha
** Patch added: "udef.diff"
https://bugs.launchpad.net/bugs/891625/+attachment/2599656/+files/udev.diff
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/891625
Title:
[qemu-kvm] add vhost-net to kv
Public bug reported:
Please consider authorizing the kvm group to access vhost-net device, similar
to the kvm device.
Thanks!
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed t
Hi,
I have a cluster of similar qemu machines, for doing some simulation.
I'm using e1000 as network driver.
When loading few machines, we encounter hangs of networking inside a
virtual machine, and
it will hang all the interfaces inside the machine.
If I'll do down/up to all interfaces, the networ
Detect overlapping requests and remember to align to cluster boundaries
if the image format uses them. This assumes that allocating I/O is
performed in cluster granularity - which is true for qcow2, qed, etc.
Signed-off-by: Stefan Hajnoczi
---
block.c | 40
When copy-on-read is enabled it is necessary to wait for overlapping
requests before issuing new requests. This prevents races between the
copy-on-read and a write request.
Signed-off-by: Stefan Hajnoczi
---
block.c | 35 +++
1 files changed, 35 insertions(+),
The new -drive copy-on-read=on|off feature populates the image file with data
from the backing file on read. This is useful when accessing images backed
over a slow medium (e.g. http over internet). All read data will be stored in
the local image file so it does not need to be fetched again in th
The bdrv_set_copy_on_read() function can be used to programmatically
enable or disable copy-on-read for a block device. Later patches add
the actual copy-on-read logic.
Signed-off-by: Stefan Hajnoczi
---
block.c | 22 ++
block.h |3 +++
block_int.h |2 ++
3
On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery
wrote:
> On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote:
>>
>> On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
>> wrote:
>>>
>>> + if ((hostcache = qemu_opt_get_bool(opts, "hostcache", -1)) !=
>>> -1) {
>>
>> This does not work. qemu_opt_g
It's common to wake up all waiting coroutines. Introduce the
qemu_co_queue_restart_all() function to do this instead of looping over
qemu_co_queue_next() in every caller.
Signed-off-by: Stefan Hajnoczi
---
block/qcow2.c |2 +-
qemu-coroutine-lock.c | 15 ---
qemu-corou
The block layer does not know about pending requests. This information
is necessary for copy-on-read since overlapping requests must be
serialized to prevent races that corrupt the image.
The BlockDriverState gets a new tracked_request list field which
contains all pending requests. Each request
This patch adds the -drive copy-on-read=on|off command-line option:
copy-on-read=on|off
copy-on-read is "on" or "off" and enables whether to copy read backing
file sectors into the image file. Copy-on-read avoids accessing the
same backing file sectors repeatedly and is useful when the ba
Signed-off-by: Benoit Canet
---
hw/sh.h|3 ++-
hw/sh7750.c| 28 +++-
hw/sh_serial.c | 55 ++-
3 files changed, 47 insertions(+), 39 deletions(-)
diff --git a/hw/sh.h b/hw/sh.h
index c764be6..0e45d61 1
Signed-off-by: Benoit Canet
---
hw/sh.h |3 ++-
hw/sh7750.c |4 ++--
hw/sh_timer.c | 43 ---
3 files changed, 28 insertions(+), 22 deletions(-)
diff --git a/hw/sh.h b/hw/sh.h
index cf3f6f6..c764be6 100644
--- a/hw/sh.h
+++ b/hw/sh.h
@@ -3
On Thu, Nov 17, 2011 at 11:34 AM, Chun Yan Liu wrote:
> Thanks for your suggestions.
>
> For the usage "qemu-nbd -f disk.img", adding some code could implement it. I
> think it could be like "losetup -f" usage.
>
> #qemu-nbd -f
>
> show the first free nbd device at this moment.
>
> user can choose
>>> On 11/16/2011 03:36 PM, Anthony Liguori wrote:
We have another requirement. We need to embed the source for the guest
agent in the QEMU release tarball. This is for GPL compliance since we
want to include an ISO (eventually) that contains binaries.
Paolo Bonzini wrote:
> ovirt-g
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
wrote:
> @@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in
> qerror_report(QERR_DATA_SYNC_FAILED, bs->device_name);
> return ret;
> }
> - open_flags = bs->open_flags;
> - bdrv_close(bs);
>
> - ret = bdrv_ope
On 11/14/2011 05:56 AM, zanghongy...@huawei.com wrote:
> From: Hongyong Zang
>
> Ivshmem(nahanni) is a mechanism for sharing host memory with VMs running on
> the same host. Currently, guest notifies qemu by reading or writing ivshmem
> device's PCI MMIO BAR0(Doorbell).
>
> This patch, changes t
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
wrote:
> +static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState **prs,
> + int flags)
> +{
> + BDRVRawReopenState *raw_rs = g_malloc0(sizeof(BDRVRawReopenState));
> + BDRVRawState *s = bs->opaque;
> +
On 11/17/2011 02:59 AM, Ayal Baron wrote:
- Original Message -
On 11/16/2011 11:53 AM, Barak Azulay wrote:
On Wednesday 16 November 2011 17:28:16 Michael Roth wrote:
2) You'd also need a schema, similar to
qemu.git/qapi-schema-guest.json,
to describe the calls you're proxying. The ex
On Thu, 2011-11-17 at 16:36 +0200, Avi Kivity wrote:
> On 11/14/2011 05:56 AM, zanghongy...@huawei.com wrote:
> > From: Hongyong Zang
> >
> > Ivshmem(nahanni) is a mechanism for sharing host memory with VMs running on
> > the same host. Currently, guest notifies qemu by reading or writing ivshmem
On 11/17/2011 02:46 AM, Ayal Baron wrote:
- Original Message -
I have been following this thread pretty closely and the one sentence
summary of
the current argument is: ovirt-guest-agent is already featureful and
tested, so
let's drop qemu-ga and have everyone adopt ovirt-guest-agent.
On 11/17/2011 04:48 PM, Sasha Levin wrote:
> On Thu, 2011-11-17 at 16:36 +0200, Avi Kivity wrote:
> > On 11/14/2011 05:56 AM, zanghongy...@huawei.com wrote:
> > > From: Hongyong Zang
> > >
> > > Ivshmem(nahanni) is a mechanism for sharing host memory with VMs running
> > > on the same host. Curre
sn->id_str could be leaked before this. The rest of this patch changes
comments, fixes coding style or removes checks that are unnecessary with
g_malloc.
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 26 +++---
1 files changed, 11 insertions(+), 15 deletions(-)
di
Doesn't immediately fix anything as the callers don't use the return
value, but they will be fixed next.
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 48 ++--
1 files changed, 38 insertions(+), 10 deletions(-)
diff --git a/block/qcow2-snap
Increase refcounts only after allocating a new L1 table has succeeded in
order to make leaks less likely. If writing the snapshot table fails,
revert in-memory state to be consistent with that on disk.
While at it, make it return the real error codes instead of -1.
Signed-off-by: Kevin Wolf
---
The refcount updates must be moved so that in the worst case we can get
cluster leaks, but refcounts may never be too low.
Signed-off-by: Kevin Wolf
---
block/qcow2-refcount.c |7 -
block/qcow2-snapshot.c | 61 ++-
2 files changed, 50 inserti
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 50 +--
1 files changed, 39 insertions(+), 11 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index 066d56b..9f6647f 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow
If the bdrv_read() of the snapshot's L1 table fails, return the right
error code and make sure that the old L1 table is still loaded and we
don't break the BlockDriverState completely.
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 33 +
1 files changed,
Hi all,
This patch series introduces the PCI passthrough for Xen.
First, we have HostPCIDevice that help to access one PCI device of the host.
Then, there is an additions in the QEMU code, pci_check_bar_overlap.
There are also several change in pci_ids and pci_regs.
Last part, but not least,
Signed-off-by: Anthony PERARD
---
hw/pci_ids.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci_ids.h b/hw/pci_ids.h
index 83f3893..2ea5ec2 100644
--- a/hw/pci_ids.h
+++ b/hw/pci_ids.h
@@ -117,6 +117,7 @@
#define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
#define PCI
Signed-off-by: Anthony PERARD
---
Makefile.target |1 +
hw/host-pci-device.c | 279 ++
hw/host-pci-device.h | 75 ++
3 files changed, 355 insertions(+), 0 deletions(-)
create mode 100644 hw/host-pci-device.c
create mode 100
From: Yuji Shimada
This function help Xen PCI Passthrough device to check for overlap.
Signed-off-by: Yuji Shimada
Signed-off-by: Anthony PERARD
---
hw/pci.c | 47 +++
hw/pci.h |3 +++
2 files changed, 50 insertions(+), 0 deletions(-)
diff --
Value check in PCI Express Base Specification rev 1.1
Signed-off-by: Anthony PERARD
---
hw/pci_regs.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci_regs.h b/hw/pci_regs.h
index e8357c3..6b42515 100644
--- a/hw/pci_regs.h
+++ b/hw/pci_regs.h
@@ -393,7 +393,7 @@
Signed-off-by: Anthony PERARD
---
Makefile.target |2 ++
configure | 25 +
2 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index a111521..2e881ce 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -219,6 +219
Signed-off-by: Anthony PERARD
---
hw/pci_regs.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci_regs.h b/hw/pci_regs.h
index 6b42515..56a404b 100644
--- a/hw/pci_regs.h
+++ b/hw/pci_regs.h
@@ -392,6 +392,7 @@
#define PCI_EXP_TYPE_UPSTREAM 0x5 /* Upstream Port
This patch move the msi definition from apic.c to apic-msidef.h. So it can be
used also by other .c files.
Signed-off-by: Anthony PERARD
Cc: Michael S. Tsirkin
---
hw/apic-msidef.h | 28
hw/apic.c| 11 +--
2 files changed, 29 insertions(+), 10 de
From: Allen Kay
A more complete history can be found here:
git://xenbits.xensource.com/qemu-xen-unstable.git
Signed-off-by: Allen Kay
Signed-off-by: Guy Zana
Signed-off-by: Anthony PERARD
---
Makefile.target |2 +
hw/xen_common.h |3 +
hw/xen
From: Jiang Yunhong
A more complete history can be found here:
git://xenbits.xensource.com/qemu-xen-unstable.git
Signed-off-by: Jiang Yunhong
Signed-off-by: Shan Haitao
Signed-off-by: Anthony PERARD
---
Makefile.target |1 +
hw/apic-msidef.h |
First the snapshot must be deleted and only then the refcounts can be
decreased.
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 48 +---
1 files changed, 33 insertions(+), 15 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-sna
On Wed, Nov 16, 2011 at 08:59:35AM -0600, Michael Roth wrote:
> On 11/16/2011 02:16 AM, Ayal Baron wrote:
> >
> >
> >- Original Message -
> >>Hi,
> >>
> >>On 11/15/2011 11:39 PM, Ayal Baron wrote:
> >>>
> >>
> >>
> >>
> If you want to talk about convergence, the discussion should start
On Tue, Nov 15, 2011 at 11:57 AM, M. Mohan Kumar wrote:
> +static void send_fd(int sockfd, int fd)
> +{
> + struct msghdr msg = { };
> + struct iovec iov;
> + struct cmsghdr *cmsg;
> + int retval, data;
> + union MsgControl msg_control;
> +
> + iov.iov_base = &data;
> + iov.io
This is more or less the same kind of fixes that we made in the rest of qcow2
last year: Return the right error codes and make the order of operations safe
so that a crash can lead to no more than cluster leaks.
Although all of these are bug fixes, I'm not so sure about taking them into
1.0. Maybe
On Thu, Nov 17, 2011 at 03:46:37AM -0500, Ayal Baron wrote:
>
>
> - Original Message -
> > I have been following this thread pretty closely and the one sentence
> > summary of the current argument is: ovirt-guest-agent is already featureful
> > and tested, so let's drop qemu-ga and have e
On Tue, Nov 15, 2011 at 12:09 PM, M. Mohan Kumar wrote:
> Changes from previous version:
>
> 1) Communication between qemu and helper process is similar to 9p way of
> packing
> elements (pdu marshaling).
There is code I haven't reviewed yet but I think it will change as you
add input validation,
On 11/17/2011 03:22 PM, Benoît Canet wrote:
> These patches converts the remaining sh4 devices to the memory API.
> The patch "sh_intc: convert interrupt controller to memory API" is
> somewhat tricky
>
>
Thanks, applied. Please adjust your editor to display tabs as 8
positions, not 4. Your patc
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 25 -
block/qcow2.c |5 +++--
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index fb7f58c..db49bb3 100644
--- a/block/qcow2-snapshot.c
++
On Thu, Nov 17, 2011 at 09:58:33AM -0600, Adam Litke wrote:
> On Thu, Nov 17, 2011 at 03:46:37AM -0500, Ayal Baron wrote:
> >
> >
> > - Original Message -
> > > I have been following this thread pretty closely and the one sentence
> > > summary of the current argument is: ovirt-guest-agen
On Thursday 17 November 2011 02:48:50 Michael Roth wrote:
> I've tried to summarize the pros/cons, points, and proposals outlined in
> this thread at the following wiki:
>
> http://www.ovirt.org/wiki/Guest_agent_proposals
>
> Please feel free to add/edit as needed. If you don't have an account on
On Thu, Nov 17, 2011 at 11:14 AM, Daniel P. Berrange
wrote:
> On Thu, Nov 17, 2011 at 09:58:33AM -0600, Adam Litke wrote:
>> On Thu, Nov 17, 2011 at 03:46:37AM -0500, Ayal Baron wrote:
>> >
>> >
>> > - Original Message -
>> > > I have been following this thread pretty closely and the one s
1 - 100 of 119 matches
Mail list logo
