[Qemu-devel] [PATCH] qcow2: fix some errors and typo in qcow2.txt

2011-10-27 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- docs/specs/qcow2.txt |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 8fc3cb2..e792953 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt @@ -108,8 +108,8 @@ as follows:

[Qemu-devel] [PATCH v2] migration: flush migration data to disk.

2011-10-27 Thread Gerd Hoffmann
This patch increases robustness when migrating to a file with two little changes: (1) Before closing the migration file handle checks if it happens to be a regular file and if so it issues a fsync. This way the data is flushed to disk before qemu sends the migration completed event. (

Re: [Qemu-devel] [PATCH 4/7] ide: Fix off-by-one error in array index check

2011-10-27 Thread Paolo Bonzini
On 10/26/2011 02:31 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- hw/ide/core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 280a117..29305d3 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2039,7 +2039,7 @@ static int i

Re: [Qemu-devel] [PATCH 3/7] qcow: Fix bdrv_write_compressed error handling

2011-10-27 Thread Paolo Bonzini
On 10/26/2011 02:31 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- block/qcow.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index ab36b29..35e21eb 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -736,8

[Qemu-devel] libacard build error

2011-10-27 Thread Jan Kiszka
Hi Alon, I'm getting this with current qemu.git: CClibcacard/vcard_emul_nss.o cc1: warnings being treated as errors In file included from /usr/include/nss3/pkcs11t.h:1780:0, from /usr/include/nss3/keythi.h:41, from /usr/include/nss3/keyt.h:41,

Re: [Qemu-devel] libacard build error

2011-10-27 Thread Alon Levy
On Thu, Oct 27, 2011 at 09:33:50AM +0200, Jan Kiszka wrote: > Hi Alon, > > I'm getting this with current qemu.git: > > CClibcacard/vcard_emul_nss.o > cc1: warnings being treated as errors > In file included from /usr/include/nss3/pkcs11t.h:1780:0, > from /usr/include/nss3/k

Re: [Qemu-devel] [QEMU : VVFAT] vvfat.c - help required for understanding/modification

2011-10-27 Thread Kevin Wolf
Am 26.10.2011 21:17, schrieb Pintu Kumar: > Dear Mr. Johannes, > > I am sorry but I think you took me wrong. I never asked you to do things for > me. > I just wanted few clarifications to proceed further as I was stuck > after performing few experiments as below: You are stuck because you still

Re: [Qemu-devel] Abnormal function exit message in Qemu block drivers code

2011-10-27 Thread Cao,Bing Bu
On 10/27/2011 02:16 PM, shu ming wrote: Hi, After reading the block driver code in, it was found that the error exit code behaved in different ways. Here are some examples. It seems that way 3 is a better way to log the error message. In fact, It is pretty important for a administrator

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-10-27 Thread Jan Kiszka
On 2011-10-27 05:21, Roy Tam wrote: > 2011/10/27 Roy Tam : >> Hi, >> >> 2011/10/26 Jan Kiszka : >>> On 2011-10-26 10:03, Roy Tam wrote: Hi, 2011/9/15 Jan Kiszka : > On 2011-09-15 15:20, Roy Tam wrote: >> 2011/9/15 Jan Kiszka : >>> On 2011-09-15 14:05, Roy Tam wrote: >

Re: [Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 11:51:37PM +1100, Ronnie Sahlberg wrote: > > Signed-off-by: Ronnie Sahlberg > --- > qemu-options.hx | 42 ++ > 1 files changed, 42 insertions(+), 0 deletions(-) Good idea, thanks for adding documentation. Reviewed-by: Stefan Haj

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 06:35:08PM +0200, Stefan Weil wrote: > Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: > >On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: > >>For compilations with -DNDEBUG, the default case did not return > >>a value which caused a compiler warning. > >> > >>Sign

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 03:51:18PM -0400, Eric Sunshine wrote: > An entry in the VDI block map will hold an offset to the actual block if > the block is allocated, or one of two specially-interpreted values if > not allocated. Using VirtualBox terminology, value VDI_IMAGE_BLOCK_FREE > (0x)

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 06:08:03PM +0800, Robert Wang wrote: > Please find version 4 in the attachment. Please send patches inline instead of attaching them. It makes it easier to reply with feedback. If you want to add extra comments that should not be included in the git commit you can add it

Re: [Qemu-devel] libacard build error

2011-10-27 Thread Jan Kiszka
On 2011-10-27 09:56, Alon Levy wrote: > On Thu, Oct 27, 2011 at 09:33:50AM +0200, Jan Kiszka wrote: >> Hi Alon, >> >> I'm getting this with current qemu.git: >> >> CClibcacard/vcard_emul_nss.o >> cc1: warnings being treated as errors >> In file included from /usr/include/nss3/pkcs11t.h:1780:0

Re: [Qemu-devel] [PATCH 0/4] add "make check"

2011-10-27 Thread Kevin Wolf
Am 26.10.2011 22:49, schrieb Anthony Liguori: > On 10/25/2011 10:22 AM, Kevin Wolf wrote: >> Am 25.10.2011 17:03, schrieb Eduardo Habkost: >> I think qemu-iotests could be considered an instance of B) >> >>> C) Functional tests that just need to run a small binary with no OS >>> installed in th

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-10-27 Thread Roy Tam
2011/10/27 Jan Kiszka : > On 2011-10-27 05:21, Roy Tam wrote: >> 2011/10/27 Roy Tam : >>> Hi, >>> >>> 2011/10/26 Jan Kiszka : On 2011-10-26 10:03, Roy Tam wrote: > Hi, > > 2011/9/15 Jan Kiszka : >> On 2011-09-15 15:20, Roy Tam wrote: >>> 2011/9/15 Jan Kiszka : On 2

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote: > On 10/26/2011 01:47 PM, Kevin Wolf wrote: > >Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: > >>Hi folks: > >> > >>We've captured a regression with floppy disk on recent qemu (and > >>qemu-kvm, after a code merge).

Re: [Qemu-devel] [PATCH 1/7] block: Remove dead code

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 09:37, schrieb Stefan Hajnoczi: > On Wed, Oct 26, 2011 at 02:31:16PM +0200, Kevin Wolf wrote: >> @@ -2039,11 +2039,7 @@ const char >> *bdrv_get_encrypted_filename(BlockDriverState *bs) >> void bdrv_get_backing_filename(BlockDriverState *bs, >> char *f

Re: [Qemu-devel] libacard build error

2011-10-27 Thread Alon Levy
On Thu, Oct 27, 2011 at 09:56:46AM +0200, Alon Levy wrote: > On Thu, Oct 27, 2011 at 09:33:50AM +0200, Jan Kiszka wrote: > > Hi Alon, > > > > I'm getting this with current qemu.git: > > > > CClibcacard/vcard_emul_nss.o > > cc1: warnings being treated as errors > > In file included from /usr

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-27 Thread Alexander Graf
On 26.10.2011, at 18:35, Stefan Weil wrote: > Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: >> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >>> For compilations with -DNDEBUG, the default case did not return >>> a value which caused a compiler warning. >>> >>> Signed-off-by: Ste

Re: [Qemu-devel] Correct syntax for named snapshots

2011-10-27 Thread Philipp Hahn
Hello Ottaavio, On Wednesday 26 October 2011 18:24:01 Ottavio wrote: > According to the latest doc file you create a named snapshot like this: > > qemu-img snapshot [-l | -a snapshot | -c snapshot | -d snapshot] > base-image.img > > Is this other following syntax still supported or deprecated: > >

Re: [Qemu-devel] [PATCH 1/7] block: Remove dead code

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 02:31:16PM +0200, Kevin Wolf wrote: > @@ -2039,11 +2039,7 @@ const char > *bdrv_get_encrypted_filename(BlockDriverState *bs) > void bdrv_get_backing_filename(BlockDriverState *bs, > char *filename, int filename_size) > { > -if (!bs->bac

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-27 Thread liu ping fan
Hi, I want to rework on it according to your comments. Before that, just want to make clear that I understand your meanings exactly :) According to the previous discussion, I will model the system according the rule -- if there is APIC in the system (including UP and MP), ICC bus will be creat

Re: [Qemu-devel] [PATCH] qemu-io: delete bs instead of leaking it

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 09:42, schrieb Stefan Hajnoczi: > Using bdrv_close() is not enough to free a BlockDriverState. Since we > explicitly create it with bdrv_new(), use bdrv_delete() to close and > delete it. > > Signed-off-by: Stefan Hajnoczi At the end of main() there's another bdrv_close() call tha

[Qemu-devel] [RFC v3 PATCH 0/4] Send gratuitous packets by guest

2011-10-27 Thread Jason Wang
We only track primary mac address in qemu and send rarp packets after migration to notify the switch to update its mac address table. This may not works when guest have complicated network configurations such as tagged vlan or ipv6, those connections may be lost or stalled after migration. One met

[Qemu-devel] [RFC v3 PATCH 1/4] announce self after vm start

2011-10-27 Thread Jason Wang
This patch moves qemu_announce_self() to vm_start() and add a new parameters to control whether sending gratuitous packet is needed. This is bacause the following reasons: - Gratuitous packet is also needed when we resume a stopped vm or successfuly load a state. - The ability of sending gratui

[Qemu-devel] [RFC v3 PATCH 2/4] net: model specific announcing support

2011-10-27 Thread Jason Wang
This patch introduces a function pointer in NetClientInfo which is called during self announcement to do the model specific announcing. The first user would be virtio-net. Signed-off-by: Jason Wang --- net.h|2 ++ savevm.c |8 +--- 2 files changed, 7 insertions(+), 3 deletions(-

[Qemu-devel] [RFC v3 PATCH 3/4] virtio-net: notify guest to annouce itself

2011-10-27 Thread Jason Wang
It's hard to track all mac address and its usage (vlan, bondings, ipv6) in qemu to send proper gratituous packet. The better choice is let guest to do it. The patch introduces a new rw config status bit of virtio-net, VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce presence of its

Re: [Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples

2011-10-27 Thread Kevin Wolf
Am 26.10.2011 14:51, schrieb Ronnie Sahlberg: > Signed-off-by: Ronnie Sahlberg > --- > qemu-options.hx | 42 ++ > 1 files changed, 42 insertions(+), 0 deletions(-) Thanks, applied to the block branch. For future patches, please keep the subject lines sh

[Qemu-devel] [RFC v3 PATCH 4/4] virtio-net: compat guest announce support.

2011-10-27 Thread Jason Wang
Disable guest announce for compat machine types. Signed-off-by: Jason Wang --- hw/pc_piix.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 8c7f2b7..6ca50a6 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -340,6 +340,10 @

Re: [Qemu-devel] Correct syntax for named snapshots

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 05:24:01PM +0100, Ottavio wrote: > According to the latest doc file you create a named snapshot like this: > > qemu-img snapshot [-l | -a snapshot | -c snapshot | -d snapshot] > base-image.img > > Is this other following syntax still supported or deprecated: > > "qemu-im

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-27 Thread Kevin Wolf
Am 26.10.2011 21:51, schrieb Eric Sunshine: > An entry in the VDI block map will hold an offset to the actual block if > the block is allocated, or one of two specially-interpreted values if > not allocated. Using VirtualBox terminology, value VDI_IMAGE_BLOCK_FREE > (0x) represents a never-

[Qemu-devel] [PATCH] qemu-io: delete bs instead of leaking it

2011-10-27 Thread Stefan Hajnoczi
Using bdrv_close() is not enough to free a BlockDriverState. Since we explicitly create it with bdrv_new(), use bdrv_delete() to close and delete it. Signed-off-by: Stefan Hajnoczi --- qemu-io.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-io.c b/qemu-io.c ind

Re: [Qemu-devel] [PATCH] qcow2: fix some errors and typo in qcow2.txt

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 08:58, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > --- > docs/specs/qcow2.txt |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH] Only flush queue or call sent callback on successful delivery

2011-10-27 Thread Mark Wu
Now queue flushing and sent callback could be invoked even on delivery failure. We add a checking of receiver's return value to avoid this case. Signed-off-by: Mark Wu --- net/queue.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/net/queue.c b/net/queue.c in

[Qemu-devel] [PATCH v4] block:add-cow file format

2011-10-27 Thread Dong Xu Wang
Provide a new file format: add-cow. The usage can be found in add-cow.txt of this patch. Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 405 +

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Dong Xu Wang
Re-sent it, thanks. 2011/10/27 Stefan Hajnoczi : > On Wed, Oct 26, 2011 at 06:08:03PM +0800, Robert Wang wrote: >> Please find version 4 in the attachment. > > Please send patches inline instead of attaching them.  It makes it > easier to reply with feedback. > > If you want to add extra comments

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Robert Wang
I re-sent the patch and use bdrv_co_flush now, thanks. 2011/10/27 shu ming : > Looks good to me.  A nit, it seems that bdrv_flush is not supported anymore > in upstream. > bdrv_co_flush should be used instead if you update your workspace to latest > one. > On 2011-10-26 18:08, Robert Wang wrote: >

[Qemu-devel] [RFC v3 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed

2011-10-27 Thread Jason Wang
As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packet when needed. This make let virtio-net driver can send gratuitous packet. Guest check VIRTIO_NET_S_ANNOUNCE during config change interrupt. When this bit is set, a workqueue

[Qemu-devel] [PATCH] net: Only flush queue or call sent callback on successful delivery

2011-10-27 Thread Mark Wu
Now queue flushing and sent callback could be invoked even on delivery failure. We add a checking of receiver's return value to avoid this case. Signed-off-by: Mark Wu --- net/queue.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/net/queue.c b/net/queue.c in

[Qemu-devel] [PATCH] block: fix qcow2_co_flush deadlock

2011-10-27 Thread Dong Xu Wang
If qcow2_cache_flush failed, s->lock will not be unlock. Signed-off-by: Dong Xu Wang --- block/qcow2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index a181932..ef057d3 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1113,11 +1113,1

[Qemu-devel] [PATCH 0/0] Add description on NBD URL to manpage

2011-10-27 Thread Ronnie Sahlberg
Please find a patch to add a description of the NBD URL to the manpage. This describes both TCP and domain socket syntax. (I could not actually test the domain syntax case since my nbd-server crashes:-( ) regards ronnie sahlberg

[Qemu-devel] [PATCH] Documentation: Describe NBD URL syntax

2011-10-27 Thread Ronnie Sahlberg
This patch adds a short description of how to specify a NBD device to QEMU. Syntax for both TCP and Unix Domain Sockets are provided as well as examples. Signed-off-by: Ronnie Sahlberg --- qemu-options.hx | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 09:14, schrieb Stefan Hajnoczi: > On Wed, Oct 26, 2011 at 11:51:37PM +1100, Ronnie Sahlberg wrote: >> >> Signed-off-by: Ronnie Sahlberg >> --- >> qemu-options.hx | 42 ++ >> 1 files changed, 42 insertions(+), 0 deletions(-) > > Good idea, t

Re: [Qemu-devel] balloon driver on winxp guest start failed

2011-10-27 Thread hkran
On 10/17/2011 08:55 PM, Vadim Rozenfeld wrote: On Fri, 2011-10-14 at 17:49 +0800, hkran wrote: On 10/14/2011 04:55 AM, Vadim Rozenfeld wrote: On Thu, 2011-10-13 at 15:47 +0100, Stefan Hajnoczi wrote: On Thu, Oct 13, 2011 at 5:00 AM, hkran wrote: On 10/12/2011 07:09 PM, hkran wrote: I used

[Qemu-devel] [PATCH 1/3] qemu-io: delete bs instead of leaking it

2011-10-27 Thread Stefan Hajnoczi
Using bdrv_close() is not enough to free a BlockDriverState. Since we explicitly create it with bdrv_new(), use bdrv_delete() to close and delete it. Signed-off-by: Stefan Hajnoczi --- qemu-io.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c i

[Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
Several block drivers set bs->read_only in .bdrv_open() but block.c:bdrv_open_common() clobbers its value. Additionally, QED uses bdrv_is_read_only() in .bdrv_open() to decide whether to perform consistency checks. The correct ordering is to initialize bs->read_only from the open flags before cal

[Qemu-devel] [PATCH 3/3] block: reinitialize across bdrv_close()/bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
Several BlockDriverState fields are not being reinitialized across bdrv_close()/bdrv_open(). Make sure they are reset to their default values. Signed-off-by: Stefan Hajnoczi --- block.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 3207e99

Re: [Qemu-devel] [PATCH] Documentation: Describe NBD URL syntax

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 11:33, schrieb Ronnie Sahlberg: > This patch adds a short description of how to specify a NBD device > to QEMU. > Syntax for both TCP and Unix Domain Sockets are provided as well > as examples. > > Signed-off-by: Ronnie Sahlberg Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] block: fix qcow2_co_flush deadlock

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 11:22, schrieb Dong Xu Wang: > If qcow2_cache_flush failed, s->lock will not be unlock. > > Signed-off-by: Dong Xu Wang Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2] fw_cfg: Use g_file_get_contents instead of multiple fread() calls

2011-10-27 Thread Pavel Borzenkov
Ping? On Mon, Oct 24, 2011 at 3:31 PM, Pavel Borzenkov wrote: > Signed-off-by: Pavel Borzenkov > --- >  hw/fw_cfg.c |  102 > ++- >  1 files changed, 38 insertions(+), 64 deletions(-) > > diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c > index 8df26

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: > Several block drivers set bs->read_only in .bdrv_open() but > block.c:bdrv_open_common() clobbers its value. Additionally, QED uses > bdrv_is_read_only() in .bdrv_open() to decide whether to perform > consistency checks. > > The correct ordering is

Re: [Qemu-devel] New Memory API Question

2011-10-27 Thread Avi Kivity
On 10/26/2011 03:52 PM, John Baboval wrote: > Sorry for coming late to the party on this... I only read qemu-devel > through a filter so I missed all the discussions on the new memory > API. I have a question as to how it works and how it's supposed to > work in certain scenarios. > > It's a questi

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 11:18 AM, Kevin Wolf wrote: > Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: >> Several block drivers set bs->read_only in .bdrv_open() but >> block.c:bdrv_open_common() clobbers its value.  Additionally, QED uses >> bdrv_is_read_only() in .bdrv_open() to decide whether to p

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 11:18 AM, Kevin Wolf wrote: > Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: >> Several block drivers set bs->read_only in .bdrv_open() but >> block.c:bdrv_open_common() clobbers its value.  Additionally, QED uses >> bdrv_is_read_only() in .bdrv_open() to decide whether to p

[Qemu-devel] virtio-scsi wiki feature page

2011-10-27 Thread Stefan Hajnoczi
Hi, I have created a virtio-scsi wiki feature page with links to Paolo's latest draft specification, our KVM Forum presentation, and code repos: http://wiki.qemu.org/Features/VirtioSCSI Paolo: v3 had some comments, is it a good time for a new revision of the draft specification? Stefan

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 12:45, schrieb Stefan Hajnoczi: > On Thu, Oct 27, 2011 at 11:18 AM, Kevin Wolf wrote: >> Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: >>> Several block drivers set bs->read_only in .bdrv_open() but >>> block.c:bdrv_open_common() clobbers its value. Additionally, QED uses >>> bdrv_i

Re: [Qemu-devel] virtio-scsi wiki feature page

2011-10-27 Thread Paolo Bonzini
On 10/27/2011 12:49 PM, Stefan Hajnoczi wrote: I have created a virtio-scsi wiki feature page with links to Paolo's latest draft specification, our KVM Forum presentation, and code repos: http://wiki.qemu.org/Features/VirtioSCSI Paolo: v3 had some comments, is it a good time for a new revision

[Qemu-devel] [PATCH v9] block: add io throttling support

2011-10-27 Thread [Zhi Yong Wu
From: Zhi Yong Wu For sync and co driver API, i have not found one good way to do test, so currently i do some testing for async api. If anyone has one good way, pls let me know. thanks. Signed-off-by: Zhi Yong Wu --- Makefile.objs |2 +- block.c | 546

[Qemu-devel] [PATCH v2 3/3] Make cpu_single_env thread-local

2011-10-27 Thread Peter Maydell
From: Paolo Bonzini Make cpu_single_env thread-local. This fixes a regression in handling of multi-threaded programs in linux-user mode (bug 823902). Signed-off-by: Paolo Bonzini [Peter Maydell: rename tls_cpu_single_env to cpu_single_env] Signed-off-by: Peter Maydell --- cpu-all.h |4 +++

[Qemu-devel] [PATCH v2 0/3] TLS abstraction layer for thread-local cpu_single_env on Linux

2011-10-27 Thread Peter Maydell
These patches add enough of the TLS abstraction layer to allow us to make cpu_single_env thread-local on Linux systems. This fixes the regression described in bug 823902 for the 1.0 release; we can add the Win32 and POSIX implementations later. I haven't included Paolo's "Prepare Windows port for

[Qemu-devel] [PATCH v2 2/3] darwin-user/main.c: Drop unused cpu_single_env definition

2011-10-27 Thread Peter Maydell
From: Paolo Bonzini Drop the cpu_single_env definition as it is unused. Signed-off-by: Paolo Bonzini --- darwin-user/main.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/darwin-user/main.c b/darwin-user/main.c index 1a881a0..c0f14f8 100644 --- a/darwin-user/main.c +

[Qemu-devel] ping Re: [PULL v2 00/33] SCSI changes for 1.0, part 1 of 2

2011-10-27 Thread Paolo Bonzini
On 10/25/2011 12:40 PM, Paolo Bonzini wrote: Kevin, The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at: git://git

Re: [Qemu-devel] [PATCH v2] fw_cfg: Use g_file_get_contents instead of multiple fread() calls

2011-10-27 Thread Peter Maydell
On 24 October 2011 12:31, Pavel Borzenkov wrote: > Signed-off-by: Pavel Borzenkov Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes

2011-10-27 Thread Paolo Bonzini
On 10/05/2011 09:12 AM, Paolo Bonzini wrote: It occurred to me that, if there's one thing vvfat ought to be good at, it is creating disk images with qemu-img convert (a driver disk in my case). It turns out the use case is really broken. qemu-img doesn't complete at all, the resulting images of

[Qemu-devel] ping Re: [PATCH 0/5] My remaining block/SCSI patches for 1.0

2011-10-27 Thread Paolo Bonzini
On 10/25/2011 12:53 PM, Paolo Bonzini wrote: The first three replace patches 20/21 and are basically rewritten with input from Kevin. The fourth is new. I had it queued for 1.1, but it turns out it is needed now or scsi-block might access some requests incorrectly when restarting after an error

Re: [Qemu-devel] [PATCH] qxl: create slots on post_load in vga state

2011-10-27 Thread Gerd Hoffmann
On 10/25/11 15:39, Alon Levy wrote: > RHBZ 740547 > > If we migrate when the device is in vga state the guest > still believes the slots are created, and will cause operations > that reference the slots, causing a "panic: virtual address out of range" > on the first of them. Easy to see by migrati

[Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Peter Maydell
Add an abstraction layer for defining and using thread-local variables. For the moment this is implemented only for Linux, which means they can only be used in restricted circumstances. The abstraction layer allows us to add POSIX and Win32 support later. Signed-off-by: Peter Maydell --- qemu-tl

[Qemu-devel] [PATCH 10/10] ppc64-linux-user: Fix syscall return type.

2011-10-27 Thread riku . voipio
From: Richard Henderson Use target_ulong instead of hard-coded uint32_t. Remove the disabled printf's that are redundant with -strace. Signed-off-by: Richard Henderson Signed-off-by: Riku Voipio --- linux-user/main.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) dif

[Qemu-devel] [PATCH 06/10] sparc-linux-user: Handle SIGILL.

2011-10-27 Thread riku . voipio
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Riku Voipio --- linux-user/main.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index e7dad54..2bc10ed 100644 --- a/linux-user/main.c +++ b/linux-use

[Qemu-devel] [PATCH 07/10] sparc-linux-user: Fixup sending SIGSEGV

2011-10-27 Thread riku . voipio
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Riku Voipio --- linux-user/main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 2bc10ed..c36a8af 100644 --- a/linux-user/main.c +++ b/linux-user/mai

[Qemu-devel] [PATCH 1/6] kvm: Add tool for querying VMX capabilities

2011-10-27 Thread Marcelo Tosatti
From: Jan Kiszka Taken from original qemu-kvm/kvm/scripts/vmxcap. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- scripts/kvm/vmxcap | 224 1 files changed, 224 insertions(+), 0 deletions(-) create mode 100755 scripts/kvm/vmxcap

[Qemu-devel] [PATCH 3/6] kvm: avoid reentring kvm_flush_coalesced_mmio_buffer()

2011-10-27 Thread Marcelo Tosatti
From: Avi Kivity mmio callbacks invoked by kvm_flush_coalesced_mmio_buffer() may themselves indirectly call kvm_flush_coalesced_mmio_buffer(). Prevent reentering the function by checking a flag that indicates we're processing coalesced mmio requests. Signed-off-by: Avi Kivity --- kvm-all.c |

[Qemu-devel] [PATCH 5/6] kvm: support TSC deadline MSR with subsection

2011-10-27 Thread Marcelo Tosatti
From: "Liu, Jinsong" KVM add emulation of lapic tsc deadline timer for guest. This patch is co-operation work at qemu side. Use subsections to save/restore the field (mtosatti). Signed-off-by: Liu, Jinsong Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h |2 ++ target-i386/kvm.c

[Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

2011-10-27 Thread Marcelo Tosatti
The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at: git://github.com/avikivity/qemu.git uq/master Avi Kivity (2):

[Qemu-devel] [PATCH 2/6] kvm: Add top-like kvm statistics script

2011-10-27 Thread Marcelo Tosatti
From: Jan Kiszka Taken from original qemu-kvm/kvm/kvm_stat. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- scripts/kvm/kvm_stat | 480 ++ 1 files changed, 480 insertions(+), 0 deletions(-) create mode 100755 scripts/kvm/kvm_stat diff

[Qemu-devel] [PATCH 6/6] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-27 Thread Marcelo Tosatti
From: Avi Kivity It's needed for its default value - bit 0 specifies that "rep movs" is good enough for memcpy, and Linux may use a slower memcpu if it is not set, depending on cpu family/model. Signed-off-by: Avi Kivity Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h |5 +

[Qemu-devel] [PATCH 01/10] linux-user: fix TARGET_RLIM_INFINITY declaration

2011-10-27 Thread riku . voipio
From: Matthias Braun Signed-off-by: Matthias Braun Signed-off-by: Riku Voipio --- linux-user/syscall_defs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 15c44d4..1bc54c7 100644 --- a/linux-user/syscall_def

Re: [Qemu-devel] virtio-scsi wiki feature page

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 12:19 PM, Paolo Bonzini wrote: > On 10/27/2011 12:49 PM, Stefan Hajnoczi wrote: >> >> I have created a virtio-scsi wiki feature page with links to Paolo's >> latest draft specification, our KVM Forum presentation, and code >> repos: >> >> http://wiki.qemu.org/Features/Virti

[Qemu-devel] [PATCH 04/10] linux-user: fix openat

2011-10-27 Thread riku . voipio
From: Alexander Graf When running openat using qemu-arm, we stumbled over invalid permissions on the created files. The reason for this is that the mode parameter gets treates as an O_... flag, which it isn't - it's a permission bitmask. This patch removes the needless translation of the mode pa

[Qemu-devel] QEMU 1.0 test day - November 7th

2011-10-27 Thread Paolo Bonzini
Hi all, QEMU 1.0 test day will be held on November 7th. Any kind of testing that you can contribute will be appreciated---including testing your favorite hypervisor, desktop virtualization or management stack together with the new release. You are also welcome to add testing hints at http:

[Qemu-devel] [PATCH 02/10] linux-user: fix rlimit syscalls on sparc(64)

2011-10-27 Thread riku . voipio
From: Matthias Braun Signed-off-by: Matthias Braun Signed-off-by: Riku Voipio --- linux-user/syscall_defs.h |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 1bc54c7..5fd4c9c 100644 --- a/linux-user/syscal

Re: [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 13:46, schrieb Paolo Bonzini: > On 10/05/2011 09:12 AM, Paolo Bonzini wrote: >> It occurred to me that, if there's one thing vvfat ought to be good >> at, it is creating disk images with qemu-img convert (a driver disk >> in my case). >> >> It turns out the use case is really broken.

[Qemu-devel] [PATCH 4/6] Revert "kvm: support TSC deadline MSR"

2011-10-27 Thread Marcelo Tosatti
This reverts commit bfc2455ddbb41148494a084d15777e6bed7533c3. New patch with subsections will follow. Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h |4 +--- target-i386/kvm.c | 14 -- target-i386/machine.c |1 - 3 files changed, 1 insertions(+), 18 deletions(

[Qemu-devel] [PATCH 00/10] Linux-user patches for 1.0

2011-10-27 Thread riku . voipio
From: Riku Voipio Fixes related linux-user qemu targetting 1.0. please ping If I have missed any. Patches are also available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-upstream Alexander Graf (2): linux-user: fix openat linux-user: implement

[Qemu-devel] [PATCH 09/10] ppc64-linux-user: Properly interpret the entry function descriptor.

2011-10-27 Thread riku . voipio
From: Richard Henderson Don't confuse the load address with the load bias. They're equal for ET_DYN objects (i.e. ld.so) but different for ET_EXEC objects (i.e. statically linked). Signed-off-by: Richard Henderson Signed-off-by: Riku Voipio --- linux-user/elfload.c |8 1 files c

[Qemu-devel] [PATCH 08/10] sparc-linux-user: Add some missing syscall numbers

2011-10-27 Thread riku . voipio
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Riku Voipio --- linux-user/sparc/syscall_nr.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/linux-user/sparc/syscall_nr.h b/linux-user/sparc/syscall_nr.h index be503f2..f201f9f 100644 --- a/lin

[Qemu-devel] [PATCH 03/10] linux-user: fix abi_(u)long, target_ulong mismatch

2011-10-27 Thread riku . voipio
From: Matthias Braun abi_(u)long might be different from target_ulong, so don't use tswapl but introduce a new tswapal Signed-off-by: Matthias Braun Signed-off-by: Riku Voipio --- linux-user/qemu-types.h | 12 ++ linux-user/signal.c | 22 ++-- linux-user/strace.c |4 +-

[Qemu-devel] [PATCH 05/10] linux-user: implement reboot syscall

2011-10-27 Thread riku . voipio
From: Alexander Graf For OBS, we're running a full cross-guest inside of a VM. When a build is done there, we reboot the guest as shutdown mechanism. Unfortunately, reboot is not implemented in linux-user. So this mechanism fails, spilling unpretty warnings. This patch implements sys_reboot() em

Re: [Qemu-devel] [PATCH 1/1 V6 resent ] qemu-kvm: fix improper nmi emulation

2011-10-27 Thread Marcelo Tosatti
On Tue, Oct 25, 2011 at 05:55:28PM +0800, Lai Jiangshan wrote: > Previous discussions: > >> >> > >> >> Which approach you prefer to? > >> >> I need to know the result before wasting too much time to respin > >> >> the approach. > > > > > > Yes, sorry about the slow and sometimes confli

Re: [Qemu-devel] about NPIV with qemu-kvm.

2011-10-27 Thread ya su
hi, hannes I really appreciate your clarify of my daze. as to improve vm's storage io perfomance as nearly hardware's, it seems the only way is something like sr-iov by hba card. NPIV can not achieve this goal. I remember that LSI released some kind SAS controller(IR 2008?) wh

[Qemu-devel] Assigning a new virtio block device (-drive)

2011-10-27 Thread Leib, David
Hi, I am trying to assign a new virtio block device in addition to a normal virtio block device who are accessing exactly the same cdrom drive ("/dev/sr0") because I additionaly want to access the block device in my way by manually calling the virtqueue_pop and virtqueue_push and not the normal

Re: [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes

2011-10-27 Thread Paolo Bonzini
On 10/27/2011 02:38 PM, Kevin Wolf wrote: Am 27.10.2011 13:46, schrieb Paolo Bonzini: On 10/05/2011 09:12 AM, Paolo Bonzini wrote: It occurred to me that, if there's one thing vvfat ought to be good at, it is creating disk images with qemu-img convert (a driver disk in my case). It turns out t

Re: [Qemu-devel] [PATCH v2 2/3] darwin-user/main.c: Drop unused cpu_single_env definition

2011-10-27 Thread Andreas Färber
Am 27.10.2011 13:37, schrieb Peter Maydell: > From: Paolo Bonzini > > Drop the cpu_single_env definition as it is unused. > > Signed-off-by: Paolo Bonzini Acked-by: Andreas Färber > --- > darwin-user/main.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/darw

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Kevin Wolf
Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Work with kvm enabled or disabled. strace output is more readable (le

Re: [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 15:10, schrieb Paolo Bonzini: > On 10/27/2011 02:38 PM, Kevin Wolf wrote: >> Am 27.10.2011 13:46, schrieb Paolo Bonzini: >>> On 10/05/2011 09:12 AM, Paolo Bonzini wrote: It occurred to me that, if there's one thing vvfat ought to be good at, it is creating disk images with q

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: > Am 19.09.2011 16:37, schrieb Frediano Ziglio: > > Now that iothread is always compiled sending a signal seems only an > > additional step. This patch also avoid writing to two pipe (one from signal > > and one in qemu_service_io). > > >

Re: [Qemu-devel] [PATCH] Documentation: Describe NBD URL syntax

2011-10-27 Thread Eric Sunshine
On Oct 27, 2011, at 5:33 AM, Ronnie Sahlberg wrote: This patch adds a short description of how to specify a NBD device to QEMU. Syntax for both TCP and Unix Domain Sockets are provided as well as examples. Signed-off-by: Ronnie Sahlberg --- qemu-options.hx | 21 + 1 files c

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: > On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: >> Am 19.09.2011 16:37, schrieb Frediano Ziglio: >>> Now that iothread is always compiled sending a signal seems only an >>> additional step. This patch also avoid writing to two pipe (one fr

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 16:15, schrieb Kevin Wolf: > Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: >> On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: >>> Am 19.09.2011 16:37, schrieb Frediano Ziglio: Now that iothread is always compiled sending a signal seems only an additional step. Th

  1   2   >