Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async

2011-10-25 Thread Gerd Hoffmann
Hi, > If all you need here is to delay sending the response, then maybe the > current interface could work (although I honestly don't trust it and > regret not having dropped it). Otherwise our only choice would be to > work on getting the QAPI async support merged. A delayed monitor response i

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Jan Kiszka
On 2011-10-25 03:37, Wen Congyang wrote: > At 10/24/2011 11:58 PM, Dave Anderson Write: >> >> >> - Original Message - >> > No, an ELF image of the guest's physical memory. Well then that should be pretty straight forward to support. Depending upon how similar it wo

Re: [Qemu-devel] Executing from a rom device - Re: [PATCH 2/4] pc: Support system flash memory with pflash

2011-10-25 Thread Avi Kivity
On 10/25/2011 01:00 AM, Jordan Justen wrote: > Avi, > > Alex pointed out that my patch below should not work for kvm, because > kvm currently does not support executing from a rom region. This > surprised me, because I thought I had been testing with kvm enabled. > But, it turns out I wasn't, and

Re: [Qemu-devel] Executing from a rom device - Re: [PATCH 2/4] pc: Support system flash memory with pflash

2011-10-25 Thread Avi Kivity
On 10/25/2011 01:12 AM, Alexander Graf wrote: > > > > Would implementing it require the flash based execution to be very > > slow under kvm? > > To be more precise, we need a memory region which is backed by RAM on reads > and does MMIO on writes. I remember Avi talking about that a while back, b

[Qemu-devel] buildbot failure in qemu on monitor_i386_debian_6_0

2011-10-25 Thread qemu
The Buildbot has detected a new failure on builder monitor_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_i386_debian_6_0/builds/71 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

[Qemu-devel] [V3 PATCH 2/2] hw/9pfs: Read-only support for 9p export

2011-10-25 Thread M. Mohan Kumar
A new fsdev parameter "readonly" is introduced to control accessing 9p export. "readonly" can be used to specify the access type. By default "rw" access is given to 9p export. Signed-off-by: M. Mohan Kumar --- fsdev/file-op-9p.h |4 +++- fsdev/qemu-fsdev.c |7 ++- hw/9pfs/virtio-9p

[Qemu-devel] [V3 PATCH 1/2] qemu: Add opt_set_bool functionality

2011-10-25 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar --- Changes from previous version V2: * qemu_opt_set_bool does not need to call qemu_opt_parse, because it supports only setting boolean types Changes from previous version: * Changed qemu_opt_{get|set}_bool to use 'bool' data type qemu-option.c | 39

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-25 Thread ronnie sahlberg
Kevin, Thanks for the review, I have attached a modified patch that addresses all your comments. Please review and/or apply. > I doubt that you really need sysemu.h. If you did, I think you couldn't > successfully build qemu-img and qemu-io. You are right. I removed it. > Is acb->status == -E

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Wen Congyang
At 10/24/2011 11:30 PM, Avi Kivity Write: > On 10/24/2011 05:25 PM, Dave Anderson wrote: >> >> - Original Message - >>> On 10/24/2011 04:25 PM, Dave Anderson wrote: > The question is that: 'virsh dump' can not be used when host pci device > is used by guest. We are discussing how to

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-25 Thread Kevin Wolf
Am 25.10.2011 10:04, schrieb ronnie sahlberg: >> iscsi_destroy_url() is only ever called here. Do we leak it in the normal >> path? > > It didnt leak but the the label was confusing. I have changed it from > "failed" to "finished" since this part > is executed for both normal and failures. But t

[Qemu-devel] [PATCH] Documentation: fix typo

2011-10-25 Thread Bernhard Reutner-Fischer
Signed-off-by: Bernhard Reutner-Fischer --- qemu-doc.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 7ce8999..f34c76f 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -225,7 +225,7 @@ QEMU uses YM3812 emulation by Tatsuyuki Satoh

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Avi Kivity
On 10/25/2011 10:06 AM, Wen Congyang wrote: > Hi, Avi Kivity, Dave Anderson > > I have two questions about it: > > 1. How to know the guest's physical base address in qemu? In fact, it's impossible. Perhaps crash can scan through the core looking for a signature. Need to be careful since multipl

Re: [Qemu-devel] Windows 98 installer

2011-10-25 Thread Avi Kivity
On 10/24/2011 08:21 PM, Michael Karcher wrote: > If you know the 8086 architecture by heart, and also know the qemu code, > you could get the idea that there might be an emulation bug causing the > premature acceptance of the second interrupt (would it be accepted after > cleaning up the stack fram

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-25 Thread ronnie sahlberg
Hi, On Tue, Oct 25, 2011 at 7:17 PM, Kevin Wolf wrote: > Am 25.10.2011 10:04, schrieb ronnie sahlberg: >>> iscsi_destroy_url() is only ever called here. Do we leak it in the normal >>> path? >> >> It didnt leak but the the label was confusing. I have changed it from >> "failed" to "finished" si

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Paolo Bonzini
On 10/25/2011 10:23 AM, Avi Kivity wrote: On 10/25/2011 10:06 AM, Wen Congyang wrote: Hi, Avi Kivity, Dave Anderson I have two questions about it: 1. How to know the guest's physical base address in qemu? In fact, it's impossible. Perhaps crash can scan through the core looking for a signat

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-25 Thread Kevin Wolf
Am 25.10.2011 10:23, schrieb ronnie sahlberg: > Hi, > > > On Tue, Oct 25, 2011 at 7:17 PM, Kevin Wolf wrote: >> Am 25.10.2011 10:04, schrieb ronnie sahlberg: iscsi_destroy_url() is only ever called here. Do we leak it in the normal path? >>> >>> It didnt leak but the the label was con

Re: [Qemu-devel] [PATCH 00/14] arm: more memory API and VMState conversion

2011-10-25 Thread Avi Kivity
On 10/24/2011 10:38 PM, Benoît Canet wrote: > These patches apply against akivity memory/master. > They convert syborg to memory API and various > arm related component to VMState. > > Omap boards where not modified because Linaro is > currently refactoring them. > > Xscale was left apart too. > >

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Avi Kivity
On 10/25/2011 10:35 AM, Paolo Bonzini wrote: > On 10/25/2011 10:23 AM, Avi Kivity wrote: >> On 10/25/2011 10:06 AM, Wen Congyang wrote: >>> Hi, Avi Kivity, Dave Anderson >>> >>> I have two questions about it: >>> >>> 1. How to know the guest's physical base address in qemu? >> >> In fact, it's impo

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-25 Thread liu ping fan
On Sun, Oct 23, 2011 at 12:40:08PM +, Blue Swirl wrote: > On Wed, Oct 19, 2011 at 01:55, wrote: > > From: Liu Ping Fan > > > > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > > of sysbus. So we can su

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Paolo Bonzini
On 10/25/2011 10:52 AM, Avi Kivity wrote: > Crash uses a heuristic based on the IDT base to identify the base from > migrate-to-file output. It also needs CR3 in order to read from > virtual address. Does elf not store cr3? Perhaps a note with the contents of the privileged cpu registers is

Re: [Qemu-devel] [PATCH 00/14] arm: more memory API and VMState conversion

2011-10-25 Thread Benoît Canet
The tab where used because the original source file is written with tabs. I'll rewrite them as space if you want. 2011/10/25 Avi Kivity > On 10/24/2011 10:38 PM, Benoît Canet wrote: > > These patches apply against akivity memory/master. > > They convert syborg to memory API and various > > arm r

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-25 Thread Jan Kiszka
On 2011-10-25 10:56, Paolo Bonzini wrote: > On 10/25/2011 10:52 AM, Avi Kivity wrote: Crash uses a heuristic based on the IDT base to identify the base from migrate-to-file output. It also needs CR3 in order to read from virtual address. >> Does elf not store cr3? Perhaps a note

[Qemu-devel] [PULL] VirtFS update 7

2011-10-25 Thread Aneesh Kumar K.V
Hi, This include all the pending patches for 1.0 The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at: git://repo.or.

[Qemu-devel] [BUG] qemu-kvm: memory_region_add_subregion_common: Assertion `!subregion->parent' failed.

2011-10-25 Thread Lai Jiangshan
This bug is triggered for my Windows XP guest, but not for my linux guests. The gdb result shows that a "vga.vram" memoryregion is added twice. libvirt log --- 2011-10-25 16:18:58.117: starting up LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin QEMU_AUDIO_DRV=none /home/laijs/bin/qe

[Qemu-devel] [PATCH 1/1 V6 resent ] qemu-kvm: fix improper nmi emulation

2011-10-25 Thread Lai Jiangshan
Previous discussions: >> >> >> >> Which approach you prefer to? >> >> I need to know the result before wasting too much time to respin >> >> the approach. > > > > Yes, sorry about the slow and sometimes conflicting feedback. > > >> >> 1) Fix KVM_NMI emulation approach (which is v3 pa

Re: [Qemu-devel] [PATCH 01/12] Fix typo: buf -> bus

2011-10-25 Thread Markus Armbruster
Best to cc: qemu-triv...@nongnu.org for trivial patches. Hervé Poussineau writes: > Signed-off-by: Hervé Poussineau > --- > hw/audiodev.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/audiodev.h b/hw/audiodev.h > index 8e930b2..d60c349 100644 > --- a/hw/audi

Re: [Qemu-devel] [PATCH] Documentation: fix typo

2011-10-25 Thread Markus Armbruster
Best to cc: qemu-triv...@nongnu.org for trivial patches. Bernhard Reutner-Fischer writes: > Signed-off-by: Bernhard Reutner-Fischer > --- > qemu-doc.texi |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-doc.texi b/qemu-doc.texi > index 7ce8999..f34c76f 100644

Re: [Qemu-devel] Can qemu emulate IBM Power env?

2011-10-25 Thread Andreas Färber
Ryan, Am 20.10.2011 02:04, schrieb Ryan Wang: > If it can, where can I find the related instructions? Your question is rather vague... I'm interpreting it as: Can QEMU emulate an IBM Power Architecture based system? Yes, it can: qemu-system-ppc64 -M pseries And if the documentation doesn't say

Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async

2011-10-25 Thread Alon Levy
On Mon, Oct 24, 2011 at 10:31:48PM -0200, Luiz Capitulino wrote: > On Mon, 24 Oct 2011 19:29:37 +0200 > Alon Levy wrote: > > > On Mon, Oct 24, 2011 at 01:45:16PM -0200, Luiz Capitulino wrote: > > > On Mon, 24 Oct 2011 17:13:14 +0200 > > > Gerd Hoffmann wrote: > > > > > > > On 10/24/11 14:02, Al

[Qemu-devel] [PATCH 00/11] V3 arm memory API conversion

2011-10-25 Thread Benoît Canet
These patches apply against akivity memory/master. They convert some ARM files to memory API. Omap boards where not modified because Linaro is currently refactoring them. Xscale was left apart too. "integratorcp: convert control to sysbus" is a lone reviewed by patch which was added at the begin

[Qemu-devel] [PATCH 01/11] integratorcp: convert control to sysbus

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet Reviewed-by: Peter Maydell --- hw/integratorcp.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 7f79560..7ad68b7 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -393,6

[Qemu-devel] [PATCH 10/11] syborg_timer: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_timer.c | 27 ++- 1 files changed, 10 insertions(+), 17 deletions(-) diff --git a/hw/syborg_timer.c b/hw/syborg_timer.c index 50c813e..dfee457 100644 --- a/hw/syborg_timer.c +++ b/hw/syborg_timer.c @@ -53,6 +53,7 @@ enum { ty

Re: [Qemu-devel] [BUG] qemu-kvm: memory_region_add_subregion_common: Assertion `!subregion->parent' failed.

2011-10-25 Thread Jan Kiszka
On 2011-10-25 11:42, Lai Jiangshan wrote: > This bug is triggered for my Windows XP guest, but not for my linux guests. > > The gdb result shows that a "vga.vram" memoryregion is added twice. > > libvirt log --- > > 2011-10-25 16:18:58.117: starting up > LC_ALL=C PATH=/sbin:/usr/

[Qemu-devel] [PATCH v2 24/33] scsi-generic: check ioctl statuses when SG_IO succeeds

2011-10-25 Thread Paolo Bonzini
A succeeding ioctl does not imply that the SCSI command succeeded. Fix some braces along the way. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 5e2d4c0..a5fc2ec 100644 ---

[Qemu-devel] [PATCH v2 11/33] scsi-disk: support DVD profile in GET CONFIGURATION

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- v1->v2: fix comment for outbuf[8]-outbuf[19] hw/scsi-disk.c | 50 ++ 1 files changed, 42 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 8f25e29..69af2e3 100644 --- a/hw/s

[Qemu-devel] [PATCH v2 31/33] scsi: make reqops const

2011-10-25 Thread Paolo Bonzini
Also delete a stale occurrence of SCSIReqOps inside SCSIDeviceInfo. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 10 +- hw/scsi-disk.c|2 +- hw/scsi-generic.c |2 +- hw/scsi.h |7 +++ 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v2 33/33] scsi: pass cdb to alloc_req

2011-10-25 Thread Paolo Bonzini
This will let scsi-block choose between passthrough and emulation. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |2 +- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |2 +- hw/scsi.h |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/scsi-bus.c b

[Qemu-devel] [PATCH 05/11] syborg_interrupt: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_interrupt.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/syborg_interrupt.c b/hw/syborg_interrupt.c index 1b0f3bb..512910a 100644 --- a/hw/syborg_interrupt.c +++ b/hw/syborg_interrupt.c @@ -55,6

[Qemu-devel] [PATCH 8/8] scsi-disk: implement eject requests

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f407e2b..241a676 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -65,6 +65,7 @@ struct SCSIDiskState uint

[Qemu-devel] [ANNOUNCE] kvm-kmod-3.1

2011-10-25 Thread Jan Kiszka
This is the kvm-kmod compat wrapper release based on KVM modules of Linux 3.1 (see [1] for background information). The package is available for download from http://sourceforge.net/projects/kvm/files/kvm-kmod/3.1/kvm-kmod-3.1.tar.bz2/download KVM changes since kvm-kmod-3.0b: - initial version o

Re: [Qemu-devel] [PATCH 00/14] arm: more memory API and VMState conversion

2011-10-25 Thread Avi Kivity
On 10/25/2011 11:03 AM, Benoît Canet wrote: > > The tab where used because the original source file is written with tabs. > I'll rewrite them as space if you want. New code should conform to CODING_STYLE. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to

[Qemu-devel] [PATCH 0/5] arm: VMState conversion

2011-10-25 Thread Benoît Canet
These patches convert various ARM related hardware to the VMState api. They apply on top of akivity/master. Benoît Canet (5): pl181: add vmstate bitbang_i2c: convert to VMState realview: convert realview i2c to VMState integratorcp: convert integratorcm to VMState integratorcp: convert

[Qemu-devel] [PATCH 1/5] pl181: add vmstate

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/pl181.c | 40 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/hw/pl181.c b/hw/pl181.c index 0943c09..06c8bd2 100644 --- a/hw/pl181.c +++ b/hw/pl181.c @@ -37,20 +37,45 @@ typedef struct { uint32_t da

[Qemu-devel] [PATCH 3/5] realview: convert realview i2c to VMState

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/realview.c | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/realview.c b/hw/realview.c index 11ffb8a..2120600 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -24,10 +24,26 @@ typedef struct { SysBusDevice b

[Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 9a289b4..e8d8d67 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -34,6 +34,29 @@ typedef struct

[Qemu-devel] [PATCH 5/5] integratorcp: convert icp_pic to VMState

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index e8d8d67..10475be 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -314,6 +314,19 @@ typedef struct icp_pic_

[Qemu-devel] [PATCH 11/11] syborg_virtio: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_virtio.c | 30 ++ 1 files changed, 14 insertions(+), 16 deletions(-) diff --git a/hw/syborg_virtio.c b/hw/syborg_virtio.c index 00c7be8..c2dbf36 100644 --- a/hw/syborg_virtio.c +++ b/hw/syborg_virtio.c @@ -62,6 +62,7 @@ enum

[Qemu-devel] [PATCH 4/8] scsi: push request restart to SCSIDevice

2011-10-25 Thread Paolo Bonzini
The request restart mechanism is generic and could be reused for scsi-generic. In the meanwhile, pushing it to SCSIDevice avoids that scsi_dma_restart_bh looks at SCSIGenericReqs when working on a scsi-block device. The code is the same that is already in hw/scsi-disk.c, with the type flags repla

[Qemu-devel] [PATCH 1/8] scsi: do not call transfer_data after canceling a request

2011-10-25 Thread Paolo Bonzini
Otherwise, if cancellation is "faked" by the AIO layer and goes through qemu_aio_flush, the whole request is completed synchronously during scsi_req_cancel. Using the enqueued flag would work here, but not in the next patches, so I'm introducing a new io_canceled flag. That's because scsi_req_dat

[Qemu-devel] [PATCH v2 32/33] scsi: export scsi_generic_reqops

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c |2 +- hw/scsi.h |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 7fe9b0d..5e0d6a4 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -449,7 +449,7 @@ static

[Qemu-devel] [PATCH v2 02/33] atapi/scsi: unify definitions for MMC

2011-10-25 Thread Paolo Bonzini
The definitions in ide/internal.h are duplicates, since ATAPI commands actually come from SCSI. Use the ones in scsi-defs.h and move the missing ones there. Two exceptions: - MODE_PAGE_WRITE_PARMS conflicts with the "flexible disk geometry" page in scsi-disk.c. It is unused, so pick the latter.

Re: [Qemu-devel] [PATCH 00/11] V3 arm memory API conversion

2011-10-25 Thread Avi Kivity
On 10/25/2011 12:32 PM, Benoît Canet wrote: > These patches apply against akivity memory/master. > They convert some ARM files to memory API. > > Omap boards where not modified because Linaro is > currently refactoring them. > > Xscale was left apart too. > > "integratorcp: convert control to sysbu

[Qemu-devel] [PATCH v2 28/33] scsi-disk: remove cluster_size

2011-10-25 Thread Paolo Bonzini
This field is redundant, and having it makes it more complicated to share reqops between the upcoming scsi-block and scsi-generic. Signed-off-by: Paolo Bonzini --- v1->v2: do not assume blocksize may be zero, since other things would break hw/scsi-disk.c | 35 -

[Qemu-devel] [PATCH v2 09/33] scsi-disk: store valid mode pages in a table

2011-10-25 Thread Paolo Bonzini
A small refactoring of the MODE SENSE implementation in scsi-disk. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 0557ede..bcce076 100644 --- a/hw/scsi-disk.c

Re: [Qemu-devel] [PATCH 00/11] V3 arm memory API conversion

2011-10-25 Thread Peter Maydell
2011/10/25 Avi Kivity : > The integratorcp patch is also unrelated, it should also go through the > integratorcp maintainer, if there is one. That would be me, but I suggested feeding it through you because it depends on the memoryregion patches which you haven't landed yet. -- PMM

[Qemu-devel] [PATCH 7/8] atapi: implement eject requests

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ide/atapi.c | 11 --- hw/ide/core.c | 13 + 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 90b6729..1fed359 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -516,9 +516,14 @@ sta

[Qemu-devel] [PATCH 2/5] bitbang_i2c: convert to VMState

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/bitbang_i2c.c | 92 +++-- 1 files changed, 61 insertions(+), 31 deletions(-) diff --git a/hw/bitbang_i2c.c b/hw/bitbang_i2c.c index 431359d..b711144 100644 --- a/hw/bitbang_i2c.c +++ b/hw/bitbang_i2c.c @@ -19,37

[Qemu-devel] [PATCH v2 06/33] scsi-disk: report media changed via unit attention sense codes

2011-10-25 Thread Paolo Bonzini
Building on the previous patch, this one adds a media change callback to scsi-disk. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |5 + hw/scsi-disk.c | 29 - hw/scsi.h |2 ++ 3 files changed, 35 insertions(+), 1 deletions(-) diff --git a/hw/scsi

[Qemu-devel] [PATCH v2 27/33] scsi-disk: do not duplicate BlockDriverState member

2011-10-25 Thread Paolo Bonzini
Same as for scsi-generic, avoid duplication even if it causes longer lines. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 92 +++ 1 files changed, 45 insertions(+), 47 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 88a65

[Qemu-devel] [PATCH 09/11] syborg_serial: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_serial.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/syborg_serial.c b/hw/syborg_serial.c index c83f82c..b73a009 100644 --- a/hw/syborg_serial.c +++ b/hw/syborg_serial.c @@ -58,6 +58,7 @@ enum {

[Qemu-devel] [PATCH v2 23/33] scsi-generic: remove scsi_req_fixup

2011-10-25 Thread Paolo Bonzini
This is not needed anymore, since asynchronous ioctls were introduced by commit 221f715 (new scsi-generic abstraction, use SG_IO, 2009-03-28). Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/hw/scsi-generi

[Qemu-devel] [PATCH v2 26/33] scsi-generic: snoop READ CAPACITY commands to get block size

2011-10-25 Thread Paolo Bonzini
Instead of "guessing" the block size when there is no medium in the drive, wait for the guest to send a READ CAPACITY command and snoop it from there. Signed-off-by: Paolo Bonzini --- v1->v2: keep a default blocksize value. hw/scsi-generic.c | 35 +-- 1

[Qemu-devel] [PATCH 3/8] scsi-generic: bump SCSIRequest reference count until aio completion runs

2011-10-25 Thread Paolo Bonzini
Same as before, but for scsi-generic. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index b30cf09..ff738fd 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c

[Qemu-devel] [PATCH 07/11] syborg_pointer: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_pointer.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/syborg_pointer.c b/hw/syborg_pointer.c index b91214d..a0f8b32 100644 --- a/hw/syborg_pointer.c +++ b/hw/syborg_pointer.c @@ -44,6 +44,7 @@ t

[Qemu-devel] [PATCH v2 05/33] scsi: notify the device when unit attention is reported

2011-10-25 Thread Paolo Bonzini
Reporting media change events via unit attention sense codes requires a small state machine: first report "NO MEDIUM", then report "MEDIUM MAY HAVE CHANGED". Unfortunately there is no good hooking point for the device to notice that its pending unit attention condition has been reported. This pat

[Qemu-devel] [PATCH 2/8] scsi-disk: bump SCSIRequest reference count until aio completion runs

2011-10-25 Thread Paolo Bonzini
In some cases a request may be canceled before the completion callback runs. Keep a reference to the request between starting an AIO operation and the corresponding scsi_req_cancel or scsi_*_complete. When a request has to be retried, the request can be dropped because scsi_dma_restart_bh only lo

[Qemu-devel] [PATCH v2 04/33] atapi: cleanup/fix mode sense results

2011-10-25 Thread Paolo Bonzini
The first two bytes (after the 8-byte ATAPI header) are the mode page number and the number of bytes after the length field itself. Make this clear in the code. The AUDIO_CTL page was filled with wrong values. It is not anymore in MMC, but at least keep the values sane. Signed-off-by: Paolo Bon

[Qemu-devel] [PATCH v2 12/33] scsi-disk: support READ DVD STRUCTURE

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- v1->v2: accept format 0xff when no media or a CD is inserted, fix sense code for media != 0, use ARRAY_SIZE, braces, remove bogus bdrv_is_inserted test. hw/scsi-disk.c | 102 +++- 1 file

[Qemu-devel] [PATCH v2 17/33] scsi: implement REPORT LUNS for arbitrary LUNs

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 49 +++-- 1 files changed, 39 insertions(+), 10 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 7104e98..a2d57a7 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -170,7 +170,7 @@ typedef

[Qemu-devel] [PATCH v2 13/33] scsi-disk: report media changed via GET EVENT STATUS NOTIFICATION

2011-10-25 Thread Paolo Bonzini
This adds support for media change notification via the GET EVENT STATUS NOTIFICATION command, used by Linux versions 2.6.38 and newer. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 57 --- 1 files changed, 53 insertions(+), 4 deletions(-

[Qemu-devel] [PATCH v2 25/33] scsi-generic: look at host status

2011-10-25 Thread Paolo Bonzini
Pass down the host status so that failing transport can be detected by the guest. Similar treatment of host status could be done in virtio-blk, too. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH 0/4] add "make check"

2011-10-25 Thread Kevin Wolf
Am 24.10.2011 20:57, schrieb Anthony Liguori: > On 10/24/2011 01:43 PM, Eduardo Habkost wrote: >> On Mon, Sep 05, 2011 at 09:55:20AM +0200, Markus Armbruster wrote: >>> Gerd Hoffmann writes: >>> Hi, This patch series intends to make unit testing easier. It adds a new "make

[Qemu-devel] [PATCH v2 03/33] atapi: move GESN definitions to scsi-defs.h

2011-10-25 Thread Paolo Bonzini
As a complement to the previous patch, move definitions for GET EVENT STATUS NOTIFICATION from the two functions to scsi-defs.h. The NCR_* constants are just bit values corresponding to the ENC_* values, with no offsets even, so keep just one copy. Signed-off-by: Paolo Bonzini --- v1->v2

[Qemu-devel] [PATCH v2 29/33] scsi-disk: small clean up to INQUIRY

2011-10-25 Thread Paolo Bonzini
Set s->removable, s->qdev.blocksize and s->qdev.type in the callers of scsi_initfn. With this in place, s->qdev.type is allowed, and we can just reuse it as the first byte in VPD data (just like we do in standard INQUIRY data). Also set s->removable is set consistently and we can use it. Signed-o

[Qemu-devel] [PATCH v2 21/33] scsi-disk: fix retrying a flush

2011-10-25 Thread Paolo Bonzini
Flush does not go anymore through scsi_disk_emulate_command. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 98881c6..88a65c5 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@

[Qemu-devel] [PATCH v2 30/33] scsi: move max_lba to SCSIDevice

2011-10-25 Thread Paolo Bonzini
The field is only in scsi-disk for now. Moving it up to SCSIDevice makes it easier to reuse the scsi-generic reqops elsewhere. At the same time, make scsi-generic get max_lba from snooped READ CAPACITY commands as well. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c| 15 +++

[Qemu-devel] [PATCH v2 16/33] scsi: remove devs array from SCSIBus

2011-10-25 Thread Paolo Bonzini
Change the devs array into a linked list, and add a scsi_device_find function to navigate the children list instead. This lets the SCSI bus use more complex addressing, and HBAs can talk to the correct device when there are multiple LUNs per target. scsi_device_find may return another LUN on the

Re: [Qemu-devel] [PATCH 3/5] qxl: support concurrent async commands

2011-10-25 Thread Alon Levy
On Mon, Oct 24, 2011 at 05:26:11PM +0200, Gerd Hoffmann wrote: > Hi, > > > +SpiceAsyncCommand *push_spice_async_command(PCIQXLDevice *qxl, > > +uint32_t async_io, int size) > > > +/* caller must call g_free */ > > +static SpiceAsyncCommand *pop_spice_async_command(PCIQXLDevice *qxl, > > +

[Qemu-devel] [PATCH v2 07/33] scsi-disk: fix coding style issues (braces)

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- v1->v2: new patch hw/scsi-disk.c | 71 --- 1 files changed, 46 insertions(+), 25 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 880cb22..3a08848 100644 --- a/hw/scsi-disk.c +++ b/hw/s

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-25 Thread Kevin Wolf
Am 24.10.2011 13:35, schrieb Paolo Bonzini: > On 10/24/2011 01:04 PM, Juan Quintela wrote: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > - What's left to merge for 1.0. I would still like to cache the default cache mode (probably to cache=writeback). We don't

[Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c|7 +++ block.h|7 +++ blockdev.c |8 +--- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 9873b57..53e21ba 100644 --- a/block.c +++ b/block.c @@ -821,6 +821,13 @@ bool bdrv_dev_has_rem

[Qemu-devel] [PATCH v2 19/33] scsi: add channel to addressing

2011-10-25 Thread Paolo Bonzini
This also requires little more than adding the new argument to scsi_device_find, and the qdev property. All devices by default end up on channel 0. Signed-off-by: Paolo Bonzini --- hw/esp.c |4 ++-- hw/lsi53c895a.c |4 ++-- hw/scsi-bus.c| 24 +++- hw/s

[Qemu-devel] [PATCH 5/8] scsi-disk: add scsi-block for device passthrough

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 118 1 files changed, 118 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f1f9335..f407e2b 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -39,6 +39,10

[Qemu-devel] [PATCH v2 15/33] qdev: switch children device list to QTAILQ

2011-10-25 Thread Paolo Bonzini
SCSI buses will need to read the children list first-to-last. This requires using a QTAILQ, because hell breaks loose if you just try inserting at the tail (thus reversing the order of all existing visits from last-to-first to first-to-tail). Signed-off-by: Paolo Bonzini --- hw/acpi_piix4.c

[Qemu-devel] [PATCH 1/2] qxl: stride fixup

2011-10-25 Thread Gerd Hoffmann
spice uses negative stride value to signal the bitmap is upside down. The qxl renderer (used for scl, vnc and screenshots) wants a positive value because it is easier to work with. The positive value is then stored in the very same variable, which has the drawback that the upside-down test works o

[Qemu-devel] [PATCH 0/2] qxl: local rendering fixes.

2011-10-25 Thread Gerd Hoffmann
Hi, These two patches fix up some issues we have with local rendering, i.e. spice-server rendering the screen instead of spice-client. Local rendering is used when qemu itself needs a fully rendered qxl display. Happens when combining qxl with vnc or sdl, also when doing screendumps. With this

[Qemu-devel] [PATCH 2/2] qxl: make sure we continue to run with a shared buffer

2011-10-25 Thread Gerd Hoffmann
The qxl renderer works only with a shared displaysurface. So better make sure we actually have one and restore it when needed. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c

[Qemu-devel] [PATCH 02/11] marvell_88x8618_audio: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/marvell_88w8618_audio.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/marvell_88w8618_audio.c b/hw/marvell_88w8618_audio.c index f8c5242..6982352 100644 --- a/hw/marvell_88w8618_audio.c +++ b/hw/marvell_

[Qemu-devel] [PATCH v2 08/33] scsi-disk: add stubs for more MMC commands

2011-10-25 Thread Paolo Bonzini
This patch adds a few stub implementations for MMC commands to scsi-disk, to be filled in later in the series. It also adds to scsi-defs.h constants for commands implemented by ide/atapi.c, when missing. Signed-off-by: Paolo Bonzini --- v1->v2: coding style (braces) hw/scsi-defs.h |

[Qemu-devel] [PATCH 06/11] syborg_keyboard: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_keyboard.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/syborg_keyboard.c b/hw/syborg_keyboard.c index 82b9dc0..03d2183 100644 --- a/hw/syborg_keyboard.c +++ b/hw/syborg_keyboard.c @@ -51,6 +51,7

[Qemu-devel] [PATCH 03/11] mst_fpga: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/mst_fpga.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/mst_fpga.c b/hw/mst_fpga.c index 7bcd5d7..e493e01 100644 --- a/hw/mst_fpga.c +++ b/hw/mst_fpga.c @@ -34,6 +34,7 @@ typedef struct mst_irq_stat

[Qemu-devel] [PATCH 08/11] syborg_rtc: convert to memory API

2011-10-25 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/syborg_rtc.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/syborg_rtc.c b/hw/syborg_rtc.c index 69f6ccf..375664f 100644 --- a/hw/syborg_rtc.c +++ b/hw/syborg_rtc.c @@ -35,12 +35,14 @@ enum { typedef s

[Qemu-devel] [PULL v2 00/33] SCSI changes for 1.0, part 1 of 2

2011-10-25 Thread Paolo Bonzini
Kevin, The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-for-kevin All comm

[Qemu-devel] [PATCH 0/5] My remaining block/SCSI patches for 1.0

2011-10-25 Thread Paolo Bonzini
The first three replace patches 20/21 and are basically rewritten with input from Kevin. The fourth is new. I had it queued for 1.1, but it turns out it is needed now or scsi-block might access some requests incorrectly when restarting after an error. The fifth is basically the same as patch 35

[Qemu-devel] [PATCH v2 18/33] scsi: allow arbitrary LUNs

2011-10-25 Thread Paolo Bonzini
This only requires changes in two places: in SCSIBus, we need to look for a free LUN if somebody creates a device with a pre-existing scsi-id but the default LUN (-1, meaning "search for a free spot"); in vSCSI, we need to actually parse the LUN according to the SCSI spec. For vSCSI, max_target/ma

[Qemu-devel] [PATCH v2 14/33] scsi: move tcq/ndev to SCSIBusOps (now SCSIBusInfo)

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- v1->v2: do not change max target in VSCSI hw/esp.c |7 +-- hw/lsi53c895a.c |9 ++--- hw/scsi-bus.c| 27 --- hw/scsi-disk.c |2 +- hw/scsi.h| 11 +-- hw/spapr_vscsi.c |8 +++

[Qemu-devel] [PATCH v2 10/33] atapi/scsi-disk: make mode page values coherent between the two

2011-10-25 Thread Paolo Bonzini
This patch adds to scsi-disk the missing mode page 0x01 for both disk and CD-ROM drives, and mode page 0x0e for CD drives only. A few offsets were wrong in atapi.c. Also change the 2Ah mode page to expose DVD media read capabilities in the IDE cdrom. This lets you run dvd+rw-mediainfo on the vir

[Qemu-devel] [PATCH v2 01/33] scsi: pass correct sense code for ENOMEDIUM

2011-10-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 6909578..9c62569 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -231,6 +231,9 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, in

[Qemu-devel] [PATCH v2 22/33] scsi-generic: drop SCSIGenericState

2011-10-25 Thread Paolo Bonzini
It is not needed, because s->bs is already stored in SCSIDevice, and can be reached from the conf.bs member. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 86 +++-- 1 files changed, 37 insertions(+), 49 deletions(-) diff --git a/hw/scsi-g

[Qemu-devel] [PATCH v2 20/33] scsi-disk: fail READ CAPACITY if LBA != 0 but PMI == 0

2011-10-25 Thread Paolo Bonzini
Tested by the Windows Logo Kit SCSI Compliance test. From SBC-3, paragraph 5.25: "The LOGICAL BLOCK ADDRESS field shall be set to zero if the PMI bit is set to zero. If the PMI bit is set to zero and the LOGICAL BLOCK ADDRESS field is not set to zero, then the device server shall terminate the comm

  1   2   3   >