Re: [Qemu-devel] [PATCH v2 0/6] trace: Add support for trace events grouping

2011-10-20 Thread Mark Wu
On 10/20/2011 02:41 PM, Mark Wu wrote: This series add support for trace events grouping. The state of a given group of trace events can be queried or changed in bulk by the following monitor commands: * info trace-groups View available trace event groups and their state. State 1 means enab

[Qemu-devel] [PATCH v2 1/6] trace: Make "tracetool" generate a group list

2011-10-20 Thread Mark Wu
Each trace events group starts with a line containing the string "group_start:group-name" and end with a line containing the string "group_end". The range of a trace events group is determined by the "tracetool" script when it processes the "trace-events" file. Signed-off-by: Mark Wu --- scripts

[Qemu-devel] [PATCH v2 6/6] trace: Update doc for trace events group

2011-10-20 Thread Mark Wu
Signed-off-by: Mark Wu --- docs/tracing.txt | 29 ++--- 1 files changed, 26 insertions(+), 3 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 95ca16c..139a331 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -16,6 +16,7 @@ for debugging, profi

[Qemu-devel] buildbot failure in qemu on monitor_i386_debian_6_0

2011-10-20 Thread qemu
The Buildbot has detected a new failure on builder monitor_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_i386_debian_6_0/builds/66 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

Re: [Qemu-devel] KVM VMenter/exit cost

2011-10-20 Thread 陳韋任
> Currently, when amd svm or intel vmx is used to run the guest os natively on > the chip, a kernel enter and vmenter are needed, and when the guest os > executes a trapping instruction, a vmexit and kernel exit is incurred. I > would like to know the latest estimate of the cost of VMEnter/VMExit o

Re: [Qemu-devel] balloon driver on winxp guest start failed

2011-10-20 Thread hkran
On 10/17/2011 08:55 PM, Vadim Rozenfeld wrote: On Fri, 2011-10-14 at 17:49 +0800, hkran wrote: On 10/14/2011 04:55 AM, Vadim Rozenfeld wrote: On Thu, 2011-10-13 at 15:47 +0100, Stefan Hajnoczi wrote: On Thu, Oct 13, 2011 at 5:00 AM, hkran wrote: On 10/12/2011 07:09 PM, hkran wrote: I used

[Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-20 Thread Stuart Brady
Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() respectively, in cases where the size passed to g_malloc() is specified as sizeof(type). Coccinelle did not match these when matching assignments involving an expression corresponding to the type used for determining the size to a

[Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new()

2011-10-20 Thread Stuart Brady
Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() respectively, in cases where the return value is casted to the same type as specified using sizeof() in the parameter to g_malloc() and assigned to a variable of that type. This was achieved using Coccinelle with the following sem

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-20 Thread Stuart Brady
On Wed, Oct 19, 2011 at 01:59:04AM +0100, Stuart Brady wrote: > On Tue, Oct 18, 2011 at 06:18:11PM +, Blue Swirl wrote: > > > Cool. Please include the spatch with the commit message. > > Thanks, will do! Okay, submitted. This is the first time I've used git send-email, so let me know if I'v

Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-20 Thread liu ping fan
On Wed, Oct 19, 2011 at 11:50:19AM +0800, canquan.shen wrote: > Hi ping fan, >Your patch is similar with my patch, my patch name is "acpi: Fix > CPU hot removal problem". I saw your patch, a little similar. BTW, how are things going on? It is a long time since V0 patch > > Thanks. > Canquan.Sh

Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-20 Thread canquan.shen
On 2011/10/20 16:08, liu ping fan wrote: On Wed, Oct 19, 2011 at 11:50:19AM +0800, canquan.shen wrote: Hi ping fan, Your patch is similar with my patch, my patch name is "acpi: Fix CPU hot removal problem". I saw your patch, a little similar. BTW, how are things going on? It is a long time

[Qemu-devel] [PATCH 4/5] Convert remaining calls to g_malloc(sizeof(type)) using casts to g_new()

2011-10-20 Thread Stuart Brady
Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() respectively, in cases where the return value is casted to the same type as specified using sizeof(type) as passed to g_malloc(). Coccinelle did not match these when matching assignments involving an expression corresponding to th

Re: [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new()

2011-10-20 Thread Paolo Bonzini
On 10/20/2011 10:03 AM, Stuart Brady wrote: Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() respectively, in cases where the return value is casted to the same type as specified using sizeof() in the parameter to g_malloc() and assigned to a variable of that type. This is li

Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-20 Thread Paolo Bonzini
On 10/20/2011 10:03 AM, Stuart Brady wrote: Coccinelle did not match these when matching assignments involving an expression corresponding to the type used for determining the size to allocate. They all look okay, perhaps the include path you passed to Coccinelle is incomplete? Reviewed-by:

Re: [Qemu-devel] [PATCH 1/8] vpc: detect floppy disk geometries

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > Converting a floppy image from RAW to VPC and back will generate > a zero-padded file of the wrong size, because the geometry is not > computed correctly. Special case floppy disk images, handling > standard MS-DOS capacities (160/180/320/360 for low d

Re: [Qemu-devel] [PATCH 2/8] vmdk: fix return values of vmdk_parent_open

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > While vmdk_open_desc_file (touched by the patch) correctly changed -1 > to -EINVAL, vmdk_open did not. Fix it directly in vmdk_parent_open. > > Signed-off-by: Paolo Bonzini > --- > block/vmdk.c | 11 ++- > 1 files changed, 6 insertions(+),

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-10-20 Thread Ricardo Padilha
Just to give some support to what Peter said, here is my experience with the patch from #32. I cross-compiled qemu 0.14.1 with the patch to ARMv5 and tried to run the i386 linux binary for dropbox. Although I no longer see the fork error message, the process gets stuck in an infinite loop running

Re: [Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > block/vmdk.c | 37 +++-- > 1 files changed, 15 insertions(+), 22 deletions(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index 21566eb..12b38d2 100644 > --- a/block/vmdk.c > +

Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-20 Thread qemulist
On Wed, Oct 19, 2011 at 09:35:46PM +0800, Gong Chen wrote: > On Wed, Oct 19, 2011 at 10:47 AM, wrote: > > From: Liu Ping Fan > > > > Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST > > > > Signed-off-by: Liu Ping Fan > > --- > >  drivers/acpi/bus.c      |    2 +- > >  drivers/acpi/scan.c

[Qemu-devel] [PATCH] Add wildcard trace event support

2011-10-20 Thread Mark Wu
A basic wildcard matching is supported in both the monitor command "trace-event" and the events list file. That means you can enable/disable the events having a common prefix in a batch. For example, virtio-blk trace events could be enabled using: trace-event virtio_blk_* on Signed-off-by: Mar

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-20 Thread Jan Kiszka
On 2011-10-20 03:22, Wen Congyang wrote: >>> I didn't read full story but 'crash' is used for investigating kernel core >>> generated >>> by kdump for several years. Considering support service guys, virsh dump >>> should support >>> a format for crash because they can't work well at investigatin

Re: [Qemu-devel] [PATCH 4/8] block: add a Rwlock to synchronous read/write drivers

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > The big conversion of bdrv_read/write to coroutines caused the two > homonymous callbacks in BlockDriver to become reentrant. It goes > like this: > > 1) bdrv_read is now called in a coroutine, and calls bdrv_read or > bdrv_pread. > > 2) the nested b

Re: [Qemu-devel] [PATCH 7/8] block: change flush to co_flush

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > Since coroutine operation is now mandatory, convert all bdrv_flush > implementations to coroutines. For qcow2, this means taking the lock. > Other implementations are simpler and just forward bdrv_flush to the > underlying protocol, so they can avoid t

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-20 Thread Wen Congyang
At 10/20/2011 05:41 PM, Jan Kiszka Write: > On 2011-10-20 03:22, Wen Congyang wrote: I didn't read full story but 'crash' is used for investigating kernel core generated by kdump for several years. Considering support service guys, virsh dump should support a format for c

Re: [Qemu-devel] [PATCH 8/8] block: change discard to co_discard

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > Since coroutine operation is now mandatory, convert both bdrv_discard > implementations to coroutines. For qcow2, this means taking the lock > around the operation. raw-posix remains synchronous. > > The bdrv_discard callback is then unused and can b

Re: [Qemu-devel] [PATCH 1/2] qemu: Add opt_set_bool functionality

2011-10-20 Thread Aneesh Kumar K.V
On Wed, 19 Oct 2011 22:46:32 +0530, "M. Mohan Kumar" wrote: > From: "M. Mohan Kumar" > > Signed-off-by: M. Mohan Kumar Applied with doc update to v9fs.git Thanks -aneesh

Re: [Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-20 Thread Paolo Bonzini
On 10/20/2011 11:28 AM, Kevin Wolf wrote: > This code is moved into bdrv_open, but there's another path how this > code can be reached: > > vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() -> > vmdk_open_desc_file(). > > Don't we forget to open the parent file there now? Let's l

Re: [Qemu-devel] [PATCH 1/8] vpc: detect floppy disk geometries

2011-10-20 Thread Paolo Bonzini
On 10/20/2011 11:14 AM, Kevin Wolf wrote: > diff --git a/block/vpc.c b/block/vpc.c > index cb6c570..549a632 100644 > --- a/block/vpc.c > +++ b/block/vpc.c > @@ -463,6 +463,14 @@ static int calculate_geometry(int64_t total_sectors, uint16_t* cyls, >{ >uint32_t cyls_times_heads; >

Re: [Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-20 Thread Kevin Wolf
Am 20.10.2011 12:12, schrieb Paolo Bonzini: > On 10/20/2011 11:28 AM, Kevin Wolf wrote: >> This code is moved into bdrv_open, but there's another path how this >> code can be reached: >> >> vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() -> >> vmdk_open_desc_file(). >> >> Don't we

[Qemu-devel] [PATCH] [v3] hw/arm_gic.c: Fix save/load of irq_target array

2011-10-20 Thread Dmitry Koshelev
irq_target array saving/loading is in the wrong loop. Version bump. Signed-off-by: Dmitry Koshelev --- hw/arm_gic.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 83213dd..8dd8742 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gi

Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

2011-10-20 Thread Stefano Stabellini
On Wed, 19 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > Makefile.target |2 ++ > configure | 21 + > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/Makefile.target b/Makefile.target > index 417f23e..c518103 100644 > -

Re: [Qemu-devel] [PATCH V2 02/10] Introduce HostPCIDevice to access a pci device on the host.

2011-10-20 Thread Stefano Stabellini
On Wed, 19 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > Makefile.target |1 + > hw/host-pci-device.c | 245 > ++ > hw/host-pci-device.h | 75 +++ > 3 files changed, 321 insertions(+), 0 deletions(-

Re: [Qemu-devel] [PATCH V2 08/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-10-20 Thread Stefano Stabellini
On Wed, 19 Oct 2011, Anthony PERARD wrote: > From: Allen Kay > > Signed-off-by: Allen Kay > Signed-off-by: Guy Zana > Signed-off-by: Anthony PERARD > --- > Makefile.target |2 + > hw/xen_pci_passthrough.c | 861 > ++ > hw/xen_

[Qemu-devel] [PATCH v2 0/7] finish coroutinization of drivers

2011-10-20 Thread Paolo Bonzini
Drivers that only implement the bdrv_read and bdrv_write callbacks were unwillingly converted to be reentrant when bdrv_read and bdrv_write were changed to always create coroutines. So, we need locks aroudn read and write operations. This series does this (patches 4-6) and removes the flush/disca

[Qemu-devel] [PATCH v2 1/7] vmdk: fix return values of vmdk_parent_open

2011-10-20 Thread Paolo Bonzini
While vmdk_open_desc_file (touched by the patch) correctly changed -1 to -EINVAL, vmdk_open did not. Fix it directly in vmdk_parent_open. Signed-off-by: Paolo Bonzini --- block/vmdk.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmd

[Qemu-devel] [PATCH v2 7/7] block: change discard to co_discard

2011-10-20 Thread Paolo Bonzini
Since coroutine operation is now mandatory, convert both bdrv_discard implementations to coroutines. For qcow2, this means taking the lock around the operation. raw-posix remains synchronous. The bdrv_discard callback is then unused and can be eliminated. Reviewed-by: Kevin Wolf Signed-off-by:

[Qemu-devel] [PATCH v2 2/7] vmdk: clean up open

2011-10-20 Thread Paolo Bonzini
Move vmdk_parent_open to vmdk_open. There's another path how vmdk_parent_open can be reached: vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() -> vmdk_open_desc_file(). If that can happen, however, the code is bogus. vmdk_parent_open reads from bs->file: if (bdrv_pread

[Qemu-devel] [PATCH v2 3/7] block: add a CoMutex to synchronous read drivers

2011-10-20 Thread Paolo Bonzini
The big conversion of bdrv_read/write to coroutines caused the two homonymous callbacks in BlockDriver to become reentrant. It goes like this: 1) bdrv_read is now called in a coroutine, and calls bdrv_read or bdrv_pread. 2) the nested bdrv_read goes through the fast path in bdrv_rw_co_entry; 3)

[Qemu-devel] [PATCH v2 6/7] block: change flush to co_flush

2011-10-20 Thread Paolo Bonzini
Since coroutine operation is now mandatory, convert all bdrv_flush implementations to coroutines. For qcow2, this means taking the lock. Other implementations are simpler and just forward bdrv_flush to the underlying protocol, so they can avoid the lock. The bdrv_flush callback is then unused and

[Qemu-devel] [PATCH v2 5/7] block: take lock around bdrv_write implementations

2011-10-20 Thread Paolo Bonzini
This does the first part of the conversion to coroutines, by wrapping bdrv_write implementations to take the write side of the rwlock. Drivers that implement bdrv_write rather than bdrv_co_writev can then benefit from asynchronous operation (at least if the underlying protocol supports it, which i

[Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations

2011-10-20 Thread Paolo Bonzini
This does the first part of the conversion to coroutines, by wrapping bdrv_read implementations to take the read side of the rwlock. Drivers that implement bdrv_read rather than bdrv_co_readv can then benefit from asynchronous operation (at least if the underlying protocol supports it, which is no

[Qemu-devel] [PULL] Migration queue

2011-10-20 Thread Juan Quintela
Anthony, Here are the pending patches of my migration series: - subsections detection fix - migration cleanup - migration errors Please consider pulling O:-) Thanks, Juan. The following changes since commit cfce6d8934243871c4dc6d0c5248b0b27a1b8d80: i8259: Move to hw library (2011-10-16 11:1

[Qemu-devel] [PATCH v2 0/2] nand/onenand: reject read-only drives

2011-10-20 Thread juha . riihimaki
From: Juha Riihimäki Make NAND and OneNAND device models reject read-only drives. Test for example by running $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=foo -device nand,drive=foo,chip_id=0x59 -kernel /dev/null or $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=fo

[Qemu-devel] [PATCH v2 1/2] hw/nand: reject read-only drives

2011-10-20 Thread juha . riihimaki
From: Juha Riihimäki also gracefully fail on nand_device_init() for unsupported block size instead of aborting. Signed-off-by: Juha Riihimäki --- hw/nand.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/nand.c b/hw/nand.c index c27783e..fad00d1

[Qemu-devel] [PATCH v2 2/2] hw/onenand: reject read-only drives

2011-10-20 Thread juha . riihimaki
From: Juha Riihimäki Signed-off-by: Juha Riihimäki --- hw/onenand.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/onenand.c b/hw/onenand.c index 6f68f70..7898da9 100644 --- a/hw/onenand.c +++ b/hw/onenand.c @@ -26,6 +26,7 @@ #include "memory.h" #include "exec

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-20 Thread jojelino
On 2011-10-20 AM 6:05, Bob Breuer wrote: We probably have a difference in build or run environment. I've double-checked with another machine and can get the same crash in longjmp when running the test executable on both WinXP and Win2k, but not on Win7. So it looks like Microsoft may have chan

[Qemu-devel] [PATCH 3/7] target-arm: Rename ARM_FEATURE_DIV to _THUMB_DIV

2011-10-20 Thread Peter Maydell
Rename the ARM_FEATURE_DIV feature bit to _THUMB_DIV, to make room for a new feature switch enabling DIV in the ARM encoding. (Cores may implement either (a) no divide insns (b) divide insns in Thumb encodings only (c) divide insns in both ARM and Thumb encodings.) Signed-off-by: Peter Maydell --

[Qemu-devel] [PULL 0/7] target-arm queue

2011-10-20 Thread Peter Maydell
Hi; these are the pending target-arm patches I'd like to get in for 1.0; a couple of minor ones plus the A15 insn work. Please pull. PS: I'm not sure who the best person to cc on target-arm pull requests is; any suggestions? thanks -- PMM The following changes since commit cfce6d8934243871c4dc6d

[Qemu-devel] [PATCH 7/7] target-arm/machine.c: Restore VFP registers correctly

2011-10-20 Thread Peter Maydell
From: Dmitry Koshelev Fix the restoring of VFP registers on vmload. Signed-off-by: Dmitry Koshelev Reviewed-by: Juan Quintela [peter.maydell: improved commit message a little] Signed-off-by: Peter Maydell --- target-arm/machine.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) d

[Qemu-devel] [PATCH 1/7] rsqrte_f32: No need to copy sign bit.

2011-10-20 Thread Peter Maydell
From: Christophe LYON Indeed, the result is known to be always positive. Signed-off-by: Christophe Lyon Signed-off-by: Peter Maydell --- target-arm/helper.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index e2428eb..17ef

[Qemu-devel] [PATCH 2/7] target-arm: v6 media multiply space: UNDEF on unassigned encodings

2011-10-20 Thread Peter Maydell
Clean up the decoding of the v6 media multiply space so that we UNDEF on unassigned encodings rather than randomly interpreting them as some instruction in this space. Signed-off-by: Peter Maydell --- target-arm/translate.c | 24 1 files changed, 20 insertions(+), 4 de

[Qemu-devel] [PATCH 6/7] target-arm: Implement VFPv4 fused multiply-accumulate insns

2011-10-20 Thread Peter Maydell
Implement the fused multiply-accumulate instructions (VFMA, VFMS, VFNMA, VFNMS) which are new in VFPv4. Signed-off-by: Peter Maydell --- target-arm/cpu.h |1 + target-arm/helper.c| 14 + target-arm/helper.h|3 ++ target-arm/translate.c | 72 +

[Qemu-devel] [PATCH 4/7] target-arm: Add ARM UDIV/SDIV support

2011-10-20 Thread Peter Maydell
Add support for UDIV and SDIV in ARM mode. This is a new optional feature for A profile cores (Thumb mode has had UDIV and SDIV for M profile cores for some time). Signed-off-by: Peter Maydell --- target-arm/cpu.h |1 + target-arm/helper.c|5 - target-arm/translate.c | 19

[Qemu-devel] [PATCH 5/7] softfloat: Implement fused multiply-add

2011-10-20 Thread Peter Maydell
Implement fused multiply-add as a softfloat primitive. This implements "a+b*c" as a single step without any intermediate rounding; it is specified in IEEE 754-2008 and implemented in a number of CPUs. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 178 ++ fpu/soft

Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()

2011-10-20 Thread Andreas Färber
Am 10.10.2011 14:52, schrieb Andreas Färber: > env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free(). > > Cc: Peter Maydell > Signed-off-by: Andreas Färber > --- > target-arm/helper.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-arm

Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()

2011-10-20 Thread Peter Maydell
On 20 October 2011 15:18, Andreas Färber wrote: > Am 10.10.2011 14:52, schrieb Andreas Färber: >> env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free(). >> >> Cc: Peter Maydell >> Signed-off-by: Andreas Färber >> --- >>  target-arm/helper.c |    2 +- >>  1 files changed, 1 i

[Qemu-devel] [PULL v2 0/8] target-arm queue

2011-10-20 Thread Peter Maydell
Hi; these are the pending target-arm patches I'd like to get in for 1.0; a couple of minor ones plus the A15 insn work. Please pull. V2 of this pullreq just adds Andreas' trivial patch as 8/8, so I haven't bothered re-emailing the identical 1-7, just this cover letter and 8/8. -- PMM The followi

[Qemu-devel] [PATCH] pc: Fix floppy drives with if=none

2011-10-20 Thread Kevin Wolf
Commit 63ffb564 broke floppy devices specific on the command line like -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it relies on drive_get() which works only with -fda/-drive if=floppy. This patch resembles what we're already doing for IDE, i.e. remember the floppy devic

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-20 Thread Kai Tietz
2011/10/20 xunxun : > Hi, all > > I think this issue causes the gdb crash on XP. > You can see the thread: http://sourceware.org/ml/gdb/2011-10/msg00056.html > > My many friends and I can reproduce this crash issue, but no problem on Win7. > > On Thu, Oct 20, 2011 at 5:05 AM, Bob Breuer wrote: >>

Re: [Qemu-devel] [PATCH] pc: Fix floppy drives with if=none

2011-10-20 Thread Zeeshan Ali (Khattak)
Hi Kevin, On Thu, Oct 20, 2011 at 5:41 PM, Kevin Wolf wrote: > Commit 63ffb564 broke floppy devices specific on the command line like > -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it > relies on drive_get() which works only with -fda/-drive if=floppy. > > This patch re

[Qemu-devel] [PATCH 8/8] target-arm: Fix use of free() in cpu_arm_close()

2011-10-20 Thread Peter Maydell
From: Andreas Färber env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free(). Signed-off-by: Andreas Färber Signed-off-by: Peter Maydell --- target-arm/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper

Re: [Qemu-devel] [PULL 00/18] Memory API conversions, batch 12

2011-10-20 Thread Anthony Liguori
On 10/19/2011 05:59 AM, Avi Kivity wrote: Please pull from: git://github.com/avikivity/qemu.git memory/batch Yet more of the same. This has been on the list for a while, with no adverse reviews. Pulled. Thanks. Regards, Anthony Liguori Avi Kivity (18): ppc_oldworld: convert to mem

Re: [Qemu-devel] [PULL] Migration queue

2011-10-20 Thread Anthony Liguori
On 10/20/2011 07:31 AM, Juan Quintela wrote: Anthony, Here are the pending patches of my migration series: - subsections detection fix - migration cleanup - migration errors Please consider pulling O:-) Thanks, Juan. The following changes since commit cfce6d8934243871c4dc6d0c5248b0b27a1b8d80

Re: [Qemu-devel] [PULL] VirtFS update 6

2011-10-20 Thread Anthony Liguori
On 10/15/2011 05:19 AM, Aneesh Kumar K.V wrote: The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git for-

Re: [Qemu-devel] [PULL 0/5]: QMP queue

2011-10-20 Thread Anthony Liguori
On 10/14/2011 12:26 PM, Luiz Capitulino wrote: Most of the patches are runstate fixes and have been sent to the list already. The changes (since 210b3a70383b0bcc4266856431491b39dcb4f14d) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git qmp/queue Pulled.

Re: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes

2011-10-20 Thread Daniel P. Berrange
On Fri, Oct 07, 2011 at 04:49:13PM +0530, Aneesh Kumar K.V wrote: > On Fri, 7 Oct 2011 10:27:56 +0100, "Daniel P. Berrange" > wrote: > > On Thu, Sep 29, 2011 at 04:22:16PM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 29, 2011 at 08:23:49PM +0530, Aneesh Kumar K.V wrote: > > > > On Thu, 29 S

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-20 Thread Kai Tietz
Hi, For trunk-version I have a tentative patch for this issue. On 4.6.x and older branches this doesn't work, as here we can't differenciate that easy between ms- and sysv-abi. But could somebody give this patch a try? Regards, Kai ChangeLog * config/i386/i386.c (ix86_frame_pointer_re

[Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Rich Wellum
Hi,Apologies in advance if I shouldn't be asking here - I can't find a dedicated forum.When I convert an ISO to a VMDk and try to deploy it as part of an OVF package in vSphere I get the following error:I've tried:qemu-img convert -O vmdk image.iso image.vmdkqemu-img convert -f raw image.iso -O vmd

Re: [Qemu-devel] [PATCH V5] Add stdio char device on windows

2011-10-20 Thread Fabien Chouteau
On 12/10/2011 16:47, Fabien Chouteau wrote: > On 06/10/2011 16:37, Fabien Chouteau wrote: >> Simple implementation of an stdio char device on Windows. >> > > Any comments? > Anthony, can you apply this patch please? Thanks in advance, -- Fabien Chouteau

Re: [Qemu-devel] [PATCH] pc: Fix floppy drives with if=none

2011-10-20 Thread Markus Armbruster
Kevin Wolf writes: > Commit 63ffb564 broke floppy devices specific on the command line like > -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it > relies on drive_get() which works only with -fda/-drive if=floppy. > > This patch resembles what we're already doing for IDE,

[Qemu-devel] [PATCH 2/8] configure: Update configure so that open_by_handle_at check returns correct value

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" According to David Gibson for some compiler/libc combinations, open_by_handle_at test in configure isn't quite right: because the file_handle pointer is never dereferenced, gcc doesn't complain even if it is undefined. Change the test as suggested by him. Signed-off-by:

[Qemu-devel] [PATCH 7/8] qemu-queue: Introduce QLIST_INSERT_HEAD_RCU and dummy RCU wrappers.

2011-10-20 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora SynthFS needs a QLIST_INSERT_HEAD_RCU to make sure list instructions are not re-ordered and therefore avoiding a crash. There may be parallel readers which should be allowed for lock-free access and this variant allows us to get rid of rwlocks used by readers. SynthFS is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] device_tree: Fix potential memory leak

2011-10-20 Thread Stefan Hajnoczi
On Mon, Oct 17, 2011 at 10:12:09PM +0200, Stefan Weil wrote: > cppcheck error report: > > device_tree.c:156: error: Memory leak: dupname > > Signed-off-by: Stefan Weil > --- > device_tree.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree

[Qemu-devel] [PATCH 4/8] hw/9pfs: Read-only support for 9p export

2011-10-20 Thread Aneesh Kumar K.V
From: "M. Mohan Kumar" A new fsdev parameter "readonly" is introduced to control accessing 9p export. readonly=on|off can be used to specify the access type. By default rw access is given to 9p export. Signed-off-by: M. Mohan Kumar Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |

[Qemu-devel] [PATCH 6/8] hw/9pfs: Add synthetic file system support using 9p

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" This patch create a synthetic file system with mount tag v_synth when -virtfs_synth command line option is specified in qemu. The synthetic file system can be mounted in guest using 9p using the below command line mount -t 9p -oversion=9p2000.L,trans=virtio v_synth Sy

[Qemu-devel] [PATCH 1/8] hw/9pfs: Fix error handling in local_mknod

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Update local_chown to remove unnecessary if loop Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-local.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index d561de8..b611

[Qemu-devel] [PATCH 8/8] hw/9pfs: Replace rwlocks with RCU variants of interfaces.

2011-10-20 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora Use QLIST_INSERT_HEAD_RCU and rcu_read_lock/unlock instead of rwlocks. Use v9fs_synth_mutex as a write-only mutex to handle concurrent writers. Signed-off-by: Harsh Prateek Bora Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-synth.c | 29 +

[Qemu-devel] [PATCH 5/8] hw/9pfs: Abstract open state of fid to V9fsFidOpenState

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" To implement synthetic file system in Qemu we may not really require file descriptor and Dir *. Make generic code use V9fsFidOpenState instead. Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h | 32 -- hw/9pfs/codir.c| 16 -

[Qemu-devel] [PATCH 0/8] VirtFS update 7 for review

2011-10-20 Thread Aneesh Kumar K.V
Hi, This patchset contain patches that will be included in the next pull request. Most of them are already posted to the list. Some of the patches got updated when adding to the v9fs.git tree. Please review -aneesh

Re: [Qemu-devel] [PATCH] ppc: Avoid decrementer related kvm exits

2011-10-20 Thread Alexander Graf
On 16.10.2011, at 22:26, David Gibson wrote: > In __cpu_ppc_store_decr(), we set up a regular timer used to trigger > decrementer interrupts. This is necessary to implement the decrementer > properly under TCG, but is unnecessary under KVM (true for both Book3S-PR > and Book3S-HV KVM variants),

Re: [Qemu-devel] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-20 Thread Alexander Graf
On 17.10.2011, at 21:15, David Gibson wrote: > Currently, when KVM is enabled, the pseries machine checks if the host > CPU supports VMX, VSX and/or DFP instructions and advertises > accordingly in the guest device tree. It does this regardless of what > CPU is selected on the command line. On

Re: [Qemu-devel] [PATCH] PPC: Bump qemu-system-ppc to 64-bit physical address space

2011-10-20 Thread Alexander Graf
On 18.10.2011, at 02:36, Andreas Färber wrote: > Am 18.10.2011 01:52, schrieb Alexander Graf: >> Some 32-bit PPC CPUs can use up to 36 bit of physicall address space. >> Treat them accordingly in the qemu-system-ppc binary type. > > physical > >> Signed-off-by: Alexander Graf >> --- >> configu

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: remove unneeded variable assignment

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:18:22PM +0400, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/vmdk.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/sh

[Qemu-devel] [PATCH 3/8] qemu: Add opt_set_bool functionality

2011-10-20 Thread Aneesh Kumar K.V
From: "M. Mohan Kumar" Signed-off-by: M. Mohan Kumar Signed-off-by: Aneesh Kumar K.V --- qemu-option.c | 43 +++ qemu-option.h |3 ++- 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 105d760..1fd2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:19:03PM +0400, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/vmdk.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/qed.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.gi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: remove unneeded variable assignment

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:17:56PM +0400, Pavel Borzenkov wrote: > 'ret' is unconditionally overwitten by qed_read_l1_table_sync() > > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/qed.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks, applied t

Re: [Qemu-devel] [RFC 3/6] block: wait for overlapping requests

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 6:48 AM, Marcelo Tosatti wrote: > On Mon, Oct 17, 2011 at 04:47:29PM +0100, Stefan Hajnoczi wrote: >> When copy-on-read is enabled it is necessary to wait for overlapping >> requests before issuing new requests.  This prevents races between the >> copy-on-read and a write r

Re: [Qemu-devel] [RFC 5/6] block: core copy-on-read logic

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 7:00 AM, Marcelo Tosatti wrote: > On Mon, Oct 17, 2011 at 04:47:31PM +0100, Stefan Hajnoczi wrote: >> Signed-off-by: Stefan Hajnoczi >> --- >>  block.c      |   69 >> ++ >>  trace-events |    1 + >>  2 files changed,

Re: [Qemu-devel] [Question]WinDbg runs too slowly or exits unexpectly when debug windows guest driver under QEMU 0.15.50

2011-10-20 Thread Stefan Hajnoczi
On Wed, Oct 19, 2011 at 3:24 AM, Mars.Cao wrote: > /usr/local/bin/qemu-system-x86_64 -drive > file=winxpsp3.img,if=virtio,format=qcow2,cache=none,aio=threads -smp 2 -net > tap,ifname=tap0,script=no,downscript=no -net > nic,model=virtio,macaddr=52:54:00:d6:be:bb -m 1024 --enable-kvm -serial > tcp:1

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Don't allow preallocation and compression at the same time

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 8:47 AM, Kevin Wolf wrote: > Only qcow and qcow2 can do compression at all, and they require unallocated > clusters when writing the compressed data. > > Signed-off-by: Kevin Wolf > --- >  qemu-img.c |    9 + >  1 files changed, 9 insertions(+), 0 deletions(-) Rev

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Stefan Hajnoczi
On Thu, Oct 20, 2011 at 8:48 AM, Rich Wellum wrote: > When I convert an ISO to a VMDk and try to deploy it as part of an OVF > package in vSphere I get the following error: > > I've tried: > qemu-img convert -O vmdk image.iso image.vmdk > qemu-img convert -f raw image.iso -O vmdk image.vmdk > I'm

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Rich Wellum
Hi Stefan, > qemu-img qemu-img version 0.15.50, Copyright (c) 2004-2008 Fabrice Bellard I haven't got this to work on any version - I was trying this version because of the expanded list of sub format versions - I thought one of them might be accepted. Thanks, ||Rich On Oct 20, 2011, at 1:50

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Stefan Hajnoczi
On Thu, Oct 20, 2011 at 10:54 AM, Rich Wellum wrote: > Hi Stefan, >> qemu-img > qemu-img version 0.15.50, Copyright (c) 2004-2008 Fabrice Bellard > I haven't got this to work on any version - I was trying this version > because of the expanded list of sub format versions - I thought one of them >

[Qemu-devel] passing secrets to block devices

2011-10-20 Thread Josh Durgin
We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid putting the secret on the command line, you can store the secret in a file and pass the file to qemu, but when this is automated, there's no good way to know

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-20 Thread Gerd Hoffmann
Hi, > If there are build problems with libfdt on any platform let me know > about them. I would like it to build clean as widely as possible, but > I don't have that great a diversity of build environments, so I have > to reply on bug reports. Fails to build on RHEL-5: CC convert-dts

[Qemu-devel] [PATCH] monitor: refactor whitespace and optional argument parsing

2011-10-20 Thread Alon Levy
Takes out the optional ('?') message parsing from the main switch loop in monitor_parse_command. Adds optional argument option for boolean parameters. Signed-off-by: Alon Levy --- Hi, I think I've sent this before as part of another series, but the rest of the patches became non relevant (the

[Qemu-devel] [PATCH] monitor: refactor whitespace and optional argument parsing

2011-10-20 Thread Alon Levy
Takes out the optional ('?') message parsing from the main switch loop in monitor_parse_command. Adds optional argument option for boolean parameters. Signed-off-by: Alon Levy --- Previous patch used qemu_free (that's how old it is), fixed. monitor.c | 79 +++--

[Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-20 Thread Max Filippov
Hi. Current git head build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers. Error messages: In file included from trace.c:2:0: trace.h: In function ‘trace_v9fs_attach’: trace.h:2850:9: error: too many arguments f

Re: [Qemu-devel] passing secrets to block devices

2011-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: > We're working on libvirt support for block device authentication [1]. To > authenticate, rbd needs a username and a secret. Normally, to > avoid putting the secret on the command line, you can store the secret > in a file and pass the f

  1   2   >