[Qemu-devel] [PATCH v2 2/2] qcow2: Fix bdrv_write_compressed error handling

2011-10-19 Thread Kevin Wolf
If during allocation of compressed clusters the cluster was already allocated uncompressed, fail and properly release the l2_table (the latter avoids a failed assertion). While at it, make it return some real error numbers instead of -1. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |

Re: [Qemu-devel] [PATCH v2 2/2] qcow2: Fix bdrv_write_compressed error handling

2011-10-19 Thread wdongxu
Reviewed-by: Dong Xu Wang 引用 Kevin Wolf : If during allocation of compressed clusters the cluster was already allocated uncompressed, fail and properly release the l2_table (the latter avoids a failed assertion). While at it, make it return some real error numbers instead of -1. Signed-off

Re: [Qemu-devel] hw/nand hw/onenand and read-only

2011-10-19 Thread Markus Armbruster
writes: > On 18.10.11 16:38 , "ext Markus Armbruster" wrote: > >>$ qemu-system-arm -drive if=none,file=tmp.qcow2,readonly,id=foo >>-device nand,drive=foo -kernel /dev/null >>qemu: hardware error: nand_device_init: Unsupported NAND block size. >>[...] >> >>Note that I didn't bother su

Re: [Qemu-devel] [PATCH 1/2] qxl: create slots on post_load in any state

2011-10-19 Thread Gerd Hoffmann
On 10/18/11 17:26, Alon Levy wrote: If we migrate when the device is not in a native state the guest still believes the slots are created, and will cause operations that reference the slots, causing a "panic: virtual address out of range" on the first of them. Easy to see by migrating in vga mode

Re: [Qemu-devel] hw/nand hw/onenand and read-only

2011-10-19 Thread Peter Maydell
On 19 October 2011 09:03, Markus Armbruster wrote: > writes: >> both device models already support running without a drive as well by >> using a memory buffer instead so it would also be possible to make them >> use a read-only drive in a way that initial NAND/OneNAND contents would be >> read fr

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-19 Thread Michael S. Tsirkin
On Wed, Oct 19, 2011 at 08:41:48AM +0200, Jan Kiszka wrote: > > a single GSI and vice versa. As there are less GSIs than possible > > MSI > > messages, we could run out of them when creating routes, statically > > or > > lazily. > > > > What

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-19 Thread Avi Kivity
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/2011 09:50 PM, Jan Kiszka wrote: > On 2011-10-18 19:34, Avi Kivity wrote: > > On 10/18/2011 06:49 PM, Jan Kiszka wrote: > >> On 2011-10-18 18:40, Avi Kivity wrote: > >>> On 10/18/2011 04:30 PM, Avi Kivity wrote: > This takes a while to r

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-19 Thread Avi Kivity
On 10/18/2011 03:46 AM, David Gibson wrote: > On Sun, Oct 16, 2011 at 03:15:53PM +0200, Avi Kivity wrote: > > On 10/14/2011 04:14 AM, David Gibson wrote: > > > > Virtio is a very, very special case. virtio requires coherent RAM > > > > access. > > > > > > Right. Virtio's access to memory is *not

Re: [Qemu-devel] hw/nand hw/onenand and read-only

2011-10-19 Thread Kevin Wolf
Am 19.10.2011 10:46, schrieb Peter Maydell: > On 19 October 2011 09:03, Markus Armbruster wrote: >> writes: >>> both device models already support running without a drive as well by >>> using a memory buffer instead so it would also be possible to make them >>> use a read-only drive in a way that

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Avi Kivity
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/2011 09:41 PM, Jan Kiszka wrote: > > Looks OK to me. > > Same here. - -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Com

[Qemu-devel] [Bug 878019] [NEW] 0.15.1 black screen and 100% cpu on start

2011-10-19 Thread Curaga
Public bug reported: Trying the freshly compiled 0.15.1 (command line: "qemu"), the window stays black, it uses 100% cpu, and can't be killed with ctrl-c, has to be killed with killall -9. Strace shows it's waiting on a futex forever? Build config: ./configure --prefix=/usr/local --interp-prefix

[Qemu-devel] [Bug 878019] Re: 0.15.1 black screen and 100% cpu on start

2011-10-19 Thread Curaga
** Attachment added: "strace output, from "strace qemu"" https://bugs.launchpad.net/bugs/878019/+attachment/2559806/+files/strace.out -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/878019 Title:

Re: [Qemu-devel] hw/nand hw/onenand and read-only

2011-10-19 Thread Markus Armbruster
Peter Maydell writes: > On 19 October 2011 09:03, Markus Armbruster wrote: >> writes: >>> both device models already support running without a drive as well by >>> using a memory buffer instead so it would also be possible to make them >>> use a read-only drive in a way that initial NAND/OneNAN

Re: [Qemu-devel] [PATCH 1/2] qxl: create slots on post_load in any state

2011-10-19 Thread Alon Levy
On Wed, Oct 19, 2011 at 10:28:57AM +0200, Gerd Hoffmann wrote: > On 10/18/11 17:26, Alon Levy wrote: > >If we migrate when the device is not in a native state the guest > >still believes the slots are created, and will cause operations > >that reference the slots, causing a "panic: virtual address

[Qemu-devel] [Question]WinDbg runs too slowly or exits unexpectly when debug windows guest driver under QEMU 0.15.50

2011-10-19 Thread Mars.Cao
WinDbg runs too slowly or exits unexpectedly when debug windows guest driver under QEMU 0.15. I installed 2 windows (WinXP SP3)VMs on my host (RHEL6.1). The basic debug method is : 1.Setup the Windows driver Kit in host /usr/local/bin/qemu-system-x86_64 -drive file=winxpsp3.img,if=virtio,f

Re: [Qemu-devel] [Question]WinDbg runs too slowly or exits unexpectly when debug windows guest driver under QEMU 0.15.50

2011-10-19 Thread Avi Kivity
On 10/19/2011 12:24 PM, Mars.Cao wrote: > > There are several problems when debugging: > > 1).The Windows VM boot slow (more than 20 seconds)and does not run > smoothly. > I use the qemu-kvm (version 0.12.1) which pre-installed in the RedHat > RHEL6.1 with same option and same image file, the VM bo

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-19 Thread Jan Kiszka
On 2011-10-19 03:55, pingf...@linux.vnet.ibm.com wrote: > From: Liu Ping Fan > > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > of sysbus. So we can support APIC hot-plug feature. > > Signed-off-by: liu pi

Re: [Qemu-devel] [PATCH 0/7] V2. Finish to convert integratorcp and stellaris to memory API

2011-10-19 Thread Avi Kivity
On 10/17/2011 05:28 PM, Benoît Canet wrote: > Theses patches finish to convert integratorcp.c and stellaris.c to the > new memory API. > > They apply on git://github.com/avikivity/qemu.git memory/master. > > Thanks, applied to memory/queue. -- I have a truly marvellous patch that fixes the bug w

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Jan Kiszka
On 2011-10-19 08:33, Lai Jiangshan wrote: > On 10/19/2011 03:41 AM, Jan Kiszka wrote: >> On 2011-10-17 18:00, Lai Jiangshan wrote: >>> On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: >>> >> >> LINT1 may have been programmed as a level -trigger

[Qemu-devel] [PULL 00/18] Memory API conversions, batch 12

2011-10-19 Thread Avi Kivity
Please pull from: git://github.com/avikivity/qemu.git memory/batch Yet more of the same. This has been on the list for a while, with no adverse reviews. Avi Kivity (18): ppc_oldworld: convert to memory API ppc_prep: convert to memory API pxa2xx: convert to memory API (part I) pxa2xx:

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-19 Thread Jan Kiszka
On 2011-10-19 11:03, Michael S. Tsirkin wrote: >>> I thought we need to match APIC ID. That needs a table lookup, no? >> >> Yes. But that's completely independent of a concrete MSI message. In >> fact, this is the same thing we need when interpreting an IOAPIC >> redirection table entry. So let's c

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-19 Thread Jan Kiszka
On 2011-10-19 11:04, Avi Kivity wrote: > > On 10/18/2011 09:50 PM, Jan Kiszka wrote: >> On 2011-10-18 19:34, Avi Kivity wrote: >>> On 10/18/2011 06:49 PM, Jan Kiszka wrote: On 2011-10-18 18:40, Avi Kivity wrote: > On 10/18/2011 04:30 PM, Avi Kivity wrote: >> This takes a while to repr

[Qemu-devel] [PATCH] integratorcp: convert control to sysbus

2011-10-19 Thread Benoît Canet
This patch convert the integratorcp control registers to sysbus. Benoît Canet (1): integratorcp: convert control to sysbus hw/integratorcp.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) -- 1.7.5.4

[Qemu-devel] [PATCH] integratorcp: convert control to sysbus

2011-10-19 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 7f79560..70fedbe 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -393,6 +393,11 @@ static int icp_pic

[Qemu-devel] [PATCH 18/18] tcx: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/tcx.c | 152 ++--- 1 files changed, 85 insertions(+), 67 deletions(-) diff --git a/hw/tcx.c b/hw/tcx.c index 309600d..cd24100 100644 --- a/hw/tcx.c +++ b/hw/tcx.c @@ -40,7 +40,15 @@ DisplayState *ds;

[Qemu-devel] [PATCH 04/18] pxa2xx: convert to memory API (part II)

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pxa.h|5 ++ hw/pxa2xx.c | 148 -- 2 files changed, 66 insertions(+), 87 deletions(-) diff --git a/hw/pxa.h b/hw/pxa.h index 3fb070f..7e98384 100644 --- a/hw/pxa.h +++ b/hw/pxa.h @@ -122,6 +122,11 @@

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-19 Thread Jan Kiszka
On 2011-10-19 04:04, KAMEZAWA Hiroyuki wrote: > On Tue, 18 Oct 2011 10:31:10 +0200 > Jan Kiszka wrote: > >> On 2011-10-18 10:31, Wen Congyang wrote: >>> At 10/18/2011 04:26 PM, Jan Kiszka Write: On 2011-10-18 10:25, Wen Congyang wrote: > At 10/18/2011 04:19 PM, Jan Kiszka Write: >> O

[Qemu-devel] [PATCH 15/18] sun4u: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sun4u.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 96fc3d0..eaaefe3 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -574,6 +574,11 @@ static void pci_ebus_register(void) device_init(p

[Qemu-devel] [PATCH 12/18] spitz: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/spitz.c | 48 ++-- 1 files changed, 18 insertions(+), 30 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index 6f8a94c..23f9d41 100644 --- a/hw/spitz.c +++ b/hw/spitz.c @@ -49,6 +49,7 @@ typedef struct { Sys

[Qemu-devel] [PATCH 13/18] strongarm: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/collie.c|4 +- hw/strongarm.c | 171 ++-- hw/strongarm.h |6 ++- 3 files changed, 75 insertions(+), 106 deletions(-) diff --git a/hw/collie.c b/hw/collie.c index a10cc1b..8dd6e4e 100644 --- a/hw/col

[Qemu-devel] [PATCH 14/18] sun4m: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sun4m.c | 49 - 1 files changed, 32 insertions(+), 17 deletions(-) diff --git a/hw/sun4m.c b/hw/sun4m.c index 71bf648..314edc4 100644 --- a/hw/sun4m.c +++ b/hw/sun4m.c @@ -593,19 +593,25 @@ static void idreg_init(

[Qemu-devel] [PATCH 09/18] s390-virtio: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/s390-virtio.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c index 778cffe..60c66e9 100644 --- a/hw/s390-virtio.c +++ b/hw/s390-virtio.c @@ -29,6 +29,7 @@ #include "hw/virtio.h" #include "hw/sy

[Qemu-devel] [PATCH 05/18] pci: simplify memory region registration

2011-10-19 Thread Avi Kivity
The two code paths (for ADDRESS_SPACE_IO and ADDRESS_SPACE_MEM) are identical. Unify them. Signed-off-by: Avi Kivity --- hw/pci.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 749e8d8..e8cc1b0 100644 --- a/hw/pci.c +++ b/hw/pci.c

[Qemu-devel] [PATCH 02/18] ppc_prep: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ppc_prep.c | 107 ++--- 1 files changed, 41 insertions(+), 66 deletions(-) diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c index 6427baa..f22d5b9 100644 --- a/hw/ppc_prep.c +++ b/hw/ppc_prep.c @@ -116,16 +116,17 @@

[Qemu-devel] [PATCH 16/18] syborg: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/syborg.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/syborg.c b/hw/syborg.c index bc200e4..248de54 100644 --- a/hw/syborg.c +++ b/hw/syborg.c @@ -26,6 +26,7 @@ #include "boards.h" #include "arm-misc.h" #include "net.h" +#i

[Qemu-devel] [PATCH 17/18] tc63963xb: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/devices.h |3 +- hw/tc6393xb.c | 71 +--- hw/tosa.c |2 +- 3 files changed, 25 insertions(+), 51 deletions(-) diff --git a/hw/devices.h b/hw/devices.h index 8ac384f..1a55c1e 100644 --- a/hw/device

[Qemu-devel] [PATCH 10/18] sm501: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sm501.c | 143 +-- 1 files changed, 70 insertions(+), 73 deletions(-) diff --git a/hw/sm501.c b/hw/sm501.c index a7ed6fa..297bc9c 100644 --- a/hw/sm501.c +++ b/hw/sm501.c @@ -459,7 +459,7 @@ target_phy

[Qemu-devel] [PATCH 08/18] realview: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/realview.c | 54 ++ 1 files changed, 26 insertions(+), 28 deletions(-) diff --git a/hw/realview.c b/hw/realview.c index 11ffb8a..14281b0 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -18,17 +18,20 @@ #inc

[Qemu-devel] [PATCH 07/18] r2d: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/r2d.c | 35 +++ 1 files changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/r2d.c b/hw/r2d.c index 82377a0..b65fd42 100644 --- a/hw/r2d.c +++ b/hw/r2d.c @@ -82,6 +82,7 @@ /* output pin */ qemu_irq irl; +MemoryR

[Qemu-devel] [PATCH 06/18] ppcr500_mpc8544ds: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ppce500_mpc8544ds.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 5bf8eab..51b6abd 100644 --- a/hw/ppce500_mpc8544ds.c +++ b/hw/ppce500_mpc8544ds.c @@ -229,6 +229,7 @@ static void

[Qemu-devel] [PATCH 01/18] ppc_oldworld: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ppc_oldworld.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c index ebcaafa..aac3526 100644 --- a/hw/ppc_oldworld.c +++ b/hw/ppc_oldworld.c @@ -73,11 +73,13 @@ static void ppc_heathrow_ini

[Qemu-devel] [PATCH 11/18] spapr: convert to memory API

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/spapr.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/spapr.c b/hw/spapr.c index b118975..63e5d33 100644 --- a/hw/spapr.c +++ b/hw/spapr.c @@ -41,6 +41,8 @@ #include "kvm.h" #include "kvm_ppc.h" +#include "exec-memory.h" +

[Qemu-devel] [PATCH 03/18] pxa2xx: convert to memory API (part I)

2011-10-19 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pxa.h|1 + hw/pxa2xx.c | 116 -- 2 files changed, 49 insertions(+), 68 deletions(-) diff --git a/hw/pxa.h b/hw/pxa.h index 1204165..3fb070f 100644 --- a/hw/pxa.h +++ b/hw/pxa.h @@ -151,6 +151,7 @@ t

Re: [Qemu-devel] [PATCH] integratorcp: convert control to sysbus

2011-10-19 Thread Peter Maydell
2011/10/19 Benoît Canet : > +static int icp_control_init(SysBusDevice *dev) >  { > -    MemoryRegion *io; > +    icp_control_state *s = FROM_SYSBUS(icp_control_state, dev); > > -    io = (MemoryRegion *)g_malloc0(sizeof(MemoryRegion)); > -    memory_region_init_io(io, &icp_control_ops, NULL, > +  

Re: [Qemu-devel] [PATCH] qxl: fix guest cursor tracking

2011-10-19 Thread Gerd Hoffmann
On 10/18/11 18:58, Yonit Halperin wrote: > (1) If the guest cursor command is empty, don't reload it after migration. > (2) Cleaning the guest cursor when it is released by > the spice server. In addition, explicitly reset the > cursor in spice upon destroying the primary surface > (was

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-19 Thread Anthony Liguori
On 10/19/2011 05:53 AM, Jan Kiszka wrote: On 2011-10-19 03:55, pingf...@linux.vnet.ibm.com wrote: From: Liu Ping Fan Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead of sysbus. So we can support APIC hot-plug f

Re: [Qemu-devel] [PATCH 2/5] runstate: Print state transition when invalid

2011-10-19 Thread Luiz Capitulino
On Wed, 19 Oct 2011 08:43:33 +0800 Wen Congyang wrote: > At 10/15/2011 01:26 AM, Luiz Capitulino Write: > > Makes it easier to debug. > > > > Signed-off-by: Luiz Capitulino > > --- > > vl.c |4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/vl.c b/vl.c > >

[Qemu-devel] [RESEND PULL 0/5]: QMP queue

2011-10-19 Thread Luiz Capitulino
Anthony, I'm resending this pull request because Wen Congyang has found a bug in one of the patches. And also to ping you to pull it :-) The changes (since cfce6d8934243871c4dc6d0c5248b0b27a1b8d80) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp L

[Qemu-devel] [PATCH 3/5] runstate: Allow to transition from paused to postmigrate

2011-10-19 Thread Luiz Capitulino
The user may already have paused the VM before starting the migration process. If s/he does that, then the state will be 'paused' when we finish the migration process. In that case we want to transition from 'paused' to 'postmigrate' as the latter is now the real reason why the VM is stopped. Sign

[Qemu-devel] [PATCH V2] integratorcp: convert control to sysbus

2011-10-19 Thread Benoît Canet
Convert control registers to sysbus. This version get rid of an unneeded comment. Benoît Canet (1): integratorcp: convert control to sysbus hw/integratorcp.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) -- 1.7.5.4

[Qemu-devel] [PATCH 2/5] runstate: Print state transition when invalid

2011-10-19 Thread Luiz Capitulino
Makes it easier to debug. Signed-off-by: Luiz Capitulino --- vl.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 2dce3ae..2a634a7 100644 --- a/vl.c +++ b/vl.c @@ -393,9 +393,12 @@ void runstate_init(void) /* This function will abort() on inval

Re: [Qemu-devel] [PATCH] integratorcp: convert control to sysbus

2011-10-19 Thread Peter Maydell
2011/10/19 Benoît Canet : > Signed-off-by: Benoit Canet Reviewed-by: Peter Maydell Avi -- since this applies on top of the memory region conversions in your queue, do you want to take this patch too? Otherwise I'll just have to hold onto it until you land those... thanks -- PMM

Re: [Qemu-devel] [PATCH 20/35] scsi-disk: do not complete requests twice

2011-10-19 Thread Paolo Bonzini
On 10/13/2011 01:03 PM, Paolo Bonzini wrote: When scsi_handle_rw_error reports a CHECK CONDITION code, the owner should not call scsi_req_complete. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/sc

Re: [Qemu-devel] [PATCH v2 21/35] scsi-disk: bump SCSIRequest reference count until aio completion runs

2011-10-19 Thread Paolo Bonzini
On 10/17/2011 05:37 PM, Paolo Bonzini wrote: In some cases a request may be canceled before the completion callback runs. Keep a reference to the request between starting an AIO operation, and let scsi_*_complete remove it. Since scsi_handle_rw_error returns whether something else has to be don

Re: [Qemu-devel] [PATCH V5] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-19 Thread Peter Maydell
On 18 October 2011 22:45, Mathieu Sonet wrote: > This driver emulates the ARM AACI interface (PL041) connected to a LM4549 > codec. > It enables audio playback for the Versatile/PB platform. > Signed-off-by: Mathieu Sonet Reviewed-by: Peter Maydell I'm about to send out the patch which adds t

[Qemu-devel] [PATCH 1/5] QMP: Fix blockdev-snapshot-sync doc example

2011-10-19 Thread Luiz Capitulino
Fix wrong command name. Reported-by: Eric Blake Signed-off-by: Luiz Capitulino --- qmp-commands.hx |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 9c11e87..4328e8b 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -710,

[Qemu-devel] [PATCH] hw/vexpress.c, hw/realview.c: Add PL041 to VExpress, Realview boards

2011-10-19 Thread Peter Maydell
Instantiate the PL041 audio on the Versatile Express and Realview board models. Signed-off-by: Peter Maydell --- This obviously is intended to be applied after Mathieu Sonet's PL041/AACI v5 patch. hw/realview.c |8 +++- hw/vexpress.c |7 ++- 2 files changed, 13 insertions(+), 2

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-19 Thread Jan Kiszka
On 2011-10-19 14:54, Anthony Liguori wrote: > On 10/19/2011 05:53 AM, Jan Kiszka wrote: >> On 2011-10-19 03:55, pingf...@linux.vnet.ibm.com wrote: >>> From: Liu Ping Fan >>> >>> Introduce a new structure CPUS as the controller of ICC (INTERRUPT >>> CONTROLLER COMMUNICATIONS), and new bus "ICC" to h

Re: [Qemu-devel] [PATCH V5] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-19 Thread Peter Maydell
On 19 October 2011 14:30, Peter Maydell wrote: > NB: this doesn't apply on current master for two reasons: > (1) something somewhere has added extra leading spaces > (2) the versatilepb patches don't seem to be against master > so don't apply for a trivial wrong-context reason Oops, (2) was me do

Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-19 Thread Gong Chen
On Wed, Oct 19, 2011 at 10:47 AM, wrote: > From: Liu Ping Fan > > Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST > > Signed-off-by: Liu Ping Fan > --- >  drivers/acpi/bus.c      |    2 +- >  drivers/acpi/scan.c     |    2 +- >  include/acpi/acpi_bus.h |    2 ++ >  3 files changed, 4 inse

[Qemu-devel] [PATCH 5/5] runstate: Allow user to migrate twice

2011-10-19 Thread Luiz Capitulino
It should be a matter of allowing the transition POSTMIGRATE -> FINISH_MIGRATE, but it turns out that the VM won't do the transition the second time because it's already stopped. So this commit also adds vm_stop_force_state() which performs the transition even if the VM is already stopped. While

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-19 Thread Jan Kiszka
On 2011-10-19 15:33, Jan Kiszka wrote: > On 2011-10-19 14:54, Anthony Liguori wrote: >> On 10/19/2011 05:53 AM, Jan Kiszka wrote: >>> On 2011-10-19 03:55, pingf...@linux.vnet.ibm.com wrote: From: Liu Ping Fan Introduce a new structure CPUS as the controller of ICC (INTERRUPT CON

[Qemu-devel] [PATCH] integratorcp: convert control to sysbus

2011-10-19 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 7f79560..7ad68b7 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -393,6 +393,11 @@ static int icp_pi

[Qemu-devel] [PATCH 4/5] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-19 Thread Luiz Capitulino
qemu_savevm_state() has some logic to stop the VM and to (or not to) resume it. But this seems to be a big noop, as qemu_savevm_state() is only called by do_savevm() when the VM is already stopped. So, let's drop qemu_savevm_state()'s stop VM logic. Reviewed-by: Michael Roth Reviewed-by: Kevin W

[Qemu-devel] [PATCH V2 08/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-10-19 Thread Anthony PERARD
From: Allen Kay Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- Makefile.target |2 + hw/xen_pci_passthrough.c | 861 ++ hw/xen_pci_passthrough.h | 258 hw/xen_pci_passth

[Qemu-devel] [PATCH] [v2] arm gic saving/loading fix

2011-10-19 Thread Dmitry Koshelev
irq_target field saving/loading is in the wrong loop version bump Signed-off-by: Dmitry Koshelev --- hw/arm_gic.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 8286a28..d0747cf 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.

[Qemu-devel] [PATCH V2 02/10] Introduce HostPCIDevice to access a pci device on the host.

2011-10-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |1 + hw/host-pci-device.c | 245 ++ hw/host-pci-device.h | 75 +++ 3 files changed, 321 insertions(+), 0 deletions(-) create mode 100644 hw/host-pci-device.c create mode 10

[Qemu-devel] [PATCH V2 03/10] pci.c: Add pci_check_bar_overlap

2011-10-19 Thread Anthony PERARD
From: Yuji Shimada This function help Xen PCI Passthrough device to check for overlap. Signed-off-by: Yuji Shimada Signed-off-by: Anthony PERARD --- hw/pci.c | 47 +++ hw/pci.h |3 +++ 2 files changed, 50 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [PATCH V2 00/10] Xen PCI Passthrough

2011-10-19 Thread Anthony PERARD
Hi all, This patch series introduce the PCI passthrough for Xen. First, we have HostPCIDevice that help to access one PCI device of the host. Then, there is an additions in the QEMU code, pci_check_bar_overlap. There are also several change in pci_ids and pci_regs. Last part, but not least, th

[Qemu-devel] [PATCH V2 04/10] pci_ids: Add INTEL_82599_VF id.

2011-10-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 83f3893..2ea5ec2 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -117,6 +117,7 @@ #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 #define PCI

Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

2011-10-19 Thread Peter Maydell
On 19 October 2011 14:56, Anthony PERARD wrote: > +if test "$xen_pci_passthrough" != "no"; then > +  if test "$xen" = "yes" -a "$linux" = "yes"; then > +    xen_pci_passthrough=yes > +  else > +    if test "$xen_pci_passthrough" = "yes"; then > +      feature_not_found "Xen PCI Passthrough without

[Qemu-devel] [PATCH V2 06/10] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2011-10-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index 6b42515..56a404b 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -392,6 +392,7 @@ #define PCI_EXP_TYPE_UPSTREAM 0x5 /* Upstream Port

[Qemu-devel] [PATCH V2 07/10] Introduce apic-msidef.h

2011-10-19 Thread Anthony PERARD
This patch move the msi definition from apic.c to apic-msidef.h. So it can be used also by other .c files. Signed-off-by: Anthony PERARD --- hw/apic-msidef.h | 28 hw/apic.c| 11 +-- 2 files changed, 29 insertions(+), 10 deletions(-) create mode

[Qemu-devel] [PATCH V2 05/10] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.

2011-10-19 Thread Anthony PERARD
Value check in PCI Express Base Specification rev 1.1 Signed-off-by: Anthony PERARD --- hw/pci_regs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index e8357c3..6b42515 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -393,7 +393,7 @@

[Qemu-devel] [PATCH V2 10/10] Introduce Xen PCI Passthrough, MSI (3/3)

2011-10-19 Thread Anthony PERARD
From: Jiang Yunhong Signed-off-by: Jiang Yunhong Signed-off-by: Shan Haitao Signed-off-by: Anthony PERARD --- Makefile.target |1 + hw/apic-msidef.h |2 + hw/xen_pci_passthrough.h | 20 ++ hw/xen_pci_passthrough_msi.c | 667 +

[Qemu-devel] [PATCH 0/8] finish coroutinization of drivers

2011-10-19 Thread Paolo Bonzini
Drivers that only implement the bdrv_read and bdrv_write callbacks were unwillingly converted to be reentrant when bdrv_read and bdrv_write were changed to always create coroutines. So, we need locks aroudn read and write operations. This series does this (patches 4-6) and removes the flush/disca

[Qemu-devel] [PATCH 7/8] block: change flush to co_flush

2011-10-19 Thread Paolo Bonzini
Since coroutine operation is now mandatory, convert all bdrv_flush implementations to coroutines. For qcow2, this means taking the lock. Other implementations are simpler and just forward bdrv_flush to the underlying protocol, so they can avoid the lock. The bdrv_flush callback is then unused and

[Qemu-devel] [PATCH 5/8] block: take lock around bdrv_read implementations

2011-10-19 Thread Paolo Bonzini
This does the first part of the conversion to coroutines, by wrapping bdrv_read implementations to take the read side of the rwlock. Drivers that implement bdrv_read rather than bdrv_co_readv can then benefit from asynchronous operation (at least if the underlying protocol supports it, which is no

Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

2011-10-19 Thread Anthony PERARD
On Wed, Oct 19, 2011 at 15:48, Peter Maydell wrote: > On 19 October 2011 14:56, Anthony PERARD wrote: >> +if test "$xen_pci_passthrough" != "no"; then >> +  if test "$xen" = "yes" -a "$linux" = "yes"; then >> +    xen_pci_passthrough=yes >> +  else >> +    if test "$xen_pci_passthrough" = "yes";

[Qemu-devel] [PATCH 4/8] block: add a Rwlock to synchronous read/write drivers

2011-10-19 Thread Paolo Bonzini
The big conversion of bdrv_read/write to coroutines caused the two homonymous callbacks in BlockDriver to become reentrant. It goes like this: 1) bdrv_read is now called in a coroutine, and calls bdrv_read or bdrv_pread. 2) the nested bdrv_read goes through the fast path in bdrv_rw_co_entry; 3)

[Qemu-devel] [PATCH 8/8] block: change discard to co_discard

2011-10-19 Thread Paolo Bonzini
Since coroutine operation is now mandatory, convert both bdrv_discard implementations to coroutines. For qcow2, this means taking the lock around the operation. raw-posix remains synchronous. The bdrv_discard callback is then unused and can be eliminated. Signed-off-by: Paolo Bonzini --- bloc

[Qemu-devel] [PATCH 1/8] vpc: detect floppy disk geometries

2011-10-19 Thread Paolo Bonzini
Converting a floppy image from RAW to VPC and back will generate a zero-padded file of the wrong size, because the geometry is not computed correctly. Special case floppy disk images, handling standard MS-DOS capacities (160/180/320/360 for low density 5.25" disks, 1200 for high density 5.25" disk

[Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

2011-10-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |2 ++ configure | 21 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index 417f23e..c518103 100644 --- a/Makefile.target +++ b/Makefile.target @@ -208,6 +208,8 @

[Qemu-devel] [PATCH 2/8] vmdk: fix return values of vmdk_parent_open

2011-10-19 Thread Paolo Bonzini
While vmdk_open_desc_file (touched by the patch) correctly changed -1 to -EINVAL, vmdk_open did not. Fix it directly in vmdk_parent_open. Signed-off-by: Paolo Bonzini --- block/vmdk.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c

[Qemu-devel] [PATCH 1/1 V6] qemu: fix improper nmi emulation

2011-10-19 Thread Lai Jiangshan
On 10/19/2011 06:57 PM, Jan Kiszka wrote: >>> >>> Looks OK to me. >>> >>> Please don't forget to bake a qemu-only patch for those bits that apply >>> to upstream as well (ie. the user space APIC path). >>> >>> Jan >>> >> >> I did forget it. >> Did you mean we need to add "#ifdef KVM_CAP_IRQCHIP" b

[Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/vmdk.c | 37 +++-- 1 files changed, 15 insertions(+), 22 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 21566eb..12b38d2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -622,20 +622,7 @@ static int vmdk_open_de

[Qemu-devel] [PATCH 6/8] block: take lock around bdrv_write implementations

2011-10-19 Thread Paolo Bonzini
This does the first part of the conversion to coroutines, by wrapping bdrv_write implementations to take the write side of the rwlock. Drivers that implement bdrv_write rather than bdrv_co_writev can then benefit from asynchronous operation (at least if the underlying protocol supports it, which i

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Lai Jiangshan
On 10/19/2011 05:29 PM, Avi Kivity wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/18/2011 09:41 PM, Jan Kiszka wrote: >> >> Looks OK to me. >> >> > > Same here. Who will merge it? Thanks, Lai > > - -- > I have a truly marvellous patch that fixes the bug which this > si

Re: [Qemu-devel] [PATCH] [v2] arm gic saving/loading fix

2011-10-19 Thread Andreas Färber
Dmitry, It would be nice to cc the people that have cared to review previous versions of the patch, Peter Maydell and me. Gets you quicker replies. Functional ARM patches are being reviewed by our ARM gurus and not by Stefan Hajnoczi, so please drop qemu-trivial from the cc list, as pointed out b

Re: [Qemu-devel] [PATCH 1/2] hw/nand: reject read-only drives

2011-10-19 Thread Markus Armbruster
juha.riihim...@nokia.com writes: > From: Juha Riihimäki > > Signed-off-by: Juha Riihimäki > --- > hw/nand.c | 23 +++ > 1 files changed, 15 insertions(+), 8 deletions(-) > > diff --git a/hw/nand.c b/hw/nand.c > index c27783e..da6529d 100644 > --- a/hw/nand.c > +++ b/hw/nan

[Qemu-devel] [PATCH 1/2] qemu: Add opt_set_bool functionality

2011-10-19 Thread M. Mohan Kumar
From: "M. Mohan Kumar" Signed-off-by: M. Mohan Kumar --- Changes from previous version: * Changed qemu_opt_{get|set}_bool to use 'bool' data type qemu-option.c | 43 +++ qemu-option.h |3 ++- 2 files changed, 41 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH 2/2] hw/9pfs: Read-only support for 9p export

2011-10-19 Thread M. Mohan Kumar
From: "M. Mohan Kumar" A new fsdev parameter "readonly" is introduced to control accessing 9p export. readonly=on|off can be used to specify the access type. By default rw access is given to 9p export. Signed-off-by: M. Mohan Kumar --- Changes from previous version V4: * Updated on top of curr

Re: [Qemu-devel] [PATCH 00/26] AREG0 conversion

2011-10-19 Thread Richard Henderson
On 10/09/2011 12:20 PM, Blue Swirl wrote: >> I didn't bother to attach the patches, if someone wants to try, the >> patch set can be found here: >>git://repo.or.cz/qemu/blueswirl.git >>http://repo.or.cz/r/qemu/blueswirl.git > > I pushed the patch set to repo.or.cz so if someone wan

Re: [Qemu-devel] [PATCH] [v2] arm gic saving/loading fix

2011-10-19 Thread Peter Maydell
On 19 October 2011 15:10, Dmitry Koshelev wrote: > irq_target field saving/loading is in the wrong loop > version bump > > Signed-off-by: Dmitry Koshelev > --- >  hw/arm_gic.c |   16 >  1 files changed, 8 insertions(+), 8 deletions(-) > > @@ -744,5 +744,5 @@ static void gic_init(

[Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppcheck)

2011-10-19 Thread Stefan Weil
assert("...") will never do anything. This assertion handles a case which should never occur, so it must be assert(!"..."). Cc: Alon Levy Signed-off-by: Stefan Weil --- libcacard/card_7816.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libcacard/card_7816.c b/libcac

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-10-19 Thread Steve
This bug also pertains to armv7l. I have a Debian chroot install on my Android phone, and was trying to do an i386 chroot within my chroot (want to run the i386 specific binaries included in the Android SDK). I installed the qemu-user-static package (tried both v 0.14.1 and 0.15.0). When puttin

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-19 Thread Bob Breuer
Kai Tietz wrote: > 2011/10/18 Bob Breuer : >> Kai Tietz wrote: >>> 2011/10/17 Bob Breuer : Richard Henderson wrote: > On 10/17/2011 07:09 AM, Bob Breuer wrote: >> Google finds a mention of longjmp failing with -fomit-frame-pointer: >> http://lua-users.org/lists/lua-l/2005-02/msg001

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-10-19 Thread Peter Maydell
Steve: there are a number of issues with that patch: * x86 cpu_set_tls() doesn't belong in linux-user/syscall.c (but it's not trivial to put it in target-i386 because it's calling do_set_thread_area()) * it's not "obviously correct" and the author says it needs review, and I'd have to dig out i

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-19 Thread Richard Henderson
On 10/19/2011 02:05 PM, Bob Breuer wrote: > Is it possible to force a > stackframe by just adding a suitable attribute to either the setjmp > function prototype, or the function which calls setjmp? The only thing I can think of that'll be portable to a large number of versions of GCC is { i

Re: [Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppcheck)

2011-10-19 Thread Alon Levy
On Wed, Oct 19, 2011 at 09:03:22PM +0200, Stefan Weil wrote: > assert("...") will never do anything. This assertion handles a case > which should never occur, so it must be assert(!"..."). > Thanks, I'll pick it up for a pull request. > Cc: Alon Levy > Signed-off-by: Stefan Weil > --- > libca

  1   2   >