Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Avi Kivity
On 10/04/2011 07:24 PM, Jan Kiszka wrote: >> >> Given that, when in conflict, we rather model after AMD than Intel for >> TCG, I would hesitate to expose this by default. Or are there >> precedences already? > > Practically all MSRs. i486 doesn't have any, IIRC, for example. Pre-Pentiums do

Re: [Qemu-devel] [PATCH RFC V1 02/11] qemu-timer: Introduce qemu_run_one_timer

2011-10-04 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Jan Kiszka wrote: > On 2011-10-04 16:51, Anthony PERARD wrote: > > Used by the Xen PCI Passthrough code to run the timer about the power > > state transition. > > > > Signed-off-by: Anthony PERARD > > --- > > qemu-timer.c | 15 +++ > > qemu-timer.h |3 +++ >

Re: [Qemu-devel] [PATCH 1/1] kvm: support TSC deadline MSR

2011-10-04 Thread Avi Kivity
On 10/03/2011 10:55 PM, Marcelo Tosatti wrote: From: "Liu, Jinsong" KVM add emulation of lapic tsc deadline timer for guest. This patch is co-operation work at qemu side. -#define CPU_SAVE_VERSION 12 +#define CPU_SAVE_VERSION 13 Unfortunate. Can't we use subsections? -- error compiling co

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-04 Thread Anthony Liguori
On 09/23/2011 07:50 AM, Juan Quintela wrote: make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela qemu_file_has_error() implies a boolean response. Wouldn't qemu_file_get_error() make more sense if you're going to rely on the return value? Regards, Antho

Re: [Qemu-devel] [Xen-devel] [PATCH RFC V1 00/11] Xen PCI Passthrough

2011-10-04 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Avi Kivity wrote: > On 10/04/2011 05:01 PM, Anthony Liguori wrote: > >> We also have pci passthrough in qemu-kvm (I think based on the same > >> Neocleus > >> code). Rather than having two pci assignment implementations, I think > >> we should > >> have just one, with the diff

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Avi Kivity
On 10/04/2011 04:38 PM, Juan Quintela wrote: Hi This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look at the idstr and see that it starts with the

Re: [Qemu-devel] [PATCH RFC V1 02/11] qemu-timer: Introduce qemu_run_one_timer

2011-10-04 Thread Anthony Liguori
On 10/04/2011 12:27 PM, Jan Kiszka wrote: On 2011-10-04 16:51, Anthony PERARD wrote: Used by the Xen PCI Passthrough code to run the timer about the power state transition. Signed-off-by: Anthony PERARD --- qemu-timer.c | 15 +++ qemu-timer.h |3 +++ 2 files changed, 18 in

Re: [Qemu-devel] [PATCH RFC V1 01/11] Introduce HostPCIDevice to access a pci device on the host.

2011-10-04 Thread Jan Kiszka
This wasn't run through checkpatch.pl, I bet. On 2011-10-04 16:51, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > hw/host-pci-device.c | 192 > ++ > hw/host-pci-device.h | 36 + > 2 files changed, 228 insertions(+), 0 del

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Anthony Liguori
On 10/04/2011 01:20 PM, Avi Kivity wrote: On 10/04/2011 04:38 PM, Juan Quintela wrote: Hi This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look a

Re: [Qemu-devel] [Xen-devel] [PATCH RFC V1 00/11] Xen PCI Passthrough

2011-10-04 Thread Avi Kivity
On 10/04/2011 08:19 PM, Stefano Stabellini wrote: On Tue, 4 Oct 2011, Avi Kivity wrote: > On 10/04/2011 05:01 PM, Anthony Liguori wrote: > >> We also have pci passthrough in qemu-kvm (I think based on the same > >> Neocleus > >> code). Rather than having two pci assignment implementations,

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Avi Kivity
On 10/04/2011 08:22 PM, Anthony Liguori wrote: The original intent with subsections was to register them as a new vmstate section, with just a name relationship. Can we rename .subsections to .old_and_semi_broken_subsections, and introduce a new .subsections field that works properly in all c

Re: [Qemu-devel] [PATCHv3] s390: Fix cpu shutdown for KVM

2011-10-04 Thread Christian Borntraeger
> Hrm. Are you sure that this doesn't break anything? The rest looks good. Works on my kvm box. Unfortunately the non-kvm mode doesnt work (with and without the patch) so I cant test that one. Christian

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Juan Quintela
Avi Kivity wrote: > On 10/04/2011 04:38 PM, Juan Quintela wrote: >> Hi >> >> This series move the subsections detection code form: >> - Look that it starts form 5 >> To: >> - Look that it starts form 5 (SUBSECTION) >> - Look at the length >> - Look that length is bigger than section name >> - Look

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:50 AM, Juan Quintela wrote: >> make functions propaget errno, instead of just using -EIO. >> >> Signed-off-by: Juan Quintela > > qemu_file_has_error() implies a boolean response. Wouldn't > qemu_file_get_error() make more sense if you're going to rely on

Re: [Qemu-devel] [PATCH RFC V1 01/11] Introduce HostPCIDevice to access a pci device on the host.

2011-10-04 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > hw/host-pci-device.c | 192 > ++ > hw/host-pci-device.h | 36 + > 2 files changed, 228 insertions(+), 0 deletions(-) > create mode 100644 hw/host-pci-devi

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Avi Kivity
On 10/04/2011 08:35 PM, Juan Quintela wrote: Avi Kivity wrote: > On 10/04/2011 04:38 PM, Juan Quintela wrote: >> Hi >> >> This series move the subsections detection code form: >> - Look that it starts form 5 >> To: >> - Look that it starts form 5 (SUBSECTION) >> - Look at the length >> -

Re: [Qemu-devel] Guest freezes "Refined TSC clocksource calibration ..."

2011-10-04 Thread Mulyadi Santosa
Hi Onkar :) On Tue, Oct 4, 2011 at 18:02, Onkar N Mahajan wrote: > On 10/02/2011 12:54 PM, Mulyadi Santosa wrote: >> >> Hi. :) >> > Hey Mulyadi , you seem to be where I go (or may be other way round) :-) ; > How > r u buddy ?? Yeah, it's like we always at the same boat :) But it's great, isn

[Qemu-devel] [PATCH 7/5] Move parsing of filedescriptor into common function

2011-10-04 Thread Stefan Berger
Move the parsing of a filedescriptor into a common function qemu_parse_fd(). Have the code in net.c call this function. Signed-off-by: Stefan Berger --- cutils.c | 12 net.c |7 +-- qemu-common.h |1 + 3 files changed, 14 insertions(+), 6 deletions(-) I

[Qemu-devel] [PATCH 6/5] Introduce --enable-tpm-passthrough configure option

2011-10-04 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) Index: qemu-git.pt/configure === --- qemu-git.pt.orig/config

[Qemu-devel] [PATCH 8/5] Add fd parameter for TPM passthrough driver

2011-10-04 Thread Stefan Berger
Enable the passing of a file descriptor via fd=<..> to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Berger --- hw/tpm_passthrough.c | 74 +-- qemu-config.c|5 +++ 2 files changed, 53 inserti

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

2011-10-04 Thread Serge Hallyn
Hi, is this still an issue under natty or oneiric? ** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/241119 Title: usb_add of a

[Qemu-devel] [Bug 546458] Re: kernel NULL pointer in -virtual (-server) kernel

2011-10-04 Thread Serge Hallyn
Per comment #7, marking this invalid for qemu-kvm. ** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/546458 Title: kernel NULL poin

Re: [Qemu-devel] [PATCH 05/11] migration: add error handling to migrate_fd_put_notify().

2011-10-04 Thread Juan Quintela
(Adding new Yoshiaki email address) Paolo Bonzini wrote: > On 09/23/2011 02:50 PM, Juan Quintela wrote: >> From: Yoshiaki Tamura >> >> Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, >> since migrate_fd_put_notify() isn't checking error of underlying >> QEMUFile, those resour

Re: [Qemu-devel] [PATCH 1/1] kvm: support TSC deadline MSR

2011-10-04 Thread Marcelo Tosatti
On Tue, Oct 04, 2011 at 07:53:42PM +0200, Avi Kivity wrote: > On 10/03/2011 10:55 PM, Marcelo Tosatti wrote: > >From: "Liu, Jinsong" > > > >KVM add emulation of lapic tsc deadline timer for guest. > >This patch is co-operation work at qemu side. > > > >-#define CPU_SAVE_VERSION 12 > >+#define CPU_S

[Qemu-devel] Qemu/KVM guest boots 2x slower with vhost_net

2011-10-04 Thread Reeted
Hello all, for people in qemu-devel list, you might want to have a look at the previous thread about this topic, at http://www.spinics.net/lists/kvm/msg61537.html but I will try to recap here. I found that virtual machines in my host booted 2x slower (on average it's 2x slower, but probably so

Re: [Qemu-devel] [PATCH 21/23] migration: Don't use callback on file defining it

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:57 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > I don't think this is better. It just eliminates the possibility of > having useful trace points in get_error. It's use is not consistent at all (same places use get_error() and the others t

Re: [Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-04 Thread Marc-André Lureau
Hi On Tue, Oct 4, 2011 at 7:21 PM, Juan Quintela wrote: > "Marc-André Lureau" wrote: >> Windows 7 may use the same stream number for input and output. >> Current code will confuse streams. >> >> NB: I wonder if this patch breaks migration code because of >> this change: >> -        VMSTATE_BOOL_

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-04 Thread Stefan Berger
On 10/03/2011 09:43 AM, Anthony Liguori wrote: On 10/03/2011 08:24 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote: Here are some suggestions: - Let's make the protocol be BER directly. As a first step, use a single octet string for the whole

<    1   2