Re: [Qemu-devel] Qemu varying performance

2011-09-28 Thread Andreas Färber
Am 28.09.2011 02:25, schrieb Torbjorn Granlund: > Another issue I ran into what the sh4 qemu performance. It is much > worse than other qemu ports (except perhaps ppc64). What is the reason > behind that? (The idle thing works well for sh4, though.) > > My host system runs FreeBSD 8.2. The Debi

Re: [Qemu-devel] [PATCH 7/7] Enable fork and MIPS64 specific changes in mq_open syscall

2011-09-28 Thread Andreas Färber
Am 28.09.2011 06:38, schrieb kha...@kics.edu.pk: > From: Khansa Butt > Please prefix the subject with "linux-user: ". Where's the preceding 6 patches? Patch description is missing. > Signed-off-by: Khansa Butt > --- > configure|1 + > linux-user/syscall.c | 11 +-- > 2

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-28 Thread Alexander Graf
Am 27.09.2011 um 21:05 schrieb Blue Swirl : > On Tue, Sep 27, 2011 at 5:23 PM, Alexander Graf wrote: >> >> On 27.09.2011, at 19:20, Blue Swirl wrote: >> >>> On Tue, Sep 27, 2011 at 5:03 PM, Alexander Graf wrote: On 27.09.2011, at 18:53, Blue Swirl wrote: > On Tue, Sep 27,

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-28 Thread Jan Kiszka
On 2011-09-28 08:27, Paolo Bonzini wrote: > On 09/27/2011 11:23 PM, Anthony Liguori wrote: >> On 09/27/2011 11:39 AM, Paolo Bonzini wrote: >>> On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attac

Re: [Qemu-devel] [PATCH] linux-user: fix memory leak in failure path

2011-09-28 Thread Peter Maydell
On 28 September 2011 07:57, wrote: > From: Alex Jia > > Haven't released memory of 'array' and 'host_mb' in failure paths. > > Signed-off-by: Alex Jia > --- >  linux-user/syscall.c |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-us

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-28 Thread Paolo Bonzini
On 09/28/2011 09:52 AM, Jan Kiszka wrote: > You can probably assume that qemu_notify_event (and dually the read in > the main loop) are resp. write/read memory barriers. Or even full. > > If we switch entirely to GSources, it would be nice to use them. But > since we aren't, and our main lo

Re: [Qemu-devel] Qemu varying performance

2011-09-28 Thread Torbjorn Granlund
Andreas Färber writes: Am 28.09.2011 02:25, schrieb Torbjorn Granlund: > Another issue I ran into what the sh4 qemu performance. It is much > worse than other qemu ports (except perhaps ppc64). What is the reason > behind that? (The idle thing works well for sh4, though.) > > My ho

[Qemu-devel] [PATCH v2] linux-user: fix memory leak in failure path

2011-09-28 Thread ajia
From: Alex Jia Haven't released memory of 'host_mb' in failure path, and calling malloc allocate memory to 'host_array', however, memory hasn't been freed before the function target_to_host_semarray returns. Signed-off-by: Alex Jia --- linux-user/syscall.c |3 ++- 1 files changed, 2 inser

Re: [Qemu-devel] [PATCH] linux-user: fix memory leak in failure path

2011-09-28 Thread Alex Jia
On 09/28/2011 03:55 PM, Peter Maydell wrote: On 28 September 2011 07:57, wrote: From: Alex Jia Haven't released memory of 'array' and 'host_mb' in failure paths. Signed-off-by: Alex Jia --- linux-user/syscall.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/l

Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions

2011-09-28 Thread Andreas Färber
Am 27.09.2011 06:17, schrieb kha...@kics.edu.pk: > From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt > > > > Signed-off-by: Khansa Butt ...nor all of mine from previous rounds. Including From vs. Signed-off-by mixup (From is who sent the patch, not whom the code originated from), Codi

Re: [Qemu-devel] [PATCH] Move filedescriptor parsing code from net.c into qemu_parse_fd()

2011-09-28 Thread Stefan Hajnoczi
On Tue, Sep 27, 2011 at 5:02 PM, Stefan Berger wrote: > Move the parsing of a filedescriptor into a common function qemu_parse_fd(). > Have the code in net.c call this function. > > Signed-off-by: Stefan Berger > > --- >  net.c       |    8 ++-- >  qemu-char.c |   12 >  qemu-char

Re: [Qemu-devel] Using iPXE with older qemu releases?

2011-09-28 Thread Stefan Hajnoczi
On Tue, Sep 27, 2011 at 6:50 PM, Kenton Cabiness wrote: > Stefan, > > On 9/27/2011 2:23 AM, Stefan Hajnoczi wrote: >> >> On Mon, Sep 26, 2011 at 02:22:21PM -0500, Kenton Cabiness wrote: >>> >>> Is there a way to point an older qemu release (currently running >>> qemu-kvm-0.12.1.2-2.16) to iPXE pro

Re: [Qemu-devel] [RFC] potential risk for macro QTAILQ_INSERT_BEFORE

2011-09-28 Thread Jan Kiszka
On 2011-09-28 05:38, Wayne Xia wrote: > Hi, during my coding, I found macro a bit different from other > QTAIL macros. > > QTAILQ_INSERT_AFTER was defined as: > --- > #define QTAILQ_INSERT_AFTER(head, listelm, elm, field) do {

Re: [Qemu-devel] virtqueue corruption in emulation mode?

2011-09-28 Thread Stefan Hajnoczi
On Wed, Sep 28, 2011 at 3:01 AM, Sinha, Ani wrote: > > On Sep 27, 2011, at 12:17 AM, Stefan Hajnoczi wrote: > >> On Mon, Sep 26, 2011 at 07:16:56PM -0500, Sinha, Ani wrote: >>> I am using the virtqueue (virtqueue_pop, virtqueue_push etc) in the >>> emulated mode (non-kvm mode) from an IO thread (

Re: [Qemu-devel] [PATCH] remove mpc8544ds.dtb

2011-09-28 Thread Alexander Graf
On 27.09.2011, at 23:58, Scott Wood wrote: > On 09/24/2011 02:32 AM, Alexander Graf wrote: >> >> On 16.09.2011, at 21:05, Stuart Yoder wrote: >> >>> From: Stuart Yoder >>> >>> make install now compiles dtb >> >> It doesn't when you don't have dtb installed, breaking the e500 >> target for bu

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-28 Thread Alexander Graf
On 28.09.2011, at 04:40, Alex Williamson wrote: > On Tue, 2011-09-27 at 16:28 -0500, Scott Wood wrote: >> On 09/26/2011 07:45 PM, Alex Williamson wrote: >>> On Mon, 2011-09-26 at 18:59 -0500, Scott Wood wrote: On 09/26/2011 01:34 PM, Alex Williamson wrote: > /* Reset the device */ >

[Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor

2011-09-28 Thread Wayne Xia
During my test, I found it inconvenient when I type "help" or "help info", because the information was shown without orderliness. This patch would just show the help information in sorted order. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the comman

[Qemu-devel] [PATCH 1/1] Sort the help info shown in monitor

2011-09-28 Thread Wayne Xia
Introduced two queues to save sorted command list in it, and dump commands from them. As a result, command help and help info would show a more friendly sorted command list. Signed-off-by: Wayne Xia --- monitor.c | 97 ++-- 1 files change

Re: [Qemu-devel] [PATCH 3/3] virtio-serial-bus: Add per-port stats for received, sent, discarded bytes

2011-09-28 Thread Amit Shah
On (Wed) 14 Sep 2011 [15:07:57], Markus Armbruster wrote: > Amit Shah writes: > > > This commit adds port-specific stats for the number of bytes received, > > sent and discarded. They can be seen in the 'info qtree' monitor output > > for the specific port. > > > > This data can be used to check

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-28 Thread Stefan Hajnoczi
On Tue, Sep 27, 2011 at 10:23 PM, Anthony Liguori wrote: > On 09/27/2011 11:39 AM, Paolo Bonzini wrote: >> >> On 09/27/2011 06:05 PM, Anthony Liguori wrote: >>> >>> Actually, for posix-aio, we can just switch to using g_idle_add(). >>> g_idle_add() uses g_source_attach which is thread safe. g_idle

[Qemu-devel] [Bug 861141] Re: Installing libvirt-bin qemu slows host network

2011-09-28 Thread shu ming
Do you mean the send-receive result is different than receive-send? What about the result of bi-direction test? It looks like that the total bytes transferred are also different. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor

2011-09-28 Thread Stefan Hajnoczi
On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xia wrote: > During my test, I found it inconvenient when I type "help" or "help info", > because the information was shown without orderliness. This patch would just > show the help information in sorted order. > > For eg: > (qemu)help > acl_add > acl_polic

[Qemu-devel] [PATCH] mips_fulong2e: Reorder ISA bus and i8259 creation

2011-09-28 Thread Jan Kiszka
Missed during memory region conversion: The i8259 now depends on the ISA bus being created first. Reorder the initialization. Signed-off-by: Jan Kiszka --- I had a reordering patch in my i8259-qdev queue as well, and these bits were left over after rebasing over current master. hw/mips_fulong2

Re: [Qemu-devel] Qemu varying performance

2011-09-28 Thread Edgar E. Iglesias
On Wed, Sep 28, 2011 at 02:25:43AM +0200, Torbjorn Granlund wrote: > Running Debian's vmlinux-2.6.32-5-4kc-malta under qemu-system-mips works > very well--the system is fast, and when it is idle the qemu-system-mips > process on the host system consumes insignificant CPU. (The same is > true for q

Re: [Qemu-devel] [PATCH v2] linux-user: fix memory leak in failure path

2011-09-28 Thread Peter Maydell
On 28 September 2011 09:24, wrote: > From: Alex Jia > > Haven't released memory of 'host_mb' in failure path, and calling malloc > allocate > memory to 'host_array', however, memory hasn't been freed before the function > target_to_host_semarray returns. > > Signed-off-by: Alex Jia > --- >  li

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

2011-09-28 Thread hkran
On 09/27/2011 04:43 AM, Luiz Capitulino wrote: This series adds support to the block layer to keep track of devices' I/O status. That information is also made available in QMP and HMP. The goal here is to allow management applications that miss the BLOCK_IO_ERROR event to able to query the VM to

Re: [Qemu-devel] [PATCH V2] Add stdio char device on windows

2011-09-28 Thread Mars.cao
On 09/27/2011 11:42 PM, Fabien Chouteau wrote: Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau --- qemu-char.c | 199 ++- 1 files changed, 197 insertions(+), 2 deletions(-) diff --git a/qemu-cha

Re: [Qemu-devel] qemu-img: subformat=streamOptimized issue

2011-09-28 Thread Stefan Hajnoczi
On Wed, Sep 28, 2011 at 12:57 AM, Fam Zheng wrote: > This could be a bug. I've briefly checked. It's not limited to > ISO->streamOptimized, but also reproduced trying to convert from VDI. > It fails because consequential writes fall into the same cluster of > target VMDK. The leading write allocat

Re: [Qemu-devel] [PATCH v2] linux-user: fix memory leak in failure path

2011-09-28 Thread Alex Jia
On 09/28/2011 05:43 PM, Peter Maydell wrote: On 28 September 2011 09:24, wrote: From: Alex Jia Haven't released memory of 'host_mb' in failure path, and calling malloc allocate memory to 'host_array', however, memory hasn't been freed before the function target_to_host_semarray returns. Sign

[Qemu-devel] [PATCH v2] Move filedescriptor parsing code from net.c into qemu_parse_fd()

2011-09-28 Thread Stefan Berger
Move the parsing of a filedescriptor into a common function qemu_parse_fd() so others can use it as well. Have net.c call this function. v2: - moving qemu_parse_fd into cutils.c Signed-off-by: Stefan Berger --- cutils.c | 12 net.c |7 +-- qemu-common.h |

Re: [Qemu-devel] [PATCH v2] linux-user: fix memory leak in failure path

2011-09-28 Thread Peter Maydell
On 28 September 2011 11:37, Alex Jia wrote: > On 09/28/2011 05:43 PM, Peter Maydell wrote: >> >> On 28 September 2011 09:24,  wrote: >>> >>> From: Alex Jia >>> >>> Haven't released memory of 'host_mb' in failure path, and calling malloc >>> allocate >>> memory to 'host_array', however, memory hasn

[Qemu-devel] [PATCH 06/22] i8259: Drop obsolete prototypes

2011-09-28 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/pc.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index 60da282..fd5f9b2 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -62,8 +62,6 @@ bool parallel_mm_init(target_phys_addr_t base, int it_shift, qemu_irq irq, typedef stru

[Qemu-devel] [PATCH 22/22] i8259: Move to hw library

2011-09-28 Thread Jan Kiszka
No target-specific bits remaining, let's move it over. Signed-off-by: Jan Kiszka --- Makefile.objs |2 +- Makefile.target |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 1c65087..e56c18a 100644 --- a/Makefile.objs +++ b/Ma

[Qemu-devel] [PATCH 00/22] Rework i8259 and PC interrupt models

2011-09-28 Thread Jan Kiszka
Highlights of this series: - generic i8259, now part of hwlib - qdev conversion of i8259 - fix for i8259 poll mode (and removal of PREP hack) The refactoring will also be important to instantiate i8259-kvm devices for in-kernel irqchip acceleration one day. Note: depends on "mips_fulong2e: Reo

[Qemu-devel] [PATCH 04/22] pc: Fix and clean up PIC-to-APIC IRQ path

2011-09-28 Thread Jan Kiszka
The master PIC is connected to the LINTIN0 of the APICs. As the APIC currently does not track the state of that line, we have to ask the PIC to reinject its IRQ after the CPU picked up an event from the APIC. This introduces pic_get_output to read the master PIC IRQ line state without changing it.

[Qemu-devel] [PATCH 05/22] i8259: Remove premature inline function attributes

2011-09-28 Thread Jan Kiszka
The compiler is smarter in choosing the right optimization. Signed-off-by: Jan Kiszka --- hw/i8259.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index 6006123..f1d58ba 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -80,7 +80,7 @@ static uint

[Qemu-devel] [PATCH 1/2] slirp: Fix use after release on tcp_input

2011-09-28 Thread Jan Kiszka
ti points into the m buffer. But the latter may already be released right after the dodata: label. Move the test before the potential release. Signed-off-by: Jan Kiszka --- slirp/tcp_input.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/slirp/tcp

[Qemu-devel] [PATCH 2/2] slirp: Fix packet expiration

2011-09-28 Thread Jan Kiszka
From: Thomas Huth The two new variables "arp_requested" and "expiration_date" in the mbuf structure have been added after the variable-sized "m_dat_" array. The variables have to be added before the m_dat_ array instead. Without this patch, the expiration_date gets clobbered by code that accesses

[Qemu-devel] [PATCH 0/2] [PULL] slirp: Small fixes

2011-09-28 Thread Jan Kiszka
The following changes since commit 46f3069cba94aab44b3b4f87bc270759b4a700fa: PPC: use memory API to construct the PCI hole (2011-09-27 19:16:46 +) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp CC: Fabien Chouteau CC: Thomas Huth Jan Kiszka (1): s

Re: [Qemu-devel] [PATCH 15/22] i8259: PREP: Replace pic_intack_read with pic_read_irq

2011-09-28 Thread Alexander Graf
On 28.09.2011, at 13:01, Jan Kiszka wrote: > There is nothing in the i8259 spec that justifies the special > pic_intack_read. At least the Linux PREP kernels configure the PICs > properly so that pic_read_irq returns identical values, and setting > read_reg_select in PIC0 cannot be derived from a

[Qemu-devel] [PATCH 08/22] i8239: Introduce per-PIC output interrupt

2011-09-28 Thread Jan Kiszka
As a first step towards more generic master-slave support, remove parent_irq in favor of a per-PIC output interrupt line. The slave's line is attached to IRQ2 of the master, but it remains unused for now. Signed-off-by: Jan Kiszka --- hw/i8259.c | 21 - 1 files changed, 12

[Qemu-devel] [PATCH 10/22] i8259: Reorder intack in pic_read_irq

2011-09-28 Thread Jan Kiszka
As we want to move the IRQ update to pic_intack, ordering matters: the slave ack must be executed before the master ack to avoid missing further pending slave IRQs. Signed-off-by: Jan Kiszka --- hw/i8259.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/i8259

[Qemu-devel] [PATCH 02/22] pc: Generalize ISA IRQs to GSIs

2011-09-28 Thread Jan Kiszka
The ISA bus IRQ range is 0..15. What isa_irq_handler and IsaIrqState are actually dealing with are the Global System Interrupts. Refactor the code to clarify this. Signed-off-by: Jan Kiszka --- hw/ioapic.h |7 +++ hw/isa.h |2 ++ hw/pc.c | 18 +- hw/pc.h

[Qemu-devel] [PATCH 17/22] i8259: Eliminate PicState2

2011-09-28 Thread Jan Kiszka
Introduce a reference to the slave PIC for the few cases we need to access it without a proper pointer at hand and drop PicState2. We could even live without slave_pic if we had a better way of modeling the cascade bus the PICs are attached to (in addition to the ISA bus). Signed-off-by: Jan Kiszk

[Qemu-devel] [PATCH 14/22] i8259: Clean up pic_ioport_read

2011-09-28 Thread Jan Kiszka
Drop redundant local address variable. Signed-off-by: Jan Kiszka --- hw/i8259.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index 849c82e..9e32ceb 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -380,11 +380,10 @@ static uint32_t pic_poll_read(P

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2011-09-28 Thread Harsh Bora
On 09/22/2011 11:12 PM, Daniel P. Berrange wrote: I've noticed that if you use a virtio 9p filesystem with a mount_tag property value that is longer than 32 bytes, it gets silently truncated. In virtio-9p-device.c len = strlen(conf->tag); if (len> MAX_TAG_LEN) { len = MAX_TA

[Qemu-devel] [PATCH 12/22] i8259: Switch to per-PIC IRQ update

2011-09-28 Thread Jan Kiszka
This converts pic_update_irq to work against a single PIC instead of the complete cascade. Along this change, the required update after pic_set_irq1 is now moved into that function. Signed-off-by: Jan Kiszka --- hw/i8259.c | 59 --- 1 fil

[Qemu-devel] [PATCH 07/22] i8259: Move pic_set_irq1 after pic_update_irq

2011-09-28 Thread Jan Kiszka
We are about to call the latter from the former. No functional changes. Signed-off-by: Jan Kiszka --- hw/i8259.c | 55 +-- 1 files changed, 29 insertions(+), 26 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index f1d58ba..de2d5ca 100644

[Qemu-devel] [PATCH 01/22] pc: Drop useless test from isa_irq_handler

2011-09-28 Thread Jan Kiszka
IsaIrqState::ioapic is always non-NULL. Probably, the concrete qemu_irq was supposed to be tested, but that's already done by qemu_set_irq. Signed-off-by: Jan Kiszka --- hw/pc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 203627d..a15d165

[Qemu-devel] [PATCH 15/22] i8259: PREP: Replace pic_intack_read with pic_read_irq

2011-09-28 Thread Jan Kiszka
There is nothing in the i8259 spec that justifies the special pic_intack_read. At least the Linux PREP kernels configure the PICs properly so that pic_read_irq returns identical values, and setting read_reg_select in PIC0 cannot be derived from any special i8259 mode. So switch ppc_prep to pic_rea

[Qemu-devel] [PATCH 09/22] i8259: Do not update IRQ output after spurious pic_poll_read

2011-09-28 Thread Jan Kiszka
If pic_poll_read finds no pending IRQ and return a spurious one instead, no PIC state is changed, thus we do not need to call pic_update_irq. Signed-off-by: Jan Kiszka --- hw/i8259.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index 65123bd..c

[Qemu-devel] [PATCH 20/22] i8259: Fix coding style

2011-09-28 Thread Jan Kiszka
No functional changes. Signed-off-by: Jan Kiszka --- hw/i8259.c | 54 ++ 1 files changed, 34 insertions(+), 20 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index ae6f784..04ef0ca 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -67,7 +67,7 @

[Qemu-devel] [PATCH 16/22] i8259: Replace PicState::pics_state with master flag

2011-09-28 Thread Jan Kiszka
This reflects how real PICs indentify their role (in non-buffered mode): Pass the state of the /SP input on pic_init and use it instead of pics_state to differentiate between master and slave mode. Signed-off-by: Jan Kiszka --- hw/i8259.c | 18 +- 1 files changed, 9 insertions(

[Qemu-devel] [PATCH 03/22] pc: Convert GSIState::i8259_irq into array

2011-09-28 Thread Jan Kiszka
Will be required when we no longer let i8259_init allocate the PIC IRQs but convert that chips to qdev. Signed-off-by: Jan Kiszka --- hw/pc.h |2 +- hw/pc_piix.c |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index 4333898..2870be4 100644 -

[Qemu-devel] [PATCH 18/22] qdev: Add HEX8 property

2011-09-28 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/qdev-properties.c | 29 + hw/qdev.h|3 +++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index e0e54aa..f0b811c 100644 --- a/hw/qdev-properties.c +++ b/hw/q

[Qemu-devel] [PATCH 13/22] i8259: Fix poll command

2011-09-28 Thread Jan Kiszka
This was probably never used so far: According to the spec, polling means ack'ing the pending IRQ and setting its corresponding bit in isr. Moreover, we have to signal a pending IRQ via bit 7 of the returned value, and we must not return a spurious IRQ if none is pending. This implements the poll

[Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset

2011-09-28 Thread Jan Kiszka
As we clearly modify the PIC state on pic_reset, we also have to update the IRQ output. This only happened on init so far. Apply this consistently. Signed-off-by: Jan Kiszka --- hw/i8259.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index b7

[Qemu-devel] [PATCH 19/22] i8259: Convert to qdev

2011-09-28 Thread Jan Kiszka
This key cleanup step requires to move the IRQ debugging bit from i8259_set_irq directly to the per-PIC pic_set_irq, to pass the PIC parameters (I/O base, ELCR address and mask, master/slave mode) as qdev properties, and to interconnect the PICs with their environment via GPIO pins. Signed-off-by:

[Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

2011-09-28 Thread Jan Kiszka
x86 cannot provide an optimized generic deposit implementation. But at least for a few special cases, namely for writing bits 0..7, 8..15, and 0..15, a version using only a single instruction is feasible. Introducing such helpers improves emulating 16-bit x86 code on x86, but also rarer cases where

[Qemu-devel] [PATCH 21/22] monitor: Restrict pic/irq_info to supporting targets

2011-09-28 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/an5206.c | 10 -- hw/arm_pic.c| 11 --- hw/cris_pic_cpu.c |6 -- hw/etraxfs.h|1 + hw/lm32_pic.c |4 ++-- hw/lm32_pic.h |3 +++ hw/microblaze_pic_cpu.c |6 ---

[Qemu-devel] Networking problem

2011-09-28 Thread Giovanni Formisano
Hy all. I have a problem to configure the network i will try to explain may trouble. I have to make a cluster of virtual machine with one Head node and N worknode. I used a kvm and qemu. Now I want that when I start my HeadNode this one have to send the ip of other machine. My Headnode have two ne

[Qemu-devel] [PATCH V11 5/5] Add a TPM Passthrough backend driver implementation

2011-09-28 Thread Stefan Berger
>From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "Qemu Trusted Platform Module (TPM) integration" and adds a new backend driver for it. This patch adds a passthrough backend driver for passing command

[Qemu-devel] [PATCH V11 2/5] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-09-28 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit

[Qemu-devel] [PATCH V11 0/5] Qemu Trusted Platform Module (TPM) integration

2011-09-28 Thread Stefan Berger
The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS emulator serves as a 'frontend' enabling for examp

[Qemu-devel] [PATCH V11 4/5] Build the TPM frontend code

2011-09-28 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger --- Makefile.target |1 + configure | 11 +++ 2 files changed, 12 insertions(+) Index: qemu-git.pt/Makefile.target === --- qe

[Qemu-devel] [PATCH V11 1/5] Support for TPM command line options

2011-09-28 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of available TPM backends (for exa

[Qemu-devel] [PATCH V11 3/5] Add a debug register

2011-09-28 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). v9: - prefixing all function with tpm_tis_ and all constants with TPM_TIS_ v3: - all output

[Qemu-devel] [RFC] Adding new filesystem 'proxy' to 9p

2011-09-28 Thread M. Mohan Kumar
Pass-through security model in QEMU 9p server needs root privilege to do few file operations (like chown, chmod to any mode/uid:gid). There are two issues in pass-through security model 1) TOCTTOU vulnerability: Following symbolic links in the server could provide access to files beyond 9p export

[Qemu-devel] qemu-kvm: Role of flush_icache_range on PPC

2011-09-28 Thread Jan Kiszka
Alex, we have this diff in qemu-kvm: diff --git a/exec.c b/exec.c index c1e045d..f188549 100644 --- a/exec.c +++ b/exec.c @@ -3950,6 +3955,11 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, cpu_physical_memory_set_dirty_flags( a

Re: [Qemu-devel] qemu-kvm: Role of flush_icache_range on PPC

2011-09-28 Thread Alexander Graf
On 28.09.2011, at 16:23, Jan Kiszka wrote: > Alex, > > we have this diff in qemu-kvm: > > diff --git a/exec.c b/exec.c > index c1e045d..f188549 100644 > --- a/exec.c > +++ b/exec.c > @@ -3950,6 +3955,11 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, > uint8_t *buf, >

Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

2011-09-28 Thread Richard Henderson
On 09/28/2011 05:28 AM, Jan Kiszka wrote: > +#if TCG_TARGET_REG_BITS == 64 > +{ INDEX_op_deposit8l_i32, { "r", "0", "r" } }, > +#else > +{ INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } }, > +#endif At minimum, abcd is spelled "q". I don't particularly care for the 3 different opcodes.

Re: [Qemu-devel] virtqueue corruption in emulation mode?

2011-09-28 Thread Sinha, Ani
On Sep 28, 2011, at 1:51 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2011 at 3:01 AM, Sinha, Ani wrote: >> >> On Sep 27, 2011, at 12:17 AM, Stefan Hajnoczi wrote: >> >>> On Mon, Sep 26, 2011 at 07:16:56PM -0500, Sinha, Ani wrote: I am using the virtqueue (virtqueue_pop, virtqueue_push etc)

Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

2011-09-28 Thread Jan Kiszka
On 2011-09-28 16:26, Richard Henderson wrote: On 09/28/2011 05:28 AM, Jan Kiszka wrote: +#if TCG_TARGET_REG_BITS == 64 +{ INDEX_op_deposit8l_i32, { "r", "0", "r" } }, +#else +{ INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } }, +#endif At minimum, abcd is spelled "q". Ah, perfect.

[Qemu-devel] [PATCH 02/21] qerror: add qerror_report_err()

2011-09-28 Thread Luiz Capitulino
From: Anthony Liguori This provides a bridge between Error (new error mechanism) and QError (old error mechanism). Errors can be propagated whereas QError cannot. The minor evilness avoids layering violations. Since QError should go away RSN, it seems like a reasonable hack. Signed-off-by: An

[Qemu-devel] [PATCH 18/21] qapi: Convert quit

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp-commands.hx |2 +- hmp.c|6 ++ hmp.h|1 + monitor.c| 12 qapi-schema.json | 11 +++ qmp-commands.hx

[Qemu-devel] [PATCH 06/21] qapi: dealloc visitor, fix premature free and iteration logic

2011-09-28 Thread Luiz Capitulino
From: Michael Roth Currently we do 3 things wrong: 1) The list iterator, in practice, is used in a manner where the pointer we pass in is the same as the pointer we assign the output to from visit_next_list(). This causes an infinite loop where we keep freeing the same structures. 2) We attempt

[Qemu-devel] How to configure a QEmu NIC in bridge mode?

2011-09-28 Thread Luiz Antonio Falaguasta Barbosa
Hi guys, I know this is not a list of QEmu users, but how it doesn't exist, I'll ask it here. If antbody could help me, I'll be greatful! Please, does anybody know how to configure a QEmu NIC in bridge mode? Thank you in advance! Regards, Luiz

Re: [Qemu-devel] qemu-kvm: Role of flush_icache_range on PPC

2011-09-28 Thread Jan Kiszka
On 2011-09-28 16:45, Jan Kiszka wrote: On 2011-09-28 16:26, Alexander Graf wrote: On 28.09.2011, at 16:23, Jan Kiszka wrote: Alex, we have this diff in qemu-kvm: diff --git a/exec.c b/exec.c index c1e045d..f188549 100644 --- a/exec.c +++ b/exec.c @@ -3950,6 +3955,11 @@ void cpu_physical_mem

Re: [Qemu-devel] qemu-kvm: Role of flush_icache_range on PPC

2011-09-28 Thread Alexander Graf
Am 28.09.2011 um 16:49 schrieb Jan Kiszka : > On 2011-09-28 16:45, Jan Kiszka wrote: >> On 2011-09-28 16:26, Alexander Graf wrote: >>> >>> On 28.09.2011, at 16:23, Jan Kiszka wrote: >>> Alex, we have this diff in qemu-kvm: diff --git a/exec.c b/exec.c index c1e04

[Qemu-devel] [PATCH 12/21] qapi: Convert query-version

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp.c| 13 + hmp.h|1 + monitor.c| 46 +++--- qapi-schema.json | 37

Re: [Qemu-devel] [RFC] Adding new filesystem 'proxy' to 9p

2011-09-28 Thread Daniel P. Berrange
On Wed, Sep 28, 2011 at 07:49:34PM +0530, M. Mohan Kumar wrote: > Pass-through security model in QEMU 9p server needs root privilege to do few > file operations (like chown, chmod to any mode/uid:gid). There are two issues > in pass-through security model > > 1) TOCTTOU vulnerability: Following s

Re: [Qemu-devel] qemu-kvm: Role of flush_icache_range on PPC

2011-09-28 Thread Jan Kiszka
On 2011-09-28 16:26, Alexander Graf wrote: On 28.09.2011, at 16:23, Jan Kiszka wrote: Alex, we have this diff in qemu-kvm: diff --git a/exec.c b/exec.c index c1e045d..f188549 100644 --- a/exec.c +++ b/exec.c @@ -3950,6 +3955,11 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2011-09-28 Thread Daniel P. Berrange
On Wed, Sep 28, 2011 at 05:22:06PM +0530, Harsh Bora wrote: > On 09/22/2011 11:12 PM, Daniel P. Berrange wrote: > >I've noticed that if you use a virtio 9p filesystem with a mount_tag > >property value that is longer than 32 bytes, it gets silently truncated. > > > >In virtio-9p-device.c > > > >

Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

2011-09-28 Thread Richard Henderson
On 09/28/2011 07:33 AM, Jan Kiszka wrote: >> I don't particularly care for the 3 different opcodes. Perhaps >> we'd be better off with an inline predicate for when the deposit >> opcode is "valid"? > > We still need to dispatch at tcg generation time which variant is valid. Or > what do you have

[Qemu-devel] [PATCH 16/21] qapi: Convert query-chardev

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp.c| 13 + hmp.h|1 + monitor.c| 11 +-- qapi-schema.json | 26 ++ qemu-char.c | 35

[Qemu-devel] [PATCH 09/21] qapi: dealloc visitor, support freeing of nested lists

2011-09-28 Thread Luiz Capitulino
From: Michael Roth Previously our logic for keeping track of when we're visiting the head of a list was done via a global bool. This can be overwritten if dealing with nested lists, so use stack entries to track this instead. Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- qapi

[Qemu-devel] [PATCH 01/21] error: let error_is_type take a NULL error

2011-09-28 Thread Luiz Capitulino
From: Anthony Liguori Reported-by: Luiz Capitulino Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- error.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/error.c b/error.c index b802752..68c0039 100644 --- a/error.c +++ b/error.c @@ -97,6 +97,10

Re: [Qemu-devel] How to configure a QEmu NIC in bridge mode?

2011-09-28 Thread Ottavio
> From: Luiz Antonio Falaguasta Barbosa > To: qemu-devel@nongnu.org > Date: Wed, 28 Sep 2011 11:48:05 -0300 > Subject: [Qemu-devel] How to configure a QEmu NIC in bridge mode? > Hi guys, > I know this is not a list of QEmu users, but how it doesn't exist, I'll ask > it here. If antbody could help

[Qemu-devel] [PATCH 13/21] qapi: Convert query-kvm

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp.c| 16 hmp.h|1 + monitor.c| 36 +--- qapi-schema.json | 25 +++

[Qemu-devel] [PATCH 19/21] qapi: Convert stop

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + monitor.c|9 - qapi-schema.json | 12 qmp-commands.hx |

[Qemu-devel] [PATCH 10/21] qapi: modify visitor code generation for list iteration

2011-09-28 Thread Luiz Capitulino
From: Michael Roth Modify logic such that we never assign values to the list head argument to progress through the list on subsequent iterations, instead rely only on having our return value passed back in as an argument on the next call. Also update QMP I/O visitors and test cases accordingly, a

[Qemu-devel] [PATCH 15/21] qapi: Convert query-uuid

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp.c|8 hmp.h|1 + monitor.c| 28 +--- qapi-schema.json | 24 qmp-commands.

[Qemu-devel] [PATCH 20/21] qapi: Convert system_reset

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + monitor.c| 10 -- qapi-schema.json |9 + qmp-commands.hx |

Re: [Qemu-devel] [PATCH] [SPARC] Fix segfault in Leon3

2011-09-28 Thread Fabien Chouteau
On 24/09/2011 10:29, Blue Swirl wrote: > On Thu, Sep 22, 2011 at 3:42 PM, Fabien Chouteau wrote: >> Remove faulty access to global "env" in op_helper.c, replaced by function >> argument. >> >> Signed-off-by: Fabien Chouteau >> --- >> target-sparc/cpu.h | 10 ++ >> target-sparc/h

[Qemu-devel] [PATCH 05/21] qapi: fixup command generation for functions that return list types

2011-09-28 Thread Luiz Capitulino
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 2776804..c947ba4 100644 ---

[Qemu-devel] [PATCH 04/21] qapi: use middle mode in QMP server

2011-09-28 Thread Luiz Capitulino
From: Anthony Liguori Use the new middle mode within the existing QMP server. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- Makefile | 12 Makefile.objs|2 ++ Makefile.target |6 +++--- monitor.c|9 - qapi-schema.json

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-28 Thread Stefan Berger
On 09/22/2011 02:37 AM, Michael S. Tsirkin wrote: On Wed, Sep 21, 2011 at 09:44:37PM -0400, Stefan Berger wrote: On 09/19/2011 03:04 PM, Michael S. Tsirkin wrote: On Mon, Sep 19, 2011 at 12:22:02PM -0400, Stefan Berger wrote: On 09/17/2011 03:28 PM, Michael S. Tsirkin wrote: On Fri, Sep 16, 2

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-28 Thread Daniel P. Berrange
On Wed, Sep 28, 2011 at 11:48:19AM -0400, Stefan Berger wrote: > On 09/22/2011 02:37 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 21, 2011 at 09:44:37PM -0400, Stefan Berger wrote: > >>On 09/19/2011 03:04 PM, Michael S. Tsirkin wrote: > >>>On Mon, Sep 19, 2011 at 12:22:02PM -0400, Stefan Berger wro

[Qemu-devel] [PATCH 21/21] qapi: Convert system_powerdown

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + qapi-schema.json | 14 ++ qmp.c|5 + 5 files changed, 26

[Qemu-devel] [PATCH 14/21] qapi: Convert query-status

2011-09-28 Thread Luiz Capitulino
The original conversion was done by Anthony Liguori. This commit is just a rebase. Signed-off-by: Luiz Capitulino --- hmp.c| 19 +++ hmp.h|1 + monitor.c| 41 + qapi-schema.json | 67 +++

  1   2   >