Hello,
I found a strange problem with allocationg big files on drive.
For example in guestfish I allocate large disk image
for example:
$ guestfish
> allocate test.img 20G
When an image allocating, there is a big slowdown of guest OSes,
launched on host machine, and on different drives.
For Li
Am 19.09.2011 22:35, schrieb Sage Weil:
> The config string is variously delimited by =, @, and /, depending on the
> field. Allow these characters to be escaped by preceeding them with \.
>
> Signed-off-by: Sage Weil
Thanks, applied to the block branch.
Kevin
On Fri, Sep 16, 2011 at 06:59:33PM +0200, Lluís Vilanova wrote:
> diff --git a/trace-events b/trace-events
> index c09399f..9d1fbbb 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -454,7 +454,7 @@ milkymist_vgafb_memory_write(uint32_t addr, uint32_t
> value) "addr %08x value %08
> mipsnet_s
On 2011-09-19 20:49, Hervé Poussineau wrote:
> Jan Kiszka a écrit :
>> On 2011-09-18 18:04, Hervé Poussineau wrote:
>>> Signed-off-by: Hervé Poussineau
>>> ---
>>> hw/pc_piix.c |2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>>> ind
On 2011-09-19 16:24, Kevin Wolf wrote:
> Am 19.09.2011 16:05, schrieb Anthony Liguori:
>> On 09/19/2011 02:26 AM, Jan Kiszka wrote:
>>> On 2011-09-16 20:03, Anthony Liguori wrote:
So this is a simplification that I plan on running with. For now, I think
this
series is the right nex
On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote:
The 'simple' trace backend uses pthreads and does not work on Windows. These
patches switch from pthreads to glib so that the code builds on all platforms
supported by glib.
Only one thing I'm unhappy about: the simpletrace write-out thread used to
Am 12.09.2011 16:47, schrieb Devin Nakamura:
> This patch series adds support for block conversion to the qed driver.
> This depends on my precivious block conversion api series
> Devin Nakamura (6):
> qed: add qed_find_cluster_sync()
> qed: add bdrv_qed_get_conversion_options()
> qed: add op
Am 12.09.2011 16:47, schrieb Devin Nakamura:
> Signed-off-by: Devin Nakamura
> ---
> block/qed.c | 57 +
> 1 files changed, 57 insertions(+), 0 deletions(-)
>
> diff --git a/block/qed.c b/block/qed.c
> index 16320f5..93827db 100644
> ---
On Tue, Sep 20, 2011 at 05:05:45PM +0800, hkran wrote:
> On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote:
> >The 'simple' trace backend uses pthreads and does not work on Windows. These
> >patches switch from pthreads to glib so that the code builds on all platforms
> >supported by glib.
> >
> >Only
On Tue, Sep 20, 2011 at 10:38:05AM +0200, Kevin Wolf wrote:
> Am 12.09.2011 16:47, schrieb Devin Nakamura:
> > This patch series adds support for block conversion to the qed driver.
> > This depends on my precivious block conversion api series
> > Devin Nakamura (6):
> > qed: add qed_find_cluster
At 09/14/2011 09:48 AM, Wen Congyang Write:
> At 09/05/2011 02:13 AM, Michael S. Tsirkin Write:
>> Support bridge filtering on top of the memory
>> API as suggested by Avi Kivity:
>>
>> Create a memory region for the bridge's address space. This region is
>> not directly added to system_memory or
Am 12.09.2011 16:59, schrieb Devin Nakamura:
> Signed-off-by: Devin Nakamura
> ---
> block/qed.c | 15 +++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/block/qed.c b/block/qed.c
> index 341cf9d..caecdff 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -15
On Tue, Sep 20, 2011 at 5:57 PM, Stefan Hajnoczi
wrote:
> On Tue, Sep 20, 2011 at 05:05:45PM +0800, hkran wrote:
>> On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote:
>> >The 'simple' trace backend uses pthreads and does not work on Windows.
>> >These
>> >patches switch from pthreads to glib so that
On 09/09/2011 12:37 PM, Stefan Hajnoczi wrote:
The 'simple' trace backend uses pthreads and does not work on Windows. These
patches switch from pthreads to glib so that the code builds on all platforms
supported by glib.
Only one thing I'm unhappy about: the simpletrace write-out thread used to
Signed-off-by: Peter Maydell
---
(1) I've put this in the 'Devices' part of the MAINTAINERS file
because OMAP isn't a specific machine; seemed the best fit
(2) I'll put together a pullreq with this and the other omap
patches later this week or early next.
MAINTAINERS |5 +
1 files change
On 2011-09-09 11:37, Stefan Hajnoczi wrote:
> Convert the simple trace backend to glib so that it works under Windows.
> We cannot use pthread directly but glib provides portable abstractions.
> Also use glib atomics instead of newish gcc builtins which may not be
> supported on Windows toolchains.
Hi ,
How can I port Android -x86 on QEMU. From where I can get the
gingerbread build and QEMU build to run windows 7 Hp EliteBook 8440p. Please
also provide the steps for Installation and running the Gingerbread android.
Br
Navneet Singh
On 09/19/2011 04:41 PM, Michael Roth wrote:
+/* concat first 'offset' chars in 'dest' with 'src' */
+char *strocat(char *buf, const char *src, int offset)
+{
+memcpy(&buf[offset], src, strlen(src));
+buf[offset+strlen(src)] = '\0';
This is just strcpy(&buf[offset], src);
+return b
On 09/20/2011 12:31 PM, Jan Kiszka wrote:
Please avoid restrictive glib thread services. We have qemu_thread
abstractions that allow central tuning (will be needed e.g. to adjust
scheduling parameters).
I think the rationale here was to allow tracing the qemu_thread
routines. For your applica
On 2011-09-20 12:52, Paolo Bonzini wrote:
> On 09/20/2011 12:31 PM, Jan Kiszka wrote:
>> Please avoid restrictive glib thread services. We have qemu_thread
>> abstractions that allow central tuning (will be needed e.g. to adjust
>> scheduling parameters).
>
> I think the rationale here was to allo
The following changes since commit 530889ff95659d8fea81eb556e5706387fdddfa7:
sun4u: don't set up isa_mem_base (2011-09-18 12:00:19 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Alexander Motin (1):
AHCI Port Interrupt Enable register cleanin
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
nbd.c |2 ++
nbd.h | 11 ++-
2 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/nbd.c b/nbd.c
index 47ecb22..d32a19e 100644
--- a/nbd.c
+++ b/nbd.c
@@ -67,6 +67,8 @@
#define NBD_PRINT_DEB
From: Paolo Bonzini
The nbd kernel module cannot enable DISCARD requests unless it is
informed about it. The flags field in the header is used for this,
and this patch adds support for it.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
nbd.c |8
1 files changed, 8 in
From: Paolo Bonzini
nbd supports writing flags in bytes 24...27 of the header,
and uses that for the read-only flag. Add support for it
in qemu-nbd.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block/nbd.c |4 ++--
nbd.c | 32 +---
nbd.h
From: Sage Weil
Properly document the configuration string syntax and semantics. Remove
(out of date) details about the librbd implementation.
Signed-off-by: Sage Weil
Signed-off-by: Kevin Wolf
---
block/rbd.c | 28 +---
1 files changed, 13 insertions(+), 15 deletio
On Tue, Sep 20, 2011 at 11:38:15AM +0400, Nikita A Menkovich wrote:
> Hello,
>
> I found a strange problem with allocationg big files on drive.
>
> For example in guestfish I allocate large disk image
> for example:
>
> $ guestfish
> > allocate test.img 20G
>
> When an image allocating, there i
From: Paolo Bonzini
When assigning a 32-bit value to cmd->xfer (which is 64-bits)
it can be erroneously sign extended because the intermediate
32-bit computation is signed. Fix this by standardizing on
the ld*_be_p functions.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
hw/scsi
On 09/20/2011 11:09 AM, Wen Congyang wrote:
At 09/14/2011 09:48 AM, Wen Congyang Write:
> At 09/05/2011 02:13 AM, Michael S. Tsirkin Write:
>> Support bridge filtering on top of the memory
>> API as suggested by Avi Kivity:
>>
>> Create a memory region for the bridge's address space. This re
From: Paolo Bonzini
Target-independent code cannot construct sglists, but it can take
them from the outside as a black box. Allow this.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
dma.h |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/dma.h b/dma
On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova
> ---
> trace-events |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 9d1fbbb..b653d70 100644
> --- a/trace-events
> +++ b/trace-eve
From: Paolo Bonzini
Also, consistently use qiov.size instead of iov.iov_len.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
hw/scsi-disk.c | 42 ++
1 files changed, 18 insertions(+), 24 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-d
On Tue, Sep 20, 2011 at 04:09:23PM +0800, Wen Congyang wrote:
> At 09/14/2011 09:48 AM, Wen Congyang Write:
> > At 09/05/2011 02:13 AM, Michael S. Tsirkin Write:
> >> Support bridge filtering on top of the memory
> >> API as suggested by Avi Kivity:
> >>
> >> Create a memory region for the bridge's
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
dma-helpers.c | 14 +++---
dma.h |2 +-
hw/ide/core.c |2 +-
hw/ide/macio.c |2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/dma-helpers.c b/dma-helpers.c
inde
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
Signed-off-by: Kevin Wolf
---
posix-aio-compat.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/posix-aio-compat.c b/posix-aio-compat.c
index 3193dbf..63a8fae 100644
--- a/posix-aio-compat.c
+++ b/posix-aio-comp
On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova
> ---
> trace-events |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 9d1fbbb..b653d70 100644
> --- a/trace-events
> +++ b/trace-eve
bdrv_flush is supposed to use 0/-errno return values
Signed-off-by: Kevin Wolf
---
block/raw-posix.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index a624f56..305998d 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.
On Tue, Sep 20, 2011 at 11:58 AM, Jan Kiszka wrote:
> On 2011-09-20 12:52, Paolo Bonzini wrote:
>> On 09/20/2011 12:31 PM, Jan Kiszka wrote:
>>> Please avoid restrictive glib thread services. We have qemu_thread
>>> abstractions that allow central tuning (will be needed e.g. to adjust
>>> scheduli
From: Paolo Bonzini
This fixes various problems with completion/cancellation:
* if the io_func fails to get an AIOCB, the callback wasn't called
* If DMA encounters a bounce buffer conflict, and the DMA operation is
canceled before the bottom half fires, bad things happen.
* memory is not unma
From: Alexander Motin
I've found that FreeBSD AHCI driver doesn't work with AHCI hardware
emulation of QEMU 0.15.0. I believe the problem is on QEMU's side. As I
see, it clears port's Interrupt Enable register each time when reset of
any level happens. Is is reasonable for the global controller r
From: Fam Zheng
Release extent_file on error in vmdk_parse_extents. Added closing files
in freeing extents.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
in
On 09/20/2011 02:55 PM, Michael S. Tsirkin wrote:
>
> Hi Michael S. Tsirkin:
> I test pci bridge filtering on real hardware, and I find that I can mmap
> the resource after I change the memory base and memory limit(The BAR should
> be not visible on OS after changing the memory region).
>
>
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
linux-aio.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 5265a02..bffa6cd 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -68,15 +68,6 @@ static v
From: Stefan Hajnoczi
Convert the simple trace backend to glib so that it works under Windows.
We cannot use pthread directly but glib provides portable abstractions.
Also use glib atomics instead of newish gcc builtins which may not be
supported on Windows toolchains.
Signed-off-by: Stefan Hajn
From: Stefan Hajnoczi
For Windows portability the simple trace backend must use the 'b' file
open mode. This prevents the stdio library from mangling 0x0a/0x0d
newline characters.
Signed-off-by: Stefan Hajnoczi
---
trace/simple.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
di
From: Stefan Hajnoczi
The 'simple' trace backend uses pthreads and does not work on Windows. These
patches switch from pthreads to glib so that the code builds on all platforms
supported by glib.
v3:
* Explain that glib threads need to be used directly
* Explain the signal masking
v2:
* Blo
From: Paolo Bonzini
I found no rationale for this in the logs, and it is quite bad because
it will make scsi-generic unsafe WRT power failures.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
hw/scsi-generic.c |6 --
1 files changed, 0 insert
From: Sage Weil
If we are reading from the default config location, ignore any failures.
It is perfectly legal for the user to specify exactly the options they need
and to not rely on any config file.
Signed-off-by: Sage Weil
Signed-off-by: Kevin Wolf
---
block/rbd.c | 14 --
1
/home/pbonzini/work/upstream/qemu/posix-aio-compat.c: In function 'aio_thread':
/home/pbonzini/work/upstream/qemu/posix-aio-compat.c:314:11: error: variable
'pid' set but not used [-Werror=unused-but-set-variable]
Signed-off-by: Paolo Bonzini
---
Kevin, can you add this to your block bra
On Tue, Sep 20, 2011 at 02:44:26PM +0300, Avi Kivity wrote:
> On 09/20/2011 11:09 AM, Wen Congyang wrote:
> >At 09/14/2011 09:48 AM, Wen Congyang Write:
> >> At 09/05/2011 02:13 AM, Michael S. Tsirkin Write:
> >>> Support bridge filtering on top of the memory
> >>> API as suggested by Avi Kivity
From: Paolo Bonzini
It will not be needed for reads and writes if the HBA provides a sglist.
In addition, this lets scsi-disk refuse commands with an excessive
allocation length, as well as limit memory on usual well-behaved guests.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
h
On Tue, Sep 20, 2011 at 1:18 PM, Paolo Bonzini wrote:
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c: In function
> 'aio_thread':
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c:314:11: error: variable
> 'pid' set but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: P
On 09/20/2011 03:22 PM, Michael S. Tsirkin wrote:
>
> Yes. Instead of hitting the BAR, you hit the default mmio handler.
Hmm, not sure what's right in that case.
But, same if BAR is disabled? Would be nice to make
some handler in bridge to get called, to set
master abort flag etc.
Put an mmi
From: Sage Weil
librbd recently added async writeback and flush support. If the new
rbd_flush() call is available, call it.
Signed-off-by: Sage Weil
Signed-off-by: Kevin Wolf
---
block/rbd.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/block/rbd.c b/bl
From: Sage Weil
The config string is variously delimited by =, @, and /, depending on the
field. Allow these characters to be escaped by preceeding them with \.
Signed-off-by: Sage Weil
Signed-off-by: Kevin Wolf
---
block/rbd.c | 29 +++--
1 files changed, 27 insert
From: Frediano Ziglio
Now that iothread is always compiled sending a signal seems only an
additional step. This patch also avoid writing to two pipe (one from signal
and one in qemu_service_io).
Work with kvm enabled or disabled. strace output is more readable (less
syscalls).
Signed-off-by: F
Am 20.09.2011 14:18, schrieb Paolo Bonzini:
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c: In function
> 'aio_thread':
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c:314:11: error: variable
> 'pid' set but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Paolo Bonzi
On Mon, Sep 19, 2011 at 05:55:41PM +0800, Zhi Yong Wu wrote:
> On Wed, Sep 14, 2011 at 6:50 PM, Marcelo Tosatti wrote:
> > On Tue, Sep 13, 2011 at 11:09:46AM +0800, Zhi Yong Wu wrote:
> >> On Fri, Sep 9, 2011 at 10:44 PM, Marcelo Tosatti
> >> wrote:
> >> > On Thu, Sep 08, 2011 at 06:11:07PM +080
Stefan Hajnoczi writes:
> On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova
>> ---
>> trace-events |4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/trace-events b/trace-events
>> index 9d1fbbb..b653d70 100644
>> ---
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> > Signed-off-by: Lluís Vilanova
> > ---
> > trace-events |4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/trace-events b/trace-events
> > index
On 09/20/2011 01:36 AM, Gerd Hoffmann wrote:
On 09/19/11 18:27, Anthony Liguori wrote:
On 09/19/2011 02:34 AM, Gerd Hoffmann wrote:
FYI: Keeping the pointer to the QemuOpts has one more reason: It will
free the
QemuOpts on hot-unplug, which is needed to free the id from QemuOpts
point of
view,
Hi
v2: Make malc happy release O;-)
- learn how to use fwrite/fread correctly O:-)
- add errno to all error messages
- make checkpatch happy. Except for
WARNING: space prohibited between function name and open parenthesis '('
Please apply.
v1:
QEMUFile is intended to be
QEMUFile * is only intended for migration nowadays. Using it for
anything else just adds pain and a layer of buffers for no good
reason.
Signed-off-by: Juan Quintela
CC: malc
---
audio/wavaudio.c | 34 --
1 files changed, 24 insertions(+), 10 deletions(-)
d
QEMUFile * is only intended for migration nowadays. Using it for
anything else just adds pain and a layer of buffers for no good
reason.
Signed-off-by: Juan Quintela
CC: malc
---
audio/wavcapture.c | 48 ++--
1 files changed, 34 insertions(+), 14
QEMUFile * is only intended for migration nowadays. Using it for
anything else just adds pain and a layer of buffers for no good
reason.
Signed-off-by: Juan Quintela
---
hw/ds1225y.c | 28
1 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/hw/ds1225y
On 09/20/11 15:04, Anthony Liguori wrote:
On 09/20/2011 01:36 AM, Gerd Hoffmann wrote:
On 09/19/11 18:27, Anthony Liguori wrote:
On 09/19/2011 02:34 AM, Gerd Hoffmann wrote:
FYI: Keeping the pointer to the QemuOpts has one more reason: It will
free the
QemuOpts on hot-unplug, which is needed t
Signed-off-by: Juan Quintela
---
migration.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index 15d001e..c56d29c 100644
--- a/migration.c
+++ b/migration.c
@@ -132,9 +132,9 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict,
QObject
Hi
This patch series contains error handling for migration.
After this series are applied, migrate_cancel after one error don't
hang. And we add some error checking left and right.
This is the error handling patches that were on the middle of my
migration-cleanup of some months ago. migration_
Am 28.08.2011 20:48, schrieb Alexander Graf:
>
> On 27.08.2011, at 04:12, Daniel Verkamp wrote:
>
>> Implement an I/O space index-data register pair as defined by the AHCI
>> spec, including the corresponding SATA PCI capability and BAR.
>>
>> This allows real-mode code to access the AHCI registe
Once there, make sure that if we already know that there is one error, just
call migration_fd_cleanup() with the ERROR state.
Signed-off-by: Juan Quintela
---
migration.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index f5959b4..9
If we have one error while migrating, and then we issuse a
"migrate_cancel" command, guest hang. Fix it for flushing only when
migration is in MIG_STATE_ACTIVE. In case of error of cancellation,
don't flush.
We had an infinite loop at buffered_close()
while (!s->has_error && s->buffer_s
On 09/14/2011 10:07 AM, Avi Kivity wrote:
I would like to carry out an online code review of the memory API so that more
people are familiar with the internals, and perhaps even to catch some bugs or
deficiency. I'd like to use the next kvm conference call slot for this (Tuesday
1400 UTC) since m
We were retrying when there was one error, entering a loop.
Signed-off-by: Juan Quintela
---
migration.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index 7f8928a..0baed23 100644
--- a/migration.c
+++ b/migration.c
@@ -362,6 +362,7 @@ v
On 09/20/2011 08:21 AM, Gerd Hoffmann wrote:
On 09/20/11 15:04, Anthony Liguori wrote:
On 09/20/2011 01:36 AM, Gerd Hoffmann wrote:
On 09/19/11 18:27, Anthony Liguori wrote:
On 09/19/2011 02:34 AM, Gerd Hoffmann wrote:
FYI: Keeping the pointer to the QemuOpts has one more reason: It will
free
Signed-off-by: Juan Quintela
---
buffered_file.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/buffered_file.c b/buffered_file.c
index 5ba3d19..10d14f9 100644
--- a/buffered_file.c
+++ b/buffered_file.c
@@ -197,7 +197,7 @@ static int buffered_rate_limit(void *opaque)
On Tue, 20 Sep 2011, Juan Quintela wrote:
> QEMUFile * is only intended for migration nowadays. Using it for
> anything else just adds pain and a layer of buffers for no good
> reason.
I've commited two wav patches with some stylistic and changes.
[..snip..]
--
mailto:av1...@comtv.ru
On 09/20/2011 03:39 PM, Kevin Wolf wrote:
Am 28.08.2011 20:48, schrieb Alexander Graf:
On 27.08.2011, at 04:12, Daniel Verkamp wrote:
Implement an I/O space index-data register pair as defined by the AHCI
spec, including the corresponding SATA PCI capability and BAR.
This allows real-mode cod
From: Yoshiaki Tamura
When qemu on the receiver gets killed during live migration, if debug
is turned on, migrate_fd_put_ready() says,
migration: done iterating
and proceeds. The reason was qemu_savevm_state_iterate() returning 1
even when qemu file has error. This patch checks
qemu_file_has_
From: Yoshiaki Tamura
Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed,
since migrate_fd_put_notify() isn't checking error of underlying
QEMUFile, those resources are kept open. This patch checks it and
calls migrate_fd_error() in case of error.
Signed-off-by: Yoshiaki Tamura
Hi,
Oh, and not
releasing the QemuOpts would also leak memory on each hot-unplug.
If you look at my patch, opts is freed at the end of device_add so there
is no leak.
Ah, ok. Missed that.
cheers,
Gerd
Hi
this patch applies on top of my previous "migration error"
patches. All error handling has been moved to that series,
except for "propagate error correctly", without this
refactoring, it is quite complicated to apply it.
Please, review.
Later, Juan.
v3:
- mor
I have to move two functions postions to avoid forward declarations
Signed-off-by: Juan Quintela
---
migration.c | 72 +-
migration.h | 12 -
2 files changed, 36 insertions(+), 48 deletions(-)
diff --git a/migration.c b/migrati
We are setting a pointer to a local variable in the previous line, just use
the global variable directly. We remove the ->file test because it is already
done inside qemu_file_set_rate_limit() function.
Signed-off-by: Juan Quintela
---
migration.c |6 ++
1 files changed, 2 insertions(+)
Now that current_migration is static, there is no reason for max_throotle
variable.
Signed-off-by: Juan Quintela
---
migration.c | 15 +++
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/migration.c b/migration.c
index 57cb1f8..b8632e5 100644
--- a/migration.c
+++ b/
This cleans up a lot the code as we don't have to check anymore if
the variable is NULL or not.
We don't make it static, because when we integrate fault tolerance, we
can have several migrations at once.
Signed-off-by: Juan Quintela
---
migration.c | 126 +--
This will allows us to hide the status values.
Signed-off-by: Juan Quintela
---
migration.c |4 ++--
migration.h |2 +-
ui/spice-core.c |4 +---
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index b8632e5..fb95e14 100644
--- a/migrat
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> > Signed-off-by: Lluís Vilanova
> > ---
> > trace-events |4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/trace-events b/trace-events
> > index
On Tue, Sep 20, 2011 at 03:24:41PM +0200, Juan Quintela wrote:
> If we have one error while migrating, and then we issuse a
> "migrate_cancel" command, guest hang. Fix it for flushing only when
> migration is in MIG_STATE_ACTIVE. In case of error of cancellation,
> don't flush.
>
> We had an inf
Hi Gerd,
can you (or anyone familiar with those bits) comment on pthread_yield()
in ioport_write() of hw/qxl.c? Which threads are supposed to run this
way? Can't this relation be expressed explicitly? If not, can we use a
sleep here (how long?)?
The background is that yielding easily breaks into
* Lluís Vilanova (vilan...@ac.upc.edu) wrote:
> Stefan Hajnoczi writes:
>
> > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> >> Signed-off-by: Lluís Vilanova
> >> ---
> >> trace-events |4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/tra
Signed-off-by: Juan Quintela
---
migration-exec.c | 16 +---
migration-fd.c | 16 +---
migration-tcp.c | 15 +--
migration-unix.c | 15 +--
migration.c | 29 +
migration.h | 11 +++
6 file
Use MIG_STATE_ACTIVE only when migration has really started
Signed-off-by: Juan Quintela
---
migration.c |6 +-
migration.h | 11 +++
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/migration.c b/migration.c
index 1d7a488..59e8f06 100644
--- a/migration.c
+++ b/
2011/9/20 Mathieu Desnoyers :
> * Lluís Vilanova (vilan...@ac.upc.edu) wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
>> >> Signed-off-by: Lluís Vilanova
>> >> ---
>> >> trace-events | 4 ++--
>> >> 1 files changed, 2 insertions(+), 2 de
We called it from a single place, and always with state !=
MIG_STATE_ACTIVE. Just remove the whole callback. For users of the
notifier, notice that this is exactly the case where they don't care,
we are just freeing the state from previous failed migration (it can't
be a sucessful one, otherwise
"Daniel P. Berrange" wrote:
> On Tue, Sep 20, 2011 at 03:24:41PM +0200, Juan Quintela wrote:
>> If we have one error while migrating, and then we issuse a
>> "migrate_cancel" command, guest hang. Fix it for flushing only when
>> migration is in MIG_STATE_ACTIVE. In case of error of cancellation,
On 09/20/11 16:27, Jan Kiszka wrote:
Hi Gerd,
can you (or anyone familiar with those bits) comment on pthread_yield()
in ioport_write() of hw/qxl.c? Which threads are supposed to run this
way?
spice server thread.
Can't this relation be expressed explicitly?
The thread is created by libsp
Signed-off-by: Juan Quintela
---
migration.c | 19 +--
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/migration.c b/migration.c
index 59e8f06..9d877a0 100644
--- a/migration.c
+++ b/migration.c
@@ -368,22 +368,21 @@ static void migrate_fd_put_ready(void *opaque
It is only used inside migration.c, and fields on that struct are
accessed all around the place on that file.
Signed-off-by: Juan Quintela
---
migration.c | 16 +---
migration.h |1 -
2 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/migration.c b/migration.c
inde
On 2011-09-20 16:48, Gerd Hoffmann wrote:
> On 09/20/11 16:27, Jan Kiszka wrote:
>> Hi Gerd,
>>
>> can you (or anyone familiar with those bits) comment on pthread_yield()
>> in ioport_write() of hw/qxl.c? Which threads are supposed to run this
>> way?
>
> spice server thread.
>
>> Can't this rel
Signed-off-by: Juan Quintela
---
migration.c | 34 --
migration.h | 16
2 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/migration.c b/migration.c
index 1a5e25f..007b162 100644
--- a/migration.c
+++ b/migration.c
@@ -34,7 +34,7
It is used only in one place
Signed-off-by: Juan Quintela
---
migration.c |9 -
migration.h |1 -
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index d63150e..306ac4e 100644
--- a/migration.c
+++ b/migration.c
@@ -132,12 +132,12 @@ free_
1 - 100 of 184 matches
Mail list logo
