Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 08:55 AM, Thomas Huth wrote: > Note that in addition to that, the PAPR spec specifies only one > "device" (whatever that means) per vscsi instance. Really? In that case, I wonder why Linux is using the "Logical unit addressing format" with target IDs and bus numbers instead of th

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Jan Kiszka
On 2011-09-16 20:03, Anthony Liguori wrote: > On 09/16/2011 12:11 PM, Kevin Wolf wrote: >> Am 16.09.2011 18:54, schrieb Anthony Liguori: >>> This series just asks the device model developer to come up with a unique >>> *when* >>> they're doing device composition. Even with a totally path based in

Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer

2011-09-19 Thread Gerd Hoffmann
On 09/16/11 18:00, Anthony Liguori wrote: qdev has this quirk that it owns a seemingly arbitrary QemuOpts pointer. That's because qdev expects a static string for the id (which really makes no sense since ids are supposed to be provided by the user). Instead of managing just the id pointer, we

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Jan Kiszka
On 2011-09-16 20:21, Anthony Liguori wrote: > On 09/16/2011 11:48 AM, Jan Kiszka wrote: >> On 2011-09-16 18:00, Anthony Liguori wrote: >>> This series introduces an infrastructure to remove anonymous devices from >>> qdev. >>> Anonymous devices are one of the big gaps between qdev and QOM so remov

Re: [Qemu-devel] [PATCH 05/14] qdev: remove opts pointer tracking

2011-09-19 Thread Gerd Hoffmann
On 09/16/11 18:00, Anthony Liguori wrote: This was only used because id's memory was stored in opts. No, see reply for patch #4. cheers, Gerd

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Kevin Wolf
Am 16.09.2011 20:03, schrieb Anthony Liguori: > On 09/16/2011 12:11 PM, Kevin Wolf wrote: >> Am 16.09.2011 18:54, schrieb Anthony Liguori: >>> This series just asks the device model developer to come up with a unique >>> *when* >>> they're doing device composition. Even with a totally path based

Re: [Qemu-devel] [PATCH v2 03/15] sheepdog: move coroutine send/recv function to generic code

2011-09-19 Thread Kevin Wolf
Am 17.09.2011 16:49, schrieb Paolo Bonzini: > On 09/17/2011 08:29 AM, MORITA Kazutaka wrote: +#else +struct iovec *p = iov; +ret = 0; +while (iovlen> 0) { +int rc; +if (do_sendv) { +rc = send(

Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled

2011-09-19 Thread Jan Kiszka
On 2011-09-18 18:04, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > hw/pc_piix.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index da6fa55..c0b8a3a 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c > @@ -121,7

Re: [Qemu-devel] [PATCH] Add astyle option file for code formatting

2011-09-19 Thread Markus Armbruster
Anthony Liguori writes: [...] > FWIW, this is what I use with emacs: > > (c-add-style "qemu" > '("stroustrup" > (indent-tabs-mode . nil) > (c-basic-offset . 4) > (tab-width . 8) > ) > nil) ; t = set this style, nil = don't

Re: [Qemu-devel] [PATCH 50/58] pseries: Update SLOF firmware image

2011-09-19 Thread Alexander Graf
On 14.09.2011, at 14:59, Anthony Liguori wrote: > On 09/14/2011 07:28 AM, Peter Maydell wrote: >> On 14 September 2011 13:24, Alexander Graf wrote: >>> Am 14.09.2011 um 13:01 schrieb Peter Maydell: I confess to not really understanding how we keep the git submodules and the binary blob

Re: [Qemu-devel] [PATCH] Add astyle option file for code formatting

2011-09-19 Thread Peter Maydell
On 19 September 2011 09:01, Markus Armbruster wrote: > Anthony Liguori writes: >> FWIW, this is what I use with emacs: > > Here's my configuration (excuse liberal use of sledgehammer): Anybody seeking yet a third emacs configuration can try https://wiki.linaro.org/PeterMaydell/QemuEmacsStyle :

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-19 Thread David Gilbert
On 18 September 2011 16:13, Stefan Weil wrote: > Am 18.09.2011 17:02, schrieb Mulyadi Santosa: >> >> Hi :) >> >> On Sun, Sep 18, 2011 at 02:59, Stefan Weil wrote: >>> >>> Hello, >>> >>> these patches add a new code generator (TCG target) to qemu. >> >> I personally congrats you for your hard work

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Alexander Graf
On 17.09.2011, at 23:40, Blue Swirl wrote: > On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: >> On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >>> Sure :). So the problem is that when emulating the G3 Beige machine in QEMU (default ppc32 target) we also add a PCI VGA adap

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Avi Kivity
On 09/19/2011 12:15 PM, Alexander Graf wrote: On 17.09.2011, at 23:40, Blue Swirl wrote: > On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: >> On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >>> Sure :). So the problem is that when emulating the G3 Beige machine in QEMU

Re: [Qemu-devel] Memory API code review

2011-09-19 Thread Peter Maydell
On 14 September 2011 16:07, Avi Kivity wrote: > I would like to carry out an online code review of the memory API so that > more people are familiar with the internals, and perhaps even to catch some > bugs or deficiency.  I'd like to use the next kvm conference call slot for > this (Tuesday 1400

Re: [Qemu-devel] windows XP fail to enter standby mode

2011-09-19 Thread hkran
On 09/18/2011 03:53 PM, Alon Levy wrote: On Fri, Sep 16, 2011 at 02:28:05PM +0800, hkran wrote: On 09/15/2011 06:42 PM, Alon Levy wrote: On Thu, Sep 15, 2011 at 05:23:01PM +0800, hkran wrote: Hi, If I select to let my guest XP enter standby mode by clicking the button manually. qemu will exit

Re: [Qemu-devel] [PATCH v2 03/15] sheepdog: move coroutine send/recv function to generic code

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 09:47 AM, Kevin Wolf wrote: As long as it's clear what the current version is, I don't mind. Do I understand right that there will be a v3 for patches 3 and 4? Yes. Paolo

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Alexander Graf
On 19.09.2011, at 11:22, Avi Kivity wrote: > On 09/19/2011 12:15 PM, Alexander Graf wrote: >> On 17.09.2011, at 23:40, Blue Swirl wrote: >> >> > On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: >> >> On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >> >>> >> Sure :). So the pro

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-09-19 Thread Justin Shafer
I would like to run wine. I have compiled qemu 0.15.5 from git and I noticed we can enable nptl without a patch. I can run an x86 nptl bash but I havent tried to chroot. I have the posix wine running with qemu... So i tried it with wine and I am able to get a --version out of it, but when I actuall

Re: [Qemu-devel] [net-next RFC V2 PATCH 0/5] Multiqueue support in tun/tap

2011-09-19 Thread Jason Wang
On 09/18/2011 03:17 AM, Michael S. Tsirkin wrote: On Sat, Sep 17, 2011 at 02:02:04PM +0800, Jason Wang wrote: A wiki-page was created to narrate the detail design of all parts involved in the multi queue implementation: http://www.linux-kvm.org/page/Multiqueue and some basic tests result could b

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Avi Kivity
On 09/19/2011 12:36 PM, Alexander Graf wrote: > >>8088-808f : macio >> 0006-0007 : macio-nvram >> 0002-00020fff : pmac-ide >> 00016000-00017fff : cuda >> 00013000-0001303f : escc-bar >> 8000-8fff : dbdma >> -0fff : heathrow

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-09-19 Thread Zhi Yong Wu
On Wed, Sep 14, 2011 at 6:50 PM, Marcelo Tosatti wrote: > On Tue, Sep 13, 2011 at 11:09:46AM +0800, Zhi Yong Wu wrote: >> On Fri, Sep 9, 2011 at 10:44 PM, Marcelo Tosatti wrote: >> > On Thu, Sep 08, 2011 at 06:11:07PM +0800, Zhi Yong Wu wrote: >> >> Note: >> >>      1.) When bps/iops limits are s

Re: [Qemu-devel] [PATCH v2 0/5] block: preparatory patches for scatter/gather support

2011-09-19 Thread Kevin Wolf
Am 16.09.2011 16:39, schrieb Paolo Bonzini: > These patches are preparatory work for supporting scatter/gather in > the SCSI subsystem. Since there would be no HBA actually using it, > I am just posting the cleanups, and the fix for CVE-2011-3346 (buffer > overflow in the handling of READ CAPACITY

Re: [Qemu-devel] [PATCH] VMDK: fix leak of extent_file

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 04:26, schrieb Fam Zheng: > Release extent_file on error in vmdk_parse_extents. Added closing files > in freeing extents. > > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-19 Thread Stefan Hajnoczi
On Mon, Sep 19, 2011 at 9:40 AM, David Gilbert wrote: > On 18 September 2011 16:13, Stefan Weil wrote: >> Am 18.09.2011 17:02, schrieb Mulyadi Santosa: >>> >>> Hi :) >>> >>> On Sun, Sep 18, 2011 at 02:59, Stefan Weil wrote: Hello, these patches add a new code generator (TCG t

Re: [Qemu-devel] [PATCH] removed usused offset variable

2011-09-19 Thread Kevin Wolf
Am 16.09.2011 13:34, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > posix-aio-compat.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-19 Thread David Gilbert
On 19 September 2011 11:20, Stefan Hajnoczi wrote: > On Mon, Sep 19, 2011 at 9:40 AM, David Gilbert > wrote: >> Is it possible to dynamically switch between the two? >> >> The two cases I'm thinking of are: >>  1) Using the interpreter to execute one or two instructions in an exception >> han

[Qemu-devel] Question on block chaining

2011-09-19 Thread 陳韋任
Hi, all I am tracing how block linking is done in QEMU. I find there is a comment in struct TranslationBlock says, /* list of TBs jumping to this one. This is a circular list using the two least significant bits of the pointers to tell what is the next pointer: 0 = jmp_next[0]

Re: [Qemu-devel] AHCI Port Interrupt Enable register cleaning on soft reset

2011-09-19 Thread Kevin Wolf
Am 12.09.2011 10:19, schrieb Alexander Motin: > Alexander Graf wrote: >> Am 11.09.2011 um 16:43 schrieb Alexander Motin : >>> I've found that FreeBSD AHCI driver doesn't work with AHCI hardware >>> emulation of QEMU 0.15.0. I believe the problem is on QEMU's side. As I >>> see, it clears port's Int

Re: [Qemu-devel] [PATCH 1/1] qemu-img: async write to block device when converting image

2011-09-19 Thread Kevin Wolf
Am 12.09.2011 16:26, schrieb Yehuda Sadeh: > In order to improve image conversion process, instead of synchronously > writing the destingation image, we keep a window of async writes. > > Signed-off-by: Yehuda Sadeh Hm, now that I'm really looking at the code, it seems that I misunderstood why y

Re: [Qemu-devel] [PATCH 14/58] device tree: add nop_node

2011-09-19 Thread Alexander Graf
On 17.09.2011, at 18:48, Blue Swirl wrote: > On Wed, Sep 14, 2011 at 8:42 AM, Alexander Graf wrote: >> We have a qemu internal abstraction layer on FDT. While I'm not fully >> convinced >> we need it at all, it's missing the nop_node functionality that we now need >> on e500. So let's add it an

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-19 Thread Alexander Graf
On 17.09.2011, at 19:40, Blue Swirl wrote: > On Sat, Sep 17, 2011 at 5:15 PM, Alexander Graf wrote: >> >> Am 17.09.2011 um 18:58 schrieb Blue Swirl : >> >>> On Wed, Sep 14, 2011 at 8:42 AM, Alexander Graf wrote: CPUs that are not the boot CPU need to run in spinning code to check if >>>

[Qemu-devel] [PATCH 0/2][RFC?] Remove SIGUSR2 from posix-aio

2011-09-19 Thread Frediano Ziglio
Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Tested and works correctly with KVM enabled. Performances are only sligthly better (as I expected). strace output is more rea

[Qemu-devel] [PATCH 1/2] block: avoid storing a constant in qemu_paiocb structure

2011-09-19 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- posix-aio-compat.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index 3193dbf..7ea63a1 100644 --- a/posix-aio-compat.c +++ b/posix-aio-compat.c @@ -42,7 +42,6 @@ struct qemu_paiocb { i

[Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2

2011-09-19 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- cpus.c |5 - posix-aio-compat.c | 14 -- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/cpus.c b/cpus.c index 54c188c..d0cfe91 100644 --- a/cpus.c +++ b/cpus.c @@ -380,11 +380,6 @@ static int qemu_signal_init(v

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Avi Kivity
On 09/19/2011 09:52 AM, Andi Kleen wrote: > I think it also improves branch target prediction - if you have a tight > loop of a few opcodes the predictor can guess where you're headed (since > there is a separate lookup key for each opcode), whereas with the > original code, there's a single

[Qemu-devel] [PATCH v2 0/2] Make simpletrace work on Windows

2011-09-19 Thread Stefan Hajnoczi
The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. v2: * Block signals in trace write-out thread Stefan Hajnoczi (2): trace: portable simple trace backend using glib tr

[Qemu-devel] [PATCH v2 2/2] trace: use binary file open mode in simpletrace

2011-09-19 Thread Stefan Hajnoczi
For Windows portability the simple trace backend must use the 'b' file open mode. This prevents the stdio library from mangling 0x0a/0x0d newline characters. Signed-off-by: Stefan Hajnoczi --- trace/simple.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace/simple.

[Qemu-devel] [PATCH v2 1/2] trace: portable simple trace backend using glib

2011-09-19 Thread Stefan Hajnoczi
Convert the simple trace backend to glib so that it works under Windows. We cannot use pthread directly but glib provides portable abstractions. Also use glib atomics instead of newish gcc builtins which may not be supported on Windows toolchains. Signed-off-by: Stefan Hajnoczi --- trace/simple.

[Qemu-devel] op-helper.c vs helper.c

2011-09-19 Thread Xin Tong Utoronto
There are 2 files on helpers in target-ppc and target-i386 ( op-helper.c helper.c), what are their differences ? also, what kind of functions are typically emulated using helpers ? Thanks Xin

Re: [Qemu-devel] op-helper.c vs helper.c

2011-09-19 Thread Alexander Graf
On 19.09.2011, at 14:06, Xin Tong Utoronto wrote: > There are 2 files on helpers in target-ppc and target-i386 ( op-helper.c > helper.c), what are their differences ? General rule: op_helper.c: Code snippets called from TCG generated code. Implement more complex operations that gcc gets be

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:04 PM, Jan Kiszka wrote: > > If you make the core patch add both mr->offset and mrp->offset, then > change isa to drop memory_region_set_offset(), instead adding the delta > to mrp->offset, does that not work out? Nope. The old API accepted arbitrary portio lists per memory r

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:16 PM, Jan Kiszka wrote: On 2011-09-18 18:49, Richard Henderson wrote: > On 09/18/2011 05:54 AM, Jan Kiszka wrote: >> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion *mr, uint64_t offset, >> const MemoryRegionPortio *mrp; >> >> for (mr

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:07 PM, Jan Kiszka wrote: On 2011-09-18 18:49, Avi Kivity wrote: > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> >> >> >> This is PIO, limited by the x86 address space to 16 bit. Will add a >> >> comment. >> > >> > x86 PIO is not limited to 16 bits, just ISA, which memo

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:07 PM, Jan Kiszka wrote: > I don't think it should be deduplicated. The device is providing two > separate ABIs. Yes, two ABIs, and the only difference is the offset of the data register. How about #ifdef TARGET_I386 # define VBE_DATA_REG 1 #else # define VBE_DATA_REG 2 #e

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:14, Avi Kivity wrote: > On 09/18/2011 10:04 PM, Jan Kiszka wrote: >> > >> > If you make the core patch add both mr->offset and mrp->offset, then >> > change isa to drop memory_region_set_offset(), instead adding the >> delta >> > to mrp->offset, does that not work out? >> >> Nop

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:19, Avi Kivity wrote: > On 09/18/2011 10:07 PM, Jan Kiszka wrote: >> On 2011-09-18 18:49, Avi Kivity wrote: >> > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> >> >> >> >> >> This is PIO, limited by the x86 address space to 16 bit. Will >> add a >> >> >> comment. >> >> > >>

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:29 PM, Jan Kiszka wrote: On 2011-09-19 14:14, Avi Kivity wrote: > On 09/18/2011 10:04 PM, Jan Kiszka wrote: >> > >> > If you make the core patch add both mr->offset and mrp->offset, then >> > change isa to drop memory_region_set_offset(), instead adding the >> delta >>

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:32 PM, Jan Kiszka wrote: > It's opt-in. If a device sets > MemoryRegionOps::impl.{min,max}_access_size = 1, it will only be fed > byte accesses (the core will take care of breaking apart larger > writes). If it sets MemoryRegionOps::impl.{min,max}_access_size = 4, it > wil

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:37, Avi Kivity wrote: > On 09/19/2011 03:29 PM, Jan Kiszka wrote: >> On 2011-09-19 14:14, Avi Kivity wrote: >> > On 09/18/2011 10:04 PM, Jan Kiszka wrote: >> >> > >> >> > If you make the core patch add both mr->offset and >> mrp->offset, then >> >> > change isa to drop memo

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:42, Avi Kivity wrote: > On 09/19/2011 03:32 PM, Jan Kiszka wrote: >> > It's opt-in. If a device sets >> > MemoryRegionOps::impl.{min,max}_access_size = 1, it will only be fed >> > byte accesses (the core will take care of breaking apart larger >> > writes). If it sets MemoryR

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:48 PM, Jan Kiszka wrote: > > Ah: > > -/* If we see a hole, break the region. */ > +/* If we see a new offset, break the region. */ > > > But, sorry for being slow, I don't see why it requires a core update > (other for adding mrp->offset). So far we matched

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:55 PM, Jan Kiszka wrote: > > The trick of having a way to register N callbacks with one shot is worth > growing. Ideally each register in a BAR would have a callback and we'd > do something like > > MemoryRegionOps mydev_ops = { > .registers = { >

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-19 Thread Kevin Wolf
Am 01.09.2011 20:37, schrieb Luiz Capitulino: > This series adds support to the block layer to keep track of devices' > I/O status. That information is also made available in QMP and HMP. > > The goal here is to allow management applications that miss the > BLOCK_IO_ERROR event to able to query th

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-09-19 Thread Justin Shafer
Here is a strace.. fumex calls??? strace -ff -o /ls-strace-alignment-6.log /usr/bin/qemu-i386 /usr/bin /wine-pthread notepad.exe ** Attachment added: "wine.log" https://bugs.launchpad.net/qemu/+bug/739785/+attachment/2426371/+files/wine.log -- You received this bug notification because you

Re: [Qemu-devel] op-helper.c vs helper.c

2011-09-19 Thread Peter Maydell
On 19 September 2011 13:06, Xin Tong Utoronto wrote: > There are 2 files on helpers in target-ppc and target-i386 ( op-helper.c >  helper.c), what are their differences ? also, what kind of functions are > typically emulated using helpers ? The key difference is that op_helper.c is compiled with

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Gerd Hoffmann
Hi, The trick of having a way to register N callbacks with one shot is worth growing. Ideally each register in a BAR would have a callback and we'd do something like MemoryRegionOps mydev_ops = { .registers = { { MYDEV_REG_x, 4, 4, mydev_reg_x_read, mydev_reg_x_wr

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/19/2011 04:55 PM, Gerd Hoffmann wrote: If the register access is trivial then you don't need to call into the driver at all ... You can have a look at hw/intel-hda.c which actually implements something like this, with some commonly needed features: * The "offset" field already ment

Re: [Qemu-devel] [PATCH 2/4] rbd: allow escaping in config string

2011-09-19 Thread Kevin Wolf
Am 15.09.2011 23:11, schrieb Sage Weil: > The config string is variously delimited by =, @, and /, depending on the > field. Allow these characters to be escaped by preceeding them with \. > > Signed-off-by: Sage Weil > --- > block/rbd.c | 29 +++-- > 1 files changed,

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Anthony Liguori
On 09/19/2011 02:26 AM, Jan Kiszka wrote: On 2011-09-16 20:03, Anthony Liguori wrote: So this is a simplification that I plan on running with. For now, I think this series is the right next step because it gives us a path name for the name (although different syntax) and let's us enforce that a

Re: [Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2

2011-09-19 Thread Stefan Hajnoczi
On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio wrote: > @@ -547,7 +549,7 @@ static int posix_aio_flush(void *opaque) > >  static PosixAioState *posix_aio_state; > > -static void aio_signal_handler(int signum) > +static void posix_aio_notify_event(void) >  { >     if (posix_aio_state) { Seems l

Re: [Qemu-devel] [PATCH 0/4] More RBD updates

2011-09-19 Thread Kevin Wolf
Am 15.09.2011 23:11, schrieb Sage Weil: > Hi, > > Here are a few more improvements to the qemu rbd support. The first > patch makes the configuration file handling cleaner (do not error out if > /etc/ceph/ceph.conf doesn't exist). One allows characters in the conf > string to be escaped, so y

Re: [Qemu-devel] [PATCH 0/2][RFC?] Remove SIGUSR2 from posix-aio

2011-09-19 Thread Stefan Hajnoczi
On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio wrote: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Tested and works correctly with KVM enabled. Performances

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-19 Thread Luiz Capitulino
On Mon, 19 Sep 2011 15:40:06 +0200 Kevin Wolf wrote: > Am 01.09.2011 20:37, schrieb Luiz Capitulino: > > This series adds support to the block layer to keep track of devices' > > I/O status. That information is also made available in QMP and HMP. > > > > The goal here is to allow management appl

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:05, schrieb Anthony Liguori: > On 09/19/2011 02:26 AM, Jan Kiszka wrote: >> On 2011-09-16 20:03, Anthony Liguori wrote: >>> So this is a simplification that I plan on running with. For now, I think >>> this >>> series is the right next step because it gives us a path name for the

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:09, schrieb Luiz Capitulino: > On Mon, 19 Sep 2011 15:40:06 +0200 > Kevin Wolf wrote: > >> Am 01.09.2011 20:37, schrieb Luiz Capitulino: >>> This series adds support to the block layer to keep track of devices' >>> I/O status. That information is also made available in QMP and HM

[Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Frediano Ziglio
Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Work with kvm enabled or disabled. strace output is more readable (less syscalls). Signed-off-by: Frediano Ziglio --- cpu

[Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-09-19 Thread Michael Roth
OVERVIEW This patch series implements a QEMUFile Visitor class that's intended to abstract away direct calls to qemu_put_*/qemu_get_* for save/load functions. Currently this is done by always creating a QEMUFileInputVisitor/QEMUFileOutputVisitor pair with each call to qemu_fopen_ops() and main

[Qemu-devel] [RFC 1/8] qapi: add Visitor interfaces for uint*_t and int*_t

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- qapi/qapi-visit-core.c | 78 qapi/qapi-visit-core.h | 30 ++ 2 files changed, 108 insertions(+), 0 deletions(-) diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c index ddef3ed..d2e7d3

[Qemu-devel] [RFC 4/8] savevm: move QEMUFile interfaces into qemu-file.c

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.objs |2 +- hw/hw.h |1 + qemu-file.c | 521 + savevm.c | 494 -- 4 files changed, 523 insertions(+), 495 deletions(-) crea

[Qemu-devel] [RFC 2/8] qapi: add QemuFileOutputVisitor

2011-09-19 Thread Michael Roth
Visitor interface to write values to a QEMUFile. Signed-off-by: Michael Roth --- Makefile.objs | 16 +- qapi/qemu-file-output-visitor.c | 353 +++ qapi/qemu-file-output-visitor.h | 26 +++ 3 files changed, 388 insertions(+), 7 deletions(

[Qemu-devel] [RFC 7/8] cutil: add strocat(), to concat a string to an offset in another

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- cutils.c |8 qemu-common.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index c91f887..0835834 100644 --- a/cutils.c +++ b/cutils.c @@ -84,6 +84,14 @@ int stristart(const char *str, const char *val,

[Qemu-devel] [RFC 3/8] qapi: add QemuFileInputVisitor

2011-09-19 Thread Michael Roth
Visitor interfaces to read values from a QEMUFile Signed-off-by: Michael Roth --- Makefile.objs |1 + qapi/qemu-file-input-visitor.c | 350 qapi/qemu-file-input-visitor.h | 26 +++ 3 files changed, 377 insertions(+), 0 deletions(-)

[Qemu-devel] [RFC 5/8] qapi: test cases for QEMUFile input/output visitors

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile |4 +- test-visitor.c | 404 2 files changed, 406 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7e9382f..2b68e39 100644 --- a/Makefile +++ b/Makefile @@ -155,7 +15

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Andi Kleen
> You generally want CSE, yes? So you can't blame gcc for getting it > wrong sometimes. There are cases where CSE pessimizes the code, .e.g when it increases memory pressure too much or caches something that is easier recomputed. This is just another one. BTW I checked again and the problem see

Re: [Qemu-devel] [PATCH] scsi: fix sign extension problems

2011-09-19 Thread Kevin Wolf
Am 09.09.2011 16:47, schrieb Paolo Bonzini: > When assigning a 32-bit value to cmd->xfer (which is 64-bits) > it can be erroneously sign extended because the intermediate > 32-bit computation is signed. Fix this by standardizing on > the ld*_be_p functions. > > Signed-off-by: Paolo Bonzini Than

[Qemu-devel] [RFC 6/8] savevm: add QEMUFile->visitor lookup routines

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/hw.h | 19 + qemu-file.c | 64 +++ 2 files changed, 83 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 244bfb9..e6d7c6a 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -10

[Qemu-devel] [RFC 8/8] slirp: convert save/load function to visitor interface

2011-09-19 Thread Michael Roth
Where possible common routines are used for both input and output, thus save on lines of code, theoretically. The added lines here are mostly due to extra logic for each save/load routine to manipulate strings into a unique field name for each saved field, and in some cases a few extra Visitor call

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 04:37 PM, Frediano Ziglio wrote: Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Work with kvm enabled or disabled. strace output is more readable (less sys

[Qemu-devel] [PATCH] linux-aio: remove process requests callback

2011-09-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- linux-aio.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/linux-aio.c b/linux-aio.c index 5265a02..bffa6cd 100644 --- a/linux-aio.c +++ b/linux-aio.c @@ -68,15 +68,6 @@ static void qemu_laio_process_completion(struct qemu_lai

Re: [Qemu-devel] Help needed -- vvfat.c

2011-09-19 Thread Kevin Wolf
Am 15.09.2011 14:49, schrieb Pintu Kumar: > Hi, > > This is regarding qemu block/vvfat.c. > > Currently vvfat scans all directories and sub-directories in the > beginning during init_directories(). > > I want to modify vvfat such that it should scan only the TOP directory > content and not the s

Re: [Qemu-devel] [net-next RFC V2 PATCH 0/5] Multiqueue support in tun/tap

2011-09-19 Thread Ben Hutchings
On Sat, 2011-09-17 at 14:02 +0800, Jason Wang wrote: [...] > 2 Current implementation may also get regression for single session > packet transmission. > > The reason is packets from each flow were not handled by the same > queue/vhost thread. > > Various method could be done to handle this: > >

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 17:02, schrieb Paolo Bonzini: > On 09/19/2011 04:37 PM, Frediano Ziglio wrote: >> Now that iothread is always compiled sending a signal seems only an >> additional step. This patch also avoid writing to two pipe (one from signal >> and one in qemu_service_io). >> >> Work with kvm enab

[Qemu-devel] mesavantages.net, bénéficiez d'avantages pour vous et vos salariés

2011-09-19 Thread Canalce
Canalce lance mesavantages.net Si ce message n'est pas lisible, merci de suivre ce lien Si vous ne voulez plus recevoir cet email, merci de suivre ce lien Si vous souhaitez vous désabonner, recopiez cette adresse dans la barre d'adresse de votre navigateur : http://www.ccmail-gmc.

Re: [Qemu-devel] [PATCH] linux-aio: remove process requests callback

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 17:05, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > linux-aio.c | 11 +-- > 1 files changed, 1 insertions(+), 10 deletions(-) Thanks applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Work with kvm enabled or disabled. strace output is more readable (le

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-19 Thread Mulyadi Santosa
Hi Stefan On Mon, Sep 19, 2011 at 03:15, Stefan Weil wrote: > Am 18.09.2011 18:39, schrieb Mulyadi Santosa: >> On Sun, Sep 18, 2011 at 22:13, Stefan Weil wrote: >> So, that interpreter, should it be build inside Qemu too? Or can we >> use/write external one? let's say creating one in python

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-19 Thread Alex Williamson
On Fri, 2011-09-09 at 08:11 -0500, Stuart Yoder wrote: > Based on the discussions over the last couple of weeks > I have updated the device fd file layout proposal and > tried to specify it a bit more formally. > > === > > 1. Overview >

[Qemu-devel] [PATCH] qcow2: Unlock during COW

2011-09-19 Thread Kevin Wolf
Unlocking during COW allows for more parallelism. One change it requires is that buffers are dynamically allocated instead of just using a per-image buffer. While touching the code, drop the synchronous qcow2_read() function and replace it by a bdrv_read() call. Signed-off-by: Kevin Wolf --- bl

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 05:11 PM, Kevin Wolf wrote: > I think it is possible to go a step further, turn > posix_aio_process_queue into a bottom half and get rid of the pipe > altogether. This in turn would remove the only real user of > io_process_queue in qemu_aio_set_fd_handler. However, this is al

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-19 Thread Scott Wood
On 09/19/2011 06:35 AM, Alexander Graf wrote: > > On 17.09.2011, at 19:40, Blue Swirl wrote: > >> On Sat, Sep 17, 2011 at 5:15 PM, Alexander Graf wrote: >>> >>> Am 17.09.2011 um 18:58 schrieb Blue Swirl : >>> On Sparc32, there is no need for a PV device. The CPU is woken up from halted

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-19 Thread Stefan Berger
On 09/17/2011 03:28 PM, Michael S. Tsirkin wrote: On Fri, Sep 16, 2011 at 12:46:40PM -0400, Stefan Berger wrote: On 09/16/2011 10:44 AM, Michael S. Tsirkin wrote: On Thu, Sep 15, 2011 at 10:33:13AM -0400, Stefan Berger wrote: On 09/15/2011 08:28 AM, Michael S. Tsirkin wrote: So the below is a

Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer

2011-09-19 Thread Anthony Liguori
On 09/19/2011 02:34 AM, Gerd Hoffmann wrote: On 09/16/11 18:00, Anthony Liguori wrote: qdev has this quirk that it owns a seemingly arbitrary QemuOpts pointer. That's because qdev expects a static string for the id (which really makes no sense since ids are supposed to be provided by the user).

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Richard Henderson
On 09/17/2011 01:00 PM, Stefan Weil wrote: > +#if TCG_TARGET_HAS_ext8s_i32 > +case INDEX_op_ext8s_i32: > +t0 = *tb_ptr++; > +t1 = tci_read_r8s(&tb_ptr); > +tci_write_reg32(t0, t1); > +break; > +#endif You really ought not need all these ifdef

Re: [Qemu-devel] [RFC PATCH 3/5] VFIO: Base framework for new VFIO driver

2011-09-19 Thread Alex Williamson
Sorry for the delay, just getting back from LPC and some time off... On Wed, 2011-09-07 at 10:52 -0400, Konrad Rzeszutek Wilk wrote: > > +static long vfio_iommu_unl_ioctl(struct file *filep, > > +unsigned int cmd, unsigned long arg) > > +{ > > + struct vfio_iommu *vio

Re: [Qemu-devel] [Qemu-ppc] [PATCH 33/58] KVM: update kernel headers

2011-09-19 Thread Scott Wood
On 09/17/2011 11:59 AM, Blue Swirl wrote: > On Wed, Sep 14, 2011 at 8:42 AM, Alexander Graf wrote: >> diff --git a/linux-headers/linux/kvm_para.h b/linux-headers/linux/kvm_para.h >> index 7bdcf93..b315e27 100644 >> --- a/linux-headers/linux/kvm_para.h >> +++ b/linux-headers/linux/kvm_para.h >> @@

Re: [Qemu-devel] [Qemu-ppc] [PATCH 33/58] KVM: update kernel headers

2011-09-19 Thread Alexander Graf
On 19.09.2011, at 19:50, Scott Wood wrote: > On 09/17/2011 11:59 AM, Blue Swirl wrote: >> On Wed, Sep 14, 2011 at 8:42 AM, Alexander Graf wrote: >>> diff --git a/linux-headers/linux/kvm_para.h b/linux-headers/linux/kvm_para.h >>> index 7bdcf93..b315e27 100644 >>> --- a/linux-headers/linux/kvm_pa

Re: [Qemu-devel] configure: Detect predefined compiler symbols for ARM and HPPA

2011-09-19 Thread Brad
On 07/09/11 9:24 PM, Brad wrote: configure: Detect predefined compiler symbols for ARM and HPPA To be able to detect some ARM / HPPA based architectures such as with OpenBSD/(armish / zaurus) or OpenBSD/hppa. Signed-off-by: Brad Smith ping. -- This message has been scanned for viruses and da

Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled

2011-09-19 Thread Hervé Poussineau
Jan Kiszka a écrit : On 2011-09-18 18:04, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau --- hw/pc_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index da6fa55..c0b8a3a 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -121,7

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-19 Thread Scott Wood
On 09/19/2011 10:16 AM, Alex Williamson wrote: > On Fri, 2011-09-09 at 08:11 -0500, Stuart Yoder wrote: >> 2. Header >> >> The header is located at offset 0x0 in the device fd >> and has the following format: >> >> struct devfd_header { >> __u32 magic; >> __u32 version; >>

  1   2   >