[Qemu-devel] About hotplug multifunction

2011-09-09 Thread Amos Kong
Hello all, I'm working on hotplug pci multifunction. 1. qemu cmdline: ./x86_64-softmmu/qemu-system-x86_64 -snapshot -m 2000 /home/kvm_autotest_root/images/rhel61-64-virtio.qcow2 -vnc :0 -monitor unix:/tmp/a,server,nowait --enable-kvm -net none 2. script to add virtio-blk devices: for i in `s

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-09 Thread Michael S. Tsirkin
On Fri, Sep 09, 2011 at 02:43:24PM +0800, Wen Congyang wrote: > > However, filtering doesn't work. You could put a BAR outside the > > filtered area and it would be visible to the guest. > > > > I test it on real hardware. If I put a BAR outside the filterer area, and > then run 'lspci -vv', the

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-09 Thread Wen Congyang
At 09/09/2011 03:12 PM, Michael S. Tsirkin Write: > On Fri, Sep 09, 2011 at 02:43:24PM +0800, Wen Congyang wrote: >>> However, filtering doesn't work. You could put a BAR outside the >>> filtered area and it would be visible to the guest. >>> >> >> I test it on real hardware. If I put a BAR outsid

Re: [Qemu-devel] About hotplug multifunction

2011-09-09 Thread Michael S. Tsirkin
On Fri, Sep 09, 2011 at 03:08:21AM -0400, Amos Kong wrote: > Hello all, > > I'm working on hotplug pci multifunction. > > 1. qemu cmdline: > ./x86_64-softmmu/qemu-system-x86_64 -snapshot -m 2000 > /home/kvm_autotest_root/images/rhel61-64-virtio.qcow2 -vnc :0 -monitor > unix:/tmp/a,server,nowa

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-09 Thread Michael S. Tsirkin
On Fri, Sep 09, 2011 at 03:24:54PM +0800, Wen Congyang wrote: > At 09/09/2011 03:12 PM, Michael S. Tsirkin Write: > > On Fri, Sep 09, 2011 at 02:43:24PM +0800, Wen Congyang wrote: > >>> However, filtering doesn't work. You could put a BAR outside the > >>> filtered area and it would be visible to

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-09 Thread Wen Congyang
At 09/09/2011 03:34 PM, Michael S. Tsirkin Write: > On Fri, Sep 09, 2011 at 03:24:54PM +0800, Wen Congyang wrote: >> At 09/09/2011 03:12 PM, Michael S. Tsirkin Write: >>> On Fri, Sep 09, 2011 at 02:43:24PM +0800, Wen Congyang wrote: > However, filtering doesn't work. You could put a BAR outsid

Re: [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features

2011-09-09 Thread Peter Maydell
On 9 September 2011 01:22, Marek Vasut wrote: > Signed-off-by: Marek Vasut > --- >  target-arm/helper.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 58cd99f..2f3e937 100644 > --- a/target-arm/helper.c > +++ b/targe

[Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code

2011-09-09 Thread Paolo Bonzini
Outside coroutines, avoid busy waiting on EAGAIN by temporarily making the socket blocking. The API of qemu_recvv/qemu_sendv is slightly different from do_readv/do_writev because they do not handle coroutines. It returns the number of bytes written before encountering an EAGAIN. The specificity

Re: [Qemu-devel] [PATCH] Fix include statements for qemu-common.h

2011-09-09 Thread Kevin Wolf
Am 08.09.2011 17:55, schrieb Stefan Weil: > * qemu-common.h is not a system include file, so it should be included > with "" instead of <>. Otherwise incremental builds might fail > because only local include files are checked for changes. > > * linux-user/syscall.c included the file twice. >

Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-09 Thread Kevin Wolf
Am 08.09.2011 18:36, schrieb Sage Weil: > On Thu, 8 Sep 2011, Kevin Wolf wrote: >> Am 08.09.2011 01:06, schrieb Yehuda Sadeh: >>> The following set of patches improve the qemu-img conversion process >>> performance. When using a higher latency backend, small writes have a >>> severe impact on the t

Re: [Qemu-devel] CFQ I/O starvation problem triggered by RHEL6.0 KVM guests

2011-09-09 Thread Takuya Yoshikawa
Vivek Goyal wrote: > So you are using both RHEL 6.0 in both host and guest kernel? Can you > reproduce the same issue with upstream kernels? How easily/frequently > you can reproduce this with RHEL6.0 host. Guests were CentOS6.0. I have only RHEL6.0 and RHEL6.1 test results now. I want to try s

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Kevin Wolf
Am 08.09.2011 17:24, schrieb Paolo Bonzini: > I find nbd quite useful to test migration, but it is limited: > it can only do synchronous operation, it is not safe because it > does not support flush, and it has no discard either. qemu-nbd > is also limited to 1MB requests, and the nbd block driver

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-9p: Fix syntax error in debug code

2011-09-09 Thread Stefan Hajnoczi
On Thu, Sep 08, 2011 at 06:17:08PM +0200, Stefan Weil wrote: > Am 20.07.2011 11:44, schrieb Aneesh Kumar K.V: > >On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil > > wrote: > >>This error was reported by cppcheck: > >> > >>qemu/hw/9pfs/virtio-9p-debug.c:342: > >>error: Invalid number of character ({

Re: [Qemu-devel] [Qemu-trivial] [PATCH] SPARC: Trivial patch to clean up npc monitor output

2011-09-09 Thread Stefan Hajnoczi
On Thu, Sep 08, 2011 at 09:58:31PM -0500, Nathan Kunkee wrote: > > This patch fixes the spacing of the PC and NPC output from 'info > cpus' for SPARC. > > Signed-off-by: Nathan Kunkee Thanks, applied to the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/t

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix include statements for qemu-common.h

2011-09-09 Thread Stefan Hajnoczi
On Thu, Sep 08, 2011 at 05:55:32PM +0200, Stefan Weil wrote: > * qemu-common.h is not a system include file, so it should be included > with "" instead of <>. Otherwise incremental builds might fail > because only local include files are checked for changes. > > * linux-user/syscall.c included

[Qemu-devel] [PATCH 1/2] balloon: Disassociate handlers from balloon device on unplug

2011-09-09 Thread Amit Shah
When a balloon device gets unplugged, allow the balloon handlers to be freed. Signed-off-by: Amit Shah --- balloon.c | 10 ++ balloon.h |1 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/balloon.c b/balloon.c index f56fdc1..a2133db 100644 --- a/balloon.c +++ b/ba

[Qemu-devel] [PATCH 2/2] virtio-balloon: Disassociate from the balloon handlers on unplug

2011-09-09 Thread Amit Shah
Adding a 2nd balloon device after unplugging the first one doesn't work. Also, the 'info balloon' command should indicate an error mentioning no balloon device is registered after unplug. Reproduction steps given by Shaolong Hu: (qemu) info balloon Device 'balloon' has not been activated by the g

Re: [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features

2011-09-09 Thread Marek Vasut
On Friday, September 09, 2011 09:52:42 AM Peter Maydell wrote: > On 9 September 2011 01:22, Marek Vasut wrote: > > Signed-off-by: Marek Vasut > > --- > > target-arm/helper.c |1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/target-arm/helper.c b/target-arm/help

Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member

2011-09-09 Thread Kevin Wolf
Am 08.09.2011 21:44, schrieb Stefan Weil: > Member variable is_read is written, but never read > (contrary to its name). Nice commit message :-) > Kevin Wolf > Signed-off-by: Stefan Weil > --- > hw/ide/ahci.c |2 -- > hw/ide/ahci.h |1 - > 2 files changed, 0 insertions(+), 3 deletions(

[Qemu-devel] [PATCH 4/8] qemu-options: Improve help texts for options which depend on configure

2011-09-09 Thread Stefan Hajnoczi
From: Stefan Weil * Replace "available only" by the more common "only available". * Tracing options depend on the configuration of the QEMU executable, so clarify the help text for both options. Cc: Stefan Hajnoczi Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qemu-options

[Qemu-devel] [PATCH 2/8] configure: Remove relicts from --enable-io-thread

2011-09-09 Thread Stefan Hajnoczi
From: Stefan Weil Commit 12d4536f7d911b6d87a766ad7300482ea663cea2 removed configure option --enable-io-thread. Remove help message which is now no longer valid. Cc: Anthony Liguori Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure |1 - 1 files changed, 0 insertion

[Qemu-devel] [PATCH 7/8] virtio-9p: Fix syntax error in debug code

2011-09-09 Thread Stefan Hajnoczi
From: Stefan Weil This error was reported by cppcheck: qemu/hw/9pfs/virtio-9p-debug.c:342: error: Invalid number of character ({) when these macros are defined: 'DEBUG_DATA'. Cc: Aneesh Kumar K.V Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/9pfs/virtio-9p-debug.c |2

[Qemu-devel] [PATCH 3/8] docs: Fix qdev-device-use.txt typo in -chardev serial, path=COM

2011-09-09 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- docs/qdev-device-use.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index 057c322..136d271 100644 --- a/docs/qdev-devic

Re: [Qemu-devel] [PATCH] tcg/ppc64: Fix zero extension code generation bug for ppc64 host

2011-09-09 Thread Alexander Graf
On 09.09.2011, at 07:58, David Gibson wrote: > From: Thomas Huth > > The ppc64 code generation backend uses an rldicr (Rotate Left Double > Immediate and Clear Right) instruction to implement zero extension of > a 32 bit quantity to a 64 bit quantity (INDEX_op_ext32u_i64). However > this is wr

[Qemu-devel] [PATCH 4/7] linux-user: Fix MIPS indirect syscall handling

2011-09-09 Thread riku . voipio
From: An-Cheng Huang Change the number of argument for MIPS sys_syscall from 0 to 8. This allows arguments for indirect syscalls to be processed correctly. Signed-off-by: Riku Voipio Reviewed-by: Peter Maydell Signed-off-by: An-Cheng Huang --- linux-user/main.c |2 +- 1 files changed, 1

[Qemu-devel] [PATCH 5/7] linux-user: Verify MIPS syscall arguments

2011-09-09 Thread riku . voipio
From: An-Cheng Huang On MIPS, some syscall arguments are taken from the stack. This patch adds verification such that do_syscall() is only invoked if all arguments have been successfully taken from the stack. Signed-off-by: Riku Voipio Reviewed-by: Peter Maydell Signed-off-by: An-Cheng Huang

[Qemu-devel] [PATCH 3/7] linux-user: Exit with an error if we couldn't set up gdbserver

2011-09-09 Thread riku . voipio
From: Peter Maydell If gdbserver_start() fails (usually because we couldn't bind to the requested TCP port) then exit qemu rather than blithely continuing. This brings the linux-user behaviour in to line with system mode. Signed-off-by: Riku Voipio Signed-off-by: Peter Maydell --- linux-user/

Re: [Qemu-devel] [PATCH] block: allow resizing of images residing on host devices

2011-09-09 Thread Kevin Wolf
Am 07.09.2011 13:02, schrieb Christoph Hellwig: > Allow to resize images that reside on host devices up to the available > space. This allows to grow images after resizing the device manually or > vice versa. > > Reviewed-by: Christoph Hellwig You mean Signed-off-by, no? > Index: qemu/block/ra

[Qemu-devel] [PATCH 0/7] pending linux-user patches

2011-09-09 Thread riku . voipio
From: Riku Voipio The following patches have sent to the list last month and look ok. If everyone is Ok with these patches, I will send these as pull request next week. Patches are also available at the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-upstream

[Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib

2011-09-09 Thread Stefan Hajnoczi
Convert the simple trace backend to glib so that it works under Windows. We cannot use pthread directly but glib provides portable abstractions. Also use glib atomics instead of newish gcc builtins which may not be supported on Windows toolchains. Signed-off-by: Stefan Hajnoczi --- trace/simple.

[Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-09 Thread Stefan Hajnoczi
The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. Only one thing I'm unhappy about: the simpletrace write-out thread used to block all signals. I have removed that code and

[Qemu-devel] [PATCH 2/2] trace: use binary file open mode in simpletrace

2011-09-09 Thread Stefan Hajnoczi
For Windows portability the simple trace backend must use the 'b' file open mode. This prevents the stdio library from mangling 0x0a/0x0d newline characters. Signed-off-by: Stefan Hajnoczi --- trace/simple.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace/simple.

Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member

2011-09-09 Thread Alexander Graf
On 09.09.2011, at 11:15, Kevin Wolf wrote: > Am 08.09.2011 21:44, schrieb Stefan Weil: >> Member variable is_read is written, but never read >> (contrary to its name). > > Nice commit message :-) > >> Kevin Wolf >> Signed-off-by: Stefan Weil >> --- >> hw/ide/ahci.c |2 -- >> hw/ide/ahci.h

[Qemu-devel] Why qemu write/rw speed is so low?

2011-09-09 Thread Zhi Yong Wu
HI, Today, i did some basical I/O testing, and suddenly found that qemu write and rw speed is so low now, my qemu binary is built on commit 344eecf6995f4a0ad1d887cec922f6806f91a3f8. Do qemu have regression? The testing data is shown as below: 1.) write test: (g=0): rw=write, bs=512-512/512-5

[Qemu-devel] [PATCH 6/8] SPARC: Trivial patch to clean up npc monitor output

2011-09-09 Thread Stefan Hajnoczi
From: Nathan Kunkee This patch fixes the spacing of the PC output from 'info cpus' for SPARC. Signed-off-by: Nathan Kunkee Signed-off-by: Stefan Hajnoczi --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index df0f622..03ae997 100644

[Qemu-devel] [PULL 0/8] Trivial patches for September 3 to 9 2011

2011-09-09 Thread Stefan Hajnoczi
The following changes since commit 07ff2c4475df77e38a31d50ee7f3932631806c15: Merge remote-tracking branch 'origin/master' into staging (2011-09-08 09:25:36 -0500) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Markus Armbruster (1):

[Qemu-devel] [PATCH 7/7] introduce environment variables for all qemu-user options

2011-09-09 Thread riku . voipio
From: Johannes Schauer (Edits by Riku Voipio to apply to current HEAD) Rework option parsing code for linux-user in a table-driven manner to allow environment variables for all commandline options. Also generate usage() output from option table. Fix complains from checkpatch.pl, also have envl

[Qemu-devel] [PATCH 8/8] Fix include statements for qemu-common.h

2011-09-09 Thread Stefan Hajnoczi
From: Stefan Weil * qemu-common.h is not a system include file, so it should be included with "" instead of <>. Otherwise incremental builds might fail because only local include files are checked for changes. * linux-user/syscall.c included the file twice. Cc: Riku Voipio Cc: Jan Kiszka

[Qemu-devel] [PATCH 5/8] configure: Avoid duplicate flags when calling compile_prog

2011-09-09 Thread Stefan Hajnoczi
From: Stefan Weil This patch removes redundant shell code and cleans it a little bit. Shell macro compile_prog takes two arguments: local_cflags and local ldflags. $QEMU_CFLAGS is added automatically to the cflags, so there is no need to pass it as an argument. It is also unnecessary to pass -

[Qemu-devel] [PATCH 1/8] Fix comment (install patch -> install path)

2011-09-09 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 5ba9b35..c9e1975 100644 --- a/vl.c +++ b/vl.c @@ -3061,7 +3061,7 @@ int main(int argc, char **argv, char **envp)

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 11:00 AM, Kevin Wolf wrote: There is anonther patch enabling AIO for NBD on the list [1], by Nicholas Thomas (CCed), that lacked review so far. Can you guys please review each others approach and then converge on a solution? I guess Paolo's patches 1-7 can be applied in any case, pr

[Qemu-devel] [PATCH -V2 1/2] hw/9pfs: add 9P2000.L renameat operation

2011-09-09 Thread Aneesh Kumar K.V
rename - change name of file or directory size[4] Trenameat tag[2] olddirfid[4] oldname[s] newdirfid[4] newname[s] size[4] Rrenameat tag[2] older Trename have the below request format size[4] Trename tag[2] fid[4] newdirfid[4] name[s] The rename message is used to change the name of a file, pos

[Qemu-devel] [PATCH -V2 2/2] hw/9pfs: add 9P2000.L unlinkat operation

2011-09-09 Thread Aneesh Kumar K.V
unlinkat - Remove a directory entry size[4] Tunlinkat tag[2] dirfid[4] name[s] flag[4] size[4] Runlinkat tag[2] older Tremove have the below request format size[4] Tremove tag[2] fid[4] The remove message is used to remove a directory entry either file or directory The remove opreation is actua

[Qemu-devel] [PATCH 6/7] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-09-09 Thread riku . voipio
From: An-Cheng Huang This patch implements the setxattr, getxattr, and removexattr syscalls if CONFIG_ATTR is enabled. Note that since libattr uses indirect syscalls for these, this change depends on the fix for indirect syscall handling on MIPS. Signed-off-by: Riku Voipio Reviewed-by: Peter M

Re: [Qemu-devel] [RESEND][PATCH] booke timers

2011-09-09 Thread Fabien Chouteau
On 07/09/2011 21:59, Alexander Graf wrote: > > On 07.09.2011, at 16:41, Fabien Chouteau wrote: > >> On 06/09/2011 21:33, Alexander Graf wrote: >>> >>> >>> Am 01.09.2011 um 10:20 schrieb Fabien Chouteau : >>> While working on the emulation of the freescale p2010 (e500v2) I realized that

[Qemu-devel] [PATCH 1/7] linux-user: Fix initialization of the heap contents when allocating new pages

2011-09-09 Thread riku . voipio
From: Cédric VINCENT Technically the new mmapped pages are already initialized to zero since they are anonymous, however we have to take care with the contents that come from the remaining part of the previous page: it may contains garbage data due to a previous heap usage (grown then shrunken).

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-09 Thread Stefan Hajnoczi
On Fri, Sep 09, 2011 at 05:44:36PM +0800, Zhi Yong Wu wrote: > Today, i did some basical I/O testing, and suddenly found that qemu write and > rw speed is so low now, my qemu binary is built on commit > 344eecf6995f4a0ad1d887cec922f6806f91a3f8. > > Do qemu have regression? > > The testing data

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 12:29, schrieb Paolo Bonzini: > On 09/09/2011 11:00 AM, Kevin Wolf wrote: >> There is anonther patch enabling AIO for NBD on the list [1], by >> Nicholas Thomas (CCed), that lacked review so far. Can you guys please >> review each others approach and then converge on a solution? I gue

[Qemu-devel] [PATCH 2/7] linux-user: Implement new ARM 64 bit cmpxchg kernel helper

2011-09-09 Thread riku . voipio
From: Dr. David Alan Gilbert linux-user: Implement new ARM 64 bit cmpxchg kernel helper Linux 3.1 will have a new kernel-page helper for ARM implementing 64 bit cmpxchg. Implement this helper in QEMU linux-user mode: * Provide kernel helper emulation for 64bit cmpxchg * Allow guest to object t

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Nicholas Thomas
On Fri, 2011-09-09 at 12:29 +0200, Paolo Bonzini wrote: > On 09/09/2011 11:00 AM, Kevin Wolf wrote: > > There is anonther patch enabling AIO for NBD on the list [1], by > > Nicholas Thomas (CCed), that lacked review so far. Can you guys please > > review each others approach and then converge on a

[Qemu-devel] [PATCH 4/8] hw/9pfs: Add init callback to fs driver

2011-09-09 Thread Aneesh Kumar K.V
This call back can be used to do fs driver specific initialization. Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |2 ++ hw/9pfs/virtio-9p-device.c |7 ++- hw/9pfs/virtio-9p-local.c |7 ++- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/fsde

[Qemu-devel] [PATCH 1/8] hw/9pfs: Make v9fs_string* functions non-static

2011-09-09 Thread Aneesh Kumar K.V
We will use them later in other files Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 10 +- hw/9pfs/virtio-9p.h |5 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index d28edb7..dc3e32b 100644 --- a/hw/9pfs

[Qemu-devel] [PATCH 5/8] hw/9pfs: Add fs driver specific details to fscontext

2011-09-09 Thread Aneesh Kumar K.V
Add a new context flag PATHNAME_FSCONTEXT and indicate whether the fs driver track fid using path names. Also add a private pointer that help us to track fs driver specific values in there Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |6 hw/9pfs/codir.c|

[Qemu-devel] [PATCH] Implement file handle based fs driver

2011-09-09 Thread Aneesh Kumar K.V
This patchset implement a file handle based fs driver for VirtFS server Using file handle instead of names, simplify the rename handling in the server. The changes also enable us to handle renames on the host. Since we are not using pathnames, symlink related security issues are not present with ha

[Qemu-devel] [PATCH 8/8] hw/9pfs: Add handle based fs driver

2011-09-09 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- Makefile.objs |8 +- fsdev/qemu-fsdev.c |1 + fsdev/qemu-fsdev.h |1 + hw/9pfs/virtio-9p-handle.c | 611 4 files changed, 617 insertions(+), 4 deletions(-) create mode 10064

[Qemu-devel] [PATCH 2/8] hw/9pfs: Use read-write lock for protecting fid path.

2011-09-09 Thread Aneesh Kumar K.V
On rename we take the write lock and this ensure path doesn't change as we operate on them. Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/codir.c| 18 ++- hw/9pfs/cofile.c | 32 +++-- hw/9pfs/cofs.c | 52 ++--- hw/9pfs/coxattr.c

[Qemu-devel] [PATCH 6/8] hw/9pfs: Avoid unnecessary get_fid in v9fs_clunk

2011-09-09 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 2a68953..e51df2a 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -417,7 +417,7 @@ sta

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 12:50 PM, Nicholas Thomas wrote: > On the other hand, Nicholas's work includes timeout and reconnect. I'm > not sure how complicated it is to include it in my series, but probably > not much. With coroutines, preserving the list of outstanding I/O > requests is done implicitly

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 12:50, schrieb Nicholas Thomas: > On Fri, 2011-09-09 at 12:29 +0200, Paolo Bonzini wrote: >> On 09/09/2011 11:00 AM, Kevin Wolf wrote: >>> There is anonther patch enabling AIO for NBD on the list [1], by >>> Nicholas Thomas (CCed), that lacked review so far. Can you guys please >>> re

[Qemu-devel] [RFC PATCH] Implement synthetic file system support in qemu using 9p

2011-09-09 Thread Aneesh Kumar K.V
This patchset implement a synthetic file system in qemu using 9p. The immediate goal is to get better error injection based testing for VirtFS server. But i guess other subsystem in qemu can use the framework to expose hypervisor data to guest. The framework also enables qemu subsytem to allow gu

[Qemu-devel] [RFC PATCH 3/3] hw/9pfs: Add synth fs test

2011-09-09 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-synth.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/virtio-9p-synth.c b/hw/9pfs/virtio-9p-synth.c index 72a916c..cbf74e4 100644 --- a/hw/9pfs/virtio-9p-synth.c +++ b/hw/9pfs/virtio-9p-syn

[Qemu-devel] [RFC PATCH 1/3] hw/9pfs: Abstract open state of fid to V9fsFidOpenState

2011-09-09 Thread Aneesh Kumar K.V
To implement synthetic file system in Qemu we may not really require file descriptor and Dir *. Make generic code use V9fsFidOpenState instead. Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h | 32 ++--- hw/9pfs/codir.c| 16 hw/9pfs/cofile.c

[Qemu-devel] [RFC PATCH 2/3] hw/9pfs: Add synthetic file system support using 9p

2011-09-09 Thread Aneesh Kumar K.V
This patch create a synthetic file system with mount tag v_synth when -virtfs_synth command line option is specified in qemu. The synthetic file system can be mounted in guest using 9p using the below command line mount -t 9p -oversion=9p2000.L,trans=virtio v_synth Synthetic file system enabled

Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 11:37 AM, Stefan Hajnoczi wrote: The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. Only one thing I'm unhappy about: the simpletrace write-out thread used to

Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 11:43, schrieb Alexander Graf: > > On 09.09.2011, at 11:15, Kevin Wolf wrote: > >> Am 08.09.2011 21:44, schrieb Stefan Weil: >>> Member variable is_read is written, but never read >>> (contrary to its name). >> >> Nice commit message :-) >> >>> Kevin Wolf >>> Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev

2011-09-09 Thread Kevin Wolf
Am 07.09.2011 17:20, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > dma-helpers.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dma-helpers.c b/dma-helpers.c > index 4610ea0..ca97e14 100644 > --- a/dma-helpers.c > +++ b/dma-helpers.c > @@ -

Re: [Qemu-devel] [PATCH 2/5] dma-helpers: allow including from target-independent code

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 01:39 PM, Kevin Wolf wrote: Am 07.09.2011 17:20, schrieb Paolo Bonzini: Target-independent code cannot construct sglists, but it can take them from the outside as a black box. Allow this. Signed-off-by: Paolo Bonzini I was hoping to find the use case for this somewhere in the r

[Qemu-devel] cross compiler for MIPS64

2011-09-09 Thread Khansa Butt
Hi I'm working on MIPS64 emulation and I need cross compiler for MIPS64. would you please guide me in this regard?. Is there any cross compiler exist or I have to make it from scratch? thanks

Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-09 Thread Kevin Wolf
Am 07.09.2011 17:21, schrieb Paolo Bonzini: > This fixes various problems with completion/cancellation: > > * If DMA encounters a bounce buffer conflict, and the DMA operation is > canceled before the bottom half fires, bad things happen. > > * memory is not unmapped after cancellation, again cau

Re: [Qemu-devel] [PATCH 2/5] dma-helpers: allow including from target-independent code

2011-09-09 Thread Kevin Wolf
Am 07.09.2011 17:20, schrieb Paolo Bonzini: > Target-independent code cannot construct sglists, but it can take > them from the outside as a black box. Allow this. > > Signed-off-by: Paolo Bonzini I was hoping to find the use case for this somewhere in the rest of the series, but there doesn't

Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-09 Thread Paolo Bonzini
> > @@ -120,9 +132,8 @@ static void dma_bdrv_cb(void *opaque, int ret) > > dbs->acb = dbs->io_func(dbs->bs, dbs->sector_num, &dbs->iov, > > dbs->iov.size / 512, dma_bdrv_cb, dbs); > > if (!dbs->acb) { > > -dma_bdrv_unmap(dbs); > > -qemu_iovec_d

Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 14:43, schrieb Paolo Bonzini: >>> @@ -120,9 +132,8 @@ static void dma_bdrv_cb(void *opaque, int ret) >>> dbs->acb = dbs->io_func(dbs->bs, dbs->sector_num, &dbs->iov, >>> dbs->iov.size / 512, dma_bdrv_cb, dbs); >>> if (!dbs->acb) { >>> -dm

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-09 Thread Marcelo Tosatti
On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote: > >>> --- a/arch/x86/include/asm/msr-index.h > >>> +++ b/arch/x86/include/asm/msr-index.h > >>> @@ -229,6 +229,8 @@ > >>> #define MSR_IA32_APICBASE_ENABLE (1<<11) > >>> #define MSR_IA32_APICBASE_BASE (0xf<<12) > >>> > >>

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-09 Thread Luiz Capitulino
On Tue, 06 Sep 2011 19:42:15 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Tue, 06 Sep 2011 17:55:12 +0200 > > Jan Kiszka wrote: > > >> On 2011-09-06 15:14, Luiz Capitulino wrote: > >> > This commit could have been folded with the previous one, however > >> > doing it separate

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-09 Thread Luiz Capitulino
On Thu, 1 Sep 2011 15:37:49 -0300 Luiz Capitulino wrote: > This series adds support to the block layer to keep track of devices' > I/O status. That information is also made available in QMP and HMP. ping? I'll have to rebase it anyway, but I'd like to know if the general approach is acceptable

[Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-09 Thread Stuart Yoder
Based on the discussions over the last couple of weeks I have updated the device fd file layout proposal and tried to specify it a bit more formally. === 1. Overview This specification describes the layout of device files used in t

Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 02:59 PM, Kevin Wolf wrote: Also, I think it should be -EIO instead of -ENOMEM (even though it doesn't make any difference if we don't call the callback) If I understood the code correctly, dbs->io_func can only fail if it fails to get an AIOCB, which is basically out-of-memory.

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-09 Thread Stuart Yoder
Meant to identify the changes in v2 of this proposal: v2: -removed PCI_INFO record type -removed PCI_BAR_INFO record type -PCI_CONFIG_SPACE is now a sub-record/property of a REGION -removed physical address from region and made it a subrecord/property of a REGION -added PCI_BAR_

Re: [Qemu-devel] [RESEND][PATCH] booke timers

2011-09-09 Thread Fabien Chouteau
On 09/09/2011 12:55, Alexander Graf wrote: > > On 09.09.2011, at 12:36, Fabien Chouteau wrote: > >> On 07/09/2011 21:59, Alexander Graf wrote: >>> >>> On 07.09.2011, at 16:41, Fabien Chouteau wrote: >>> On 06/09/2011 21:33, Alexander Graf wrote: > > > Am 01.09.2011 um 10:20 schri

[Qemu-devel] [PULL 0/4] xen: old bug fixes

2011-09-09 Thread Stefano Stabellini
Hi Anthony, I have few not very exiting xen bug fixes laying around that haven't been applied to master yet. None of them are new, some of them are more than an year old. Please pull (git branch based on 07ff2c4475df77e38a31d50ee7f3932631806c15): git://xenbits.xen.org/people/sstabellini/qemu-dm.

Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 15:12, schrieb Paolo Bonzini: > On 09/09/2011 02:59 PM, Kevin Wolf wrote: Also, I think it should be -EIO instead of -ENOMEM (even though it doesn't make any difference if we don't call the callback) >>> >>> If I understood the code correctly, dbs->io_func can only fail if i

[Qemu-devel] [PATCH 2/4] Move the xenfb pointer handler to the connected method

2011-09-09 Thread stefano.stabellini
From: John Haxby Ensure that we read "request-abs-pointer" after the frontend has written it. This means that we will correctly set up an ansolute or relative pointer handler correctly. Signed-off-by: John Haxby Signed-off-by: Stefano Stabellini --- hw/xenfb.c | 21 - 1

[Qemu-devel] [PATCH 3/4] xen: use uint64_t instead of target_ulong in cpu_ioreq_move

2011-09-09 Thread stefano.stabellini
From: Stefano Stabellini cpu_ioreq_move might move 8 bytes at a time so we must make sure that the temporary variable can hold 8 bytes. Signed-off-by: Stefano Stabellini --- xen-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xen-all.c b/xen-all.c index 9eaeac1.

[Qemu-devel] [PATCH 1/4] Introduce a new 'connected' xendev op called when Connected.

2011-09-09 Thread stefano.stabellini
From: John Haxby Rename the existing xendev 'connect' op to 'initialised' and introduce a new 'connected' op. This new op, if defined, is called when the backend is connected. Note that since there is no state transition this may be called more than once. Signed-off-by: John Haxby Signed-off-

[Qemu-devel] [PATCH 4/4] xen-mapcache: Fix rlimit set size.

2011-09-09 Thread stefano.stabellini
From: Anthony PERARD Previously, the address space soft limit was set mcache_max_size. So, before the mcache_max_size was reached by the mapcache, QEMU was killed for overuse of the virtual address space. This patch fix that by setting the soft limit the maximum than can have QEMU. So the soft a

Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 03:34 PM, Kevin Wolf wrote: So the release that we avoid is the release in the callback that may or may not be called indirectly by bdrv_aio_cancel. We always call dma_complete at the end of dma_aio_cancel so that it will be properly freed. In fact it may be worse than just the qe

Re: [Qemu-devel] [RESEND][PATCH] booke timers

2011-09-09 Thread Alexander Graf
On 09.09.2011, at 15:27, Fabien Chouteau wrote: > On 09/09/2011 12:55, Alexander Graf wrote: >> >> On 09.09.2011, at 12:36, Fabien Chouteau wrote: > >> >>> +} >>> + >>> +qemu_mod_timer(timer, *next); >>> +} >>> + >>> +static void booke_decr_cb(void *opaq

Re: [Qemu-devel] CFQ I/O starvation problem triggered by RHEL6.0 KVM guests

2011-09-09 Thread Stefan Hajnoczi
On Fri, Sep 9, 2011 at 10:00 AM, Takuya Yoshikawa wrote: > Vivek Goyal wrote: > >> So you are using both RHEL 6.0 in both host and guest kernel? Can you >> reproduce the same issue with upstream kernels? How easily/frequently >> you can reproduce this with RHEL6.0 host. > > Guests were CentOS6.0.

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-09 Thread Zhi Yong Wu
On Fri, Sep 9, 2011 at 6:38 PM, Stefan Hajnoczi wrote: > On Fri, Sep 09, 2011 at 05:44:36PM +0800, Zhi Yong Wu wrote: >> Today, i did some basical I/O testing, and suddenly found that qemu write >> and rw speed is so low now, my qemu binary is built on commit >> 344eecf6995f4a0ad1d887cec922f6806

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-09 Thread Stefan Hajnoczi
On Fri, Sep 9, 2011 at 2:48 PM, Zhi Yong Wu wrote: > On Fri, Sep 9, 2011 at 6:38 PM, Stefan Hajnoczi > wrote: >> On Fri, Sep 09, 2011 at 05:44:36PM +0800, Zhi Yong Wu wrote: >>> Today, i did some basical I/O testing, and suddenly found that qemu write >>> and rw speed is so low now, my qemu bina

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 15:54, schrieb Stefan Hajnoczi: > On Fri, Sep 9, 2011 at 2:48 PM, Zhi Yong Wu wrote: >> On Fri, Sep 9, 2011 at 6:38 PM, Stefan Hajnoczi >> wrote: >>> On Fri, Sep 09, 2011 at 05:44:36PM +0800, Zhi Yong Wu wrote: Today, i did some basical I/O testing, and suddenly found that qemu

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-09 Thread Zhi Yong Wu
On Fri, Sep 9, 2011 at 9:54 PM, Stefan Hajnoczi wrote: > On Fri, Sep 9, 2011 at 2:48 PM, Zhi Yong Wu wrote: >> On Fri, Sep 9, 2011 at 6:38 PM, Stefan Hajnoczi >> wrote: >>> On Fri, Sep 09, 2011 at 05:44:36PM +0800, Zhi Yong Wu wrote: Today, i did some basical I/O testing, and suddenly found

Re: [Qemu-devel] [RESEND][PATCH] booke timers

2011-09-09 Thread Fabien Chouteau
On 09/09/2011 15:46, Alexander Graf wrote: > > On 09.09.2011, at 15:27, Fabien Chouteau wrote: > >> On 09/09/2011 12:55, Alexander Graf wrote: >>> >>> On 09.09.2011, at 12:36, Fabien Chouteau wrote: >> >>> +} + +qemu_mod_timer(timer, *next); +}

Re: [Qemu-devel] [PATCH] support add-cow file format

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 07:48, schrieb Dong Xu Wang: > As raw file format does not support backing_file and copy on write feature, > so > I add COW to it to support backing_file option. I store dirty bitmap in an > add-cow file. When executed, it looks like this: > qemu-img create -f add-cow -o backing_fi

Re: [Qemu-devel] CFQ I/O starvation problem triggered by RHEL6.0 KVM guests

2011-09-09 Thread Vivek Goyal
On Fri, Sep 09, 2011 at 06:00:28PM +0900, Takuya Yoshikawa wrote: [..] > > > > > - Even if there are close cooperators, these queues are merged and they > > are treated as single queue from slice point of view. So cooperating > > queues should be merged and get a single slice instead of star

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-09-09 Thread Marcelo Tosatti
On Thu, Sep 08, 2011 at 06:11:07PM +0800, Zhi Yong Wu wrote: > Note: > 1.) When bps/iops limits are specified to a small value such as 511 > bytes/s, this VM will hang up. We are considering how to handle this senario. You can increase the length of the slice, if the request is larger than s

[Qemu-devel] [PATCH] scsi: fix sign extension problems

2011-09-09 Thread Paolo Bonzini
When assigning a 32-bit value to cmd->xfer (which is 64-bits) it can be erroneously sign extended because the intermediate 32-bit computation is signed. Fix this by standardizing on the ld*_be_p functions. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 22 +++--- 1 files cha

[Qemu-devel] [PATCH] scsi-generic: fix get_stream_blocksize

2011-09-09 Thread Paolo Bonzini
The computation of the block size is completely broken; mode page 0 is vendor specific. Use the right SCSI command instead. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c ind

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Nicholas Thomas
On 09/09/11 12:04, Kevin Wolf wrote: > Good to see agreement here. Do you think that Paolo's patches need to be > changed or can we do everything else on top? A few things have come up on a third read, actually. I'll respond in due course to the appropriate patch. > We do have some timer stubs i

Re: [Qemu-devel] [PATCH 11/12] nbd: switch to asynchronous operation

2011-09-09 Thread Nicholas Thomas
On 08/09/11 16:25, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/nbd.c | 167 ++ > nbd.c |8 +++ > 2 files changed, 117 insertions(+), 58 deletions(-) > > diff --git a/block/nbd.c b/block/nbd.c > index 964caa8

  1   2   >