From: Markus Armbruster
pci_piix3_xen_ide_unplug() unplugs only disks, not CD-ROMs. It peeks
into the DriveInfo's BlockDriverState to distinguish between the two.
Unclean; use DriveInfo member media_cd, like xen_config_dev_blk().
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
From: Fam Zheng
Add twoGbMaxExtentSparse support. Introduce vmdk_free_last_extent.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 133 --
1 files changed, 83 insertions(+), 50 deletio
From: Fam Zheng
Haiku provides a specially formed vmdk image, which let qemu abort. It a
combination of sparse header and flat data (i.e. with not l1/l2 table at
all). The fix is turn to descriptor when sparse header is zero in field
'capacity'.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajn
From: Frediano Ziglio
Add some notes about Linux AIO explaining why we don't use AIO in
some situations.
Signed-off-by: Frediano Ziglio
Signed-off-by: Kevin Wolf
---
block/raw-posix.c |4
linux-aio.c |1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/block
Requests depending on a failed request would end up waiting forever. This fixes
the error path to continue dependent requests even when the request has failed.
Signed-off-by: Kevin Wolf
---
block/qcow2.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c
From: Fam Zheng
Factor out read/write extent code, since there will be more things to
take care of once reading/writing compressed clusters is introduced.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 54 +
Need to ask the device, so this requires new BlockDevOps member
is_tray_open().
Signed-off-by: Markus Armbruster
---
block.c | 18 --
block.h |6 ++
hw/ide/core.c |6 ++
hw/scsi-disk.c |6 ++
qmp-commands.hx |2 ++
5 files changed,
This patch series looks bigger than it is. All the patches are small
and hopefully easy to review.
Objectives:
* Push BlockDriverState members locked, tray_open, media_changed into
device models, where they belong. Kevin picked the patches pushing
media_changed from v2, so that part's gone
From: Fam Zheng
Add support for reading/writing compressed extent.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 111 --
1 files changed, 100 insertions(+), 11 deletions(-)
diff --g
BlockDriverState member buffer_alignment is initially 512. The device
model may set them, with bdrv_set_buffer_alignment(). If the device
model gets detached (hot unplug), the device's alignment is left
behind. Only okay because device hot unplug automatically destroys
the BlockDriverState. But
MMC-5 6.40.2.6 specifies that START STOP UNIT succeeds when the drive
already has the requested state. cmd_start_stop_unit() fails when
asked to eject while the tray is open and locked. Fix that.
Signed-off-by: Markus Armbruster
---
hw/ide/atapi.c |2 +-
1 files changed, 1 insertions(+), 1
Signed-off-by: Markus Armbruster
---
block/nbd.c |1 +
nbd.c |1 +
nbd.h |2 --
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 55cb2fd..70edd81 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -28,6 +28,7 @@
#include "qemu-c
While there, make the locked parameter bool.
Signed-off-by: Markus Armbruster
---
block.c |8
block.h |2 +-
block/raw-posix.c |8
block/raw.c |6 +++---
block_int.h |2 +-
hw/ide/atapi.c|2 +-
hw/scsi-disk.c|2
BlockDriverState member removable is a confused mess. It is true when
an ide-cd, scsi-cd or floppy qdev is attached, or when the
BlockDriverState was created with -drive if={floppy,sd} or -drive
if={ide,scsi,xen,none},media=cdrom ("created removable"), except when
an ide-hd, scsi-hd, scsi-generic
Including it in device models is unclean, including it without a
reason adds insult to injury.
Signed-off-by: Markus Armbruster
---
hw/fdc.c|1 -
hw/ide/cmd646.c |1 -
hw/ide/ich.c|1 -
hw/ide/isa.c|1 -
hw/ide/macio.c |1 -
hw/ide/microdr
We already track it in BlockDriverState since commit 4be9762a. As
discussed in that commit's message, we should track it in the device
device models instead, because it's device state.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 9724d0f..c8ad2e7 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -814,6 +814,18 @@ static int scsi_disk_emulate_
Commit 4be9762a changed bdrv_is_inserted() to fail when the tray is
open. Unfortunately, there are two different kinds of users, with
conflicting needs.
1. Device models using bdrv_eject(), currently ide-cd and scsi-cd.
They expect bdrv_is_inserted() to reflect the tray status. Commit
4be9762a m
From: Markus Armbruster
savevm and loadvm silently ignore block devices with removable media,
such as floppies and SD cards. Rolling back a VM to a previous
checkpoint will *not* roll back writes to block devices with removable
media.
Moreover, bdrv_is_removable() is a confused mess, and wrong
No functional change.
It would be nice to have handler functions in the table, like commit
e1a064f9 did for ATAPI. Left for another day.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 105 +++-
1 files changed, 80 insertions(+), 25 del
change fails while the tray is locked by the guest. eject -f forces
it open and removes any media. Unfortunately, the tray closes again
instantly. Since the lock remains as it is, there is no way to insert
another medium unless the guest voluntarily unlocks.
Fix by leaving the tray open after m
Don't fail when tray is already open.
Signed-off-by: Markus Armbruster
---
hw/scsi-bus.c | 10 ++
hw/scsi-disk.c | 15 +++
hw/scsi.h |4
3 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 160eaee..79cb29d 100
Device models should be able to set it without an unclean include of
block_int.h.
Signed-off-by: Markus Armbruster
---
block.c |6 --
block.h |1 +
hw/ide/core.c |2 +-
hw/scsi-disk.c |2 +-
hw/virtio-blk.c |3 +--
5 files changed, 8 insertions(+), 6 de
From: Markus Armbruster
hw/fdc.c is the only one that cares.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
block.c | 20 ++--
block_int.h |1 -
hw/fdc.c| 40 ++--
3 files changed, 24 insertions(+), 37 deletio
It's a confused mess (see previous commit). No users remain.
Signed-off-by: Markus Armbruster
---
block.c |8
block.h |1 -
block_int.h |1 -
blockdev.c|5 -
hw/fdc.c |1 -
hw/ide/core.c |1 -
hw/scsi-disk.c
ACS-2 Table B.2 explicitly prohibits ATAPI devices from implementing
WIN_RECAL, WIN_READ_EXT, WIN_READDMA_EXT, WIN_READ_NATIVE_MAX,
WIN_MULTREAD_EXT, WIN_WRITE, WIN_WRITE_ONCE, WIN_WRITE_EXT,
WIN_WRITEDMA_EXT, WIN_MULTWRITE_EXT, WIN_WRITE_VERIFY, WIN_VERIFY,
WIN_VERIFY_ONCE, WIN_VERIFY_EXT, WIN_SPE
"eject" is misleading; it means "eject" when start is clear, but
"load" when start is set. Rename to loej, because that's how MMC-5
calls it, in section 6.40.
Signed-off-by: Markus Armbruster
---
hw/ide/atapi.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/i
Commit 4be9762a is now completely redone.
Signed-off-by: Markus Armbruster
---
block.c |1 -
block_int.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 6fe8add..8c86251 100644
--- a/block.c
+++ b/block.c
@@ -3062,7 +3062,6 @@ int bdrv_eje
On Tue, 06 Sep 2011 09:31:32 -0500, Anthony Liguori
wrote:
> On 09/06/2011 06:22 AM, Gerd Hoffmann wrote:
> > Hi,
> >
> > virtfs stopped working for me in master, the guest (fedora 15) just
> > hangs at boot when mounting the virtfs filesystems. Bisecting points to
> > this commit:
> >
> > rincew
We already track it in BlockDriverState. Just like tray open/close
state, we should track it in the device models instead, because it's
device state.
Signed-off-by: Markus Armbruster
---
hw/ide/atapi.c|4 +++-
hw/ide/internal.h |1 +
2 files changed, 4 insertions(+), 1 deletions(-)
From: Markus Armbruster
So we can more easily add device model callbacks.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
block.c | 43 +--
block.h |9 ++---
block_int.h |5 ++---
hw/ide/core.c |6 +
It's convenience stuff for block device models, so block.h isn't the
ideal home either, but better than block_int.h.
Permits moving some #include "block_int.h" from device model .h into
.c.
Signed-off-by: Markus Armbruster
---
block.h | 38 ++
blo
The QDict unit-tests (check-qdict) will fail when ran on a different
build directory. That's, it only works when ran on the source dir.
This happens because its data file (qdict-test-data.txt) is not
copied to the build dir. Fix it.
Signed-off-by: Luiz Capitulino
---
configure |2 +-
1 file
From: Paolo Bonzini
Writes go through scsi_write_complete at least twice, the first time
to get some data without having actually written anything. Because
of this, the first time scsi_write_complete is called it will call
bdrv_acct_done and account a read incorrectly. Fix this by looking
at th
From: Jan Kiszka
"\/" is supposed to be decoded as "/", but there is no need to encode
"/" via escape. Fix the existing test and add a second one expressing
this.
Signed-off-by: Jan Kiszka
Acked-by: Michael Roth
Signed-off-by: Luiz Capitulino
---
check-qjson.c |3 ++-
1 files changed, 2
On Tue, Sep 06, 2011 at 11:28:09AM -0500, Anthony Liguori wrote:
> On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote:
> >On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote:
> >>On 09/06/2011 10:45 AM, Jan Kiszka wrote:
> >>>On 2011-09-06 16:48, Michael S. Tsirkin wrote:
> I'm afraid
Use a subsection, so that migration to older version still works,
provided the tray is closed and unlocked.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
in
Anthony,
The following patches have been sent to the list and look good to me. I've
also tested them.
The changes (since 344eecf6995f4a0ad1d887cec922f6806f91a3f8) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Jan Kiszka (1):
Fix qjson test
We already track it in BlockDriverState since commit 4be9762a. As
discussed in that commit's message, we should track it in the device
device models instead, because it's device state.
Signed-off-by: Markus Armbruster
---
hw/ide/atapi.c|6 +-
hw/ide/internal.h |1 +
2 files chan
Must set the ATAPI device signature, see ATA4 8.27.5.2 Outputs for
PACKET Command feature set devices, and ACS-2 7.36.6 Outputs for
PACKET feature set devices.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/ide/co
On Tue, 06 Sep 2011 22:55:17 +0530, "Aneesh Kumar K.V"
wrote:
> On Tue, 06 Sep 2011 09:31:32 -0500, Anthony Liguori
> wrote:
> > On 09/06/2011 06:22 AM, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > virtfs stopped working for me in master, the guest (fedora 15) just
> > > hangs at boot when mounti
Requires new BlockDevOps member is_medium_locked(). Implement for IDE
and SCSI CD-ROMs.
Signed-off-by: Markus Armbruster
---
block.c| 16 +---
block.h|7 ++-
block_int.h|1 -
blockdev.c |2 +-
hw/ide/core.c |6 ++
hw/scsi-disk.c |
Luiz Capitulino writes:
> On Tue, 06 Sep 2011 17:55:12 +0200
> Jan Kiszka wrote:
>> On 2011-09-06 15:14, Luiz Capitulino wrote:
>> > This commit could have been folded with the previous one, however
>> > doing it separately will allow for easy bisect and revert if needed.
>> >
>> > Checking and
We already track it in BlockDriverState. Just like tray open/close
state, we should track it in the device models instead, because it's
device state.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/
The device model knows best when to accept the guest's eject command.
No need to detour through the block layer.
bdrv_eject() can't fail anymore. Make it void.
Signed-off-by: Markus Armbruster
---
block.c|7 +--
block.h|2 +-
hw/ide/atapi.c | 29 +-
To let device models distinguish between eject and load.
Signed-off-by: Markus Armbruster
---
block.c| 12 ++--
block.h|3 ++-
hw/fdc.c |2 +-
hw/ide/core.c |2 +-
hw/scsi-disk.c |2 +-
hw/sd.c|2 +-
6 files changed, 12 insertions(+),
Dear Customer,
We would like to introduce you
the good performance jetski, jetboat with the
original SUZUKI 1400CC engine.
we truthly believe in mind that
only our customer's success make us going further.
2011 model Jet Ski:
Model name: HSJ3A
Engine : 1400cc Suzuki
On Tue, Sep 6, 2011 at 18:19, octane indice wrote:
> En réponse à Stefan Hajnoczi :
>> You can run QEMU completely without a disk, just run:
>> $ gdb qemu
>> (gdb) r
>>
>> I wonder if it crashes that way too.
>>
> Yes:
> (gdb) r
> Starting program: /usr/src/qemu-0.15.0/i386-softmmu/qemu -vnc 127.
Am 01.09.2011 um 10:20 schrieb Fabien Chouteau :
> While working on the emulation of the freescale p2010 (e500v2) I realized that
> there's no implementation of booke's timers features. Currently mpc8544 uses
> ppc_emb (ppc_emb_timers_init) which is close but not exactly like booke (for
> exampl
Am 01.09.2011 um 16:56 schrieb Fabien Chouteau :
>
> Signed-off-by: Fabien Chouteau
Tanks, applied. But please add a patch description next time :)
Alex
The print function is listed in the vector table as 0xbfc00808. The backedge
of the loop is improperly encoded, and so jumps to 0xb814 instead of the
desired 0xbfc00814.
Signed-off-by: Andrew Drake
---
hw/mips_malta.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
On 09/04/2011 03:32 PM, Michael S. Tsirkin wrote:
On Thu, Sep 01, 2011 at 09:53:40PM -0400, Stefan Berger wrote:
Generally, what all other devices do is perform validation
as the last step in migration when device state
is restored. On failure, management can decide what to do:
retry migration o
On 09/04/2011 12:58 PM, Michael S. Tsirkin wrote:
On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote:
Checks are added that test
- whether encryption is supported follwing the revision of the directory
structure (rev>= 2)
You never generate rev 1 code, right?
I did this in the pr
On 09/04/2011 12:38 PM, Michael S. Tsirkin wrote:
On Thu, Sep 01, 2011 at 11:00:56PM -0400, Stefan Berger wrote:
initstate_fd=
initstate_base64=on/off (or base64/bin if you really expect
more formats in the future)
and use qemu routines to get the fd so they can be
passed through the mo
The Buildbot has detected a new failure on builder qmp_x86_64_debian_6_0 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/qmp_x86_64_debian_6_0/builds/23
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
Build Rea
Add --disable-debug-symbols to disable building with debug
symbols and --optflags to override the optimization flags
passed to the compiler.
---
configure | 18 +++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c3044c7..c7948b6 100755
Hi,
Sometime back I posted a patch for fixing x86 CPU topology (
http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02022.html).
Here is the next version of the fix which addresses all but one
comment received during that post.
- Fixed code style issues
- Ensured that the fix doesn't break T
At 09/06/2011 03:45 PM, Avi Kivity Write:
> On 09/06/2011 06:06 AM, Wen Congyang wrote:
>> > Use the uio driver -
>> > http://docs.blackfin.uclinux.org/kernel/generated/uio-howto/. You
>> just
>> > mmap() the BAR from userspace and play with it.
>>
>> When I try to bind ivshmem to uio_pci_gener
On 09/06/2011 08:50 PM, malc wrote:
> Correct me if i'm wrong, previously the code worked like this:
>
> mov tmp, 0
> sub tmp, 1
> sar r, r, tmp
>
> Still UB as far as TCG is concerned but since no immediates are involved
> things worked, now, with constant folding, we are asked to sar by -1
> d
On Sat, Jul 16, 2011 at 12:27 AM, Luiz Capitulino
wrote:
> On Fri, 15 Jul 2011 09:15:18 +0800
> Zhi Yong Wu wrote:
>
>> On Fri, Jul 15, 2011 at 4:00 AM, Michael Roth
>> wrote:
>> > This is Set 3/3 of the QAPI+QGA patchsets.
>> >
>> > These patches apply on top of qapi-backport-set2-v6, and can
101 - 160 of 160 matches
Mail list logo
