[Qemu-devel] [PATCH] scsi: execute SYNCHRONIZE_CACHE asynchronously

Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 41 + 1 files changed, 25 insertions(+), 16 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 3ffd536..c23c2b8 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -130,6 +130,24 @@ static vo

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

On 09/06/2011 06:06 AM, Wen Congyang wrote: > Use the uio driver - > http://docs.blackfin.uclinux.org/kernel/generated/uio-howto/. You just > mmap() the BAR from userspace and play with it. When I try to bind ivshmem to uio_pci_generic, I get the following messages: uio_pci_generic :01:0

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

On 09/05/2011 10:36 PM, Blue Swirl wrote: > I don't agree. That's not what qemu_irq represents. > It represents a wire, a mechanism to drive changes through logic paths > between state. It is intrinsically stateless. > > It may be the case that it is missused in some places, or that it isn't

Re: [Qemu-devel] new memory api: offsets?

On 09/01/2011 01:00 PM, Michael Walle wrote: Am Donnerstag 01 September 2011, 07:54:28 schrieb Avi Kivity: > On 09/01/2011 01:54 AM, Michael Walle wrote: > > Hi Avi, > > > > while debugging, i noticed, that mr->offset is never set, expect in the > > initializer. (The subregion collision w

[Qemu-devel] [PATCH] docs: Fix qdev-device-use.txt typo in -chardev serial, path=COM

Signed-off-by: Markus Armbruster --- docs/qdev-device-use.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index 057c322..136d271 100644 --- a/docs/qdev-device-use.txt +++ b/docs/qdev-device-use.txt @@ -208,7 +208,7

[Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

Only build with -g CFLAGS/LDFLAGS if using --enable-debug. Add --optflags to allow overriding the default optimization level added to CFLAGS. This is a first draft of coming up with a patch I could potentially push upstream based on much cruder local patches to do something similar. I'm trying to

Re: [Qemu-devel] qemu segfaults at start

En réponse à Stefan Hajnoczi : > > qemu disk.img > > Segmentation fault > > Please post the backtrace as well as your host operating > system > version (e.g. Fedora 15): > > gdb --args qemu disk.img > (gdb) r > ...runs and crashes... > (gdb) bt > Thanks for the help, here the infos: I run under

Re: [Qemu-devel] qemu segfaults at start

Am 06.09.2011 10:11, schrieb octane indice: $ gdb --args qemu disk.img -vnc 127.0.0.1:1 GNU gdb (GDB) 7.1 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

On Tue, Sep 06, 2011 at 08:55:42AM +0200, Paolo Bonzini wrote: > On 09/06/2011 05:12 AM, David Gibson wrote: > >I'm not "fixing ppc". I'm fixing a fundamental flaw in the protocol > >implementation._So far_ I've only observed the effects on ppc, but > >that doesn't mean they don't exist. > > Act

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

Gerd Hoffmann writes: > Hi, > >>> Looking... qdev_device_help() shows only device properties, not bus >>> properties. I'd call that a bug. >> >> Hmm, but is "bus" a bus property? > > It isn't. bus= is handled by qdev core (id= too). addr= actually is > a (pci) bus property. bus is indeed t

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

On 6 September 2011 09:02, Brad wrote: > Only build with -g CFLAGS/LDFLAGS if using --enable-debug. I'm not convinced -- I think we should always build with -g; it means you can do at least some debugging on an in-tree build even if it's the optimised version. Debug info should be stripped at ins

Re: [Qemu-devel] qemu segfaults at start

On Tue, Sep 6, 2011 at 9:11 AM, octane indice wrote: > En réponse à Stefan Hajnoczi : > -In order to prove it's not related to the disk used, I create an empty one > for > the purpose: > $ dd if=/dev/zero of=disk.img bs=1024k count=1 You can run QEMU completely without a disk, just run: $ gdb q

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

On 09/06/2011 09:55 AM, Paolo Bonzini wrote: On 09/06/2011 05:12 AM, David Gibson wrote: I'm not "fixing ppc". I'm fixing a fundamental flaw in the protocol implementation._So far_ I've only observed the effects on ppc, but that doesn't mean they don't exist. Actually Michael is right. The

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

On Tue, Sep 06, 2011 at 12:28:40PM +0300, Avi Kivity wrote: > On 09/06/2011 09:55 AM, Paolo Bonzini wrote: > >On 09/06/2011 05:12 AM, David Gibson wrote: > >>I'm not "fixing ppc". I'm fixing a fundamental flaw in the protocol > >>implementation._So far_ I've only observed the effects on ppc, but

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

On 09/06/2011 11:28 AM, Avi Kivity wrote: Actually Michael is right. The implementation is correct on x86, though wrong anywhere else (perhaps s390?). On those architectures you do not need rmb() and wmb(). Are we sure? Nothing prevents the guest from using weakly-ordered writes, is there?

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

On 09/06/11 10:02, Brad wrote: Only build with -g CFLAGS/LDFLAGS if using --enable-debug. Add --optflags to allow overriding the default optimization level added to CFLAGS. This is a first draft of coming up with a patch I could potentially push upstream based on much cruder local patches to do

[Qemu-devel] [PATCH] scsi: refine constants for READ CAPACITY 16

Rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16 to distinguish from the 12-byte CDB variant, and add a constant for the subcommand. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |3 ++- hw/scsi-defs.h |8 +++- hw/scsi-disk.c |6 +++--- 3 files changed, 12 insertions(+), 5 dele

[Qemu-devel] [PATCH] scsi: fill in additional sense length correctly

Even though we do not use them, we should include the last three bytes of sense data in the additional sense length. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 80b8802..96d6305 1006

[Qemu-devel] [PATCH] scsi: improve MODE SENSE emulation

- do not return extra pages when requesting all pages (PAGE CODE = 0x3f) - return correct sense code for PC = 3 (saved parameters not supported) - do not return geometry pages for CD devices Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 96 +++-

[Qemu-devel] 50 euros offerts pour démarrer votre campagne Google AdWords

Affichez correctement cet email. Vous souhaitez apparaître sur la page de résultats de Google lorsqu'un utilisateur recherche vos produits ou services ? Essayez GRATUITEMENT le programme publicitaire AdWords de Google qui vous permet de publier vos annonces en ligne à côté des résult

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

On 6 September 2011 09:02, Brad wrote: > @@ -937,6 +940,7 @@ echo "  --cross-prefix=PREFIX    use PREFIX for compile > tools [$cross_prefix]" >  echo "  --cc=CC                  use C compiler CC [$cc]" >  echo "  --host-cc=CC             use C compiler CC [$host_cc] for code run > at" >  echo "

Re: [Qemu-devel] [PATCH v3 2/8] VMDK: add twoGbMaxExtentSparse support

Am 12.08.2011 17:19, schrieb Fam Zheng: > Add twoGbMaxExtentSparse support. Introduce vmdk_free_last_extent. > > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 133 > -- > 1 files changed, 83 insertions(+), 50 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support

Am 05.09.2011 10:15, schrieb Stefan Hajnoczi: > On Fri, Aug 12, 2011 at 11:19:26PM +0800, Fam Zheng wrote: >> Changes: >> 02/06: Free extents on fail in vmdk_open. >> >> Added: >> 07/08: VMDK: bugfix, open Haiku vmdk image >> 08/08: VMDK: bugfix, opening vSphere 4 exported image >>

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

On 05/09/2011 21:22, Blue Swirl wrote: > On Mon, Sep 5, 2011 at 9:33 AM, Fabien Chouteau wrote: >> On 03/09/2011 11:25, Blue Swirl wrote: >>> On Thu, Sep 1, 2011 at 2:17 PM, Fabien Chouteau >>> wrote: Gdb expects all registers windows to be flushed in ram, which is not the case i

[Qemu-devel] [PATCH v7 0/4] The intro of QEMU block I/O throttling

The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue for

[Qemu-devel] [PATCH v7 1/4] block: add the command line support

Signed-off-by: Zhi Yong Wu --- block.c |8 block_int.h | 30 ++ blockdev.c | 29 + blockdev.h |2 ++ qemu-config.c | 24 qemu-options.hx |1 + 6 files changed, 94 in

[Qemu-devel] [PATCH v7 2/4] block: add the block queue support

Signed-off-by: Zhi Yong Wu --- Makefile.objs |2 +- block/blk-queue.c | 184 + block/blk-queue.h | 59 + 3 files changed, 244 insertions(+), 1 deletions(-) create mode 100644 block/blk-queue.c create mode 100644 bloc

[Qemu-devel] [PATCH v7 3/4] block: add block timer and throttling algorithm

Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When "dd" command is issued in guest, if its option bs is set to a large value such as "bs=1024K", the result speed will slightly b

[Qemu-devel] [PATCH v7 4/4] qmp/hmp: add block_set_io_throttle

The patch introduce one new command block_set_io_throttle; For its usage syntax, if you have better idea, pls let me know. Signed-off-by: Zhi Yong Wu --- block.c | 26 -- hmp-commands.hx | 15 +++ qerror.c|4 qerror.h|

Re: [Qemu-devel] [PATCH] scsi: execute SYNCHRONIZE_CACHE asynchronously

Am 06.09.2011 09:08, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/scsi-disk.c | 41 + > 1 files changed, 25 insertions(+), 16 deletions(-) Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] scsi: fix accounting of writes

Am 05.09.2011 18:11, schrieb Paolo Bonzini: > Writes go through scsi_write_complete at least twice, the first time > to get some data without having actually written anything. Because > of this, the first time scsi_write_complete is called it will call > bdrv_acct_done and account a read incorrect

Re: [Qemu-devel] qemu segfaults at start

En réponse à Stefan Weil : > /usr/local/bin/qemu is stripped because it was installed with > make install, > so there is no useful debugging information. > > Please look for the unstripped i386-softmmu/qemu executable in > your build path and run it using gdb. > $ gdb --args /usr/src/qemu-0.15.0

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

Thanks Avi, Marcelo, Kevin for comments, sorry for late reply (just come back from vacation). Avi Kivity wrote: > On 08/17/2011 07:19 AM, Liu, Jinsong wrote: >> From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 >> 2001 >> From: Liu, Jinsong >> Date: Wed, 17 Aug 2011 11:36:28 +0

Re: [Qemu-devel] qemu segfaults at start

En réponse à Stefan Hajnoczi : > You can run QEMU completely without a disk, just run: > $ gdb qemu > (gdb) r > > I wonder if it crashes that way too. > Yes: (gdb) r Starting program: /usr/src/qemu-0.15.0/i386-softmmu/qemu -vnc 127.0.0.1:1 [Thread debugging using libthread_db enabled] Program r

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

Marcelo Tosatti wrote: >>> --- a/arch/x86/include/asm/msr-index.h >>> +++ b/arch/x86/include/asm/msr-index.h >>> @@ -229,6 +229,8 @@ >>> #define MSR_IA32_APICBASE_ENABLE (1<<11) >>> #define MSR_IA32_APICBASE_BASE (0xf<<12) >>> >>> +#define MSR_IA32_TSCDEADLINE 0x0

[Qemu-devel] glib mainloop breaks virtfs

Hi, virtfs stopped working for me in master, the guest (fedora 15) just hangs at boot when mounting the virtfs filesystems. Bisecting points to this commit: rincewind kraxel ~/projects/qemu ((69e5bb6...)|BISECTING)# git bisect good 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2 is the first bad

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

On 09/06/2011 02:18 PM, Liu, Jinsong wrote: >>struct x86_instruction_info *info, >>enum x86_intercept_stage stage); >> + u64 (*guest_to_host_tsc)(u64 guest_tsc); >>}; > > Please put this near the other tsc functions. Add a comment > expl

[Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels

Alex, Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x1. (e.g. current linux-next). We must not rely on specific code at certain addresses, so lets just remove this check. Reported-by: Philipp Muens Signed-off-by: Christian Borntraeger --- hw/s390-virtio.c |5 -

[Qemu-devel] [PATCH 1/9] Move vm_state_notify() prototype from cpus.h to sysemu.h

It's where all the state handling functions prototypes are located. Signed-off-by: Luiz Capitulino --- cpus.h |1 - sysemu.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.h b/cpus.h index f42b54e..5885885 100644 --- a/cpus.h +++ b/cpus.h @@ -15,7 +15,6 @@ vo

[Qemu-devel] [PATCH v4 0/9]: Introduce the RunState type

It replaces the VMSTOP macros and allows us to drop some global variables. Additionally, the problem with issuing 'cont' when the VM is in bad state is addressed and we make the current state available in QMP and HMP. ** IMPORTANT: patch 04/09 is a new addition, it needs careful review. changelo

[Qemu-devel] [PATCH 6/9] Drop the vm_running global variable

Use runstate_is_running() instead, which is introduced by this commit. Signed-off-by: Luiz Capitulino --- cpus.c|9 - gdbstub.c |4 ++-- hw/etraxfs_dma.c |2 +- hw/kvmclock.c |2 +- hw/virtio.c |2 +- migration.c |2 +- monitor

[Qemu-devel] [PATCH 5/9] Drop the incoming_expected global variable

Test against RSTATE_IN_MIGRATE instead. Please, note that the RSTATE_IN_MIGRATE state is only set when all the initial VM setup is done, while 'incoming_expected' was set right in the beginning when parsing command-line options. Shouldn't be a problem as far as I could check. Signed-off-by: Luiz

[Qemu-devel] [PATCH 2/9] Replace the VMSTOP macros with a proper state type

Today, when notifying a VM state change with vm_state_notify(), we pass a VMSTOP macro as the 'reason' argument. This is not ideal because the VMSTOP macros tell why qemu stopped and not exactly what the current VM state is. One example to demonstrate this problem is that vm_start() calls vm_state

[Qemu-devel] [PATCH 7/9] Monitor/QMP: Don't allow cont on bad VM state

We have two states where issuing cont before system_reset can cause problems: RSTATE_SHUTDOWN (when -no-shutdown is used) and RSTATE_PANICKED (which only happens with kvm). This commit fixes that by doing the following when state is RSTATE_SHUTDOWN or RSTATE_PANICKED: 1. returning an error to th

[Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

This commit could have been folded with the previous one, however doing it separately will allow for easy bisect and revert if needed. Checking and testing all valid transitions wasn't trivial, chances are this will need broader testing to become more stable. Signed-off-by: Luiz Capitulino ---

[Qemu-devel] [PATCH] linux-user: Exit with an error if we couldn't set up gdbserver

If gdbserver_start() fails (usually because we couldn't bind to the requested TCP port) then exit qemu rather than blithely continuing. This brings the linux-user behaviour in to line with system mode. Signed-off-by: Peter Maydell --- linux-user/main.c |6 +- 1 files changed, 5 insertion

Re: [Qemu-devel] [PATCH 3/8] RunState: Add additional states

On Fri, 2 Sep 2011 11:28:18 -0300 Luiz Capitulino wrote: > On Thu, 01 Sep 2011 22:58:51 +0200 > Jan Kiszka wrote: > > > On 2011-09-01 20:39, Luiz Capitulino wrote: > > > On Thu, 01 Sep 2011 20:30:57 +0200 > > > Jan Kiszka wrote: > > > > > >> On 2011-09-01 20:12, Luiz Capitulino wrote: > > >>>

[Qemu-devel] [PATCH 8/9] QMP: query-status: Introduce 'status' key

This new key reports the current VM status to clients. Please, check the documentation being added in this commit for more details. Signed-off-by: Luiz Capitulino --- monitor.c |3 +-- qmp-commands.hx | 19 ++- sysemu.h|1 + vl.c| 23

[Qemu-devel] [PATCH 3/9] RunState: Add additional states

Currently, only vm_start() and vm_stop() change the VM state. That's, the state is only changed when starting or stopping the VM. This commit adds the runstate_set() function, which makes it possible to also do state transitions when the VM is stopped or running. Additional states are also added

Re: [Qemu-devel] [PATCH] scsi: refine constants for READ CAPACITY 16

Am 06.09.2011 12:31, schrieb Paolo Bonzini: > Rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16 to distinguish > from the 12-byte CDB variant, and add a constant for the subcommand. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] scsi: fill in additional sense length correctly

Am 06.09.2011 12:31, schrieb Paolo Bonzini: > Even though we do not use them, we should include the last three > bytes of sense data in the additional sense length. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] scsi: improve MODE SENSE emulation

Am 06.09.2011 12:31, schrieb Paolo Bonzini: > - do not return extra pages when requesting all pages (PAGE CODE = 0x3f) > > - return correct sense code for PC = 3 (saved parameters not supported) > > - do not return geometry pages for CD devices > > Signed-off-by: Paolo Bonzini Thanks, applied

[Qemu-devel] [PATCH 9/9] HMP: info status: Print the VM state

Today our printf format for the "info status" command is: VM status: %s Where the string can be "running", "running (single step mode)" or "paused". This commit extends it to: VM status: %s (%s) The second string corresponds to the "status" field as returned by the query-status QMP command

Re: [Qemu-devel] KVM call agenda for September 6

Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. To agenda items. Anthony off. Call got cancelled. Happy hacking, Juan.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] docs: Fix qdev-device-use.txt typo in -chardev serial, path=COM

On Tue, Sep 06, 2011 at 10:01:36AM +0200, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > docs/qdev-device-use.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/shortlo

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Avoid duplicate flags when calling compile_prog

On Sun, Sep 04, 2011 at 06:30:02PM +0200, Stefan Weil wrote: > This patch removes redundant shell code and cleans it a little bit. > > Shell macro compile_prog takes two arguments: > local_cflags and local ldflags. > > $QEMU_CFLAGS is added automatically to the cflags, so there is no need > to pa

Re: [Qemu-devel] [Qemu-trivial] [PATCH] docs: Fix qdev-device-use.txt typo in -chardev serial, path=COM

On Tue, Sep 06, 2011 at 10:01:36AM +0200, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > docs/qdev-device-use.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/shortlo

Re: [Qemu-devel] [PATCH] qemu-options: Improve help texts for options which depend on configure

On Mon, Sep 05, 2011 at 06:13:03PM +0200, Stefan Weil wrote: > * Replace "available only" by the more common "only available". > > * Tracing options depend on the configuration of the QEMU executable, > so clarify the help text for both options. > > Cc: Stefan Hajnoczi > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

On Mon, Sep 05, 2011 at 07:45:36PM +, Blue Swirl wrote: > On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi > wrote: > > String arguments are useful for producing human-readable traces without > > post-processing (e.g. stderr backend).  Although the simple backend > > cannot handles strings all

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

On 08/22/2011 03:47 PM, Paolo Bonzini wrote: On 08/22/2011 03:45 PM, Anthony Liguori wrote: Almost: in Win32 you need to use g_io_channel_win32_new_socket. But indeed on Windows you can only use qemu_set_fd_handler for sockets too. I think that's really only for read/write though. If you're j

Re: [Qemu-devel] glib mainloop breaks virtfs

On 09/06/2011 06:22 AM, Gerd Hoffmann wrote: Hi, virtfs stopped working for me in master, the guest (fedora 15) just hangs at boot when mounting the virtfs filesystems. Bisecting points to this commit: rincewind kraxel ~/projects/qemu ((69e5bb6...)|BISECTING)# git bisect good 4d88a2ac8643265108

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On Fri, Aug 26, 2011 at 04:48:10PM +0200, Jan Kiszka wrote: > More than one year ago I posted some patches to add a monitor command > callend device_show. The purpose of that command is to dump the state of > some qdev device based on its vmstate. > > To improve the usability of that interface, th

Re: [Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

On Mon, Sep 05, 2011 at 09:48:21PM +0530, M. Mohan Kumar wrote: > Qemu need to be invoked by root user for using virtfs with passthrough > security model (i.e to use chroot() syscall). > > Question is: Is running qemu by root user expected and allowed? Some of the > virtfs features can be utilized

Re: [Qemu-devel] TCG sar UB (fwd)

On 09/04/2011 08:03 AM, malc wrote: > On Sun, 4 Sep 2011, Richard Henderson wrote: > >> On 09/03/2011 03:47 PM, malc wrote: >>> Doesn't make much sense to me, guest clearly asked for 0 and not -1, >>> besides -1 violates TCG's sar constraints and PPC obliges by emiting >>> illegal instruction in t

Re: [Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

Sorry, I forgot to include Daniel Berrange who might have thoughts about a nice way of running the privileged virtfs helper and how to integrate with libvirt. On Tue, Sep 6, 2011 at 3:48 PM, Stefan Hajnoczi wrote: > On Mon, Sep 05, 2011 at 09:48:21PM +0530, M. Mohan Kumar wrote: >> Qemu need to b

Re: [Qemu-devel] TCG sar UB (fwd)

On Tue, 6 Sep 2011, Richard Henderson wrote: > On 09/04/2011 08:03 AM, malc wrote: > > On Sun, 4 Sep 2011, Richard Henderson wrote: > > > >> On 09/03/2011 03:47 PM, malc wrote: > >>> Doesn't make much sense to me, guest clearly asked for 0 and not -1, > >>> besides -1 violates TCG's sar constrain

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

We're affected by this bug, too. Trying to find a workaround, last friday we changed VGA model to cirrus, and the machine is working properly without new entries in log. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

[Qemu-devel] [PATCH 04/31] async: Allow nested qemu_bh_poll calls

qemu may segfault when a BH handler first deletes a BH and then (possibly indirectly) calls a nested qemu_bh_poll(). This is because the inner instance frees the BH and deletes it from the list that the outer one processes. This patch deletes BHs only in the outermost qemu_bh_poll instance. Commi

[Qemu-devel] [PATCH 02/31] qcow2: Properly initialise QcowL2Meta

Dependency list pointers filled with random garbage from the stack aren't a good idea. Signed-off-by: Kevin Wolf --- block/qcow2.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index b725d68..f26f7b6 100644 --- a/block/qcow2.c +++ b/bl

[Qemu-devel] [PATCH 29/31] scsi: refine constants for READ CAPACITY 16

From: Paolo Bonzini Rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16 to distinguish from the 12-byte CDB variant, and add a constant for the subcommand. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/scsi-bus.c |3 ++- hw/scsi-defs.h |8 +++- hw/scsi-disk.c |6

[Qemu-devel] [PATCH 17/31] spitz tosa: Simplify "drive is suitable for microdrive" test

From: Markus Armbruster We try the drive defined with -drive if=ide,index=0 (or equivalent sugar). We use it only if (dinfo && bdrv_is_inserted(dinfo->bdrv) && !bdrv_is_removable(dinfo->bdrv)). This is a convoluted way to test for "drive media can't be removed". The only way to create such a d

[Qemu-devel] [PATCH 27/31] scsi: execute SYNCHRONIZE_CACHE asynchronously

From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 41 + 1 files changed, 25 insertions(+), 16 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 3cc830f..5c652a2 100644 --- a/hw/scsi-disk.c ++

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 2011-09-06 16:48, Michael S. Tsirkin wrote: > On Fri, Aug 26, 2011 at 04:48:10PM +0200, Jan Kiszka wrote: >> More than one year ago I posted some patches to add a monitor command >> callend device_show. The purpose of that command is to dump the state of >> some qdev device based on its vmstate.

[Qemu-devel] [PATCH 22/31] VMDK: Opening compressed extent.

From: Fam Zheng Added flags field for compressed/streamOptimized extents, open and save image configuration. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/vmdk.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 09/06/2011 10:45 AM, Jan Kiszka wrote: On 2011-09-06 16:48, Michael S. Tsirkin wrote: I'm afraid that won't be enough to stop people scripting this command - libvirt accessed HMP for years. On the other hand, no QMP command means e.g. libvirt users don't get any benefit from this. What I th

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

On 2011-09-06 15:14, Luiz Capitulino wrote: > This commit could have been folded with the previous one, however > doing it separately will allow for easy bisect and revert if needed. > > Checking and testing all valid transitions wasn't trivial, chances > are this will need broader testing to beco

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

On 09/06/2011 09:31 AM, Paolo Bonzini wrote: On 08/22/2011 03:47 PM, Paolo Bonzini wrote: On 08/22/2011 03:45 PM, Anthony Liguori wrote: Almost: in Win32 you need to use g_io_channel_win32_new_socket. But indeed on Windows you can only use qemu_set_fd_handler for sockets too. I think that's

[Qemu-devel] [PATCH 08/31] ide: Update command code definitions as per ACS-2 Table B.2

From: Markus Armbruster Drop WIN_SRST, it has the same value as WIN_DEVICE_RESET. Drop unused WIN_RESTORE, it has the same value as WIN_RECAL. Drop codes that are not implemented and long obsolete: WIN_READ_LONG, WIN_READ_LONG_ONCE, WIN_WRITE_LONG, WIN_WRITE_LONG_ONCE, WIN_FORMAT (all obsolete

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 2011-09-06 17:51, Anthony Liguori wrote: > I'm still contemplating how we go about doing this. This series > introduces a couple new concepts like QMP class hinting anonymous IDs. > I'm concerned that we'll further complicate the need to support > backwards compatibility. Anonymous IDs must

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: > On 09/06/2011 10:45 AM, Jan Kiszka wrote: > >On 2011-09-06 16:48, Michael S. Tsirkin wrote: > >>I'm afraid that won't be enough to stop people > >>scripting this command - libvirt accessed > >>HMP for years. > >> > >>On the other ha

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 09/06/2011 11:05 AM, Jan Kiszka wrote: On 2011-09-06 17:51, Anthony Liguori wrote: I'm still contemplating how we go about doing this. This series introduces a couple new concepts like QMP class hinting anonymous IDs. I'm concerned that we'll further complicate the need to support backwards

[Qemu-devel] [PATCH 26/31] VMDK: bugfix, opening vSphere 4 exported image

From: Fam Zheng The vSphere 4 exported image is streamOptimized extent, which is not quite correctly handled. Ignore rdgOffset when RGD flag bit not set. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/vmdk.c |9 +++-- 1 files changed, 7 inse

[Qemu-devel] [PATCH 05/31] block: Attach non-qdev devices as well

From: Markus Armbruster For now, this just protects against programming errors like having the same drive back multiple non-qdev devices, or untimely bdrv_delete(). Later commits will add other interesting uses. While there, rename BlockDriverState member peer to dev, bdrv_attach() to bdrv_attac

[Qemu-devel] [PULL 00/31] Block patches

The following changes since commit f69539b14bdba7a5cd22e1f4bed439b476b17286: apb_pci: convert PCI space to memory API (2011-09-04 09:28:04 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Fam Zheng (8): VMDK: enable twoGbMaxExtentFlat VMD

[Qemu-devel] [PATCH 18/31] block: Declare qemu_blockalign() in block.h, not block_int.h

From: Markus Armbruster Device models should be able to use it without an unclean include of block_int.h. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.h |2 ++ block_int.h |2 -- hw/sd.c |1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff -

[Qemu-devel] [PATCH 19/31] VMDK: enable twoGbMaxExtentFlat

From: Fam Zheng Enable the createType 'twoGbMaxExtentFlat'. The supporting code is already in. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/vmdk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmd

[Qemu-devel] [PATCH 13/31] fdc: Make media change detection more robust

From: Markus Armbruster fdctrl_change_cb() gets called on a virtual media change via monitor. It would be nice if host device block drivers called it on physical media change, but they don't. bdrv_media_changed() lets you poll for media change, but it returns "don't know" except with block drive

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

- Original message - > On 09/06/11 10:02, Brad wrote: > > Only build with -g CFLAGS/LDFLAGS if using --enable-debug. > > Add --optflags to allow overriding the default optimization > > level added to CFLAGS. > > > > This is a first draft of coming up with a patch I could potentially > > pu

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: On 09/06/2011 10:45 AM, Jan Kiszka wrote: On 2011-09-06 16:48, Michael S. Tsirkin wrote: I'm afraid that won't be enough to stop people scripting this command - libvirt accessed H

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 2011-09-06 18:09, Michael S. Tsirkin wrote: > On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: >> On 09/06/2011 10:45 AM, Jan Kiszka wrote: >>> On 2011-09-06 16:48, Michael S. Tsirkin wrote: I'm afraid that won't be enough to stop people scripting this command - libvirt

[Qemu-devel] [PATCH 31/31] scsi: improve MODE SENSE emulation

From: Paolo Bonzini - do not return extra pages when requesting all pages (PAGE CODE = 0x3f) - return correct sense code for PC = 3 (saved parameters not supported) - do not return geometry pages for CD devices Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 96

[Qemu-devel] [PATCH 14/31] block: Clean up bdrv_flush_all()

From: Markus Armbruster Change (!bdrv_is_removable(bs) || bdrv_is_inserted(bs)) to just bdrv_is_inserted(). Rationale: The value of bdrv_is_removable(bs) matters only when bdrv_is_inserted(bs) is false. bdrv_is_inserted(bs) is true when bs is open (bs->drv != NULL) and not an e

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

On 2011-09-06 18:08, Anthony Liguori wrote: > On 09/06/2011 11:05 AM, Jan Kiszka wrote: >> On 2011-09-06 17:51, Anthony Liguori wrote: >>> I'm still contemplating how we go about doing this. This series >>> introduces a couple new concepts like QMP class hinting anonymous IDs. >>> I'm concerned th

[Qemu-devel] [PATCH 24/31] VMDK: creating streamOptimized subformat

From: Fam Zheng Creating streamOptimized subformat. Added subformat option 'streamOptimized', to create a image with compression enabled and each cluster with a GrainMarker. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/vmdk.c | 18 --

[Qemu-devel] [PATCH 09/31] ide: Clean up case label indentation in ide_exec_cmd()

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index d1cbfe7..ff59a45 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -979,7

[Qemu-devel] [PATCH 10/31] ide: Give vmstate structs internal linkage where possible

From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index ff59a45..1806e00 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2010,7 +201

[Qemu-devel] [PATCH 11/31] block/raw: Fix to forward method bdrv_media_changed()

From: Markus Armbruster Block driver "raw" forwards most methods to the underlying block driver. However, it doesn't implement method bdrv_media_changed(). Makes bdrv_media_changed() always return -ENOTSUP. I believe -fda /dev/fd0 gives you raw over host_floppy, and disk change detection (fdc r

[Qemu-devel] [PATCH 30/31] scsi: fill in additional sense length correctly

From: Paolo Bonzini Even though we do not use them, we should include the last three bytes of sense data in the additional sense length. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/scsi-bus.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/scsi-

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

On Tue, 06 Sep 2011 17:55:12 +0200 Jan Kiszka wrote: > On 2011-09-06 15:14, Luiz Capitulino wrote: > > This commit could have been folded with the previous one, however > > doing it separately will allow for easy bisect and revert if needed. > > > > Checking and testing all valid transitions was

[Qemu-devel] [PATCH 07/31] block: Split change_cb() into change_media_cb(), resize_cb()

From: Markus Armbruster Multiplexing callbacks complicates matters needlessly. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c | 23 +++ block.h | 12 +++- block_int.h |3 --- hw/ide/core.c |8 ++-- hw/sd

  1   2   >