Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Peter Maydell
On 25 August 2011 14:22, Avi Kivity wrote: > On 08/25/2011 04:13 PM, Jan Kiszka wrote: >> Packing all structs is not really a good idea, more a last resort. > > btw, how are the non-x86s handling this? by trapping and fixuping in the > kernel? If a structure's packing means it doesn't adhere to t

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:36 PM, Peter Maydell wrote: On 25 August 2011 14:22, Avi Kivity wrote: > On 08/25/2011 04:13 PM, Jan Kiszka wrote: >> Packing all structs is not really a good idea, more a last resort. > > btw, how are the non-x86s handling this? by trapping and fixuping in the > kernel? If

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Anthony Liguori
On 08/25/2011 07:19 AM, Kevin Wolf wrote: Am 24.08.2011 20:43, schrieb Anthony Liguori: Signed-off-by: Anthony Liguori --- blockdev.c | 22 +++--- blockdev.h |1 - hmp-commands.hx |3 +-- hmp.c| 14 ++ hmp.h|1

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Kevin Wolf
Am 25.08.2011 14:56, schrieb Anthony Liguori: > On 08/25/2011 07:46 AM, Kevin Wolf wrote: >> Am 24.08.2011 20:43, schrieb Anthony Liguori: >>> A new QMP only command to change the blockdev associated with a block >>> device. >>> The semantics of change right now are just plain scary. This command

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Kevin Wolf
Am 25.08.2011 15:40, schrieb Anthony Liguori: > On 08/25/2011 07:19 AM, Kevin Wolf wrote: >> Am 24.08.2011 20:43, schrieb Anthony Liguori: >>> Signed-off-by: Anthony Liguori >>> --- >>> blockdev.c | 22 +++--- >>> blockdev.h |1 - >>> hmp-commands.hx |3 +-

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Anthony Liguori
On 08/25/2011 08:47 AM, Kevin Wolf wrote: Am 25.08.2011 14:56, schrieb Anthony Liguori: On 08/25/2011 07:46 AM, Kevin Wolf wrote: Am 24.08.2011 20:43, schrieb Anthony Liguori: A new QMP only command to change the blockdev associated with a block device. The semantics of change right now are ju

Re: [Qemu-devel] Questions regarding ivshmem spec

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:29 PM, Sasha Levin wrote: 2. The spec describes DOORBELL as an array of DWORDs, when one guest wants to poke a different guest it would write something into the offset of the other guest in the DOORBELL array. Looking at the implementation in QEMU, DOORBELL is one DWORD, when wri

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:52 PM, Kevin Wolf wrote: > > It's not pretty, but it lets us preserve compatibility. I think it's > also safer for dealing with pointers because otherwise you have a mix of > pointers that may be null and may not be null. Having a clear > indication of which pointers are nu

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Stefan Weil
As I wrote in my last mail, I compared all structs without and with -mms-bitfields using pahole and codiff. The result is in the appended codiff.log. About 17 structs changed because of -mms-bitfield. This attribute modifies not only structs with bitfield but also packed structs or structs with

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:43:07 -0500 Anthony Liguori wrote: > A new QMP only command to change the blockdev associated with a block device. > The semantics of change right now are just plain scary. This command > introduces > sane semantics. For more details, see the documentation in the schema

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Anthony Liguori
On 08/25/2011 09:09 AM, Luiz Capitulino wrote: On Wed, 24 Aug 2011 13:43:07 -0500 Anthony Liguori wrote: A new QMP only command to change the blockdev associated with a block device. The semantics of change right now are just plain scary. This command introduces sane semantics. For more deta

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Anthony Liguori
On 08/25/2011 09:03 AM, Stefan Weil wrote: As I wrote in my last mail, I compared all structs without and with -mms-bitfields using pahole and codiff. The result is in the appended codiff.log. About 17 structs changed because of -mms-bitfield. This attribute modifies not only structs with bitfie

Re: [Qemu-devel] [PATCH] qcow2: use always stderr for debugging

2011-08-25 Thread Paolo Bonzini
On 08/25/2011 09:23 AM, Frediano Ziglio wrote: let all DEBUG_ALLOC2 printf goes to stderr Signed-off-by: Frediano Ziglio --- block/qcow2-cluster.c |2 +- block/qcow2-refcount.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow

Re: [Qemu-devel] Questions regarding ivshmem spec

2011-08-25 Thread Sasha Levin
On Thu, 2011-08-25 at 17:00 +0300, Avi Kivity wrote: > On 08/25/2011 04:29 PM, Sasha Levin wrote: > > 2. The spec describes DOORBELL as an array of DWORDs, when one guest > > wants to poke a different guest it would write something into the offset > > of the other guest in the DOORBELL array. > > L

Re: [Qemu-devel] Questions regarding ivshmem spec

2011-08-25 Thread Avi Kivity
On 08/25/2011 05:39 PM, Sasha Levin wrote: On Thu, 2011-08-25 at 17:00 +0300, Avi Kivity wrote: > On 08/25/2011 04:29 PM, Sasha Levin wrote: > > 2. The spec describes DOORBELL as an array of DWORDs, when one guest > > wants to poke a different guest it would write something into the offset >

Re: [Qemu-devel] Questions regarding ivshmem spec

2011-08-25 Thread Sasha Levin
On Thu, 2011-08-25 at 17:40 +0300, Avi Kivity wrote: > On 08/25/2011 05:39 PM, Sasha Levin wrote: > > On Thu, 2011-08-25 at 17:00 +0300, Avi Kivity wrote: > > > On 08/25/2011 04:29 PM, Sasha Levin wrote: > > > > 2. The spec describes DOORBELL as an array of DWORDs, when one guest > > > > wants

Re: [Qemu-devel] [PATCH 13/14] qapi: convert change

2011-08-25 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:43:08 -0500 Anthony Liguori wrote: > Convert the change command to QAPI and document all of its gloriousness. > > Signed-off-by: Anthony Liguori > --- > blockdev.c | 27 -- > blockdev.h |6 +++- > hmp-commands.hx |3 +- > hmp.c

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Luiz Capitulino
On Thu, 25 Aug 2011 09:21:02 -0500 Anthony Liguori wrote: > On 08/25/2011 09:09 AM, Luiz Capitulino wrote: > > On Wed, 24 Aug 2011 13:43:07 -0500 > > Anthony Liguori wrote: > > > >> A new QMP only command to change the blockdev associated with a block > >> device. > >> The semantics of change r

Re: [Qemu-devel] [PATCH 00/14] Convert commands to QAPI (batch 1)

2011-08-25 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:42:55 -0500 Anthony Liguori wrote: > This is my attempt to jump-start the QAPI switch over. All of the hard work > is already done in my qapi branch, we just need to start merging stuff. > > To simplify the merge process, I've introduced a new mode to the code > generato

[Qemu-devel] [PATCH 1/6] hw/9pfs: Add reference counting for fid

2011-08-25 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 273 ++- hw/9pfs/virtio-9p.h |2 + 2 files changed, 184 insertions(+), 91 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index ad70768..555f456 100644 --- a/hw/9pfs

[Qemu-devel] [PATCH 0/7] usb-host: bugfixes

2011-08-25 Thread Gerd Hoffmann
Hi, Here comes a bunch of bugfixes for the usb host (aka usb pass-thru) driver. Gets some of my devices working which didn't work before, so anyone who had trouble with it recently is encouraged to re-test with these patches applied. cheers, Gerd Gerd Hoffmann (7): usb-host: start tracing

[Qemu-devel] [PATCH 3/7] usb-host: fix halted endpoints

2011-08-25 Thread Gerd Hoffmann
Two fixes for the price of one ;) First, reinitialize the endpoint table after device reset. This is needed anyway as the reset might have switched interfaces. It also clears the endpoint halted state. Second the CLEAR_HALT ioctl wants a unsigned int passed in as argument, not uint8_t. This gets

[Qemu-devel] [PATCH 6/7] usb-host: claim port

2011-08-25 Thread Gerd Hoffmann
When configured to pass through a specific host port (using hostbus and hostport properties), try to claim the port if supported by the kernel. That will avoid any kernel drivers binding to devices plugged into that port. It will not stop any userspace apps (such as usb_modeswitch) access the devi

[Qemu-devel] [PATCH 4/7] usb-host: limit open retries

2011-08-25 Thread Gerd Hoffmann
Limit the number of times qemu tries to open host devices to three. Reset error counter when the device goes away, after un-plugging and re-plugging the device qemu will try again three times. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 13 - 1 files changed, 12 insertions(+), 1

[Qemu-devel] [PATCH 2/7] usb-host: reapurb error report fix

2011-08-25 Thread Gerd Hoffmann
Don't report errors on devices which are in disconnected and closing state. --- usb-linux.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index d813a85..ddfa50a 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -312,9 +312,11 @@ static void a

[Qemu-devel] [PATCH 5/6] hw/9pfs: Add directory reclaim support

2011-08-25 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/codir.c |9 + hw/9pfs/virtio-9p.c | 31 +-- 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/codir.c b/hw/9pfs/codir.c index 86adc87..f17f927 100644 --- a/hw/9pfs/codir.c +++ b/hw/9pfs

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Don Dutile
On 08/25/2011 06:54 AM, Roedel, Joerg wrote: Hi Alex, On Wed, Aug 24, 2011 at 05:13:49PM -0400, Alex Williamson wrote: Is this roughly what you're thinking of for the iommu_group component? Adding a dev_to_group iommu ops callback let's us consolidate the sysfs support in the iommu base. Would

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-08-25 Thread David Rando
Do you know if it's something related to the virtio net driver? anyone tried going to the e1000 only? i have some machines with e1000 and some of them with virtio-net, but i have crash no matter what driver is using (but the virtio driver is installed anyway, despite i'm using the e1000). I was se

Re: [Qemu-devel] [RFC PATCH V1 00/14] Dynamic machine model creation from device trees

2011-08-25 Thread Peter Crosthwaite
Hi Anthony, So the primary motivation for using this is in embedded systems design flows where you are already working with DTS for software boot. For microblaze-linux, xilinx-ppc and the xilinx-arm platforms which we are working with, it even more makes sense as the hardware platform design tools

[Qemu-devel] [PATCH 3/6] hw/9pfs: init fid list properly

2011-08-25 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 44b9ace..97f2da5 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -130,6

[Qemu-devel] [PATCH 1/7] usb-host: start tracing support

2011-08-25 Thread Gerd Hoffmann
Add a bunch of trace points to usb-linux.c Drop a bunch of DPRINTK's in favor of the trace points. Also cleanup error reporting a bit while being at it. Signed-off-by: Gerd Hoffmann --- trace-events | 18 ++ usb-linux.c | 73 ++--

[Qemu-devel] [PATCH 4/6] hw/9pfs: Use v9fs_do_close instead of close

2011-08-25 Thread Aneesh Kumar K.V
we should use the local abstraction instead of directly calling close. Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 4ba2590..6529216 100644 --- a/hw/9pfs/virtio-

[Qemu-devel] [PATCH v6 00/14] trace-state: make the behaviour of "disable" consistent across all backends

2011-08-25 Thread Lluís
This patch defines the "disable" trace event state to always use the "nop" backend. As a side-effect, all events are now enabled (without "disable") by default, as all backends (except "stderr") have programmatic support for dynamically (de)activating each trace event. In order to make this true,

[Qemu-devel] [PATCH v6 01/14] [simple] Include qemu-timer-common.o in trace-obj-y

2011-08-25 Thread Lluís
Helper programs like qemu-ga use tracing primitives, but qemu-timer-common.o (also used by simpletrace.o) is not necessarily included in the linkage line. This currently produces a warning when linking the *-softmmu programs. Signed-off-by: Lluís Vilanova --- Makefile.objs |2 +- 1 files ch

[Qemu-devel] [PATCH v6 02/14] provide support for default implementations using weak symbols

2011-08-25 Thread Lluís
Routines using the QEMU_WEAK attribute can have a default implementation that can be later overriden just by re-implementing it. Signed-off-by: Lluís Vilanova --- compiler.h | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/compiler.h b/compiler.h index 9af5dc

[Qemu-devel] [PATCH v6 04/14] trace: [make] replace 'ifeq' with values in CONFIG_TRACE_*

2011-08-25 Thread Lluís
Signed-off-by: Lluís Vilanova --- Makefile.objs | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 44d7238..aaf6542 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -374,16 +374,14 @@ endif simpletrace.o: simpletrace.c $(GEN

[Qemu-devel] [PATCH v6 03/14] trace: [configure] rename CONFIG_*_TRACE into CONFIG_TRACE_*

2011-08-25 Thread Lluís
Provides a more hierarchical view of the variable domain. Signed-off-by: Lluís Vilanova --- Makefile.target |6 +++--- configure |4 ++-- hmp-commands.hx |4 ++-- monitor.c |8 qemu-config.c |4 ++-- qemu-options.hx |2 +- simpletrace.h

[Qemu-devel] [PATCH v6 07/14] trace: generalize the "property" concept in the trace-events file

2011-08-25 Thread Lluís
This adds/modifies the following functions: * get_name: Get _only_ the event name * has_property: Return whether an event has a property (keyword before the event name) Signed-off-by: Lluís Vilanova --- docs/tracing.txt |4 +-- scripts/tracetool | 73 ---

[Qemu-devel] [PATCH v6 08/14] trace-state: separate trace event control and query routines from the simple backend

2011-08-25 Thread Lluís
Move the 'st_print_trace_events' and 'st_change_trace_event_state' into backend-agnostic 'trace_print_events' and 'trace_event_set_state' (respectively) in the "trace/control.c" file. Uses "QEMU_WEAK" to provide a default implementation that signals it as not implemented. Backends can provide the

[Qemu-devel] [PATCH v6 11/14] trace-state: always use the "nop" backend on events with the "disable" keyword

2011-08-25 Thread Lluís
Any event with the keyword/property "disable" generates an empty trace event using the "nop" backend, regardless of the current backend. Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 25 +++-- scripts/tracetool | 15 ++- 2 files changed, 17 insertions(

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-08-25 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 3:53 PM, David Rando wrote: > Do you know if it's something related to the virtio net driver? anyone > tried going to the e1000 only? i have some machines with e1000 and some > of them with virtio-net, but i have crash no matter what driver is using > (but the virtio driver

[Qemu-devel] [PATCH v6 13/14] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-08-25 Thread Lluís
Uses the generic interface provided in "trace/control.h" in order to provide a programmatic interface as well as command line and monitor controls. Signed-off-by: Fabien Chouteau Signed-off-by: Lluís Vilanova --- Makefile.objs |2 ++ configure |3 +++ docs/tracing.txt |

Re: [Qemu-devel] [PATCH 1/7] usb-host: start tracing support

2011-08-25 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 4:06 PM, Gerd Hoffmann wrote: > Add a bunch of trace points to usb-linux.c  Drop a bunch of DPRINTK's in > favor of the trace points.  Also cleanup error reporting a bit while being > at it. > > Signed-off-by: Gerd Hoffmann > --- >  trace-events |   18 ++ >  us

[Qemu-devel] [PATCH 6/6] hw/9pfs: mark directories also as un-reclaimable on unlink

2011-08-25 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 73 ++ 1 files changed, 38 insertions(+), 35 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 16f7d4e..94b7090 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virti

[Qemu-devel] [PATCH 5/7] usb-host: fix configuration tracking.

2011-08-25 Thread Gerd Hoffmann
It is perfectly fine to leave the usb device in unconfigured state (USBHostDevice->configuration == 0). Just do that and wait for the guest to explicitly set a configuration. This is closer to what real hardware does and it also simplifies the device initialization. There is no need to figure ho

[Qemu-devel] [PATCH 7/7] usb: fix use after free

2011-08-25 Thread Gerd Hoffmann
The ->complete() callback might have released the USBPacket (uhci actually does), so we must not touch it after the callback returns. Signed-off-by: Gerd Hoffmann --- hw/usb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 685e775..a091e4e 100

Re: [Qemu-devel] [RFC PATCH V1 00/14] Dynamic machine model creation from device trees

2011-08-25 Thread Paolo Bonzini
On 08/25/2011 05:43 PM, Peter Crosthwaite wrote: Now my understanding is the part of the qdev philosophy is to not embed connection information in device models themselves? This is going to change sooner or later, the GPIO connections in qdev _are_ embedded connections and extending qdev requ

Re: [Qemu-devel] [PATCH 6/7] usb-host: claim port

2011-08-25 Thread Erik Rull
Hi Gerd, is this related / the fix to my question regarding the recurring claimed messages? (See my mail dated 2011-08-21) Best regards, Erik Gerd Hoffmann wrote: When configured to pass through a specific host port (using hostbus and hostport properties), try to claim the port if support

Re: [Qemu-devel] [RFC PATCH V1 00/14] Dynamic machine model creation from device trees

2011-08-25 Thread Anthony Liguori
On 08/25/2011 10:43 AM, Peter Crosthwaite wrote: Hi Anthony, So the primary motivation for using this is in embedded systems design flows where you are already working with DTS for software boot. For microblaze-linux, xilinx-ppc and the xilinx-arm platforms which we are working with, it even mor

Re: [Qemu-devel] [PATCH v6 13/14] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-08-25 Thread Lluís
Forgot to add this hunk: diff --git a/qemu-options.hx b/qemu-options.hx index 91144d9..455f1ef 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2450,7 +2450,8 @@ Immediately enable events listed in @var{file}. The file must contain one event name (as listed in the @var{

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V3

2011-08-25 Thread Kevin Wolf
Am 25.08.2011 08:25, schrieb Christoph Hellwig: > changes since V2: > - fix the crash with non read/write/flush commands in virtio_blk >pointed out by Ryan > - address all review comments by Kevin > changes since V1: > - rebase to apply against the current qemu.git tree > > > Note that thi

[Qemu-devel] [PATCH v6 09/14] trace-state: always compile support for controlling and querying trace event states

2011-08-25 Thread Lluís
The current interface is generic for this small set of operations, and thus other backends can easily modify the "trace/control.c" file to add their own implementation. Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 39 +-- hmp-commands.hx |7

Re: [Qemu-devel] [PATCH 03/14] qapi: use middle mode in QMP server

2011-08-25 Thread Michael Roth
On 08/24/2011 01:42 PM, Anthony Liguori wrote: Use the new middle mode within the existing QMP server. Signed-off-by: Anthony Liguori --- Makefile | 11 +++ Makefile.objs|2 ++ Makefile.target |6 +++--- monitor.c| 11 --- qapi-schema.json |

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Decker, Schorschi
>From a security perspective, this not a great idea. Security isolation in >virtualization is gaining ground, so anything that breaches the >hypervisor/guest vale is by your typical enterprise/company security team >considered completely illegal, a number of firms I have talked with all are >t

Re: [Qemu-devel] [PATCH 0/3] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-08-25 Thread An-Cheng Huang
On Wed, Aug 17, 2011 at 02:30:53PM -0700, An-Cheng Huang wrote: > On Tue, Aug 09, 2011 at 12:30:52PM -0700, An-Cheng Huang wrote: > > These patches implement the setxattr, getxattr, and removexattr syscalls. > > Since libattr uses indirect syscalls for these, the fix for the indirect > > syscall ha

[Qemu-devel] [PATCH] hw/9pfs: Update the fidp path before opendir

2011-08-25 Thread Aneesh Kumar K.V
We need to update the fidp path before opendir. Since we don't use the fid returned by mkdir, earlier code should not have much issue. We do a double v9fs_string_copy here. The later patch cleanup the entire function. Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c |1 + 1 files chan

Re: [Qemu-devel] [PATCH 03/14] qapi: use middle mode in QMP server

2011-08-25 Thread Luiz Capitulino
On Thu, 25 Aug 2011 11:24:04 -0500 Michael Roth wrote: > On 08/24/2011 01:42 PM, Anthony Liguori wrote: > > Use the new middle mode within the existing QMP server. > > > > Signed-off-by: Anthony Liguori > > --- > > Makefile | 11 +++ > > Makefile.objs|2 ++ > > Makef

[Qemu-devel] [PATCH] hw/9pfs: Initialize rest of qid field to zero.

2011-08-25 Thread Aneesh Kumar K.V
Since qid is allocated out of stack we need to intialize the field to zero. Otherwise we will send wrong qid value to client. Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-25 Thread Ryan Harper
* Christoph Hellwig [2011-08-24 13:46]: > On Mon, Aug 22, 2011 at 11:46:00AM -0500, Ryan Harper wrote: > > So, I believe this is how it's happening. > > > > we start accounting on a write which is turned into a multiwrite via > > virtio_blk_handle_write() which calls virtio_submit_multiwrite(). >

[Qemu-devel] [PATCH] monitor: fix build breakage for !CONFIG_VNC

2011-08-25 Thread Luiz Capitulino
From: Jamie Iles Commit c62f6d1 (monitor: fix build breakage with --disable-vnc) conditionalised some VNC setup code but left an unused variable. Move the variable into the conditional code to fix the build breakage. Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Jamie Iles Signed-

[Qemu-devel] [PULL 0/1]: Monitor queue

2011-08-25 Thread Luiz Capitulino
Anthony, The following patches have been sent to the list and look good to me. I've also tested them. The changes (since 56a7a874e962e28522857fbf72eaefb1a07e2001) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/monitor Jamie Iles (1): monitor: f

[Qemu-devel] [PATCH v6 12/14] trace-state: [simple] disable all trace points by default

2011-08-25 Thread Lluís
Note that this refers to the backend-specific state (whether the output must be generated), not the event "disabled" property (which always uses the "nop" backend). Signed-off-by: Lluís Vilanova --- scripts/tracetool |9 ++--- trace-events |3 --- 2 files changed, 2 insertions(+

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Roedel, Joerg
On Thu, Aug 25, 2011 at 11:38:09AM -0400, Don Dutile wrote: > On 08/25/2011 06:54 AM, Roedel, Joerg wrote: > > We need to solve this differently. ARM is starting to use the iommu-api > > too and this definitly does not work there. One possible solution might > > be to make the iommu-ops per-bus. >

[Qemu-devel] [PATCH v6 05/14] trace: move backend-specific code into the trace/ directory

2011-08-25 Thread Lluís
Signed-off-by: Lluís Vilanova --- Makefile |1 Makefile.objs |6 + scripts/tracetool |2 simpletrace.c | 355 - simpletrace.h | 48 --- trace/simple.c| 355 ++

[Qemu-devel] [PATCH v6 14/14] trace: enable all events

2011-08-25 Thread Lluís
Given that all events with programmatically-controlled state are disabled by default, we can delete the "disable" property from all events. Signed-off-by: Lluís Vilanova --- trace-events | 644 +- 1 files changed, 322 insertions(+), 322 de

[Qemu-devel] [PATCH 2/6] hw/9pfs: Add file descriptor reclaim support

2011-08-25 Thread Aneesh Kumar K.V
[M. Mohan Kumar removed some unused variables] Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/codir.c|4 +- hw/9pfs/cofile.c | 19 - hw/9pfs/virtio-9p-coth.h |4 +- hw/9pfs/virtio-9p-device.c |1 + hw/9pfs/virtio-9p.c| 187

[Qemu-devel] [PATCH v6 06/14] trace: avoid conditional code compilation during option parsing

2011-08-25 Thread Lluís
Uses "QEMU_WEAK" to provide a default implementation that signals it as not implemented. Backends can provide their own implementation if the (sub)options are supported. Signed-off-by: Lluís Vilanova --- Makefile|2 +- Makefile.objs |2 ++ qemu-config.c |4 qemu-opt

[Qemu-devel] [PATCH 0/6] hw/9pfs: Implement file descriptor reclaim in VirtFS server

2011-08-25 Thread Aneesh Kumar K.V
Hi, The patch series implement file descriptor reclaim support in VirtFS server. VirtFS qemu server track open file descriptor on the client using an open fid. This result in server returning EMFILE error even though on the client side the process have not reached maximum open file limit. To fix

[Qemu-devel] [PATCH v6 10/14] trace-state: add "-trace events" argument to control initial state

2011-08-25 Thread Lluís
The "-trace events" argument can be used to provide a file with a list of trace event names that will be enabled prior to starting execution, thus providing early tracing. This saves the user from manually toggling event states through the monitor interface or whichever backend-specific interface.

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 16:03, Stefan Weil wrote: > As I wrote in my last mail, I compared all structs without and with > -mms-bitfields > using pahole and codiff. The result is in the appended codiff.log. > > About 17 structs changed because of -mms-bitfield. This attribute > modifies not only > structs wi

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Alex Williamson
On Thu, 2011-08-25 at 12:54 +0200, Roedel, Joerg wrote: > Hi Alex, > > On Wed, Aug 24, 2011 at 05:13:49PM -0400, Alex Williamson wrote: > > Is this roughly what you're thinking of for the iommu_group component? > > Adding a dev_to_group iommu ops callback let's us consolidate the sysfs > > support

Re: [Qemu-devel] PPC* and Sparc32 crash

2011-08-25 Thread Blue Swirl
On Thu, Aug 25, 2011 at 4:43 AM, Avi Kivity wrote: > On 08/24/2011 11:02 PM, Blue Swirl wrote: >> >> > >> >  Backtrace? >> >> [Thread debugging using libthread_db enabled] >> [New Thread 0x70ab7700 (LWP 15515)] >> qemu-system-sparc: /src/qemu/hw/sysbus.c:156: >> sysbus_register_withprop: Asser

Re: [Qemu-devel] [PATCH v6 02/14] provide support for default implementations using weak symbols

2011-08-25 Thread Blue Swirl
On Thu, Aug 25, 2011 at 3:51 PM, Lluís wrote: > Routines using the QEMU_WEAK attribute can have a default implementation that > can be later overriden just by re-implementing it. Nack: weak attributes are only available for ELF and a.out. > Signed-off-by: Lluís Vilanova > --- >  compiler.h |  

[Qemu-devel] [PATCH] hw/lan9118.c: Convert to MemoryRegion

2011-08-25 Thread Peter Maydell
Signed-off-by: Peter Maydell --- Another device I needed to convert so I could connect it to omap_gpmc for an omap3 board (in this case overo). hw/lan9118.c | 29 +++-- 1 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 73

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-08-25 Thread Blue Swirl
On Wed, Aug 24, 2011 at 9:38 PM, Alexander Graf wrote: > On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool > would be doing and what he expects from it. Basically he wants a > small and simple tool he and other developers can run to try out and > see if the kernel they just built

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Joerg Roedel
On Thu, Aug 25, 2011 at 11:20:30AM -0600, Alex Williamson wrote: > On Thu, 2011-08-25 at 12:54 +0200, Roedel, Joerg wrote: > > We need to solve this differently. ARM is starting to use the iommu-api > > too and this definitly does not work there. One possible solution might > > be to make the iomm

Re: [Qemu-devel] [PATCH v6 02/14] provide support for default implementations using weak symbols

2011-08-25 Thread Lluís
Blue Swirl writes: > On Thu, Aug 25, 2011 at 3:51 PM, Lluís wrote: >> Routines using the QEMU_WEAK attribute can have a default implementation that >> can be later overriden just by re-implementing it. > Nack: weak attributes are only available for ELF and a.out. Right, sorry. It was too good t

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Edgar E. Iglesias
On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote: > On 08/25/2011 03:01 AM, Avi Kivity wrote: > >Please pull from > > > >git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch > > > >to receive the fifth memory API conversions batch. There is really > >nothing notable, excep

Re: [Qemu-devel] [RFC PATCH V1 12/14] microblaze: Make the MSR PVR bit non writable

2011-08-25 Thread Edgar E. Iglesias
On Thu, Aug 25, 2011 at 08:17:35PM +1000, Peter Crosthwaite wrote: > Hi Peter , I included them as they are prerequisite for patch 14. Edgar, can > we > get a review / push of these two separate of this series so I can take them > out > next revision ? Yes, my bad. I should have pushed this bef

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Blue Swirl
On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias wrote: > On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote: >> On 08/25/2011 03:01 AM, Avi Kivity wrote: >> >Please pull from >> > >> >git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch >> > >> >to receive the fifth memo

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Anthony Liguori
On 08/25/2011 01:58 PM, Blue Swirl wrote: On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias wrote: On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote: On 08/25/2011 03:01 AM, Avi Kivity wrote: Please pull from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch to

Re: [Qemu-devel] [RFC PATCH V1 00/14] Dynamic machine model creation from device trees

2011-08-25 Thread Edgar E. Iglesias
On Thu, Aug 25, 2011 at 11:04:12AM -0500, Anthony Liguori wrote: > On 08/25/2011 10:43 AM, Peter Crosthwaite wrote: > >Hi Anthony, > > > >So the primary motivation for using this is in embedded systems design flows > >where you are already working with DTS for software boot. For > >microblaze-linux

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Blue Swirl
On Thu, Aug 25, 2011 at 7:02 PM, Anthony Liguori wrote: > On 08/25/2011 01:58 PM, Blue Swirl wrote: >> >> On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias >>  wrote: >>> >>> On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote: On 08/25/2011 03:01 AM, Avi Kivity wrote:

[Qemu-devel] [PATCH v7 00/13] trace-state: make the behaviour of "disable" consistent across all backends

2011-08-25 Thread Lluís
This patch defines the "disable" trace event state to always use the "nop" backend. As a side-effect, all events are now enabled (without "disable") by default, as all backends (except "stderr") have programmatic support for dynamically (de)activating each trace event. In order to make this true,

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Edgar E. Iglesias
On Thu, Aug 25, 2011 at 02:02:24PM -0500, Anthony Liguori wrote: > On 08/25/2011 01:58 PM, Blue Swirl wrote: > >On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias > > wrote: > >>On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote: > >>>On 08/25/2011 03:01 AM, Avi Kivity wrote: > Pl

[Qemu-devel] [PATCH v7 01/13] [simple] Include qemu-timer-common.o in trace-obj-y

2011-08-25 Thread Lluís
Helper programs like qemu-ga use tracing primitives, but qemu-timer-common.o (also used by simpletrace.o) is not necessarily included in the linkage line. This currently produces a warning when linking the *-softmmu programs. Signed-off-by: Lluís Vilanova --- Makefile.objs |2 +- 1 files ch

[Qemu-devel] [PATCH v7 02/13] trace: [configure] rename CONFIG_*_TRACE into CONFIG_TRACE_*

2011-08-25 Thread Lluís
Provides a more hierarchical view of the variable domain. Also adds the CONFIG_TRACE_* variables for all backends. Signed-off-by: Lluís Vilanova --- Makefile.target |6 +++--- configure | 13 +++-- hmp-commands.hx |4 ++-- monitor.c |8 qemu-co

[Qemu-devel] [PATCH v7 12/13] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-08-25 Thread Lluís
Uses the generic interface provided in "trace/control.h" in order to provide a programmatic interface as well as command line and monitor controls. Signed-off-by: Fabien Chouteau Signed-off-by: Lluís Vilanova --- configure |3 +++ docs/tracing.txt |5 - qemu-options.hx |

[Qemu-devel] [PATCH v7 11/13] trace-state: [simple] disable all trace points by default

2011-08-25 Thread Lluís
Note that this refers to the backend-specific state (whether the output must be generated), not the event "disabled" property (which always uses the "nop" backend). Signed-off-by: Lluís Vilanova --- scripts/tracetool |9 ++--- trace-events |3 --- 2 files changed, 2 insertions(+

[Qemu-devel] [PATCH v7 13/13] trace: enable all events

2011-08-25 Thread Lluís
Given that all events with programmatically-controlled state are disabled by default, we can delete the "disable" property from all events. Signed-off-by: Lluís Vilanova --- trace-events | 644 +- 1 files changed, 322 insertions(+), 322 de

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Avi Kivity
On 08/25/2011 09:58 PM, Blue Swirl wrote: > > Guys, please start testing before applying these patches. It's not hard, > there are images on the wiki with scripts that area easy to run. It's also possible to revert offending patches. Please revert the entire pull (git revert 8ef9ea85a2cc1) w

Re: [Qemu-devel] PPC* and Sparc32 crash

2011-08-25 Thread Avi Kivity
On 08/25/2011 08:33 PM, Blue Swirl wrote: (gdb) bt #0 0x73da2165 in *__GI_raise (sig=) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #1 0x73da4f70 in *__GI_abort () at abort.c:92 #2 0x73d9b2b1 in *__GI___assert_fail ( assertion=0x5c7390 "info->qdev.size>= size

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Jan Kiszka
On 2011-08-25 20:27, Edgar E. Iglesias wrote: > On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote: >> On 08/25/2011 03:01 AM, Avi Kivity wrote: >>> Please pull from >>> >>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch >>> >>> to receive the fifth memory API conversi

[Qemu-devel] [PATCH v7 08/13] trace-state: always compile support for controlling and querying trace event states

2011-08-25 Thread Lluís
The current interface is generic for this small set of operations, and thus other backends can easily modify the "trace/control.c" file to add their own implementation. Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 39 +-- hmp-commands.hx |7

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-08-25 Thread Vadim Rozenfeld
On Thu, 2011-08-25 at 16:54 +0100, Stefan Hajnoczi wrote: > On Thu, Aug 25, 2011 at 3:53 PM, David Rando wrote: > > Do you know if it's something related to the virtio net driver? anyone > > tried going to the e1000 only? i have some machines with e1000 and some > > of them with virtio-net, but i

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Avi Kivity
On 08/25/2011 10:32 PM, Jan Kiszka wrote: > > Program received signal SIGSEGV, Segmentation fault. > 0x0041be54 in memory_region_init_rom_device (mr=0xfb6900, > ops=, dev=, > name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216) > at /home/edgar/src/c/qemu/qemu/memor

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Jan Kiszka
On 2011-08-25 21:36, Avi Kivity wrote: > On 08/25/2011 10:32 PM, Jan Kiszka wrote: >> > >> > Program received signal SIGSEGV, Segmentation fault. >> > 0x0041be54 in memory_region_init_rom_device (mr=0xfb6900, >> > ops=, dev=, >> > name=0x564c5d "petalogix_s3adsp1800.flash", size

[Qemu-devel] [PATCH v7 09/13] trace-state: add "-trace events" argument to control initial state

2011-08-25 Thread Lluís
The "-trace events" argument can be used to provide a file with a list of trace event names that will be enabled prior to starting execution, thus providing early tracing. This saves the user from manually toggling event states through the monitor interface or whichever backend-specific interface.

[Qemu-devel] [PATCH v7 07/13] trace-state: separate trace event control and query routines from the simple backend

2011-08-25 Thread Lluís
Generalize the 'st_print_trace_events' and 'st_change_trace_event_state' into backend-specific 'trace_print_events' and 'trace_event_set_state' (respectively) in the "trace/control.h" file. Signed-off-by: Lluís Vilanova --- hmp-commands.hx |2 +- monitor.c | 11 ++- trace/con

[Qemu-devel] [PATCH v7 04/13] trace: move backend-specific code into the trace/ directory

2011-08-25 Thread Lluís
Signed-off-by: Lluís Vilanova --- Makefile |1 Makefile.objs |6 + scripts/tracetool |2 simpletrace.c | 355 - simpletrace.h | 48 --- trace/simple.c| 355 ++

<    1   2   3   >