[Qemu-devel] [PATCH] fix spelling error

2011-08-24 Thread Robert Wang
Signed-off-by: Robert Wang --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 57b6e1a..ab04932 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -66,7 +66,7 @@ * 20 - 31 (12 bits): reserved data object

[Qemu-devel] [PATCH] qemu-coroutine: Add simple work queue support

2011-08-24 Thread Peter A. G. Crosthwaite
Add a function co_queue_yield_to_next() which will immediately transfer control to the coroutine at the head of a co queue. This can be used for implementing simple work queues where the manager of a co-queue only needs to restart queued routines one at a time. Signed-off-by: Peter A. G. Crosthwai

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels

2011-08-24 Thread Avi Kivity
On 08/24/2011 01:16 AM, Alexander Graf wrote: On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool would be doing and what he expects from it. Basically he wants a small and simple tool he and other developers can run to try out and see if the kernel they just built actually works.

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread Joerg Roedel
On Tue, Aug 23, 2011 at 03:30:06PM -0400, Alex Williamson wrote: > On Tue, 2011-08-23 at 07:01 +1000, Benjamin Herrenschmidt wrote: > > Could be tho in what form ? returning sysfs pathes ? > > I'm at a loss there, please suggest. I think we need an ioctl that > returns some kind of array of devi

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread Roedel, Joerg
On Tue, Aug 23, 2011 at 01:08:29PM -0400, Alex Williamson wrote: > On Tue, 2011-08-23 at 15:14 +0200, Roedel, Joerg wrote: > > Handling it through fds is a good idea. This makes sure that everything > > belongs to one process. I am not really sure yet if we go the way to > > just bind plain groups

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread Roedel, Joerg
On Tue, Aug 23, 2011 at 07:35:37PM -0400, Benjamin Herrenschmidt wrote: > On Tue, 2011-08-23 at 15:18 +0200, Roedel, Joerg wrote: > > Hmm, good idea. But as far as I know the hotplug-event needs to be in > > the guest _before_ the device is actually unplugged (so that the guest > > can unbind its

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread Joerg Roedel
On Tue, Aug 23, 2011 at 01:33:14PM -0400, Aaron Fabbri wrote: > On 8/23/11 10:01 AM, "Alex Williamson" wrote: > > The iommu domain would probably be allocated when the first device is > > bound to vfio. As each device is bound, it gets attached to the group. > > DMAs are done via an ioctl on the

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-24 Thread Jan Kiszka
On 2011-08-23 12:49, TeLeMan wrote: > On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: >> Am 15.08.2011 08:39, schrieb Jan Kiszka: >>> >>> The following changes since commit >>> 3b6ffe50300f13240e1b46420ad05da1116df410: >>> >>> hw/scsi-bus.c: Fix use of uninitialised variable (2011-08-14 19:34:25

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread Roedel, Joerg
On Tue, Aug 23, 2011 at 12:54:27PM -0400, aafabbri wrote: > On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > > That is makes uiommu basically the same as the meta-groups, right? > > Yes, functionality seems the same, thus my suggestion to keep uiommu > explicit. Is there some need for group-groups be

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels

2011-08-24 Thread Jan Kiszka
On 2011-08-24 10:25, Avi Kivity wrote: > On 08/24/2011 01:16 AM, Alexander Graf wrote: >> +" >> +echo "\ >> +Your guest is bound to the current foreground shell. To quit the guest, >> +please use Ctrl-A x" >> +echo " Executing: $QEMU_BIN $QEMU_OPTIONS -append \"$KERNEL_APPEND\" >> -smp $SMP" >> +e

Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2

2011-08-24 Thread Avi Kivity
On 08/24/2011 03:13 AM, Richard Henderson wrote: The problem that malc saw with sb16 was a major think-o on my part with the whole interface. We can't re-use the const sub-arrays of the original MemoryRegionPortio array because they have the wrong offset for the MemoryRegion to which it is attac

Re: [Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-24 Thread Avi Kivity
On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote: Hello Avi, Thnx, fixed: OK, maybe some credits :-) Acked-by: Gerhard Wiesinger This pattern is still present at (maybe some further problems!!!) and I guess it has to be fixed, too: grep -ir 'ops, s, "' . ./hw/rtl8139.c:memory_region_ini

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread David Gibson
On Wed, Aug 24, 2011 at 11:14:26AM +0200, Roedel, Joerg wrote: > On Tue, Aug 23, 2011 at 12:54:27PM -0400, aafabbri wrote: > > On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > > > That is makes uiommu basically the same as the meta-groups, right? > > > > Yes, functionality seems the same, thus my sugg

Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2

2011-08-24 Thread malc
On Tue, 23 Aug 2011, Richard Henderson wrote: > The problem that malc saw with sb16 was a major think-o on my part > with the whole interface. We can't re-use the const sub-arrays of > the original MemoryRegionPortio array because they have the wrong > offset for the MemoryRegion to which it is a

Re: [Qemu-devel] PPC* and Sparc32 crash

2011-08-24 Thread Avi Kivity
On 08/23/2011 08:55 PM, Blue Swirl wrote: qemu-system-ppc: /src/qemu/memory.c:1183: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. Aborted qemu-system-ppc64: /src/qemu/memory.c:1183: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. Aborted qem

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Avi Kivity
On 08/08/2011 10:31 PM, Anthony Liguori wrote: We've always listened on port 501 for vgabios panic messages. In the entire time I've worked on QEMU, I've never actually seen a vgabios panic message :-) If we change the semantics of this port a little bit, it makes it possible to use it for more

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 04:59:16PM -0400, Don Dutile wrote: > So we want to pollute the dev assignment code with knowledge of this array > for bounds checking, which you're threatening to remove? OKay, I'll stop being a mule, and apply that patch. -- MST

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > From: Alex Williamson > > Nothing good can happen when we overlap capabilities > > [ Jan: rebased over qemu, minor formatting ] > > Signed-off-by: Jan Kiszka This doesn't build for me: /scm/qemu/hw/pci.c: In function ‘pci_add_capa

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 12:04, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: >> From: Alex Williamson >> >> Nothing good can happen when we overlap capabilities >> >> [ Jan: rebased over qemu, minor formatting ] >> >> Signed-off-by: Jan Kiszka > > This doesn't bui

[Qemu-devel] [PATCH 13/24] cirrus: wrap memory update in a transaction

2011-08-24 Thread Avi Kivity
This prevents spurious unmapping and remapping of the vga windows, which reduces performance. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 4d0ef0d..ec7ea82 100644 --- a/hw/cirrus_vg

[Qemu-devel] [PATCH 16/24] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-24 Thread Avi Kivity
cfi02 is annoying in that is ignores some address bits; we probably want explicit support in the memory API for that. Signed-off-by: Avi Kivity --- hw/collie.c | 17 --- hw/flash.h| 16 +-- hw/gumstix.c | 29 +++- hw/lm

Re: [Qemu-devel] [PATCH 01/24] arm_sysctl: convert to memory API

2011-08-24 Thread Peter Maydell
On 24 August 2011 11:11, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- >  hw/arm_sysctl.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c > index 17cf6f7..5b845a2 100644 > --- a/hw/arm_sysctl.c > +++ b/hw/arm_sysctl.c > @@ -19,

Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

2011-08-24 Thread Peter Maydell
On 24 August 2011 11:11, Avi Kivity wrote: > Avoids get_system_memory() everywhere. > -    machine->init(ram_size, boot_devices, > +    machine->init(get_system_memory(), get_system_io(), ram_size, > boot_devices, >                   kernel_filename, kernel_cmdline, initrd_filename, > cpu_model

[Qemu-devel] [PATCH 18/24] g364fb: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/g364fb.c| 61 +++ hw/mips.h |4 ++- hw/mips_jazz.c |3 +- 3 files changed, 39 insertions(+), 29 deletions(-) diff --git a/hw/g364fb.c b/hw/g364fb.c index b3020c5..d081bb4 100644 --- a/hw/g364f

[Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mcf5208.c | 71 + 1 files changed, 31 insertions(+), 40 deletions(-) diff --git a/hw/mcf5208.c b/hw/mcf5208.c index f4d4fbd..73c6961 100644 --- a/hw/mcf5208.c +++ b/hw/mcf5208.c @@ -5,6 +5,7 @@ * * Thi

Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API

2011-08-24 Thread Peter Maydell
On 24 August 2011 11:11, Avi Kivity wrote: > diff --git a/hw/mcf5208.c b/hw/mcf5208.c > index f4d4fbd..73c6961 100644 > --- a/hw/mcf5208.c > +++ b/hw/mcf5208.c > @@ -5,6 +5,7 @@ >  * >  * This code is licensed under the GPL >  */ > +#include >  #include "hw.h" >  #include "mcf.h" >  #include "qem

[Qemu-devel] [PATCH 20/24] mainstone: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mainstone.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/mainstone.c b/hw/mainstone.c index cb62abb..ae7a542 100644 --- a/hw/mainstone.c +++ b/hw/mainstone.c @@ -91,7 +91,8 @@ static struct arm_boot_info mainstone_binfo =

Re: [Qemu-devel] [PATCH 01/24] arm_sysctl: convert to memory API

2011-08-24 Thread Avi Kivity
On 08/24/2011 01:23 PM, Peter Maydell wrote: On 24 August 2011 11:11, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- >hw/arm_sysctl.c |1 + >1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c > index 17cf6f7..5b845a2 100644 >

[Qemu-devel] [PATCH 02/24] stellaris_enet: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/stellaris_enet.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c index f9bd3da..d5613ff 100644 --- a/hw/stellaris_enet.c +++ b/hw/stellaris_enet.c @@ -69,7 +69,7 @@ ty

[Qemu-devel] [PATCH 15/24] Makefile.hw: allow hw/ files to include glib headers

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- Makefile.hw |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.hw b/Makefile.hw index 659e441..63eb7e4 100644 --- a/Makefile.hw +++ b/Makefile.hw @@ -10,6 +10,7 @@ include $(SRC_PATH)/rules.mak $(call set-vpath, $(SRC_PATH):$(SRC_PATH)

Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

2011-08-24 Thread Avi Kivity
On 08/24/2011 01:32 PM, Peter Maydell wrote: On 24 August 2011 11:11, Avi Kivity wrote: > Avoids get_system_memory() everywhere. > -machine->init(ram_size, boot_devices, > +machine->init(get_system_memory(), get_system_io(), ram_size, boot_devices, > kernel_filen

Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API

2011-08-24 Thread Avi Kivity
On 08/24/2011 01:35 PM, Peter Maydell wrote: On 24 August 2011 11:11, Avi Kivity wrote: > diff --git a/hw/mcf5208.c b/hw/mcf5208.c > index f4d4fbd..73c6961 100644 > --- a/hw/mcf5208.c > +++ b/hw/mcf5208.c > @@ -5,6 +5,7 @@ >* >* This code is licensed under the GPL >*/ > +#inclu

[Qemu-devel] [PATCH 01/24] arm_sysctl: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/arm_sysctl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c index 17cf6f7..5b845a2 100644 --- a/hw/arm_sysctl.c +++ b/hw/arm_sysctl.c @@ -19,6 +19,7 @@ typedef struct { SysBusDevice busdev; Memo

Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

2011-08-24 Thread Peter Maydell
On 24 August 2011 11:46, Avi Kivity wrote: > On 08/24/2011 01:32 PM, Peter Maydell wrote: >> >> On 24 August 2011 11:11, Avi Kivity  wrote: >> >  Avoids get_system_memory() everywhere. >> >> >  -    machine->init(ram_size, boot_devices, >> >  +    machine->init(get_system_memory(), get_system_io()

[Qemu-devel] [PATCH 08/24] armv7m: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/arm-misc.h |5 - hw/armv7m.c| 24 ++-- hw/stellaris.c |3 ++- 3 files changed, 20 insertions(+), 12 deletions(-) diff --git a/hw/arm-misc.h b/hw/arm-misc.h index f8a7472..af403a1 100644 --- a/hw/arm-misc.h +++ b/hw/arm-misc.

[Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In CVE-2011-0011 it was noted that setting an empty password would disable all authentication for the VNC password. Commit 1cd20f8bf0ecb9d1d1bd5e2ffab3b88835380c9b attempted to fix this but it just broke it in a different way, because now instead of blindly disabling al

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > On 2011-08-24 12:04, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > >> From: Alex Williamson > >> > >> Nothing good can happen when we overlap capabilities > >> > >> [ Jan: rebased over qemu,

[Qemu-devel] [PATCH 12/24] leon3: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/leon3.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/leon3.c b/hw/leon3.c index efe6c7c..5c3780d 100644 --- a/hw/leon3.c +++ b/hw/leon3.c @@ -21,6 +21,9 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR O

[Qemu-devel] [PATCH 00/24] Memory API conversions, batch 5

2011-08-24 Thread Avi Kivity
This is a collection of random conversions to devices to the new memory API. Some qemu interfaces are also update, for example machine creation and sysbus. Please review. If all is fine, I will post a [PULL] request for the batch (in git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-24 Thread Roedel, Joerg
On Wed, Aug 24, 2011 at 05:33:00AM -0400, David Gibson wrote: > On Wed, Aug 24, 2011 at 11:14:26AM +0200, Roedel, Joerg wrote: > > I don't see a reason to make this meta-grouping static. It would harm > > flexibility on x86. I think it makes things easier on power but there > > are options on that

[Qemu-devel] [PATCH 17/24] dummy_m68k: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/dummy_m68k.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/dummy_m68k.c b/hw/dummy_m68k.c index 2de69ad..609d04c 100644 --- a/hw/dummy_m68k.c +++ b/hw/dummy_m68k.c @@ -6,6 +6,7 @@ * This code is licensed under the GPL */ +#

Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

2011-08-24 Thread Avi Kivity
On 08/24/2011 01:53 PM, Peter Maydell wrote: > The purpose here is to allow removal of get_system_memory() from > the general code base. The right way to remove get_system_memory() from the general code base is to actually model things correctly, for instance by having machine models create a

Re: [Qemu-devel] [PATCH 11/24] integratorcp: convert to memory API (RAM/flash only)

2011-08-24 Thread Peter Maydell
On 24 August 2011 11:11, Avi Kivity wrote: > @@ -108,9 +111,15 @@ static uint32_t integratorcm_read(void *opaque, > target_phys_addr_t offset) >  static void integratorcm_do_remap(integratorcm_state *s, int flash) >  { >     if (flash) { > -        cpu_register_physical_memory(0, 0x10, IO_MEM

[Qemu-devel] [PATCH 04/24] pci_host: convert conf index and data ports to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/dec_pci.c | 13 hw/grackle_pci.c | 13 hw/pci_host.c| 86 -- hw/pci_host.h| 16 -- hw/piix_pci.c| 11 +- hw/ppc4xx_pci.c | 10 -- hw/ppce500_pci.c |

[Qemu-devel] [PATCH 10/24] sysbus: add sysbus_add_memory_overlap()

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sysbus.c |6 ++ hw/sysbus.h |2 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index f5f0ed2..4efb91a 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -263,6 +263,12 @@ void sysbus_add_memory(SysBusDevice *dev,

[Qemu-devel] [PATCH 22/24] milkymist-minimac2: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/milkymist-minimac2.c | 43 +-- 1 files changed, 21 insertions(+), 22 deletions(-) diff --git a/hw/milkymist-minimac2.c b/hw/milkymist-minimac2.c index cd36026..fb48e37 100644 --- a/hw/milkymist-minimac2.c +++ b/hw/milkymi

Re: [Qemu-devel] [PATCH 11/24] integratorcp: convert to memory API (RAM/flash only)

2011-08-24 Thread Avi Kivity
On 08/24/2011 02:22 PM, Peter Maydell wrote: On 24 August 2011 11:11, Avi Kivity wrote: > @@ -108,9 +111,15 @@ static uint32_t integratorcm_read(void *opaque, target_phys_addr_t offset) >static void integratorcm_do_remap(integratorcm_state *s, int flash) >{ > if (flash) { > -

[Qemu-devel] [PATCH 23/24] milkymist-softusb: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/milkymist-softusb.c | 48 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c index fe4eedb..ef4d9ee 100644 --- a/hw/milkymist-softusb.c +++ b/hw/milkym

[Qemu-devel] [PATCH 14/24] piix_pci: wrap memory update in a transaction

2011-08-24 Thread Avi Kivity
The code will remap all PAMs, even if just one is updated, resulting in reduced performance. Wrap in a transaction to detect that those other PAMs have not changed. Signed-off-by: Avi Kivity --- hw/piix_pci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/piix_pci.

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-24 Thread Saggi Mizrahi
On Tue 23 Aug 2011 07:21:56 PM IDT, Anthony Liguori wrote: On 08/23/2011 11:18 AM, Daniel P. Berrange wrote: On Tue, Aug 23, 2011 at 11:14:20AM -0500, Anthony Liguori wrote: On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: $(block-obj-y) pulls in 'aio.o' which is built from aio.c which is lic

[Qemu-devel] [PATCH 19/24] lm32_boards: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/lm32_boards.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/lm32_boards.c b/hw/lm32_boards.c index 3c6b5af..0a9ad59 100644 --- a/hw/lm32_boards.c +++ b/hw/lm32_boards.c @@ -79,7 +79,7 @@ static void lm32_evr_init(MemoryRegi

[Qemu-devel] [PATCH 03/24] sysbus: add helpers to add and delete memory regions to the system bus

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sysbus.c | 22 ++ hw/sysbus.h |6 ++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index f39768b..f5f0ed2 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -256,3 +256,25 @@ static char *sysbus_

[Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

2011-08-24 Thread Avi Kivity
Avoids get_system_memory() everywhere. Signed-off-by: Avi Kivity --- hw/an5206.c |4 ++- hw/axis_dev88.c |4 ++- hw/boards.h |5 +++- hw/collie.c |4 ++- hw/dummy_m68k.c |4 ++- hw/gumstix.c

[Qemu-devel] [PATCH 05/24] ReadWriteHandler: remove

2011-08-24 Thread Avi Kivity
No longer used. Signed-off-by: Avi Kivity --- Makefile.target |1 - rwhandler.c | 87 --- rwhandler.h | 27 - 3 files changed, 0 insertions(+), 115 deletions(-) delete mode 100644 rwhandler.c delete mode 100644

Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API

2011-08-24 Thread Peter Maydell
On 24 August 2011 11:47, Avi Kivity wrote: > On 08/24/2011 01:35 PM, Peter Maydell wrote: >> >> On 24 August 2011 11:11, Avi Kivity  wrote: >> >  diff --git a/hw/mcf5208.c b/hw/mcf5208.c >> >  index f4d4fbd..73c6961 100644 >> >  --- a/hw/mcf5208.c >> >  +++ b/hw/mcf5208.c >> >  @@ -5,6 +5,7 @@ >>

[Qemu-devel] [PATCH 24/24] milkymist: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/milkymist.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/milkymist.c b/hw/milkymist.c index 74994a7..09de681 100644 --- a/hw/milkymist.c +++ b/hw/milkymist.c @@ -85,7 +85,7 @@ milkymist_init(MemoryRegion *address_space_mem,

[Qemu-devel] [PATCH 11/24] integratorcp: convert to memory API (RAM/flash only)

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/integratorcp.c | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 3d4b339..720cc02 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -7,6 +7,8 @@ * This code is

[Qemu-devel] [PATCH 07/24] an5206: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/an5206.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/an5206.c b/hw/an5206.c index e34de39..9a91984 100644 --- a/hw/an5206.c +++ b/hw/an5206.c @@ -6,6 +6,8 @@ * This code is licensed under the GPL */ +#include + #i

Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API

2011-08-24 Thread Avi Kivity
On 08/24/2011 02:38 PM, Peter Maydell wrote: On 24 August 2011 11:47, Avi Kivity wrote: > On 08/24/2011 01:35 PM, Peter Maydell wrote: >> >> On 24 August 2011 11:11, Avi Kivitywrote: >> >diff --git a/hw/mcf5208.c b/hw/mcf5208.c >> >index f4d4fbd..73c6961 100644 >> >--- a/hw/

[Qemu-devel] [PATCH 09/24] axis_dev88: convert to memory API (RAM only)

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/axis_dev88.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/axis_dev88.c b/hw/axis_dev88.c index cfc89c2..04a3d5b 100644 --- a/hw/axis_dev88.c +++ b/hw/axis_dev88.c @@ -22,6 +22,8 @@ * THE SOFTWARE. */ +#include +

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > On 2011-08-24 12:04, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > >> From: Alex Williamson > >> > >> Nothing good can happen when we overlap capabilities > >> > >> [ Jan: rebased over qemu,

[Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Avi Kivity
Newer gcc complains that base and size may be used uninitialized, even though it is clearly a false warning. Silence the warning by indicating to gcc that the code path triggering the warning cannot happen. Signed-off-by: Avi Kivity --- hw/vga.c |2 ++ 1 files changed, 2 insertions(+), 0 de

Re: [Qemu-devel] [PATCH] qemu-coroutine: Add simple work queue support

2011-08-24 Thread Stefan Hajnoczi
On Wed, Aug 24, 2011 at 05:57:51PM +1000, Peter A. G. Crosthwaite wrote: > Add a function co_queue_yield_to_next() which will immediately transfer > control to the coroutine at the head of a co queue. This can be used for > implementing simple work queues where the manager of a co-queue only > need

Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

2011-08-24 Thread Avi Kivity
On 08/24/2011 02:18 PM, Avi Kivity wrote: On 08/24/2011 01:53 PM, Peter Maydell wrote: > The purpose here is to allow removal of get_system_memory() from > the general code base. The right way to remove get_system_memory() from the general code base is to actually model things correctly, for

[Qemu-devel] [PATCH v2] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
Nothing good can happen when we overlap capabilities. This may happen when plugging in assigned devices or when devices models contain bugs. Detect the overlap and report it. Based on qemu-kvm commit by Alex Williamson. Signed-off-by: Jan Kiszka --- hw/pci.c | 34 +

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 13:58, Michael S. Tsirkin wrote: > On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: >> On 2011-08-24 12:04, Michael S. Tsirkin wrote: >>> On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: From: Alex Williamson Nothing good can happen when we overla

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: > On 2011-08-24 13:58, Michael S. Tsirkin wrote: > > On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > >> On 2011-08-24 12:04, Michael S. Tsirkin wrote: > >>> On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > F

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:34, Michael S. Tsirkin wrote: > On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: >> On 2011-08-24 13:58, Michael S. Tsirkin wrote: >>> On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: On 2011-08-24 12:04, Michael S. Tsirkin wrote: > On Tue, Aug 23, 20

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Anthony Liguori
On 08/24/2011 04:47 AM, Avi Kivity wrote: On 08/08/2011 10:31 PM, Anthony Liguori wrote: We've always listened on port 501 for vgabios panic messages. In the entire time I've worked on QEMU, I've never actually seen a vgabios panic message :-) If we change the semantics of this port a little bi

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 02:36:31PM +0200, Jan Kiszka wrote: > On 2011-08-24 14:34, Michael S. Tsirkin wrote: > > On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: > >> On 2011-08-24 13:58, Michael S. Tsirkin wrote: > >>> On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:39, Michael S. Tsirkin wrote: > On Wed, Aug 24, 2011 at 02:36:31PM +0200, Jan Kiszka wrote: >> On 2011-08-24 14:34, Michael S. Tsirkin wrote: >>> On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: On 2011-08-24 13:58, Michael S. Tsirkin wrote: > On Wed, Aug 24, 20

Re: [Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Anthony Liguori
On 08/24/2011 06:01 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" In CVE-2011-0011 it was noted that setting an empty password would disable all authentication for the VNC password. Commit 1cd20f8bf0ecb9d1d1bd5e2ffab3b88835380c9b attempted to fix this but it just broke it in a differe

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:07, Avi Kivity wrote: > Newer gcc complains that base and size may be used uninitialized, even though > it is clearly a false warning. Mmh, gcc is getting dumber again. > Silence the warning by indicating to gcc that > the code path triggering the warning cannot happen. > > Sig

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-24 Thread Anthony Liguori
On 08/24/2011 06:32 AM, Saggi Mizrahi wrote: On Tue 23 Aug 2011 07:21:56 PM IDT, Anthony Liguori wrote: But QEMU is GPL. Libraries derived from QEMU will also be GPL. Regards, Anthony Liguori Regards, Daniel OK, I admit it was a pretty naive solution. But I always try to do the simplest s

Re: [Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 07:45:06AM -0500, Anthony Liguori wrote: > On 08/24/2011 06:01 AM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange" > > > >In CVE-2011-0011 it was noted that setting an empty password > >would disable all authentication for the VNC password. Commit > >1cd20f8bf0ecb9d1

Re: [Qemu-devel] [PATCH v2] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 02:29:30PM +0200, Jan Kiszka wrote: > Nothing good can happen when we overlap capabilities. This may happen > when plugging in assigned devices or when devices models contain bugs. > Detect the overlap and report it. > > Based on qemu-kvm commit by Alex Williamson. > > Sig

Re: [Qemu-devel] [PATCH] sheepdog: use coroutines

2011-08-24 Thread Kevin Wolf
Am 23.08.2011 19:14, schrieb MORITA Kazutaka: > At Tue, 23 Aug 2011 14:29:50 +0200, > Kevin Wolf wrote: >> >> Am 12.08.2011 14:33, schrieb MORITA Kazutaka: >>> This makes the sheepdog block driver support bdrv_co_readv/writev >>> instead of bdrv_aio_readv/writev. >>> >>> With this patch, Sheepdog n

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 07:50:37AM -0500, Anthony Liguori wrote: > On 08/24/2011 06:32 AM, Saggi Mizrahi wrote: > >On Tue 23 Aug 2011 07:21:56 PM IDT, Anthony Liguori wrote: > >>But QEMU is GPL. Libraries derived from QEMU will also be GPL. > >> > >>Regards, > >> > >>Anthony Liguori > >> > >>> > >>

Re: [Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Anthony Liguori
On 08/24/2011 07:50 AM, Daniel P. Berrange wrote: On Wed, Aug 24, 2011 at 07:45:06AM -0500, Anthony Liguori wrote: On 08/24/2011 06:01 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" In CVE-2011-0011 it was noted that setting an empty password would disable all authentication for the

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Avi Kivity
On 08/24/2011 03:38 PM, Anthony Liguori wrote: diff --git a/hw/pc.c b/hw/pc.c index 1c9d89a..4b07b35 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -549,8 +549,7 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) /* LGPL'ed VGA BIOS messages */ case 0x501: case 0x502: - fprintf(

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Avi Kivity
On 08/24/2011 03:46 PM, Jan Kiszka wrote: > +++ b/hw/vga.c > @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) > base = 0xb8000; > size = 0x8000; > break; > +default: > +abort(); > } >

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:58, Avi Kivity wrote: > On 08/24/2011 03:46 PM, Jan Kiszka wrote: >>> +++ b/hw/vga.c >>> @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) >>> base = 0xb8000; >>> size = 0x8000; >>> break; >>> +default:

Re: [Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 07:55:38AM -0500, Anthony Liguori wrote: > On 08/24/2011 07:50 AM, Daniel P. Berrange wrote: > >On Wed, Aug 24, 2011 at 07:45:06AM -0500, Anthony Liguori wrote: > >>On 08/24/2011 06:01 AM, Daniel P. Berrange wrote: > >>>From: "Daniel P. Berrange" > >>> > >>>In CVE-2011-0011

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Anthony Liguori
On 08/24/2011 07:55 AM, Avi Kivity wrote: On 08/24/2011 03:38 PM, Anthony Liguori wrote: diff --git a/hw/pc.c b/hw/pc.c index 1c9d89a..4b07b35 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -549,8 +549,7 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) /* LGPL'ed VGA BIOS mes

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Avi Kivity
On 08/24/2011 04:02 PM, Anthony Liguori wrote: Too subtle, IMO. I understand that we want to avoid a full qmp parser for one-off unit tests, but using bit fields in the exit code? Perhaps a python script that launches qemu with qmp and -no-shutdown, listens for the guest shutdown event, and prin

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Avi Kivity
On 08/24/2011 04:00 PM, Jan Kiszka wrote: On 2011-08-24 14:58, Avi Kivity wrote: > On 08/24/2011 03:46 PM, Jan Kiszka wrote: >>> +++ b/hw/vga.c >>> @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) >>>base = 0xb8000; >>>size = 0x8000

[Qemu-devel] [PATCH v2 01/22] stellaris_enet: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/stellaris_enet.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c index f9bd3da..d5613ff 100644 --- a/hw/stellaris_enet.c +++ b/hw/stellaris_enet.c @@ -69,7 +69,7 @@ ty

[Qemu-devel] [PATCH v2 08/22] sysbus: add sysbus_add_memory_overlap()

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sysbus.c |6 ++ hw/sysbus.h |2 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index f5f0ed2..4efb91a 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -263,6 +263,12 @@ void sysbus_add_memory(SysBusDevice *dev,

[Qemu-devel] [PATCH v2 02/22] sysbus: add helpers to add and delete memory regions to the system bus

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sysbus.c | 22 ++ hw/sysbus.h |6 ++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index f39768b..f5f0ed2 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -256,3 +256,25 @@ static char *sysbus_

[Qemu-devel] [PATCH v2 22/22] milkymist: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/milkymist.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/milkymist.c b/hw/milkymist.c index 092d8b0..ef21cca 100644 --- a/hw/milkymist.c +++ b/hw/milkymist.c @@ -29,6 +29,7 @@ #include "blockdev.h" #include "milkymist-hw.h"

[Qemu-devel] [PATCH v2 15/22] dummy_m68k: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/dummy_m68k.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/dummy_m68k.c b/hw/dummy_m68k.c index eed9e38..30146b9 100644 --- a/hw/dummy_m68k.c +++ b/hw/dummy_m68k.c @@ -10,6 +10,7 @@ #include "boards.h" #include "loader.h" #in

[Qemu-devel] [PATCH v2 14/22] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-24 Thread Avi Kivity
cfi02 is annoying in that is ignores some address bits; we probably want explicit support in the memory API for that. Signed-off-by: Avi Kivity --- hw/collie.c | 16 --- hw/flash.h| 16 +-- hw/gumstix.c | 28 +++- hw/lm

[Qemu-devel] [PATCH v2 19/22] mcf5208: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mcf5208.c | 72 + 1 files changed, 32 insertions(+), 40 deletions(-) diff --git a/hw/mcf5208.c b/hw/mcf5208.c index 8fe507f..1c2c0c4 100644 --- a/hw/mcf5208.c +++ b/hw/mcf5208.c @@ -13,6 +13,7 @@ #include

[Qemu-devel] [PATCH v2 04/22] ReadWriteHandler: remove

2011-08-24 Thread Avi Kivity
No longer used. Signed-off-by: Avi Kivity --- Makefile.target |1 - rwhandler.c | 87 --- rwhandler.h | 27 - 3 files changed, 0 insertions(+), 115 deletions(-) delete mode 100644 rwhandler.c delete mode 100644

[Qemu-devel] [PATCH v2 07/22] axis_dev88: convert to memory API (RAM only)

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/axis_dev88.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/axis_dev88.c b/hw/axis_dev88.c index 06200e2..73eb39d 100644 --- a/hw/axis_dev88.c +++ b/hw/axis_dev88.c @@ -31,6 +31,7 @@ #include "elf.h" #include "cris-boo

[Qemu-devel] [PATCH v2 21/22] milkymist-softusb: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/milkymist-softusb.c | 48 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c index fe4eedb..ef4d9ee 100644 --- a/hw/milkymist-softusb.c +++ b/hw/milkym

[Qemu-devel] [PATCH v2 03/22] pci_host: convert conf index and data ports to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/dec_pci.c | 13 hw/grackle_pci.c | 13 hw/pci_host.c| 86 -- hw/pci_host.h| 16 -- hw/piix_pci.c| 11 +- hw/ppc4xx_pci.c | 10 -- hw/ppce500_pci.c |

[Qemu-devel] [PATCH v2 09/22] integratorcp: convert to memory API (RAM/flash only)

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/integratorcp.c | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 2814108..3c8982e 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -13,11 +13,13 @@ #include "b

[Qemu-devel] [PATCH v2 20/22] milkymist-minimac2: convert to memory API

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/milkymist-minimac2.c | 43 +-- 1 files changed, 21 insertions(+), 22 deletions(-) diff --git a/hw/milkymist-minimac2.c b/hw/milkymist-minimac2.c index cd36026..fb48e37 100644 --- a/hw/milkymist-minimac2.c +++ b/hw/milkymi

[Qemu-devel] [PATCH v2 13/22] Makefile.hw: allow hw/ files to include glib headers

2011-08-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- Makefile.hw |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.hw b/Makefile.hw index 659e441..63eb7e4 100644 --- a/Makefile.hw +++ b/Makefile.hw @@ -10,6 +10,7 @@ include $(SRC_PATH)/rules.mak $(call set-vpath, $(SRC_PATH):$(SRC_PATH)

  1   2   3   >