Re: [Qemu-devel] VMState assertion for USB devices on multiple buses

2011-08-22 Thread Gerd Hoffmann
On 08/18/11 20:04, Daniel P. Berrange wrote: I've been experimenting with multiple USB2 buses, and device physical port addressing. It seems if you have 2 devices of the same type on the same port, but in different buses, you get a bogus VMState assertion failure qemu-system-x86_64: savev

Re: [Qemu-devel] [PATCH v2 00/24] Memory API batch 4: more conversions

2011-08-22 Thread Avi Kivity
On 08/15/2011 05:17 PM, Avi Kivity wrote: This patchset converts a few more devices (and boards) to the memory API. Nothing is really interesting except for the last patch, which brings proper PAM support (and better SMRAM emulation). It should also fix the regressions that were reported in some

[Qemu-devel] [PATCH 1/2] xilinx.h: Added missing includes

2011-08-22 Thread Peter A. G. Crosthwaite
Added some missing #includes for this file. Previously this file relied on its clients to pre-include its dependencies. Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xilinx.h b/hw/xilinx.h index 090e6f7..3a1f4c

[Qemu-devel] [PATCH 2/2] xilinx: removed microbalze_pic_init from xilinx.h

2011-08-22 Thread Peter A. G. Crosthwaite
This is a microblaze target specific function that belongs outside of xilinx.h (which is a collection of target independent device model instantiator functions) Signed-off-by: Peter A. G. Crosthwaite --- hw/microblaze_pic_cpu.c |2 +- hw/microblaze_pic_cpu.h |8 hw/p

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix up some style nits of last uq/master merge

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 15, 2011 at 04:24:48PM -0700, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka > --- > cutils.c |2 +- > target-i386/kvm.c |5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/sho

Re: [Qemu-devel] [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-22 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:00 PM, Raghavendra D Prabhu wrote: > The gnutls_*_set_priority family of functions has been marked deprecated > in 2.12.x. These functions have been superceded by > gnutls_priority_set_direct(). > > Signed-off-by: Raghavendra D Prabhu > --- >  ui/vnc-tls.c |   20 +--

Re: [Qemu-devel] [RFC PATCH v4 3/5] separate migration bitmap

2011-08-22 Thread Paolo Bonzini
On 08/21/2011 03:41 AM, Umesh Deshpande wrote: This should be run under the iothread lock. Pay attention to avoiding lock inversion: the I/O thread always takes the iothread lock outside and the ramlist lock within, so the migration thread must do the same. BTW, I think this code in the migrat

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 12:25:47AM +0200, Christoph Hellwig wrote: > changes since V1: > - rebase to apply against the current qemu.git tree Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23)

2011-08-22 Thread Stefan Hajnoczi
On Sat, Aug 20, 2011 at 04:29:50PM +0200, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > hw/pcnet-pci.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-22 Thread Avi Kivity
On 08/17/2011 07:19 AM, Liu, Jinsong wrote: From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 2001 From: Liu, Jinsong Date: Wed, 17 Aug 2011 11:36:28 +0800 Subject: [PATCH] KVM: emulate lapic tsc deadline timer for hvm kvm doesn't have hvm. This patch emulate lapic tsc deadli

[Qemu-devel] [PATCH 00/11] Goldfish

2011-08-22 Thread Patrick Jackson
This patchset is a step towards integrating the Goldfish hardware that is necessary to run Android in QEMU. It contains all of the devices that I was able to get working during my GSOC project, but is missing several important devices and as a result does not allow for a usable Android OS (Specific

[Qemu-devel] [PATCH 01/11] Goldfish: Create a minimal "android_arm" machine.

2011-08-22 Thread Patrick Jackson
Signed-off-by: Patrick Jackson --- Makefile.target |1 + hw/android_arm.c | 76 ++ 2 files changed, 77 insertions(+), 0 deletions(-) create mode 100644 hw/android_arm.c diff --git a/Makefile.target b/Makefile.target index 096214a..790f7

[Qemu-devel] [PATCH 02/11] Goldfish: Adding devices for handling qdev needs in goldfish.

2011-08-22 Thread Patrick Jackson
This commit includes a bridge device and a bus, as well as necessary access functions. Signed-off-by: Patrick Jackson --- Makefile.target |2 +- hw/goldfish_device.c | 294 ++ hw/goldfish_device.h | 52 + 3 files changed, 347 in

[Qemu-devel] [PATCH 03/11] Goldfish: Added an interrupt device.

2011-08-22 Thread Patrick Jackson
Signed-off-by: Patrick Jackson --- Makefile.target |2 +- hw/android_arm.c|5 ++ hw/goldfish_device.h|1 + hw/goldfish_interrupt.c | 182 +++ 4 files changed, 189 insertions(+), 1 deletions(-) create mode 100644 hw/gold

[Qemu-devel] [PATCH 04/11] Goldfish: Added timing devices.

2011-08-22 Thread Patrick Jackson
Includes a timer and a real time clock. Signed-off-by: Patrick Jackson --- Makefile.target |2 +- hw/android_arm.c |2 + hw/goldfish_device.h |2 + hw/goldfish_timer.c | 241 ++ 4 files changed, 246 insertions(+), 1 deletions

[Qemu-devel] [PATCH 05/11] Goldfish: Added a tty device:

2011-08-22 Thread Patrick Jackson
This device allows for viewing the kernel output using the command line options below. -append "console=ttyS0" -serial stdio Signed-off-by: Patrick Jackson --- Makefile.target |1 + hw/android_arm.c |9 ++ hw/goldfish_device.h |1 + hw/goldfish_tty.c| 227 +

[Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger device.

2011-08-22 Thread Patrick Jackson
Signed-off-by: Patrick Jackson --- Makefile.target |2 +- hw/android_arm.c |1 + hw/goldfish_device.h |1 + hw/goldfish_memlog.c | 106 ++ 4 files changed, 109 insertions(+), 1 deletions(-) create mode 100644 hw/goldfish_memlo

[Qemu-devel] [PATCH 10/11] Goldfish: Added switch device.

2011-08-22 Thread Patrick Jackson
Signed-off-by: Patrick Jackson --- Makefile.target |2 +- hw/android_arm.c | 18 + hw/goldfish_device.h |2 + hw/goldfish_switch.c | 168 ++ 4 files changed, 189 insertions(+), 1 deletions(-) create mode 100644 hw/goldfish_s

[Qemu-devel] [PATCH 09/11] Goldfish: Added battery device.

2011-08-22 Thread Patrick Jackson
Signed-off-by: Patrick Jackson --- Makefile.target |1 + hw/android_arm.c |1 + hw/goldfish_battery.c | 247 + hw/goldfish_device.h |3 + hw/power_supply.h | 109 ++ 5 files changed, 361 insertions(+

[Qemu-devel] [PATCH 11/11] Goldfish: Added device setup for NICs.

2011-08-22 Thread Patrick Jackson
Signed-off-by: Patrick Jackson --- hw/android_arm.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/android_arm.c b/hw/android_arm.c index 5d8372d..f85db5c 100644 --- a/hw/android_arm.c +++ b/hw/android_arm.c @@ -74,6 +74,25 @@ static void android_ar

Re: [Qemu-devel] [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-22 Thread Gerd Hoffmann
On 08/22/11 10:26, Stefan Hajnoczi wrote: On Mon, Jul 4, 2011 at 11:00 PM, Raghavendra D Prabhu wrote: The gnutls_*_set_priority family of functions has been marked deprecated in 2.12.x. These functions have been superceded by gnutls_priority_set_direct(). Signed-off-by: Raghavendra D Prabhu

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-22 Thread Avi Kivity
On 08/11/2011 10:01 PM, Gerhard Wiesinger wrote: On Thu, 11 Aug 2011, Avi Kivity wrote: Or maybe it's just -O2 screwing up debug information. Please change ./configure to set -O1 and redo. Please print *r.memory as well. ./configure --target-list=x86_64-softmmu,i386-softmmu --enable-debug R

[Qemu-devel] TCG sar UB

2011-08-22 Thread malc
While booting linux-test 0.2 following sequence of instructions is seen: IN: 0xc03227aa: mov%esi,%edx 0xc03227ac: xor%ecx,%ecx 0xc03227ae: movzwl 0x12(%esp),%ebp 0xc03227b3: mov%edi,%eax 0xc03227b5: sar%cl,%eax 0xc03227b7: and$0x1,%eax 0xc03227ba: je 0xc0322802 OP

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Joerg Roedel
On Mon, Aug 22, 2011 at 02:30:26AM -0400, Avi Kivity wrote: > On 08/20/2011 07:51 PM, Alex Williamson wrote: > > We need to address both the description and enforcement of device > > groups. Groups are formed any time the iommu does not have resolution > > between a set of devices. On x86, this t

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 01:46 PM, Joerg Roedel wrote: > $ readlink /sys/devices/pci:00/:00:19.0/iommu_group > ../../../path/to/device/which/represents/the/resource/constraint > > (the pci-to-pci bridge on x86, or whatever node represents partitionable > endpoints on power) That does not work.

Re: [Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger device.

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 10:39 AM, Patrick Jackson wrote: > +static void memlog_write(void *opaque, target_phys_addr_t offset, uint32_t > val) > +{ > +    static unsigned info[8]; The size should be 2, not 8. Using a static variable is a bit lazy here. We're already accessing GoldfishMemlogDevic

Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 10:39 AM, Patrick Jackson wrote: > > The paths to the system images must be specified from the command line as > follows. > -global goldfish_nand.system_init_path=/path/to/initial/system/image -global > goldfish_nand.user_data_path=/path/to/user/data > Signed-off-by: Patric

[Qemu-devel] [Bug 830558] [NEW] VF doesn't work in guest when not pinned with "addr="

2011-08-22 Thread Launchpad Bug Tracker
You have been subscribed to a public bug: Environment: Host OS (ia32/ia32e/IA64):All Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):Linux (rhel6 and rhel5u5) kvm.git Commit:ef7c782ea4a99fafb3d60dc8b8c057e0ef14f9f7 qemu-kvm Commit:44755ea36fee3f0b1093ef27404def885760227

[Qemu-devel] [Bug 739088] [NEW] I/O errors after "Save/Restore"

2011-08-22 Thread Launchpad Bug Tracker
You have been subscribed to a public bug: qemu-kvm commit: b73357ecd2b14c057134cb71d29447b5b988c516 ( Author: Marcelo Tosatti Date: Wed Mar 16 17:04:16 2011 -0300) kvm commit: a72e315c509376bbd1e121219c3ad9f23973923f After restoring from saved img, some I/O errors appear in dmesg and file

[Qemu-devel] [Bug 830558] Re: VF doesn't work in guest when not pinned with "addr="

2011-08-22 Thread Yongjie Ren
** Project changed: qemu-kvm => qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/830558 Title: VF doesn't work in guest when not pinned with "addr=" Status in QEMU: New Bug description: Env

[Qemu-devel] [Bug 739088] Re: I/O errors after "Save/Restore"

2011-08-22 Thread Yongjie Ren
** Project changed: qemu-kvm => qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739088 Title: I/O errors after "Save/Restore" Status in QEMU: New Bug description: qemu-kvm commit: b73357ec

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 06:51:35AM -0400, Avi Kivity wrote: > On 08/22/2011 01:46 PM, Joerg Roedel wrote: > > That does not work. The bridge in question may not even be visible as a > > PCI device, so you can't link to it. This is the case on a fe

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 03:55 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: > On 08/22/2011 03:36 PM, Roedel, Joerg wrote: > > On the AMD IOMMU side this information is stored in the IVRS ACPI table. > > Not sure about the VT-d side, though. > > I see. There is

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 06:51:35AM -0400, Avi Kivity wrote: > On 08/22/2011 01:46 PM, Joerg Roedel wrote: > > That does not work. The bridge in question may not even be visible as a > > PCI device, so you can't link to it. This is the case on a few PCIe > > cards which only have a PCIx chip and a P

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: > On 08/22/2011 03:36 PM, Roedel, Joerg wrote: > > On the AMD IOMMU side this information is stored in the IVRS ACPI table. > > Not sure about the VT-d side, though. > > I see. There is no sysfs node representing it? No. It also doesn't

[Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-08-22 Thread Anthony Liguori
This patch changes qemu_set_fd_handler to be implemented in terms of g_io_add_watch(). The semantics are a bit different so some glue is required. qemu_set_fd_handler2 is much harder to convert because of its use of polling. The glib main loop has the major of advantage of having a proven thread

[Qemu-devel] [PATCH 1/2] Add glib support to main loop

2011-08-22 Thread Anthony Liguori
This allows GSources to be used to register callback events in QEMU. This is useful as it allows us to take greater advantage of glib and also because it allows us to write code that is more easily testable outside of QEMU since we can make use of glib's main loop in unit tests. All new code shou

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 04:15 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: > On 08/22/2011 03:55 PM, Roedel, Joerg wrote: > > Well, I don't think its really meaningless, but we need some way to > > communicate the information about device groups to userspace. >

[Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Anthony Liguori
Enabling the I/O thread by default seems like an important part of declaring 1.0. Besides allowing true SMP support with KVM, the I/O thread means that the TCG VCPU doesn't have to multiplex itself with the I/O dispatch routines which currently requires a (racey) signal based alarm system. I know

[Qemu-devel] Block layer roadmap on wiki

2011-08-22 Thread Stefan Hajnoczi
At KVM Forum Kevin, Christoph, and I had an opportunity to get together for a Block Layer BoF. We went through the recent "roadmap" mailing list thread and touched on each proposed feature. Here is the block layer roadmap wiki page: http://wiki.qemu.org/BlockRoadmap Kevin: I have moved the runti

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Jan Kiszka
On 2011-08-22 15:24, Anthony Liguori wrote: > Enabling the I/O thread by default seems like an important part of declaring > 1.0. Besides allowing true SMP support with KVM, the I/O thread means that > the > TCG VCPU doesn't have to multiplex itself with the I/O dispatch routines which > currentl

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-08-22 Thread Paolo Bonzini
On 08/22/2011 03:12 PM, Anthony Liguori wrote: I'm pretty sure that this will work on Win32, but I would appreciate some help testing. I think the semantics of g_io_channel_unix_new() are really just tied to the notion of a "unix fd" and not necessarily unix itself. Almost: in Win32 you need t

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Anthony Liguori
On 08/22/2011 08:35 AM, Jan Kiszka wrote: On 2011-08-22 15:24, Anthony Liguori wrote: Enabling the I/O thread by default seems like an important part of declaring 1.0. Besides allowing true SMP support with KVM, the I/O thread means that the TCG VCPU doesn't have to multiplex itself with the I/

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-08-22 Thread Anthony Liguori
On 08/22/2011 08:40 AM, Paolo Bonzini wrote: On 08/22/2011 03:12 PM, Anthony Liguori wrote: I'm pretty sure that this will work on Win32, but I would appreciate some help testing. I think the semantics of g_io_channel_unix_new() are really just tied to the notion of a "unix fd" and not necessari

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: > On 08/22/2011 03:55 PM, Roedel, Joerg wrote: > > Well, I don't think its really meaningless, but we need some way to > > communicate the information about device groups to userspace. > > I mean the contents of the group descriptor. Th

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-08-22 Thread Paolo Bonzini
On 08/22/2011 03:45 PM, Anthony Liguori wrote: Almost: in Win32 you need to use g_io_channel_win32_new_socket. But indeed on Windows you can only use qemu_set_fd_handler for sockets too. I think that's really only for read/write though. If you're just polling on I/O, it shouldn't matter IIUC.

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Peter Maydell
On 22 August 2011 14:24, Anthony Liguori wrote: > Enabling the I/O thread by default seems like an important part of declaring > 1.0.  Besides allowing true SMP support with KVM, the I/O thread means that > the > TCG VCPU doesn't have to multiplex itself with the I/O dispatch routines which > cur

[Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-22 Thread Avi Kivity
Another casualty of the memory API conversion. Signed-off-by: Avi Kivity --- hw/pcnet-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 13d9380..51e1320 100644 --- a/hw/pcnet-pci.c +++ b/hw/pcnet-pci.c @@ -290,10 +290,10 @@ st

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Paolo Bonzini
On 08/22/2011 03:50 PM, Peter Maydell wrote: > Enabling the I/O thread by default seems like an important part of declaring > 1.0. Besides allowing true SMP support with KVM, the I/O thread means that the > TCG VCPU doesn't have to multiplex itself with the I/O dispatch routines which > cu

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Jan Kiszka
On 2011-08-22 16:00, Paolo Bonzini wrote: > On 08/22/2011 03:50 PM, Peter Maydell wrote: >>> Enabling the I/O thread by default seems like an important part of >>> declaring >>> 1.0. Besides allowing true SMP support with KVM, the I/O thread means >>> that the >>> TCG VCPU doesn't have to mul

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Anthony Liguori
On 08/22/2011 08:50 AM, Peter Maydell wrote: On 22 August 2011 14:24, Anthony Liguori wrote: Enabling the I/O thread by default seems like an important part of declaring 1.0. Besides allowing true SMP support with KVM, the I/O thread means that the TCG VCPU doesn't have to multiplex itself wit

Re: [Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger device.

2011-08-22 Thread Paolo Bonzini
On 08/22/2011 01:59 PM, Stefan Hajnoczi wrote: > +DEFINE_PROP_INT32("fd", GoldfishMemlogDevice, fd, -1), I'm not sure these fields all need to be defined here. Why make fd a qdev property? I agree fd doesn't make much sense, but we may want to make it a chardev. Paolo

Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-22 Thread Paolo Bonzini
On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: Please use the block layer instead of reinventing portable file I/O. Also, please check which of the utility functions already exist in QEMU. If a utility function in this patch is needed it should be made generic for all of QEMU, not just goldfish

Re: [Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-22 Thread Gerhard Wiesinger
Hello Avi, Thnx, fixed: OK, maybe some credits :-) Acked-by: Gerhard Wiesinger This pattern is still present at (maybe some further problems!!!) and I guess it has to be fixed, too: grep -ir 'ops, s, "' . ./hw/rtl8139.c:memory_region_init_io(&s->bar_io, &rtl8139_io_ops, s, "rtl8139", 0

Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

2011-08-22 Thread Peter Maydell
On 22 August 2011 15:00, Paolo Bonzini wrote: > On 08/22/2011 03:50 PM, Peter Maydell wrote: >> Even with iothread it's still signal based (and still racy) -- the only >> way to get a thread currently executing TCG code to stop doing so is to >> send it a signal. > > It's signal-based, but I'm not

Re: [Qemu-devel] Block layer roadmap on wiki

2011-08-22 Thread Ryan Harper
* Stefan Hajnoczi [2011-08-22 08:35]: > At KVM Forum Kevin, Christoph, and I had an opportunity to get > together for a Block Layer BoF. We went through the recent "roadmap" > mailing list thread and touched on each proposed feature. > > Here is the block layer roadmap wiki page: > http://wiki.q

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 09:17:41AM -0400, Avi Kivity wrote: > On 08/22/2011 04:15 PM, Roedel, Joerg wrote: > > On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: > > > On 08/22/2011 03:55 PM, Roedel, Joerg wrote: > > > > > > Well, I don't think its really meaningless, but we need some w

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-22 Thread Anthony Liguori
On 08/11/2011 02:40 AM, Avi Kivity wrote: The memory API automatically cracks wide memory accesses into narrower (usually byte) accesses when needed. Unfortunately this wasn't implemented for ioports, leading to an lsi53c895a failure. This series implements cracking for ioports as well. Note t

Re: [Qemu-devel] [PATCH 1/2] guest agent: remove g_strcmp0 usage

2011-08-22 Thread Anthony Liguori
On 08/11/2011 03:38 PM, Michael Roth wrote: g_strcmp0 isn't in all version of glib 2.0, so don't use it to avoid build breakage on older distros. Signed-off-by: Michael Roth Applied. Thanks. Regards, Anthony Liguori --- qemu-ga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] Check for presence of compiler -pthread flag

2011-08-22 Thread Anthony Liguori
On 08/07/2011 07:02 PM, Brad wrote: Check for presence of compiler -pthread flag. OpenBSD / FreeBSD and some other OS's require the use of cc -pthread to link threaded programs so have QEMU's configure script check for the presence of the flag and use it if so. Signed-off-by: Brad Smith Appli

[Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-22 Thread Corey Bryant
sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in file system extended attributes. Some file systems, such as NFS, do not support the ext

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Ryan Harper
* Christoph Hellwig [2011-08-21 17:27]: > changes since V1: > - rebase to apply against the current qemu.git tree Testing on tip + this series with: ./configure --enable-debug --enable-kvm --enable-io-thread --target-list=x86_64-softmmu x86_64-softmmu/qemu-system-x86_64 --enable-kvm -L pc-bi

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Christoph Hellwig
On Mon, Aug 22, 2011 at 09:59:16AM -0500, Ryan Harper wrote: > * Christoph Hellwig [2011-08-21 17:27]: > > changes since V1: > > - rebase to apply against the current qemu.git tree > > > Testing on tip + this series with: > > ./configure --enable-debug --enable-kvm --enable-io-thread > --targ

Re: [Qemu-devel] [PATCH, braille] Add dots keypresses support to the baum braille device

2011-08-22 Thread Anthony Liguori
On 08/18/2011 09:16 PM, Samuel Thibault wrote: Oops, sorry, the previous patch had a debugging leftover, here it is again. Add dots keypresses support to the baum braille device. Signed-off-by: Samuel Thibault diff --git a/hw/baum.c b/hw/baum.c index 21326ae..0b29498 100644 --- a/hw/baum.c +++

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Ryan Harper
* Christoph Hellwig [2011-08-22 10:16]: > On Mon, Aug 22, 2011 at 09:59:16AM -0500, Ryan Harper wrote: > > * Christoph Hellwig [2011-08-21 17:27]: > > > changes since V1: > > > - rebase to apply against the current qemu.git tree > > > > > > Testing on tip + this series with: > > > > ./configu

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Christoph Hellwig
On Mon, Aug 22, 2011 at 10:29:11AM -0500, Ryan Harper wrote: > (gdb) frame 0 > #0 0x004200c1 in bdrv_acct_done (bs=0x12310b0, cookie=0x1c68810) at > /root/git/qemu/block_int.h:239 239 bs->nr_bytes[cookie->type] += > cookie->bytes; > (gdb) p *cookie > $3 = {bytes = 720575897597378

Re: [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-22 Thread Christoph Hellwig
I'm still totally against this. FD passing is a nice feature for sandboxing, but the passing should be between closely cooperating programs. We'll need a tool shipped from the qemu source tree to open and set up the FDs, and not someone external. With that setup in place we can use a protocol si

[Qemu-devel] [GIT PULL] Memory API fixes

2011-08-22 Thread Avi Kivity
Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git refs/tags/memory-region-fixes-1 to receive a memory API fix. The fix is not required for any of the already merged patches, but is needed by other patches in my queue. I am sending core patches separately than

Re: [Qemu-devel] [PATCH, braille] Add dots keypresses support to the baum braille device

2011-08-22 Thread Samuel Thibault
Anthony Liguori, le Mon 22 Aug 2011 10:27:08 -0500, a écrit : > I don't think this patch is against qemu.git. Please submit (and test) > against qemu.git. Oops, apparently I missed the git repository switch. Here it is, retested against qemu.git (last commit Mon Aug 22 so I guess that's the propr

Re: [Qemu-devel] [PATCH 2/3] block: explicit I/O accounting

2011-08-22 Thread Kevin Wolf
Am 22.08.2011 00:26, schrieb Christoph Hellwig: > Decouple the I/O accounting from bdrv_aio_readv/writev/flush and > make the hardware models call directly into the accounting helpers. > > This means: > - we do not count internal requests from image formats in addition >to guest originating I

[Qemu-devel] [PATCH v3 1/3] Do not drop global mutex for polled main loop runs

2011-08-22 Thread Jan Kiszka
If we call select without a timeout, it's more efficient to keep the global mutex locked as we may otherwise just play ping pong with a vcpu thread contending for it. This is particularly important for TCG mode where we run in lock-step with the vcpu thread. Signed-off-by: Jan Kiszka --- vl.c |

[Qemu-devel] [PATCH v3 0/3] io-thread optimizations

2011-08-22 Thread Jan Kiszka
Rebased as requested, also fixing a compiler warning about last_io being write-only on !CONFIG_IOTHREAD. That "__attribute__ ((unused))" in patch 2 can be removed again when CONFIG_IOTHREAD becomes mandatory. Jan Kiszka (3): Do not drop global mutex for polled main loop runs Poll main loop aft

[Qemu-devel] [PATCH v3 3/3] Do not kick vcpus in TCG mode

2011-08-22 Thread Jan Kiszka
In TCG mode, iothread and vcpus run in lock-step. So it's pointless to send a signal from qemu_cpu_kick to the vcpu thread - if we got here, the receiver already left the vcpu loop. Signed-off-by: Jan Kiszka --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu

[Qemu-devel] [PATCH v3 2/3] Poll main loop after I/O events were received

2011-08-22 Thread Jan Kiszka
Polling until select returns empty fdsets helps to reduce the switches between iothread and vcpus. The benefit of this patch is best visible when running an SMP guest on an SMP host in emulation mode. Signed-off-by: Jan Kiszka --- sysemu.h |2 +- vl.c | 12 2 files changed

[Qemu-devel] [RESEND][PATCH 1/2] target-i386: Remove unused polarity arguments from APIC API

2011-08-22 Thread Jan Kiszka
Polarity of external interrupts needs to be handled in the IOAPIC. Passing it to the APIC is pointless. So remove all these arguments. Signed-off-by: Jan Kiszka --- hw/apic.c| 22 +- hw/apic.h|6 ++ hw/ioapic.c |4 +--- trace-events |2 +- 4 files c

[Qemu-devel] [RESEND][PATCH 2/2] ioapic: Implement polarity

2011-08-22 Thread Jan Kiszka
If the polarity bit is set in the redirection table, the input level simply has to inverted as it is low active in this case. Signed-off-by: Jan Kiszka --- hw/ioapic.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 5916387..61991d7 1006

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Kevin Wolf
Am 22.08.2011 00:25, schrieb Christoph Hellwig: > changes since V1: > - rebase to apply against the current qemu.git tree Applied patch 1, commented on patch 2. The third one looks good, but doesn't apply without the other one. Kevin

Re: [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-22 Thread Corey Bryant
On 08/22/2011 11:38 AM, Christoph Hellwig wrote: I'm still totally against this. FD passing is a nice feature for sandboxing, but the passing should be between closely cooperating programs. We'll need a tool shipped from the qemu source tree to open and set up the FDs, and not someone external.

Re: [Qemu-devel] [RESEND][PATCH] Replace qemu_system_cond with VCPU stop mechanism

2011-08-22 Thread Avi Kivity
On 08/22/2011 06:46 PM, Jan Kiszka wrote: We can express the VCPU thread wakeup with the stop mechanism, saving both qemu_system_ready and the qemu_system_cond. For KVM threads, we can just enter the main loop as long as the thread is stopped. The central TCG thread is better held back before the

Re: [Qemu-devel] [GIT PULL] Memory API fixes

2011-08-22 Thread Anthony Liguori
On 08/22/2011 10:42 AM, Avi Kivity wrote: Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git refs/tags/memory-region-fixes-1 I don't fetch tags from subtrees at the moment. Could you make this a branch instead? Regards, Anthony Liguori to receive a memory API

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-22 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 05:38:20PM +0200, Christoph Hellwig wrote: > I'm still totally against this. FD passing is a nice feature for sandboxing, > but the passing should be between closely cooperating programs. We'll > need a tool shipped from the qemu source tree to open and set up the > FDs, a

Re: [Qemu-devel] [GIT PULL] Memory API fixes

2011-08-22 Thread Anthony Liguori
On 08/22/2011 10:42 AM, Avi Kivity wrote: Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git refs/tags/memory-region-fixes-1 Also, please use the tag '[PULL]' as that's what I (and presumably others) currently filter for. Regards, Anthony Liguori to receive a

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-22 Thread Anthony Liguori
On 08/22/2011 11:24 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 05:38:20PM +0200, Christoph Hellwig wrote: I'm still totally against this. FD passing is a nice feature for sandboxing, but the passing should be between closely cooperating programs. We'll need a tool shipped from the q

Re: [Qemu-devel] [PATCH] build: list libraries after objects, for proper linkage

2011-08-22 Thread Anthony Liguori
On 08/14/2011 08:31 AM, Diego Elio Pettenò wrote: Without this change, when using -Wl,--as-needed with GNU linker, the libraries would be discarded. Signed-off-by: Diego Elio Pettenò Applied. Thanks. Regards, Anthony Liguori --- libcacard/Makefile |4 ++-- 1 files changed, 2 insert

Re: [Qemu-devel] [PATCH 00/14] char: flow control part I

2011-08-22 Thread Anthony Liguori
On 08/15/2011 11:17 AM, Anthony Liguori wrote: This is a dump of some of the easier stuff to merge from my character backend flow control branch. It's mostly just renaming functions and adding documentation. Applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] e1000: use MII status register for link up/down

2011-08-22 Thread Anthony Liguori
On 08/17/2011 04:03 AM, Bjørn Mork wrote: Some guests will use the standard MII status register to verify link state. They will not notice link changes unless this register is updated. Verified with Linux 3.0 and Windows XP guests. Without this patch, ethtool will report speed and duplex as un

Re: [Qemu-devel] [PATCH] w32: Fix qemu_ftruncate64

2011-08-22 Thread Anthony Liguori
On 08/20/2011 05:10 AM, Stefan Weil wrote: SetFilePointer returns INVALID_SET_FILE_POINTER when it fails. In addition, GetLastError must be checked. The first call of SetFilePointer did not use INVALID_SET_FILE_POINTER, the second call used wrong error handling. Signed-off-by: Stefan Weil App

Re: [Qemu-devel] [PATCH] Improvements to libtool support.

2011-08-22 Thread Anthony Liguori
On 08/13/2011 07:30 PM, Brad wrote: Improvements to the libtool support in QEMU. Replace hard coded libtool in the infrastructure with $(LIBTOOL) and allow overriding the libtool binary used via the configure script. Signed-off-by: Brad Smith Applied. Thanks. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH v2 00/24] Memory API batch 4: more conversions

2011-08-22 Thread Anthony Liguori
On 08/15/2011 09:17 AM, Avi Kivity wrote: This patchset converts a few more devices (and boards) to the memory API. Nothing is really interesting except for the last patch, which brings proper PAM support (and better SMRAM emulation). It should also fix the regressions that were reported in some

Re: [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23)

2011-08-22 Thread Anthony Liguori
On 08/20/2011 09:29 AM, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau Applied. Thanks. Regards, Anthony Liguori --- hw/pcnet-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 13d9380..51e1320 100644 --- a/h

[Qemu-devel] [RESEND][PATCH] Replace qemu_system_cond with VCPU stop mechanism

2011-08-22 Thread Jan Kiszka
We can express the VCPU thread wakeup with the stop mechanism, saving both qemu_system_ready and the qemu_system_cond. For KVM threads, we can just enter the main loop as long as the thread is stopped. The central TCG thread is better held back before the loop as there can be side effects of the se

[Qemu-devel] [PATCH v3] Replace qemu_system_cond with VCPU stop mechanism

2011-08-22 Thread Jan Kiszka
On 2011-08-22 18:18, Avi Kivity wrote: > On 08/22/2011 06:46 PM, Jan Kiszka wrote: >> We can express the VCPU thread wakeup with the stop mechanism, saving >> both qemu_system_ready and the qemu_system_cond. For KVM threads, we can >> just enter the main loop as long as the thread is stopped. The c

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-22 Thread Alex Williamson
On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: > On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: > > We had an extremely productive VFIO BoF on Monday. Here's my attempt to > > capture the plan that I think we agreed to: > > > > We need to address both the description and

[Qemu-devel] [PATCH] sdl: Don't release input on mouse mode change in full-screen mode

2011-08-22 Thread Jan Kiszka
While in full-screen mode, the input focus naturally belongs to the SDL window. Avoid dropping it when switching from absolute to relative mouse mode. Signed-off-by: Jan Kiszka --- ui/sdl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 385c

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Ryan Harper
* Christoph Hellwig [2011-08-22 10:37]: > On Mon, Aug 22, 2011 at 10:29:11AM -0500, Ryan Harper wrote: > > (gdb) frame 0 > > #0 0x004200c1 in bdrv_acct_done (bs=0x12310b0, cookie=0x1c68810) > > at /root/git/qemu/block_int.h:239 239 bs->nr_bytes[cookie->type] += > > cookie->bytes

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-22 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori wrote: > On 08/22/2011 11:24 AM, Daniel P. Berrange wrote: > >On Mon, Aug 22, 2011 at 05:38:20PM +0200, Christoph Hellwig wrote: > >>I'm still totally against this. FD passing is a nice feature for > >>sandboxing, > >>but the passing shoul

[Qemu-devel] [PULL] Memory API fix

2011-08-22 Thread Avi Kivity
Anthony, please pull from: ssh://master.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core to receive a memory API fix. The fix is not required for any of the already merged patches, but is needed by other patches in my queue. I am sending core patches separately than the conversions to

[Qemu-devel] [PULL][v2] Memory API fix

2011-08-22 Thread Avi Kivity
[v2: fix git url...] Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core to receive a memory API fix. The fix is not required for any of the already merged patches, but is needed by other patches in my queue. I am sending core patches separately than

Re: [Qemu-devel] [PATCH] fix code format

2011-08-22 Thread Anthony Liguori
On 08/19/2011 04:17 AM, Robert Wang wrote: Fix code format to make checkpatch.pl happy. Signed-off-by: Robert Wang Applied. Thanks. Regards, Anthony Liguori --- block.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 26910ca..87e83b

[Qemu-devel] [PATCH] linux-user: Correct a few missuses of host addresses

2011-08-22 Thread Edgar E. Iglesias
Hi, I ran into a couple of missuses of where signal setup was directly passing host pointers to the guest. I've run tested the CRIS and MicroBlaze changes. The S390 and SH4 are only compile tested. Cheers commit f47829920bc06abddfd7d55cec97ec798f4668e2 Author: Edgar E. Iglesias Date: Mon Aug

  1   2   >