[Qemu-devel] [PULL] usb patch queue

2011-08-11 Thread Gerd Hoffmann
Hi, More usb and hid bits. Fixes a usb tablet regression with windows xp. milkymist goes use the new, splitted hid code directly instead of (ab-)using the usb-kbd device, which in turn allows to kill the usb_hid_datain_cb callback as no users are left. please pull, Gerd The following change

[Qemu-devel] [PATCH 4/6] usb-hid: use hid vmstate macro

2011-08-11 Thread Gerd Hoffmann
From: Michael Walle Use new hid vmstate macro. Version stays the same, because there is no reordering of the fields. Signed-off-by: Michael Walle Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c | 41 ++--- 1 files changed, 2 insertions(+), 39 deletions(-)

[Qemu-devel] [PATCH 3/6] hid: introduce hid vmstate macros

2011-08-11 Thread Gerd Hoffmann
From: Michael Walle Add VMSTATE macros to describe a HIDState. Based on usb-hid.c descriptions. Signed-off-by: Michael Walle Signed-off-by: Gerd Hoffmann --- hw/hid.c | 58 ++ hw/hw.h | 20 2 files changed, 78 i

[Qemu-devel] [PULL] spice patch queue

2011-08-11 Thread Gerd Hoffmann
Hi, Here comes the spice patch queue with two little fixes queued up and and extension of the "info spice" monitor command which reports the spice version too now. please pull, Gerd The following changes since commit b9c6cbff76061537b722d55f0e321dde2a612a23: Merge remote-tracking branch '

[Qemu-devel] [PATCH 2/3] qxl: unbreak after memory API conversion

2011-08-11 Thread Gerd Hoffmann
From: Alon Levy Break is only noticable with newer spice-server library (0.8.2 release or 0.9.0 and newer on master branch). ioport_write's val was changed from uint32_t to uint64_t, this broke two printfs. Use PRId64 instead of %d. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- h

[Qemu-devel] [PATCH 3/3] ui/spice-core: report compiled-version in info spice/query-spice

2011-08-11 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- ui/spice-core.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 3d77c01..8bb62ea 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -372,6 +372,8

[Qemu-devel] [PATCH 1/3] qxl: allowing the command rings to be not empty when spice worker is stopped RHBZ #728984

2011-08-11 Thread Gerd Hoffmann
From: Yonit Halperin same as 8927cfbba232e28304734f7afd463c1b84134031, but for qxl_check_state, that was triggered by qxl_pre_load (which calls qxl_hard_reset, which calls qxl_soft_reset), and caused the migration target to crash. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |8 +++- 1

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-11 Thread Harsh Bora
On 08/10/2011 08:47 PM, Stefan Hajnoczi wrote: On Fri, Aug 5, 2011 at 1:53 PM, Stefan Hajnoczi wrote: On Fri, Aug 5, 2011 at 12:32 PM, Aneesh Kumar K.V wrote: On Fri, 5 Aug 2011 10:24:42 +0100, Stefan Hajnoczi wrote: On Fri, Aug 5, 2011 at 7:40 AM, Aneesh Kumar K.V wrote: On Thu, 4 Aug

[Qemu-devel] [PATCH 1/6] usb/hid: add hid_pointer_activate, use it

2011-08-11 Thread Gerd Hoffmann
HID reorganziation broke the usb tablet in windows xp. The reason is that xp activates idle before it starts polling, which creates a chicken-and-egg issue: We don't call hid_pointer_poll because there are no pending events. We don't get any events because the activation code in hid_pointer_poll

[Qemu-devel] [PATCH 5/6] milkymist-softusb: use hid code directly

2011-08-11 Thread Gerd Hoffmann
From: Michael Walle Remove the dummy USB device and use the HID code directly. Use the HID code for the mouse support, too. Signed-off-by: Michael Walle Signed-off-by: Gerd Hoffmann --- hw/milkymist-softusb.c | 122 +++- 1 files changed, 38 inserti

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-11 Thread Kevin Wolf
Am 10.08.2011 19:20, schrieb Blue Swirl: > On Wed, Aug 10, 2011 at 7:58 AM, Kevin Wolf wrote: >> Am 09.08.2011 21:39, schrieb Blue Swirl: >>> On Tue, Aug 9, 2011 at 12:24 PM, Kevin Wolf wrote: Am 09.08.2011 14:00, schrieb Stefan Hajnoczi: > I liked the idea of doing a generic FDStash typ

[Qemu-devel] [PATCH 2/2] memory: crack wide ioport accesses into smaller ones when needed

2011-08-11 Thread Avi Kivity
The memory API supports cracking wide accesses into narrower ones when needed; but this was no implemented for the pio address space, causing lsi53c895a's IO BAR to malfunction. Fix by correctly cracking wide accesses when needed. Signed-off-by: Avi Kivity --- memory.c | 11 +-- 1 fil

[Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
The memory API automatically cracks wide memory accesses into narrower (usually byte) accesses when needed. Unfortunately this wasn't implemented for ioports, leading to an lsi53c895a failure. This series implements cracking for ioports as well. Note that the dual implementation is due to the fa

[Qemu-devel] [PATCH 1/2] memory: abstract cracking of write access ops into a function

2011-08-11 Thread Avi Kivity
The memory API automatically cracks large reads and writes into smaller ones when needed. Factor out this mechanism, which is now duplicated between memory reads and memory writes, into a function. Signed-off-by: Avi Kivity --- memory.c | 109 ++-

[Qemu-devel] [Bug 721793] Re: QEMU freezes on startup (100% CPU utilization)

2011-08-11 Thread Vlad Glagolev
QEMU 0.15.0 fixes the problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/721793 Title: QEMU freezes on startup (100% CPU utilization) Status in QEMU: New Bug description: 0.12.5 was the l

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Avi Kivity
On 08/11/2011 01:28 AM, Richard Henderson wrote: [ Sorry about the partial duplicates, Avi. ] This patchset is relative to git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory-region although I'm sure it could be applied on top of Avi's batch 4. This is not complete by any means. I'm

[Qemu-devel] [PATCH 2/6] hid: register kbd hander in init()

2011-08-11 Thread Gerd Hoffmann
From: Michael Walle Register the keyboard event handler in hid's init() instead of its reset() function. Signed-off-by: Michael Walle Signed-off-by: Gerd Hoffmann --- hw/hid.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/hid.c b/hw/hid.c index 77339f7..3dc42

Re: [Qemu-devel] [PATCH] pcie/slot: fix hotplug event

2011-08-11 Thread Michael S. Tsirkin
On Fri, Aug 05, 2011 at 06:22:03PM +0900, Isaku Yamahata wrote: > When slot status register is cleared, PCIDevice::exp.hpev_notify > needs to be cleared. > Otherwise, PCIDevice::exp.hpev_notify is never set to false resulting > in no more hot plug event once it's raised. > > Signed-off-by: Isaku Y

Re: [Qemu-devel] [PATCH] pcie/aer: fix inject aer error command

2011-08-11 Thread Michael S. Tsirkin
On Fri, Aug 05, 2011 at 06:22:06PM +0900, Isaku Yamahata wrote: > various fixes to make aer inject error command work. > - wrong assert > - command line parser > - err.status needs initialization > > Signed-off-by: Isaku Yamahata Thanks, applied. > --- > hw/pcie_aer.c |9 + > 1 fil

Re: [Qemu-devel] [PATCH 00/10] SCSI scatter/gather support

2011-08-11 Thread Stefan Hajnoczi
On Thu, Aug 04, 2011 at 07:14:38PM +0200, Paolo Bonzini wrote: > Hi, > > this is the version of SCSI scatter/gather based on the existing > DMA helpers infrastructure. > > The infrastructure required a little update because I need to > know the residual amount of data upon short transfers. To th

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Stefan Hajnoczi
On Thu, Aug 04, 2011 at 07:14:43PM +0200, Paolo Bonzini wrote: > These helpers do a full transfer from an in-memory buffer to > target memory, with full support for MMIO areas. It will be used to store > the reply of an emulated command into a QEMUSGList provided by the > adapter. > > Signed-off-

[Qemu-devel] [PATCH 6/6] usb-hid: remove usb_hid_datain_cb

2011-08-11 Thread Gerd Hoffmann
No users left, all migrated over to hw/hid.[ch]. Yea! Zap it! Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c | 14 -- hw/usb.h |3 --- 2 files changed, 0 insertions(+), 17 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 6a75147..ba79466 100644 --- a/hw/usb-hid.

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Shribman, Aidan
> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Wednesday, August 10, 2011 10:28 PM > To: Avi Kivity > Cc: Blue Swirl; Stefan Hajnoczi; Shribman, Aidan; qemu-devel > Developers; libvir-l...@redhat.com > Subject: Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of > large m

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Edgar E. Iglesias
On Thu, Aug 11, 2011 at 10:48:23AM +0300, Avi Kivity wrote: > On 08/11/2011 01:28 AM, Richard Henderson wrote: > >[ Sorry about the partial duplicates, Avi. ] > > > >This patchset is relative to > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory-region > > > >although I'm sure it coul

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Avi Kivity
On 08/10/2011 10:27 PM, Anthony Liguori wrote: This may be acceptable, wait until the entire migration cluster is xzbrle capable before enabling it. If not, add a monitor command. 1) xzbrle needs to be disabled by default. That way management tools don't unknowingly enable it by not passing

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Avi Kivity
On 08/11/2011 11:05 AM, Edgar E. Iglesias wrote: > > If we're going to work on this in parallel, we'd better coordinate. > Right now I'm going though all files the contain qemu_ram_alloc > alphabetically and converting them (now in 'O'). If anyone wants a > letter, let me know. Hi Avi, I w

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region_del_subregion: Assertion `subregion->parent == mr' failed. Thnx. Ciao, Gerhard -- http:/

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 11:25 AM, Gerhard Wiesinger wrote: Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region_del_subregion: Assertion `subregion->paren

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 11:27 AM, Avi Kivity wrote: On 08/11/2011 11:25 AM, Gerhard Wiesinger wrote: Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00435339 in memory_region_del_subregion (mr=, subregion=)at /root/download/qemu/git/qem

Re: [Qemu-devel] [libvirt] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2011 at 11:17:09AM +0300, Avi Kivity wrote: > On 08/10/2011 10:27 PM, Anthony Liguori wrote: > >>This may be acceptable, wait until the entire migration cluster is > >>xzbrle capable before enabling it. If not, add a monitor command. > > > > > >1) xzbrle needs to be disabled by defa

Re: [Qemu-devel] [libvirt] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Avi Kivity
On 08/11/2011 12:16 PM, Daniel P. Berrange wrote: On Thu, Aug 11, 2011 at 11:17:09AM +0300, Avi Kivity wrote: > On 08/10/2011 10:27 PM, Anthony Liguori wrote: > >>This may be acceptable, wait until the entire migration cluster is > >>xzbrle capable before enabling it. If not, add a monitor com

Re: [Qemu-devel] [libvirt] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2011 at 02:27:41PM -0500, Anthony Liguori wrote: > On 08/10/2011 11:40 AM, Avi Kivity wrote: > Instead of teaching management tools how to deal with all of these > things, let's just fix this problem once. It just takes: > > a) A query-migration-caps command that returns a dict wi

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 12:01 PM, Gerhard Wiesinger wrote: Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00435339 in memory_region_del_subregion (mr

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Edgar E. Iglesias
On Thu, Aug 11, 2011 at 11:20:04AM +0300, Avi Kivity wrote: > On 08/11/2011 11:05 AM, Edgar E. Iglesias wrote: > >> > >> If we're going to work on this in parallel, we'd better coordinate. > >> Right now I'm going though all files the contain qemu_ram_alloc > >> alphabetically and converting the

[Qemu-devel] [PATCH 0/5] etrax: Convert devices to MemoryRegion

2011-08-11 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Mechanical conversion of ETRAX devices to use MemoryRegions. I've tested it lightly with the axis-dev88 board, seems to work fine. Note that eth and dma models predate CodingStyle and use tabs, I plan to change that with separate commits at some point. Edgar E. Iglesi

[Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
While compiling current HEAD on a ppc64 box, I was confronted with the following compile errors: tcg/optimize.c: In function ‘tcg_constant_folding’: tcg/optimize.c:546: error: ‘INDEX_op_not_i32’ undeclared (first use in this function) tcg/optimize.c:546: error: (Each undeclared identifier i

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Avi Kivity
On 08/11/2011 01:24 PM, Edgar E. Iglesias wrote: > > I converted etraxfs.c, which was then removed... I've been planing to remove that board for a while, apparantly I did it to late. Sorry. No problem, especially as I didn't coordinate this with anyone. > > I haven't touched xilinx. You c

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread malc
On Thu, 11 Aug 2011, Alexander Graf wrote: > While compiling current HEAD on a ppc64 box, I was confronted with the > following compile errors: > > tcg/optimize.c: In function ?tcg_constant_folding?: > tcg/optimize.c:546: error: ?INDEX_op_not_i32? undeclared (first use in this > function) >

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 2 July 2011 08:50, Jan Kiszka wrote: > From: Jan Kiszka > > Recent compilers look deep into cpu_exec, find longjmp as a noreturn > function and decide to smash some stack variables as they won't be used > again. This may lead to env becoming invalid after return from setjmp, > causing crashes.

Re: [Qemu-devel] [PATCH 0/5] etrax: Convert devices to MemoryRegion

2011-08-11 Thread Avi Kivity
On 08/11/2011 01:25 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Mechanical conversion of ETRAX devices to use MemoryRegions. I've tested it lightly with the axis-dev88 board, seems to work fine. Note that eth and dma models predate CodingStyle and use tabs, I plan to change that wit

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
On 11.08.2011, at 13:24, malc wrote: > On Thu, 11 Aug 2011, Alexander Graf wrote: > >> While compiling current HEAD on a ppc64 box, I was confronted with the >> following compile errors: >> >> tcg/optimize.c: In function ?tcg_constant_folding?: >> tcg/optimize.c:546: error: ?INDEX_op_not_i32?

[Qemu-devel] [PATCH 1/5] etrax-pic: Convert to MemoryRegion

2011-08-11 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/etraxfs_pic.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/hw/etraxfs_pic.c b/hw/etraxfs_pic.c index 4feffda..47a56d7 100644 --- a/hw/etraxfs_pic.c +++ b/hw/etraxfs_pic.c

[Qemu-devel] [PATCH 3/5] etrax-timer: Convert to MemoryRegion

2011-08-11 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/etraxfs_timer.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) diff --git a/hw/etraxfs_timer.c b/hw/etraxfs_timer.c index b08e574..57dc739 100644 --- a/hw/etraxfs_timer.c +++ b/hw/etra

[Qemu-devel] [PATCH 4/5] etrax-dma: Convert to MemoryRegion

2011-08-11 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/etraxfs_dma.c | 43 +++ 1 files changed, 27 insertions(+), 16 deletions(-) diff --git a/hw/etraxfs_dma.c b/hw/etraxfs_dma.c index c205ec1..8023fa1 100644 --- a/hw/etraxfs_dma.c +++ b/hw/

[Qemu-devel] [PATCH 2/5] etrax-ser: Convert to MemoryRegion

2011-08-11 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/etraxfs_ser.c | 33 ++--- 1 files changed, 18 insertions(+), 15 deletions(-) diff --git a/hw/etraxfs_ser.c b/hw/etraxfs_ser.c index 28b86ea..f862231 100644 --- a/hw/etraxfs_ser.c +++ b/hw/etraxfs_se

[Qemu-devel] [PATCH 5/5] etrax-eth: Convert to MemoryRegion

2011-08-11 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/etraxfs_eth.c | 30 -- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index 92d4eca..38b33bf 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c

Re: [Qemu-devel] [PATCH 1/5] etrax-pic: Convert to MemoryRegion

2011-08-11 Thread Avi Kivity
On 08/11/2011 02:47 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Thanks, queued all 5 in the memory-region branch. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 09:58 AM, Stefan Hajnoczi wrote: On Thu, Aug 04, 2011 at 07:14:43PM +0200, Paolo Bonzini wrote: These helpers do a full transfer from an in-memory buffer to target memory, with full support for MMIO areas. It will be used to store the reply of an emulated command into a QEMUSGList

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 01:30 PM, Peter Maydell wrote: > Recent compilers look deep into cpu_exec, find longjmp as a noreturn > function and decide to smash some stack variables as they won't be used > again. This may lead to env becoming invalid after return from setjmp, > causing crashes. Fix it by r

[Qemu-devel] [PATCH 2/5] spice-qemu-char: Generate chardev open/close events

2011-08-11 Thread Hans de Goede
Define a state callback and make that generate chardev open/close events when called by the spice-server. Note that for all but the newest spice-server versions (which have a fix for this) the code ignores these events for a spicevmc with a subtype of vdagent, this subtype specific knowledge is un

[Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public

2011-08-11 Thread Hans de Goede
Make qemu_chr_event public so that it can be used by chardev code which lives outside of qemu-char.c Signed-off-by: Hans de Goede --- qemu-char.c |2 +- qemu-char.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 8d39500..5d5a6d5 10064

[Qemu-devel] [PATCH 5/5] usb-redir: Don't try to write to the chardev after a close event

2011-08-11 Thread Hans de Goede
Sicne we handle close async in a bh, do_write and thus write can get called after receiving a close event. This patch adds a check to the usb-redir write callback to not do a qemu_chr_write on a closed chardev. Signed-off-by: Hans de Goede --- usb-redir.c |2 +- 1 files changed, 1 insertions

[Qemu-devel] [PATCH 4/5] usb-redir: Device disconnect + re-connect robustness fixes

2011-08-11 Thread Hans de Goede
These fixes mainly target the other side sending some (error status) packets after a disconnect packet. In some cases these would get queued up and then reported to the controller when a new device gets connected. * Fully reset device state on disconnect * Don't allow a connect message when alread

[Qemu-devel] [PATCH 3/5] usb-redir: Call qemu_chr_guest_open/close

2011-08-11 Thread Hans de Goede
To let the chardev now we're ready start receiving data. This is necessary with the spicevmc chardev to get it registered with the spice-server. Signed-off-by: Hans de Goede --- usb-redir.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/usb-redir.c b/usb-redir.c index

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Avi Kivity
On 08/11/2011 02:40 PM, Alexander Graf wrote: On 11.08.2011, at 13:24, malc wrote: > On Thu, 11 Aug 2011, Alexander Graf wrote: > >> While compiling current HEAD on a ppc64 box, I was confronted with the >> following compile errors: >> >> tcg/optimize.c: In function ?tcg_constant_folding?:

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
On 11.08.2011, at 14:28, Avi Kivity wrote: > On 08/11/2011 02:40 PM, Alexander Graf wrote: >> On 11.08.2011, at 13:24, malc wrote: >> >> > On Thu, 11 Aug 2011, Alexander Graf wrote: >> > >> >> While compiling current HEAD on a ppc64 box, I was confronted with the >> >> following compile error

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 11 August 2011 13:16, Paolo Bonzini wrote: > On 08/11/2011 01:30 PM, Peter Maydell wrote: >> Can you give more details of what compiler/platform this was >> a problem for? My reading of the C standard is that the compiler >> isn't allowed to trash env across this longjmp, because it's >> a vari

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Avi Kivity
On 08/11/2011 03:36 PM, Alexander Graf wrote: > > Or to have automatic generation of the optionals based on the primitives, if the optionals are not present. That's what's happening in the background already, no? The line is towards tcg users though, not it tcg internal code. Yes, and it d

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Anthony Liguori
On 08/11/2011 03:03 AM, Shribman, Aidan wrote: From: Anthony Liguori [mailto:anth...@codemonkey.ws] Sent: Wednesday, August 10, 2011 10:28 PM To: Avi Kivity Cc: Blue Swirl; Stefan Hajnoczi; Shribman, Aidan; qemu-devel Developers; libvir-l...@redhat.com Subject: Re: [Qemu-devel] [PATCH v4] XBZRLE

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2011-08-11 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/521994 Title: Windows 98 doesn't detect mouse on qemu and SeaBIOS. Statu

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Anthony Liguori
On 08/11/2011 03:17 AM, Avi Kivity wrote: 3) a management tool should be able to query the source and destination, and then enable xzbrle if both sides support it. You can argue that (3) could be static. A command could be added to toggle it dynamically through the monitor. But no matter what,

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 02:40 PM, Peter Maydell wrote: "All accessible objects have values [...] as of the time the longjmp function was called, except that the values of objects of automatic storage duration that are local to the function containing the invocation of the corresponding setjmp macro that do

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Stefan Hajnoczi
On Thu, Aug 11, 2011 at 1:10 PM, Paolo Bonzini wrote: > On 08/11/2011 09:58 AM, Stefan Hajnoczi wrote: >> >> On Thu, Aug 04, 2011 at 07:14:43PM +0200, Paolo Bonzini wrote: >>> >>> These helpers do a full transfer from an in-memory buffer to >>> target memory, with full support for MMIO areas.  It

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 11 August 2011 14:13, Paolo Bonzini wrote: > On 08/11/2011 02:40 PM, Peter Maydell wrote: >> We don't change env between the setjmp and longjmp so the compiler >> should not trash it. (Indeed according to Jan in >> http://lists.gnu.org/archive/html/qemu-devel/2011-07/msg00144.html >> -Wclobbere

[Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Anthony Liguori
Hi, I've posted an initial proposal for the 1.0 release on the wiki[1]. The release would be targeted for December 1st. Unlike previous releases, I'm proposing that instead of forking master into a stable branch and releasing from there, we stop taking features into master and all work on st

Re: [Qemu-devel] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-11 Thread Kevin Wolf
[ CCed qemu-devel, just in case someone's interested ] Am 11.08.2011 15:23, schrieb Eric Blake: >> [ Okay, some of it is handled later in this document, but I think it's >> still useful to leave this summary in my mail. External VM state is >> something that you don't seem to have covered yet - ca

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 03:31 PM, Peter Maydell wrote: Then it's a compiler bug, not smartness. Making env volatile (or making a volatile copy if there is a performance impact) should still be enough to work around it. Yes. (It would have to be a volatile copy, I think, env is a function parameter and I

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread David Gilbert
On 11 August 2011 15:10, Paolo Bonzini wrote: > I'm not sure about what to read from there: > >> If I make cpu_single_env thread local with __thread and leave >> 0d101... in, then again it works reliably on 32bit Lucid, and is >> flaky on 64 bit Oneiric (5/10 2 hangs, 3 segs) >> >> I've also trie

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 03:29 PM, Stefan Hajnoczi wrote: > > What do you think about passing the residual bytes for short transfers? >Should I look into updating BlockDriverCompletionFunc, or is the approach > of patch 2 okay? If I have an excuse to learn more about Coccinelle, that > can be fun.:)

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 11 August 2011 15:10, Paolo Bonzini wrote: > On 08/11/2011 03:31 PM, Peter Maydell wrote: Then it's a compiler bug, not smartness.  Making env volatile (or making a volatile copy if there is a performance impact) should still be enough to work around it. >> >> Yes. (It would

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 04:24 PM, Peter Maydell wrote: I cannot think off-hand of a reason why thread-local cpu_single_env should not work for iothread under Unix, BTW. Since cpu_single_env is only set/used by a thread at a time (under the global lock), its users cannot distinguish between a thread-local

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Kevin Wolf
Am 11.08.2011 16:24, schrieb Paolo Bonzini: > On 08/11/2011 03:29 PM, Stefan Hajnoczi wrote: What do you think about passing the residual bytes for short transfers? Should I look into updating BlockDriverCompletionFunc, or is the approach of patch 2 okay? If I have a

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Richard Henderson
On 08/11/2011 12:48 AM, Avi Kivity wrote: > If we're going to work on this in parallel, we'd better coordinate. > Right now I'm going though all files the contain qemu_ram_alloc > alphabetically and converting them (now in 'O'). If anyone wants a > letter, let me know. I've been looking at files

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 04:37 PM, Kevin Wolf wrote: > Right, I would rather update BlockDriverCompletionFunc to pass the AIOCB > as a third parameter, and store the residual bytes in the DMAAIOCB (with > a getter that the completion function can use). Isn't the DMAAIOCB already passed as opaque to the

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Kevin Wolf
Am 11.08.2011 17:05, schrieb Paolo Bonzini: > On 08/11/2011 04:37 PM, Kevin Wolf wrote: >>> Right, I would rather update BlockDriverCompletionFunc to pass the AIOCB >>> as a third parameter, and store the residual bytes in the DMAAIOCB (with >>> a getter that the completion function can use). >>

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Avi Kivity
On 08/11/2011 05:58 PM, Richard Henderson wrote: On 08/11/2011 12:48 AM, Avi Kivity wrote: > If we're going to work on this in parallel, we'd better coordinate. > Right now I'm going though all files the contain qemu_ram_alloc > alphabetically and converting them (now in 'O'). If anyone wants

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 05:12 PM, Kevin Wolf wrote: > Another possibility is always completing DMA in a bottom half. This > ensures that the callback can access the AIOCB, but it exposes an > implementation detail to the caller, so I don't like it. At least in the block layer, AIO callbacks may never

Re: [Qemu-devel] [PATCHSET 2] VirtFS coroutine changes

2011-08-11 Thread Aneesh Kumar K.V
On Mon, 8 Aug 2011 22:36:27 +0530, "Aneesh Kumar K.V" wrote: > Full patchset is available at > > git://repo.or.cz/qemu/v9fs.git for-upstream-1 > > -aneesh > > Any update on this. I updated the for-upstream-1 branch with changes to fold few patches. But there are no code changes. -aneesh

[Qemu-devel] sparc32_dma: correctly initialize ledma base address

2011-08-11 Thread Bob Breuer
The ledma base address defaults to 0xff00 on reset. This fixes a bug with Solaris and SS-20 OBP when boot net is skipped. Signed-off-by: Bob Breuer --- diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c index e75694b..61812fb 100644 --- a/hw/sparc32_dma.c +++ b/hw/sparc32_dma.c @@ -252,6 +252

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: On 08/11/2011 12:01 PM, Gerhard Wiesinger wrote: Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: This should be faster today with really new kernels (the problem is not in qemu) but I'm not sure if it's fast enough. What's a "really new" kernel? In which version were performance optimizations done? (Currently I'm using 2.6.34.7, hadn't time yet to u

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:11 PM, Gerhard Wiesinger wrote: On Thu, 11 Aug 2011, Avi Kivity wrote: This should be faster today with really new kernels (the problem is not in qemu) but I'm not sure if it's fast enough. What's a "really new" kernel? In which version were performance optimizations done? (C

[Qemu-devel] [PULL] [PATCHSET 1] VirtFS coroutine changes

2011-08-11 Thread Aneesh Kumar K.V
On Mon, 8 Aug 2011 22:33:48 +0530, "Aneesh Kumar K.V" wrote: > Full patchset is available at > > git://repo.or.cz/qemu/v9fs.git for-upstream-1 > > -aneesh Here is the updated pull request. I folded few patches based on the review. But there are no code changes. The following changes since c

Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Peter Maydell
On 8 August 2011 18:07, Avi Kivity wrote: > -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr) > +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr, > +                                    unsigned size) >  { >     uint32_t val; > -    val = pci_da

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:08 PM, Gerhard Wiesinger wrote: (gdb) frame 4 #4 0x0041eb9b in pci_update_mappings (d=0x1a90bc0) at /root/download/qemu/git/qemu-kvm-test/hw/pci.c:1134 1134memory_region_del_subregion(r->address_space, r->memory); (gdb) print i $1 = (gdb) print *r

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 7:37 AM, Kevin Wolf wrote: > Am 10.08.2011 19:20, schrieb Blue Swirl: >> On Wed, Aug 10, 2011 at 7:58 AM, Kevin Wolf wrote: >>> Am 09.08.2011 21:39, schrieb Blue Swirl: On Tue, Aug 9, 2011 at 12:24 PM, Kevin Wolf wrote: > Am 09.08.2011 14:00, schrieb Stefan Hajno

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:20 PM, Avi Kivity wrote: On 08/11/2011 07:08 PM, Gerhard Wiesinger wrote: (gdb) frame 4 #4 0x0041eb9b in pci_update_mappings (d=0x1a90bc0) at /root/download/qemu/git/qemu-kvm-test/hw/pci.c:1134 1134memory_region_del_subregion(r->address_space, r->m

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-08-11 Thread Corey Bryant
On 07/26/2011 08:51 AM, Corey Bryant wrote: > +static int raw_open_fd(BlockDriverState *bs, const char *filename, int flags) > +{ > +BDRVRawState *s = bs->opaque; > +const char *fd_str; > +int fd; > + > +/* extract the file descriptor - fail if it's not fd: */ > +if (!strs

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: > On 08/11/2011 03:36 PM, Alexander Graf wrote: >> >> > >> >  Or to have automatic generation of the optionals based on the >> > primitives, if the optionals are not present. >> >> That's what's happening in the background already, no? The line i

[Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-08-11 Thread Nigel Horne
Public bug reported: The latest git version of qemu (commit 8cc7c3952d4d0a681d8d4c3ac89a206a5bfd7f00) crashes after a few minutes. All was fine up to a few days ago. This is wth both x86 and sparc emulation, on an x86_64 host. e.g. qemu-system-sparc -drive file=netbsd5.0.2-sparc,index=0,media=di

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-11 Thread Andrea Arcangeli
Hello everyone, so basically this is a tradeoff between not having a long latency for the migration to succeed and reducing the total network traffic (and CPU load) in the migration source and destination and reducing the memory footprint a bit, by adding an initial latency to the memory accesses

Re: [Qemu-devel] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-11 Thread Eric Blake
On 08/11/2011 08:11 AM, Kevin Wolf wrote: I agree with you. It feels a bit backwards for snapshots, but it's really the only reasonable thing to do if you're using external snapshots. That you can't rename block devices is actually a very point point, too. There's one more point to consider: If

Re: [Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 1:46 PM, Anthony Liguori wrote: > Hi, > > I've posted an initial proposal for the 1.0 release on the wiki[1]. > > The release would be targeted for December 1st.  Unlike previous releases, > I'm proposing that instead of forking master into a stable branch and > releasing f

Re: [Qemu-devel] [PATCH 1/2] pflash: Support read-only mode

2011-08-11 Thread Jordan Justen
On Thu, Jul 28, 2011 at 14:05, Jordan Justen wrote: > On Thu, Jul 28, 2011 at 11:26, Jan Kiszka wrote: >> On 2011-07-27 17:38, Jordan Justen wrote: >>> On Wed, Jul 27, 2011 at 02:30, Jan Kiszka wrote: On 2011-07-25 23:34, Jordan Justen wrote: > Read-only mode is indicated by bdrv_is_rea

Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:20 PM, Peter Maydell wrote: On 8 August 2011 18:07, Avi Kivity wrote: > -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr) > +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr, > +unsigned

[Qemu-devel] [PATCH v1.1 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Avi Kivity
Signed-off-by: Avi Kivity --- v1.1: fix bogus 'return size', thanks to Peter Maydell hw/versatile_pci.c | 92 --- 1 files changed, 43 insertions(+), 49 deletions(-) diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index e1d5c0b..98e56f1 100

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Richard Henderson
On 08/11/2011 09:38 AM, Blue Swirl wrote: > On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: >> On 08/11/2011 03:36 PM, Alexander Graf wrote: >>> Or to have automatic generation of the optionals based on the primitives, if the optionals are not present. >>> >>> That's what's hap

Re: [Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Anthony Liguori
On 08/11/2011 12:30 PM, Blue Swirl wrote: On Thu, Aug 11, 2011 at 1:46 PM, Anthony Liguori wrote: Hi, I've posted an initial proposal for the 1.0 release on the wiki[1]. The release would be targeted for December 1st. Unlike previous releases, I'm proposing that instead of forking master int

[Qemu-devel] [Bug 824716] [NEW] linux-user broken for targets with TARGET_ABI32 (i.e. qemu-sparc32plus)

2011-08-11 Thread Matthias Braun
Public bug reported: I just debugged a problem I had with linux-user for qemu-sparc32plus. Turns out that sparc32plus is defined as a 64bit target with TARGET_ABI32 set. This correctly leads to abi_ulong (and others) being defined as uint32_t. However most of the code (in syscall.c) uses tswapl fo

  1   2   >