Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 1:03 PM, Aneesh Kumar K.V wrote: > On Thu, 4 Aug 2011 12:47:42 +0100, Stefan Hajnoczi wrote: >> On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V >> wrote: >> > On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi >> > wrote: >> >> On Thu, Aug 4, 2011 at 11:06 AM, Harsh Pr

[Qemu-devel] [PATCH v3 07/39] cirrus: simplify vga window mmio access functions

2011-08-04 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 79 +++--- 1 files changed, 11 insertions(+), 68 deletions(-)

[Qemu-devel] [PATCH v3 14/39] ac97: convert to memory API

2011-08-04 Thread Avi Kivity
fixes BAR sizing as well. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ac97.c | 88 +++- 1 files changed, 51 insertions(+), 37 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 0b59896..bcddaa6 100644 --- a/hw/ac9

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Paolo Bonzini
On 08/04/2011 02:59 PM, Kevin Wolf wrote: > > I have. If we are changing a protocol in an incompatible version, we > can remove a lot of warts that current descriptions have. Not that > Paolo protocol is bad, but if we are going to do some change, adding > things like size, removing previou

[Qemu-devel] [PATCH v3 36/39] pci: remove pci_register_bar()

2011-08-04 Thread Avi Kivity
Superceded by pci_register_bar_region(). The implementations are folded together. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c | 42 +- hw/pci.h |3 --- 2 files changed, 17 insertions(+), 28 deletions(-) diff --git a/hw/pc

[Qemu-devel] [PATCH v3 25/39] ne2000: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ne2000-isa.c | 14 +++--- hw/ne2000.c | 77 +- hw/ne2000.h |8 + 3 files changed, 59 insertions(+), 40 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne200

[Qemu-devel] [PATCH v3 38/39] pci: rename pci_register_bar_region() to pci_register_bar()

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ac97.c |4 ++-- hw/cirrus_vga.c |5 ++--- hw/e1000.c|5 ++--- hw/eepro100.c |7 +++ hw/es1370.c |2 +- hw/ide/cmd646.c | 14 +- hw/ide/ich.c |2 +- hw/ide/

[Qemu-devel] [PATCH v3 05/39] cirrus: simplify mmio BAR access functions

2011-08-04 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 78 +- 1 files changed, 8 insertions(+), 70 deletions(-) d

[Qemu-devel] [PATCH v3 16/39] eepro100: convert to memory API

2011-08-04 Thread Avi Kivity
Note: the existing code aliases the flash BAR into the MMIO bar. This is probably a bug. This patch does not correct the problem. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/eepro100.c | 182 - 1 files changed, 37 in

[Qemu-devel] [PATCH v3 10/39] Integrate I/O memory regions into qemu

2011-08-04 Thread Avi Kivity
get_system_io() returns the root I/O memory region. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- exec-memory.h |2 ++ exec.c| 10 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/exec-memory.h b/exec-memory.h index c439aba..999fd69 100644

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-04 Thread Amit Shah
(Adding Gerd to cc) On (Thu) 04 Aug 2011 [08:11:23], Anthony Liguori wrote: > On 08/04/2011 01:45 AM, Amit Shah wrote: > >On (Mon) 01 Aug 2011 [09:22:58], Anthony Liguori wrote: > >>The char layer has been growing some nasty warts for some time now as we > >>ask it > >>to do things it was never i

[Qemu-devel] [PATCH v3 28/39] isa-mmio: concert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/isa.h |2 ++ hw/isa_mmio.c | 30 +++--- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index d2b6126..f1f2181 100644 --- a/hw/isa.h +++ b/hw/isa.h @@ -4,6 +4,7

[Qemu-devel] [PATCH v3 22/39] intel-hda: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/intel-hda.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 5a2bc3a..1e4c71e 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -177

[Qemu-devel] [PATCH v3 23/39] lsi53c895a: convert to memory API

2011-08-04 Thread Avi Kivity
An optimization that fast-pathed DMA reads from the SCRIPTS memory was removed int the process. Likely it breaks with iommus anyway. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/lsi53c895a.c | 258 --- 1 files changed, 56

[Qemu-devel] [PATCH v3 13/39] rtl8139: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/rtl8139.c | 72 ++--- 1 files changed, 38 insertions(+), 34 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 5214b8c..dfbab90 100644 --- a/hw/rtl8139.c +++ b/hw/rtl81

[Qemu-devel] [PATCH v3 26/39] pcnet: convert to memory API

2011-08-04 Thread Avi Kivity
Also related chips. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/lance.c | 31 ++- hw/pcnet-pci.c | 74 +-- hw/pcnet.h |4 ++- 3 files changed, 61 insertions(+), 48 deletions(-) diff --gi

Re: [Qemu-devel] [BUG] Qcow2 corruption on snapshot revert

2011-08-04 Thread Kevin Wolf
Am 04.08.2011 16:20, schrieb Philipp Hahn: > Hello, > > it seems like I have discovered a bug in qemu-0.14.1 which corrupts Qcow2 > image files when using internal snapshots. > I tied this both on an amd64 host running our Debian bases UCS distribution > (using pure qemu-kvm_0.14 and pure qemu-k

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-08-04 Thread Luiz Capitulino
On Mon, 01 Aug 2011 08:53:28 -0500 Anthony Liguori wrote: > On 08/01/2011 02:54 AM, Christoph Hellwig wrote: > > On Sun, Jul 31, 2011 at 07:15:21PM -0500, Anthony Liguori wrote: > >> I think we've set the bar too low historically for introducing new > >> interfaces. I think Avi's new memory API

[Qemu-devel] [PATCH v3 39/39] pci: remove support for pre memory API BARs

2011-08-04 Thread Avi Kivity
Not used anymore. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c | 33 ++--- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6ed08ae..e6a3e56 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -848,18 +848,7 @@

[Qemu-devel] [PATCH v3 19/39] ivshmem: convert to memory API

2011-08-04 Thread Avi Kivity
excluding msix. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ivshmem.c | 148 -- 1 files changed, 50 insertions(+), 98 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 3055dd2..f80e7b6 100644 --- a/hw/ivshme

[Qemu-devel] [PATCH v3 21/39] ahci: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ide/ahci.c | 31 +-- hw/ide/ahci.h |2 +- hw/ide/ich.c |3 +-- 3 files changed, 15 insertions(+), 21 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1f008a3..e207ca0 100644 --- a

[Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-04 Thread Avi Kivity
From: "Michael S. Tsirkin" We originally did get config on map, so that following write accesses are done on an updated config. New memory API doesn't give us a callback on map, and arguably, devices don't know when cpu really can access there. So updating on init seems cleaner. Signed-off-by: M

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Paolo Bonzini
On 08/04/2011 04:30 PM, Anthony Liguori wrote: Force the subsection to be sent and increment the version number. That works if you want the smallest patch that fixes the bug. It doesn't if you want something that is useful, too. Paolo

[Qemu-devel] [PATCH 04/16] move QEMUSGList typedef

2011-08-04 Thread Gerd Hoffmann
Move the QEMUSGList typedef to qemu-common so it can easily be used. The actual struct definition stays in dma.h. Signed-off-by: Gerd Hoffmann --- dma.h |4 ++-- qemu-common.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dma.h b/dma.h index 3d8324b..a6db5b

[Qemu-devel] [PATCH 02/16] Add iov_hexdump()

2011-08-04 Thread Gerd Hoffmann
Useful for debugging purposes. Signed-off-by: Gerd Hoffmann --- iov.c | 31 +++ iov.h |2 ++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/iov.c b/iov.c index 1e02791..60553c7 100644 --- a/iov.c +++ b/iov.c @@ -73,3 +73,34 @@ size_t iov_size(co

[Qemu-devel] [PULL] usb patch queue: iovecs, hid split, misc fixes

2011-08-04 Thread Gerd Hoffmann
Hi, Major changes in the USB patch queue: * The USBPacket payload is represented as iovec instead of a linear buffer. This allows to kill some copying and buffering. * The HID code is splitted into hw/hid.[ch], keeping only the usb interfaacing in hw/usb-hid.c. This allows easy reuse

[Qemu-devel] [PATCH 07/16] usb-host: iovec support

2011-08-04 Thread Gerd Hoffmann
Add full support for iovecs to usb-host. The code can split large transfers into smaller ones already, we are using this to also split requests at iovec borders. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 27 ++- 1 files changed, 18 insertions(+), 9 deletions(-) d

[Qemu-devel] [PATCH 06/16] usb-serial: iovec support

2011-08-04 Thread Gerd Hoffmann
Add full support for iovecs to usb-serial. Signed-off-by: Gerd Hoffmann --- hw/usb-serial.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/usb-serial.c b/hw/usb-serial.c index 09731da..bf2b775 100644 --- a/hw/usb-serial.c +++ b/hw/usb-seri

[Qemu-devel] [PATCH 08/16] usb-storage: iovec support

2011-08-04 Thread Gerd Hoffmann
Add full iovec support to usb-storage. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c | 107 ++--- 1 files changed, 49 insertions(+), 58 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 48e0b34..90e57fb 100644 --- a/hw/usb-msd.c +++

[Qemu-devel] [PATCH 12/16] usb-hid: add event callback

2011-08-04 Thread Gerd Hoffmann
Add callback for event notification, which allows to un-usbify more functions. Also split separate hid_* functions for reset and release. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c | 106 ++--- 1 files changed, 63 insertions(+), 43 deletio

[Qemu-devel] [PATCH 16/16] bluetooth: kill dummy usb device, use hid code directly.

2011-08-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/bt-hid.c | 62 -- 1 files changed, 22 insertions(+), 40 deletions(-) diff --git a/hw/bt-hid.c b/hw/bt-hid.c index a4204f9..5f1afe3 100644 --- a/hw/bt-hid.c +++ b/hw/bt-hid.c @@ -19,7 +19,9 @@ */ #i

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-08-04 Thread Stefan Hajnoczi
On Sat, Jul 30, 2011 at 1:39 AM, Anthony Liguori wrote: > On behalf of the entire QEMU team, I'm please to announce the release of > QEMU 0.15.0-rc1.  This is the second release candidate for the 0.15.0 > release. > > There are numerous ways you can help participate in the 0.15.0 release. >  There

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-08-04 Thread Lucas Meneghel Rodrigues
On 08/04/2011 12:17 PM, Stefan Hajnoczi wrote: On Sat, Jul 30, 2011 at 1:39 AM, Anthony Liguori wrote: On behalf of the entire QEMU team, I'm please to announce the release of QEMU 0.15.0-rc1. This is the second release candidate for the 0.15.0 release. There are numerous ways you can help pa

[Qemu-devel] [PATCH 11/16] usb-hid: create & use HIDState

2011-08-04 Thread Gerd Hoffmann
First step in separating out the HID emulation code from usb-hid, so it can be reused without creating a dummy usb device like bluetooth does. This creates a HIDState struct, moves the non-usbish fields from USBHIDStruct there. Renames non-usbish structs, defines and functions from usb* to hid*.

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-08-04 Thread Avi Kivity
On 08/04/2011 06:17 PM, Stefan Hajnoczi wrote: On Sat, Jul 30, 2011 at 1:39 AM, Anthony Liguori wrote: > On behalf of the entire QEMU team, I'm please to announce the release of > QEMU 0.15.0-rc1. This is the second release candidate for the 0.15.0 > release. > > There are numerous ways you

[Qemu-devel] [PATCH 14/16] usb-hid: split hid code to hw/hid.[ch]

2011-08-04 Thread Gerd Hoffmann
Almost pure code motion. Unstatic hid interface functions and add them to the header file. Some renames. Some code style cleanups. Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + hw/hid.c | 395 hw/hid.h | 54 +

[Qemu-devel] [PATCH 10/16] ehci: iovec support, remove buffer

2011-08-04 Thread Gerd Hoffmann
Map guest memory and pass on a direct pointer instead of copying the bits to a indirect buffer. EHCI transfer descriptors can reference multiple (physical guest) pages so we'll actually start seeing usb packets wich carry iovec with more than one element. Signed-off-by: Gerd Hoffmann --- hw/usb

[Qemu-devel] [PATCH 03/16] Add iov_clear()

2011-08-04 Thread Gerd Hoffmann
Fill the spefified area with zeros. Signed-off-by: Gerd Hoffmann --- iov.c | 23 +++ iov.h |2 ++ 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/iov.c b/iov.c index 60553c7..e7385c4 100644 --- a/iov.c +++ b/iov.c @@ -62,6 +62,29 @@ size_t iov_to_buf(con

[Qemu-devel] [PATCH 13/16] usb-hid: add hid_has_events()

2011-08-04 Thread Gerd Hoffmann
Add hid_has_events function, use it to figure whenever there are pending events instead of checking and updating USBHIDState->changed. Setting ->changed to 1 on init is removed, that should have absolutely no effect as the initial state of ->idle is 0 so we report hid state anyway until the guest

[Qemu-devel] [PATCH 01/16] re-activate usb-host for bsd

2011-08-04 Thread Gerd Hoffmann
A bunch of code was disabled via #if 0, for a quite long time (since Sept 2009). Surprisingly the code builds just fine when they are removed (tested on OpenBSD). /me wonders nevertheless whenever there are any users of those bits when this went unnoticed for almost two years ... Signed-off-by:

[Qemu-devel] [PATCH 09/16] uhci: remove buffer

2011-08-04 Thread Gerd Hoffmann
Map guest memory and pass on a direct pointer instead of copying the bits to a indirect buffer. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 20b829b..824e3a5 100644 --- a/

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-08-04 Thread Anthony Liguori
On 08/04/2011 10:25 AM, Avi Kivity wrote: On 08/04/2011 06:17 PM, Stefan Hajnoczi wrote: On Sat, Jul 30, 2011 at 1:39 AM, Anthony Liguori wrote: > On behalf of the entire QEMU team, I'm please to announce the release of > QEMU 0.15.0-rc1. This is the second release candidate for the 0.15.0 > rel

[Qemu-devel] [PATCH 05/16] usb: use iovecs in USBPacket

2011-08-04 Thread Gerd Hoffmann
Zap data pointer from USBPacket, add a QEMUIOVector instead. Add a bunch of helper functions to manage USBPacket data. Switch over users to the new interface. Note that USBPacket->len was used for two purposes: First to pass in the buffer size and second to return the number of transfered bytes o

[Qemu-devel] [PATCH 15/16] hid: move idle+protocol from usb-hid to hid too.

2011-08-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/hid.c |8 hw/hid.h |4 hw/usb-hid.c | 36 +--- 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/hw/hid.c b/hw/hid.c index 1893ae5..7b5ef5f 100644 --- a/hw/hid.c +++ b/hw/hid.c @@ -2

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-08-04 Thread Avi Kivity
On 08/04/2011 06:38 PM, Anthony Liguori wrote: I tested qemu-kvm-0.15.0-rc1 before releasing it, with my limited test set. I also run kvm-autotest through qemu before releases (albeit with a limited config file). That's great to hear, esp. as qemu-kvm is being wound down. -- error compil

Re: [Qemu-devel] [PATCH v2 00/45] Block layer cleanup & fixes

2011-08-04 Thread Avi Kivity
On 08/03/2011 04:07 PM, Markus Armbruster wrote: * Both master and the block branch are broken for me by Avi's memory API work (Avi reproduced, and claims to have a fix), so for testing I had to rebase the block branch on an older master cde1a700 plus my dependencies: some Xen work e3745

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Avi Kivity
On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end sends data by calling qemu_chr_write(). The back-end, typically created via -chardev, can also send and receive data. Oddly, it se

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-04 Thread rowa
Now it is possible to build qemu 0.15.0-rc1 with --disable-spice option on Ubuntu 10.10 „Maverick Meerkat“ . -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/816370 Title: compile error in QEMU 0.15.0

[Qemu-devel] -vga qxl

2011-08-04 Thread Rick Vernam
it seems that qxl is not working correctly with any of the 0.15 releases thus far. this includes qemu and qemu-kvm. when I start qemu like so: qemu-system-x86_64 -cpu host -enable-kvm -m 768 -usb -vga qxl -monitor stdio I get a black screen. when I start with -vga std: qemu-system-x86_64 -cpu h

Re: [Qemu-devel] [PATCH 03/12] char: introduce tx queue to enable Unix style flow control

2011-08-04 Thread Avi Kivity
On 08/01/2011 05:23 PM, Anthony Liguori wrote: The char layer tries very hard to avoid using an intermediate buffer. The implication of this is that when the backend does a write(), the data for that write must be immediately passed to the front end. Flow control is needed to handle the likely

[Qemu-devel] qemu-0.15.0-rc1 compile failure

2011-08-04 Thread Rick Vernam
./configure --disable-vnc make ... monitor.o: In function `add_graphics_client': /home/rick/qemu/src/qemu-0.15.0-rc1/monitor.c:1205: undefined reference to `vnc_display_add_client'

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Daniel P. Berrange
On Thu, Aug 04, 2011 at 11:03:10AM -0500, Rick Vernam wrote: > it seems that qxl is not working correctly with any of the 0.15 releases thus > far. this includes qemu and qemu-kvm. > > when I start qemu like so: > qemu-system-x86_64 -cpu host -enable-kvm -m 768 -usb -vga qxl -monitor stdio > I g

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:00 AM, Avi Kivity wrote: On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end sends data by calling qemu_chr_write(). The back-end, typically created via -chardev, can

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Avi Kivity
On 08/04/2011 07:11 PM, Anthony Liguori wrote: On 08/04/2011 11:00 AM, Avi Kivity wrote: On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end sends data by calling qemu_chr_write(). T

[Qemu-devel] [PATCH 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Kevin Wolf
When loading an internal snapshot whose L1 table is smaller than the current L1 table, the size of the current L1 would be shrunk to the snapshot's L1 size in memory, but not on disk. This lead to incorrect refcount updates and eventuelly to image corruption. Instead of writing the new L1 size to

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Avi Kivity
On 08/04/2011 07:14 PM, Avi Kivity wrote: Yes, I'm just talking about the function names, not about the implementation. qemu_chr_fe_write(chr,...) -> qemu_chr_write(chr, ...) qemu_chr_be_write(chr, ...) -> qemu_chr_write(&chr->backend, ...) And, if you want an internal pipe: QemuPi

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:14 AM, Avi Kivity wrote: On 08/04/2011 07:11 PM, Anthony Liguori wrote: On 08/04/2011 11:00 AM, Avi Kivity wrote: On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end

[Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Kevin Wolf
When loading an internal snapshot whose L1 table is smaller than the current L1 table, the size of the current L1 would be shrunk to the snapshot's L1 size in memory, but not on disk. This lead to incorrect refcount updates and eventuelly to image corruption. Instead of writing the new L1 size to

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:17 AM, Avi Kivity wrote: On 08/04/2011 07:14 PM, Avi Kivity wrote: Yes, I'm just talking about the function names, not about the implementation. qemu_chr_fe_write(chr,...) -> qemu_chr_write(chr, ...) qemu_chr_be_write(chr, ...) -> qemu_chr_write(&chr->backend, ...) And, if

Re: [Qemu-devel] [PATCH 03/12] char: introduce tx queue to enable Unix style flow control

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:04 AM, Avi Kivity wrote: On 08/01/2011 05:23 PM, Anthony Liguori wrote: The char layer tries very hard to avoid using an intermediate buffer. The implication of this is that when the backend does a write(), the data for that write must be immediately passed to the front end. Fl

[Qemu-devel] [PATCH V2] xen-mapcache: Fix rlimit set size.

2011-08-04 Thread Anthony PERARD
Previously, the address space soft limit was set mcache_max_size. So, before the mcache_max_size was reached by the mapcache, QEMU was killed for overuse of the virtual address space. This patch fix that by setting the soft limit the maximum than can have QEMU. So the soft and hard limit are alway

[Qemu-devel] [PATCH 00/10] SCSI scatter/gather support

2011-08-04 Thread Paolo Bonzini
Hi, this is the version of SCSI scatter/gather based on the existing DMA helpers infrastructure. The infrastructure required a little update because I need to know the residual amount of data upon short transfers. To this end, my choice was to make QEMUSGList mutable and track the current positi

[Qemu-devel] [PATCH 10/10] scsi-disk: enable scatter/gather functionality

2011-08-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 52 +--- 1 files changed, 41 insertions(+), 11 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 509407f..81117d2 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -37,6 +37,7 @@ d

[Qemu-devel] [PATCH 11/11] sample pvscsi driver with s/g support

2011-08-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |1 + default-configs/i386-softmmu.mak |1 + default-configs/pci.mak|1 + default-configs/x86_64-softmmu.mak |1 + hw/pci.h |1 + hw/vmw_pvscsi.c| 9

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Rick Vernam
On Thursday 04 August 2011 11:09:30 Daniel P. Berrange wrote: > On Thu, Aug 04, 2011 at 11:03:10AM -0500, Rick Vernam wrote: > > it seems that qxl is not working correctly with any of the 0.15 releases > > thus far. this includes qemu and qemu-kvm. > > > > when I start qemu like so: > > qemu-syst

Re: [Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Philipp Hahn
Hello, On Thursday 04 August 2011 18:24:59 Kevin Wolf wrote: > When loading an internal snapshot whose L1 table is smaller than the > current L1 table, the size of the current L1 would be shrunk to the > snapshot's L1 size in memory, but not on disk. This lead to incorrect > refcount updates and e

[Qemu-devel] [PATCH] Fix DEBUG_* compilation of qcow2.

2011-08-04 Thread Philipp Hahn
By introducing BlockDriverState compiling qcow2 with DEBUG_ALLOC and DEBUG_EXT defined got broken. Define a BdrvCheckResult structure locally which is now needed as the second argument. Also fix qcow2_read_extensions() needing BDRVQcowState. Signed-off-by: Philipp Hahn --- block/qcow2-snapshot.

[Qemu-devel] [PATCH 01/10] dma-helpers: allow including from target-independent code

2011-08-04 Thread Paolo Bonzini
Target-independent code cannot construct sglists, but it can take them from the outside as a black box. Allow this. Signed-off-by: Paolo Bonzini --- dma.h | 12 qemu-common.h |1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dma.h b/dma.h index 3d83

[Qemu-devel] [PATCH 07/10] scsi: add scatter/gather functionality

2011-08-04 Thread Paolo Bonzini
Scatter/gather functionality uses the newly added DMA helpers. The device can choose between doing DMA itself, or calling scsi_req_data as usual, which will use the newly added DMA helpers to map the destination area(s) piecewise and copy to/from them. Signed-off-by: Paolo Bonzini --- hw/esp.c

[Qemu-devel] [PATCH 06/10] scsi: pass residual amount to command_complete

2011-08-04 Thread Paolo Bonzini
With the upcoming sglist support, HBAs will not see any transfer_data call and will not have a way to detect short transfers. So pass the residual amount of data upon command completion. Signed-off-by: Paolo Bonzini --- hw/esp.c |3 ++- hw/lsi53c895a.c |2 +- hw/scsi-bus.c|

[Qemu-devel] [PATCH 02/10] dma-helpers: track position in the QEMUSGList

2011-08-04 Thread Paolo Bonzini
The DMA helpers infrastructures cannot at the moment track how many bytes have been actually written, so the users cannot detect short transfers. Adding an accessor to the DMAAIOCB cannot fix this however, because the callback may not have access at all to the AIOCB if the transfer is completed syn

[Qemu-devel] [PATCH 09/10] scsi-disk: lazily allocate bounce buffer

2011-08-04 Thread Paolo Bonzini
It will not be needed for reads and writes if the HBA provides a sglist. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 37dd9d6..509407f 100644 --- a/

[Qemu-devel] [PATCH 04/10] dma-helpers: prepare for adding dma_buf_* functions

2011-08-04 Thread Paolo Bonzini
Store in the AIOCB which callback function we are using, and abstract the process of starting DMA. Signed-off-by: Paolo Bonzini --- dma-helpers.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index d716524..4469ce2 10

[Qemu-devel] [PATCH 03/10] dma-helpers: rewrite completion/cancellation

2011-08-04 Thread Paolo Bonzini
This fixes various problems with completion/cancellation: * If DMA encounters a bounce buffer conflict, and the DMA operation is canceled before the bottom half fires, bad things happen. * memory is not unmapped after cancellation, again causing problems when doing DMA to I/O areas * cancellatio

Re: [Qemu-devel] [PATCH v2 20/45] ide: Provide IDEDeviceInfo method exit()

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:07:59 +0200 Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > hw/ide/internal.h |1 + > hw/ide/qdev.c | 12 > 2 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/hw/ide/internal.h b/hw/ide/internal.h > index 3e56

[Qemu-devel] read-only IDE drives in qemu

2011-08-04 Thread Frédéric Dreier
Hi, We are updating some machines in our server farm to Ubuntu natty (KVM / Opennebula cluster). Since then we used to have some VM with shared read-only IDE disks to mirror software repositories through several isolated networks (one-way data diode). The updated qemu does not allow it. It failed

[Qemu-devel] [PATCH 08/10] scsi-disk: commonize iovec creation between reads and writes

2011-08-04 Thread Paolo Bonzini
Also, consistently use qiov.size instead of iov.iov_len. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 40 ++-- 1 files changed, 18 insertions(+), 22 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 2cb6ff3..37dd9d6 100644 --- a/hw/scsi-d

Re: [Qemu-devel] [PATCH v2 35/45] block: Clean up remaining users of "removable"

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:14 +0200 Markus Armbruster wrote: > BlockDriverState member removable is a confused mess. It is true when > an ide-cd, scsi-cd or floppy qdev is attached, or when the > BlockDriverState was created with -drive if={floppy,sd} or -drive > if={ide,scsi,xen,none},media=cdro

[Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-04 Thread Paolo Bonzini
These helpers do a full transfer from an in-memory buffer to target memory, with full support for MMIO areas. It will be used to store the reply of an emulated command into a QEMUSGList provided by the adapter. Signed-off-by: Paolo Bonzini --- cutils.c |8 +++--- dma-helpers.c | 63 +

Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:16 +0200 Markus Armbruster wrote: > Need to ask the device, so this requires new BlockDevOps member > is_medium_ejected(). > > Signed-off-by: Markus Armbruster Looks good to me. > --- > block.c | 17 +++-- > block.h |6 ++ > hw/

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:19 +0200 Markus Armbruster wrote: > Device models should be able to use it without an unclean include of > block_int.h. Nitpick: I'd do the prototype move after patch 38/45 and include the block_int.h removal in the patch you're trimming block_int.h includes. > > Sign

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Gerd Hoffmann
Hi, I recently had black screen problems with QXL in 0.14.x that turned out to actually be a Seabios bug due to the default 64MB vram QXL has. It is a seabios issue indeed. I suspect this would hit 0.15.x builds too. If this is what you're hitting, then reducing the vram to 32MB is a tempo

Re: [Qemu-devel] read-only IDE drives in qemu

2011-08-04 Thread Markus Armbruster
Frédéric Dreier writes: > Hi, > > We are updating some machines in our server farm to Ubuntu natty (KVM / > Opennebula cluster). Since then we used to have some VM with shared > read-only IDE disks to mirror software repositories through several isolated > networks (one-way data diode). > > The u

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-08-04 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 3 Aug 2011 15:08:19 +0200 > Markus Armbruster wrote: > >> Device models should be able to use it without an unclean include of >> block_int.h. > > Nitpick: I'd do the prototype move after patch 38/45 and include the > block_int.h removal in the patch you're tri

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-08-04 Thread Luiz Capitulino
On Thu, 04 Aug 2011 20:22:15 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 3 Aug 2011 15:08:19 +0200 > > Markus Armbruster wrote: > > > >> Device models should be able to use it without an unclean include of > >> block_int.h. > > > > Nitpick: I'd do the prototype move

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Rick Vernam
On Thursday 04 August 2011 13:15:35 Gerd Hoffmann wrote: >Hi, > > > I recently had black screen problems with QXL in 0.14.x that turned out > > to actually be a Seabios bug due to the default 64MB vram QXL has. > > It is a seabios issue indeed. > > > I suspect > > this would hit 0.15.x build

Re: [Qemu-devel] [PATCH v3 2/6] Add copy and constant propagation.

2011-08-04 Thread Blue Swirl
On Wed, Aug 3, 2011 at 9:03 PM, Stefan Weil wrote: > Am 03.08.2011 22:56, schrieb Stefan Weil: >> >> Am 03.08.2011 22:20, schrieb Blue Swirl: >>> >>> On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil wrote: Am 07.07.2011 14:37, schrieb Kirill Batuzov: > > Make tcg_constant_folding do

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Aneesh Kumar K.V
On Thu, 4 Aug 2011 15:31:08 +0100, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 1:03 PM, Aneesh Kumar K.V > wrote: > > On Thu, 4 Aug 2011 12:47:42 +0100, Stefan Hajnoczi > > wrote: > >> On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V > >> wrote: > >> > On Thu, 4 Aug 2011 11:21:05 +0100, S

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-04 Thread David Ahern
On 08/03/2011 09:00 AM, Michael S. Tsirkin wrote: > On Wed, Aug 03, 2011 at 07:55:47AM -0600, David Ahern wrote: >> Tested-by: David Ahern >> >> David > > Applied, thanks very much. > I assume this will make 0.15 since it is a regression? haven't seen the patch applied to that branch yet. Da

[Qemu-devel] Time to cut a new release?

2011-08-04 Thread Gerd Hoffmann
Hi, A bunch of new stuff has been added to master since the last version, time to release a new one? Especially I'd like to see qemu get a seabios update, and anthony prefers a release instead of a git snapshot for that. cheers, Gerd

Re: [Qemu-devel] [PATCH 01/16] re-activate usb-host for bsd

2011-08-04 Thread Blue Swirl
On Thu, Aug 4, 2011 at 3:10 PM, Gerd Hoffmann wrote: > A bunch of code was disabled via #if 0, for a quite long time (since > Sept 2009).  Surprisingly the code builds just fine when they are > removed (tested on OpenBSD).  /me wonders nevertheless whenever there > are any users of those bits when

Re: [Qemu-devel] [PATCH 01/16] re-activate usb-host for bsd

2011-08-04 Thread Gerd Hoffmann
On 08/04/11 20:50, Blue Swirl wrote: On Thu, Aug 4, 2011 at 3:10 PM, Gerd Hoffmann wrote: A bunch of code was disabled via #if 0, for a quite long time (since Sept 2009). Surprisingly the code builds just fine when they are removed (tested on OpenBSD). /me wonders nevertheless whenever there

[Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2011-08-04 Thread Rick Vernam
sorry, the output from qemu-kvm which seems to indicate an error is qemu-system-x86_64: virtio-serial-bus: Unexpected port id 3125770964 for device virtio-serial0.0 or sometimes qemu-system-x86_64: virtio-serial-bus: Unexpected port id 47936 for device virtio-serial0.0 -- You received this bug

[Qemu-devel] [Bug 821078] [NEW] virtio-serial-bus: Unexpected port id

2011-08-04 Thread Rick Vernam
Public bug reported: With qemu-kvm-0.15.0-rc1 virtio-serial-bus reports an error, and windows vdagent can not start. qemu-0.15.0-rc1 behaves as expected, ie vdagent runs in the guest, mouse passes seamlessly between spicec and host and copy/paste works between guest and host. qemu-kvm has been

Re: [Qemu-devel] Time to cut a new release?

2011-08-04 Thread Anthony Liguori
On 08/04/2011 01:49 PM, Gerd Hoffmann wrote: Hi, A bunch of new stuff has been added to master since the last version, time to release a new one? Especially I'd like to see qemu get a seabios update, and anthony prefers a release instead of a git snapshot for that. What's left in order to enab

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2011 at 07:00:38PM +1000, David Gibson wrote: > On Wed, Aug 03, 2011 at 04:28:33PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 02, 2011 at 12:15:22AM +1000, David Gibson wrote: > > > On Mon, Aug 01, 2011 at 05:03:18PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Aug 01, 201

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2011 at 12:48:49PM -0600, David Ahern wrote: > > > On 08/03/2011 09:00 AM, Michael S. Tsirkin wrote: > > On Wed, Aug 03, 2011 at 07:55:47AM -0600, David Ahern wrote: > >> Tested-by: David Ahern > >> > >> David > > > > Applied, thanks very much. > > > > I assume this will make

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-04 Thread David Ahern
On 08/04/2011 01:17 PM, Michael S. Tsirkin wrote: > On Thu, Aug 04, 2011 at 12:48:49PM -0600, David Ahern wrote: >> >> >> On 08/03/2011 09:00 AM, Michael S. Tsirkin wrote: >>> On Wed, Aug 03, 2011 at 07:55:47AM -0600, David Ahern wrote: Tested-by: David Ahern David >>> >>> Applied

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 18:51:44 +0400 Michael Tokarev wrote: > If we do, it results in double monitor_resume() (second being called > from migrate_fd_cleanup() anyway) and monitor suspend count becoming > negative. Are you hitting an specific issue or did you find this by code inspection? IIRC, I

Re: [Qemu-devel] [PATCH v3 2/6] Add copy and constant propagation.

2011-08-04 Thread Blue Swirl
On Thu, Aug 4, 2011 at 6:42 PM, Blue Swirl wrote: > On Wed, Aug 3, 2011 at 9:03 PM, Stefan Weil wrote: >> Am 03.08.2011 22:56, schrieb Stefan Weil: >>> >>> Am 03.08.2011 22:20, schrieb Blue Swirl: On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil wrote: > > Am 07.07.2011 14:37, schri

<    1   2   3   >